[Libreoffice-commits] core.git: 2 commits - bridges/Library_cpp_uno.mk bridges/source

2018-03-11 Thread jan Iversen 
 bridges/Library_cpp_uno.mk   |   18 -
 bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx  |2 
 bridges/source/cpp_uno/gcc3_ios/generate-snippets.pl |   55 -
 bridges/source/cpp_uno/gcc3_ios/ios64_helper.s   |  205 ++-
 4 files changed, 206 insertions(+), 74 deletions(-)

New commits:
commit 02f6aa7355d77842caa0416217e0a572144467c3
Author: jan Iversen 
Date:   Sun Mar 11 09:19:39 2018 +0100

iOS, removed perl script in bridges

The perl script just generated static asm code, this
code is now included directly in ios64_helper.s

Change-Id: I3ebc6f85865287e1a1d11f82be72fc2407bcb40f

diff --git a/bridges/Library_cpp_uno.mk b/bridges/Library_cpp_uno.mk
index 4c6d7ec95046..902b735b3d65 100644
--- a/bridges/Library_cpp_uno.mk
+++ b/bridges/Library_cpp_uno.mk
@@ -26,24 +26,6 @@ bridges_SELECTED_BRIDGE := gcc3_ios
 bridge_noopt_objects := cpp2uno except uno2cpp
 bridge_asm_objects := ios64_helper
 
-#HACK
-$(eval $(call gb_Library_set_include,$(gb_CPPU_ENV)_uno,\
-$$(INCLUDE) \
--I $(call gb_CustomTarget_get_workdir,bridges/source/cpp_uno/gcc3_ios) \
-))
-
-$(SRCDIR)/bridges/source/cpp_uno/gcc3_ios/ios64_helper.s: \
-   $(call 
gb_CustomTarget_get_workdir,bridges/source/cpp_uno/gcc3_ios)/codesnippets.S
-
-$(call 
gb_CustomTarget_get_workdir,bridges/source/cpp_uno/gcc3_ios)/codesnippets.S: \
-   $(SRCDIR)/bridges/source/cpp_uno/gcc3_ios/generate-snippets.pl \
-| $(call 
gb_CustomTarget_get_workdir,bridges/source/cpp_uno/gcc3_ios)/.dir
-   $(PERL) $< > $@
-
-$(call gb_Library_get_clean_target,$(gb_CPPU_ENV)_uno) :
-   rm -f 
$(WORKDIR)/CustomTarget/bridges/source/cpp_uno/gcc3_ios/codesnippets.S
-
-
 else ifeq ($(CPUNAME),AARCH64)
 
 ifneq ($(filter ANDROID DRAGONFLY FREEBSD LINUX NETBSD OPENBSD,$(OS)),)
diff --git a/bridges/source/cpp_uno/gcc3_ios/generate-snippets.pl 
b/bridges/source/cpp_uno/gcc3_ios/generate-snippets.pl
deleted file mode 100755
index 3a3b0a3fbb1a..
--- a/bridges/source/cpp_uno/gcc3_ios/generate-snippets.pl
+++ /dev/null
@@ -1,55 +0,0 @@
-#!/usr/bin/perl -w # -*- tab-width: 4; indent-tabs-mode: nil; 
cperl-indent-level: 4 -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-my $nFunIndexes = 8;
-my $nVtableOffsets = 4;
-
-sub gen_arm ($$)
-{
-my ($funIndex, $vtableOffset) = @_;
-printf ("codeSnippet_%08x_%d:\n", $funIndex, $vtableOffset);
-printf ("adr x15, .+8\n");
-printf ("b _privateSnippetExecutor\n");
-printf (".long %#08x\n", $funIndex);
-printf (".long %d\n", $vtableOffset);
-}
-
-printf (".text\n");
-printf ("\n");
-printf (".align 4\n");
-printf ("\n");
-
-foreach my $funIndex (0 .. $nFunIndexes-1)
-{
-   foreach my $vtableOffset (0 .. $nVtableOffsets-1)
-   {
-   gen_arm ($funIndex, $vtableOffset);
-   }
-}
-
-printf (".globl _nFunIndexes\n");
-printf ("_nFunIndexes:\n");
-printf (".long %d\n", $nFunIndexes);
-
-printf (".globl _nVtableOffsets\n");
-printf ("_nVtableOffsets:\n");
-printf (".long %d\n", $nVtableOffsets);
-
-printf (".globl _codeSnippets\n");
-printf ("_codeSnippets:\n");
-
-foreach my $funIndex (0 .. $nFunIndexes-1)
-{
-foreach my $vtableOffset (0 .. $nVtableOffsets-1)
-{
-printf (".long codeSnippet_%08x_%d - _codeSnippets\n", $funIndex, 
$vtableOffset);
-}
-}
-
-# vim:set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/bridges/source/cpp_uno/gcc3_ios/ios64_helper.s 
b/bridges/source/cpp_uno/gcc3_ios/ios64_helper.s
index 51e4d160dafe..6e6e8c74b347 100644
--- a/bridges/source/cpp_uno/gcc3_ios/ios64_helper.s
+++ b/bridges/source/cpp_uno/gcc3_ios/ios64_helper.s
@@ -16,8 +16,211 @@
 //   except in compliance with the License. You may obtain a copy of
 //   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 //
+.text
+.align 4
+
+codeSnippet__0:
+adr x15, .+8
+b _privateSnippetExecutor
+.long 
+.long 0
+codeSnippet__1:
+adr x15, .+8
+b _privateSnippetExecutor
+.long 
+.long 1
+codeSnippet__2:
+adr x15, .+8
+b _privateSnippetExecutor
+.long 
+.long 2
+codeSnippet__3:
+adr x15, .+8
+b _privateSnippetExecutor
+.long 
+.long 3
+codeSnippet_0001_0:
+adr x15, .+8
+b _privateSnippetExecutor
+.long 0x01
+.long 0
+codeSnippet_0001_1:
+adr x15, .+8
+b _privateSnippetExecutor
+.long 0x01
+.long 1
+codeSnippet_0001_2:
+adr x15, .+8
+b _privateSnippetExecutor
+.long 0x01
+.long 2
+codeSnippet_0001_3:
+adr x15, .+8
+b _privateSnippetExecutor
+.long 0x01
+.long 3
+codeSnippet_0002_0:
+adr x15, .+8
+b _privateSnippetExec

Re: Mac build error.

2018-03-11 Thread Jan Iversen 
> The 'g' script in turn is called in 'Makefile'/'Makefile.in’.

Thanks, I got my problem identified.

I work on 2 branches in parallel (iOS and master), so I use “git worktree” in 
order not to have 2 clones (a lot less diskspace).

I know I could switch branches with the help of “git stash”, but it  does not 
allow me to work on one branch while the other branch does its rather lengthy 
compile.

However the worktree version, does not have a .git directory but a .git file 
pointing the clone.

rgds
Jan I.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

2018-03-11 Thread andreas kainz 
 icon-themes/colibre/cmd/lc_save.png  |binary
 icon-themes/colibre/cmd/sc_save.png  |binary
 icon-themes/colibre/res/notebookbar.png  |binary
 icon-themes/colibre/res/recentdoc_remove.png |binary
 icon-themes/colibre/res/recentdoc_remove_highlighted.png |binary
 icon-themes/colibre/res/savemodified_large.png   |binary
 icon-themes/colibre/res/savemodified_small.png   |binary
 icon-themes/colibre/res/sc10223.png  |binary
 icon-themes/colibre/res/sc10224.png  |binary
 icon-themes/colibre/res/sx03139.png  |binary
 icon-themes/colibre/res/sx03248.png  |binary
 icon-themes/colibre/res/sx03252.png  |binary
 icon-themes/colibre/res/sx03253.png  |binary
 icon-themes/colibre/res/sx03254.png  |binary
 icon-themes/colibre/res/sx03255.png  |binary
 icon-themes/colibre_svg/cmd/lc_save.svg  |2 +-
 icon-themes/colibre_svg/cmd/sc_save.svg  |3 ++-
 icon-themes/colibre_svg/res/notebookbar.svg  |1 +
 icon-themes/colibre_svg/res/recentdoc_remove.svg |1 +
 icon-themes/colibre_svg/res/recentdoc_remove_highlighted.svg |1 +
 icon-themes/colibre_svg/res/savemodified_large.svg   |2 +-
 icon-themes/colibre_svg/res/savemodified_small.svg   |5 +
 icon-themes/colibre_svg/res/sc10223.svg  |1 +
 icon-themes/colibre_svg/res/sc10224.svg  |1 +
 icon-themes/colibre_svg/res/sx03139.svg  |1 +
 icon-themes/colibre_svg/res/sx03248.svg  |1 +
 icon-themes/colibre_svg/res/sx03252.svg  |1 +
 icon-themes/colibre_svg/res/sx03253.svg  |1 +
 icon-themes/colibre_svg/res/sx03254.svg  |1 +
 icon-themes/colibre_svg/res/sx03255.svg  |1 +
 30 files changed, 20 insertions(+), 3 deletions(-)

New commits:
commit 0e73fd8218cfc009edfda02e7240b9d0907916d9
Author: andreas kainz 
Date:   Sun Mar 11 09:38:53 2018 +0100

Colibre icons: add res sx and other res icons

Change-Id: I6dd8c044fe7e68b9edc12be419d5cf41c81798ea
Reviewed-on: https://gerrit.libreoffice.org/51072
Reviewed-by: andreas_kainz 
Tested-by: andreas_kainz 

diff --git a/icon-themes/colibre/cmd/lc_save.png 
b/icon-themes/colibre/cmd/lc_save.png
index d0306ad6011f..fd439188289b 100644
Binary files a/icon-themes/colibre/cmd/lc_save.png and 
b/icon-themes/colibre/cmd/lc_save.png differ
diff --git a/icon-themes/colibre/cmd/sc_save.png 
b/icon-themes/colibre/cmd/sc_save.png
index 013ad2989893..f35a30b21001 100644
Binary files a/icon-themes/colibre/cmd/sc_save.png and 
b/icon-themes/colibre/cmd/sc_save.png differ
diff --git a/icon-themes/colibre/res/notebookbar.png 
b/icon-themes/colibre/res/notebookbar.png
new file mode 100644
index ..4ba3e06de0b6
Binary files /dev/null and b/icon-themes/colibre/res/notebookbar.png differ
diff --git a/icon-themes/colibre/res/recentdoc_remove.png 
b/icon-themes/colibre/res/recentdoc_remove.png
new file mode 100644
index ..22d26174b4e7
Binary files /dev/null and b/icon-themes/colibre/res/recentdoc_remove.png differ
diff --git a/icon-themes/colibre/res/recentdoc_remove_highlighted.png 
b/icon-themes/colibre/res/recentdoc_remove_highlighted.png
new file mode 100644
index ..a12dd5d372ed
Binary files /dev/null and 
b/icon-themes/colibre/res/recentdoc_remove_highlighted.png differ
diff --git a/icon-themes/colibre/res/savemodified_large.png 
b/icon-themes/colibre/res/savemodified_large.png
index fd439188289b..b6cc6a9675fc 100644
Binary files a/icon-themes/colibre/res/savemodified_large.png and 
b/icon-themes/colibre/res/savemodified_large.png differ
diff --git a/icon-themes/colibre/res/savemodified_small.png 
b/icon-themes/colibre/res/savemodified_small.png
new file mode 100644
index ..ed3ff8a69469
Binary files /dev/null and b/icon-themes/colibre/res/savemodified_small.png 
differ
diff --git a/icon-themes/colibre/res/sc10223.png 
b/icon-themes/colibre/res/sc10223.png
new file mode 100644
index ..97c6bf13f7b2
Binary files /dev/null and b/icon-themes/colibre/res/sc10223.png differ
diff --git a/icon-themes/colibre/res/sc10224.png 
b/icon-themes/colibre/res/sc10224.png
new file mode 100644
index ..4c59fadf0b09
Binary files /dev/null and b/icon-themes/colibre/res/sc10224.png differ
diff --git a/icon-themes/colibre/res/sx03139.png 
b/icon-themes/colibre/res/sx03139.png
new file mode 100644
index ..481ee89daba2
Binary files /dev/null and b/icon-themes/colibre/res/sx03139.png differ
diff --git a/icon-themes/colibre/res/sx03248.png 
b/icon-themes/colibre/res/sx03248.png
new file mode 10

Let failed Jenkins builds set Verified: -1 in Gerrit?

2018-03-11 Thread David Ostrovsky 
On Fri Mar 9 19:14:33 UTC 2018, Eike Rathke wrote:

>> On Tuesday, 2018-03-06 10:09:22 +0100, Stephan Bergmann wrote:
>> for a Gerrit change on which I'm listed as reviewer, I do get mails
for mine
>> and all other people's comments, just not for comments from Jenkins.
>
>Same here. I also don't get Jenkins comments mails for changes in
areas
>that touch my Watched Projects list (under Settings), even though
>I ticked All Comments for each entry there as well.

You and Stephan tell us, that you do want to be notified from
Jenkins and get all that spam (on start job and finish job, and re-
scheduled verification on rebases, and fixed patch sets in case first
17 verifications failed). Other developers told us the wuite the
opposite: shutdown the notification firehose and stop spam reviewers.

Gerrit has a mean for that: ACL "Email Reviewers" that can be denied:
[1] that id documented on Gerrit ACL page: [2] and to be easy to find
is even documented on the Jenkins Gerrit Trigger plugin: [3].

The bottom line of the discussion was: we shutdown the firehose and
disallow Jenkins to spam reviewers. On this screenshot, from All-
Project ACL page in gerrit, you can see how/where this DENY rule is
implemented: [4].

Of course, we could easily remove that DENY rule (again), but
I'm sure, that this would just restart the bikeshedding on that topic
that would probably end up (again) in disabling the firehose.

But let us do a step back and re-visit this thread: the actual
problem we are trying to solve is a different one: a missing
feedback from Jenkins on failed verifications jobs. Let me repeat
this again: the LibreOffice Gerrit-Jenkins setup deviates from
the standard recommended setup, by preventing voting Verified-1 on
failed builds.

That was an oversight, as confirmed by infra team, and in case of
false negative, Verified-1 vote can be easily removed by anyone, who
was granted the Remove Revievers ACL. In recent gerrit versions, I
even added "Delete Vote" feature, that let you preserve the reviewer
on a change, and only remove the vote. I would like to re-new my
call and ask infra team (again) to enable voting Verified-1 on failed
verifications.

My proposal to solve that for now and avoid future discussions:

1. Grant "Remove Reviewer" ACL to stewards group: [5]. That way many
devs are able to drop the wrong vote, and someone is always on the IRC.
2. Re-configure Jenkins Trigger Plugin set-up and enable voting of
Verified-1 on failed jobs.

[1] https://github.com/GerritCodeReview/gerrit/commit/d9488f0c37084f3e8
b6426ad9fd7722bea776ae2
[2] https://gerrit-review.googlesource.com/Documentation/access-control
.html#capability_emailReviewers
[3] https://wiki.jenkins.io/display/JENKINS/Gerrit+Trigger#GerritTrigge
r-Reducenumberofnotificationemails
[4] https://imgur.com/a/Lz3XM
[5] https://gerrit-review.googlesource.com/Documentation/access-control
.html#category_remove_reviewer

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - cppuhelper/source

2018-03-11 Thread Damjan Jovanovic 
 cppuhelper/source/makefile.mk |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit bd60ade1538d3b52b2052dd0aee187cedd18fe5d
Author: Damjan Jovanovic 
Date:   Sun Mar 11 07:25:25 2018 +

Fix the main/cppuhelpr symbol version map checks

for Win32 and Win64.

Patch by: me

diff --git a/cppuhelper/source/makefile.mk b/cppuhelper/source/makefile.mk
index 57da8f5ca155..325201006fe3 100644
--- a/cppuhelper/source/makefile.mk
+++ b/cppuhelper/source/makefile.mk
@@ -175,7 +175,9 @@ SHL1DEF=$(MISC)$/$(SHL1TARGET).def
 
 DEF1NAME=$(SHL1TARGET)
 
-.IF "$(COMNAME)"=="sunpro5"
+.IF "$(COMNAME)"=="msci"
+.ELIF "$(COMNAME)"=="mscx"
+.ELIF "$(COMNAME)"=="sunpro5"
 SHL1VERSIONMAP=cc5_solaris_sparc.map
 .ELIF "$(GUI)$(COMNAME)"=="OS2gcc3"
 SHL1VERSIONMAP=gcc3os2.map
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/source

2018-03-11 Thread Tamas Bunth 
 dbaccess/source/filter/hsqldb/hsqlimport.cxx |   10 --
 dbaccess/source/filter/hsqldb/rowinputbinary.cxx |9 -
 2 files changed, 16 insertions(+), 3 deletions(-)

New commits:
commit f9831de353742485b8241fb2bd8ca6b23e3c1c75
Author: Tamas Bunth 
Date:   Sat Mar 10 23:40:43 2018 +0100

dbahsql: import TIME columns

Change-Id: I8863127a4de1bfc06b13d008e037db2a4e60f1e7
Reviewed-on: https://gerrit.libreoffice.org/51059
Tested-by: Jenkins 
Reviewed-by: Tamás Bunth 

diff --git a/dbaccess/source/filter/hsqldb/hsqlimport.cxx 
b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
index cc806b313e9a..7f6426231b06 100644
--- a/dbaccess/source/filter/hsqldb/hsqlimport.cxx
+++ b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
@@ -139,8 +139,8 @@ void lcl_setParams(const RowVector& row, 
Reference& xParam,
 {
 xParam->setDouble(i + 1, nVal);
 }
-break;
 }
+break;
 case DataType::NUMERIC:
 case DataType::DECIMAL:
 {
@@ -157,8 +157,14 @@ void lcl_setParams(const RowVector& row, 
Reference& xParam,
 // TODO
 break;
 case DataType::TIME:
-// TODO
+{
+css::util::Time time;
+if (row.at(i) >>= time)
+{
+xParam->setTime(i + 1, time);
+}
 break;
+}
 case DataType::TIMESTAMP:
 // TODO
 break;
diff --git a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx 
b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
index b657abd36d52..0bcd0109e304 100644
--- a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
+++ b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -300,7 +301,13 @@ std::vector HsqlRowInputStream::readOneRow(const 
ColumnTypeVector& nColType
 case DataType::DATE:
 break;
 case DataType::TIME:
-break;
+{
+sal_Int64 value = 0;
+m_pStream->ReadInt64(value);
+css::util::Time time((value % 1000) * 100, value / 1000, 
0, 0, true);
+aData.push_back(makeAny(time));
+}
+break;
 case DataType::TIMESTAMP:
 break;
 case DataType::BOOLEAN:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa sw/source

2018-03-11 Thread Mike Kaganski 
 sw/qa/extras/odfimport/data/tdf108482.odt |binary
 sw/qa/extras/odfimport/odfimport.cxx  |   15 +++
 sw/source/core/layout/tabfrm.cxx  |3 +++
 3 files changed, 18 insertions(+)

New commits:
commit 82d9af7f14c808d48fa5db9420c85a8d26c79905
Author: Mike Kaganski 
Date:   Sun Mar 11 11:58:13 2018 +0300

tdf#108482: ignore repeated headlines' previous instances height

Change-Id: Idae0b99c4171556612fb41bb02f1c48bbfeec4b2
Reviewed-on: https://gerrit.libreoffice.org/51073
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/odfimport/data/tdf108482.odt 
b/sw/qa/extras/odfimport/data/tdf108482.odt
new file mode 100644
index ..c3ce2fc4272a
Binary files /dev/null and b/sw/qa/extras/odfimport/data/tdf108482.odt differ
diff --git a/sw/qa/extras/odfimport/odfimport.cxx 
b/sw/qa/extras/odfimport/odfimport.cxx
index 5ab5c5910ba3..1d4737318517 100644
--- a/sw/qa/extras/odfimport/odfimport.cxx
+++ b/sw/qa/extras/odfimport/odfimport.cxx
@@ -887,5 +887,20 @@ DECLARE_ODFIMPORT_TEST(testTdf115079, "tdf115079.odt")
 // This document caused segfault when layouting
 }
 
+DECLARE_ODFIMPORT_TEST(testTdf108482, "tdf108482.odt")
+{
+CPPUNIT_ASSERT_EQUAL_MESSAGE("The table on second page must have two rows",
+OUString("2"), parseDump("count(/root/page[2]/body/tab/row)")
+);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("The second page table's first row must be 
the repeated headline",
+OUString("Header"), parseDump("/root/page[2]/body/tab/row[1]/cell/txt")
+);
+// The first (repeated headline) row with vertical text orientation must 
have non-zero height
+// (in my tests, it was 1135)
+CPPUNIT_ASSERT_GREATER(
+sal_Int32(1000), 
parseDump("/root/page[2]/body/tab/row[1]/infos/bounds", "height").toInt32()
+);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index fec639ea943e..67ee9cc37a18 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -4101,6 +4101,9 @@ static sal_uInt16 lcl_GetBottomLineDist( const 
SwRowFrame& rRow )
 // on each following page
 static SwTwips lcl_calcHeightOfRowBeforeThisFrame(const SwRowFrame& rRow)
 {
+// We don't need to account for previous instances of repeated headlines
+if (rRow.IsRepeatedHeadline())
+return 0;
 SwRectFnSet aRectFnSet(&rRow);
 const SwTableLine* pLine = rRow.GetTabLine();
 const SwTabFrame* pTab = rRow.FindTabFrame();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Makefile.in

2018-03-11 Thread jan Iversen 
 Makefile.in |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit e6d2332eae92b8f288d3d3f8aa2090abfa777098
Author: jan Iversen 
Date:   Sun Mar 11 12:27:43 2018 +0100

Allow use of "git worktree" in Makefile.in

When using git worktree $(SRCDIR)/.git is a file and not a directory, 
therefore
get-submodules: fails in "./g -z".

Eliminating call to "./g -z" in worktree directories, but keeping it in the
cloned directory.

Change-Id: I88d8e3e06cac2a2710da21ae233364d8119fe5ef

diff --git a/Makefile.in b/Makefile.in
index 470c6956cc0e..0b2340a0ef58 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -241,7 +241,9 @@ get-submodules:
 ifneq ($(foreach i,$(GIT_NEEDED_SUBMODULES),$(i)/.git),$(wildcard $(foreach 
i,$(GIT_NEEDED_SUBMODULES),$(i)/.git)))
cd $(SRCDIR) && ./g -f clone
 endif
+ifeq ($(shell test -d $(SRCDIR)/.git; echo $$?),0)
@cd $(SRCDIR) && ./g -z # make sure the git hooks are in place even if 
no submodules are needed
+endif
 
 else # these sources are from a tarball, so get the other source tarballs
 gb_LO_VER := $(shell . $(SRCDIR)/sources.ver && echo $$lo_sources_ver)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Mac build error.

2018-03-11 Thread Noel Grandin 
On 11 March 2018 at 10:39, Jan Iversen  wrote:

> I work on 2 branches in parallel (iOS and master), so I use “git worktree”
> in order not to have 2 clones (a lot less diskspace).
>
>
I use the --with-referenced-git feature we have, and it works well to avoid
too much clone data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

My License Statement

2018-03-11 Thread Apurva Pavaskar 
All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.


Regards,
Apurva Pavaskar
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - config.guess config.sub

2018-03-11 Thread Matthias Seidel 
 config.guess |  482 ++-
 config.sub   |  207 +
 2 files changed, 326 insertions(+), 363 deletions(-)

New commits:
commit 8a023654625069efe6dddae685bed2fa3640a002
Author: Matthias Seidel 
Date:   Sun Mar 11 13:27:48 2018 +

Updated to the latest version:

- config.guess: 2018-03-08
- config.sub: 2018-03-08

diff --git a/config.guess b/config.guess
index 770cb5c7eb04..256083a70d35 100755
--- a/config.guess
+++ b/config.guess
@@ -1,8 +1,8 @@
 #! /bin/sh
 # Attempt to guess a canonical system name.
-#   Copyright 1992-2017 Free Software Foundation, Inc.
+#   Copyright 1992-2018 Free Software Foundation, Inc.
 
-timestamp='2017-12-17'
+timestamp='2018-03-08'
 
 # This file is free software; you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by
@@ -50,7 +50,7 @@ version="\
 GNU config.guess ($timestamp)
 
 Originally written by Per Bothner.
-Copyright 1992-2017 Free Software Foundation, Inc.
+Copyright 1992-2018 Free Software Foundation, Inc.
 
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE."
@@ -107,9 +107,9 @@ trap "rm -f \$tmpfiles 2>/dev/null; rmdir \$tmp 
2>/dev/null; exit 1" 1 2 13 15 ;
 dummy=$tmp/dummy ;
 tmpfiles="$dummy.c $dummy.o $dummy.rel $dummy" ;
 case $CC_FOR_BUILD,$HOST_CC,$CC in
- ,,)echo "int x;" > $dummy.c ;
+ ,,)echo "int x;" > "$dummy.c" ;
for c in cc gcc c89 c99 ; do
- if ($c -c -o $dummy.o $dummy.c) >/dev/null 2>&1 ; then
+ if ($c -c -o "$dummy.o" "$dummy.c") >/dev/null 2>&1 ; then
 CC_FOR_BUILD="$c"; break ;
  fi ;
done ;
@@ -132,14 +132,14 @@ UNAME_RELEASE=`(uname -r) 2>/dev/null` || 
UNAME_RELEASE=unknown
 UNAME_SYSTEM=`(uname -s) 2>/dev/null`  || UNAME_SYSTEM=unknown
 UNAME_VERSION=`(uname -v) 2>/dev/null` || UNAME_VERSION=unknown
 
-case "${UNAME_SYSTEM}" in
+case "$UNAME_SYSTEM" in
 Linux|GNU|GNU/*)
# If the system lacks a compiler, then just pick glibc.
# We could probably try harder.
LIBC=gnu
 
-   eval $set_cc_for_build
-   cat <<-EOF > $dummy.c
+   eval "$set_cc_for_build"
+   cat <<-EOF > "$dummy.c"
#include 
#if defined(__UCLIBC__)
LIBC=uclibc
@@ -149,13 +149,20 @@ Linux|GNU|GNU/*)
LIBC=gnu
#endif
EOF
-   eval `$CC_FOR_BUILD -E $dummy.c 2>/dev/null | grep '^LIBC' | sed 's, 
,,g'`
+   eval "`$CC_FOR_BUILD -E "$dummy.c" 2>/dev/null | grep '^LIBC' | sed 's, 
,,g'`"
+
+   # If ldd exists, use it to detect musl libc.
+   if command -v ldd >/dev/null && \
+   ldd --version 2>&1 | grep -q ^musl
+   then
+   LIBC=musl
+   fi
;;
 esac
 
 # Note: order is significant - the case branches are not exclusive.
 
-case "${UNAME_MACHINE}:${UNAME_SYSTEM}:${UNAME_RELEASE}:${UNAME_VERSION}" in
+case "$UNAME_MACHINE:$UNAME_SYSTEM:$UNAME_RELEASE:$UNAME_VERSION" in
 *:NetBSD:*:*)
# NetBSD (nbsd) targets should (where applicable) match one or
# more of the tuples: *-*-netbsdelf*, *-*-netbsdaout*,
@@ -169,30 +176,30 @@ case 
"${UNAME_MACHINE}:${UNAME_SYSTEM}:${UNAME_RELEASE}:${UNAME_VERSION}" in
# portion of the name.  We always set it to "unknown".
sysctl="sysctl -n hw.machine_arch"
UNAME_MACHINE_ARCH=`(uname -p 2>/dev/null || \
-   /sbin/$sysctl 2>/dev/null || \
-   /usr/sbin/$sysctl 2>/dev/null || \
+   "/sbin/$sysctl" 2>/dev/null || \
+   "/usr/sbin/$sysctl" 2>/dev/null || \
echo unknown)`
-   case "${UNAME_MACHINE_ARCH}" in
+   case "$UNAME_MACHINE_ARCH" in
armeb) machine=armeb-unknown ;;
arm*) machine=arm-unknown ;;
sh3el) machine=shl-unknown ;;
sh3eb) machine=sh-unknown ;;
sh5el) machine=sh5le-unknown ;;
earmv*)
-   arch=`echo ${UNAME_MACHINE_ARCH} | sed -e 
's,^e\(armv[0-9]\).*$,\1,'`
-   endian=`echo ${UNAME_MACHINE_ARCH} | sed -ne 
's,^.*\(eb\)$,\1,p'`
-   machine=${arch}${endian}-unknown
+   arch=`echo "$UNAME_MACHINE_ARCH" | sed -e 
's,^e\(armv[0-9]\).*$,\1,'`
+   endian=`echo "$UNAME_MACHINE_ARCH" | sed -ne 
's,^.*\(eb\)$,\1,p'`
+   machine="${arch}${endian}"-unknown
;;
-   *) machine=${UNAME_MACHINE_ARCH}-unknown ;;
+   *) machine="$UNAME_MACHINE_ARCH"-unknown ;;
esac
# The Operating System including object format, if it has switched
# to ELF recently (or will in the future) and ABI.
-   case "${UNAME_MACHINE_ARCH}" in
+   case "$UNAME_MACHINE_ARCH" in
earm*)
os=netbsdelf
;;
arm*|i386|m68k|ns32k|sh3*|sparc|vax)
-   eval $set_cc_for_build
+   eval "$set_cc_f

[Libreoffice-commits] core.git: dbaccess/source

2018-03-11 Thread Tamas Bunth 
 dbaccess/source/filter/hsqldb/fbcreateparser.cxx |4 ++
 dbaccess/source/filter/hsqldb/hsqlimport.cxx |   23 ---
 dbaccess/source/filter/hsqldb/rowinputbinary.cxx |   34 +--
 3 files changed, 53 insertions(+), 8 deletions(-)

New commits:
commit 813296d4a21163ffba86f1f4c0bec6ddb0511e6c
Author: Tamas Bunth 
Date:   Sun Mar 11 11:54:36 2018 +0100

dbahsql: import DATE and DATETIME columns

Change-Id: Ibfd9340fad40efab891cba5b77ce3496424a3525
Reviewed-on: https://gerrit.libreoffice.org/51076
Tested-by: Jenkins 
Reviewed-by: Tamás Bunth 

diff --git a/dbaccess/source/filter/hsqldb/fbcreateparser.cxx 
b/dbaccess/source/filter/hsqldb/fbcreateparser.cxx
index f69580423cf2..b92be4af6812 100644
--- a/dbaccess/source/filter/hsqldb/fbcreateparser.cxx
+++ b/dbaccess/source/filter/hsqldb/fbcreateparser.cxx
@@ -113,7 +113,9 @@ OUString FbCreateStmtParser::compose() const
 lcl_appendWithSpace(sSql, 
lcl_DataTypetoFbTypeName(columnIter->getDataType()));
 
 const std::vector params = columnIter->getParams();
-if (params.size() > 0)
+
+// Firebird SQL dialect does not like paremeters for TIMESTAMP
+if (params.size() > 0 && columnIter->getDataType() != 
DataType::TIMESTAMP)
 {
 sSql.append("(");
 auto it = params.cbegin();
diff --git a/dbaccess/source/filter/hsqldb/hsqlimport.cxx 
b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
index 7f6426231b06..95f7de3a878a 100644
--- a/dbaccess/source/filter/hsqldb/hsqlimport.cxx
+++ b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -154,8 +155,14 @@ void lcl_setParams(const RowVector& row, 
Reference& xParam,
 }
 break;
 case DataType::DATE:
-// TODO
-break;
+{
+css::util::Date date;
+if (row.at(i) >>= date)
+{
+xParam->setDate(i + 1, date);
+}
+}
+break;
 case DataType::TIME:
 {
 css::util::Time time;
@@ -163,11 +170,17 @@ void lcl_setParams(const RowVector& row, 
Reference& xParam,
 {
 xParam->setTime(i + 1, time);
 }
-break;
 }
+break;
 case DataType::TIMESTAMP:
-// TODO
-break;
+{
+css::util::DateTime dateTime;
+if (row.at(i) >>= dateTime)
+{
+xParam->setTimestamp(i + 1, dateTime);
+}
+}
+break;
 case DataType::BOOLEAN:
 {
 bool bVal = false;
diff --git a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx 
b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
index 0bcd0109e304..7b6fd4eff94c 100644
--- a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
+++ b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
@@ -22,10 +22,13 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include 
 #include 
 #include 
+#include 
 
 namespace
 {
@@ -299,7 +302,16 @@ std::vector HsqlRowInputStream::readOneRow(const 
ColumnTypeVector& nColType
 }
 break;
 case DataType::DATE:
-break;
+{
+sal_Int64 value = 0;
+m_pStream->ReadInt64(value); // in millisec, from 1970
+sal_Int64 nEpochSec = value / 1000;
+std::tm* tm = std::gmtime(&nEpochSec);
+css::util::Date date(tm->tm_mday, tm->tm_mon + 1,
+ tm->tm_year + 1900); // day, month, year
+aData.push_back(makeAny(date));
+}
+break;
 case DataType::TIME:
 {
 sal_Int64 value = 0;
@@ -309,7 +321,25 @@ std::vector HsqlRowInputStream::readOneRow(const 
ColumnTypeVector& nColType
 }
 break;
 case DataType::TIMESTAMP:
-break;
+{
+sal_Int64 nEpochMillis = 0;
+m_pStream->ReadInt64(nEpochMillis);
+sal_Int64 nEpochSec = nEpochMillis / 1000;
+std::tm* tm = std::gmtime(&nEpochSec);
+
+sal_Int32 nNanos = 0;
+m_pStream->ReadInt32(nNanos);
+css::util::DateTime dateTime;
+dateTime.NanoSeconds = nNanos;
+dateTime.Seconds = tm->tm_sec;
+dateTime.Minutes = tm->tm_min;
+dateTime.Hours = tm->tm_hour;
+dateTime.Day = tm->tm_mday;
+dateTime.Month = tm->tm_mon + 1; // indexed from 0
+dateTime.Year = 1900 + tm->tm_year;
+aData.push_back(makeAny(dateTime));
+}
+break;

[Libreoffice-commits] core.git: 2 commits - bridges/inc bridges/source

2018-03-11 Thread jan Iversen 
 bridges/inc/vtablefactory.hxx   |2 +-
 bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx |5 -
 2 files changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 5facd232c181e3bd47f1140245bd32a5efb2b21b
Author: jan Iversen 
Date:   Sun Mar 11 17:19:05 2018 +0100

iOS, removed unneeded #ifdef arm64

Change-Id: Ie568c461ae834b33b9220c4b9fb42ec66b5e7ce0

diff --git a/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
index 0ca1401ba960..17ed29f60789 100644
--- a/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
@@ -17,8 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifdef __arm64
-
 // For iOS devices (64-bit ARM). Originally a copy of
 // ../gcc3_linux_arm/cpp2uno.cxx.
 
@@ -555,7 +553,6 @@ unsigned char * 
bridges::cpp_uno::shared::VtableFactory::addLocalFunctions(
 return code;
 }
 
-#endif
 
 
 void bridges::cpp_uno::shared::VtableFactory::flushCode(
commit 6ec77e28f131a03cd6209ef3de5bd8afb2442086
Author: jan Iversen 
Date:   Sun Mar 11 13:05:57 2018 +0100

iOS, revert bed135e02bf7db2ef8c29747bbf79f26da71e9ca

using USE_DOUBLE_MMAP worked well on the device, but caused
problems with the simulator, that depends on the GCC3_MAC* implementation.

Change-Id: Ifbc1d48b3642567029c5271054a545eaacaf18ed

diff --git a/bridges/inc/vtablefactory.hxx b/bridges/inc/vtablefactory.hxx
index 04e3addc3149..70c87c385952 100644
--- a/bridges/inc/vtablefactory.hxx
+++ b/bridges/inc/vtablefactory.hxx
@@ -31,7 +31,7 @@
 /*See: http://people.redhat.com/drepper/selinux-mem.html*/
 #if defined(LINUX) || defined(OPENBSD) || defined(FREEBSD) \
 || defined(NETBSD) || defined(DRAGONFLY) || defined (ANDROID) \
-|| defined(HAIKU)  || defined(IOS)
+|| defined(HAIKU)
 #define USE_DOUBLE_MMAP
 #endif
 
diff --git a/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
index 8008d3a2193e..0ca1401ba960 100644
--- a/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
@@ -512,13 +512,11 @@ bridges::cpp_uno::shared::VtableFactory::initializeBlock(
 unsigned char * bridges::cpp_uno::shared::VtableFactory::addLocalFunctions(
 Slot ** slots,
 unsigned char * code,
-sal_PtrDiff writetoexecdiff,
 typelib_InterfaceTypeDescription const * type,
 sal_Int32 functionOffset,
 sal_Int32 functionCount,
 sal_Int32 vtableOffset)
 {
-(void)writetoexecdiff;
 (*slots) -= functionCount;
 Slot * s = *slots;
 for (sal_Int32 i = 0; i < type->nMembers; ++i)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/gbuild

2018-03-11 Thread Mike Kaganski 
 solenv/gbuild/extensions/post_GbuildToJson.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e42d869a2f0551aca748f70d8c2c2f770ad3742c
Author: Mike Kaganski 
Date:   Sun Mar 11 16:30:32 2018 +0100

gbuildtojson: unblacklist i18npool scaddins tools

Change-Id: I26a41fa7afb2fd374103e7a4a321be35b4bf22a1
Reviewed-on: https://gerrit.libreoffice.org/51081
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/solenv/gbuild/extensions/post_GbuildToJson.mk 
b/solenv/gbuild/extensions/post_GbuildToJson.mk
index 46493368a498..ae042962e6c2 100644
--- a/solenv/gbuild/extensions/post_GbuildToJson.mk
+++ b/solenv/gbuild/extensions/post_GbuildToJson.mk
@@ -186,7 +186,7 @@ endef
 
 gb_Module_add_l10n_target =
 
-gb_GbuildToJson_BLACKLISTEDMODULES := connectivity compilerplugins cli_ure 
dictionaries bridges helpcompiler helpcontent2 icon-themes jurt external 
i18npool javaunohelper lingucomponent odk scaddins solenv stoc tools 
translations udkapi unoidl
+gb_GbuildToJson_BLACKLISTEDMODULES := connectivity compilerplugins cli_ure 
dictionaries bridges helpcompiler helpcontent2 icon-themes jurt external 
javaunohelper lingucomponent odk solenv stoc translations udkapi unoidl
 
 define gb_Module__add_moduledir_impl
 include $(patsubst $(1):%,%,$(filter 
$(1):%,$(gb_Module_MODULELOCATIONS)))/$(2)/Module_$(2).mk
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - bridges/source ios/LibreOfficeLight

2018-03-11 Thread jan Iversen 
 bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx |   44 ++--
 bridges/source/cpp_uno/gcc3_ios/ios64_helper.s  |   36 --
 ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj |   52 
++
 3 files changed, 88 insertions(+), 44 deletions(-)

New commits:
commit 814bd40070db654d80a16d9f813610cae3b12dd6
Author: jan Iversen 
Date:   Sun Mar 11 19:05:09 2018 +0100

iOS, calling cpp_vtable_call does not corrupt stack

Changing bl -> b (jump long to jump) allowed cpp_vtable_call
to work without corrumping the stack.

However return still corrumpts the stack.

Change-Id: I3437a73139b65af13dcf6fa0c959bb1c847564b9

diff --git a/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
index 1250beedbcda..98d859c69cde 100644
--- a/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
@@ -56,11 +56,11 @@ extern "C" void privateSnippetExecutor()
  // Second argument: The pointer to all the above
  "   mov x1, sp\n"
 
- "   bl  _cpp_vtable_call\n"
+ "   b   _cpp_vtable_call\n"
 
  "   ldp x8, lr, [sp, #0]\n"
  "   add sp, sp, #144\n"
- "   ret lr\n"
+// "   ret lr\n"
 );
 }
 
commit a414d362350df8eacd82104545a6aaf4ce102011
Author: jan Iversen 
Date:   Sun Mar 11 18:22:38 2018 +0100

iOS, updated xcode project file

the only change is that addition of files needed to debug the
stack corruption problem.

Change-Id: I3598cdba2e84f51a3a90387dbe3439eafb34f878

diff --git a/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj 
b/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
index e02182b1d8e7..c702cef65d22 100644
--- a/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
+++ b/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
@@ -93,6 +93,24 @@
39E950521FC9842000D82C49 /* source */ = {isa = 
PBXFileReference; lastKnownFileType = folder; name = source; path = ../source; 
sourceTree = ""; };
39EE81531FA644E800B73AB8 /* Info.plist */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = 
Info.plist; sourceTree = ""; };
39EF4E2E1FA500C9001914AC /* PropertiesController.swift */ = 
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = 
sourcecode.swift; path = PropertiesController.swift; sourceTree = ""; };
+   39FD89C9204E87E900E7179F /* except.cxx */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = except.cxx; path = 
"../../bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx"; sourceTree = 
""; };
+   39FD89CB204E87FD00E7179F /* except.cxx */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = except.cxx; path = ../../bridges/source/cpp_uno/gcc3_ios/except.cxx; 
sourceTree = ""; };
+   39FD89CF204E8EB900E7179F /* cpp2uno.cxx */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = cpp2uno.cxx; path = ../../bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx; 
sourceTree = ""; };
+   39FD89D1204E8ED000E7179F /* share.hxx */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.h; name 
= share.hxx; path = ../../bridges/source/cpp_uno/gcc3_ios/share.hxx; sourceTree 
= ""; };
+   39FD89D2204E8ED000E7179F /* unwind-cxx.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
"unwind-cxx.h"; path = "../../bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h"; 
sourceTree = ""; };
+   39FD89D3204E8ED000E7179F /* rtti.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = 
rtti.h; path = ../../bridges/source/cpp_uno/gcc3_ios/rtti.h; sourceTree = 
""; };
+   39FD89D4204E8ED000E7179F /* ios64_helper.s */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.asm; name = 
ios64_helper.s; path = ../../bridges/source/cpp_uno/gcc3_ios/ios64_helper.s; 
sourceTree = ""; };
+   39FD89D5204E8ED000E7179F /* uno2cpp.cxx */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = uno2cpp.cxx; path = ../../bridges/source/cpp_uno/gcc3_ios/uno2cpp.cxx; 
sourceTree = ""; };
+   39FD89D8204E8EEE00E7179F /* call.cxx */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = call.cxx; path = 
"../../bridges/source/cpp_uno/gcc3_macosx_x86-64/call.cxx"; sourceTree = 
""; };
+   39FD89D9204E8EEE00E7179F /* abi.cxx */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; 
name = abi.cxx; path = 
"../../bridges/source/cpp_uno/gcc3_macosx_x86-64/abi.cxx"; sou

[Libreoffice-commits] core.git: Branch 'feature/OperationSmiley' - 801 commits - accessibility/inc accessibility/source android/source avmedia/source basctl/inc basctl/source basctl/uiconfig basegfx/s

2018-03-11 Thread Armin Le Grand 
Rebased ref, commits from common ancestor:
commit 0c2dc352ed73b9eecb464b79e155f37910b2e551
Author: Armin Le Grand 
Date:   Fri Feb 23 16:57:41 2018 +0100

OperationSmiley: Added support for using same FillGeometry

It is now possible to use a single FillGeometry to fill objects that
are made of multiple filled objects (e.g. CustomShapes) so that
they look as using a single fill. This is used for CustomShapes,
but may later be 'extended' to be used for more cases. The basic
functionality was already in the primitives, but had to be added
to SDrObject due to these being used for CustomShapeVisualization
(currently - would be better to change this to primitives, too).

Change-Id: I1d9fb158191a9ec663e46f3911213be2f3d88986

diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 3e97a472084f..7bd547f20d71 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -270,11 +270,32 @@ public:
 class SvxShape;
 class SVX_DLLPUBLIC SdrObject: public SfxListener, public virtual 
tools::WeakBase
 {
+private:
 friend classSdrObjListIter;
 friend classSdrVirtObj;
 friend classSdrRectObj;
 friend classSdrDelayBroadcastObjectChange;
 
+// OperationSmiley: Allow at each SdrObject to set a 
FillGeometryDefiningShape,
+// so that for SdrObjects where this is set, the definition of a defined 
FillStyle
+// will use this, but the local geometry will be filled. This allows to 
fill
+// multiple shapes with a unified fill, e.g think about CustomShapes.
+// Currently this is *only* used for CustomShapes, but may be developed to 
get a
+// common mechanism - usages for it are easy to be found. The current 
limitation
+// to CustomShapes allows to to think about these SdrObjects to 'vanish' 
during the
+// lifetime of 'this' - the SdrObjects without SdrPage and SdrModel are 
used as helper
+// objects for SdrObjCustomShape and thus their lifetime is limited to the 
lifetime
+// of this local object. For unifying this mechanism, some weak reference 
of
+// SdrObjects would have to be thought about (not easy with the current 
implementation).
+// So - allow *only* EnhancedCustomShape2d (which creates the 
visualizations for
+// SdrObjCustomShape) to set this. Already allow unified read to use it - 
thus already
+// allowing to implement as standard case for all kinds of SdrObjects.
+friend class EnhancedCustomShape2d;
+const SdrObject*mpFillGeometryDefiningShape;
+void setFillGeometryDefiningShape(const SdrObject* pNew) { 
mpFillGeometryDefiningShape = pNew; }
+public:
+const SdrObject* getFillGeometryDefiningShape() const { return 
mpFillGeometryDefiningShape; }
+
 public:
 SdrObject();
 
diff --git a/svx/inc/sdr/primitive2d/sdrpathprimitive2d.hxx 
b/svx/inc/sdr/primitive2d/sdrpathprimitive2d.hxx
index b60e9b3df565..e165344b26c1 100644
--- a/svx/inc/sdr/primitive2d/sdrpathprimitive2d.hxx
+++ b/svx/inc/sdr/primitive2d/sdrpathprimitive2d.hxx
@@ -40,20 +40,36 @@ namespace drawinglayer
 attribute::SdrLineFillShadowTextAttribute   maSdrLFSTAttribute;
 basegfx::B2DPolyPolygon maUnitPolyPolygon;
 
+// OperationSmiley: Added to be able to define a FillGeometry 
different from local
+// geometry. It is ignored when empty and/or equal to 
UnitPolyPolygon.
+// If used and there is a fill, object's geomery 
(maUnitPolyPolygon) will be filled,
+// but UnitDefinitionPolyPolygon will be used to define the 
FillStyle. Thus when
+// using the 'same' UnitDefinitionPolyPolygon for multiple 
definitions,
+// all filled stuff using it will fit seamless together.
+// 'same' is in quotes since it is a UnitPolygon, so being 
relative to the
+// unit polygon of the local geometry (UnitPolyPolygon). The 
definition is complete
+// when applying the also given transfomation (maTransform)
+basegfx::B2DPolyPolygon 
maUnitDefinitionPolyPolygon;
+
 protected:
 // local decomposition.
 virtual void create2DDecomposition(Primitive2DContainer& 
rContainer, const geometry::ViewInformation2D& aViewInformation) const override;
 
 public:
+// OperationSmiley: Extended to UnitDefinitionPolyPolygon, but 
when needed
+// a 2nd version without can be defined that just does not set the
+// maUnitDefinitionPolyPolygon or set equal to UnitPolyPolygon
 SdrPathPrimitive2D(
 const basegfx::B2DHomMatrix& rTransform,
 const attribute::SdrLineFillShadowTextAttribute& 
rSdrLFSTAttribute,
-const basegfx::B2DPolyPolygon& rUnitPolyPolygon);
+const basegfx::B2DPolyPolygon& rUnitPolyPolygon,
+const basegfx::B2DPolyP

[Libreoffice-commits] core.git: icon-themes/sifr icon-themes/sifr_dark icon-themes/sifr_svg

2018-03-11 Thread Matthias Freund 
 icon-themes/sifr/links.txt  |   11 +--
 icon-themes/sifr_dark/links.txt |   17 +++--
 icon-themes/sifr_svg/links.txt  |   17 +++--
 3 files changed, 27 insertions(+), 18 deletions(-)

New commits:
commit 745998f778c22568c3bd691ffc24e80982e2db44
Author: Matthias Freund 
Date:   Sun Mar 11 16:00:34 2018 +0100

tdf#75256 Sifr update fix for not showing up epub export icon

Change-Id: Ifa85cb2d99e049295903408bb990e8e37d1f5021
Reviewed-on: https://gerrit.libreoffice.org/51080
Tested-by: Jenkins 
Reviewed-by: Matthias Freund 

diff --git a/icon-themes/sifr/links.txt b/icon-themes/sifr/links.txt
index e2dae945a9ca..555f7242f40f 100644
--- a/icon-themes/sifr/links.txt
+++ b/icon-themes/sifr/links.txt
@@ -58,9 +58,6 @@ sc/res/table.png cmd/sc_inserttable.png
 cmd/lc_thesaurusdialog.png cmd/lc_thesaurus.png
 cmd/sc_thesaurusdialog.png cmd/sc_thesaurus.png
 
-# File Menu
-cmd/sc_exporttopdf.png cmd/sc_exportdirecttopdf.png
-
 # Print Preview Toolbar
 cmd/lc_showsinglepage.png cmd/lc_adddirect.png
 cmd/sc_showsinglepage.png cmd/sc_adddirect.png
@@ -209,9 +206,11 @@ cmd/sc_objectforwardone.png cmd/sc_forward.png
 cmd/lc_objectbackone.png cmd/lc_backward.png
 cmd/sc_objectbackone.png cmd/sc_backward.png
 
-# writer epub export
-cmd/lc_exportdirecttoepub.png cmd/lc_exportdirecttopdf.png
-cmd/sc_exportdirecttoepub.png cmd/sc_exportdirecttopdf.png
+# writer pdf and epub export
+cmd/lc_exporttopdf.png cmd/lc_exportdirecttopdf.png
+cmd/sc_exporttopdf.png cmd/sc_exportdirecttopdf.png
+cmd/lc_exporttoepub.png cmd/lc_exportdirecttoepub.png
+cmd/sc_exporttoepub.png cmd/sc_exportdirecttoepub.png
 
 # writer formatting style toolbar
 cmd/lc_bulletliststyle.png cmd/lc_defaultbullet.png
diff --git a/icon-themes/sifr_dark/links.txt b/icon-themes/sifr_dark/links.txt
index 58d9a65f5852..555f7242f40f 100644
--- a/icon-themes/sifr_dark/links.txt
+++ b/icon-themes/sifr_dark/links.txt
@@ -58,12 +58,11 @@ sc/res/table.png cmd/sc_inserttable.png
 cmd/lc_thesaurusdialog.png cmd/lc_thesaurus.png
 cmd/sc_thesaurusdialog.png cmd/sc_thesaurus.png
 
-# File Menu
-cmd/sc_exporttopdf.png cmd/sc_exportdirecttopdf.png
-
 # Print Preview Toolbar
 cmd/lc_showsinglepage.png cmd/lc_adddirect.png
 cmd/sc_showsinglepage.png cmd/sc_adddirect.png
+cmd/lc_closepreview.png cmd/lc_exitsearch.png
+cmd/sc_closepreview.png cmd/sc_exitsearch.png
 
 # Horizontal Text Alignment (align* is in calc and *para is used in writer)
 #cmd/lc_alignleft.png cmd/lc_leftpara.png
@@ -207,12 +206,18 @@ cmd/sc_objectforwardone.png cmd/sc_forward.png
 cmd/lc_objectbackone.png cmd/lc_backward.png
 cmd/sc_objectbackone.png cmd/sc_backward.png
 
-# writer epub export
-cmd/lc_exportdirecttoepub.png cmd/lc_exportdirecttopdf.png
-cmd/sc_exportdirecttoepub.png cmd/sc_exportdirecttopdf.png
+# writer pdf and epub export
+cmd/lc_exporttopdf.png cmd/lc_exportdirecttopdf.png
+cmd/sc_exporttopdf.png cmd/sc_exportdirecttopdf.png
+cmd/lc_exporttoepub.png cmd/lc_exportdirecttoepub.png
+cmd/sc_exporttoepub.png cmd/sc_exportdirecttoepub.png
 
 # writer formatting style toolbar
 cmd/lc_bulletliststyle.png cmd/lc_defaultbullet.png
 cmd/sc_bulletliststyle.png cmd/sc_defaultbullet.png
 cmd/lc_numberliststyle.png cmd/lc_defaultnumbering.png
 cmd/sc_numberliststyle.png cmd/sc_defaultnumbering.png
+
+# view menu
+cmd/lc_viewsidebarstyles.png cmd/lc_designerdialog.png
+cmd/sc_viewsidebarstyles.png cmd/sc_designerdialog.png
diff --git a/icon-themes/sifr_svg/links.txt b/icon-themes/sifr_svg/links.txt
index 58d9a65f5852..555f7242f40f 100644
--- a/icon-themes/sifr_svg/links.txt
+++ b/icon-themes/sifr_svg/links.txt
@@ -58,12 +58,11 @@ sc/res/table.png cmd/sc_inserttable.png
 cmd/lc_thesaurusdialog.png cmd/lc_thesaurus.png
 cmd/sc_thesaurusdialog.png cmd/sc_thesaurus.png
 
-# File Menu
-cmd/sc_exporttopdf.png cmd/sc_exportdirecttopdf.png
-
 # Print Preview Toolbar
 cmd/lc_showsinglepage.png cmd/lc_adddirect.png
 cmd/sc_showsinglepage.png cmd/sc_adddirect.png
+cmd/lc_closepreview.png cmd/lc_exitsearch.png
+cmd/sc_closepreview.png cmd/sc_exitsearch.png
 
 # Horizontal Text Alignment (align* is in calc and *para is used in writer)
 #cmd/lc_alignleft.png cmd/lc_leftpara.png
@@ -207,12 +206,18 @@ cmd/sc_objectforwardone.png cmd/sc_forward.png
 cmd/lc_objectbackone.png cmd/lc_backward.png
 cmd/sc_objectbackone.png cmd/sc_backward.png
 
-# writer epub export
-cmd/lc_exportdirecttoepub.png cmd/lc_exportdirecttopdf.png
-cmd/sc_exportdirecttoepub.png cmd/sc_exportdirecttopdf.png
+# writer pdf and epub export
+cmd/lc_exporttopdf.png cmd/lc_exportdirecttopdf.png
+cmd/sc_exporttopdf.png cmd/sc_exportdirecttopdf.png
+cmd/lc_exporttoepub.png cmd/lc_exportdirecttoepub.png
+cmd/sc_exporttoepub.png cmd/sc_exportdirecttoepub.png
 
 # writer formatting style toolbar
 cmd/lc_bulletliststyle.png cmd/lc_defaultbullet.png
 cmd/sc_bulletliststyle.png cmd/sc_defaultbullet.png
 cmd/lc_numberliststyle.png cmd/lc_defaultnumbering.png
 cmd/sc_numberliststyle.png cmd/sc_defaultnumberin

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - dictionaries

2018-03-11 Thread László Németh 
 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5ef624f7c95455937b4f90c41580050d6f9fe8a0
Author: László Németh 
Date:   Fri Mar 9 18:59:33 2018 +0100

Updated core
Project: dictionaries  d689c8660c0e3335159273af25fd88fe82de4af3

tdf#95024 update Hungarian spelling dictionary

Changes from Magyar Helyesírási Szótár (2017),
for example "soppingol", "sznekk", "videófilm".
Other fixes and rules.

Change-Id: I7ba79f48495fc0f6b930ae426e0ce1efdaa66984
Reviewed-on: https://gerrit.libreoffice.org/51020
Reviewed-by: László Németh 
Tested-by: László Németh 
(cherry picked from commit edcc4e770e287a6ebe1022cb57fda539ceec9188)
Reviewed-on: https://gerrit.libreoffice.org/51089
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/dictionaries b/dictionaries
index eaeb462d7812..d689c8660c0e 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit eaeb462d78121c7b9ba7c9e6c6de94c5781c9fbd
+Subproject commit d689c8660c0e3335159273af25fd88fe82de4af3
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-6-0' - hu_HU/description.xml hu_HU/hu_HU.aff hu_HU/hu_HU.dic hu_HU/README_hu_HU.txt

2018-03-11 Thread László Németh 
 hu_HU/README_hu_HU.txt |8 
 hu_HU/description.xml  |2 
 hu_HU/hu_HU.aff|  815 +
 hu_HU/hu_HU.dic| 2866 -
 4 files changed, 2680 insertions(+), 1011 deletions(-)

New commits:
commit d689c8660c0e3335159273af25fd88fe82de4af3
Author: László Németh 
Date:   Fri Mar 9 18:59:33 2018 +0100

tdf#95024 update Hungarian spelling dictionary

Changes from Magyar Helyesírási Szótár (2017),
for example "soppingol", "sznekk", "videófilm".
Other fixes and rules.

Change-Id: I7ba79f48495fc0f6b930ae426e0ce1efdaa66984
Reviewed-on: https://gerrit.libreoffice.org/51020
Reviewed-by: László Németh 
Tested-by: László Németh 
(cherry picked from commit edcc4e770e287a6ebe1022cb57fda539ceec9188)
Reviewed-on: https://gerrit.libreoffice.org/51089
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/hu_HU/README_hu_HU.txt b/hu_HU/README_hu_HU.txt
index addfda6..fdb5d86 100644
--- a/hu_HU/README_hu_HU.txt
+++ b/hu_HU/README_hu_HU.txt
@@ -1,17 +1,17 @@
-Magyar Ispell helyesírási szótár – 1.7 béta 4 szótárállományok morfológiai 
adatokkal
+Magyar Ispell helyesírási szótár – 1.7 béta 5 szótárállományok morfológiai 
adatokkal
 
 A szótárállományok a LibreOffice projekt részeként a következő nyílt forráskódú
 licencek bármelyike alapján szabadon felhasználhatóak, de mindenféle garancia 
nélkül:
 
 MPLv2 vagy LesserGPLv3+
 
-(c) Németh László és Godó Ferenc, 2017
+(c) Németh László és Godó Ferenc, 2018
 
 Honlap: http://magyarispell.sf.net
 
 --
 
-Hungarian Hunspell dictionaries version 1.7 beta 4 with morphological data
+Hungarian Hunspell dictionaries version 1.7 beta 5 with morphological data
 
 These files are part of the LibreOffice project.
 
@@ -26,6 +26,6 @@ Software distributed under these licenses is distributed on 
an "AS IS" basis,
 WITHOUT WARRANTY OF ANY KIND, either express or implied. See the licences
 for the specific language governing rights and limitations under the licenses.
 
-2017 (c) László Németh & Ferenc Godó
+2018 (c) László Németh & Ferenc Godó
 
 Home: http://magyarispell.sf.net
diff --git a/hu_HU/description.xml b/hu_HU/description.xml
index 5599c5a..072e2c3 100644
--- a/hu_HU/description.xml
+++ b/hu_HU/description.xml
@@ -1,6 +1,6 @@
 
 http://openoffice.org/extensions/description/2006"; 
xmlns:d="http://openoffice.org/extensions/description/2006";  
xmlns:xlink="http://www.w3.org/1999/xlink";>
-
+
 
 
 Hungarian spelling dictionary, hyphenation rules, 
thesaurus, and grammar checker
diff --git a/hu_HU/hu_HU.aff b/hu_HU/hu_HU.aff
index 235f785..f8f6411 100644
--- a/hu_HU/hu_HU.aff
+++ b/hu_HU/hu_HU.aff
@@ -6,11 +6,11 @@
 # GPL/LGPL/MPL license as published by the FSF and Mozilla Foundation.
 #
 #
-# Version: January 2018, 1.7 beta 4
+# Version: March 2018, 1.7 beta 5
 #
 # Home page: http://magyarispell.sourceforge.net
 #
-# 2002-2017 (c) L�szl� N�meth  and Ferenc God�
+# 2002-2018 (c) L�szl� N�meth  and Ferenc God�
 #
 # Thanks to
 # Tam�s Sz�nt� ,
@@ -30,7 +30,7 @@
 # amelyet N�meth L�szl� �s God� Ferenc k�sz�tett, �s a GPL/LGPL/MPL licenc
 # alatt k�zz�tett a http://magyarispell.sourceforge.net oldalon.
 #
-# Magyar Ispell 1.7 b�ta 4 v�ltozat, 2018-01
+# Magyar Ispell 1.7 beta 5 v�ltozat, 2018-03
 #
 # K�sz�net illeti a k�vetkez�ket:
 #
@@ -111,7 +111,7 @@ MAP ií
 MAP oóöő
 MAP uúüű
 
-BREAK 9
+BREAK 10
 BREAK –
 BREAK -
 BREAK ^-
@@ -119,6 +119,7 @@ BREAK -$
 BREAK -beli$
 BREAK -féle$
 BREAK "
+BREAK ”
 BREAK ?
 BREAK !
 
@@ -131,6 +132,9 @@ COMPOUNDRULE 2
 COMPOUNDRULE 0*1
 COMPOUNDRULE 00*20*1
 
+# (1)-ben, [3]-ban, c)-vel
+# LibreOffice hibajegy:
+# https://bugs.documentfoundation.org/show_bug.cgi?id=116072
 IGNORE ()]
 
 # f-ligat�r�k
@@ -153,7 +157,7 @@ ICONV fl fl
 # - multicharacter suggestions
 # - well-sorted suggestions
 
-REP 147
+REP 153
 REP í i
 REP i í
 REP ó o
@@ -198,6 +202,8 @@ REP nny nyj
 REP nny nj
 REP tty tyj
 REP tty tj
+REP ttsz tsz # tettszik->tetszik
+REP ttsz tssz # tettszék->tetsszék
 REP ck dzk # óckodik->ódzkodik
 REP cc tsz # maracc->maratsz
 REP cc dsz # maracc->maradsz
@@ -264,6 +270,9 @@ REP csakazértis csak_azért_is
 REP fő fő_
 REP papír papír_
 REP közben _közben
+REP jellegű _jellegű
+REP formájú _formájú
+REP nagyságú _nagyságú
 REP vég _vég
 REP be be_
 REP módra _módra
@@ -301,8 +310,9 @@ REP ue ü # fondue->fondü, fonduet->fondüt
 REP ue- ü # fondue-t->fondüt
 REP ^rám rám_ # rámváró->rám váró
 REP ^rád rád_ # rádváró->rád váró
+REP ^hű hűe # hűn->hűen, hűk->hűek
 
-AF 1414
+AF 1477
 AF V˯j�L�n��TtYc��l # 1
 AF Um��yiYc� # 2
 AF �CWR̯j���y���Yc� # 3
@@ -1717,7 +1727,71 @@ AF DRT # 1411
 AF DQS # 1412
 AF @ # 1413
 AF % # 1414
-AM 23361
+AF c!V�n�Llabh) # 1415
+AF bh)) # 1416
+AF nI)) # 1417
+AF !AU�m��Kkbh)) # 1418
+AF m�A$U�Ssbhc�� # 1419
+AF c!V�n�Llbh) # 1420
+AF Uʮi�K�m��yǿ�SsYc # 1421
+AF V˯j�L�n��y���TtYc

[Libreoffice-commits] core.git: sw/uiconfig

2018-03-11 Thread Caolán McNamara 
 sw/uiconfig/swriter/ui/splittable.ui |1 +
 1 file changed, 1 insertion(+)

New commits:
commit e0e307675cc2b962d0dcb557f4af4a34a729da66
Author: Caolán McNamara 
Date:   Sat Mar 10 21:44:52 2018 +

has-default without can-default

Change-Id: Id10bf6afd455c1f78152aabde033b24cb879db36
Reviewed-on: https://gerrit.libreoffice.org/51056
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/uiconfig/swriter/ui/splittable.ui 
b/sw/uiconfig/swriter/ui/splittable.ui
index 31db232b96f6..a192f79b2c44 100644
--- a/sw/uiconfig/swriter/ui/splittable.ui
+++ b/sw/uiconfig/swriter/ui/splittable.ui
@@ -24,6 +24,7 @@
 gtk-ok
 True
 True
+True
 True
 True
 True
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang cui/inc cui/source cui/uiconfig extras/source icon-themes/galaxy icon-themes/tango include/svx include/vcl sfx2/source svx/source sw/source vcl/so

2018-03-11 Thread Caolán McNamara 
 compilerplugins/clang/store/fpcomparison.cxx   |2 
 cui/inc/bitmaps.hlst   |1 
 cui/source/dialogs/colorpicker.cxx |  792 ++---
 cui/uiconfig/ui/colorpickerdialog.ui   |  136 ++--
 extras/source/glade/libreoffice-catalog.xml.in |9 
 icon-themes/galaxy/res/colorsliderright.png|binary
 icon-themes/tango/res/colorsliderright.png |binary
 include/svx/hexcolorcontrol.hxx|   20 
 include/vcl/layout.hxx |   41 +
 include/vcl/weld.hxx   |   21 
 sfx2/source/doc/new.cxx|5 
 sfx2/source/inc/preview.hxx|2 
 svx/source/dialog/hexcolorcontrol.cxx  |   63 +
 sw/source/ui/table/autoformatpreview.cxx   |4 
 sw/source/uibase/inc/autoformatpreview.hxx |2 
 vcl/source/app/salvtables.cxx  |   51 +
 vcl/unx/gtk3/gtk3gtkinst.cxx   |  190 +
 17 files changed, 796 insertions(+), 543 deletions(-)

New commits:
commit cf4b65c75c07142be0fcab5835188a28e839b749
Author: Caolán McNamara 
Date:   Thu Mar 8 12:17:56 2018 +

weld color picker

Change-Id: I487b9a0cc13b2b60a0f1e28667773b5d3b5c66cc
Reviewed-on: https://gerrit.libreoffice.org/51001
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/compilerplugins/clang/store/fpcomparison.cxx 
b/compilerplugins/clang/store/fpcomparison.cxx
index b914d7084bc4..0e27ed9819f4 100644
--- a/compilerplugins/clang/store/fpcomparison.cxx
+++ b/compilerplugins/clang/store/fpcomparison.cxx
@@ -231,8 +231,6 @@ bool FpComparison::ignore(FunctionDecl* function)
 || 
dc.Function("ApplySpecialItem").Class("TitleItemConverter").Namespace("wrapper").Namespace("chart").GlobalNamespace()
 || 
dc.Function("ApplySpecialItem").Class("TextLabelItemConverter").Namespace("wrapper").Namespace("chart").GlobalNamespace()
 || 
dc.Function("operate").Class("OOp_COMPARE").Namespace("file").Namespace("connectivity").GlobalNamespace()
-|| 
dc.Function("SetValues").Class("ColorFieldControl").Namespace("cui").GlobalNamespace()
-|| 
dc.Function("SetValue").Class("ColorSliderControl").Namespace("cui").GlobalNamespace()
 || 
dc.Function("Write").Class("ORTFImportExport").Namespace("dbaui").GlobalNamespace()
 || 
dc.Function("appendRow").Class("ORTFImportExport").Namespace("dbaui").GlobalNamespace()
 || 
dc.Function("WriteCell").Class("OHTMLImportExport").Namespace("dbaui").GlobalNamespace()
diff --git a/cui/inc/bitmaps.hlst b/cui/inc/bitmaps.hlst
index dc1ce4a6a9e4..2cefabd14611 100644
--- a/cui/inc/bitmaps.hlst
+++ b/cui/inc/bitmaps.hlst
@@ -63,7 +63,6 @@
 #define RID_SVXBMP_FILEOPEN "res/fileopen.png"
 #define RID_SVXBMP_TARGET   "res/target.png"
 #define RID_SVXBMP_NEWDOC   "res/newdoc.png"
-#define RID_SVXBMP_COLORSLIDER  "res/colorslider.png"
 
 #define RID_SVXBMP_COLLAPSEDNODE"res/sx18002.png"
 #define RID_SVXBMP_EXPANDEDNODE "res/sx18003.png"
diff --git a/cui/source/dialogs/colorpicker.cxx 
b/cui/source/dialogs/colorpicker.cxx
index 756c0d5aed6f..70a059a29014 100644
--- a/cui/source/dialogs/colorpicker.cxx
+++ b/cui/source/dialogs/colorpicker.cxx
@@ -28,6 +28,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -150,61 +151,85 @@ static void RGBtoCMYK( double dR, double dG, double dB, 
double& fCyan, double& f
 }
 }
 
-class ColorPreviewControl : public Control
+class ColorPreviewControl
 {
+private:
+std::unique_ptr m_xDrawingArea;
+Color m_aColor;
+Size m_aSize;
+
+DECL_LINK(DoPaint, weld::DrawingArea::draw_args, void);
+DECL_LINK(DoResize, const Size& rSize, void);
 public:
-ColorPreviewControl( vcl::Window* pParent, WinBits nStyle );
+ColorPreviewControl(weld::DrawingArea* pDrawingArea)
+: m_xDrawingArea(pDrawingArea)
+{
+m_xDrawingArea->connect_size_allocate(LINK(this, ColorPreviewControl, 
DoResize));
+m_xDrawingArea->connect_draw(LINK(this, ColorPreviewControl, DoPaint));
+
m_xDrawingArea->set_size_request(m_xDrawingArea->get_approximate_char_width() * 
10,
+ m_xDrawingArea->get_text_height() * 
2);
 
-virtual void Paint(vcl::RenderContext& rRenderContext, const 
::tools::Rectangle& rRect) override;
+}
 
-void SetColor(const Color& rColor);
+void SetColor(const Color& rCol)
+{
+if (rCol != m_aColor)
+{
+m_aColor = rCol;
+m_xDrawingArea->queue_draw();
+}
+}
 
-private:
-Color maColor;
+void show() { m_xDrawingArea->show(); }
 };
 
-ColorPreviewControl::ColorPreviewControl(vcl::Window* pParent, WinBits nStyle)
-: Control(pParent, nStyle)
+IMPL_LINK(ColorPreviewControl, DoPaint, weld::DrawingArea::draw_args, 
aPayload, void)
 {
+vcl::RenderContext&

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2018-03-11 Thread Bjoern Michaelsen 
 sw/inc/calbck.hxx  |   56 ++--
 sw/qa/core/uwriter.cxx |  112 ++---
 sw/source/core/attr/calbck.cxx |   70 +
 3 files changed, 180 insertions(+), 58 deletions(-)

New commits:
commit 5c04518c2d4b289289d551e22709e22702563d50
Author: Bjoern Michaelsen 
Date:   Wed Jan 31 01:13:53 2018 +0100

introduce sw::WriterMultiListener

- it can handle multple sources to listen to: this should make SwDepend
  (always been a hack) soon obsolete
- also add a unittest for it
- WriterMultiListener notifies via hints about reregistering, so help
  migrating away from these crazy static_cast<>(GetRegisteredIn())
- fix expected<->actual asserts in uwriter.cxx

Change-Id: I8c70826d1a8be5c8097d81304f0df42bb7319cd4
Reviewed-on: https://gerrit.libreoffice.org/49565
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/inc/calbck.hxx b/sw/inc/calbck.hxx
index d42f1e95dbd0..7b903c2c9638 100644
--- a/sw/inc/calbck.hxx
+++ b/sw/inc/calbck.hxx
@@ -26,6 +26,8 @@
 #include "ring.hxx"
 #include "hintids.hxx"
 #include 
+#include 
+#include 
 
 
 class SwModify;
@@ -69,6 +71,12 @@ namespace sw
 const SfxPoolItem* m_pOld;
 const SfxPoolItem* m_pNew;
 };
+struct SW_DLLPUBLIC ModifyChangedHint final: SfxHint
+{
+ModifyChangedHint(const SwModify* pNew) : m_pNew(pNew) {};
+virtual ~ModifyChangedHint() override;
+const SwModify* m_pNew;
+};
 /// refactoring out the some of the more sane SwClient functionality
 class SW_DLLPUBLIC WriterListener
 {
@@ -104,6 +112,7 @@ class SW_DLLPUBLIC SwClient : public ::sw::WriterListener
 protected:
 // single argument ctors shall be explicit.
 inline explicit SwClient( SwModify* pToRegisterIn );
+SwClient(SwClient&&);
 
 // write access to pRegisteredIn shall be granted only to the object 
itself (protected access)
 SwModify* GetRegisteredInNonConst() const { return m_pRegisteredIn; }
@@ -122,7 +131,7 @@ public:
 
 // in case an SwModify object is destroyed that itself is registered in 
another SwModify,
 // its SwClient objects can decide to get registered to the latter instead 
by calling this method
-void CheckRegistration( const SfxPoolItem *pOldValue );
+std::unique_ptr CheckRegistration( const 
SfxPoolItem* pOldValue );
 
 // controlled access to Modify method
 // mba: this is still considered a hack and it should be fixed; the name 
makes grep-ing easier
@@ -212,6 +221,12 @@ class SW_DLLPUBLIC SwDepend final : public SwClient
 
 public:
 SwDepend(SwClient *pTellHim, SwModify *pDepend) : SwClient(pDepend), 
m_pToTell(pTellHim) {}
+SwDepend(SwDepend&) = delete;
+SwDepend(SwDepend&& o)
+: SwClient(std::move(o)), m_pToTell(o.m_pToTell)
+{
+o.m_pToTell = nullptr;
+}
 
 SwClient* GetToTell() { return m_pToTell; }
 
@@ -221,17 +236,46 @@ public:
 private:
 virtual void Modify( const SfxPoolItem* pOldValue, const SfxPoolItem 
*pNewValue ) override
 {
-if( pNewValue && pNewValue->Which() == RES_OBJECTDYING )
-CheckRegistration(pOldValue);
-else if( m_pToTell )
-m_pToTell->ModifyNotification(pOldValue, pNewValue);
+SwClientNotify(*GetRegisteredIn(), sw::LegacyModifyHint(pOldValue, 
pNewValue));
 }
 virtual void SwClientNotify( const SwModify& rModify, const SfxHint& rHint 
) override
-{ if(m_pToTell) m_pToTell->SwClientNotifyCall(rModify, rHint); }
+{
+if (auto pLegacyHint = dynamic_cast(&rHint))
+{
+if( pLegacyHint->m_pNew && pLegacyHint->m_pNew->Which() == 
RES_OBJECTDYING )
+{
+auto pModifyChanged = CheckRegistration(pLegacyHint->m_pOld);
+if(pModifyChanged)
+m_pToTell->SwClientNotify(rModify, *pModifyChanged);
+}
+else if( m_pToTell )
+m_pToTell->ModifyNotification(pLegacyHint->m_pOld, 
pLegacyHint->m_pNew);
+}
+else if(m_pToTell)
+m_pToTell->SwClientNotifyCall(rModify, rHint);
+}
 };
 
+
 namespace sw
 {
+class SW_DLLPUBLIC WriterMultiListener final
+{
+#ifdef WNT
+typedef std::shared_ptr pointer_t;
+#else
+typedef std::unique_ptr pointer_t;
+#endif
+SwClient& m_rToTell;
+std::list m_vDepends;
+public:
+WriterMultiListener(SwClient& rToTell)
+: m_rToTell(rToTell) {}
+void StartListening(SwModify* pDepend);
+void EndListening(SwModify* pDepend);
+bool IsListeningTo(const SwModify* const pDepend);
+void EndListeningAll();
+};
 class ClientIteratorBase : public sw::Ring< ::sw::ClientIteratorBase >
 {
 friend SwClient* SwModify::Remove(SwClient*);
diff --git a/sw/qa/core/uwriter.cxx b/sw/q

[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source

2018-03-11 Thread Bjoern Michaelsen 
 sw/inc/docufld.hxx |2 -
 sw/source/core/fields/docufld.cxx  |8 +--
 sw/source/core/inc/unoport.hxx |6 ++---
 sw/source/core/unocore/unoport.cxx |   41 +
 4 files changed, 25 insertions(+), 32 deletions(-)

New commits:
commit 82ff1317a3f4627d25399e93da0f9bc88fe89205
Author: Bjoern Michaelsen 
Date:   Wed Jan 31 23:12:14 2018 +0100

use sw::WriterMultiListener instead of SwDepend in SwXTextPortion

- also switch from old Modify() handler to new SwClientNotify()
- also simplify some sequence generation with C++11

Change-Id: I219f626ce51e07c581ddf49d0cf5dc66e2d6a997
Reviewed-on: https://gerrit.libreoffice.org/49567
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/source/core/inc/unoport.hxx b/sw/source/core/inc/unoport.hxx
index d0cef52f7c70..2cb9ddb38402 100644
--- a/sw/source/core/inc/unoport.hxx
+++ b/sw/source/core/inc/unoport.hxx
@@ -115,8 +115,8 @@ private:
 std::unique_ptr< css::uno::Any > m_pRubyPosition;
 sw::UnoCursorPointer m_pUnoCursor;
 
-const SwDepend  m_FrameDepend;
-SwFrameFormat *  m_pFrameFormat;
+sw::WriterMultiListener m_aDepends;
+SwFrameFormat*  m_pFrameFormat;
 const SwTextPortionType m_ePortionType;
 
 boolm_bIsCollapsed;
@@ -148,7 +148,7 @@ protected:
 virtual ~SwXTextPortion() override;
 
 //SwClient
-virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) 
override;
+virtual void SwClientNotify(const SwModify&, const SfxHint& rHint) 
override;
 
 public:
 SwXTextPortion(const SwUnoCursor* pPortionCursor, css::uno::Reference< 
css::text::XText > const& rParent, SwTextPortionType   eType   );
diff --git a/sw/source/core/unocore/unoport.cxx 
b/sw/source/core/unocore/unoport.cxx
index 09092d1501d1..80f707ef2526 100644
--- a/sw/source/core/unocore/unoport.cxx
+++ b/sw/source/core/unocore/unoport.cxx
@@ -71,7 +71,7 @@ SwXTextPortion::SwXTextPortion(
 ?  PROPERTY_MAP_REDLINE_PORTION
 :  PROPERTY_MAP_TEXTPORTION_EXTENSIONS))
 , m_xParentText(rParent)
-, m_FrameDepend(this, nullptr)
+, m_aDepends(*this)
 , m_pFrameFormat(nullptr)
 , m_ePortionType(eType)
 , m_bIsCollapsed(false)
@@ -86,11 +86,12 @@ SwXTextPortion::SwXTextPortion(
 : m_pPropSet(aSwMapProvider.GetPropertySet(
 PROPERTY_MAP_TEXTPORTION_EXTENSIONS))
 , m_xParentText(rParent)
-, m_FrameDepend(this, &rFormat)
+, m_aDepends(*this)
 , m_pFrameFormat(&rFormat)
 , m_ePortionType(PORTION_FRAME)
 , m_bIsCollapsed(false)
 {
+m_aDepends.StartListening(&rFormat);
 init( pPortionCursor);
 }
 
@@ -107,7 +108,7 @@ SwXTextPortion::SwXTextPortion(
 , m_pRubyAdjust ( bIsEnd ? nullptr : new uno::Any )
 , m_pRubyIsAbove( bIsEnd ? nullptr : new uno::Any )
 , m_pRubyPosition( bIsEnd ? nullptr : new uno::Any )
-, m_FrameDepend(this, nullptr)
+, m_aDepends(*this)
 , m_pFrameFormat(nullptr)
 , m_ePortionType( bIsEnd ? PORTION_RUBY_END : PORTION_RUBY_START )
 , m_bIsCollapsed(false)
@@ -129,7 +130,7 @@ SwXTextPortion::~SwXTextPortion()
 {
 SolarMutexGuard aGuard;
 m_pUnoCursor.reset(nullptr);
-const_cast(&m_FrameDepend)->EndListeningAll();
+m_aDepends.EndListeningAll();
 }
 
 uno::Reference< text::XText >  SwXTextPortion::getText()
@@ -798,14 +799,12 @@ sal_Int64 SwXTextPortion::getSomething( const 
uno::Sequence< sal_Int8 >& rId )
 
 uno::Sequence< OUString > SwXTextPortion::getAvailableServiceNames()
 {
-SolarMutexGuard aGuard;
-uno::Sequence aRet { "com.sun.star.text.TextContent" };
-return aRet;
+return { "com.sun.star.text.TextContent" };
 }
 
 OUString SwXTextPortion::getImplementationName()
 {
-return OUString("SwXTextPortion");
+return { "SwXTextPortion" };
 }
 
 sal_Bool SwXTextPortion::supportsService(const OUString& rServiceName)
@@ -815,24 +814,22 @@ sal_Bool SwXTextPortion::supportsService(const OUString& 
rServiceName)
 
 uno::Sequence< OUString > SwXTextPortion::getSupportedServiceNames()
 {
-uno::Sequence< OUString > aRet(7);
-OUString* pArray = aRet.getArray();
-pArray[0] = "com.sun.star.text.TextPortion";
-pArray[1] = "com.sun.star.style.CharacterProperties";
-pArray[2] = "com.sun.star.style.CharacterPropertiesAsian";
-pArray[3] = "com.sun.star.style.CharacterPropertiesComplex";
-pArray[4] = "com.sun.star.style.ParagraphProperties";
-pArray[5] = "com.sun.star.style.ParagraphPropertiesAsian";
-pArray[6] = "com.sun.star.style.ParagraphPropertiesComplex";
-return aRet;
+return { "com.sun.star.text.TextPortion",
+"com.sun.star.style.CharacterProperties",
+"com.sun.star.style.CharacterPropertiesAsian",
+"com.sun.star.style.CharacterPropertiesComplex",
+"com.sun.star.style.ParagraphProperties",
+"com.su

[Libreoffice-commits] core.git: sc/common_unoapi_tests.mk sc/CppunitTest_sc_anchor_test.mk sc/CppunitTest_sc_annotationobj.mk sc/CppunitTest_sc_annotationshapeobj.mk sc/CppunitTest_sc_annotationsobj.m

2018-03-11 Thread Tomaž Vajngerl 
 sc/CppunitTest_sc_anchor_test.mk|   36 -
 sc/CppunitTest_sc_annotationobj.mk  |   36 -
 sc/CppunitTest_sc_annotationshapeobj.mk |   35 -
 sc/CppunitTest_sc_annotationsobj.mk |   36 -
 sc/CppunitTest_sc_arealinkobj.mk|   36 -
 sc/CppunitTest_sc_arealinksobj.mk   |   36 -
 sc/CppunitTest_sc_autoformatobj.mk  |   36 -
 sc/CppunitTest_sc_cellcursorobj.mk  |   36 -
 sc/CppunitTest_sc_cellobj.mk|   36 -
 sc/CppunitTest_sc_cellrangeobj.mk   |   36 -
 sc/CppunitTest_sc_cellrangesobj.mk  |   37 --
 sc/CppunitTest_sc_check_data_pilot_field.mk |   33 
 sc/CppunitTest_sc_check_data_pilot_table.mk |   33 
 sc/CppunitTest_sc_check_xcell_ranges_query.mk   |   33 
 sc/CppunitTest_sc_consolidationdescriptorobj.mk |   36 -
 sc/CppunitTest_sc_databaserangeobj.mk   |   35 -
 sc/CppunitTest_sc_databaserangesobj.mk  |   36 -
 sc/CppunitTest_sc_datapilotfieldobj.mk  |   35 -
 sc/CppunitTest_sc_datapilotitemobj.mk   |   35 -
 sc/CppunitTest_sc_datapilottableobj.mk  |   36 -
 sc/CppunitTest_sc_documentconfigurationobj.mk   |   36 -
 sc/CppunitTest_sc_editfieldobj_cell.mk  |   33 
 sc/CppunitTest_sc_editfieldobj_header.mk|   33 
 sc/CppunitTest_sc_filterdescriptorbaseobj.mk|   37 --
 sc/CppunitTest_sc_functionlistobj.mk|   36 -
 sc/CppunitTest_sc_headerfootercontentobj.mk |   36 -
 sc/CppunitTest_sc_importdescriptorbaseobj.mk|   36 -
 sc/CppunitTest_sc_labelrangeobj.mk  |   36 -
 sc/CppunitTest_sc_labelrangesobj.mk |   36 -
 sc/CppunitTest_sc_modelobj.mk   |   35 -
 sc/CppunitTest_sc_namedrangeobj.mk  |   36 -
 sc/CppunitTest_sc_namedrangesobj.mk |   36 -
 sc/CppunitTest_sc_new_cond_format_api.mk|   36 -
 sc/CppunitTest_sc_outlineobj.mk |   36 -
 sc/CppunitTest_sc_recentfunctionsobj.mk |   36 -
 sc/CppunitTest_sc_recordchanges.mk  |   36 -
 sc/CppunitTest_sc_scenariosobj.mk   |   36 -
 sc/CppunitTest_sc_shapeobj.mk   |   36 -
 sc/CppunitTest_sc_sheetlinkobj.mk   |   36 -
 sc/CppunitTest_sc_spreadsheetsettingsobj.mk |   36 -
 sc/CppunitTest_sc_styleloaderobj.mk |   36 -
 sc/CppunitTest_sc_subtotaldescriptorbaseobj.mk  |   35 -
 sc/CppunitTest_sc_subtotalfieldobj.mk   |   36 -
 sc/CppunitTest_sc_tableconditionalentryobj.mk   |   36 -
 sc/CppunitTest_sc_tableconditionalformatobj.mk  |   36 -
 sc/CppunitTest_sc_tablesheetobj.mk  |   36 -
 sc/CppunitTest_sc_tablesheetsobj.mk |   36 -
 sc/CppunitTest_sc_tablevalidationobj.mk |   36 -
 sc/CppunitTest_sc_tabviewobj.mk |   36 -
 sc/CppunitTest_sc_viewpaneobj.mk|   35 -
 sc/Module_sc.mk |2 
 sc/common_unoapi_tests.mk   |   49 
 52 files changed, 103 insertions(+), 1728 deletions(-)

New commits:
commit cab04bc39b5164ea74216cd849c3af5f5b298f79
Author: Tomaž Vajngerl 
Date:   Sun Mar 11 23:45:38 2018 +0900

extract common components to one place for sc unoapi tests

The declared components in a test of uno api don't change much
or at all, so instead of duplicating this in every test, define
it in a common file use when needed. Some more common things
could be extracted in a similar way.

Change-Id: I07ae641afca55ffaf3c5c93624bfaa2143590886
Reviewed-on: https://gerrit.libreoffice.org/51079
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/sc/CppunitTest_sc_anchor_test.mk b/sc/CppunitTest_sc_anchor_test.mk
index 480149c7ecd5..d7942c19d8f6 100644
--- a/sc/CppunitTest_sc_anchor_test.mk
+++ b/sc/CppunitTest_sc_anchor_test.mk
@@ -65,41 +65,7 @@ $(eval $(call gb_CppunitTest_use_ure,sc_anchor_test))
 $(eval $(call gb_CppunitTest_use_vcl,sc_anchor_test))
 
 $(eval $(call gb_CppunitTest_use_components,sc_anchor_test,\
-   basic/util/sb \
-   comphelper/util/comphelp \
-   configmgr/source/configmgr \
-   dbac

Re: GSoC Idea Discussion "Improvements to Notebookbar"

2018-03-11 Thread Kshitij Pathania 
Hi

I was writing the proposal for Gsoc "Improvement to notebookbar".While
going through the notebookbar implementation I have got some doubts. It
would be very helpful if these below-mentioned points can be explained.

Style dropdown in notebookbar- As I see, in all the notebookbars styles
dropdown combo box is there, then why in GSoC ideas it is written that "new
functions such as style dropdown haven't been introduced yet". Please
correct me if something above is wrong.

Customization of notebookbar- Customization via Glade is not suitable for
normal users so we need to user-friendly interface to customize the
notebookbar.But since the ui files are specific for each notebookbar,
customization will make all these glade files dynamic.How this can be
achieved, some advice will be helpful in this.

Resizing of notebookbar - Do I need to improve the existing algorithm for
resizing using PriorityHBox and DropdownBox or need to make a new algorithm
to implement new features especially of ms ribbon resize(as these
improvements will be slightly different from above algorithm and cannot be
added on it ).

Thanking you,
Kshitij Pathania
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Subsequent tests: forms_unoapi_1 failing under Windows

2018-03-11 Thread Luke Benes 
After 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c15ea73f960bbd3d2a4b0c43b467ac62eeba3505

I'm getting the following build failure with a 'make check' under windows:
https://pastebin.com/iMJq68V3





___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GSoC Project

2018-03-11 Thread Pranav Kant 
Hi Shayantan,

On 11/03/18 23:45, Shayantan Pal wrote:
> Respected sirs,
> 
> I am interested in the project : 
> 
> 
>   LibreOffice Online Admin
> 
> 
> for Google Summer Of Code 2018 and would like to work on it . Kindly consider 
> my
> candidature. 

As a qualification process, we require students to work on at least one Easy
Hacks (as mentioned here[1]) before you submit your application for GSoC later.

> 
> I have sond knowledge of CPP and other OOP languages such as Java and also can
> code in Python , HTML5 and Css3. 

Please look at the list of easy hacks for Online[2]. There are relevant code
pointers already in all of the easy hacks but if stuck, don't hesitate to ask on
the bug itself. There is some more helpful information on the same wiki page
including slides of talks given on LibreOffice Online in previous conferences;
you might want to go through them to understand the architecture, code
structure, etc.


> I have successfully participated in Google Code
> In 2013,14,15 and wat to extend my repertoire in coding 

That's great to hear.


[1] https://wiki.documentfoundation.org/Development/LibreOffice_Online#GSoC
[2] 
https://wiki.documentfoundation.org/Development/LibreOffice_Online#Easy_Hacks

-- 
Regards,
Pranav



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

2018-03-11 Thread Henry Castro 
 sc/source/ui/view/tabvwshf.cxx |   28 +---
 1 file changed, 17 insertions(+), 11 deletions(-)

New commits:
commit c9c0f257f4abe738203d2294ca86822e200d3ce3
Author: Henry Castro 
Date:   Sun Mar 11 18:44:58 2018 -0400

lokdialog: convert the show sheet dialog to async exec

Change-Id: I501d9444ef9798a26b4db06ab51e4fb691144b17
Reviewed-on: https://gerrit.libreoffice.org/51094
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/sc/source/ui/view/tabvwshf.cxx b/sc/source/ui/view/tabvwshf.cxx
index ae3a8bc6ac88..64e5cb52ef3b 100644
--- a/sc/source/ui/view/tabvwshf.cxx
+++ b/sc/source/ui/view/tabvwshf.cxx
@@ -135,7 +135,7 @@ void ScTabViewShell::ExecuteTable( SfxRequest& rReq )
 ScAbstractDialogFactory* pFact = 
ScAbstractDialogFactory::Create();
 OSL_ENSURE(pFact, "ScAbstractFactory create fail!");
 
-ScopedVclPtr 
pDlg(pFact->CreateScShowTabDlg(GetDialogParent()));
+VclPtr 
pDlg(pFact->CreateScShowTabDlg(GetDialogParent()));
 OSL_ENSURE(pDlg, "Dialog create fail!");
 
 OUString aTabName;
@@ -150,18 +150,24 @@ void ScTabViewShell::ExecuteTable( SfxRequest& rReq )
 }
 }
 
-if ( pDlg->Execute() == RET_OK )
-{
-const sal_Int32 nCount = pDlg->GetSelectedEntryCount();
-for (sal_Int32 nPos=0; nPos pReq = 
std::make_shared(rReq);
+pDlg->StartExecuteAsync([this, pDlg, pReq](sal_Int32 
nResult){
+OUString sTable;
+std::vector sTables;
+if (RET_OK == nResult)
 {
-aName = pDlg->GetSelectedEntry(nPos);
-rReq.AppendItem( SfxStringItem( FID_TABLE_SHOW, 
aName ) );
-rNames.push_back(aName);
+const sal_Int32 nCount = 
pDlg->GetSelectedEntryCount();
+for (sal_Int32 nPos=0; nPosGetSelectedEntry(nPos);
+pReq->AppendItem( SfxStringItem( 
FID_TABLE_SHOW, sTable ) );
+sTables.push_back(sTable);
+}
+ShowTable( sTables );
+pReq->Done();
 }
-ShowTable( rNames );
-rReq.Done();
-}
+});
+rReq.Ignore();
 }
 }
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: GSoC 2018 Help

2018-03-11 Thread Pranav Kant 
Hi Apurva,

(Please keep @libreoffice in CC)

On 11/03/18 19:04, Apurva Pavaskar wrote:
> Hi,
> 
> Needed to ask some more things :
> -the subsequent builds will automatically be incremental right?

Yes, unless you touch some widely used header files.

> -for filing a bug/working on one : do I need to do it through bugzilla or
> gerrit? and how?

If you have found a bug, it's best to file it on bugzilla first and then submit
fixes/patches for it in gerrit (mentioning the bug number in the commit 
message).

Regarding how, you might want to look at these:

https://wiki.documentfoundation.org/Development/gerrit
https://wiki.documentfoundation.org/QA/Bugzilla

> -how do I pull the latest changes before building my build and submitting my 
> patch?

`git pull` should be enough to pull the latest changes and rebase your current
changes on top of that.

> 
> And there is an easy hack on Bugzilla : Bug 55410
> (https://bugs.documentfoundation.org/show_bug.cgi?id=55410)
> 
> I wanted to fix it for KDE rather than windows, how do I file in a new bug
> (gerrit/bugzilla) and how?

Comment 16 reports that it's broken for Linux as well. Also, the bug fields
doesn't mention it to be a Window specific bug; so, no need to file a separate 
bug.

You might want to read the commit that breaks it for Linux. Did you already do
that? If yes, I think it's best to dump your findings on the bug so that others
can help you wherever you are stuck.

-- 
Regards,
Pranav



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GSoC Project

2018-03-11 Thread Pranav Kant 


On 12/03/18 11:46, Shayantan Pal wrote:
> Hi Pranav,
> 
> Thanks for the heads up .  Is it absolutely necessary that I submit my  GSoC
> application on 18 March itself ? Can I submit it later too ? 

Reading here[1], the student application deadline is 27th March. So, you need to
submit it by 27, not 18th. And yes, it's absolutely necessary that you submit
your proposal by 27th.

[1] https://developers.google.com/open-source/gsoc/timeline


> 
> On 12-Mar-2018 9:15 AM, "Pranav Kant"  > wrote:
> 
> Hi Shayantan,
> 
> On 11/03/18 23:45, Shayantan Pal wrote:
> > Respected sirs,
> >
> > I am interested in the project : 
> >
> >
> >       LibreOffice Online Admin
> >
> >
> > for Google Summer Of Code 2018 and would like to work on it . Kindly
> consider my
> > candidature.
> 
> As a qualification process, we require students to work on at least one 
> Easy
> Hacks (as mentioned here[1]) before you submit your application for GSoC 
> later.
> 
> >
> > I have sond knowledge of CPP and other OOP languages such as Java and 
> also can
> > code in Python , HTML5 and Css3.
> 
> Please look at the list of easy hacks for Online[2]. There are relevant 
> code
> pointers already in all of the easy hacks but if stuck, don't hesitate to 
> ask on
> the bug itself. There is some more helpful information on the same wiki 
> page
> including slides of talks given on LibreOffice Online in previous 
> conferences;
> you might want to go through them to understand the architecture, code
> structure, etc.
> 
> 
> > I have successfully participated in Google Code
> > In 2013,14,15 and wat to extend my repertoire in coding
> 
> That's great to hear.
> 
> 
> [1] 
> https://wiki.documentfoundation.org/Development/LibreOffice_Online#GSoC
> 
> [2]
> 
> https://wiki.documentfoundation.org/Development/LibreOffice_Online#Easy_Hacks 
> 
> 
> --
> Regards,
> Pranav
> 

-- 
Regards,
Pranav



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: compilerplugins/clang editeng/source include/editeng mysqlc/source

2018-03-11 Thread Noel Grandin 
 compilerplugins/clang/unusedmethods.results|  222 -
 compilerplugins/clang/unusedmethods.unused-returns.results |4 
 editeng/source/editeng/editeng.cxx |5 
 include/editeng/editeng.hxx|1 
 mysqlc/source/mysqlc_driver.cxx|   34 -
 mysqlc/source/mysqlc_subcomponent.hxx  |5 
 6 files changed, 85 insertions(+), 186 deletions(-)

New commits:
commit cb34e6083cdc82333d64ad9224e0d25e895d1dae
Author: Noel Grandin 
Date:   Fri Mar 9 15:23:44 2018 +0200

loplugin:unusedmethods

Change-Id: I027adbe65edd5f07534bb36f9f54c55f30ba516e
Reviewed-on: https://gerrit.libreoffice.org/50998
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedmethods.results 
b/compilerplugins/clang/unusedmethods.results
index 747cb3037f08..3c535defd69c 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -10,8 +10,6 @@ connectivity/source/drivers/evoab2/NResultSetMetaData.hxx:51
 class com::sun::star::uno::Reference 
connectivity::evoab::OEvoabResultSetMetaData::operator Reference()
 connectivity/source/drivers/firebird/Driver.hxx:65
 const class com::sun::star::uno::Reference & 
connectivity::firebird::FirebirdDriver::getContext() const
-connectivity/source/drivers/firebird/SubComponent.hxx:53
-void release(int &,struct cppu::OBroadcastHelperVar 
&,class com::sun::star::uno::Reference 
&,class com::sun::star::lang::XComponent *)
 connectivity/source/drivers/firebird/Util.hxx:61
  connectivity::firebird::ColumnTypeInfo::ColumnTypeInfo(short,const class 
rtl::OUString &)
 connectivity/source/drivers/firebird/Util.hxx:66
@@ -46,8 +44,6 @@ connectivity/source/inc/OTypeInfo.hxx:55
 _Bool connectivity::OTypeInfo::operator==(const struct 
connectivity::OTypeInfo &) const
 connectivity/source/inc/OTypeInfo.hxx:56
 _Bool connectivity::OTypeInfo::operator!=(const struct 
connectivity::OTypeInfo &) const
-dbaccess/source/filter/hsqldb/columndef.hxx:37
-int dbahsql::ColumnDefinition::getAutoIncrementDefault() const
 dbaccess/source/ui/browser/genericcontroller.cxx:1230
 const type-parameter-?-? & dbaui::(anonymous 
namespace)::SGI_identity::operator()(const type-parameter-?-? &) const
 dbaccess/source/ui/inc/indexcollection.hxx:54
@@ -260,8 +256,6 @@ include/comphelper/configuration.hxx:264
 void comphelper::ConfigurationLocalizedProperty::set(const 
type-parameter-?-? &,const class std::shared_ptr &)
 include/comphelper/configuration.hxx:300
 class com::sun::star::uno::Reference 
comphelper::ConfigurationGroup::get(const class std::shared_ptr &)
-include/comphelper/graphicmimetype.hxx:27
-class rtl::OUString 
comphelper::GraphicMimeTypeHelper::GetMimeTypeForImageUrl(const class 
rtl::OUString &)
 include/comphelper/logging.hxx:57
 class rtl::OUString convertLogArgToString(char16_t)
 include/comphelper/logging.hxx:232
@@ -336,8 +330,8 @@ include/drawinglayer/primitive3d/baseprimitive3d.hxx:113
 _Bool drawinglayer::primitive3d::BasePrimitive3D::operator!=(const class 
drawinglayer::primitive3d::BasePrimitive3D &) const
 include/drawinglayer/texture/texture.hxx:44
 _Bool drawinglayer::texture::GeoTexSvx::operator!=(const class 
drawinglayer::texture::GeoTexSvx &) const
-include/editeng/outliner.hxx:999
-_Bool Outliner::IsHoriAlignIgnoreTrailingWhitespace() const
+include/editeng/editeng.hxx:626
+_Bool EditEngine::IsHoriAlignIgnoreTrailingWhitespace() const
 include/filter/msfilter/mstoolbar.hxx:98
  Indent::Indent(_Bool)
 include/formula/opcode.hxx:520
@@ -426,8 +420,6 @@ include/o3tl/typed_flags_set.hxx:348
 typename typed_flags::Self 
operator^=(type-parameter-?-? &,typename typed_flags::Wrap)
 include/o3tl/vector_pool.hxx:83
  o3tl::detail::struct_from_value::type::type()
-include/oox/export/drawingml.hxx:207
-void oox::drawingml::DrawingML::WriteSrcRect(const class 
com::sun::star::uno::Reference 
&,const class rtl::OUString &)
 include/oox/helper/containerhelper.hxx:51
 _Bool oox::ValueRange::operator!=(const struct oox::ValueRange &) const
 include/oox/helper/containerhelper.hxx:99
@@ -444,10 +436,8 @@ include/oox/helper/containerhelper.hxx:123
 typename vector 
>::iterator oox::Matrix::row_end(typename vector >::size_type)
 include/oox/helper/containerhelper.hxx:126
 typename vector 
>::reference oox::Matrix::row_front(typename vector >::size_type)
-include/oox/helper/graphichelper.hxx:148
-class rtl::OUString oox::GraphicHelper::importGraphicObject(const class 
com::sun::star::uno::Sequence &) const
-include/oox/helper/graphichelper.hxx:152
-class rtl::OUString oox::GraphicHelper::importEmbeddedGraphicObject(const 
class rtl::OUString &) const
+include/oox/helper/graphichelper.hxx:142
+class rtl::OUString oox::GraphicHelper::importGraphicObject(const class 
com::sun::star::uno::Referen

[Libreoffice-commits] core.git: chart2/source compilerplugins/clang connectivity/source dbaccess/source desktop/source filter/source framework/source i18nutil/source include/svl include/ucbhelper pyun

2018-03-11 Thread Noel Grandin 
 chart2/source/controller/sidebar/ChartAreaPanel.cxx  |4 -
 chart2/source/model/template/DataInterpreter.cxx |2 
 chart2/source/tools/CachedDataSequence.cxx   |2 
 chart2/source/tools/UncachedDataSequence.cxx |2 
 chart2/source/view/diagram/VDiagram.cxx  |4 -
 compilerplugins/clang/redundantfcast.cxx |   40 +++
 compilerplugins/clang/test/redundantfcast.cxx|9 ++
 connectivity/source/drivers/firebird/StatementCommonBase.cxx |2 
 dbaccess/source/ui/misc/DExport.cxx  |2 
 desktop/source/deployment/inc/dp_ucb.h   |3 
 filter/source/svg/svgdialog.cxx  |2 
 framework/source/services/pathsettings.cxx   |3 
 framework/source/uielement/statusbaritem.cxx |2 
 i18nutil/source/utility/oneToOneMapping.cxx  |   12 +--
 include/svl/zforlist.hxx |2 
 include/ucbhelper/macros.hxx |6 -
 pyuno/source/module/pyuno.cxx|2 
 reportdesign/source/core/sdr/RptObject.cxx   |2 
 sc/source/ui/vba/vbaapplication.cxx  |   12 +--
 sc/source/ui/vba/vbaglobals.cxx  |4 -
 sc/source/ui/vba/vbainterior.cxx |2 
 sc/source/ui/vba/vbaworkbook.cxx |6 -
 sc/source/ui/vba/vbaworksheet.cxx|2 
 sfx2/source/view/classificationcontroller.cxx|2 
 svgio/source/svgreader/svgtools.cxx  |2 
 svtools/source/table/tablecontrol.cxx|2 
 svx/source/svdraw/sdrpaintwindow.cxx |2 
 sw/source/ui/vba/vbadocument.cxx |4 -
 sw/source/ui/vba/vbawindow.cxx   |2 
 sw/source/uibase/dbui/mailmergetoolbarcontrols.cxx   |4 -
 toolkit/source/controls/roadmapentry.cxx |3 
 ucb/source/core/cmdenv.cxx   |5 -
 ucb/source/core/ucbcmds.cxx  |4 -
 ucb/source/sorter/sortdynres.cxx |5 -
 ucb/source/ucp/file/filrset.hxx  |2 
 ucb/source/ucp/file/prov.cxx |4 -
 ucb/source/ucp/ftp/ftpcontentprovider.cxx|6 -
 ucb/source/ucp/ftp/ftpresultsetbase.hxx  |2 
 ucb/source/ucp/tdoc/tdoc_content.cxx |   13 +--
 ucb/source/ucp/tdoc/tdoc_documentcontentfactory.cxx  |5 -
 ucbhelper/source/provider/propertyvalueset.cxx   |2 
 uui/source/passwordcontainer.cxx |5 -
 vbahelper/source/msforms/vbaframe.cxx|2 
 xmlhelp/source/cxxhelp/provider/provider.cxx |6 -
 xmlhelp/source/cxxhelp/provider/resultsetbase.hxx|2 
 xmlhelp/source/treeview/tvfactory.cxx|5 -
 xmlsecurity/source/component/certificatecontainer.cxx|2 
 47 files changed, 125 insertions(+), 93 deletions(-)

New commits:
commit 2f5868c4309d49ad495e0763b5b57d1f7f98e377
Author: Noel Grandin 
Date:   Fri Mar 9 13:59:52 2018 +0200

loplugin:redundantfcast look for redundant copies in return statements

Change-Id: I5f416c865dfe1c36018784246a8007452eb42008
Reviewed-on: https://gerrit.libreoffice.org/50996
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/controller/sidebar/ChartAreaPanel.cxx 
b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
index c057ebc5e0ad..0423aca7e8d1 100644
--- a/chart2/source/controller/sidebar/ChartAreaPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
@@ -112,7 +112,7 @@ XGradient getXGradientForName(const 
css::uno::Reference& xMo
 continue;
 
 if (pGradient->GetName() == rName)
-return XGradient(pGradient->GetGradient());
+return pGradient->GetGradient();
 }
 }
 catch (...)
@@ -163,7 +163,7 @@ XHatch getXHatchFromName(const 
css::uno::Reference& xModel,
 {
 // we need to update the hatch name
 rName = pHatch->GetName();
-return XHatch(pHatch->GetHatch());
+return pHatch->GetHatch();
 }
 }
 }
diff --git a/chart2/source/model/template/DataInterpreter.cxx 
b/chart2/source/model/template/DataInterpreter.cxx
index a29d49afd2c0..940287572b51 100644
--- a/chart2/source/model/template/DataInterpreter.cxx
+++ b/chart2/source/model/template/DataInterpreter.cxx
@@ -297,7 +297,7 @@ Reference< data::XDataSource > SAL_CALL 
DataInterpreter::me