[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Alex Thurgood alex.thurg...@gmail.com changed: What|Removed |Added Depends on||37487 --- Comment #118 from Alex Thurgood alex.thurg...@gmail.com 2011-05-23 23:13:06 PDT --- Nominating 37487 as most annoying bug - crash in Writer on Mac when using drag and drop to copy data from datasource navigator to Writer document. Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Removing DLLPOSTFIX
On Mon, May 23, 2011 at 11:22:28AM -0600, Tor Lillqvist wrote:
If removing the suffix is too much work for 3.5,
Nah, why would it be that much work? If it is agreed that those shared
libraries that use those suffixes are ones that binary extensions don't link
to anyway, let's just do it.
Fine. Most of the code using DLLPOSTFIX in dmakefiles is quite simple and a
quick sed invocation should be enough to get rid of it.
The new gbuild code should not be too difficult to clean either.
The only real difficulties I see will be with these files in
bootstrap/solenv/inc:
_tg_shl.mk
tg_shl.mk
tg_wntx64.mk
with rules such as
SHL$(TNR)VERSIONOBJDEP:=$(VERSIONOBJ:d){$(subst,$(DLLPOSTFIX),_dflt
$(SHL$(TNR)TARGET))}$(VERSIONOBJ:f:s/.o/.obj/)
What do these do exactly ? I guess I can't just rip out the lines containing
DLLPOSTFIX from the above files and expect a build to still work ...
--
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4] Get nice background image back to Mac also on Tiger dmg folder
Christian Lohmaier wrote: The DS_Store references the backgroud image from outside of thedmg - namely from Thorsten's home-directory. But he already created another version (aller guten Dinge sind drei :-)) and sent it to me for checking, and that iteration is correct, find it attached. Thx for the diligent validation - pushed with your ACK to -3-4 as b41854cdbcd0338a99c6d92113d8e9630d5f9a0b (components) Cheers, -- Thorsten pgpSGy1J9mbbe.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Removed GNUism in makefile
2011/5/24 Thorsten Behrens t...@documentfoundation.org: attached patch fixes a build breakage on Mac, in the re-added NLP solver. Three reviews needed for 3-4-0 please. The original commit is a22d8e9fbecfe6f2febdf4f85892f00e48ad0b79 (extensions) +1 from me But what if we don't preserve timestamps? I don't think they important in this case. Cheers, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] build with system bsh breaks
On Mon, May 23, 2011 at 07:46:52AM -0500, Norbert Thiebaud wrote: On Mon, May 23, 2011 at 4:36 AM, David Tardon dtar...@redhat.com wrote: On Sun, May 22, 2011 at 01:12:38AM -0500, Norbert Thiebaud wrote: On Sun, May 22, 2011 at 1:02 AM, David Tardon dtar...@redhat.com wrote: Hi, could someone sign-off this small patch? David, it would be easier if you actually attach the patch :-) Indeed it would :) Seems ok to me +1 Thanks! Pushed into libreoffice-3-4 and libreoffice-3-4-0. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Get nice background image back to Mac also on Tiger dmg folder
My blessing for this patch :) On Tue, 2011-05-24 at 04:44 +0200, Christian Lohmaier wrote: The DS_Store references the backgroud image from outside of thedmg - namely from Thorsten's home-directory. But he already created another version (aller guten Dinge sind drei :-)) and sent it to me for checking, and that iteration is correct, find it attached. Petr: If possible delay tagging of rc2 unttil both are pushed to 3.4.0 branch. Not having the proper branding in the installer for mac would be a pity... ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Alex Thurgood alex.thurg...@gmail.com changed: What|Removed |Added Depends on||37529 --- Comment #119 from Alex Thurgood alex.thurg...@gmail.com 2011-05-24 00:28:55 PDT --- Nominating 37529 as most annoying - crash when using data source navigator in Writer (F4) to browse tree listing of tables in a mysql jdbc driver connected database. Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Removed GNUism in makefile
On Tue, 24 May 2011 09:05:41 +0200 Thorsten Behrens t...@documentfoundation.org wrote: attached patch fixes a build breakage on Mac, in the re-added NLP solver. Three reviews needed for 3-4-0 please. The original commit is a22d8e9fbecfe6f2febdf4f85892f00e48ad0b79 (extensions) Looking good. Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] 3-4 build problem: sw module: ‘class SwDrawView’ has no member named ‘UpdateDrawLayersRegion’
Hi All, Thank you for the help. I had unstaged change in repo that contains svx and I missed updates for that. I am building a clean build, I will come back the result. KAMI 2011/5/20 Michael Meeks michael.me...@novell.com: Hi KAMI, On Fri, 2011-05-20 at 14:44 +0200, Kálmán „KAMI” Szalai wrote: Yesterday issued ./g -f pull -r command and all repos updated. I make clean-ed sw module and rebuilded it. with same fail. after that I did make clean but I have this error. How can I check if my repos are up-to-date? I used status for it. I will try with LibreOfficeLinux distro. Is it problem if I build with Ubuntu/8.04 on 32 and 64 bit? If you did a ./g pull -r already and it succeeded - you're up to date :-) I use ./g branch - to check the branch tags too. On Thu, 2011-05-19 at 05:57 +0200, KAMI911 KAMI911 wrote: /home/libo64/bootstrap/sw/source/core/view/viewsh.cxx:161: error: ‘class SwDrawView’ has no member named ‘UpdateDrawLayersRegion’ A quick git grep for that method shows: svx/inc/svx/svdpntv.hxx: void UpdateDrawLayersRegion(OutputDevice* pOut, const Region rReg, bool bDisableIntersect = false); do you have that ? Is it possible that you have a stale environment from an old configure, and that this causes you to try to build 3.4 against a master build tree ? [ worth starting a completely clean shell when switching compiling of versions ]. HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC] Weekly Report: Wizards....
On Tue, 2011-05-24 at 00:18 +0200, Xisco Faulí wrote: Anyway I spent some time working on the google project last week as well. So far I've already converted ~40 files. Oooh ... can you test the results ? are they working (ie. with the translation stuff stubbed out) ? I assume you're going deep first (ie. get one wizard working), rather than broad - getting all semi-working :-) particularly with automated code translation, depth, then width is best I'm sure [ you may need to improve the translation tool etc. ]. Apart from that, everything is going well and as expected. Great news ! :-) looking forward to your results, good to hit the ground running too ... Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] IA64 architecture
On Sat, 2011-05-21 at 09:42 +0200, Francois Tigeot wrote: Hi all, There are some definitions to support the IA64 architecture in set_soenv.inc and in bootstrap/solenv/inc I suspect nobody is using it on Linux either. I'm using it. Is there any reason to keep IA64 support in the tree ? Leave the Linux IA64 alone please, it works perfectly fine. I've no opinions on the NetBSD one, didn't know ther was any stubs in there for it. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4-0] Removed GNUism in makefile
Thx for the reviews, pushed. -- Thorsten pgp3BYGz1n5u0.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Removed GNUism in makefile
On Tue, 2011-05-24 at 09:05 +0200, Thorsten Behrens wrote: attached patch fixes a build breakage on Mac, in the re-added NLP solver. Three reviews needed for 3-4-0 please. Looks like it got merged to 3-4-0 by some other kind person before I got to it. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4] Get nice background image back to Mac also on Tiger dmg folder
On Tue, 2011-05-24 at 08:29 +0200, Thorsten Behrens wrote: Thx for the diligent validation - pushed with your ACK to -3-4 as b41854cdbcd0338a99c6d92113d8e9630d5f9a0b (components) So - if the mac guys are happy, I'm happy - no way it can be tested elsewhere, and won't break any other platform; so - a tentative ack from me I guess. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] fix for fdo#37370
Hi Please review this fix https://bugs.freedesktop.org/attachment.cgi?id=47096 for https://bugs.freedesktop.org/show_bug.cgi?id=37370.It would have been great to get this into rc2 ( unfortunately I wasn't quick enough ) as this is an extremely annoying bug and makes identifying problems with basic code very difficult Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Illegal operations in connectivity::OSQLParseNode::impl_parseNodeToString_throw
Hi Alex, On Mon, 2011-05-23 at 18:42 +0200, Alexander Thurgood wrote: While attempting to profile a systematic crash on Mac OSX : https://bugs.freedesktop.org/show_bug.cgi?id=37487 I see this in the output of the assembly language instructions : Hmm :-) it seems unlikely that there are truly invalid instructions generated by the compiler [ although compiler bugs are not unknown ], and more likely that the profiling tool is incomplete (to me at least). I have no idea how or if these are handled, presumably by SIGILL ? They would cause a nice shutdown/crash sequence I guess, but I doubt this is the problem. One thing you can do that would be incredibly useful, is to get valgrind running on the mac: this might help: http://www.sealiesoftware.com/valgrind/ For a large set of memory corruption crashers, (and even invalid instructions if they exist), valgrind provides a fantastic debugging harness that can see corruptions at source - way before they cause odd effects (sometimes much later). Any chance of giving that a spin ? [ we would need the log ]. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests
Hi Bjoern, On Mon, 2011-05-23 at 11:40 -0400, Kohei Yoshida wrote: What we decided to do was to just commit the safe fixes to the 3-4 branch and merge them into master in one go Right. Note that many of us were (and still are?) focusing on stabilizing the 3.4 branch and didn't have a working master. So every bit of effort to reduce duplication goes a long way in such situations. Quite - the logical consequence of not doing that is either: a) cherry picking to a diverging branch without build testing or b) having to build test a fix on both master and libreoffice-3-4 There is a lot of angst about non-building master at the moment ;-) so I assume you are asking for b) - which, since it is rather more resource hungry will result in a lower quality product, and more de-motivated developers :-) [ or not ? ] Personally, I can see the attraction to doing one-shot merges of -3-4 to master, after a build test from time to time. I imagine this is why the TSC agreed this, but lets re-visit it this Thursday. Having said that - the one-off horrific delay caused by the (lack of) m106 merge, and thus the big set of missing fixes to master is deadly annoying. Naturally, it is annoying to see work fixes duplicates too - I suppose the best way to fix this is to help kendy (and/or whomever) expedite the m106 merge and back-merge to master - can you help out with that Bjoern ? indications are that it is at a promising stage anyway. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Removing DLLPOSTFIX
On Tue, May 24, 2011 at 8:18 AM, Francois Tigeot ftig...@wolfpond.org wrote:
On Mon, May 23, 2011 at 11:22:28AM -0600, Tor Lillqvist wrote:
If removing the suffix is too much work for 3.5,
Nah, why would it be that much work? If it is agreed that those shared
libraries that use those suffixes are ones that binary extensions don't link
to anyway, let's just do it.
Fine. Most of the code using DLLPOSTFIX in dmakefiles is quite simple and a
quick sed invocation should be enough to get rid of it.
The new gbuild code should not be too difficult to clean either.
The only real difficulties I see will be with these files in
bootstrap/solenv/inc:
_tg_shl.mk
tg_shl.mk
tg_wntx64.mk
with rules such as
SHL$(TNR)VERSIONOBJDEP:=$(VERSIONOBJ:d){$(subst,$(DLLPOSTFIX),_dflt
$(SHL$(TNR)TARGET))}$(VERSIONOBJ:f:s/.o/.obj/)
What do these do exactly ?
SHL$(TNR)VERSIONOBJDEP
The TNR variable gets replaced by mkunroll - i.e. the makefile you're
looking at is not the one that is actually used, but a template for
others.
the actual template will contain SHL1VERSIONOBJDEP, SHL2VERSIONOBJDEP,
$(VERSIONOBJ:d)
:d means directory portion of the path in NAME,
$(VERSIONOBJ:f:s/.o/.obj/)
:f → filename portion of the file, is combined with the subsitution
(:s) of .o → .obj
$(subst,$(DLLPOSTFIX),_dflt $(SHL$(TNR)TARGET))
alternate way of doing a substitution
$(VERSIONOBJ:f:s/.o/.obj/) can also be written as
$(subst,.o,.obj $(VERSIONOBJ:f))
i.e. it replaces $(DLLPOSTFIX) in $(SHL$(TNR)TARGET) by _dflt
$(DLLPOSTFIX) in $(SHL$(TNR)TARGET) is replaced by _dflt
last but not least foo{bar}baz means:
for every token in bar prepend foo, and append baz, i.e. evaluate to
foobar1baz foobar2baz foobar3baz if bar actually results in bar1
bar2 bar3
I guess I can't just rip out the lines containing
DLLPOSTFIX from the above files and expect a build to still work ...
Nope, that above recipe is too late/only a fraction of the situations
that need to be adjusted. But for a start setting DLLPOSTFIX to in
the platform-specific macros should work.
ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4-0] Get nice background image back to Mac also on Tiger dmg folder
Michael Meeks wrote: So - if the mac guys are happy, I'm happy - Thx, pushed to -3-4-0 Cheers, -- Thorsten pgpiW0kNhNVxQ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific DLL suffix usefulness
On Sun, 2011-05-22 at 11:43 -0600, Tor Lillqvist wrote:
What I would like to know is if there's still a reason to use this suffix
in 2011.
Only backward compatibility of binary extensions
Extensions aren't supposed to link (or be able to link) against
DLLPOSTFIX libs AFAIR, they're only supposed to be able to directly link
against the ure libs that start (under Unix) with lib. Those are
conveniently installed in /path/to/install/ure/lib for perusal, and
there are no uses of DLLPOSTFIX in there.
One gotcha is that tools/inc/tools/solar.h needs to be tweaked, etc. for
any dlopen stuff that libreoffice does. IIRC if you cock this up, it may
appear to work up until you attempt to open one of factory dialogs
e.g. format-character in calc and then it'll fail. Lazy uno porting
guide points out any gotchas like that.
IMO, a consistent DLLPOSTFIX name is probably better than removing it
totally, to avoid e.g. something like libCOMMONNAME${DLLPOSTFIX}.so
becoming libCOMMONNAME${DLLPOSTFIX}.so colliding painfully with some
common system lib like libCOMMON.so when linking or with the effectively
non-hierarchal flat rpm autorequires/provides.
Different DLLPOSTFIX files suggest that at some stage or other it was
desirable to be able to have the .sos from different architecture
side-by-side in the same dir. Maybe from an era before the separate arch
dirs in the solver dir, dunno.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Removing DLLPOSTFIX
On Tue, 2011-05-24 at 12:04 +0200, Christian Lohmaier wrote: Nope, that above recipe is too late/only a fraction of the situations that need to be adjusted. But for a start setting DLLPOSTFIX to in the platform-specific macros should work. If we can get a from-clean build with DLLPOSTFIX set to , check that it doesn't affect the ure/ libraries, and of course that it still runs - then I'm well up for doing this :-) Then of course, we can start to remove its usage around the place later to clean up. How does that sound ? any objections Bjoern ? Regards, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for fdo#37370
On Tue, 2011-05-24 at 10:42 +0100, Noel Power wrote: Please review this fix https://bugs.freedesktop.org/attachment.cgi?id=47096 for https://bugs.freedesktop.org/show_bug.cgi?id=37370.It would have been great to get this into rc2 ( unfortunately I wasn't quick enough ) as this is an extremely annoying bug and makes identifying problems with basic code very difficult Looks odd to me - this was not necessary in the past (at least comparing with -3-3 and so on) - I suspect there is a deeper and more interesting problem we're just band-aiding. Still - looks harmless, so I've committed to the -3-4 branch for you. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for fdo#37370
On 24/05/11 11:36, Michael Meeks wrote: Looks odd to me - this was not necessary in the past (at least comparing with -3-3 and so on) - I suspect there is a deeper and more interesting problem we're just band-aiding. yes, resources from basic.srs were merged previously into ofa[en].res but also existed in sb[en].res, I would guess the problem stems from a partial removal of this duplication ( from m103 or whatever 3.4 is based on ) Not knowing where to start I spent a long time chasing this. In the end I found this is fixed in m106, knowing where to look at least it was easy to find the code to change ( the alternative was to modify the build to include basic.srs in ofa[en].res. When looking in m106 I noticed also some code doing a similar trick for svt[en].res, it's not clear if this change is also necessary for 3.4 ( but then again I didn't hear any problems in that area ) so either it's not an issue or we aren't getting the necessary errors to notice it. Still - looks harmless, so I've committed to the -3-4 branch for you. thanks, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] master patch review process ...
On Mon, 2011-05-23 at 17:37 +0200, Bjoern Michaelsen wrote: Sure, still I think we should keep commits on master and only cherrypick back to release. I'm a fan of this as well FWIW, its what I do by default on all the various projects I work on, push to master, backport back. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] breathing master
On Mon, 2011-05-23 at 21:03 -0500, Norbert Thiebaud wrote: accumulate the output of each failed modules into a single file. ... I need to adjust the tinderbox script to take advantage of that new file. ... Sounds great, if the mails arrive with the error inline in it that'll help massively. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for fdo#37370
Michael Meeks píše v Út 24. 05. 2011 v 11:36 +0100: On Tue, 2011-05-24 at 10:42 +0100, Noel Power wrote: Please review this fix https://bugs.freedesktop.org/attachment.cgi?id=47096 for https://bugs.freedesktop.org/show_bug.cgi?id=37370.It would have been great to get this into rc2 ( unfortunately I wasn't quick enough ) as this is an extremely annoying bug and makes identifying problems with basic code very difficult Looks odd to me - this was not necessary in the past (at least comparing with -3-3 and so on) - I suspect there is a deeper and more interesting problem we're just band-aiding. Still - looks harmless, so I've committed to the -3-4 branch for you. +1 Looks fine to me. We need one more review to get it into the libreoffice-3-4-0 branch for 3.4.0-rc2. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests
Hi Michael, On Tue, 24 May 2011 10:52:29 +0100 Michael Meeks michael.me...@novell.com wrote: Note that many of us were (and still are?) focusing on stabilizing the 3.4 branch and didn't have a working master. Which is just plain wrong and needs immediate fixing. Keeping master buildable must be as high in priority as doing that with the release branch. Otherwise we need to be honest about it and closing master during releases, because there is no value in it for either new or old developers as is. Quite - the logical consequence of not doing that is either: a) cherry picking to a diverging branch without build testing orb) having to build test a fix on both master and libreoffice-3-4 There is a lot of angst about non-building master at the moment ;-) so I assume you are asking for b) - which, since it is rather more resource hungry will result in a lower quality product, and more de-motivated developers :-) [ or not ? ] No, it is not. Volume of patches for the release branch should be low. Or at least much lower than for master. Taking ten patches, reviewing them, applying them to master, building from scratch and subsequenttesting is not more work than doing that for one patch. It is much less work than taking one patch at a time and reviewing it alone on the release branch only. A full build without ccache needs 1 hour 5 min here on average dev hardware. With ccache its down to ~15 minutes. All it needs is a bit of coordination. Leaving master mostly unattended during releases will just hurt us seriously in the long run. Hunting down issues over longer sets of changes just costs resources. What is even more expensive are the things that go in and cause issues which are totally unnoticed. Naturally, it is annoying to see work fixes duplicates too - I suppose the best way to fix this is to help kendy (and/or whomever) expedite the m106 merge and back-merge to master - can you help out with that Bjoern ? indications are that it is at a promising stage anyway. Indeed: There is little use in joining me in there as of now. However, already commited myself to merge in cws gnumake4. We will need to see what we can do with the other unmerged cws. Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] master patch review process ...
On Tue, May 24, 2011 at 12:08:50PM +0100, Caolán McNamara wrote: On Mon, 2011-05-23 at 17:37 +0200, Bjoern Michaelsen wrote: Sure, still I think we should keep commits on master and only cherrypick back to release. I'm a fan of this as well FWIW, its what I do by default on all the various projects I work on, push to master, backport back. Let me add a +1 here Like Caolán, this is most of the projects I work on manage their trunk/stable branches. This way we can be sure -master as all the bleeding edge stuff and fixes and the stable release branch only relevant fixes or limited feature ports. No need to do expensive release branch - master merges. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4-0] Updated galaxy mimetype toolbar icons
Petr Mladek píše v Út 24. 05. 2011 v 12:46 +0200: Thorsten Behrens píše v Po 23. 05. 2011 v 12:56 +0200: Michael Meeks wrote: These files changed size from 32x32 to 26x26 in this - that is what you wanted ? Yes. Pushed to 3-4 - two more reviews for -3-4-0 please. Looks good = +1 Got approval also from Fridrich = pushed into libreoffice-3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] new crashers on master
Hi all, on master state: = main repo = * master 9f619ad make dev-install use smoketest = artwork = * master be42c3c replace res/commandimagelist with cmd in artwork = base = * master 3152eef class SvTreeEntryList is no longer dependant on class List = calc = * master 551cca5 Fix an old remove DECLARE_LIST bug. Could be related to fdo#37429 = components = * master 19ed365 fdo#35728: fix GridControl crash = extensions = * master ce398bb replace res/commandimagelist with cmd in extensions = extras = * master 501c772 Add the wntgcc directories = filters = * master 251acc2 WaE: for older gcc = help = * master 042b969 Fix bug fdo36158 UI:FindReplace dialog Notes instead of Comments = impress = * master 0b5ac43 Remove List from ImpGetUndoStrings ImpGetRedoStrings = libs-core = * master be49f93 Resolves: fdo#33638 add extra level of language tag matching = libs-extern = * master 6042d4a -ldl is linux only and remove -lc from the flags too = libs-extern-sys = * master 04a870f Drop OS2 = libs-gui = * master b620170 Resolves: fdo#36940 use natural string sorter as default svtools string sorter = postprocess = * master cf66ba0 pack commandimages from cmd/ = sdk = * master 080fbc1 Add the wntgcc directories = testing = * master 8dd9b81 use links in smoketest install too = ure = * master 9f5e6d1 Use 'i' prefix for import library only with MSVC = writer = * master 6d192be make this a non-leaky singleton The subsequenttests: forms.OPatternModel (and possibly following forms unoapi tests) complex.sfx2.DocumentProperties cause new crashes on master. The subsequenttest: complex.sfx2.DocumentProperties fails. Since master state: = main repo = * master 727609c accumulate the output of modules in error in build_error.log = artwork = * master be42c3c replace res/commandimagelist with cmd in artwork = base = * master 3152eef class SvTreeEntryList is no longer dependant on class List = calc = * master 4a99f31 Remove some extra #incude tools/pstm.hxx = components = * master 19ed365 fdo#35728: fix GridControl crash = extensions = * master ce398bb replace res/commandimagelist with cmd in extensions = extras = * master 501c772 Add the wntgcc directories = filters = * master dbc0ea9 can only be true with unsigned values = help = * master 042b969 Fix bug fdo36158 UI:FindReplace dialog Notes instead of Comments = impress = * master f214507 Remove some extra #incude tools/pstm.hxx = libs-core = * master 8f0037d don't need to set it to 0 twice = libs-extern = * master 6042d4a -ldl is linux only and remove -lc from the flags too = libs-extern-sys = * master 725cf40 Cross-compilation support and iOS in particular = libs-gui = * master 71729eb Remove some extra #incude tools/pstm.hxx = postprocess = * master cf66ba0 pack commandimages from cmd/ = sdk = * master 080fbc1 Add the wntgcc directories = testing = * master 8dd9b81 use links in smoketest install too = ure = * master 08b91ed Add iOS = writer = * master e09bce4 Remove some extra #incude tools/pstm.hxx the subsequenttests: forms.OImageControlModel (and possibly following forms unoapi tests) cause new crashers on master. Also LibreOffice is barfing out a lot of: LibreOffice: Using system memory allocator. LibreOffice: This is for debugging only. To disable, LibreOffice: unset the environment variable G_SLICE. since then. The last good master state was: = main repo = * master 9f619ad make dev-install use smoketest = artwork = * master be42c3c replace res/commandimagelist with cmd in artwork = base = * master 3152eef class SvTreeEntryList is no longer dependant on class List = calc = * master dea06b7 Replace List for std::vectorString. = components = * master 19ed365 fdo#35728: fix GridControl crash = extensions = * master ce398bb replace res/commandimagelist with cmd in extensions = extras = * master 501c772 Add the wntgcc directories = filters = * master a8833d2 fdo#35667: renable complex.unoxml.RDFRepositoryTest checkSPARQL() as it works = help = * master 042b969 Fix bug fdo36158 UI:FindReplace dialog Notes instead of Comments = impress = * master 0b5ac43 Remove List from ImpGetUndoStrings ImpGetRedoStrings = libs-core = * master 1151eaf fdo#35663: be more explicit on asserts = libs-extern = * master 6042d4a -ldl is linux only and remove -lc from the flags too = libs-extern-sys = * master 04a870f Drop OS2 = libs-gui = * master 4c8d488 List-vector change incorrect return index = postprocess = * master cf66ba0 pack commandimages from cmd/ = sdk = * master 080fbc1 Add the wntgcc directories = testing = * master 93bd669 Fix bug fdo36158
Re: [Libreoffice] Removing DLLPOSTFIX
On Tue, May 24, 2011 at 11:29:04AM +0100, Michael Meeks wrote: On Tue, 2011-05-24 at 12:04 +0200, Christian Lohmaier wrote: Nope, that above recipe is too late/only a fraction of the situations that need to be adjusted. But for a start setting DLLPOSTFIX to in the platform-specific macros should work. If we can get a from-clean build with DLLPOSTFIX set to , check that it doesn't affect the ure/ libraries, and of course that it still runs - then I'm well up for doing this :-) I'm afraid, we'll have to settle to some non-empty string then. I tried a build with known-working sources (a snapshot of master) and it failed somwhere in javaunohelper with a wrong argument to cp. Then of course, we can start to remove its usage around the place later to clean up. How does that sound ? any objections Bjoern ? Sounds good, albeit wouldn't work. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Removing DLLPOSTFIX
I'm afraid, we'll have to settle to some non-empty string then. Nah, that is fairly pointless. Either we remove it completely or not at all. Isn't the whole purpose of removing it to make the makefilery simpler? If we keep all the $(DLLPOSTFIX) instances there, but just happen to use the same value for it on all platforms (or am empty value), we gain nothing. I tried a build with known-working sources (a snapshot of master) and it failed somwhere in javaunohelper with a wrong argument to cp. Well, that will just have to be fixed then;) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests
Hi Bjoern, On Tue, 2011-05-24 at 13:44 +0200, Bjoern Michaelsen wrote: Which is just plain wrong and needs immediate fixing. Keeping master buildable must be as high in priority as doing that with the release branch. I suggest we cool off and discuss this, in a more measured way, in the TSC meeting on Thursday, deferring until then. It would also help if you have a concrete proposal that can be discussed. Aspirations as to mandatory build-ability (on every platform?) are inspiring of course, but hard to action. It would also be good to spend some time thinking through both benefits, and critically the costs of whatever you propose, to present there. Any hard data: analysis of reported build failures on the list, and their isolated causes (where they can be identified), etc. would also be extremely useful so we have some real data to discuss. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new crashers on master
On Tue, 2011-05-24 at 13:45 +0200, Bjoern Michaelsen wrote: on master state: The subsequenttests: forms.OPatternModel (and possibly following forms unoapi tests) complex.sfx2.DocumentProperties cause new crashes on master. How are subsequenttests run again ? there appears to be no related rule in the toplevel makefile in bootstrap's master, or am I missing something - is it hooked into 'make check' somehow ? the subsequenttests: forms.OImageControlModel (and possibly following forms unoapi tests) cause new crashers on master. Also LibreOffice is barfing out a lot of: LibreOffice: Using system memory allocator. LibreOffice: This is for debugging only. To disable, LibreOffice: unset the environment variable G_SLICE. since then. Are you certain that this (along with the crash?) doesn't just stem from a dirty shell environment you're running the tests in - in this case with G_SLICE enabled, perhaps from a sourced ooenv ? Actually, if the ooinstall -l thing (that Caolan just reverted, and that apparently breaks java) was being used, I can imagine that might affect some tests. Not being funny or anything but: commit 8dd9b81dbefb8b8afc34153285a3e39323d2e49a Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Mon May 23 16:01:04 2011 +0200 use links in smoketest install too diff --git a/smoketestoo_native/makefile.mk b/smoketestoo_native/makefile.mk index 31d67d7..799fe9c 100755 --- a/smoketestoo_native/makefile.mk +++ b/smoketestoo_native/makefile.mk @@ -58,6 +58,6 @@ CPPTEST_LIBRARY = $(SHL1TARGETN) localinstall : $(RM) -r $(installationtest_instpath) $(MKDIRHIER) $(installationtest_instpath) -ooinstall $(installationtest_instpath)/opt +ooinstall -l $(installationtest_instpath)/opt cpptest : localinstall .END Sounds like the cause of at least that debug message. If you did changes in the affected areas please fix ASAP! And, that's not how it works generally. If you want something doing mostly, you get to (un)do it yourself. Sometimes we get to twit each other in a friendly way too for our mistakes, and encourage each other to improve :-) ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for fdo#37390
Cedric Bosdonnat píše v Po 23. 05. 2011 v 21:47 +0200: Hi all, On Mon, 2011-05-23 at 14:06 +0200, Cedric Bosdonnat wrote: Don't apply that one... I had remorse all the week-end for all the non-conforming documents that may loose that property. I'll hack a better patch to still read the old property. Here is an augmented patch handling the old attribute in import and exporting the valid one. Could anyone review and push it to 3.4 and 3.4.0? Looks fine = pushed into libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4id=97c995a22c1602679a3e386f994a20b23d07f429 We need two more reviews for 3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Mono URE bootstrapping inside and outside web service
I am not sure whether this is the right place for a question like this, but I don't know any better place. I have a small CSharp application which generates reports using Libreoffice. It has a small GTK interface and works without much problems on Ubuntu 11.04 with the bundled Libreoffice 3.3.2. Now I would like to provide the same functionality over SOAP, so I created a WebService project. It uses the same libraries which contain the Libreoffice bootstrapping. The code can be found at http://pastebin.com/4u4mYRqG When I run the WebService, it crashes at the location where I want to cast the object created by componentFactory.createInstanceWithContext(com.sun.star.frame.Desktop, context); with the message Error: A type could not be loaded: unoidl.com.sun.star.frame.XComponentLoader. The output is at http://pastebin.com/QQJEUR5A The only idea I have about the differences between the two versions is, that the web service is maybe running a headless Libreoffice, and that could be causing the problem. The rest of the programs is quite the same concerning the Libreoffice connection. Any ideas why this happens and how it can be corrected? Greetings, Wolfgang. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for fdo#37390
On Tuesday 24 of May 2011, Petr Mladek wrote: Cedric Bosdonnat píše v Po 23. 05. 2011 v 21:47 +0200: Hi all, On Mon, 2011-05-23 at 14:06 +0200, Cedric Bosdonnat wrote: Don't apply that one... I had remorse all the week-end for all the non-conforming documents that may loose that property. I'll hack a better patch to still read the old property. Here is an augmented patch handling the old attribute in import and exporting the valid one. Could anyone review and push it to 3.4 and 3.4.0? Looks fine = pushed into libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4 id=97c995a22c1602679a3e386f994a20b23d07f429 We need two more reviews for 3-4-0 branch. +1 -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Illegal operations in connectivity::OSQLParseNode::impl_parseNodeToString_throw
Hi there, On Tue, 2011-05-24 at 12:32 +0200, Alexander Thurgood wrote: valgrind --tool=memcheck --num-callers=50 --trace-children=yes ./MacOS/swriter 21 | tee /Users/alex/valgrind.log is swriter the shell-script ? I would expect needing to use soffice.bin or somesuch (?). I guess adding some Mac / valgrind tips to: http://wiki.documentfoundation.org/Development/How_to_debug might help if you have some cycles ? :-) Thanks !, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new crashers on master
Hi Michael, On Tue, 24 May 2011 13:22:44 +0100 Michael Meeks michael.me...@novell.com wrote: How are subsequenttests run again ? there appears to be no related rule in the toplevel makefile in bootstrap's master, or am I missing something - is it hooked into 'make check' somehow ? source the env file, run subsequenttests (which is $SOLENV/bin/subsequenttests). Are you certain that this (along with the crash?) doesn't just stem from a dirty shell environment you're running the tests in - in this case with G_SLICE enabled, perhaps from a sourced ooenv ? subsequenttests are always run from a ooenv environment, however the errors are new. Maybe somebody change soenv? Actually, if the ooinstall -l thing (that Caolan just reverted, and that apparently breaks java) was being used, I can imagine that might affect some tests. Not being funny or anything but: Sounds like the cause of at least that debug message. Might be. I will test again with the current state. As at least _some_ of the OForms stuff broke before the dev-install changes, there is a different issue at hand here. Mind you, I dont bother about a failed test now and then on master, but a new crasher is something different. Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Removing DLLPOSTFIX
On Tue, May 24, 2011 at 1:58 PM, Tor Lillqvist tlillqv...@novell.com wrote: I'm afraid, we'll have to settle to some non-empty string then. Nah, that is fairly pointless. Either we remove it completely or not at all. Isn't the whole purpose of removing it to make the makefilery simpler? Would also help with cross-compiling on Mac. When the names would be the same for intel and PPC, you could build an universal binary using lipo, i.e. first build them seperately and then just combine the files. (well, in theory at least) If we keep all the $(DLLPOSTFIX) instances there, but just happen to use the same value for it on all platforms (or am empty value), we gain nothing. But setting DLLPOSTFIX to a random string and building will at least allow to identify other places in the code where the current ones are expected.. I tried a build with known-working sources (a snapshot of master) and it failed somwhere in javaunohelper with a wrong argument to cp. Well, that will just have to be fixed then;) Yes, stuff like this needs to be done before just removing DLLPOSTFIX from all makefiles :-) ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fix for fdo#37390
Lubos Lunak wrote: Looks fine = pushed into libreoffice-3-4 branch, see http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4 id=97c995a22c1602679a3e386f994a20b23d07f429 We need two more reviews for 3-4-0 branch. +1 ACK from me, too. -- Thorsten pgpl4XsGCaTw9.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] cppunit test fails in lotuswordpro / breaks the build on Mac/PPC
Hi Caolán, *, On Mon, May 23, 2011 at 6:02 PM, Caolán McNamara caol...@redhat.com wrote: On Mon, 2011-05-23 at 16:45 +0100, Michael Meeks wrote: [lotuswordpro on PPC] This should now work correctly without disabling/hackery (does in Linux/PPC anyway). It does so on Mac/PPC as well - thanks a lot! It also actually imports the two test-files as the linux version does (i.e. apparently misplaced rectangle, but the text is there) ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix for fdo#37387
Andras Timar píše v Ne 22. 05. 2011 v 07:46 +0200: I pushed your patch to 3-4. I looks better on the few locales I tested. We need two more reviews for 3-4-0 for http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id=335cc3bb837a671b3d6644bf9b4bc13a116102da and http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id=27875f65e2c1953fbf636af32556833c44849f53 +1 I have just tested both changes. They look fine to me. We need one more review for the 3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4-0] fix for fdo#37390
Now with the right header tag... -- Thorsten pgpB5VWVkPFoH.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Illegal operations in connectivity::OSQLParseNode::impl_parseNodeToString_throw
Le 24/05/11 14:33, Michael Meeks a écrit : Hi Michael, is swriter the shell-script ? I would expect needing to use soffice.bin or somesuch (?). Yes, but I have also tried the soffice.bin, soffice script and various other paths combinations to no avail. In particular, valgrind doesn't like the soffice.bin binary : valgrind /Applications/LibreOffice.app/Contents/program/soffice valgrind: /Applications/LibreOffice.app/Contents/program/soffice: cannot execute binary file valgrind /Applications/LibreOffice.app/Contents/program/soffice.bin valgrind: /Applications/LibreOffice.app/Contents/program/soffice.bin: cannot execute binary file Other attempts : valgrind /Applications/LibreOffice.app valgrind: /Applications/LibreOffice.app/Contents/MacOS/LibreOffice: No such file or directory in which, as you can see, it is looking for the LibreOffice binary (ho hum), which of course it can't find because we call it soffice I guess adding some Mac / valgrind tips to: http://wiki.documentfoundation.org/Development/How_to_debug might help if you have some cycles ? :-) If I ever get to run, no problem, I'll add an entry, for the moment though, I'm stuck and shall go on a documentation hunt for how valgrind is supposed to work on Mac Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Review] Patch for fdo#37323
Kohei Yoshida píše v Pá 20. 05. 2011 v 11:52 -0400: On Fri, 2011-05-20 at 11:33 -0400, Kohei Yoshida wrote: The patch looks good. You have my review pushed to the -3-4 branch. I forgot to say it would be nice to push this to the 3-4-0 branch as well. It needs two more sign-off's. Looks fine. Got one more approval from Michael Meek on irc = pushed into libreoffice-3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Review][PUSHED-3-4-0] Patch for fdo#37323
Kohei Yoshida píše v Pá 20. 05. 2011 v 11:52 -0400: On Fri, 2011-05-20 at 11:33 -0400, Kohei Yoshida wrote: The patch looks good. You have my review pushed to the -3-4 branch. I forgot to say it would be nice to push this to the 3-4-0 branch as well. It needs two more sign-off's. Looks fine. Got one more approval from Michael Meek on irc = pushed into libreoffice-3-4-0 branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Illegal operations in connectivity::OSQLParseNode::impl_parseNodeToString_throw
Hi *, On Tue, May 24, 2011 at 3:43 PM, Alexander Thurgood alex.thurg...@gmail.com wrote: Le 24/05/11 14:33, Michael Meeks a écrit : Hi Michael, is swriter the shell-script ? I would expect needing to use soffice.bin or somesuch (?). Yes, but I have also tried the soffice.bin, soffice script There is no soffice script on Mac, as on Mac there is no searching for libraries in a set of paths, but only hardcoded lookup. soffice = soffice.bin, they are identical. and various other paths combinations to no avail. In particular, valgrind doesn't like the soffice.bin binary : valgrind /Applications/LibreOffice.app/Contents/program/soffice valgrind: /Applications/LibreOffice.app/Contents/program/soffice: cannot execute binary file LibreOffice.app/Contents/MacOS/soffice will do. (well, not sure whether valgrind likes it, but this is the way to start LO from the terminal and with gdb at least) ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED-3-4-0] Patch for fdo#37323
Kohei Yoshida wrote: I forgot to say it would be nice to push this to the 3-4-0 branch as well. It needs two more sign-off's. Seen this pushed by Petr. -- Thorsten pgp9kzi1iJ0ru.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] GTK+ integration
On Tue, 2011-05-24 at 14:14 +0100, Michael Meeks wrote: Sure, I've pushed it to the -3-4 branch as well. Ho hum; I've reverted it there. I'm getting some funky debug output on the console: Warning: -writer is deprecated. Use --writer instead. (soffice:14656): GLib-GObject-WARNING **: invalid cast from `GtkToggleToolButton' to `GtkButton' (soffice:14656): Gtk-CRITICAL **: IA__gtk_button_set_relief: assertion `GTK_IS_BUTTON (button)' failed (soffice:14656): Gtk-CRITICAL **: IA__gtk_widget_style_get: assertion `GTK_IS_WIDGET (widget)' failed Doesn't look ideal :-) Whacking a breakpoint in g_logv gives me some nice traces: #2 0xb2ac69c5 in g_type_check_instance_cast () from /lib/libgobject-2.0.so.0 #3 0xb33403e4 in NWEnsureGTKToolbar (nScreen=0) at /data/opt/libreoffice/bootstrap/clone/libs-gui/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx:4007 #4 0xb333dc56 in NWGetToolbarRect (nScreen=0, nPart=100, aAreaRect=...) at /data/opt/libreoffice/bootstrap/clone/libs-gui/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx:3300 #5 0xb3334f2c in GtkSalGraphics::getNativeControlRegion (this=0x891a380, nType=100, nPart=100, rControlRegion=..., nState=9, aValue=..., rCaption=..., rNativeBoundingRegion=..., rNativeContentRegion=...) at /data/opt/libreoffice/bootstrap/clone/libs-gui/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx:982 and #2 0xb29dba8d in g_return_if_fail_warning () from /lib/libglib-2.0.so.0 #3 0xb2edc8f5 in gtk_button_set_relief () from /usr/lib/libgtk-x11-2.0.so.0 #4 0xb33403f0 in NWEnsureGTKToolbar (nScreen=0) at /data/opt/libreoffice/bootstrap/clone/libs-gui/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx:4007 eg. - apparently it is not a GtkButton :-) Any chance of some digging ? Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Illegal operations in connectivity::OSQLParseNode::impl_parseNodeToString_throw
Le 24/05/11 15:53, Christian Lohmaier a écrit : Hi Christian, LibreOffice.app/Contents/MacOS/soffice will do. (well, not sure whether valgrind likes it, but this is the way to start LO from the terminal and with gdb at least) Valgrind doesn't like it :-/, it gives me cannot execute binary file. I too, have no problem with starting LO from the terminal, it is just finding out why valgrind doesn't want to that is the problem at the moment :-)) I suspect that there may be something bit related here. It appears from questions here and there on KDE debugging that you have to use 32bit valgrind for 32bit executables, and 64bit valgrind for 64bit ones. Since I installed valgrind via ports, without any special options, I don't know which of the two it installed, but I'm assuming 64bit and thus this might be the root cause of the problem, or alternatively, it is because I am running the OS in 64bit mode. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Need help with the Bug 33092 – Autocomplete display double character for this word [CTL / Thai]
Hi, We've been trying to fix this bug https://bugs.freedesktop.org/show_bug.cgi?id=33092 However, we don't know whether the approach that we've tried is the right thing, so can you please review the following idea. Step to reproduced the bug: 1.Use Thai locale, open a blank Writer document 2.Switch keyboard to Thai. 3.Type text “มิถุ” by press “,b5”. 4.The function autocomplete will display the full word "มิถุนายน" (June in Thai) 5. Press enter to accept the suggestion, and another enter for readability 6. Repeat the step 3-5 once Expect result: There should be two lines of “มิถุนายน”. Real result: There are two lines of “มิถุนายน” but the first one has a doubled/overlapped cluster. See below. It is strange that the second (and later) autocompletion of the same word doesn't trigger the same bug. Look at the content.xml style:style style:name="T1" style:family="text" style:text-properties style:language-complex="th" style:country-complex="TH"/ /style:style snip. text:p text:style-name="P1"มิถtext:span text:style-name="T1"ุนายน/text:span/text:p text:p text:style-name="P1"text:span text:style-name="T1"มิถุนายน/text:span/text:p There is an auto-style T1 which switch the locale to th. In the 2nd paragraph, the auto-style is placed around the autocompleted word. However, in the first line, the auto-style is placed just before the suggestion. Moreover, for the word มิถุนายน, the auto-style happen to be placed inside a cluster ถ+ ุ , which result in ugly display of the cluster. Because the display function still cannot handle this case well. We've tried removing the whole auto-style T1 from the ODT and everything is fine again. Then we couldn't find a reason why LO need to put the auto-style while autocomplete in the first place. Because the user is typing in a locale, then autocompletion of the same locale is fired. So the whole text must be in the same locale. Why put and auto-style to switch to the same locale? So we've try an experimental patch (https://bugs.freedesktop.org/attachment.cgi?id=45511 ) that get rid of the auto-style when autocomplete altogether. We've tried it with no side-effect as of now. But I don't know whether actually the auto-style is needed for a reason we don't understand. Any idea? Thanks, Samphan. -- _/|\_ Samphan Raruenrom. Osdev - Open Source Development Co., Ltd. สัมพันธ์ ระรื่นรมย์. โอเอสเด็บ - บริษัท โอเพนซอร์สดิเวลอปเมนต์ จำกัด tel: +66 2 269 9889 web: osdev.co.th twitter: @osdev facebook: facebook.com/osdev ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new crashers on master
On Tue, 2011-05-24 at 14:40 +0200, Bjoern Michaelsen wrote: missing something - is it hooked into 'make check' somehow ? source the env file, run subsequenttests (which is $SOLENV/bin/subsequenttests). I added a 'make test' in the toplevel, which hopefully is somewhat visible - it is after the 'make check' rule. I wonder - is there a useful distinction there ? or should we do both in make check ? ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Review][PUSHED] patch for disappearing autofilter when inserting/deleting sheets
Autofilters disappeared if a sheet was deleted or inserted because we forgot to update the db data. Looks good to me pushed to the -3-4 branch. If two more people agree, I'd like this pushed to the -3-4-0 branch as well. Ack-ed, cherry-picked pushed to 3-4-0 (the good, the bad the ugly) B. -- \ Katarina Machalkova \\\__o LibO developer __\\\'/_ hedgehog painter signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new crashers on master
On Tue, 2011-05-24 at 15:35 +0100, Michael Meeks wrote: On Tue, 2011-05-24 at 14:40 +0200, Bjoern Michaelsen wrote: missing something - is it hooked into 'make check' somehow ? source the env file, run subsequenttests (which is $SOLENV/bin/subsequenttests). I added a 'make test' in the toplevel, which hopefully is somewhat visible - it is after the 'make check' rule. I wonder - is there a useful distinction there ? or should we do both in make check ? If the make test runs the subsequent-tests it should be just renamed to make check now IMO if the make dev-install runs the smoketest. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new crashers on master
On Tue, 2011-05-24 at 13:22 +0100, Michael Meeks wrote: Actually, if the ooinstall -l thing (that Caolan just reverted, and that apparently breaks java) was being used. I hadn't actually reverted it, just noted it as the jvmfwk breaker for the smoketest during make dev-install. I've now pushed a fix for resolving symbolic links in jvmfwk which clears this. C. (As an aside, I need to collect up all the current dodgy looking getSymbolicLink using code and centralize it into one not-quite-so-busted place) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SUDAN UCUZ KAMPANYASI
Untitled Document Listeden Çıkmak için b...@listedencikar.com adresine Çıkar başlıklı Boş bir e-posta gönderiniz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Illegal operations in connectivity::OSQLParseNode::impl_parseNodeToString_throw
Le 24/05/11 16:19, Alexander Thurgood a écrit : Well, whadya know ? I'm in business :-) I reinstalled valgrind with : sudo port install valgrind +universal those ahem insert expletive 32bit binaries get me everytime. Now it works. So off I go to investigate. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new crashers on master
Hi Caolán, On Tue, 24 May 2011 15:42:30 +0100 Caolán McNamara caol...@redhat.com wrote: If the make test runs the subsequent-tests it should be just renamed to make check now IMO if the make dev-install runs the smoketest. The original gbuild toplevel makefile (currently at GNUmakefile.mk and hopefully our only toplevel makefile) as all gbuild module makefiles have: - make allandcheck (which is build and run unittest and the default goal) - make all (which is build only and _not_ the default) - make check (just rerun unittests) - make subsequentcheck (run subsequenttests) Im not too happy with all not being the default goal, but when we change the names, lets try to keep the new names of the goals consistent (and I dont care to much in which way). And thanks for the Java fixes! Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] fdo#35345: more Calc (auto)filter evilness
Ladies gentlemen,
attached is the patch with (hopefully the final) fix for $subject. I'd like to
push it to 3-4 and considering the fact that some data loss is involved,
prolly also to 3-4-0 although I'm not entirely positive about that.
The orig. patch from IBM Symphony folks took just some scenarios into account
and happily kept deleting cell data in drag-fill operation in all other cases
(as described here: https://bugs.freedesktop.org/show_bug.cgi?id=35345#c10)
Now we're trying to look also for anonymous DB data in the current sheet and
check those for the presence of autofilter or query params.
Please review comment. /me doesn't know this particular pieces of code so
well.
frozenB.
--
\ Katarina Machalkova
\\\__o LibO developer
__\\\'/_ hedgehog painter
From 6b4c2666b8c4131371859191f322f5bfc0aca027 Mon Sep 17 00:00:00 2001
From: Katarina Machalkova kmachalk...@suse.cz
Date: Tue, 24 May 2011 17:23:35 +0200
Subject: [PATCH] fdo#35345: Query the sheet for the presence of anonymous DB ranges
... and for autofilters || query params in those. This avoids
overwriting the hidden cells in drag-fill operation
---
sc/source/core/tool/dbcolect.cxx | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/sc/source/core/tool/dbcolect.cxx b/sc/source/core/tool/dbcolect.cxx
index 635ab5a..39b6575 100644
--- a/sc/source/core/tool/dbcolect.cxx
+++ b/sc/source/core/tool/dbcolect.cxx
@@ -827,7 +827,8 @@ ScDBData* ScDBCollection::GetDBAtArea(SCTAB nTab, SCCOL nCol1, SCROW nRow1, SCCO
ScDBData* ScDBCollection::GetFilterDBAtTable(SCTAB nTab) const
{
-ScDBData* pDataEmpty = NULL;
+ScDBData* pAnonData = pDoc-GetAnonymousDBData(nTab);
+
if (pItems)
{
for (sal_uInt16 i = 0; i nCount; i++)
@@ -843,7 +844,13 @@ ScDBData* ScDBCollection::GetFilterDBAtTable(SCTAB nTab) const
}
}
-return pDataEmpty;
+if (pAnonData)
+{
+if ( pAnonData-HasAutoFilter() || pAnonData-HasQueryParam())
+return pAnonData;
+}
+
+return NULL;
}
sal_Bool ScDBCollection::SearchName( const String rName, sal_uInt16 rIndex ) const
--
1.7.3.4
signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED-3-4-0] fdo#37001Update license text
Andras Timar píše v Ne 22. 05. 2011 v 21:24 +0200: Hi, There is an updated, more accurate, more complete and better formatted license document attached to https://bugs.freedesktop.org/show_bug.cgi?id=37001. See details in the bug, especially Comment 8. I would like to update license documents in 3-4 and 3-4-0, please approve. Got approval by me, Michael Meeks and Sophie = pushed into libreoffice-3-4 and 3-4-0 branches. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix for fdo#37387
On Tue, 2011-05-24 at 15:13 +0200, Petr Mladek wrote: Andras Timar píše v Ne 22. 05. 2011 v 07:46 +0200: I pushed your patch to 3-4. I looks better on the few locales I tested. We need two more reviews for 3-4-0 for http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id=335cc3bb837a671b3d6644bf9b4bc13a116102da and http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id=27875f65e2c1953fbf636af32556833c44849f53 +1 I have just tested both changes. They look fine to me. We need one more review for the 3-4-0 branch. Checked it in Japanese UI, and it looks good to me. You have my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] [PUSHED] Fix for fdo#37387
On Tue, 2011-05-24 at 12:03 -0400, Kohei Yoshida wrote: On Tue, 2011-05-24 at 15:13 +0200, Petr Mladek wrote: Andras Timar píše v Ne 22. 05. 2011 v 07:46 +0200: I pushed your patch to 3-4. I looks better on the few locales I tested. We need two more reviews for 3-4-0 for http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id=335cc3bb837a671b3d6644bf9b4bc13a116102da and http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id=27875f65e2c1953fbf636af32556833c44849f53 +1 I have just tested both changes. They look fine to me. We need one more review for the 3-4-0 branch. Checked it in Japanese UI, and it looks good to me. You have my sign-off. Since I'm the 3rd reviewer, I did the honor of cherry-picking both commits to the -3-4-0 branch. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix crash when importing doc from fdo#36239
Cedric Bosdonnat píše v Čt 19. 05. 2011 v 14:51 +0200: Hi Michael, On Thu, 2011-05-19 at 12:21 +0100, Michael Meeks wrote: Hi Cedric, On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote: could you please review / push this patch to 3.4 and 3.4.0? It's a simple fix that would save quite some crashes. Looks fine to me - of course I'd prefer: -xub_StrLen nEndPos = rEnd == rStart ? rEnd.nContent.GetIndex() : rEnd.nContent.GetIndex() - 1; +xub_StrLen nEndPos = MAX (0, rEnd.nContent.GetIndex() - 1); which looks like it might do the same thing ? ;-) no, it doesn't do the same... as xub_StrLen is sal_uInt32 or sal_uInt16. If rEnd.nContent.GetIndex() is 0, then we would still have that big value (the max of sal_uInt32 or sal_uInt16) when doing rEnd.nContent.GetIndex() - 1 The patch looked fine = got 3 approvals = pushed into both libreoffice-3-4 and 3-4-0 branches. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW][PUSHED-3-4-0] Fix crash when importing doc from fdo#36239
Cedric Bosdonnat píše v Čt 19. 05. 2011 v 14:51 +0200: Hi Michael, On Thu, 2011-05-19 at 12:21 +0100, Michael Meeks wrote: Hi Cedric, On Thu, 2011-05-19 at 12:44 +0200, Cedric Bosdonnat wrote: could you please review / push this patch to 3.4 and 3.4.0? It's a simple fix that would save quite some crashes. Looks fine to me - of course I'd prefer: -xub_StrLen nEndPos = rEnd == rStart ? rEnd.nContent.GetIndex() : rEnd.nContent.GetIndex() - 1; +xub_StrLen nEndPos = MAX (0, rEnd.nContent.GetIndex() - 1); which looks like it might do the same thing ? ;-) no, it doesn't do the same... as xub_StrLen is sal_uInt32 or sal_uInt16. If rEnd.nContent.GetIndex() is 0, then we would still have that big value (the max of sal_uInt32 or sal_uInt16) when doing rEnd.nContent.GetIndex() - 1 The patch looked fine = got 3 approvals = pushed into both libreoffice-3-4 and 3-4-0 branches. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] new crashers on master
On Tue, 2011-05-24 at 15:50 +0100, Caolán McNamara wrote: (As an aside, I need to collect up all the current dodgy looking getSymbolicLink using code and centralize it into one not-quite-so-busted place) It would be ideal to have this in sal - somewhere, so we could clobber it even for binaries like soffice.bin such that we can link them (and libsal, and ... all the exceptions in linkoo currently). :-) Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fdo#35345: more Calc (auto)filter evilness
On Tue, 2011-05-24 at 17:50 +0200, Markus Mohrhard wrote: Hello Katarina, the idea is good, but I think we should move this code to ScDocument::GetFilterDBAtTable because I'm not quite sure if there are not some cases where there is a sheet local db data but no dbcollection. I personally would prefer that but I'm fine with this patch too. You have a second. Nice work! We need one more sign-off in order to get this piece included in the -3-4-0 branch. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANNOUNCE] libreoffice-3.4.0.2 tag created (3.4.0-rc2)
Hi, there have been created the libreoffice-3.4.0.2 tag for 3.4.0-rc2 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.4.0-rc1. You might switch your current 3-4 source tree to it using: ./g fetch --tags ./g checkout -b tag-libreoffice-3.4.0.2 libreoffice-3.4.0.2 See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.4.0_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr + artwork + fix wrong-sized toolbar mimetype icons. (fdo#33229) [Thorsten Behrens] + calc + fix a layout problem in Export text (CSV) dialog (fdo#37418) [Andras Timar] + fix for (binary import crash) (fdo#37322) [Katarina Machalkova] + fix for Correct autofilter import from ODS. (fdo#37323) [Markus Mohrhard] + fix for crash when copy/paste table from writer to calc (fdo#37429) [Markus Mohrhard] + sign number must be either 1 or -1, never 0. (fdo#37326) [Regina Henschel] + components + polish branding - fix langpack mac installer icon (fdo#33229) [Thorsten Behrens] + libs-core + - updated license information (fdo#37001) [Andras Timar] + don't assume you'll always find a match. (fdo#37252) [Kohei Yoshida] + fixed crash when reading malformed fieldmark tags in ODT (fdo#34997) [Cédric Bosdonnat] + initialize resource manager to get verbose basic errors (fdo#37370) [Noel Power] + make style:layout-grid-snap-to-characters fit to ODF spec. (fdo#37390) [Cédric Bosdonnat] + sanity checks that fix crash (fdo#36495) [Tor Lillqvist] + libs-extern-sys + remove added license header that caused parse error (fdo#37433) [Andras Timar] + libs-gui + don't broadcast setting changes during painting of button. (fdo#36690) [Kohei Yoshida] + fix a bug about presssed button state (fdo#36613) [Lucas Baudin] + fixed the prefix recognition in URLs... that list is sorted. (fdo#36615) [Cédric Bosdonnat] + testing + make toolkit.UnoScrollBarControl not fail headless (fdo#37325) [Bjoern Michaelsen] + writer + compatibility option for old size of small caps (bnc#691473) [Luboš Luňák] + fix crash reading some documents with fields (fdo#36329) [Cédric Bosdonnat] + fix for (fdo#36552) [Noel Power] + reorganized columns dialog to show text direction correctly (fdo#37387) [Cédric Bosdonnat] + common + branch libreoffice-3-4-0 [Petr Mladek] + version 3.4.0.2, tag libreoffice-3.4.0.2 (3.4.0-rc2) [Petr Mladek] + artwork + fix wrong-sized toolbar mimetype icons. (fdo#33229) [Thorsten Behrens] + bootstrap + always request an unversioned lib from gcc in gccinstlib.pl [Bjoern Michaelsen] + bump product version to 3.4.0-rc2, release number to 12 [Petr Mladek] + calc + fix a layout problem in Export text (CSV) dialog (fdo#37418) [Andras Timar] + fix for (binary import crash) (fdo#37322) [Katarina Machalkova] + fix for Correct autofilter import from ODS. (fdo#37323) [Markus Mohrhard] + fix for crash when copy/paste table from writer to calc (fdo#37429) [Markus Mohrhard] + fix index out of bounds in ScTableConditionalFormat. [Rafael Dominguez] + sign number must be either 1 or -1, never 0. (fdo#37326) [Regina Henschel] + update sheet local db data when sheets are inserted/deleted [Markus Mohrhard] + components + 3rd update to Mac dmg background. [Thorsten Behrens] + polish branding - fix langpack mac installer icon (fdo#33229) [Thorsten Behrens] + extensions + removed GNUism in makefile [Thorsten Behrens] + filters + don't de-reference null pointer - fix crash with certain PPTX files [Michael Meeks] + fix config for pptx filter - thanks to Bubli [Radek Doulik] + make export to .pptx 2010 work again [Katarina Machalkova] + impress + added sdfilt.component for pptx export [Radek Doulik] + fix sdfilt component generation [Radek Doulik] + libs-core + - updated license information (fdo#37001) [Andras Timar] + do not include bsh.jar when building with system bsh [David Tardon] + don't assume you'll always find a match. (fdo#37252) [Kohei Yoshida] + fixed crash when reading malformed fieldmark tags in ODT (fdo#34997) [Cédric Bosdonnat] + initialize resource manager to get verbose basic errors (fdo#37370) [Noel Power] + make style:layout-grid-snap-to-characters fit to ODF spec. (fdo#37390) [Cédric Bosdonnat] + sanity checks that fix crash (fdo#36495) [Tor Lillqvist] + libs-extern-sys + remove added license header that caused parse error (fdo#37433) [Andras Timar] + libs-gui + don't broadcast setting changes during painting of button. (fdo#36690) [Kohei Yoshida] + fix a bug about presssed button state (fdo#36613) [Lucas Baudin] + fixed the prefix recognition in URLs... that list is sorted. (fdo#36615) [Cédric Bosdonnat] + postprocess + add sdfilt component [Radek Doulik] + testing + make toolkit.UnoScrollBarControl not fail
Re: [Libreoffice] [PUSHED] Re: REVIEW for fix#37211
18.05.2011 05:24, Jan Holesovsky пишет: Hi Noel, On 2011-05-17 at 17:47 +0100, Noel Power wrote: following patch fixes regressions reported in https://bugs.freedesktop.org/show_bug.cgi?id=37211; https://bugs.freedesktop.org/show_bug.cgi?id=37170 https://bugs.freedesktop.org/attachment.cgi?id=46831 it would be great to get the 1 review for libreoffice-3-4 ( not critical so no point pushing for the release branch I think ) Thank you for that, reviewed pushed :-) Regards, Kendy . Please, can anyone make third review to this patch (if my review counts) and push it to libreoffice-3-4-0 ? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one
Hello, here is a short patch that sets all specified borders during parsing instead of only one border. The problem was that nBorderTyp was set for every border with the correct value but SetBorderLine was only called once after the do while loop. So now every time nBorderType will be overriden, I call SetBorderLine. If this patch is ok I think we should add it to the 3-4 branch. Regards, Markus 0001-set-all-border-lines-not-only-one.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Andras Timar tima...@gmail.com changed: What|Removed |Added Depends on||37516 --- Comment #120 from Andras Timar tima...@gmail.com 2011-05-24 12:57:03 PDT --- I nominate bug 37516. It is a regression, invalid DOC file (MS Office Binary Format) is saved from LibreOffice 3.4. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Fix for fdo#37520
The attached patch fixes the crasher reported in https://bugs.freedesktop.org/show_bug.cgi?id=37520 The crash occurs in ScRangeList::Join() where the array size is cached prior to the for loop, but array may shrink during the loop, in which case an out-of-bound array access may occur which in turn results in a crash. I'm actually surprised that this didn't cause a crash on Linux. Anyhow, the solution is to always dynamically check the size of the array via size() method in each iteration, instead of caching it for all iterations. Review appreciated. I'd like this to go into the -3-4-0 branch. So I need three sign-off's. Kohei 0001-fdo-37520-Don-t-cache-the-array-size-but-query-it-dy.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix for fdo#37520
You have my sign off and pushed to 3-4. 2011/5/24 Kohei Yoshida kohei.yosh...@gmail.com The attached patch fixes the crasher reported in https://bugs.freedesktop.org/show_bug.cgi?id=37520 The crash occurs in ScRangeList::Join() where the array size is cached prior to the for loop, but array may shrink during the loop, in which case an out-of-bound array access may occur which in turn results in a crash. I'm actually surprised that this didn't cause a crash on Linux. Anyhow, the solution is to always dynamically check the size of the array via size() method in each iteration, instead of caching it for all iterations. Review appreciated. I'd like this to go into the -3-4-0 branch. So I need three sign-off's. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37520, which changed state. Bug 37520 Summary: Crash with Insert Names Labels https://bugs.freedesktop.org/show_bug.cgi?id=37520 What|Old Value |New Value Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OneGit(tm) migration plan
Hi *, On Sun, May 22, 2011 at 12:52 AM, Norbert Thiebaud nthieb...@gmail.com wrote: [onegit] I have put what I have come-up with so far on our Wiki http://wiki.documentfoundation.org/Development/One_Git_Conversion [...] Comments and suggestion are welcomed on the 'Discussion Page' associated in the Wiki. Hope it is not off-topic here as well (if it is, please tell and I'll just copy it to wiki discussion page) /* artwok */ is meant to not being merged. I think this is a bad choice, as you will always need it when building, and for the same reasons it is discussed not to be worthy to be merged, I'm all in favor of merging it: * changes very infrequently (thus no significant increase in history data, but even if it was: Does it matter whether you pull it into the one or into the other repository? So I don't understand the only binaries argument as supporting the idea to keeping it separate) * (mostly only) designers work on it. They have no use for git, be it a seperate repository or not. They don't need any history, the cannot use diffs on binaries anyway. A static tarball containing the content or just a webpage for browsing the icons is enough and better suited to satisfy them. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OneGit(tm) migration plan
On Sun, May 22, 2011 at 1:52 AM, Norbert Thiebaud nthieb...@gmail.com wrote: The fact that our source is spread among 20 git repositories has been a source of grief and quite a common complaint from people joining the project. Recently there ave been some tests conducted to see if having just one big git repo would be viable from a performace stand-point. Björn Michaelsen did some preliminarily measurement that indicated that it would be bearable, and this has been discussed few times during Technical Steering Committee's conference calls. The consensus emerging is that the benefit outweigh the cost. I have been working on setting-up a concrete plan on how to do this migration. I have put what I have come-up with so far on our Wiki http://wiki.documentfoundation.org/Development/One_Git_Conversion I got slightly different figures for the .git/ of each repository. Instead of 1666MB total, I got 1350MB. You may have to run 'git gc' on your repositories. I got the 1350MB figure by testing with fresh clones. Tell me if you want me to update the wiki page with these figures. Simos This is still a work in progress, and there are small and full scale test to be conducted. Planning and exact deployment plan are also very much a work in progress. Never-the-less the general idea is to try to do this migration sightly after 3.4.2, so roughly in the August 2011 time-frame. Comments and suggestion are welcomed on the 'Discussion Page' associated in the Wiki. Please do not do substantial change to the main page without discussing it first. (fixing my horrible English spelling/grammar is fine, of course :-) ) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- A. Because it breaks the logical sequence of discussion Q. Why is top posting bad? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OneGit(tm) migration plan
On Tue, May 24, 2011 at 5:40 PM, Simos Xenitellis simos.li...@googlemail.com wrote: I got slightly different figures for the .git/ of each repository. Instead of 1666MB total, I got 1350MB. You may have to run 'git gc' on your repositories. I got the 1350MB figure by testing with fresh clones. Yep, very possible... but these number are mostly to get an idea of the order of magnitude... Tell me if you want me to update the wiki page with these figures. Sure, no problem. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OneGit(tm) migration plan
On Wed, May 25, 2011 at 1:51 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Tue, May 24, 2011 at 5:40 PM, Simos Xenitellis simos.li...@googlemail.com wrote: I got slightly different figures for the .git/ of each repository. Instead of 1666MB total, I got 1350MB. You may have to run 'git gc' on your repositories. I got the 1350MB figure by testing with fresh clones. Yep, very possible... but these number are mostly to get an idea of the order of magnitude... Tell me if you want me to update the wiki page with these figures. Sure, no problem. Done. Simos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GSOC] build fails for chart2 module
Hello Kohei, After make clean build seems to fail again here for chart2 module while compiling chart2/source/controller/mainShapeController.cxx . This is the output. http://pastebin.com/AYj1Bbf0 Its the same error which I mentioned over IRC today. Thanks and regards. -- Anurag Jain Final yr B.Tech CSE SASTRA University Thanjavur(T.N.)-613402 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Гopящий туp
Мoб +38 050 200 79 40 гopящий туp: ЗHAКОМСТВО C ИТAЛИЕЙ Aкция нa июнь! Пpиведи дpуга и пoлучи cкидку 70 евpо! Будапeшт – Люблянa – Вeнeция – Флopeнция – Пизa – Pим – Вaтикан – Бaлатон Бeз нoчныx пepеездов в автобуcе Hабор гpуппы в июнe: 10.06.2011 -20.06.2011 Стoимoсть: 440 евpо - дeти (дo 16 лeт), 470 eвpo - взpослый B стоимoсти туpa: • «Арxитектурное чудo - Будaпeшт» • Экскуpcия «Любляна – cтoлица Слoвении» • «Прeкрасная Флоpенция - дpевняя и cовpеменная»; • «Pим – стoлица миpа; • a такжe купaние нa «венгеpском мope»!!! 1 дeнь: Bыeзд из Киeвa поeздoм. 2 дeнь: Пpибытиe в Чoп. Пocaдка нa кoмфоpтабельный автобуc, пepесечение украинo-венгерской гpaницы. Пeрвая оcтaновка «Bенгерский Памуккaлe» – Эгеpcалок! Пocещение Вeлнeс–Комплекса (вx.12 еврo). K Baшим услугaм paзвлекательные бaссейны, экcклюзивныe caуны, пpиятныe и нeжныe вaнны. B кoмплекcе, pазместившемся нa тeppитории 1800 кв.м, еcть 16 кpытых и откpытыx бaccейнов: cидячиe басcейны c лечебнoй вoдoй, джaкузи, бaссейн c cюpпризами, гopкa. Пocле купaния пеpеезд в иcторический кpай винoделия – гopод Эгeр. Обeд в Дoлине Кpасавиц c дeгуcтацией винa (для взpocлых) и нeзабываемым венгеpским гуляшoм (15 взpocлые/10 еврo дeти). Oтправление в Будaпешт. Рaсселение в отелe 3* в Будапeште. Hoчлег. 3 дeнь: Завтpак. Oбзоpная экcкуpcия: «Apхитектурное чудo - Будaпeшт». Прекpасная Будa и вeличественный Пeшт – этo “Жемчужинa Дунaя” – Будaпешт! O! этoт Гopoд… Кpaсивейшая площaдь Eвpoпы – плoщaдь Геpоев, пapк Вapошлигет и зaмoк в нeм – Вaйдaхуняд. Boт и Pыбацкий бaстиoн, cобoр Мaтияша, гдe вeнчaютcя всe корoлевские cемьи Евpопы, пaмятник Cвятoй Трoицe и … cам Kopолевский Двoрeц! Свoбoдное врeмя. Bы мoжeте поceтить пo жeлaнию: сaмый cтаpый зоoпарк Евpoпы (8/6 eврo) или ещe рaз нaслaдится целебнoй вoдoй царcких теpмальных купалeн Сeчeни (14 евpo). Для жeлaющиx рекoмендуем – пpoгулкa нa коpaблике пo Дунaю (15 eвpо). Вeчерний Будaпeшт в иллюминaции, пoд музыку вальcoв И. Штрaуcа c бoкалом шaмпанcкого или cладкoго нaпитка для дeтей – этo надo увидeть. Ночлeг в гоcтинице. 4 дeнь: Завтpак. Bыезд в Любляну. Экcкурсия «Любляна – стoлицa Cлoвeнии». Красивый гoрод, pаскинулся нa бepегах рeки Любляницы. Ha правoм беpeгу рeки раcкинулся Cтаpый гopод, нa лeвом – пapaдные здaния прошлoго векa. Свoбoдное вpемя. Bыeзд в cтoрону Итaлии. Нoчь в тpанзитном oтеле нa теppитории Cлoвeнии. 5 дeнь: Завтpaк. A дaльшe - всe дopоги вeдут в Итaлию… Перeезд в Вeнецию. O, Bенеция! Cказoчный гoрoд! Oбзоpная экскуpсия Мopcкое чудo - Венeция! (билeты нa кaтер + курoтный сбоp обязaтeльно + экскуpсия: взрoслые – 35 eврo, дeти – 25 eвpo). Boт oн – гopoд мeчты и cилы чeловеческого дуxа. Cвoбoдное вpемя. Рeкомендуем ромaнтическую прoгулку нa гондолe пo кaналам (20 евpo). Вeсёлые кpаcавцы гондoльeры, удивитeльно крacивые маcки, вeликoлeпные мocты, двoрцы, и мaленькиe дoмики coставляют нeпoвторимый колopит дивнoй итальянcкoй скaзки пoд нaзваниeм Венeция. Дaлее нaш путь лeжит в Мeкку всex худoжникoв – Флорeнцию. Пocеление в oтелe. Нoчлег. 6 дeнь: Зaвтpaк. Обзоpная экcкурcия «Пpекрасная Флopенция - дpевняя и сoвременная». Ceгoдня мы окунёмcя в эпоxу Вoзpождения. Здеcь жили и твopили гeнии: Микелaнджело, Бeнвенуто Чeллини, Джoтто. Свобoдное вpемя. Факультативнoе поceщение всeмиpно извeстнoй Гaлеpеи Уффици. Гaлepея Уффици - oдин из cтаpейших музeев Итaлии и мировoго изoбразительного иcкуccтва. Cеpдце знaмeнитoго музeя - кoллeкция нe мeнee знамeнитoго pода Мeдичи, пpавившeго здecь дoлгиe гoды. K момeнту рoждения музeя, a произoшло этo cо всex тoчeк зpeния пpимечательное сoбытиe вo втoрой пoлoвинe XVI векa, oна былa oднoй из бoгатейших и лучшиx в мирe (35 eвpо взp/30 eвpo рeб., брониpуется зaрaнее). Приглашаем Ваc в вeликолeпную Пизу - Hа встрeчу к пaдaющeй башне (Bзрослые 30 евpо/ дeти дo 12 лeт 20 eвpo). Пиза- изюминкa Итaлии, «Таинствeнный гopод из бeлoго мpамoра». Тeпеpь едeм в гopoд, кoтoрый нe зpя назывaют Beчным - Pим Пoceление в отелe. Hочлeг. 7 дeнь: Зaвтpaк. BHИМАНИЕ!!! ПEРEДВИЖЕНИЕ ПO PИМУ OБЩEСТВЕННЫМ ТРАHСПОРТОМ!!! Экскуpcия «Pим – cтoлицa миpа». Здecь кaждый камешeк дышит вeчноcтью… Cвобoдное вpемя. Пpeдлагаем экcкурcию «Путeшествие в Гоcударство Baтикан» (30 eвро). Hаш путь лeжит в cамую мaлeнькую стрaну в миpe, нo каждoe словo ёe пpaвитeлей отзываeтся в душаx миллионoв xристиан. Удобнo pасположившись нa правoм бepегу Тибpa, Bатикан пoлнoстью нeзависим oт Итaлии, у негo cвоя желeзнaя доpoга, cвоe тeлeвидeние, газетa, зaкoны, правилa и пoлиция. Вaтикaн объявлeн ЮHEСКО пaмятником миpовoго культуpногo наcлeдия. Мы поceтим Сoбор Святогo Пeтpа, вeличие и кpaсота кoтоpого нe имeют себe рaвных. Cвобoдное врeмя. Нoчлeг. 8 дeнь: Зaвтрак. Oсвoбождение нoмepов Приглaшаем нa экcкурсию «Beличие Имперcкого Римa» (взp 30 евpo/ peб. 25 евpo): Кoлизей, Pимский и Имперaторский фopумы, Капитoлийский хoлм - свящeнное мeсто бoгoв - цeль вceх побeдоносных пoлкoвoдцев. Вaс зaxватит и увлечeт истоpия Дpевнего Pимa, тaйны и легeнды, чтo xранит в сeбе этoт пpекpасный вeчный гoрод. Пеpеезд нa oзеpо
Re: [Libreoffice] [GSOC] build fails for chart2 module
Hi Anurag, On Wed, 2011-05-25 at 05:14 +0530, Anurag Jain wrote: Hello Kohei, After make clean build seems to fail again here for chart2 module while compiling chart2/source/controller/mainShapeController.cxx . So, I checked my IRC log and looks like Markus helped you solve your build issue? :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Review] fix for fdo# 37548
Hello, this patch fixes fdo#37548. This patch just reverts this line to it's old state ( http://opengrok.libreoffice.org/diff/calc/sc/source/ui/docshell/docfunc.cxx?r1=/calc/sc/source/ui/docshell/docfunc.cxx@2753db3283d6bcc96ba955a688119d1ffbe5bfd5r2=/calc/sc/source/ui/docshell/docfunc.cxx@45b851e763affdd1031f7a04f131757ea0e9b656format=ofull=0). It seems to be only an accidential change. It would be nice to get this into the 3-4 branch. Regards, Markus 0001-fix-for-fdo-37548-InsertNames-InsertAll-doesn-t-inse.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Review] fix for fdo# 37548
On Wed, 2011-05-25 at 03:43 +0200, Markus Mohrhard wrote: this patch fixes fdo#37548. This patch just reverts this line to it's old state ( http://opengrok.libreoffice.org/diff/calc/sc/source/ui/docshell/docfunc.cxx?r1=/calc/sc/source/ui/docshell/docfunc.cxx@2753db3283d6bcc96ba955a688119d1ffbe5bfd5r2=/calc/sc/source/ui/docshell/docfunc.cxx@45b851e763affdd1031f7a04f131757ea0e9b656format=ofull=0 ). It seems to be only an accidential change. Yes indeed. Good catch. It would be nice to get this into the 3-4 branch. Agreed. Pushed this to the -3-4 branch with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] LibreOffice Extensions repository
Hi all, I found http://libreofficeaustralia.org/download/extensions. Is it the new extensions repository for LibreOffice? If yes, should I start posting my extensions to this site? Tantai, -- _/|\_ Tantai Thanakanok. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [ANNOUNCE] libreoffice-3.4.0.2 tag created (3.4.0-rc2)
Am Tue, 24 May 2011 20:05:39 +0200 schrieb Petr Mladek pmla...@suse.cz: Hi, there have been created the libreoffice-3.4.0.2 tag for 3.4.0-rc2 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.4.0-rc1. You might switch your current 3-4 source tree to it using: ./g fetch --tags ./g checkout -b tag-libreoffice-3.4.0.2 libreoffice-3.4.0.2 See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.4.0_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr Any idea why the bootstrap tarball has a size of 256MB? Is this a mistake? -Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix for fdo#37520
On 24/05/2011 22:03, Kohei Yoshida wrote: The attached patch fixes the crasher reported in https://bugs.freedesktop.org/show_bug.cgi?id=37520 The crash occurs in ScRangeList::Join() where the array size is cached prior to the for loop, but array may shrink during the loop, in which case an out-of-bound array access may occur which in turn results in a crash. I'm actually surprised that this didn't cause a crash on Linux. Kohei in this case wouldnt it be better to use a linked list instead of an array since a link list can easily adjust to size instead of an array which is of a static size? Anyhow, the solution is to always dynamically check the size of the array via size() method in each iteration, instead of caching it for all iterations. Review appreciated. I'd like this to go into the -3-4-0 branch. So I need three sign-off's. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] menu packages for OxygenOffice
Title: Szal Hi Developers, Last time Fridrich has reverted a patch because it caused problem. It seems I forget to attach all required patches. Can you revert this: http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4id=77eb7f58d973eeb397dac0702646fc811894851c And also please apply the patch that I attached? I would like to get it to libreoffice-3-4, so I need 1 approval. Thank you in advance! Cheers, KAMI -- From 042a4eb95273b01d6d77c3324e1ee76d3620beec Mon Sep 17 00:00:00 2001 From: Kalman Szalai - KAMI kami...@gmail.com Date: Wed, 25 May 2011 06:50:30 +0200 Subject: [PATCH] Add OxygenOffice menu-icon package support --- sysui/desktop/productversion.mk |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/sysui/desktop/productversion.mk b/sysui/desktop/productversion.mk index 8d1f93c..0b027a4 100755 --- a/sysui/desktop/productversion.mk +++ b/sysui/desktop/productversion.mk @@ -72,4 +72,9 @@ PKGVERSION.broffice = $(PKGVERSION) UNIXFILENAME.broffice = $(PRODUCTNAME.broffice:l)$(PRODUCTVERSION.broffice) ICONPREFIX.broffice = $(UNIXFILENAME.broffice:s/.//g) - +PRODUCTNAME.oxygenoffice = OxygenOffice +PRODUCTVERSION.oxygenoffice = $(PRODUCTVERSION) +PRODUCTVERSIONSHORT.oxygenoffice = $(PRODUCTVERSIONSHORT) +PKGVERSION.oxygenoffice = $(PKGVERSION) +UNIXFILENAME.oxygenoffice = $(PRODUCTNAME.oxygenoffice:l)$(PRODUCTVERSION.oxygenoffice) +ICONPREFIX.oxygenoffice = $(UNIXFILENAME.oxygenoffice:s/.//g) -- 1.5.4.3 signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Fix for fdo#37520
On Tue, May 24, 2011 at 3:03 PM, Kohei Yoshida kohei.yosh...@gmail.com wrote: The attached patch fixes the crasher reported in https://bugs.freedesktop.org/show_bug.cgi?id=37520 The crash occurs in ScRangeList::Join() where the array size is cached prior to the for loop, but array may shrink during the loop, in which case an out-of-bound array access may occur which in turn results in a crash. I'm actually surprised that this didn't cause a crash on Linux. Anyhow, the solution is to always dynamically check the size of the array via size() method in each iteration, instead of caching it for all iterations. Review appreciated. I'd like this to go into the -3-4-0 branch. So I need three sign-off's. +1 Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice Extensions repository
I found http://libreofficeaustralia.org/download/extensions. You can find lots of stuff on the Internet. Is it the new extensions repository for LibreOffice? Using common sense is useful. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
