[Libreoffice-bugs] [Bug 102506] Find Bar Ctrl+F (search of Cells in Calc): add option to set search for cell Values instead of Formulas

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102506

--- Comment #30 from Toby Bartels  ---
Well, of course this doesn't really fix anything; it exchanges one default that
works for some people but not for others, for another default that works for
some people but not for others.  Of course, you've heard from a lot of people
that prefer the new default, because those of us who preferred the old way
didn't think that there was a bug and didn't come looking until one day
recently when Calc just broke for us, and I seem to be the first of that group
to track down this report and make a comment.

The desired resolution of this bug report was for an option, and I wouldn't
object to switching the default if there really was an option to switch it
back.  We only have anecdotal evidence that more people prefer the new way;
still, now that I think of it, that's what I would have guessed.  But as the
previous comment says, getting an option is WONTFIX, and I guess that the
report can only have one status.

Now, I just created this account to make the comment, and I seem to have the
power to reopen the bug by editing the status here, but I'm not sure if I
really have the right to do that.  I suppose that I should really make a new
bug, which I can start by copying mahfiaz's first post on this bug, that it IS
a bug because it used to work differently.  And I can open a bug for how using
Ctrl-F resets the default for Ctrl-H, so that I not only have to retrain my
fingers to use Ctrl-H instead of Ctrl-F, I also have to adjust the settings on
Ctrl-H again every time my fingers forget.  And I *actually* have to train my
fingers to hit an arrow key before Ctrl-H, in case some cells are selected,
since Ctrl-H defaults to searching only in the current selection if there is
one, so I'll need to open a bug about how that setting is never remembered.

But I'll make this comment first, since I don't really know my way around here
yet.  Commenting is easy; searching for duplicates and writing a good initial
report is hard.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141092] Lagging badly on Impress when Skia enabled

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141092

--- Comment #11 from yxpoh  ---
7.3.1.3 seems to have stopped the issue.
Still trying but at least initial usage seems fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147754] Floating image repainted incorrectly as surrounding text changes

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147754

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147749] calc issuing X11 activate hint when "Find" bottom tab is opened

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147749

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143925] 7.1.5.2 x64 writer: tab set missing, online help is wrong; line spacing wonky

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143925

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143925] 7.1.5.2 x64 writer: tab set missing, online help is wrong; line spacing wonky

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143925

--- Comment #4 from QA Administrators  ---
Dear Michael Potts,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143924] Rows Duplicate Text to Row Above

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143924

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143924] Rows Duplicate Text to Row Above

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143924

--- Comment #3 from QA Administrators  ---
Dear farrah.humphrey,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 37128] Writer saves text alignment of RTL paragraph not according to the ODF specification

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=37128

--- Comment #18 from QA Administrators  ---
Dear Dotan Cohen,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148029] Colibre Dark icons with dark background should be made transparent

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148029

--- Comment #2 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/778bbcede813dd51e11ee61583247db1199eda63

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147734] KeyID on image format import/export dialog is nothing in UI.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147734

20001...@protonmail.com <20001...@protonmail.com> changed:

   What|Removed |Added

  Component|Localization|UI

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148008] autofit column width by cell selection using wrong width

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148008

Scott Clewell  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Scott Clewell  ---
Hello Ryan,

Thank you for reporting the bug. I can confirm that the bug is present in

Version: 7.3.1.3 / LibreOffice Community
Build ID: 30(Build:3)
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.1~rc3-0ubuntu0.20.04.1~lo1
Calc: threaded

and in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: cb56edb177f4db5b9cc4d140543c4b11d41ef1b0
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

Lemures Lemniscati license statement

2022-03-17 Thread Lemures Lemniscati
All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.



[Libreoffice-bugs] [Bug 148051] Crashings for unkown reasons, despite reset user profile etc.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148051

Julien Nabet  changed:

   What|Removed |Added

 CC||ipla...@tuta.io,
   ||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet  ---
Noticing these on the crash stacktrace:
  11  MenuData::MenuContentViewAccessibilityHandler(OpaqueEventHandlerCallRef*,
OpaqueEventRef*, void*) + 97 (HIToolbox + 1723459) [0x7ff819ca5c43]
  11  HIObject::DispatchAccessibilityEvent(OpaqueEventRef*, unsigned long long,
AccessibilityHandlers const*, void*) + 485 (HIToolbox + 1828159)
[0x7ff819cbf53f]
  11  MenuData::ContentViewGetNamedAccessibleAttribute(unsigned long long,
__CFString const*, unsigned int, OpaqueEventRef*, void*) + 71 (HIToolbox +
1723615) [0x7ff819ca5cdf]
  11  MenuData::HandleGetAccessibleChildren(unsigned long long, __CFArray*) +
232 (HIToolbox + 1712300) [0x7ff819ca30ac]

I thought about this old comment from Alex (put in cc) about accessibility part
on MacOs which may help here:
"Do you have installed any window management/user interface
utilities/apps/control panels/extensions for Mac OS X like
   * AquaSnap* BetterSnapTool
   * BetterTouchTool * Breeze
   * Cinch   * Divvy
   * DoublePane  * Flexiglass
   * HyperDock   * iSnap
   * Moom* RightZoom
   * ShiftIt * SizeUp
   * SizeWell* Spectacle
   * Stay* TileWindows
   * WindowTidy  * Flavours (from flavours.interacto.net)
... or something similar?

And/or do you use any mouse cursor/pointer utility, i.e. some little
application or control panel etc. which animates or replaces etc. the mouse
curser/pointer, like
   * LazyMouse?

And/or do you use any special software which could be related to accessibility
stuff, e.g. a screen reader, screen magnifier, speech recognition software,
a text-to-speech (dictation) application, or similar?

All these and many similar utilities rely heavily on Mac OS accessibility
features and therefore can cause LibreOffice to crash or freeze. So please
check if you have installed any utility of this kind and try to disable it
(or to add LibreOffice to the list of excluded applications for the utility,
if there is such a thing).

So please check these possibilities, if any of them helps to make the crash go
away, and report the results here.
"

Alex: this message is several years old, I suppose it must have changed a lot
until Monterey version so don't hesitate to comment here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148042] Base reports crash on Mageia 8 when opened, but not when edited

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148042

--- Comment #11 from Julien Nabet  ---
No pb here to open both reports on Debian x86-64 with LO Debian package 7.3.1
with gen or gtk3 renderings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148061] Crash when opening report of the file from tdf#148042 (DBG_UTIL only)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148061

--- Comment #1 from Julien Nabet  ---
Created attachment 178951
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178951=edit
bt with debug symbols

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148061] New: Crash when opening report of the file from tdf#148042 (DBG_UTIL only)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148061

Bug ID: 148061
   Summary: Crash when opening report of the file from tdf#148042
(DBG_UTIL only)
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serval2...@yahoo.fr

Description:
On pc Debian x86-64 with master sources updated today + enable-dbgutil, I got a
crash when opening report of the file from tdf#148042

Steps to Reproduce:
1. Retrieve file from tdf#148042 and open it
2. Open the first report


Actual Results:
Crash

Expected Results:
No crash


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: feb8e7c58dc72d01febc914fd6575757f3f7e746
CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: x11
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147882] Asking for the "original size" of a PDF inserted image delivers weird results

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147882

Ezinne  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||nnamani.ezi...@collabora.co
   ||m
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Ezinne  ---
Please can you attach a sample file to aid testing?

I will set the status to NEEDINFO. Please feel free to set it to UNCONFIRMED
when you attach the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2022-03-17 Thread Caolán McNamara (via logerrit)
 sw/source/core/txtnode/fntcache.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit d64ba1048716767db6fd3daedb637df193c7071b
Author: Caolán McNamara 
AuthorDate: Thu Mar 17 16:24:16 2022 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 17 22:18:27 2022 +0100

Related: tdf#148053 fix a crash in out of range dx array

also seen with tdf#124116

Change-Id: I211c5b9d58ee5857c8286b2009e4159b35a9e047
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131713
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/core/txtnode/fntcache.cxx 
b/sw/source/core/txtnode/fntcache.cxx
index e48c5e0e9953..7afb53d29a9c 100644
--- a/sw/source/core/txtnode/fntcache.cxx
+++ b/sw/source/core/txtnode/fntcache.cxx
@@ -2178,6 +2178,10 @@ TextFrameIndex 
SwFntObj::GetModelPositionForViewPoint(SwDrawTextInfo )
 if ( nIdx <= nLastIdx )
 break;
 
+// the next character might be outside the layout range (e.g 
tdf124116-1.odt)
+if (nIdx > nEnd)
+nIdx = nEnd;
+
 nLeft = nRight;
 nRight = aKernArray[sal_Int32(nIdx - rInf.GetIdx()) - 1] + nKernSum + 
nSpaceSum;
 


[Libreoffice-bugs] [Bug 148033] Loss of precision in /MediaBox: `nMediaBoxWidth` and `nMediaBoxHeight` in `PDFWriterImpl::emitCatalog()` should be `double` in accordance with `PDFPage::emit()`.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148033

Julien Nabet  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |lemures.lemnisc...@gmail.co
   |desktop.org |m
 Status|NEW |ASSIGNED

--- Comment #7 from Julien Nabet  ---
I cherry-picked the patch for 7.3 branch, let's wait review.

Meanwhile, I assigned you since you found the fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

2022-03-17 Thread Caolán McNamara (via logerrit)
 vcl/source/gdi/CommonSalLayout.cxx |8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

New commits:
commit 2c2b3aaa5ba15087aac06b762cc4b767eaea6cac
Author: Caolán McNamara 
AuthorDate: Thu Mar 17 16:12:20 2022 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 17 22:16:50 2022 +0100

crashtesting: clip fallback glyph range to layout range

as seen in tdf124116-1.odt

Change-Id: If81192d326e298794051a87632e63798402ff60b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131712
Tested-by: Jenkins
Tested-by: Julien Nabet 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index c4217e21a985..74478e0ef268 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -224,15 +224,19 @@ void 
GenericSalLayout::SetNeedFallback(vcl::text::ImplLayoutArgs& rArgs, sal_Int
 //mark all glyphs as missing so the whole thing is rendered with the same
 //font
 sal_Int32 nDone;
-sal_Int32 nGraphemeEndPos =
+int nGraphemeEndPos =
 mxBreak->nextCharacters(rArgs.mrStr, nCharPos, aLocale,
 i18n::CharacterIteratorMode::SKIPCELL, 1, nDone);
 // Safely advance nCharPos in case it is a non-BMP character.
 rArgs.mrStr.iterateCodePoints();
-sal_Int32 nGraphemeStartPos =
+int nGraphemeStartPos =
 mxBreak->previousCharacters(rArgs.mrStr, nCharPos, aLocale,
 i18n::CharacterIteratorMode::SKIPCELL, 1, nDone);
 
+//stay inside the Layout range (e.g. with tdf124116-1.odt)
+nGraphemeStartPos = std::max(rArgs.mnMinCharPos, nGraphemeStartPos);
+nGraphemeEndPos = std::min(rArgs.mnEndCharPos, nGraphemeEndPos);
+
 rArgs.AddFallbackRun(nGraphemeStartPos, nGraphemeEndPos, bRightToLeft);
 }
 


[Libreoffice-bugs] [Bug 148033] Loss of precision in /MediaBox: `nMediaBoxWidth` and `nMediaBoxHeight` in `PDFWriterImpl::emitCatalog()` should be `double` in accordance with `PDFPage::emit()`.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148033

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148033] Loss of precision in /MediaBox: `nMediaBoxWidth` and `nMediaBoxHeight` in `PDFWriterImpl::emitCatalog()` should be `double` in accordance with `PDFPage::emit()`.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148033

--- Comment #6 from Commit Notification 
 ---
Lemures Lemniscati committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fb48a6408a515057a03c485bf00df5c34706595b

tdf#148033: Loss of precision in /MediaBox (PDFWriterImpl::emitCatalog())

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

2022-03-17 Thread Lemures Lemniscati (via logerrit)
 vcl/source/gdi/pdfwriter_impl.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit fb48a6408a515057a03c485bf00df5c34706595b
Author: Lemures Lemniscati 
AuthorDate: Thu Mar 17 18:44:39 2022 +0100
Commit: Julien Nabet 
CommitDate: Thu Mar 17 22:12:32 2022 +0100

tdf#148033: Loss of precision in /MediaBox (PDFWriterImpl::emitCatalog())

License statement provided here:
https://bugs.documentfoundation.org/show_bug.cgi?id=148033#c4

Change-Id: I9a17d4a6a266fc25a92abf50c22cb01a2b1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131716
Reviewed-by: Caolán McNamara 
Tested-by: Jenkins

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index fc15be2be7bb..1847eb7d7f78 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -4539,8 +4539,8 @@ bool PDFWriterImpl::emitCatalog()
 aLine.append( getResourceDictObj() );
 aLine.append( " 0 R\n" );
 
-sal_Int32 nMediaBoxWidth = 0;
-sal_Int32 nMediaBoxHeight = 0;
+double nMediaBoxWidth = 0;
+double nMediaBoxHeight = 0;
 sal_Int32 nUserUnit = 1;
 if( m_aPages.empty() ) // sanity check, this should not happen
 {


[Libreoffice-bugs] [Bug 148051] Crashings for unkown reasons, despite reset user profile etc.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148051

--- Comment #4 from Sam  ---
Created attachment 178950
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178950=edit
The crash report mentioned in Comment #4

- uninstalled all previous LO versions (incl. user profiles) from my computer
- reinstalled LO 7.3.1.3
- did some minimal changes to Preferences etc.
- created a Writer document and started writing
- LO crashed
This is the report that followed this crash.
See alos
https://ask.libreoffice.org/t/libreoffice-keeps-crashing/74751/11?u=jeshkhol

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148060] New: 'Save As' removes password protection

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148060

Bug ID: 148060
   Summary: 'Save As' removes password protection
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: david.cortes.riv...@gmail.com

If I have a .xls file which is password-protected, open it with Calc, then
click "Save As", the saved file will not be password-protected anymore.

Steps to reproduce:
- Create a .xls file with MS Excel.
- Inside excel, set a password for opening the file.
- Open the file with LO Calc, using the password that was set before.
- Save the file again from inside Calc through the 'Save As' button.
- Close Calc, open the saved file again with Calc.

Expected result: should ask for the password to open the file.

Actual result: doesn't ask for the password.

Version: 7.3.1.3 / LibreOffice Community
Build ID: 30(Build:3)
CPU threads: 16; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Debian package version: 1:7.3.1-1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104927] Text Import - fixed width mode not adjusting csvtablebox for multi-byte fonts

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104927

Eike Rathke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8054

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148054] With "Text to Column" function when first column hidden data is not parsed

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148054

Eike Rathke  changed:

   What|Removed |Added

   Keywords||bibisectNotNeeded
 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4927

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa

2022-03-17 Thread Andrea Gelmini (via logerrit)
 sc/qa/extras/macros-test.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fab611b2310579962fe74b86e537f1812431f761
Author: Andrea Gelmini 
AuthorDate: Thu Mar 17 20:58:48 2022 +0100
Commit: Julien Nabet 
CommitDate: Thu Mar 17 21:22:36 2022 +0100

Fix typo

Change-Id: I7962b8fa81bd6510bc83b7656d84486806bd81c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131719
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/sc/qa/extras/macros-test.cxx b/sc/qa/extras/macros-test.cxx
index e69feea0e8ac..a53361f2d686 100644
--- a/sc/qa/extras/macros-test.cxx
+++ b/sc/qa/extras/macros-test.cxx
@@ -1172,7 +1172,7 @@ void ScMacrosTest::testFunctionAccessIndirect()
 
comphelper::getProcessServiceFactory()->createInstance("com.sun.star.sheet.FunctionAccess"),
 UNO_QUERY_THROW);
 
-// tdf#148040: without the fix in plcae, this would have failed with:
+// tdf#148040: without the fix in place, this would have failed with:
 //   An uncaught exception of type 
com.sun.star.lang.IllegalArgumentException
 // because of disallowed external link update (needed to obtain the cell 
value).
 css::uno::Any aResult = xFunc->callFunction("INDIRECT", 
{css::uno::Any(aReference)});


[Libreoffice-bugs] [Bug 90299] External links don't saved as relative in xls

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90299

Łukasz Leszko  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |leszko.lu...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111924] Focus lost on context menu

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111924

Andreas Heinisch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148013] Larger ODT with ~500 pages and comments an record changes very slow to load, worse than before

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148013

--- Comment #8 from Telesto  ---
(In reply to Timur from comment #6)
> (In reply to Noel Grandin from comment #3)
> > Oh, this is a broken file (it has overlapping redlines)
> 
> There are more of overlapping redlines. IIUC those are not broken, it just
> isn't supported well in LO: I add bug 144995 to See Also. Maybe meta should
> be created.

Bug 144995 is same document or different version of the same file... so not
useful 

But I would like to know:
a) how to detect the presence of overlapping redlines without a full perf trace
Could/should it throw SAL_INFO/WARN or something like that
b) Is it possible to check the bug tracker document pool for documents with
overlapping redlines. So verify if this issue here being unique or representing
a more common problem .. It's not that easy to spot with smaller less complex
files (so might go unnoticed)

If the issue of overlapping redlines being more common, QA could investigate...
to figure out how those files a generated.. there might be (still) some bug
with LibO causing this to happen... 

The file here has likely been saved into DOCX and back to ODT. The DOCX is
possibly edited with Word somewhere in the process

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: hwpfilter/source

2022-03-17 Thread Caolán McNamara (via logerrit)
 hwpfilter/source/hwpreader.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 05ad57ea76b088569e5c34d5ff08342d8e894e1e
Author: Caolán McNamara 
AuthorDate: Thu Mar 17 11:50:17 2022 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 17 20:48:48 2022 +0100

ofz: Null-dereference READ

Change-Id: I0e3dfed65db245779d3402293d23864b0a4fb6e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131705
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 9262b4c81d30..13e60e21590d 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -3567,7 +3567,7 @@ void HwpReader::makeFormula(TxtBox * hbox)
 hchar dest[3];
 size_t l = 0;
 
-pPar = hbox->plists[0].front().get();
+pPar = hbox->plists[0].empty() ? nullptr : hbox->plists[0].front().get();
 while( pPar )
 {
 for( n = 0; n < pPar->nch && pPar->hhstr[n]->hh;


[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118320

--- Comment #75 from V Stuart Foote  ---
(In reply to Caolán McNamara from comment #73)
> With "tools, options, advanced, enable experimental features" enabled this
> partial very experimental "demo" is available with the caveats mentioned in
> the above commit message. Maybe it can help point people the right way
> towards a full solution and illustrate some of the code involved in how we
> do the windows themeing and color selection

Yep, looking very promising. Setting Rizal's new Colibre Dark icons, and
setting Application colors to the 'LibreOffice Dark' this last piece is doing a
nice job of rendering in a Dark mode. 

With this configuration toolbars, menus and the SB deck all look great. And of
the MUFFIN assemplages, every thing is pretty presentable except the 'Tabbed'
and the 'Tabbed Compact', which have bg color issues for the UI area fills.

This is a lot better than we were able to achieve using the os/DE passed theme
details when an Assistive Technology 'HighContrast' theme is set; e.g. GreyEve
and the forced Sifr icon theme.

Looks like weere on the right track for Windows 10+, shame about the Tabbed
UI--I know some folks will fuss.

Thanks Caolán!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148053] Typing or pasting ZWNJ leads to Writer crash (debug build only)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148053

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #8 from Caolán McNamara  ---
I think it was the follow up patch of
https://gerrit.libreoffice.org/c/core/+/131713 so adapted the commit message of
that to mention this

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148042] Base reports crash on Mageia 8 when opened, but not when edited

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148042

--- Comment #10 from Robert Großkopf  ---
No problem to execute the reports with
Version: 7.3.1.3 / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

(OpenSUSE 15.3 64bit rpm Linux)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148053] Typing or pasting ZWNJ leads to Writer crash (debug build only)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148053

--- Comment #7 from Caolán McNamara  ---
It is possible https://gerrit.libreoffice.org/c/core/+/131712 addresses this
because that backtrace looks like one seen in crashtesting that the above fixes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148033] Loss of precision in /MediaBox: `nMediaBoxWidth` and `nMediaBoxHeight` in `PDFWriterImpl::emitCatalog()` should be `double` in accordance with `PDFPage::emit()`.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148033

Caolán McNamara  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144995] FILEOPEN ODT: Slow opening (220 seconds to screen with 7.3; 60 seconds with 4.4.7.2 ) for a large document with lots of changes tracked (in shown mode), and being combi

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144995

Telesto  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Telesto  ---


*** This bug has been marked as a duplicate of bug 148013 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148013] Larger ODT with ~500 pages and comments an record changes very slow to load, worse than before

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148013

--- Comment #7 from Telesto  ---
*** Bug 144995 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141722] Calc, Writer, Impress, Draw: hangs when using copy paste (often copying is sufficient to trigger the hang)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141722

--- Comment #24 from steve  ---
Unable to reproduce in 7.1.0.1
Don't think this is document related thus not re-attaching a file. One tester
also reproduced in writer and presentation for which no document ever was
provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138349] Editing : Issue when replacing an image by another

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138349

--- Comment #7 from Andrew Watson  ---
Bug still present with both JPEG and PNG in:

Version: 7.3.1.3 / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141722] Calc, Writer, Impress, Draw: hangs when using copy paste (often copying is sufficient to trigger the hang)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141722

steve  changed:

   What|Removed |Added

 CC||l.lu...@collabora.com
   Keywords|bibisectRequest |bibisected

--- Comment #23 from steve  ---
bibisected, problematic commit:
https://git.libreoffice.org/core/+/d3b498cc4732f964919fecb265085cefcc422469%5E%21

Adding Luboš to cc:

Thanks buovjaga for assistance.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Simple UX bits & dialogs ...

2022-03-17 Thread Michael Meeks

Hi Pedro,

Some great grist for easy-hacks here I hope:

We should prolly fix the consistency things to avoid functionality loss
between classic & notebookbar soonish.

Some of the new dialogs will need core work to make them async; others
are just dialog-less uno commands.

Can you file all of these chopped up whatever way you like, and (I 
guess)
Nick might be interested in some of the dialog async'ing bits.

Thanks !

Michael.


Consistency:
Writer Split Cells – add it to the Classic Mode UI (already in 
notebookbar)
Calc: Insert: Named-range or expression – not in notebookbar 
but in classic.
Calc: Insert text box – not in classic – but in notebookbar: 
NB. test it heavily!
Calc: Format row/column – height/width/optimal height etc. → in 
classic not NB.
Calc: Print Ranges → not in Notebookbar
Calc: Insert - Define / named Ranges in NB.
Calc: Data → Define Range missing in NB

Lowest hanging fruit:

Writer: Format→ Name & Description → key for a11y – trivial 
dialogs.
Calc: Format →  Description → key for a11y / alt tags suspected.
Calc: Insert Formatting Mark drop-down (?) - if we want to …
Writer Tables

Protect & un-protect cells: no UI just a cmd.
Merge Table command
Split table dialog and

Number Format dialog (?)

Calc → Paste Special → menu: of options needs to prompt for a 
Ctrl-V afterwards
Calc: View → Value Highlighting + Show Formula + View (all) 
Comments.
Calc: Insert Field → sheet name, document-title (NB. test 
heavily).
Calc cell protection:

Tools → Protect sheet – 1x dialog + password for 
editing.
Tools → Protect spreadsheet structure
Edit → Protect cell check-box/button

Writer sidebar: no text shadow effect vs. PC / desktop.

Context menus:

Calc: cell right-click insert/delete cells + 2x dialogs
Calc: right-click – insert-comment
Calc: right-click on image →

Original Size
Edit Hyperlink
Name + Description

Calc: right-click on Shape

Position, size, Line Area dialog
Alig Objecs / flip
Edit Hyperlink


Needs / likes:

Writer: right-click → Table Properties, Image Properties, 
Floating Frame properties
style sidebar
gallery sidebar
Repeat item …
Calc: Data → Consolidate

--
michael.me...@collabora.com <><, GM Collabora Productivity
Hangout: mejme...@gmail.com, Skype: mmeeks
(M) +44 7795 666 147 - timezone usually UK / Europe


[Libreoffice-commits] core.git: vcl/jsdialog

2022-03-17 Thread Szymon Kłos (via logerrit)
 vcl/jsdialog/enabled.cxx |   15 +++
 1 file changed, 15 insertions(+)

New commits:
commit feb8e7c58dc72d01febc914fd6575757f3f7e746
Author: Szymon Kłos 
AuthorDate: Tue Mar 15 10:09:43 2022 +0100
Commit: Szymon Kłos 
CommitDate: Thu Mar 17 20:08:08 2022 +0100

jsdialog: enable dialog on demand by env var

It will be possible to enable some dialogs by environment variable:


SAL_JSDIALOG_ENABLE=modules/scalc/ui/validationdialog.ui:modules/scalc/ui/validationcriteriapage.ui

(you can specify multiple items with ':' separator)

Change-Id: Iba1e6b7ac77716f40c9073a8064206c420f2d081
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131597
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index 31b18a3ae347..100741447b6e 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -7,7 +7,9 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
 #include 
+#include 
 
 namespace jsdialog
 {
@@ -60,6 +62,19 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool 
bMobile)
 return true;
 }
 
+const char* pEnabledDialog = getenv("SAL_JSDIALOG_ENABLE");
+if (pEnabledDialog)
+{
+OUString sAllEnabledDialogs(pEnabledDialog, strlen(pEnabledDialog), 
RTL_TEXTENCODING_UTF8);
+std::vector aEnabledDialogsVector
+= comphelper::string::split(sAllEnabledDialogs, ':');
+for (const auto& rDialog : aEnabledDialogsVector)
+{
+if (rUIFile == rDialog)
+return true;
+}
+}
+
 return false;
 }
 


[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118320

--- Comment #74 from Pedro  ---
Caolán, quite frankly this looks amazing already.
The only real blocker I see is the Tabbed UI.
There a couple of other minor issues that I'll open bug reports and append
here.
Another couple of suggestion can be done as enhancements:
- Change Application color automatically to LibreOffice Dark when it toggles to
Dark mode.
- Change to Dark version of icon sets when Dark mode is activated.
- Create option in the menu for the users to select Light or Dark mode by
themselves (ex. user with light theme that wants dark mode in LibO or
vice-versa)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

2022-03-17 Thread Mike Kaganski (via logerrit)
 sc/source/ui/unoobj/funcuno.cxx |   13 +
 1 file changed, 5 insertions(+), 8 deletions(-)

New commits:
commit 8cf99c39b5dba7d1dbfda70e73ee3a8388037325
Author: Mike Kaganski 
AuthorDate: Thu Mar 17 20:09:05 2022 +0300
Commit: Mike Kaganski 
CommitDate: Thu Mar 17 19:38:39 2022 +0100

Use ScDocumentUniquePtr in ScTempDocSource

Change-Id: I17d726aba52dd25f221f2ff3e9238f935afa4de5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131715
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/source/ui/unoobj/funcuno.cxx b/sc/source/ui/unoobj/funcuno.cxx
index d3fe7c342c50..e0d18a7a2ab0 100644
--- a/sc/source/ui/unoobj/funcuno.cxx
+++ b/sc/source/ui/unoobj/funcuno.cxx
@@ -63,7 +63,7 @@ class ScTempDocSource
 {
 private:
 ScTempDocCache& rCache;
-ScDocument* pTempDoc;
+ScDocumentUniquePtr pTempDoc;
 
 static ScDocument*  CreateDocument();   // create and initialize doc
 
@@ -84,11 +84,10 @@ ScDocument* ScTempDocSource::CreateDocument()
 }
 
 ScTempDocSource::ScTempDocSource( ScTempDocCache& rDocCache ) :
-rCache( rDocCache ),
-pTempDoc( nullptr )
+rCache( rDocCache )
 {
 if ( rCache.IsInUse() )
-pTempDoc = CreateDocument();
+pTempDoc.reset(CreateDocument());
 else
 {
 rCache.SetInUse( true );
@@ -99,16 +98,14 @@ ScTempDocSource::ScTempDocSource( ScTempDocCache& rDocCache 
) :
 
 ScTempDocSource::~ScTempDocSource() COVERITY_NOEXCEPT_FALSE
 {
-if ( pTempDoc )
-delete pTempDoc;
-else
+if ( !pTempDoc )
 rCache.SetInUse( false );
 }
 
 ScDocument* ScTempDocSource::GetDocument()
 {
 if ( pTempDoc )
-return pTempDoc;
+return pTempDoc.get();
 else
 return rCache.GetDocument();
 }


[Libreoffice-bugs] [Bug 147888] Only one option to choose when slide elements should appear

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147888

--- Comment #1 from pieter kristensen  ---
I'm doing a little more testing...
With version 7.3.1.3 on my Plasma machine there is only one option to choose
when selected slide elements can come in: "on click".
Version 6.4.7.2 gives me all three options to choose from on the same machine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148039] Mac PPTX to PDF: convert-to pdf option produces PDF with out of position text

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148039

--- Comment #8 from Dhaval Sonawane  ---
Created attachment 178949
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178949=edit
The same pptx in MSOffice is rendered correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148039] Mac PPTX to PDF: convert-to pdf option produces PDF with out of position text

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148039

--- Comment #7 from Dhaval Sonawane  ---
Created attachment 178948
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178948=edit
This is how the pptx looks in Libreoffice. Its an issue

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148039] Mac PPTX to PDF: convert-to pdf option produces PDF with out of position text

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148039

--- Comment #6 from Dhaval Sonawane  ---
Thanks for looking into it Timur.

About your suggestions: 
1. Tried opening the pptx in LibreOffice, I see the same issue (Attaching a
screenshot libreoffice-ui.png)
2. Tried opening in MS Office, the pptx renders correctly. (Attaching a
screenshot msoffice-ui.png)
3. I tried the --convert-to pdf command in a docker container running on
Redhat. Still see the same issue
4. Tried the command `soffice --convert-to pdf:impress_pdf_Export
/Users/dhaval/tableProblem-english.pptx`, still results in the incorrect
output.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148053] Typing or pasting ZWNJ leads to Writer crash (debug build only)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148053

Julien Nabet  changed:

   What|Removed |Added

   Priority|medium  |high
 CC||caol...@redhat.com,
   ||l.lu...@collabora.com

--- Comment #6 from Julien Nabet  ---
Caolán/Luboš: thought you might be interested in this one.

(meanwhile, crash + regression => let's increase importance)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148053] Typing or pasting ZWNJ leads to Writer crash (debug build only)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148053

--- Comment #5 from Julien Nabet  ---
Just for the record, I don't reproduce this with LO Debian package 7.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148053] Typing or pasting ZWNJ leads to Writer crash (debug build only)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148053

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
Created attachment 178947
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178947=edit
gdb bt

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I attached bt + console logs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148059] LibreOffice also shows up as Soffice when using alt-tab to cycle through windows on XFCE

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148059

--- Comment #1 from B.J. Herbison  ---
Created attachment 178946
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178946=edit
Screen shot showing Soffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148059] New: LibreOffice also shows up as Soffice when using alt-tab to cycle through windows on XFCE

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148059

Bug ID: 148059
   Summary: LibreOffice also shows up as Soffice when using
alt-tab to cycle through windows on XFCE
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: b...@herbison.com

Description:
LibreOffice should consistently appear as LibreOffice, instead of sometimes
appearing as Soffice.

When I cycle through tabs on Ubuntu/XFCE the icon appears as "Soffice/Untitled
1 - Lib". See the attached image. With multiple windows present the "Soffice"
only appears when that icon is selected.

Observed with Calc and Writer and with 6.4.7 and 7.3.1.3.

(I'm not sure where the Soffice is coming from. I don't see that in in the
output of ps, top, or task manager.)

Steps to Reproduce:
1. Start LibreOffice.
2. Cycle through windows with alt-tab.


Actual Results:
2. As pictured, the icon is identified as Soffice.

Expected Results:
2.  The icon should identify as LibreOffice.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.7.2
Build ID: 1:6.4.7-0ubuntu0.20.04.4
CPU threads: 16; OS: Linux 5.16; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: CL

(The 7.3.1.3 is on another computer.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141722] Calc, Writer, Impress, Draw: hangs when using copy paste (often copying is sufficient to trigger the hang)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141722

--- Comment #22 from Buovjaga  ---
The content of attachment 171252 has been deleted for the following reason:

not sanitised

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141722] Calc, Writer, Impress, Draw: hangs when using copy paste (often copying is sufficient to trigger the hang)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141722

steve  changed:

   What|Removed |Added

 Attachment #171252|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148042] Base reports crash on Mageia 8 when opened, but not when edited

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148042

--- Comment #9 from i027...@gmail.com ---
Created attachment 178945
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178945=edit
Sample Base database with reports

Sample Base database with reports which fail to open.

Can't say whether reports worked on previous versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cui/source sw/Module_sw.mk sw/qa sw/source sw/UITest_sw_uibase_shells.mk

2022-03-17 Thread Miklos Vajna (via logerrit)
 cui/source/tabpages/macroass.cxx  |   11 ++---
 sw/Module_sw.mk   |1 
 sw/UITest_sw_uibase_shells.mk |   16 +
 sw/qa/uitest/data/image-rel-size.fodt |   40 ++
 sw/qa/uitest/uibase/shells/shells.py  |   32 +++
 sw/source/uibase/shells/grfsh.cxx |   10 
 6 files changed, 107 insertions(+), 3 deletions(-)

New commits:
commit 9e8712ed6f9fb5dbd971e352a5709bd45fadc74f
Author: Miklos Vajna 
AuthorDate: Thu Mar 17 17:36:18 2022 +0100
Commit: Miklos Vajna 
CommitDate: Thu Mar 17 19:03:42 2022 +0100

sw image dialog: fix fallback width/height for images with relative sizes

Make sure that we work with the up to date layout size of the image in
the dialog, otherwise 80% shows up as 237%.

Also fix SfxMacroTabPage::FillItemSet() to not put anything to the
output item set when the macro table is empty, this way clicking OK in
the image dialog results in an unmodified document when the user doesn't
change anything.

Change-Id: I4b987bd3e3818ee737e37ea10861f9043c25bc93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131714
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/cui/source/tabpages/macroass.cxx b/cui/source/tabpages/macroass.cxx
index eb98f14ab7d1..d9b071dcff66 100644
--- a/cui/source/tabpages/macroass.cxx
+++ b/cui/source/tabpages/macroass.cxx
@@ -155,9 +155,14 @@ bool SfxMacroTabPage::FillItemSet( SfxItemSet* rSet )
 SvxMacroItem aItem( GetWhich( aPageRg[0] ) );
 const_cast(aItem.GetMacroTable()) = aTbl;
 
-const SfxPoolItem* pItem;
-if( SfxItemState::SET != GetItemSet().GetItemState( aItem.Which(), true, 
 )
-|| aItem != *static_cast(pItem) )
+const SfxPoolItem* pItem = nullptr;
+SfxItemState eState = GetItemSet().GetItemState(aItem.Which(), true, 
);
+if (eState == SfxItemState::DEFAULT && aTbl.empty())
+{
+// Don't touch the item set if there was no input and our table is 
empty.
+return false;
+}
+if (SfxItemState::SET != eState || aItem != *static_cast(pItem))
 {
 rSet->Put( aItem );
 return true;
diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index fd5b7024cc50..de0affba1bc7 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -199,6 +199,7 @@ $(eval $(call gb_Module_add_uicheck_targets,sw,\
UITest_sw_styleInspector \
UITest_sw_ui_fmtui \
UITest_sw_ui_index \
+   UITest_sw_uibase_shells \
UITest_classification \
UITest_writer_macro_tests \
UITest_writer_dialogs \
diff --git a/sw/UITest_sw_uibase_shells.mk b/sw/UITest_sw_uibase_shells.mk
new file mode 100644
index ..de9cb7c8a9d9
--- /dev/null
+++ b/sw/UITest_sw_uibase_shells.mk
@@ -0,0 +1,16 @@
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call  gb_UITest_UITest,sw_uibase_shells))
+
+$(eval $(call gb_UITest_add_modules,sw_uibase_shells,$(SRCDIR)/sw/qa/uitest,\
+   uibase/shells/ \
+))
+
+$(eval $(call gb_UITest_set_defs,sw_uibase_shells, \
+TDOC="$(SRCDIR)/sw/qa/uitest/data" \
+))
diff --git a/sw/qa/uitest/data/image-rel-size.fodt 
b/sw/qa/uitest/data/image-rel-size.fodt
new file mode 100644
index ..9df285861616
--- /dev/null
+++ b/sw/qa/uitest/data/image-rel-size.fodt
@@ -0,0 +1,40 @@
+
+
+  
+
+  
+
+
+  
+  
+  
+  
+
+
+  
+
+  
+  
+
+  
+  
+
+  iVBORw0KGgoNSUhEUgAAAEBACAQAYLlVBGdBTUEAALGPC/xhBQFz
+   UkdCAK7OHOkgY0hSTQAAeiYAAICEAAD6gOgAAHUwAADqYAAAOpgAABdwnLpRPAAA
+   AAJiS0dEAACqjSMyCW9GRnMGAAAMc1XTCXBIWXMAAA3XAAAN1wFCKJt4
+   CXZwQWcAAABMQACdMTgbAAABzUlEQVRo3u3ZPU/CQBjA8X+Jxs3ESUDj4iK+LA5+
+   BBfjqBE1cXB2MlFAEqMgxvhNNL4sLsK3UPQL6ObkoAETz+FKW2mxCPRYnucWUu76/OC59C49
+   cGOCKqrD9kHRc6ddPv7oW2WCwMh0nF63Myz7Tm8hPTNu0pgHMER3scepTbgK6enJNND83RLn
+   /878yRaPmgBZFDuMsNLeWB9gmFQHP77MIg9gsYciR50NFKvtjIy10yk84pSZA7DYpwR8scmF
+   QQCMuoQMpzbh0iAARrlnVn90CWHTsZcAiHPPdINQAuqsc2MQAAnKDUKWEhZ10twaBEDSJWQo
+   YlFj7S9CzwEegkXWIbQsRAQASFJhpplwbRAACS+hANRJBxMiAkDcJeQ4sQkBhYgMoJ+Ozlwo
+   2YQ7AJ6CRxyiUGnVy3hVKb0Af9v7hUG2Wy9TEQCUelFTDULB2S+YKYGOMcpM6UIccOQnRA6A
+   cSp6ibfI+wkGADBGpTEd8xz1AaAfTQ7huA8AvUw5hVjuA0D/C5OaMN8XACRZ8F0zCggKAQhA
+   AAIQgAAEIAABCEAAAhCAAAQgAAH4zg3feY4w3Xs44M5+oW0qvCWoGcvaIlM3x/f/ab+O738A
+   hOCNQr34oD4ldEVYdGNyZWF0ZS1kYXRlADIwMTAtMTItMjBUMTc6MDg6MzYrMDE6MDB6
+   5RscJXRFWHRtb2RpZnktZGF0ZQAyMDEwLTEyLTIwVDE3OjA4OjM3KzAxOjAwgyNmnAAA
+   AABJRU5ErkJggg==
+  
+
+  
+
diff --git a/sw/qa/uitest/uibase/shells/shells.py 
b/sw/qa/uitest/uibase/shells/shells.py
new file mode 100644

[Libreoffice-bugs] [Bug 148033] Loss of precision in /MediaBox: `nMediaBoxWidth` and `nMediaBoxHeight` in `PDFWriterImpl::emitCatalog()` should be `double` in accordance with `PDFPage::emit()`.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148033

--- Comment #5 from Julien Nabet  ---
I gave it a try, I reproduced what you described:
<>/Contents 2 0 R>>
/MediaBox[ 0 0 595 841 ]

after the patch, I got:
<>/Contents 2 0 R>>
/MediaBox[ 0 0 595.303937007874 841.889763779528 ]

I submitted the patch for review on your behalf here:
https://gerrit.libreoffice.org/c/core/+/131716
Let's wait for the feedback now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148054] With "Text to Column" function when first column hidden data is not parsed

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148054

Eike Rathke  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All
   Keywords||regression
 OS|Windows (All)   |All
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
Version|7.2.5.2 release |7.2.0.4 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148058] New: Dynamic graphics enhancement

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148058

Bug ID: 148058
   Summary: Dynamic graphics enhancement
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: promual...@net.sapo.pt

Description:
I have a spreadsheet in which I want to have everything automated without
resorting to macros. It has a dynamic graphic which is a main spreadsheet
output and I want it to update whenever I change the data in the source table.
Right now I have the source table on one sheet and the dynamic table hidden and
the dynamic graphic on another sheet. If I save the spreadsheet on the sheet
that contains the source data table and if I update it, the dynamic graphic
update, but when I visualize it, it no longer update. I only need the dynamic
table to make the dynamic graphic, because then it will be hidden. So a new
feature is that Calc always update the dynamic table/graphic after updating the
source data table. It can be with an option in the dynamic table to update
automatically and if the user don't want this situation, don't select it.

Steps to Reproduce:
1.Dynamic graphic don't update always
2.
3.

Actual Results:
The dynamic graphic only update in some cases

Expected Results:
Dynamic graphic always update 


Reproducible: Always


User Profile Reset: No



Additional Info:
Read the decription

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148057] FILEOPEN DOCX Column break disappears in 1 column per page document

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148057

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 178944
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178944=edit
The example file in Word and Writer master

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108771] [META] DOCX (OOXML) page-related issues

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108771

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||148057


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148057
[Bug 148057] FILEOPEN DOCX Column break disappears in 1 column per page
document
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148057] New: FILEOPEN DOCX Column break disappears in 1 column per page document

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148057

Bug ID: 148057
   Summary: FILEOPEN DOCX Column break disappears in 1 column per
page document
   Product: LibreOffice
   Version: 4.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: implementationError
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 108771

This is a continuation of bug 146851

When attachment 177662 is opened, there should be a page break before the " 
Schedule 2 Particulars of the Company [and the Subsidiaries]" part around page
24.

1, Open attachment 177662 
2, Note the layout of the "Schedule 2 Particulars of the Company" text: in Word
there is a column break before it, working as a page break, in Writer it is on
the previous page of "Schedule 1 Particulars of the Investors and the Founders"

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: cfd82e7a2cc2b45b738eb0efa0827196d2de61a4
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: hu-HU
Calc: threaded

Started to look like this in 4.4, in range:

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=27b1ddff407df7bbabf51096147cf58372ad861c..af748c7fff9e57a5b95bdc569456cc0da93a1f90

of which this commit stands out as suspicious:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=382bab9412b87f82da82276332496eb28b28d4f3

author  Miklos Vajna   2014-10-20 14:43:42 +0200
committer   Miklos Vajna   2014-10-20 15:23:50
+0200
commit  382bab9412b87f82da82276332496eb28b28d4f3 (patch)

DOCX import: fix  wrt. inherited styles

Before the commit range there was a whole empty page in place of the column
break, so it was not good either.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108771
[Bug 108771] [META] DOCX (OOXML) page-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148040] When called through the FunctionAccess service, the INDIRECT function does not process the external reference.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148040

--- Comment #6 from Vladimir Sokolinskiy  ---
Mike, thank you very much!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147045] Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147045

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #8 from Buovjaga  ---
(In reply to Telesto from comment #5)
> Which version of macOS are you using? Monterey?

Marco: can you reply?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148056] EDITING wrapped text not removed from cell when deleting

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148056

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Mike Kaganski  ---


*** This bug has been marked as a duplicate of bug 143709 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114286] Move uno command entries from module specific xcu file to GenericCommands.xcu

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114286

--- Comment #17 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/52a695d2ceb4231a9fcc419959e29023ecef037b

Related tdf#114286: put duplicates commands in GenericCommands (DeleteRows)

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: officecfg/registry

2022-03-17 Thread Julien Nabet (via logerrit)
 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu|
8 -
 officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu |
8 -
 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |   
14 ++
 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu  |   
14 --
 4 files changed, 14 insertions(+), 30 deletions(-)

New commits:
commit 52a695d2ceb4231a9fcc419959e29023ecef037b
Author: Julien Nabet 
AuthorDate: Thu Mar 17 11:01:47 2022 +0100
Commit: Julien Nabet 
CommitDate: Thu Mar 17 17:46:29 2022 +0100

Related tdf#114286: put duplicates commands in GenericCommands (DeleteRows)

Change-Id: I100297d10b2643c5ddad7753a7c1032526ce06cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131699
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
index 4dec87c0d8ac..9d9abf01a239 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
@@ -1095,14 +1095,6 @@
   Data ~Validation...
 
   
-  
-
-  Delete Rows
-
-
-  1
-
-  
   
 
   Insert
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
index b92e50e53f3f..ee4ba7829da5 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
@@ -2026,14 +2026,6 @@
   1
 
   
-  
-
-  Delete Row
-
-
-  1
-
-  
   
 
   Delete Table
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index c6189f593075..56b927eb98b8 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -7054,6 +7054,20 @@ bit 3 (0x8): #define 
UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8
   1
 
   
+  
+
+  Delete Rows
+
+
+  ~Rows
+
+
+  Delete selected rows
+
+
+  1
+
+  
   
 
   Manage Language
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index 55fcb9f31414..e8d5a1baf545 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -1633,20 +1633,6 @@
   1
 
   
-  
-
-  Delete Rows
-
-
-  ~Rows
-
-
-  Delete selected rows
-
-
-  1
-
-  
   
 
   Delete Table


[Libreoffice-bugs] [Bug 148056] New: EDITING wrapped text not removed from cell when deleting

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148056

Bug ID: 148056
   Summary: EDITING wrapped text not removed from cell when
deleting
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: phoe...@apollonus.net

Created attachment 178943
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178943=edit
End of cell not redrawn when editing.

When deleting contents of the cell with "wrap" enabled, the text below editing
point is not removed until the cell contents is confirmed (lost focus).


Please see attached image for the bug.

Steps to reproduce it:

a) enable wrapping
b) enter enough text to make it wrap into next line
c) navigate to the middle of the text (not the last line) and start removing
characters. Look below. The text gets duplicated (last line is not redrawn).

In the attached image, I wrote 1-14 and hit return. Then double-clicked after 6
and started removing words. Please note fourteen is duplicated because the last
row is not redrawn [cleared].

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148042] Base reports crash on Mageia 8 when opened, but not when edited

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148042

--- Comment #8 from Julien Nabet  ---
Thank you for your feedback.
With which LO version was it ok? (if there was one) from 7.1 branch? from 7.0
branch or even older?

Would it be possible you attach an example file? (after having sanitized it if
needed, see
https://wiki.documentfoundation.org/QA/Bugzilla/Sanitizing_Files_Before_Submission).

Just for info, I got:
openjdk 11.0.14 2022-01-18
OpenJDK Runtime Environment (build 11.0.14+9-post-Debian-1)
OpenJDK 64-Bit Server VM (build 11.0.14+9-post-Debian-1, mixed mode, sharing)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

2022-03-17 Thread Caolán McNamara (via logerrit)
 vcl/source/filter/svm/SvmConverter.cxx |   35 ++---
 1 file changed, 15 insertions(+), 20 deletions(-)

New commits:
commit e1e65c9388a9f2fe7b8dc34a5a10f14f08635720
Author: Caolán McNamara 
AuthorDate: Thu Mar 17 11:57:10 2022 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 17 17:27:33 2022 +0100

ofz: Use-of-uninitialized-value

Change-Id: I7d9bb71cc3448e5552005ecac580e50073260e8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131706
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/filter/svm/SvmConverter.cxx 
b/vcl/source/filter/svm/SvmConverter.cxx
index 36fc1d43f7db..90ae5f9ccf70 100644
--- a/vcl/source/filter/svm/SvmConverter.cxx
+++ b/vcl/source/filter/svm/SvmConverter.cxx
@@ -878,10 +878,10 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 
 case GDI_PEN_ACTION:
 {
-sal_Int32 nPenWidth;
-sal_Int16 nPenStyle;
-
 ImplReadColor( rIStm, aActionColor );
+
+sal_Int32 nPenWidth(0);
+sal_Int16 nPenStyle(0);
 rIStm.ReadInt32( nPenWidth ).ReadInt16( nPenStyle );
 
 aLineInfo.SetStyle( nPenStyle ? LineStyle::Solid : 
LineStyle::NONE );
@@ -894,10 +894,9 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 
 case GDI_FILLBRUSH_ACTION:
 {
-sal_Int16 nBrushStyle;
-
 ImplReadColor( rIStm, aActionColor );
 rIStm.SeekRel( 6 );
+sal_Int16 nBrushStyle(0);
 rIStm.ReadInt16( nBrushStyle );
 rMtf.AddAction( new MetaFillColorAction( aActionColor, 
nBrushStyle != 0 ) );
 rIStm.SeekRel( 2 );
@@ -919,10 +918,10 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 case GDI_CLIPREGION_ACTION:
 {
 vcl::Region  aRegion;
-sal_Int16   nRegType;
-sal_Int16   bIntersect;
 boolbClip = false;
 
+sal_Int16 nRegType(0);
+sal_Int16 bIntersect(0);
 rIStm.ReadInt16( nRegType ).ReadInt16( bIntersect );
 ImplReadRect( rIStm, aRect );
 
@@ -1003,8 +1002,8 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 case GDI_RASTEROP_ACTION:
 {
 RasterOpeRasterOp;
-sal_Int16   nRasterOp;
 
+sal_Int16 nRasterOp(0);
 rIStm.ReadInt16( nRasterOp );
 
 switch( nRasterOp )
@@ -1064,20 +1063,16 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& 
rIStm, GDIMetaFile& rMtf )
 
 case GDI_GRADIENT_ACTION:
 {
-Color   aStartCol;
-Color   aEndCol;
-sal_Int16   nStyle;
-sal_Int16   nAngle;
-sal_Int16   nBorder;
-sal_Int16   nOfsX;
-sal_Int16   nOfsY;
-sal_Int16   nIntensityStart;
-sal_Int16   nIntensityEnd;
-
 ImplReadRect( rIStm, aRect );
+
+sal_Int16 nStyle(0);
 rIStm.ReadInt16( nStyle );
+
+Color aStartCol, aEndCol;
 ImplReadColor( rIStm, aStartCol );
 ImplReadColor( rIStm, aEndCol );
+
+sal_Int16 nAngle(0), nBorder(0), nOfsX(0), nOfsY(0), 
nIntensityStart(0), nIntensityEnd(0);
 rIStm.ReadInt16( nAngle ).ReadInt16( nBorder ).ReadInt16( 
nOfsX ).ReadInt16( nOfsY ).ReadInt16( nIntensityStart ).ReadInt16( 
nIntensityEnd );
 
 Gradient aGrad( static_cast(nStyle), aStartCol, 
aEndCol );
@@ -1147,7 +1142,7 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 case GDI_REFPOINT_COMMENT:
 {
 Point   aRefPoint;
-boolbSet;
+bool bSet(false);
 sal_Int32 nFollowingActionCount(0);
 
 aSerializer.readPoint(aRefPoint);
@@ -1168,7 +1163,7 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 case GDI_TEXTLINECOLOR_COMMENT:
 {
 Color   aColor;
-boolbSet;
+bool bSet(false);
 sal_Int32 nFollowingActionCount(0);
 
 aSerializer.readColor(aColor);


[Libreoffice-commits] core.git: hwpfilter/source

2022-03-17 Thread Caolán McNamara (via logerrit)
 hwpfilter/source/hwpreader.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 8e5bc762d8b1bf80e1d2fb7706b03978acc5082f
Author: Caolán McNamara 
AuthorDate: Thu Mar 17 11:45:31 2022 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 17 17:27:11 2022 +0100

ofz#45598 Integer-overflow

Change-Id: Ib3c6f9af746693678f9b031a23e4a703d0615b0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131704
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index bfdc72c704a2..9262b4c81d30 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -3913,9 +3913,10 @@ void HwpReader::makePictureDRAW(HWPDrawingObject 
*drawobj, const Picture* hbox)
 
 basegfx::B2DPoint pt[3], r_pt[3];
 for(i = 0 ; i < 3 ; i++ ){
- pt[i].setX(pal.pt[i].x - 
drawobj->property.rot_originx);
+ basegfx::B2DPoint 
rot_origin(drawobj->property.rot_originx, drawobj->property.rot_originy);
+ pt[i].setX(pal.pt[i].x - rot_origin.getX());
  /* Convert to a physical coordinate */
- pt[i].setY(-(pal.pt[i].y - 
drawobj->property.rot_originy));
+ pt[i].setY(-(pal.pt[i].y - rot_origin.getY()));
 }
 
 double skewX;


[Libreoffice-commits] core.git: hwpfilter/source

2022-03-17 Thread Caolán McNamara (via logerrit)
 hwpfilter/source/hwpreader.cxx |   24 
 1 file changed, 12 insertions(+), 12 deletions(-)

New commits:
commit a89c16d8f37effc1be0898fc268d7b88c0157407
Author: Caolán McNamara 
AuthorDate: Thu Mar 17 11:40:19 2022 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 17 17:26:51 2022 +0100

can use a reference instead of a pointer

Change-Id: I3811c9d24e4890022be7c6179148d0eac0e5525c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131703
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 5d364586310a..bfdc72c704a2 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -3909,13 +3909,13 @@ void HwpReader::makePictureDRAW(HWPDrawingObject 
*drawobj, const Picture* hbox)
 {
 
 int i;
-ZZParall *pal = >property.parall;
+ZZParall& pal = drawobj->property.parall;
 
 basegfx::B2DPoint pt[3], r_pt[3];
 for(i = 0 ; i < 3 ; i++ ){
- pt[i].setX(pal->pt[i].x - 
drawobj->property.rot_originx);
+ pt[i].setX(pal.pt[i].x - 
drawobj->property.rot_originx);
  /* Convert to a physical coordinate */
- pt[i].setY(-(pal->pt[i].y - 
drawobj->property.rot_originy));
+ pt[i].setY(-(pal.pt[i].y - 
drawobj->property.rot_originy));
 }
 
 double skewX;
@@ -3942,20 +3942,20 @@ void HwpReader::makePictureDRAW(HWPDrawingObject 
*drawobj, const Picture* hbox)
 if( skewX != 0.0 && rotate != 0.0 ){
 trans = "skewX (" + OUString::number(skewX)
  + ") rotate (" + OUString::number(rotate)
- + ") translate (" + OUString::number(WTMM(x + a + 
drawobj->offset2.x + pal->pt[0].x)) + "mm "
- + OUString::number(WTMM(y + b + 
drawobj->offset2.y + pal->pt[0].y)) + "mm)";
+ + ") translate (" + OUString::number(WTMM(x + a + 
drawobj->offset2.x + pal.pt[0].x)) + "mm "
+ + OUString::number(WTMM(y + b + 
drawobj->offset2.y + pal.pt[0].y)) + "mm)";
 bIsRotate = true;
 }
 else if( skewX != 0.0 ){
 trans = "skewX (" + OUString::number(skewX)
- + ") translate (" + OUString::number(WTMM(x + a + 
drawobj->offset2.x + pal->pt[0].x)) + "mm "
- + OUString::number(WTMM(y + b + 
drawobj->offset2.y + pal->pt[0].y)) + "mm)";
+ + ") translate (" + OUString::number(WTMM(x + a + 
drawobj->offset2.x + pal.pt[0].x)) + "mm "
+ + OUString::number(WTMM(y + b + 
drawobj->offset2.y + pal.pt[0].y)) + "mm)";
 bIsRotate = true;
 }
 else if( rotate != 0.0 ){
 trans = "rotate (" + OUString::number(rotate)
- + ") translate (" + OUString::number(WTMM(x + a + 
drawobj->offset2.x + pal->pt[0].x)) + "mm "
- + OUString::number(WTMM(y + b + 
drawobj->offset2.y + pal->pt[0].y)) + "mm)";
+ + ") translate (" + OUString::number(WTMM(x + a + 
drawobj->offset2.x + pal.pt[0].x)) + "mm "
+ + OUString::number(WTMM(y + b + 
drawobj->offset2.y + pal.pt[0].y)) + "mm)";
 bIsRotate = true;
 }
 if( bIsRotate ){
@@ -4129,10 +4129,10 @@ void HwpReader::makePictureDRAW(HWPDrawingObject 
*drawobj, const Picture* hbox)
 
 if( drawobj->type == HWPDO_ADVANCED_ARC ){
 double start_angle, end_angle;
-ZZParall *pal = >property.parall;
+ZZParall& pal = drawobj->property.parall;
 
-start_angle = atan2(pal->pt[0].y - 
pal->pt[1].y,pal->pt[1].x - pal->pt[0].x );
-end_angle = atan2(pal->pt[2].y - pal->pt[1].y, 
pal->pt[1].x - pal->pt[2].x);
+start_angle = atan2(pal.pt[0].y - 
pal.pt[1].y,pal.pt[1].x - pal.pt[0].x );
+end_angle = atan2(pal.pt[2].y - pal.pt[1].y, 
pal.pt[1].x - pal.pt[2].x);
 
 if( ( start_angle > end_angle ) && 
(start_angle - end_angle < M_PI )){
 double tmp_angle = start_angle;


[Libreoffice-bugs] [Bug 148055] New: Template fields can't be properly edited

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148055

Bug ID: 148055
   Summary: Template fields can't be properly edited
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: y...@rawbw.com

This document https://people.freebsd.org/~yuri/doc-with-template-fields.doc
contains template fields, particularly in the first line of text.

After some text is typed into the template field, spaces can't be removed - the
hyphens are being added instead of removed characters.

When this document is uploaded to Google Docs - it allows to edit template
fields properly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148054] New: With "Text to Column" function when first column hidden data is not parsed

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148054

Bug ID: 148054
   Summary: With "Text to Column" function when first column
hidden data is not parsed
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jamb...@gmail.com

1. Copy and Paste this data into a single column:
Expires 3/8/22
Expires 3/8/22
Expires 4/30/22

2. Select all three rows

3. Data -> Text to columns

4. Select Fixed Width

5. In 'Fields' Set a dividing mark at position 8, just before the Date in the
data

6. Choose 'Hide' for the first column Type and 'Date (MDY)' for the second
column.

7. Click the 'OK' button.

8. Observe: Data is not parsed, it's unchanged in the original column.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147528] [FEATURE REQUEST] LibreOffice Writer - Review > Combine multiple documents with comments function (MS Word similar)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147528

--- Comment #7 from Bella vGFH  ---
(In reply to Heiko Tietze from comment #6)
> (In reply to Bella vGFH from comment #4)
> > [!!!] ACCEPT/ REJECT window comes up. Document owner *DOES NOT* ACCEPT OR
> > REJECT ANYTHING BUT JUST HITS *CLOSE*.
> 
> Merging documents is a different action than managing changes. Your comment
> sounds as if you take this dialog as a confirmation for the merge operation.
> 
> So the actual request is not a bug neither requires enhancement. It might be
> a documentation gap. Do you agree, Bella?
> 
> Laszlo, can we improve the situation at combining documents from comment 5?

Hi Heiko,
Sorry, not that much into nomenclature, just trying to get a job done ;)
But yes, I do indeed see managing changes as something different than merging
documents. Then again, I did notice, playing around with this, that merging
documents can also mean "just gluing them together", which in my use case would
lead to a multiplication of the same text.
In addition, there is I mentioned earlier; if a reviewer takes a (later)
version of one of the other reviewers who shared their comments earlier, the
"just hit close" work around does not work. This means bottom line that:
[] Yes, LO can combine the documents *with* their comments if all reviewers
start/ work in the original document (original.odf) exclusively.
[] However, if reviewers work in one of the later versions, adding their
changes/ comments to a later version of one of the other reviewers, then LO
throws an error (and I have to resort to the COMBINE" function of MS Word).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 147528] [FEATURE REQUEST] LibreOffice Writer - Review > Combine multiple documents with comments function (MS Word similar)

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147528

--- Comment #7 from Bella vGFH  ---
(In reply to Heiko Tietze from comment #6)
> (In reply to Bella vGFH from comment #4)
> > [!!!] ACCEPT/ REJECT window comes up. Document owner *DOES NOT* ACCEPT OR
> > REJECT ANYTHING BUT JUST HITS *CLOSE*.
> 
> Merging documents is a different action than managing changes. Your comment
> sounds as if you take this dialog as a confirmation for the merge operation.
> 
> So the actual request is not a bug neither requires enhancement. It might be
> a documentation gap. Do you agree, Bella?
> 
> Laszlo, can we improve the situation at combining documents from comment 5?

Hi Heiko,
Sorry, not that much into nomenclature, just trying to get a job done ;)
But yes, I do indeed see managing changes as something different than merging
documents. Then again, I did notice, playing around with this, that merging
documents can also mean "just gluing them together", which in my use case would
lead to a multiplication of the same text.
In addition, there is I mentioned earlier; if a reviewer takes a (later)
version of one of the other reviewers who shared their comments earlier, the
"just hit close" work around does not work. This means bottom line that:
[] Yes, LO can combine the documents *with* their comments if all reviewers
start/ work in the original document (original.odf) exclusively.
[] However, if reviewers work in one of the later versions, adding their
changes/ comments to a later version of one of the other reviewers, then LO
throws an error (and I have to resort to the COMBINE" function of MS Word).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148042] Base reports crash on Mageia 8 when opened, but not when edited

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148042

--- Comment #7 from i027...@gmail.com ---
(In reply to Julien Nabet from comment #4)
> Do you have Java installed too? If yes, could you indicate package (openjdk,
> Java from Oracle, ...), version + if it's 32 or 64 bits ?

java-1.8.0-openjdk - OpenJDK 8 Runtime Environment​

The OpenJDK 8 runtime environment. 

Versión: 1:1.8.0.312.b07-2.1.mga8

Versión instalada actualmente: 1:1.8.0.312.b07-2.1.mga8

Grupo: Desarrollo/Java

Arquitectura: x86_64

Tamaño: 664 KB

Medio: Ninguno (instalado)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148037] LibreOffice 7.2.5.2 (x64) will not open on Windows 11 home

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148037

--- Comment #4 from m50wal...@gmail.com ---
I have 3 questions.  First, since LO will not open even in safe mode on my
Windows 11 laptop, what if I rename the LO profile folder and it still does not
open, even in safe mode?  Do I then restore the original LO profile folder?

Second, where do I type the set and path-to statements, and how do I get there
in Windows 11?

Third, it seems like it would be safer to keep using LO version 7.1.8 on my
Windows 11 laptop and LO version 7.2.5 on my Windows 7 desktop, since both
versions work fine in the different Windows versions.  Possibly I could wait
until another version of LO comes out and try installing that newer version on
the laptop?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 45854] ODF database mime-type confusion

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45854

--- Comment #13 from Michael Stahl (allotropia)  
---
the ODF TC is currently trying to figure out how to get this resolved with IANA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148040] When called through the FunctionAccess service, the INDIRECT function does not process the external reference.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148040

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107659
Bug 107659 depends on bug 148040, which changed state.

Bug 148040 Summary: When called through the FunctionAccess service, the 
INDIRECT function does not process the external reference.
https://bugs.documentfoundation.org/show_bug.cgi?id=148040

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148024] Footnotes in sections are disabled when save, close and reopen file

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148024

--- Comment #4 from gmoll...@us.es ---
Created attachment 178942
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178942=edit
menu for change footnote in a section

See the screenshot with the menu where to change the character type: menu
Format - Sections... select Section1 and push the button Options... then
activate [v] Custom format and select the characters: *, ♱, ...

If save, close and open the file, that option "Custom format" is deactivated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148040] When called through the FunctionAccess service, the INDIRECT function does not process the external reference.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148040

--- Comment #5 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7f58df88771767962fc4e98f2b6bed445ab18994

tdf#148040: allow external link update for css.sheet.FunctionAccess

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148040] When called through the FunctionAccess service, the INDIRECT function does not process the external reference.

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148040

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa sc/source

2022-03-17 Thread Mike Kaganski (via logerrit)
 sc/qa/extras/macros-test.cxx |   21 +
 sc/source/ui/docshell/externalrefmgr.cxx |2 +-
 2 files changed, 22 insertions(+), 1 deletion(-)

New commits:
commit 7f58df88771767962fc4e98f2b6bed445ab18994
Author: Mike Kaganski 
AuthorDate: Thu Mar 17 00:28:07 2022 +0300
Commit: Mike Kaganski 
CommitDate: Thu Mar 17 16:19:32 2022 +0100

tdf#148040: allow external link update for css.sheet.FunctionAccess

Change-Id: I2608c10fd3354e90049d1c7315895922c865a648
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131682
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/qa/extras/macros-test.cxx b/sc/qa/extras/macros-test.cxx
index 0d1be3d710c7..e69feea0e8ac 100644
--- a/sc/qa/extras/macros-test.cxx
+++ b/sc/qa/extras/macros-test.cxx
@@ -13,12 +13,14 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
 #include 
 #include 
 
+#include 
 #include 
 
 #include 
@@ -68,6 +70,7 @@ public:
 void testMacroButtonFormControlXlsxExport();
 void testShapeLayerId();
 void testVbaRangeSort();
+void testFunctionAccessIndirect();
 
 CPPUNIT_TEST_SUITE(ScMacrosTest);
 CPPUNIT_TEST(testStarBasic);
@@ -99,6 +102,7 @@ public:
 CPPUNIT_TEST(testMacroButtonFormControlXlsxExport);
 CPPUNIT_TEST(testShapeLayerId);
 CPPUNIT_TEST(testVbaRangeSort);
+CPPUNIT_TEST(testFunctionAccessIndirect);
 
 CPPUNIT_TEST_SUITE_END();
 };
@@ -1158,6 +1162,23 @@ void ScMacrosTest::testVbaRangeSort()
 pDocSh->DoClose();
 }
 
+void ScMacrosTest::testFunctionAccessIndirect()
+{
+OUString aFileName;
+createFileURL(u"tdf120161.ods", aFileName); // just some document with 
known values in cells
+const OUString aReference = "'" + aFileName + "'#$Sheet1.A1";
+
+css::uno::Reference xFunc(
+
comphelper::getProcessServiceFactory()->createInstance("com.sun.star.sheet.FunctionAccess"),
+UNO_QUERY_THROW);
+
+// tdf#148040: without the fix in plcae, this would have failed with:
+//   An uncaught exception of type 
com.sun.star.lang.IllegalArgumentException
+// because of disallowed external link update (needed to obtain the cell 
value).
+css::uno::Any aResult = xFunc->callFunction("INDIRECT", 
{css::uno::Any(aReference)});
+CPPUNIT_ASSERT_EQUAL(css::uno::Any(OUString("a1")), aResult);
+}
+
 ScMacrosTest::ScMacrosTest()
   : UnoApiTest("/sc/qa/extras/testdocuments")
 {
diff --git a/sc/source/ui/docshell/externalrefmgr.cxx 
b/sc/source/ui/docshell/externalrefmgr.cxx
index c25a79f1f919..3d1845cbeacb 100644
--- a/sc/source/ui/docshell/externalrefmgr.cxx
+++ b/sc/source/ui/docshell/externalrefmgr.cxx
@@ -1655,7 +1655,7 @@ bool isLinkUpdateAllowedInDoc(const ScDocument& rDoc)
 {
 SfxObjectShell* pDocShell = rDoc.GetDocumentShell();
 if (!pDocShell)
-return false;
+return rDoc.IsFunctionAccess();
 
 return pDocShell->GetEmbeddedObjectContainer().getUserAllowsLinkUpdate();
 }


[Libreoffice-bugs] [Bug 147971] The text automatically subscripted and the format changed

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147971

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEW |UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147960] The text become subscript in libreoffice but not in microsoft word

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147960

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - vcl/jsdialog

2022-03-17 Thread Szymon Kłos (via logerrit)
 vcl/jsdialog/enabled.cxx |   15 +++
 1 file changed, 15 insertions(+)

New commits:
commit 6402b065aef78f0b6533ebdb74d3a81bf954c625
Author: Szymon Kłos 
AuthorDate: Tue Mar 15 10:09:43 2022 +0100
Commit: Szymon Kłos 
CommitDate: Thu Mar 17 16:13:29 2022 +0100

jsdialog: enable dialog on demand by env var

It will be possible to enable some dialogs by environment variable:


SAL_JSDIALOG_ENABLE=modules/scalc/ui/validationdialog.ui:modules/scalc/ui/validationcriteriapage.ui

(you can specify multiple items with ':' separator)

Change-Id: Iba1e6b7ac77716f40c9073a8064206c420f2d081
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131600
Tested-by: Szymon Kłos 
Reviewed-by: Szymon Kłos 

diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index 9aa8d19db108..99e20b17bb71 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -7,7 +7,9 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
 #include 
+#include 
 
 namespace jsdialog
 {
@@ -60,6 +62,19 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool 
bMobile)
 return true;
 }
 
+const char* pEnabledDialog = getenv("SAL_JSDIALOG_ENABLE");
+if (pEnabledDialog)
+{
+OUString sAllEnabledDialogs(pEnabledDialog, strlen(pEnabledDialog), 
RTL_TEXTENCODING_UTF8);
+std::vector aEnabledDialogsVector
+= comphelper::string::split(sAllEnabledDialogs, ':');
+for (const auto& rDialog : aEnabledDialogsVector)
+{
+if (rUIFile == rDialog)
+return true;
+}
+}
+
 return false;
 }
 


[Libreoffice-bugs] [Bug 148029] Colibre Dark icons with dark background should be made transparent

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148029

--- Comment #1 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6898a115426de6c3142521587fa693914fbe553f

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148029] Colibre Dark icons with dark background should be made transparent

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148029

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_dark icon-themes/colibre_dark_svg icon-themes/colibre_svg

2022-03-17 Thread Rizal Muttaqin (via logerrit)
 icon-themes/colibre/cmd/32/autocontrolfocus.png  
|binary
 icon-themes/colibre/cmd/32/filecontrol.png   
|binary
 icon-themes/colibre/cmd/32/imagecontrol.png  
|binary
 icon-themes/colibre/cmd/32/insertvideo.png   
|binary
 icon-themes/colibre/cmd/32/morecontrols.png  
|binary
 icon-themes/colibre/cmd/32/refreshformcontrol.png
|binary
 icon-themes/colibre/cmd/lc_advancedmode.png  
|binary
 icon-themes/colibre/cmd/lc_aligncenter.png   
|binary
 icon-themes/colibre/cmd/lc_aligndown.png 
|binary
 icon-themes/colibre/cmd/lc_alignmiddle.png   
|binary
 icon-themes/colibre/cmd/lc_alignup.png   
|binary
 icon-themes/colibre/cmd/lc_animationeffects.png  
|binary
 icon-themes/colibre/cmd/lc_animationmode.png 
|binary
 icon-themes/colibre/cmd/lc_animationobjects.png  
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.chevron.png   
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.circular-arrow.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.corner-right-arrow.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.down-arrow-callout.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.down-arrow.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.left-arrow-callout.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.left-arrow.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.left-right-arrow-callout.png  
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.notched-right-arrow.png   
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.pentagon-right.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.png   
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.quad-arrow-callout.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.quad-arrow.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.right-arrow-callout.png   
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.right-arrow.png   
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.s-sharped-arrow.png   
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.split-arrow.png   
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.split-round-arrow.png 
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.striped-right-arrow.png   
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.up-arrow-callout.png  
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.up-arrow.png  
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.up-down-arrow-callout.png 
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.up-down-arrow.png 
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.up-right-arrow-callout.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.up-right-arrow.png
|binary
 icon-themes/colibre/cmd/lc_arrowshapes.up-right-down-arrow.png   
|binary
 icon-themes/colibre/cmd/lc_autocontrolfocus.png  
|binary
 icon-themes/colibre/cmd/lc_autoformat.png
|binary
 icon-themes/colibre/cmd/lc_changepicture.png 
|binary
 icon-themes/colibre/cmd/lc_changepolygon.png 
|binary
 icon-themes/colibre/cmd/lc_choosecontrols.png
|binary
 icon-themes/colibre/cmd/lc_closepreview.png  
|binary
 icon-themes/colibre/cmd/lc_commentchangetracking.png 
|binary
 icon-themes/colibre/cmd/lc_comparedocuments.png  
|binary
 icon-themes/colibre/cmd/lc_compilebasic.png  
|binary
 icon-themes/colibre/cmd/lc_controlproperties.png 
|binary
 icon-themes/colibre/cmd/lc_filecontrol.png   
|binary
 icon-themes/colibre/cmd/lc_insertvideo.png   
|binary
 icon-themes/colibre/cmd/lc_morecontrols.png  
|binary
 icon-themes/colibre/cmd/lc_refreshformcontrol.png
|binary
 icon-themes/colibre/cmd/sc_autocontrolfocus.png  
|binary
 icon-themes/colibre/cmd/sc_imagecontrol.png  
|binary
 icon-themes/colibre/cmd/sc_insertvideo.png   
|binary
 

[Libreoffice-bugs] [Bug 141207] [EDITING] Undo and text data can confuse top-N formatting

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141207

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 Whiteboard| QA:needsComment|

--- Comment #1 from Buovjaga  ---
No problem here. Can you test with 7.3?

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 71b952340726190d1f178ef0dadfa89677f2c1dd
CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147971] The text automatically subscripted and the format changed

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147971

joebros  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143002] [META] Tracked Changes of tables

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143002
Bug 143002 depends on bug 147347, which changed state.

Bug 147347 Summary: Deleting rows with track changes enabled behaving kind of 
strange
https://bugs.documentfoundation.org/show_bug.cgi?id=147347

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147960] The text become subscript in libreoffice but not in microsoft word

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147960

joebros  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 141140] GTK3: menubuttons toggled states not visually consistent throughout the toolbars

2022-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141140

Buovjaga  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  1   2   3   >