[Libreoffice-bugs] [Bug 150657] CALC Chart elements disappear when the data columns are hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=150657 --- Comment #5 from Colin --- Created attachment 182910 --> https://bugs.documentfoundation.org/attachment.cgi?id=182910=edit Image of two edit panes identifying the culprit -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150657] CALC Chart elements disappear when the data columns are hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=150657 --- Comment #4 from Colin --- Found the source of the issue (and the workaround pending a fix) If the Data range is edited then saving the edit disables the inclusion of hidden cells but leaves the checkbox indicating that they are included. The simple workaround is:- Edit and save the Range adjustment Hide the columns Unhide the columns Edit -Disable- the inclusion Save the change Edit -Re-enable- the inclusion Save the change Hide the columns It may be that all the hiding and unhiding are superfluous and that simply editing the range and inclusion parameter together are the "workaround". Image attached -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142446] In folding outlines, enable specifying, document-wide, the level to which text should be collapsed.
https://bugs.documentfoundation.org/show_bug.cgi?id=142446 --- Comment #5 from j.a.sw...@gmail.com --- Beautiful. The tip for "level 0" is especially useful. The label for the UNO function "Fold All Content Of Ouline Level" could be clearer. I suggest: "Fold all outline content to level." (I'd say "specified level," but that seems too long.) Many thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151417] Editing with Draw, activating Form controls, selecting one, LO crash without code number.
https://bugs.documentfoundation.org/show_bug.cgi?id=151417 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151150] very long time to execute a macro when libreoffice calc file is started after start of the system (7mn) since V7
https://bugs.documentfoundation.org/show_bug.cgi?id=151150 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147913] VIEWING: Formatted date results from Vlookup will not appear as expected
https://bugs.documentfoundation.org/show_bug.cgi?id=147913 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147913] VIEWING: Formatted date results from Vlookup will not appear as expected
https://bugs.documentfoundation.org/show_bug.cgi?id=147913 --- Comment #3 from QA Administrators --- Dear henrick.silva, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147512] program is crashed while set printer settings in calc printing
https://bugs.documentfoundation.org/show_bug.cgi?id=147512 --- Comment #4 from QA Administrators --- Dear anthonio, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147512] program is crashed while set printer settings in calc printing
https://bugs.documentfoundation.org/show_bug.cgi?id=147512 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94510] Validity list of dates converted to numbers inside list
https://bugs.documentfoundation.org/show_bug.cgi?id=94510 --- Comment #7 from QA Administrators --- Dear Marcelo, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92059] Spell Check: Shows incorrect for the correctly spelled words and URLs
https://bugs.documentfoundation.org/show_bug.cgi?id=92059 --- Comment #5 from QA Administrators --- Dear muthu, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 87476] EDITING: "Validity..." functional to unprotected cells when sheet is protected
https://bugs.documentfoundation.org/show_bug.cgi?id=87476 --- Comment #7 from QA Administrators --- Dear Patrick, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132113] Opening PPS or PPSX slideshow using -o command line, the slideshow still opens in --show mode
https://bugs.documentfoundation.org/show_bug.cgi?id=132113 --- Comment #7 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135864] FILEOPEN Text Wrap with URL in the cell is not applied from .xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=135864 --- Comment #4 from QA Administrators --- Dear Khalil, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125600] Calc spellcheck does not recognize correct spelling of KWh
https://bugs.documentfoundation.org/show_bug.cgi?id=125600 --- Comment #4 from QA Administrators --- Dear Tracy, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122231] Fontwork not selectable if placed over a picture
https://bugs.documentfoundation.org/show_bug.cgi?id=122231 --- Comment #7 from QA Administrators --- Dear reikenberg, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122167] "List" Field from FireBird query doesn't show up at mail merging
https://bugs.documentfoundation.org/show_bug.cgi?id=122167 --- Comment #4 from QA Administrators --- Dear Alex Ander, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116833] Unticking "Save preview image with this document" before resetting properties will make modified date appear after save & reload
https://bugs.documentfoundation.org/show_bug.cgi?id=116833 --- Comment #18 from QA Administrators --- Dear ga3893hnd, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121076] Can't select/pick multiples lines or items in tables with CTRL key
https://bugs.documentfoundation.org/show_bug.cgi?id=121076 --- Comment #8 from QA Administrators --- Dear Regis Perdreau, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116582] Sometimes suggestions for French spelling corrections no longer appear in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=116582 --- Comment #7 from QA Administrators --- Dear Frédéric MASSOT, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114559] copy paste from Calc to Writer defective
https://bugs.documentfoundation.org/show_bug.cgi?id=114559 --- Comment #4 from QA Administrators --- Dear fredo69008, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114343] Adding a new Title Page via Format > Title Page is impossible with a ToC in document
https://bugs.documentfoundation.org/show_bug.cgi?id=114343 --- Comment #9 from QA Administrators --- Dear Clemens Prill, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151359] Locale data: The DefaultName for CountryID "TW" should be "Taiwan (Province of China)" rather than "Taiwan"
https://bugs.documentfoundation.org/show_bug.cgi?id=151359 --- Comment #20 from Kevin Suo --- (In reply to Mark Hung from comment #19) > Taiwan in many situations has been forced to use a different name or even > hide its name in order to satisfy China government. We're good with the name > itself. ..., in response to a political request from China is bad for TDF Mark Hung, you force me to continue the political debate here. I should emphasize again that it was not me who started this discussion deliberately, and it was not the "China government" who started this debate here. I am not a China government agent. It was someone who put that "Taiwan" name in a "Country" tag many years ago in the Aoo ara, which is the cause of my request here. Someone had did it wrong first, and then I jump here to point out his wrong doing, then do you think I am wrong? The name "Taiwan" is also good to me itself, but as I said, it is wrong to treat it as a "Country" or put it within a tag in the code by the TDF. Stop muddy the waters and only post if you have any other technical opinion. I tag the two comments as "obsolete" so they hide in this bug report by default. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151359] Locale data: The DefaultName for CountryID "TW" should be "Taiwan (Province of China)" rather than "Taiwan"
https://bugs.documentfoundation.org/show_bug.cgi?id=151359 --- Comment #19 from Mark Hung --- > > > So far I always regarded it as a kind of comment that is preserved by all > > > XML processing.. maybe making it optional and just removing it in > > > zh_TW.xml > > > would indeed be best. > > > > Is the statement 'best' based on easiness of implementation? > Not only that. It would avoid endless political discussions about what > content would be right or wrong. Obviously whatever we put there will be > wrong for *someone*. We don't need the element for functionality, it's not > shown anywhere in the UI, so let's just get rid of it in this case. As a balance to Kevin Suo's opinion, I'd like to explain my viewpoint: Taiwan in many situations has been forced to use a different name or even hide its name in order to satisfy China government. We're good with the name itself. I think moving from what it is, which at least Taiwanese people satisfy with, either changing the DefaultName or hiding it in zh_TW.xml alone, in response to a political request from China is bad for TDF. I hope that the board can take this into consideration. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source vcl/unx
sw/source/uibase/utlui/content.cxx |6 ++ vcl/unx/gtk3/gtkinst.cxx |2 ++ 2 files changed, 8 insertions(+) New commits: commit 53d5f5e15c005d95fa8c9d24d98e26afd2ca2103 Author: Jim Raykowski AuthorDate: Fri Oct 7 02:18:05 2022 -0800 Commit: Jim Raykowski CommitDate: Sat Oct 8 02:18:24 2022 +0200 tdf#151387 Fix regression cause by tdf#149279 The gtk_tree_view_expand_to_path function not only expands all parent rows of path as necessary but also expands the children of the row of the path. This explains the difference seen between gtk3inst and salinst when a collapsed row is scrolled to. gtk3inst expands the collapsed row, salinst does not. The enhancement patch for tdf#149279 removed the gtk_tree_view_expand_to_path function from gtk_tree_view_scroll_to_row. This caused a regression in the styles tree. To fix the regression this patch reverts the removed gtk_tree_view_expand_to_path functions. To make the enhancement patch behave the same for gtk3 and sal, the scroll to row is collapsed after scrolling if that was it's state before. Change-Id: I3c3975a3f258c6c432eb866a1c712299e2faf5be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141048 Tested-by: Jenkins Reviewed-by: Jim Raykowski diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx index 9e3984333715..1605a470d438 100644 --- a/sw/source/uibase/utlui/content.cxx +++ b/sw/source/uibase/utlui/content.cxx @@ -3997,7 +3997,13 @@ void SwContentTree::UpdateTracking() while (!weld::IsEntryVisible(*m_xTreeView, *xIter)) m_xTreeView->iter_parent(*xIter); } +// Assure the scroll to row is collapsed after scrolling if it was collapsed +// before. This is required here to make gtkinst scroll_to_row behave like +// salinst. +const bool bRowExpanded = m_xTreeView->get_row_expanded(*xIter); m_xTreeView->scroll_to_row(*xIter); +if (!bRowExpanded) +m_xTreeView->collapse_row(*xIter); } bRet = true; } diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx index f0ba23618dcb..a50f98c31ee5 100644 --- a/vcl/unx/gtk3/gtkinst.cxx +++ b/vcl/unx/gtk3/gtkinst.cxx @@ -15199,6 +15199,7 @@ public: assert(gtk_tree_view_get_model(m_pTreeView) && "don't select when frozen, select after thaw. Note selection doesn't survive a freeze"); disable_notify_events(); GtkTreePath* path = gtk_tree_path_new_from_indices(pos, -1); +gtk_tree_view_expand_to_path(m_pTreeView, path); gtk_tree_view_scroll_to_cell(m_pTreeView, path, nullptr, true, 0, 0); gtk_tree_path_free(path); enable_notify_events(); @@ -15900,6 +15901,7 @@ public: disable_notify_events(); const GtkInstanceTreeIter& rGtkIter = static_cast(rIter); GtkTreePath* path = gtk_tree_model_get_path(m_pTreeModel, const_cast()); +gtk_tree_view_expand_to_path(m_pTreeView, path); gtk_tree_view_scroll_to_cell(m_pTreeView, path, nullptr, true, 0, 0); gtk_tree_path_free(path); enable_notify_events();
[Libreoffice-bugs] [Bug 151417] Editing with Draw, activating Form controls, selecting one, LO crash without code number.
https://bugs.documentfoundation.org/show_bug.cgi?id=151417 Hossein changed: What|Removed |Added Keywords||haveBacktrace --- Comment #2 from Hossein --- Backtrace created using Qt Creator: 1 sdr::properties::TextProperties::SetStyleSheet textproperties.cxx 260 0x7279f478 2 sdr::properties::RectangleProperties::SetStyleSheet rectangleproperties.cxx 61 0x727974b2 3 sdr::properties::AttributeProperties::applyDefaultStyleSheetFromSdrModel attributeproperties.cxx 535 0x727a4f4e 4 sdr::properties::AttributeProperties::GetObjectItemSet attributeproperties.cxx 261 0x727a43ff 5 SdrObject::GetObjectItemSet svdobj.cxx 1969 0x72912ee0 6 SdrTextObj::GetTextAniKind svdotext.cxx 1742 0x7299d188 7 sdr::contact::ViewContactOfSdrObj::ActionChanged viewcontactofsdrobj.cxx 104 0x7271ae84 8 SdrObject::ActionChanged svdobj.cxx 271 0x7290aba7 9 SdrObject::SetChanged svdobj.cxx 1001 0x7290db00 10 SdrUnoObj::CreateUnoControlModel svdouno.cxx 386 0x729d6231 11 SdrUnoObj::SdrUnoObj svdouno.cxx 148 0x729d4936 12 FmFormObj::FmFormObj fmobj.cxx 59 0x7251c2d4 13 FmFormObjFactory::MakeObject fmobjfac.cxx 213 0x73a6ff3f 14 FmFormObjFactory::LinkStubMakeObject fmobjfac.cxx 103 0x73a6fa98 15 Link>::Call link.hxx 111 0x7291f329 16 SdrObjFactory::CreateObjectFromFactory svdobj.cxx 3202 0x72918aa2 17 SdrObjFactory::MakeNewObject svdobj.cxx 3331 0x729193b5 18 SdrCreateView::SetCurrentObj svdcrtv.cxx 344 0x727db1b5 19 sd::FuConstructUnoControl::Activate fuconuno.cxx 112 0x7fffd31f3ba4 20 sd::DrawViewShell::FuPermanent drviewse.cxx 589 0x7fffd35c1fd6 21 SfxStubGraphicViewShellFuPermanent sdgslots.hxx 1541 0x7fffd35d2fa7 22 SfxDispatcher::Call_Impl dispatch.cxx 254 0x7482ddda 23 SfxDispatcher::PostMsgHandler dispatch.cxx 990 0x748321f6 24 std::__invoke_impl>), SfxDispatcher *&, std::unique_ptr>> invoke.h 74 0x74860633 25 std::__invoke>), SfxDispatcher *&, std::unique_ptr>> invoke.h 96 0x7485eee1 26 std::_Bind))(std::unique_ptr>)>::__call>&&, 0ul, 1ul>(std::tuple>&&>&&, std::_Index_tuple<0ul, 1ul>) functional 420 0x7485c87c 27 std::_Bind))(std::unique_ptr>)>::operator()>, void>(std::unique_ptr>&&) functional 503 0x748598ee 28 std::__invoke_impl))(std::unique_ptr>)>&, std::unique_ptr>>(std::__invoke_other, std::_Bind))(std::unique_ptr>)>&, std::unique_ptr>&&) invoke.h 61 0x74854b67 29 std::__invoke_r))(std::unique_ptr>)>&, std::unique_ptr>>(std::_Bind))(std::unique_ptr>)>&, std::unique_ptr>&&) invoke.h 111 0x7484e907 30 std::_Function_handler>), std::_Bind))(std::unique_ptr>)>>::_M_invoke(std::_Any_data const&, std::unique_ptr>&&) std_function.h 290 0x7484a47f 31 std::function>)>::operator()(std::unique_ptr>) const std_function.h 590 0x74c6defb 32 SfxHintPoster::DoEvent_Impl hintpost.cxx 43 0x74c6dd1a 33 SfxHintPoster::LinkStubDoEvent_Impl hintpost.cxx 39 0x74c6dcad 34 Link::Call link.hxx 111 0x7fffeecc9867 35 ImplHandleUserEvent winproc.cxx 2287 0x7fffeecc6648 36 ImplWindowFrameProc winproc.cxx 2857 0x7fffeecc84f6 37 SalFrame::CallCallback salframe.hxx 306 0x7fffef7767b6 38 SalGenericDisplay::ProcessEvent gendisp.cxx 66 0x7fffef79e645 39 operator() salusereventlist.cxx 119 0x7fffef349382 40 SalUserEventList::DispatchUserEvents salusereventlist.cxx 120 0x7fffef34965b 41 SalGenericDisplay::DispatchInternalEvent gendisp.cxx 51 0x7fffef79e5b1 42 SalX11Display::Yield saldisp.cxx 1896 0x7fffe4eecb09 43 DisplayYield saldisp.cxx 381 0x7fffe4ee44f3 44 (anonymous namespace)::YieldEntry::HandleNextEvent saldata.cxx 562 0x7fffe4edf0ef 45 SalXLib::Yield saldata.cxx 658 0x7fffe4edf983 46 X11SalInstance::DoYield salinst.cxx 192 0x7fffe4f02ec5 47 ImplYield svapp.cxx 475 0x7fffef40a874 48 Application::Yield svapp.cxx 559 0x7fffef40b556 49 Application::Execute svapp.cxx 453 0x7fffef40a514 50 desktop::Desktop::Main app.cxx 1604 0x77bf7e44 51 ImplSVMain svmain.cxx 203 0x7fffef42a257 52 SVMain svmain.cxx 235 0x7fffef42a380 53 soffice_main sofficemain.cxx 94 0x77c62323 54 sal_main main.c 51 0x4a60 55 main main.c 49 0x4a42 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Hossein changed: What|Removed |Added Depends on||151417 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151417 [Bug 151417] Editing with Draw, activating Form controls, selecting one, LO crash without code number. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151417] Editing with Draw, activating Form controls, selecting one, LO crash without code number.
https://bugs.documentfoundation.org/show_bug.cgi?id=151417 Hossein changed: What|Removed |Added Blocks||133092, 107742 Keywords||regression Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107742 [Bug 107742] [META] Form control bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107742] [META] Form control bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107742 Hossein changed: What|Removed |Added Depends on||151417 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151417 [Bug 151417] Editing with Draw, activating Form controls, selecting one, LO crash without code number. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151417] Editing with Draw, activating Form controls, selecting one, LO crash without code number.
https://bugs.documentfoundation.org/show_bug.cgi?id=151417 Hossein changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Hossein --- SEGFAULT with the latest LO 7.5 dev master: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 82ad6bc4e8c081bfb547ad10d29885cbdd0e8ea1 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vbahelper sc/source vbahelper/source
include/vbahelper/vbaeventshelperbase.hxx |2 ++
sc/source/ui/vba/vbaeventshelper.cxx |5 +++--
vbahelper/source/vbahelper/vbaeventshelperbase.cxx | 17 +
3 files changed, 22 insertions(+), 2 deletions(-)
New commits:
commit 6834fda784f3066a89838cd6cda4fe945f4c7904
Author: Justin Luth
AuthorDate: Thu Oct 6 20:00:07 2022 -0400
Commit: Justin Luth
CommitDate: Fri Oct 7 23:48:36 2022 +0200
related tdf#148806 xls/x vba: no auto_open if Auto_Open module
The presence of an Auto_Close module prevents any
auto_close subroutines from running.
Interestingly, Word is different. It doesn't care at all
if such a module is present. (In fact, it uses that
module's main() as an AutoClose if there is no
Sub AutoClose.)
Change-Id: I83a80b7f016dcf2ad3b7fd931acacb6f788241a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141036
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/include/vbahelper/vbaeventshelperbase.hxx
b/include/vbahelper/vbaeventshelperbase.hxx
index 0126db442ee8..e7038da7ab75 100644
--- a/include/vbahelper/vbaeventshelperbase.hxx
+++ b/include/vbahelper/vbaeventshelperbase.hxx
@@ -78,6 +78,8 @@ public:
// little helpers -
+bool hasModule(const OUString& rModuleName);
+
/** Helper to execute event handlers without throwing any exceptions. */
void processVbaEventNoThrow( sal_Int32 nEventId, const css::uno::Sequence<
css::uno::Any >& rArgs );
diff --git a/sc/source/ui/vba/vbaeventshelper.cxx
b/sc/source/ui/vba/vbaeventshelper.cxx
index bd00fdcac3bd..d412af36b466 100644
--- a/sc/source/ui/vba/vbaeventshelper.cxx
+++ b/sc/source/ui/vba/vbaeventshelper.cxx
@@ -659,7 +659,8 @@ bool ScVbaEventsHelper::implPrepareEvent( EventQueue&
rEventQueue,
rEventQueue.emplace_back(WORKBOOK_ACTIVATE );
uno::Sequence< uno::Any > aArgs{
uno::Any(mxModel->getCurrentController()) };
rEventQueue.emplace_back( WORKBOOK_WINDOWACTIVATE, aArgs );
-rEventQueue.emplace_back(AUTO_OPEN );
+if (!hasModule("Auto_Open"))
+rEventQueue.emplace_back(AUTO_OPEN );
// remember initial selection
maOldSelection <<= mxModel->getCurrentSelection();
}
@@ -779,7 +780,7 @@ void ScVbaEventsHelper::implPostProcessEvent( EventQueue&
rEventQueue,
case WORKBOOK_BEFORECLOSE:
/* Execute Auto_Close only if not cancelled by event handler, but
before UI asks user whether to cancel closing the document. */
-if( !bCancel )
+if (!bCancel && !hasModule("Auto_Close"))
rEventQueue.emplace_back(AUTO_CLOSE );
break;
}
diff --git a/vbahelper/source/vbahelper/vbaeventshelperbase.cxx
b/vbahelper/source/vbahelper/vbaeventshelperbase.cxx
index 1f92e449a156..dbd345c9bac7 100644
--- a/vbahelper/source/vbahelper/vbaeventshelperbase.cxx
+++ b/vbahelper/source/vbahelper/vbaeventshelperbase.cxx
@@ -320,6 +320,23 @@ void VbaEventsHelperBase::ensureVBALibrary()
}
}
+bool VbaEventsHelperBase::hasModule(const OUString& rModuleName)
+{
+if (rModuleName.isEmpty())
+return false;
+
+bool bRet = false;
+try
+{
+ensureVBALibrary();
+bRet = mxModuleInfos->hasModuleInfo(rModuleName);
+}
+catch (uno::Exception&)
+{}
+
+return bRet;
+}
+
sal_Int32 VbaEventsHelperBase::getModuleType( const OUString& rModuleName )
{
// make sure the VBA library exists
[Libreoffice-bugs] [Bug 151417] New: Editing with Draw, activating Form controls, selecting one, LO crash without code number.
https://bugs.documentfoundation.org/show_bug.cgi?id=151417 Bug ID: 151417 Summary: Editing with Draw, activating Form controls, selecting one, LO crash without code number. Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: miguelange...@libreoffice.org Open a new Draw file (No issue with calc and writer). Active Menu/View/Form controls Click on any control. LibreOffice crash. Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 9940a5dce79fe9dc3e6ff0302c9be8c7d1648f67 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Last version working: Version: 7.4.2.1 (x64) / LibreOffice Community Build ID: 681d65acd9ede00dd724d6716f21cabfdcc95bd2 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151304] Cursor position error.
https://bugs.documentfoundation.org/show_bug.cgi?id=151304 --- Comment #8 from LeroyG --- (In reply to LeroyG from comment #7) > Not reproducible > reproducible sometimes It happened twice, while testing in a new document (for bug #151416). But I could not find the way to reproduce it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151304] Cursor position error.
https://bugs.documentfoundation.org/show_bug.cgi?id=151304 LeroyG changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1416 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151416] [UI] Changing zoom level in one window of the same document moves the document in the other window
https://bugs.documentfoundation.org/show_bug.cgi?id=151416 LeroyG changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1304 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151416] New: [UI] Changing zoom level in one window of the same document moves the document in the other window
https://bugs.documentfoundation.org/show_bug.cgi?id=151416 Bug ID: 151416 Summary: [UI] Changing zoom level in one window of the same document moves the document in the other window Product: LibreOffice Version: 7.2.7.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: iavs.le...@gmail.com Description: As in summary. Cursor sometimes can be seen misplaced (not always reproducible). Steps to Reproduce: 1. Open a Writer document. 2. Open a new window for the same document. 3. Change zoom level in the active window. Actual Results: Actual window zoom level changes. Other window horizontal position changes. Expected Results: Actual window zoom level changes. Other window horizontal position remains the same. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.7.2 (x64) / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: default; VCL: win Locale: es-MX (es_ES); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151393] Auto_Open should not run from ThisWorkbook
https://bugs.documentfoundation.org/show_bug.cgi?id=151393 --- Comment #2 from Justin L --- Prior to Tomaž' patch, hasMacro could return true if sMod.isEmpty() and a Module named sMacroName has a "Main" macro. I think that might have been for MS Word's benefit. At least AutoOpen works that way (although our code didn't get the macroURL right). It is probably better that it doesn't return true, but just noting the difference. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/node.hxx |2 +-
sw/source/core/docnode/ndtbl.cxx |6 +++---
sw/source/filter/inc/msfilter.hxx |2 +-
sw/source/filter/ww8/writerhelper.cxx |6 +++---
4 files changed, 8 insertions(+), 8 deletions(-)
New commits:
commit 4a07e9e31a6cd93958f94354a15325af098c93b8
Author: Noel Grandin
AuthorDate: Fri Oct 7 19:41:56 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Oct 7 22:03:37 2022 +0200
use more SwPosition
part of the process of hiding the internals of SwPosition
Change-Id: I3107ad6cb8636125ec98342ec4ed69d2c703a74b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141090
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/node.hxx b/sw/inc/node.hxx
index e6176ce5b91b..1ac709ca2965 100644
--- a/sw/inc/node.hxx
+++ b/sw/inc/node.hxx
@@ -525,7 +525,7 @@ public:
/// Creates the frms for the table node (i.e. the TabFrames).
/// pIdxBehind is optional parameter.
-void MakeOwnFrames(SwNodeIndex* pIdxBehind = nullptr);
+void MakeOwnFrames(SwPosition* pIdxBehind = nullptr);
/** Method deletes all views of document for the node.
The content frames are removed from the respective layout. */
diff --git a/sw/source/core/docnode/ndtbl.cxx b/sw/source/core/docnode/ndtbl.cxx
index 341bc2188af8..6b384f9a18a0 100644
--- a/sw/source/core/docnode/ndtbl.cxx
+++ b/sw/source/core/docnode/ndtbl.cxx
@@ -2377,17 +2377,17 @@ void
SwTableNode::MakeFramesForAdjacentContentNode(const SwNodeIndex & rIdx)
/**
* Create a TableFrame for every Shell and insert before the corresponding
ContentFrame.
*/
-void SwTableNode::MakeOwnFrames(SwNodeIndex* pIdxBehind)
+void SwTableNode::MakeOwnFrames(SwPosition* pIdxBehind)
{
SwNode *pNd = GetNodes().FindPrvNxtFrameNode( *this, EndOfSectionNode() );
if( !pNd )
{
if (pIdxBehind)
-*pIdxBehind = *this;
+pIdxBehind->Assign(*this);
return;
}
if (pIdxBehind)
-*pIdxBehind = *pNd;
+pIdxBehind->Assign(*pNd);
SwFrame *pFrame( nullptr );
SwLayoutFrame *pUpper( nullptr );
diff --git a/sw/source/filter/inc/msfilter.hxx
b/sw/source/filter/inc/msfilter.hxx
index 1a3626bdd521..70ef8d12aa80 100644
--- a/sw/source/filter/inc/msfilter.hxx
+++ b/sw/source/filter/inc/msfilter.hxx
@@ -289,7 +289,7 @@ namespace sw
explicit InsertedTablesManager(const SwDoc );
private:
bool mbHasRoot;
-std::map, SwNodeIndex*>
maTables;
+std::map, SwPosition*>
maTables;
};
void MoveAttrFieldmarkInserted(SwFltPosition& rMkPos, SwFltPosition&
rPtPos, const SwPosition& rPos);
diff --git a/sw/source/filter/ww8/writerhelper.cxx
b/sw/source/filter/ww8/writerhelper.cxx
index ebb9e855f593..8b14ceb70b79 100644
--- a/sw/source/filter/ww8/writerhelper.cxx
+++ b/sw/source/filter/ww8/writerhelper.cxx
@@ -887,7 +887,7 @@ namespace sw
if (pFrameFormat != nullptr)
{
-SwNodeIndex *pIndex = aTable.second;
+SwPosition *pIndex = aTable.second;
pTable->DelFrames();
pTable->MakeOwnFrames(pIndex);
}
@@ -899,11 +899,11 @@ namespace sw
{
if (!mbHasRoot)
return;
-//Associate this tablenode with this after position, replace an
//old
+//Associate this tablenode with this after position, replace an old
//node association if necessary
maTables.emplace(
std::unique_ptr(new
InsertedTableListener(rTableNode)),
-&(rPaM.GetPoint()->nNode));
+rPaM.GetPoint());
}
}
[Libreoffice-commits] core.git: sw/source
sw/source/core/docnode/nodes.cxx |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit 83b6e22b37ffcd36d6030ab0c044fd7bb848f0df
Author: Noel Grandin
AuthorDate: Fri Oct 7 19:27:49 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Oct 7 22:03:21 2022 +0200
simplify MakeOwnFrames usage
the parameter is purely an "out" parameter, so unless we need the
result, there is no need to pass anything in it.
Change-Id: Ic4eda8790edb1a6cb8837fe5b6c97c9c61cc25a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141089
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/docnode/nodes.cxx b/sw/source/core/docnode/nodes.cxx
index 37d0159a4e3f..915fb673778d 100644
--- a/sw/source/core/docnode/nodes.cxx
+++ b/sw/source/core/docnode/nodes.cxx
@@ -1815,10 +1815,7 @@ void SwNodes::CopyNodes( const SwNodeRange& rRange,
aRg.aStart = pCurrentNode->EndOfSectionIndex();
if( bNewFrames && pTableNd )
-{
-nStt = aInsPos;
-pTableNd->MakeOwnFrames();
-}
+pTableNd->MakeOwnFrames();
}
break;
[Libreoffice-bugs] [Bug 151304] Cursor position error.
https://bugs.documentfoundation.org/show_bug.cgi?id=151304 --- Comment #7 from LeroyG --- Tested just a little, but I think (by past experiences) that the problem is with the images. Not reproducible with: Version: 7.2.7.2 (x64) / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: default; VCL: win Locale: es-MX (es_ES); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151373] EDITING coloured borders of referenced cells missing when more than 128 references in formula expression
https://bugs.documentfoundation.org/show_bug.cgi?id=151373 --- Comment #4 from LeroyG --- (In reply to Eike Rathke from comment #2) > […] colouring too many referenced cells slows things down Why if since the 9th reference only default cell selection color is applied? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151373] EDITING coloured borders of referenced cells missing when more than 128 references in formula expression
https://bugs.documentfoundation.org/show_bug.cgi?id=151373 --- Comment #3 from LeroyG --- Created attachment 182909 --> https://bugs.documentfoundation.org/attachment.cgi?id=182909=edit Formula in A152 without skipping rows Which color do not help much, since there are only eight colors. But I think that it helps to see which cells are included (or not) in the formula. However, how frequent is to have a formula with more than 128 references? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151415] New: Adding Google Drive as remote service fails because OOB has been deprecated
https://bugs.documentfoundation.org/show_bug.cgi?id=151415 Bug ID: 151415 Summary: Adding Google Drive as remote service fails because OOB has been deprecated Product: LibreOffice Version: 7.4.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: empbarr...@gmail.com Description: Google has deprecated its OAuth out-of-band flow for security reasons as of October 3, 2022, so users can no longer add Google Drive as a remote service. Attempts to do so will result in the error "Access blocked: LibreOffice’s request is invalid." If an attempt seems successful (Google returns a code for the user to copy and paste into LibreOffice), the user is asked to redo the authentication process until the error shows up. Steps to Reproduce: 1. File > Open Remote... 2. Manage services > Add service (Type: Google Drive) 3. Enter user (Google Drive account) and leave password empty 4. Press OK 5. Press OK (leave password empty again on "Authentication Required" popup) 6. Open given Google OAuth link in browser 7. Allow LibreOffice access to Google if request is not returned as invalid 8. Copy and paste given code into field in "Authentication Required" popup 9. Press OK 10. Repeat steps 6-9 until "Access blocked: LibreOffice’s request is invalid" error is given Actual Results: The "Authentication Required" popup opened again or Google returned an error (Access blocked: LibreOffice’s request is invalid). Expected Results: After step 9, LibreOffice should have been able to access remote files from Google Drive and continued with adding the service. Reproducible: Always User Profile Reset: Yes Additional Info: Here is a guide for OOB flow migration: https://developers.google.com/identity/protocols/oauth2/resources/oob-migration -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151401] Writers keeps generating random bookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=151401 --- Comment #2 from LeroyG --- (In reply to J22Gim from comment #0) > 2. start […] copy/pasting […] from external sources using clipboard such as > websites, other documents, etc. External sources have bookmarks. You must paste as unformatted text (Ctrl+Alt+Shift+V) to avoid pasting bookmarks. Not a bug for me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151409] Missing colon in "Vertical maximum" (TDF Weblate)
https://bugs.documentfoundation.org/show_bug.cgi?id=151409 LeroyG changed: What|Removed |Added Summary|Missing colon in "Vertical |Missing colon in "Vertical |maximum"|maximum" (TDF Weblate) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151412] window opening problems
https://bugs.documentfoundation.org/show_bug.cgi?id=151412 --- Comment #3 from LeroyG --- Not a bug for me. See: https://ask.libreoffice.org/t/set-default-window-size-for-new-document/43987 https://ask.libreoffice.org/t/window-size-and-position/60499 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151407] Pressing and holding ctrl+o opens multiple file open dialogs
https://bugs.documentfoundation.org/show_bug.cgi?id=151407 --- Comment #2 from LeroyG --- Not reproducible with: Version: 7.2.7.2 (x64) / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: default; VCL: win Locale: es-MX (es_ES); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151414] New: libre office is not opening
https://bugs.documentfoundation.org/show_bug.cgi?id=151414 Bug ID: 151414 Summary: libre office is not opening Product: LibreOffice Version: 7.4.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: elias__0...@yahoo.com Video of the described behavior `https://ufile.io/kgm6c6sb` Some times Libre office opens and other times does not open. If one time is not opening, it could not be opened even killing soffice oosplash processes, again and again. When clicking to a file to open it, it appears only the name of file on my menu bar in kde. In order to be able to run libre office 7.4.1.2 again, i must run libreoffice 7.1.3.2 to close it and then run libre office 7.4.1.2, otherwise i cannot open it. Version: 7.4.1.2 / LibreOffice Community Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded No LSB modules are available. Distributor ID: Debian Description:Debian GNU/Linux 11 (bullseye) Release:11 Codename: bullseye -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124672] Hi-Contrast mode should use Sifr dark icons, not Sifr
https://bugs.documentfoundation.org/show_bug.cgi?id=124672 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124672] Hi-Contrast mode should use Sifr dark icons, not Sifr
https://bugs.documentfoundation.org/show_bug.cgi?id=124672 Caolán McNamara changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=98 ||067 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98067] Menu bar and right tool bar are invisible, but functional in high-contrast-mode/theme
https://bugs.documentfoundation.org/show_bug.cgi?id=98067 Caolán McNamara changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4672 --- Comment #31 from Caolán McNamara --- bug 124672 exists for sifr vs sifr_dark as hicontrast icon theme choices -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151407] Pressing and holding ctrl+o opens multiple file open dialogs
https://bugs.documentfoundation.org/show_bug.cgi?id=151407 Jean-Baptiste Faure changed: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #1 from Jean-Baptiste Faure --- Not reproducible for me with LO 6.4.7 provided by Ubuntu 20.04, Version: 7.4.3.0.0+ / LibreOffice Community Build ID: 8bc82b41a97461a6b03e7a678f563b5ad3b4d79d CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Ubuntu_20.04_x86-64 Calc: threaded Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: fe51aa0a8d796b456a3c6966c47afc98e4532cd0 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Ubuntu_20.04_x86-64 Calc: threaded Ubuntu 20.04 LTS with Gnome and Wayland. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/source
sw/source/core/layout/frmtool.cxx |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
New commits:
commit 0fb5f7e22b68fc045843af95ca3918c1d92a8656
Author: Michael Stahl
AuthorDate: Thu Oct 6 19:22:51 2022 +0200
Commit: Caolán McNamara
CommitDate: Fri Oct 7 20:27:39 2022 +0200
tdf#150500 sw_fieldmarkhide: fix duplicate text frame on paste
The problem is that in MakeFrames() after the 1st iteration the
SwNode2Layout::NextFrame() on node 10 returns a SwTextFrame that was
just created by the 1st iteration, due to a fieldmark merging the 2
SwTextNodes.
Only itreate the frames that are pre-existing.
(regression from commit 2f726fa41cbd249f2fb30222b29d5f30bce52e6e)
Change-Id: Iba684dfc903e1c72ca3e70a9aabf1aecf4baf32b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141032
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 21358e0502995238b85677d72a005f3f96d60f7f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141059
Reviewed-by: Caolán McNamara
diff --git a/sw/source/core/layout/frmtool.cxx
b/sw/source/core/layout/frmtool.cxx
index ee50dcc7cd12..ecd69e9012ab 100644
--- a/sw/source/core/layout/frmtool.cxx
+++ b/sw/source/core/layout/frmtool.cxx
@@ -2026,9 +2026,14 @@ void MakeFrames( SwDoc *pDoc, const SwNodeIndex ,
{
bool bApres = aTmp < rSttIdx;
SwNode2Layout aNode2Layout( *pNd, rSttIdx.GetIndex() );
-SwFrame* pFrame;
sw::FrameMode eMode = sw::FrameMode::Existing;
-while( nullptr != (pFrame = aNode2Layout.NextFrame()) )
+::std::vector frames;
+while (SwFrame* pFrame = aNode2Layout.NextFrame())
+{ // tdf#150500 new frames may be created that end up merged on pNd
+// so copy the currently existing ones; they shouldn't get deleted
+frames.push_back(pFrame);
+}
+for (SwFrame *const pFrame : frames)
{
SwLayoutFrame *pUpper = pFrame->GetUpper();
SwFootnoteFrame* pFootnoteFrame = pUpper->FindFootnoteFrame();
[Libreoffice-bugs] [Bug 98067] Menu bar and right tool bar are invisible, but functional in high-contrast-mode/theme
https://bugs.documentfoundation.org/show_bug.cgi?id=98067 --- Comment #30 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/82ad6bc4e8c081bfb547ad10d29885cbdd0e8ea1 Related: tdf#98067 get high contrast hover/default button text color right It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/win
vcl/win/window/salframe.cxx | 40 ++--
1 file changed, 22 insertions(+), 18 deletions(-)
New commits:
commit 82ad6bc4e8c081bfb547ad10d29885cbdd0e8ea1
Author: Caolán McNamara
AuthorDate: Fri Oct 7 12:38:58 2022 +0100
Commit: Caolán McNamara
CommitDate: Fri Oct 7 20:26:38 2022 +0200
Related: tdf#98067 get high contrast hover/default button text color right
Normal and high contrast themes seem to behave differently
(in Windows 10)
to play more directly with themes than the usual ui try:
Press Windows Key + R and paste:
shell:::{ED834ED6-4B5A-4bfe-8F11-A626DCB6A921}
-Microsoft.Personalization\pageColorization
High Contrast themes seem different to the others, with a high contrast
theme set then its possible to customize the colors, otherwise not.
Playing with 'Selected Text' it seems that this is the color used for
the active/hover button text color with a high contrast theme.
Change-Id: I561616fce6a6f6d781e4881bfdf8ba0abedcd75c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141051
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index 95cb08e20b07..d2d2f697aeb3 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -2615,6 +2615,15 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings
)
StyleSettings aStyleSettings = rSettings.GetStyleSettings();
+// High contrast
+HIGHCONTRAST hc;
+hc.cbSize = sizeof( HIGHCONTRAST );
+if( SystemParametersInfoW( SPI_GETHIGHCONTRAST, hc.cbSize, , 0 )
+&& (hc.dwFlags & HCF_HIGHCONTRASTON) )
+aStyleSettings.SetHighContrastMode( true );
+else
+aStyleSettings.SetHighContrastMode( false );
+
aStyleSettings.SetScrollBarSize( GetSystemMetrics( SM_CXVSCROLL ) );
aStyleSettings.SetSpinSize( GetSystemMetrics( SM_CXVSCROLL ) );
UINT blinkTime = GetCaretBlinkTime();
@@ -2630,6 +2639,7 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings )
Color aControlTextColor;
Color aMenuBarTextColor;
Color aMenuBarRolloverTextColor;
+Color aHighlightTextColor =
ImplWinColorToSal(GetSysColor(COLOR_HIGHLIGHTTEXT));
const bool bUseDarkMode(UseDarkMode());
@@ -2680,7 +2690,7 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings )
aStyleSettings.SetRadioCheckTextColor( ImplWinColorToSal( GetSysColor(
COLOR_WINDOWTEXT ) ) );
aStyleSettings.SetMenuTextColor( ImplWinColorToSal( GetSysColor(
COLOR_MENUTEXT ) ) );
aMenuBarTextColor = ImplWinColorToSal( GetSysColor( COLOR_MENUTEXT ) );
-aMenuBarRolloverTextColor = ImplWinColorToSal( GetSysColor(
COLOR_HIGHLIGHTTEXT ) );
+aMenuBarRolloverTextColor = aHighlightTextColor;
}
if ( std::optional aColor =
aStyleSettings.GetPersonaMenuBarTextColor() )
@@ -2703,16 +2713,19 @@ void WinSalFrame::UpdateSettings( AllSettings&
rSettings )
aStyleSettings.SetDialogColor(aStyleSettings.GetFaceColor());
aStyleSettings.SetDialogTextColor(aControlTextColor);
-aStyleSettings.SetDefaultButtonTextColor(aControlTextColor);
+Color aHighlightButtonTextColor = aStyleSettings.GetHighContrastMode() ?
+aHighlightTextColor : aControlTextColor;
+
+aStyleSettings.SetDefaultButtonTextColor(aHighlightButtonTextColor);
aStyleSettings.SetButtonTextColor(aControlTextColor);
-aStyleSettings.SetDefaultActionButtonTextColor(aControlTextColor);
+aStyleSettings.SetDefaultActionButtonTextColor(aHighlightButtonTextColor);
aStyleSettings.SetActionButtonTextColor(aControlTextColor);
aStyleSettings.SetFlatButtonTextColor(aControlTextColor);
-aStyleSettings.SetDefaultButtonRolloverTextColor(aControlTextColor);
-aStyleSettings.SetButtonRolloverTextColor(aControlTextColor);
-aStyleSettings.SetDefaultActionButtonRolloverTextColor(aControlTextColor);
-aStyleSettings.SetActionButtonRolloverTextColor(aControlTextColor);
-aStyleSettings.SetFlatButtonRolloverTextColor(aControlTextColor);
+
aStyleSettings.SetDefaultButtonRolloverTextColor(aHighlightButtonTextColor);
+aStyleSettings.SetButtonRolloverTextColor(aHighlightButtonTextColor);
+
aStyleSettings.SetDefaultActionButtonRolloverTextColor(aHighlightButtonTextColor);
+aStyleSettings.SetActionButtonRolloverTextColor(aHighlightButtonTextColor);
+aStyleSettings.SetFlatButtonRolloverTextColor(aHighlightButtonTextColor);
aStyleSettings.SetDefaultButtonPressedRolloverTextColor(aControlTextColor);
aStyleSettings.SetButtonPressedRolloverTextColor(aControlTextColor);
aStyleSettings.SetDefaultActionButtonPressedRolloverTextColor(aControlTextColor);
@@ -2732,7 +2745,7 @@ void WinSalFrame::UpdateSettings( AllSettings& rSettings )
aStyleSettings.SetFieldRolloverTextColor(
aStyleSettings.GetFieldTextColor() );
[Libreoffice-bugs] [Bug 98067] Menu bar and right tool bar are invisible, but functional in high-contrast-mode/theme
https://bugs.documentfoundation.org/show_bug.cgi?id=98067 --- Comment #29 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4cb11d8a6682fecd661b926a417ae7f26f76e7db Related: tdf#98067 do RollOver for Edit as well as SpinButton It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - include/vcl sw/source vcl/source
include/vcl/toolkit/edit.hxx |1 +
sw/source/ui/table/autoformatpreview.cxx |9 -
vcl/source/control/edit.cxx | 22 ++
vcl/source/control/spinfld.cxx |8 ++--
vcl/source/window/brdwin.cxx | 17 ++---
5 files changed, 39 insertions(+), 18 deletions(-)
New commits:
commit e73f779f46cb709c2c7de7f0b6d217195ccb5a4f
Author: Caolán McNamara
AuthorDate: Fri Oct 7 17:31:40 2022 +0100
Commit: Caolán McNamara
CommitDate: Fri Oct 7 20:25:41 2022 +0200
set the background before setting the DrawMode
so we get the document color set even in HighContrast mode
Change-Id: I40a009cb473cc7e033f2be77488c081067fef69d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141088
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/ui/table/autoformatpreview.cxx
b/sw/source/ui/table/autoformatpreview.cxx
index 2a2318252c9f..e04fffefcae4 100644
--- a/sw/source/ui/table/autoformatpreview.cxx
+++ b/sw/source/ui/table/autoformatpreview.cxx
@@ -432,6 +432,10 @@ void AutoFormatPreview::Paint(vcl::RenderContext&
rRenderContext, const tools::R
{
rRenderContext.Push(vcl::PushFlags::ALL);
+const Color& rWinColor =
SW_MOD()->GetColorConfig().GetColorValue(::svtools::DOCCOLOR).nColor;
+rRenderContext.SetBackground(Wallpaper(rWinColor));
+rRenderContext.Erase();
+
DrawModeFlags nOldDrawMode = rRenderContext.GetDrawMode();
if (rRenderContext.GetSettings().GetStyleSettings().GetHighContrastMode())
rRenderContext.SetDrawMode(DrawModeFlags::SettingsLine |
DrawModeFlags::SettingsFill
@@ -441,12 +445,7 @@ void AutoFormatPreview::Paint(vcl::RenderContext&
rRenderContext, const tools::R
vcl::Font aFont(rRenderContext.GetFont());
aFont.SetTransparent(true);
-
rRenderContext.SetFont(aFont);
-rRenderContext.SetLineColor();
-const Color& rWinColor =
SW_MOD()->GetColorConfig().GetColorValue(::svtools::DOCCOLOR).nColor;
-rRenderContext.SetBackground(Wallpaper(rWinColor));
-rRenderContext.SetFillColor(rWinColor);
// Draw the Frame
Color oldColor = rRenderContext.GetLineColor();
commit 4cb11d8a6682fecd661b926a417ae7f26f76e7db
Author: Caolán McNamara
AuthorDate: Fri Oct 7 16:40:23 2022 +0100
Commit: Caolán McNamara
CommitDate: Fri Oct 7 20:25:21 2022 +0200
Related: tdf#98067 do RollOver for Edit as well as SpinButton
Change-Id: I058cc965a9b0d85e5491191e2ac712c01f700043
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141086
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/include/vcl/toolkit/edit.hxx b/include/vcl/toolkit/edit.hxx
index 6cba936040eb..2291ce2d7558 100644
--- a/include/vcl/toolkit/edit.hxx
+++ b/include/vcl/toolkit/edit.hxx
@@ -161,6 +161,7 @@ public:
virtual voidCommand( const CommandEvent& rCEvt ) override;
virtual voidStateChanged( StateChangedType nType ) override;
virtual voidDataChanged( const DataChangedEvent& rDCEvt ) override;
+virtual boolPreNotify(NotifyEvent& rNEvt) override;
virtual voidModify();
diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 70c29cff95b1..1554f846ba95 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -1913,6 +1913,28 @@ void Edit::LoseFocus()
Control::LoseFocus();
}
+bool Edit::PreNotify(NotifyEvent& rNEvt)
+{
+if (rNEvt.GetType() == NotifyEventType::MOUSEMOVE)
+{
+const MouseEvent* pMouseEvt = rNEvt.GetMouseEvent();
+if (pMouseEvt && !pMouseEvt->GetButtons() && !pMouseEvt->IsSynthetic()
&& !pMouseEvt->IsModifierChanged())
+{
+// trigger redraw if mouse over state has changed
+if (pMouseEvt->IsLeaveWindow() || pMouseEvt->IsEnterWindow())
+{
+if (IsNativeWidgetEnabled() &&
+IsNativeControlSupported(ControlType::Editbox,
ControlPart::Entire))
+{
+ImplInvalidateOutermostBorder(this);
+}
+}
+}
+}
+
+return Control::PreNotify(rNEvt);
+}
+
void Edit::Command( const CommandEvent& rCEvt )
{
if ( rCEvt.GetCommand() == CommandEventId::ContextMenu )
diff --git a/vcl/source/control/spinfld.cxx b/vcl/source/control/spinfld.cxx
index 56d26d81c8f8..973825a3a977 100644
--- a/vcl/source/control/spinfld.cxx
+++ b/vcl/source/control/spinfld.cxx
@@ -870,12 +870,8 @@ bool SpinField::PreNotify(NotifyEvent& rNEvt)
tools::Rectangle* pLastRect = ImplFindPartRect(
GetLastPointerPosPixel() );
if( pRect != pLastRect || (pMouseEvt->IsLeaveWindow() ||
pMouseEvt->IsEnterWindow()) )
{
-if (IsNativeWidgetEnabled() &&
-IsNativeControlSupported(ControlType::Editbox,
ControlPart::Entire))
-{
-
[Libreoffice-bugs] [Bug 98067] Menu bar and right tool bar are invisible, but functional in high-contrast-mode/theme
https://bugs.documentfoundation.org/show_bug.cgi?id=98067 --- Comment #28 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8bc5c3bfdb5717f4bff0a513c5c2d17cd728771d Related: tdf#98067 use EP_EDITBORDER_NOSCROLL for Edits It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source vcl/win
vcl/source/control/edit.cxx | 14 --
vcl/source/control/imp_listbox.cxx| 10 --
vcl/source/control/spinfld.cxx|4 +---
vcl/source/window/brdwin.cxx | 11 +--
vcl/win/gdi/salnativewidgets-luna.cxx | 17 -
5 files changed, 26 insertions(+), 30 deletions(-)
New commits:
commit 8bc5c3bfdb5717f4bff0a513c5c2d17cd728771d
Author: Caolán McNamara
AuthorDate: Fri Oct 7 16:13:17 2022 +0100
Commit: Caolán McNamara
CommitDate: Fri Oct 7 20:24:51 2022 +0200
Related: tdf#98067 use EP_EDITBORDER_NOSCROLL for Edits
which gives a border which indicates if the Edit has focus
or not. In High Contrast Black this is a bright yellow and I see
it in notepad and visual studio, so lets do that too.
MultilineEdit left alone for now
Change-Id: I6785e3cdef7d563509a3a6ea8617ab5f89602a6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141085
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 29b25a7205ad..70c29cff95b1 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -1876,11 +1876,8 @@ void Edit::GetFocus()
ImplShowCursor();
-// FIXME: this is currently only on macOS
-// check for other platforms that need similar handling
-if( ImplGetSVData()->maNWFData.mbNoFocusRects &&
-IsNativeWidgetEnabled() &&
-IsNativeControlSupported( ControlType::Editbox,
ControlPart::Entire ) )
+if (IsNativeWidgetEnabled() &&
+IsNativeControlSupported( ControlType::Editbox,
ControlPart::Entire ))
{
ImplInvalidateOutermostBorder( mbIsSubEdit ? GetParent() : this );
}
@@ -1903,11 +1900,8 @@ void Edit::LoseFocus()
{
if ( !mpSubEdit )
{
-// FIXME: this is currently only on macOS
-// check for other platforms that need similar handling
-if( ImplGetSVData()->maNWFData.mbNoFocusRects &&
-IsNativeWidgetEnabled() &&
-IsNativeControlSupported( ControlType::Editbox,
ControlPart::Entire ) )
+if (IsNativeWidgetEnabled() &&
+IsNativeControlSupported(ControlType::Editbox,
ControlPart::Entire))
{
ImplInvalidateOutermostBorder( mbIsSubEdit ? GetParent() : this );
}
diff --git a/vcl/source/control/imp_listbox.cxx
b/vcl/source/control/imp_listbox.cxx
index 033f477a9185..531244925062 100644
--- a/vcl/source/control/imp_listbox.cxx
+++ b/vcl/source/control/imp_listbox.cxx
@@ -2769,9 +2769,8 @@ void ImplWin::Resize()
void ImplWin::GetFocus()
{
ShowFocus( maFocusRect );
-if( ImplGetSVData()->maNWFData.mbNoFocusRects &&
-IsNativeWidgetEnabled() &&
-IsNativeControlSupported( ControlType::Listbox, ControlPart::Entire ) )
+if (IsNativeWidgetEnabled() &&
+IsNativeControlSupported(ControlType::Listbox, ControlPart::Entire))
{
vcl::Window* pWin = GetParent()->GetWindow( GetWindowType::Border );
if( ! pWin )
@@ -2786,9 +2785,8 @@ void ImplWin::GetFocus()
void ImplWin::LoseFocus()
{
HideFocus();
-if( ImplGetSVData()->maNWFData.mbNoFocusRects &&
-IsNativeWidgetEnabled() &&
-IsNativeControlSupported( ControlType::Listbox, ControlPart::Entire ) )
+if (IsNativeWidgetEnabled() &&
+IsNativeControlSupported( ControlType::Listbox, ControlPart::Entire))
{
vcl::Window* pWin = GetParent()->GetWindow( GetWindowType::Border );
if( ! pWin )
diff --git a/vcl/source/control/spinfld.cxx b/vcl/source/control/spinfld.cxx
index 51d66131160a..56d26d81c8f8 100644
--- a/vcl/source/control/spinfld.cxx
+++ b/vcl/source/control/spinfld.cxx
@@ -870,9 +870,7 @@ bool SpinField::PreNotify(NotifyEvent& rNEvt)
tools::Rectangle* pLastRect = ImplFindPartRect(
GetLastPointerPosPixel() );
if( pRect != pLastRect || (pMouseEvt->IsLeaveWindow() ||
pMouseEvt->IsEnterWindow()) )
{
-// FIXME: this is currently only on macOS
-// check for other platforms that need similar handling
-if (ImplGetSVData()->maNWFData.mbNoFocusRects &&
IsNativeWidgetEnabled() &&
+if (IsNativeWidgetEnabled() &&
IsNativeControlSupported(ControlType::Editbox,
ControlPart::Entire))
{
ImplInvalidateOutermostBorder(this);
diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx
index 6617de6414b3..3e8ff6f332d2 100644
--- a/vcl/source/window/brdwin.cxx
+++ b/vcl/source/window/brdwin.cxx
@@ -662,17 +662,8 @@ void
ImplSmallBorderWindowView::DrawWindow(vcl::RenderContext& rRenderContext, c
if (!mpBorderWindow->IsEnabled())
nState &= ~ControlState::ENABLED;
-if (mpBorderWindow->HasFocus())
+if
[Libreoffice-ux-advise] [Bug 151394] play an audio stream/soundtrack in background for entire ODF presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151394 --- Comment #8 from Rainer Bielefeld Retired --- Created attachment 182908 --> https://bugs.documentfoundation.org/attachment.cgi?id=182908=edit content.xml from sample file (In reply to Randy from comment #7) No! The music simply comes from a linked file. Here as att. you see content.xml from unzipped presentation. Search in it for "Hartford" and you will find 2 relative links to the background music .mp3. An expert might be able to find out how that works from the source file Also ASK and OOo forum and so on are full of hints how to get a background music for all presentation, but I can't think straight enough at the moment to understand what they tell me -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 151394] play an audio stream/soundtrack in background for entire ODF presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151394 --- Comment #8 from Rainer Bielefeld Retired --- Created attachment 182908 --> https://bugs.documentfoundation.org/attachment.cgi?id=182908=edit content.xml from sample file (In reply to Randy from comment #7) No! The music simply comes from a linked file. Here as att. you see content.xml from unzipped presentation. Search in it for "Hartford" and you will find 2 relative links to the background music .mp3. An expert might be able to find out how that works from the source file Also ASK and OOo forum and so on are full of hints how to get a background music for all presentation, but I can't think straight enough at the moment to understand what they tell me -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/filter/inc/fltshell.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit c40671e082b6ece4dbd117346d9f5a3912900e54
Author: Noel Grandin
AuthorDate: Fri Oct 7 17:04:32 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Oct 7 19:49:04 2022 +0200
use more SwPosition::GetNode
part of the process of hiding the internals of SwPosition
Change-Id: I89fdef3ac8f12f88db76abe281d628f25a66536e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141084
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/filter/inc/fltshell.hxx
b/sw/source/filter/inc/fltshell.hxx
index edf724f0a1f1..12ec446bf081 100644
--- a/sw/source/filter/inc/fltshell.hxx
+++ b/sw/source/filter/inc/fltshell.hxx
@@ -64,7 +64,7 @@ public:
//operators with SwPosition, where the node is hacked to the previous one,
//and the offset to content is de-dynamic-ified
SwFltPosition(const SwPosition )
-: m_nNode(rPos.nNode, -1)
+: m_nNode(rPos.GetNode(), -1)
, m_nContent(rPos.GetContentIndex())
{
}
[Libreoffice-bugs] [Bug 151314] Please support e-mail client Betterbird (Thunderbird fork) for sending documents
https://bugs.documentfoundation.org/show_bug.cgi?id=151314 mfs changed: What|Removed |Added CC||m...@mfs.name --- Comment #11 from mfs --- Created attachment 182907 --> https://bugs.documentfoundation.org/attachment.cgi?id=182907=edit add Betterbird to the list of Thunderbird-like mail clients I am proposing the attached patch to add Betterbird to the list of mail clients that senddoc.sh treats like Thunderbird. Together with the fix implemented on Betterbird side this should make the integration between LO and Betterbird work for users that specify Betterbird as their mail client in the LO settings. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/atrfrm.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit aa0e536c2b09952aab729c529e81394fedeb8507 Author: Noel Grandin AuthorDate: Fri Oct 7 16:51:33 2022 +0200 Commit: Noel Grandin CommitDate: Fri Oct 7 19:29:01 2022 +0200 use more SwPosition::AdjustContent part of the process of hiding the internals of SwPosition Change-Id: I645b620691c55c14b8f58261608ae06a9a5cffda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141083 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/source/core/layout/atrfrm.cxx b/sw/source/core/layout/atrfrm.cxx index 1cf992854c6c..96f3c751b325 100644 --- a/sw/source/core/layout/atrfrm.cxx +++ b/sw/source/core/layout/atrfrm.cxx @@ -3418,7 +3418,7 @@ void SwHandleAnchorNodeChg::ImplDestroy() *rCursor.GetPoint() = *moCommentAnchor; rCursor.SetMark(); *rCursor.GetMark() = *moCommentAnchor; -++rCursor.GetMark()->nContent; +rCursor.GetMark()->AdjustContent(+1); } // Set up the target of the move: the new comment anchor.
[Libreoffice-bugs] [Bug 151394] play an audio stream/soundtrack in background for entire ODF presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151394 --- Comment #7 from Randy --- I downloaded that attachment but there was no music file attached and the sheets were mostly blank. It was only 21kb in size. I did figure out how to use the xbox game bar to screen record the presentation as it played. That produced an .mp4 video file. I then added the audio track I wanted to that file. A lot of steps that could be potentially all handled by Impress I think. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151394] play an audio stream/soundtrack in background for entire ODF presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151394 --- Comment #7 from Randy --- I downloaded that attachment but there was no music file attached and the sheets were mostly blank. It was only 21kb in size. I did figure out how to use the xbox game bar to screen record the presentation as it played. That produced an .mp4 video file. I then added the audio track I wanted to that file. A lot of steps that could be potentially all handled by Impress I think. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/txtnode/thints.cxx |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
New commits:
commit 911b6b413048a2161e803b85cf2fe45e8dd8
Author: Noel Grandin
AuthorDate: Fri Oct 7 16:46:09 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Oct 7 19:05:11 2022 +0200
use more SwPosition::GetContentIndex
part of the process of hiding the internals of SwPosition
Change-Id: Idf4be99ea209c22eb0b0e1a478b93c8b2445628a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141082
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/txtnode/thints.cxx
b/sw/source/core/txtnode/thints.cxx
index 0ea2a3e8aecc..ee699481a79b 100644
--- a/sw/source/core/txtnode/thints.cxx
+++ b/sw/source/core/txtnode/thints.cxx
@@ -1390,10 +1390,9 @@ bool SwTextNode::InsertHint( SwTextAttr * const pAttr,
const SetAttrMode nMode )
(RndStdIds::FLY_AS_CHAR == pAnchor->GetAnchorId()) &&
pAnchor->GetContentAnchor() &&
pAnchor->GetContentAnchor()->GetNode() == *this &&
-pAnchor->GetContentAnchor()->nContent == aIdx )
+pAnchor->GetContentAnchor()->GetContentIndex() ==
aIdx.GetIndex() )
{
---const_cast(
-pAnchor->GetContentAnchor()->nContent);
+
const_cast(pAnchor->GetContentAnchor())->AdjustContent(-1);
}
}
pFly->SetAnchor( this );
[Libreoffice-bugs] [Bug 150809] Language list in Help should not be translatable
https://bugs.documentfoundation.org/show_bug.cgi?id=150809 --- Comment #4 from Tuomas Hietala --- (In reply to Olivier Hallot from comment #3) > The LO language selection page in Tools - Options - Language Settings - > Languages ... > > shows all foreign languages translated. Changing those should be considered too, IMO. > I'll keep as is for consistency. We could use endonyms to keep consistency with the language selector in the wiki: https://wiki.documentfoundation.org/Main_Page/ Or we could also use language codes, in consistency with the documentation website: https://documentation.libreoffice.org/en/english-documentation/ > Also the first entry in the language drop-down list in the Help is always > English (USA). So there is a path to display the Help path into a > user-friendly language (assuming a minimal knowledge of English of course). If we assume a minimal knowledge of English, then what's the point of translating the language names? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151413] New: Unable to create a DDE link to a file with special characters in name on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=151413 Bug ID: 151413 Summary: Unable to create a DDE link to a file with special characters in name on Windows Product: LibreOffice Version: unspecified Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com 1. Create a Calc document; put "1" into A1. 2. Save the document as "m³ph.ods". Note that "³" is U+00b3 "superscript 3"; possibly one would need different special characters on systems with that character supported by system encoding. 3. Select A1, Ctrl+C to copy to clipboard. 4. Create a new Writer document. 5. Paste Special -> DDE Link. The pasted table is empty, while it is expected to contain "1". The External Links manager shows that source file is "m%3Fph.ods", and its status is "not available". If on step 3, the file name is "m3ph.ods", i.e. does not contain characters not representable in system encoding, then the link is established OK. Examining the ODT content.xml, the reference is like "D:\Documents\m?ph.ods", so the character had been converted to "?" (which corresponds to the percent-encoded data shown by External Links). Replacing it to "D:\Documents\m³ph.ods" manually in the XML makes the ODT open with correct data from the link. Tested with Version: 7.4.2.1 (x64) / LibreOffice Community Build ID: 681d65acd9ede00dd724d6716f21cabfdcc95bd2 CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL Likely Windows-specific (or at least specific to non-Unicode system encoding). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 151394] play an audio stream/soundtrack in background for entire ODF presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151394 --- Comment #6 from Rainer Bielefeld Retired --- Created attachment 182906 --> https://bugs.documentfoundation.org/attachment.cgi?id=182906=edit Presentation with audio background play This is a Presentation I created in 2011 with background Music. Starts with Sheet 1. Music is related to sheet, if I delete it music will not play. Deleting sheets 3,5,7 will not delete any Music, will not cause Music hickups. I can't find out how I did that ... -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 151394] play an audio stream/soundtrack in background for entire ODF presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=151394 --- Comment #6 from Rainer Bielefeld Retired --- Created attachment 182906 --> https://bugs.documentfoundation.org/attachment.cgi?id=182906=edit Presentation with audio background play This is a Presentation I created in 2011 with background Music. Starts with Sheet 1. Music is related to sheet, if I delete it music will not play. Deleting sheets 3,5,7 will not delete any Music, will not cause Music hickups. I can't find out how I did that ... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151412] window opening problems
https://bugs.documentfoundation.org/show_bug.cgi?id=151412 --- Comment #2 from Paolo --- nessun altro commento -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151412] window opening problems
https://bugs.documentfoundation.org/show_bug.cgi?id=151412 --- Comment #1 from Paolo --- nessuno -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145130] Changing an LO Draw's background gradient color resets its gradient type, angle, and other properties
https://bugs.documentfoundation.org/show_bug.cgi?id=145130 --- Comment #4 from xordevore...@gmail.com --- Still a problem in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6d724a494e37412c3fd2e5d0e5e54bda177c4108 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151412] New: window opening problems
https://bugs.documentfoundation.org/show_bug.cgi?id=151412 Bug ID: 151412 Summary: window opening problems Product: LibreOffice Version: 7.4.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: paolo...@gmail.com Description: Quando si apre una qualsiasi applicazione di libre la finestra si posiziona nell'angolo in alto a sinistra ed è necessario ridimensinarla. In base anche le tabelle si aprono con una finestra strettissima e lunga When you open any libre application the window is positioned in the upper left corner and you need to resize it. In base also the tables open with a very narrow and long window Steps to Reproduce: 1.open libre 2.windows non open 3. Actual Results: window that does not open on the desktop Expected Results: window that opens on the desktop Reproducible: Always User Profile Reset: No Additional Info: Kubuntu 22.04 the snap version does not have this problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149872] Sidebar properties switch from what we're manipulating to the page's properties after merging two shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=149872 xordevore...@gmail.com changed: What|Removed |Added CC||xordevore...@gmail.com --- Comment #1 from xordevore...@gmail.com --- Still a problem in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6d724a494e37412c3fd2e5d0e5e54bda177c4108 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144654] Switching LO draw from any visible page margin to None and undoing the change does not restore the side margins
https://bugs.documentfoundation.org/show_bug.cgi?id=144654 --- Comment #7 from xordevore...@gmail.com --- Still a problem in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6d724a494e37412c3fd2e5d0e5e54bda177c4108 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143212] Copying and pasting pages whose master have an SVG unnecessarily creates a new master
https://bugs.documentfoundation.org/show_bug.cgi?id=143212 --- Comment #8 from xordevore...@gmail.com --- Still a problem in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6d724a494e37412c3fd2e5d0e5e54bda177c4108 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139106] Only first slide's background is updated in Windows 10 LO Draw when all slides are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=139106 --- Comment #11 from xordevore...@gmail.com --- Still a problem in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6d724a494e37412c3fd2e5d0e5e54bda177c4108 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151411] New: Store both dark/light versions of the document thumbnails and use it in start center when appropriate
https://bugs.documentfoundation.org/show_bug.cgi?id=151411 Bug ID: 151411 Summary: Store both dark/light versions of the document thumbnails and use it in start center when appropriate Product: LibreOffice Version: Master old -3.6 Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hoss...@libreoffice.org When switching back and forth between dark and light mode, an annoying problem is that the thumbnails are not compatible with the application color settings. If the application color is light, then the thumbnails will be light, even if you switch the application color. A solution for this problem would be storing both dark and light versions of the thumbnails, and use them when appropriate. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136844] Undo / Control-Z does not undo slide background choice in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=136844 --- Comment #14 from xordevore...@gmail.com --- Still a problem in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6d724a494e37412c3fd2e5d0e5e54bda177c4108 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139851] Windows LibreOffice Draw - Selecting various align text options leaves all options selected all the time
https://bugs.documentfoundation.org/show_bug.cgi?id=139851 --- Comment #10 from xordevore...@gmail.com --- Still a problem in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6d724a494e37412c3fd2e5d0e5e54bda177c4108 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145269] Simple clicking a module gives the impression that this module has the view
https://bugs.documentfoundation.org/show_bug.cgi?id=145269 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #4 from raal --- (In reply to Frederic Parrenin from comment #2) > You have no straightforward way to see which module is opened. This is visible in the window's title. Reproducible. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151410] New: "Please report this incident." is not actionable advice
https://bugs.documentfoundation.org/show_bug.cgi?id=151410 Bug ID: 151410 Summary: "Please report this incident." is not actionable advice Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: In sfx2/messages, there's the following string: "An error occurred while adding new target. Please report this incident." The "Please report this incident." part is not really actionable advice, though, because it doesn't say _where_ the incident should be reported to. Steps to Reproduce: 1. See https://translations.documentfoundation.org/translate/libo_ui-master/sfx2messages/en/?checksum=d8a6cd840ab8b6ea Actual Results: The string does not specify where to report the incident, possibly disconcerting the user for no good reason. Expected Results: The string either gives useful information to the user, or is deleted. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45261] EDITING: unbalanced distribution of text between columns
https://bugs.documentfoundation.org/show_bug.cgi?id=45261 --- Comment #19 from Paolo Benvenuto --- Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: es-DO (it_IT.UTF-8); UI: it-IT Ubuntu package version: 1:7.3.5-0ubuntu0.22.04.1 Calc: threaded The bug is still there! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source
sw/inc/redline.hxx |2
sw/source/core/doc/DocumentContentOperationsManager.cxx | 10 -
sw/source/core/doc/docredln.cxx | 156
sw/source/core/frmedt/fefly1.cxx| 12 -
4 files changed, 89 insertions(+), 91 deletions(-)
New commits:
commit dbee0c128b75b3ea0cb527300ebcd0ad55745fb1
Author: Noel Grandin
AuthorDate: Fri Oct 7 12:54:39 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Oct 7 18:23:12 2022 +0200
use more unique_ptr in GetAllValidRanges
Change-Id: I59f6afb5b39779a58d2b0ea47b524df299e1c0d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141050
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/redline.hxx b/sw/inc/redline.hxx
index 1ad8c456b56c..f2d6c31a40ac 100644
--- a/sw/inc/redline.hxx
+++ b/sw/inc/redline.hxx
@@ -338,7 +338,7 @@ class SW_DLLPUBLIC SwRedlineHint final : public SfxHint
namespace sw {
-std::vector GetAllValidRanges(std::unique_ptr
p);
+std::vector>
GetAllValidRanges(std::unique_ptr p);
} // namespace sw
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index ec52d3ec1221..677ae7f0b8fd 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -4094,12 +4094,12 @@ bool
DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl(SwPaM & rPam
return false; // do not add empty redlines
}
-std::vector redlines;
+std::vector> redlines;
{
auto pRedline(std::make_unique(RedlineType::Delete,
rPam));
if (pRedline->HasValidRange())
{
-redlines.push_back(pRedline.release());
+redlines.push_back(std::move(pRedline));
}
else // sigh ... why is such a selection even possible...
{// split it up so we get one SwUndoRedlineDelete per inserted RL
@@ -4160,7 +4160,7 @@ bool
DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl(SwPaM & rPam
m_rDoc.getIDocumentRedlineAccess().SetRedlineFlags(
RedlineFlags::On | RedlineFlags::ShowInsert |
RedlineFlags::ShowDelete);
-for (SwRangeRedline * pRedline : redlines)
+for (std::unique_ptr & pRedline : redlines)
{
assert(pRedline->HasValidRange());
undos.emplace_back(std::make_unique(
@@ -4195,14 +4195,14 @@ bool
DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl(SwPaM & rPam
}
}
-for (SwRangeRedline *const pRedline : redlines)
+for (std::unique_ptr & pRedline : redlines)
{
// note: 1. the pRedline can still be merged & deleted
// 2. the impl. can even DeleteAndJoin the range => no plain PaM
std::shared_ptr const
pCursor(m_rDoc.CreateUnoCursor(*pRedline->GetMark()));
pCursor->SetMark();
*pCursor->GetPoint() = *pRedline->GetPoint();
-m_rDoc.getIDocumentRedlineAccess().AppendRedline(pRedline, true);
+m_rDoc.getIDocumentRedlineAccess().AppendRedline(pRedline.release(),
true);
// sw_redlinehide: 2 reasons why this is needed:
// 1. it's the first redline in node => RedlineDelText was sent but
ignored
// 2. redline spans multiple nodes => must merge text frames
diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx
index 68225e0741b7..cfd77733e331 100644
--- a/sw/source/core/doc/docredln.cxx
+++ b/sw/source/core/doc/docredln.cxx
@@ -477,9 +477,9 @@ bool SwRedlineTable::Insert(SwRangeRedline*& p, size_type&
rP)
namespace sw {
-std::vector GetAllValidRanges(std::unique_ptr
p)
+std::vector>
GetAllValidRanges(std::unique_ptr p)
{
-std::vector ret;
+std::vector> ret;
// Create valid "sub-ranges" from the Selection
auto [pStt, pEnd] = p->StartEnd(); // SwPosition*
SwPosition aNewStt( *pStt );
@@ -493,91 +493,90 @@ std::vector
GetAllValidRanges(std::unique_ptr p
aNewStt.Assign(rNds.GetEndOfContent());
}
-SwRangeRedline* pNew = nullptr;
-if( aNewStt < *pEnd )
-do {
-if( !pNew )
-pNew = new SwRangeRedline( p->GetRedlineData(), aNewStt );
-else
-{
-pNew->DeleteMark();
-*pNew->GetPoint() = aNewStt;
-}
+if( aNewStt >= *pEnd )
+return ret;
-pNew->SetMark();
-GoEndSection( pNew->GetPoint() );
-// i60396: If the redlines starts before a table but the table is
the last member
-// of the section, the GoEndSection will end inside the table.
-// This will result in an incorrect redline, so we've to go back
-SwNode* pTab =
pNew->GetPoint()->GetNode().StartOfSectionNode()->FindTableNode();
-// We end in a table when pTab != 0
-if(
[Libreoffice-bugs] [Bug 151404] How To Find Out The Cash App Direct Deposit Time?
https://bugs.documentfoundation.org/show_bug.cgi?id=151404 Eike Rathke changed: What|Removed |Added Component|Android Editor |deletionRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151409] New: Missing colon in "Vertical maximum"
https://bugs.documentfoundation.org/show_bug.cgi?id=151409 Bug ID: 151409 Summary: Missing colon in "Vertical maximum" Product: LibreOffice Version: 7.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tuomas.hiet...@iki.fi Description: It looks like the string "Vertical maximum" in sc/messages is missing a colon at the end. (Compare to the string below it in Weblate.) Steps to Reproduce: 1. See https://translations.documentfoundation.org/translate/libo_ui-master/scmessages/en/?checksum=e1c0d4bcc4e5818c Actual Results: There's no colon at the end. Expected Results: There is a colon at the end. Reproducible: Always User Profile Reset: No Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
Looking for reviewer for makefiles
Hi all, Change 137159 [1] is expecting review for some weeks. Christian Lohmaier made some comments (thanks to him), but he seems away from gerrit since some times. Don't be afraid by the size: this change is huge because it converts .ott and .ots files to their xml content. The main concern is about makefiles (extras/Pakage_tplwiz*.mk were merged). Could someone check the .mk files? Many thanks in advance. Laurent Balland [1] https://gerrit.libreoffice.org/c/core/+/137159
[Libreoffice-bugs] [Bug 104224] [META] LibreLogo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=104224 Bug 104224 depends on bug 120411, which changed state. Bug 120411 Summary: LibreLogo: support keyboard shortcuts https://bugs.documentfoundation.org/show_bug.cgi?id=120411 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120411] LibreLogo: support keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=120411 László Németh changed: What|Removed |Added CC||nem...@numbertext.org Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from László Németh --- Solved in newer versions of LibreOffice, see on the attached screenshot. In Tools->Customize..., choose in Category list Application Macros -> Application Macros -> LibreLogo -> LibreLogo and run, etc. Note: new LibreLogo got .uno commands: .uno:LibreLogo-goforward .uno:LibreLogo-gobackward .uno:LibreLogo-left .uno:LibreLogo-right .uno:LibreLogo-run .uno:LibreLogo-stop .uno:LibreLogo-home .uno:LibreLogo-clearscreen .uno:LibreLogo-translate -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151375] Crash when running insertDocumentFromURL with certain document
https://bugs.documentfoundation.org/show_bug.cgi?id=151375 Michael Stahl (allotropia) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Keywords||bisected, regression Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | Version|7.5.0.0 alpha0+ Master |7.1.0.3 release --- Comment #4 from Michael Stahl (allotropia) --- fixed on master was another problem from commit e366c928819c44b5c253c45dca6dae40b71c9808 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Bug 103100 depends on bug 145871, which changed state. Bug 145871 Summary: Table row heights increased in legacy odt https://bugs.documentfoundation.org/show_bug.cgi?id=145871 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145871] Table row heights increased in legacy odt
https://bugs.documentfoundation.org/show_bug.cgi?id=145871 Michael Stahl (allotropia) changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | --- Comment #4 from Michael Stahl (allotropia) --- fixed on master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120411] LibreLogo: support keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=120411 --- Comment #1 from László Németh --- Created attachment 182905 --> https://bugs.documentfoundation.org/attachment.cgi?id=182905=edit LibreLogo shortcuts in LibreOffice 7.5 development version -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151375] Crash when running insertDocumentFromURL with certain document
https://bugs.documentfoundation.org/show_bug.cgi?id=151375 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151375] Crash when running insertDocumentFromURL with certain document
https://bugs.documentfoundation.org/show_bug.cgi?id=151375 --- Comment #3 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ac8717e861608031e50230015c90e64282a10ad0 tdf#151375 sw: ODF import: delete any layout frames before ... It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145871] Table row heights increased in legacy odt
https://bugs.documentfoundation.org/show_bug.cgi?id=145871 --- Comment #3 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4757dfc2a520f63fba0b27cc161fe732231dbd0e tdf#145871 sw: ODF import: don't convert subtables if outer row ... It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145871] Table row heights increased in legacy odt
https://bugs.documentfoundation.org/show_bug.cgi?id=145871 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/core/table/swnewtable.cxx | 29 +
1 file changed, 29 insertions(+)
New commits:
commit ac8717e861608031e50230015c90e64282a10ad0
Author: Michael Stahl
AuthorDate: Fri Oct 7 16:21:27 2022 +0200
Commit: Michael Stahl
CommitDate: Fri Oct 7 17:45:08 2022 +0200
tdf#151375 sw: ODF import: delete any layout frames before ...
... converting subtables.
This avoids use-after-free by the frames or a11y code on deleted cells.
For file open, there is no layout at this point, but when inserting a
file the crash happens.
(regression from commit e366c928819c44b5c253c45dca6dae40b71c9808)
Change-Id: Ia2cbe548fd5cdce7ae2479bfc3dc993ebb3ce830
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141080
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/table/swnewtable.cxx
b/sw/source/core/table/swnewtable.cxx
index 8d6bcf023d2c..a0c420b1876c 100644
--- a/sw/source/core/table/swnewtable.cxx
+++ b/sw/source/core/table/swnewtable.cxx
@@ -2382,6 +2382,8 @@ bool SwTable::CanConvertSubtables() const
void SwTable::ConvertSubtables()
{
+FndBox_ all(nullptr, nullptr);
+all.DelFrames(*this); // tdf#151375 avoid UAF by frames on deleted cells
for (size_t i = 0; i < GetTabLines().size(); ++i)
{
SwTableLine *const pLine(GetTabLines()[i]);
@@ -2397,6 +2399,7 @@ void SwTable::ConvertSubtables()
}
GCLines();
m_bNewModel = true;
+all.MakeFrames(*this);
#if 0
// note: outline nodes (and ordinary lists) are sorted by MoveNodes()
itself
// (this could change order inside table of contents, but that's a
commit 4757dfc2a520f63fba0b27cc161fe732231dbd0e
Author: Michael Stahl
AuthorDate: Fri Oct 7 16:13:05 2022 +0200
Commit: Michael Stahl
CommitDate: Fri Oct 7 17:44:54 2022 +0200
tdf#145871 sw: ODF import: don't convert subtables if outer row ...
... has fixed or min height.
The code had 2 obvious problems: the fixed height on the outer row
wasn't cleared if the inner row didn't have a fixed height, and the code
to set lastSize on the last row erroneously set the first row's height
as well due to sharing the row format.
But it turns out that this doesn't work anyway in case any of the inner
rows are variable sized, because without layout it's not possible to
determine the height of these rows, and so the lastSize is going to be
too large in many cases.
(regression from commit e366c928819c44b5c253c45dca6dae40b71c9808)
Change-Id: I42ac7c14236562f9cae228efc0e98dc2fa8c2a23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141079
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/table/swnewtable.cxx
b/sw/source/core/table/swnewtable.cxx
index d87c039185c0..8d6bcf023d2c 100644
--- a/sw/source/core/table/swnewtable.cxx
+++ b/sw/source/core/table/swnewtable.cxx
@@ -2133,6 +2133,11 @@ void SwTable::ConvertSubtableBox(sal_uInt16 const nRow,
sal_uInt16 const nBox)
assert(!pSubTableBox->GetTabLines().empty());
// are relative (%) heights possible? apparently not
SwFormatFrameSize const
outerSize(pSourceLine->GetFrameFormat()->GetFrameSize());
+if (outerSize.GetHeightSizeType() != SwFrameSize::Variable)
+{ // tdf#145871 clear fixed size in first row
+pSourceLine->ClaimFrameFormat();
+pSourceLine->GetFrameFormat()->ResetFormatAttr(RES_FRM_SIZE);
+}
tools::Long minHeights(0);
{
SwFrameFormat const&
rSubLineFormat(*pSubTableBox->GetTabLines()[0]->GetFrameFormat());
@@ -2171,12 +2176,14 @@ void SwTable::ConvertSubtableBox(sal_uInt16 const nRow,
sal_uInt16 const nBox)
&& outerSize.GetHeightSizeType() != SwFrameSize::Variable
&& minHeights < outerSize.GetHeight())
{
+assert(false); // this should be impossible currently, such
subtable isn't converted because layout is needed to determine how much space
is taken up by variable height rows
SwFormatFrameSize
lastSize(pNewLine->GetFrameFormat()->GetFrameSize());
lastSize.SetHeight(lastSize.GetHeight() + outerSize.GetHeight() -
minHeights);
if (lastSize.GetHeightSizeType() == SwFrameSize::Variable)
{
lastSize.SetHeightSizeType(SwFrameSize::Minimum);
}
+pNewLine->ClaimFrameFormat();
pNewLine->GetFrameFormat()->SetFormatAttr(lastSize);
}
SfxPoolItem const* pRowBrush(nullptr);
@@ -2295,6 +2302,7 @@ bool SwTable::CanConvertSubtables() const
return false;
}
haveSubtable = true;
+bool haveNonFixedInnerLine(false);
for (SwTableLine const*const pInnerLine : pBox->GetTabLines())
{
// bitmap row background will look different
@@ -2311,6
