3) Click on Profile, pick your Username (your freenode IRC nick)
Still not joined IRC, used 'ivan' as Username. Ok?
7/ people with a fdo account, please let us know when you've done the
above so that we can add you to the appropriate group on gerrit
I am ready. fdo account name:
sc/source/filter/excel/xecontent.cxx |1 +
sw/source/ui/uiview/pview.cxx|2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 6f6a419a39f8d97a49a84ae730ecd3d93738a744
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue May 15 10:39:17 2012 +0400
Hi Petr,
On 15.05.2012 14:17, Petr Mladek wrote:
+ some commits fix more bugs; your solution returns summary of
the last one
+ there might be more commits for the same bug; you might get
more exactly same lines
Yes.
(also there might be reverts, so that
Hi,
looking at our release notes
http://wiki.documentfoundation.org/Releases/3.5.3/RC1
I think it is confusing for users to see the git commit messages there.
For example:
clrContourCache for SwAnchoredDrawObjects (fdo#45376) [Andreas Schierl]
What about using the bug names? Mozilla does
Hi,
attached a simplified fix for
https://bugs.freedesktop.org/show_bug.cgi?id=39106
(just see https://bugs.freedesktop.org/attachment.cgi?id=48958)
In the gtk native theming only vertical separators were supported. The
patch falls back to non-native rendering in the case of vertical
On 09.05.2012 12:22, Jean-Baptiste Faure wrote:
Is this fix eligible for backport to 3.5 ?
Hopefully. :) We need a sign-off from someone courageous enough...
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On 09.05.2012 15:06, Michael Meeks wrote:
On Mon, 2012-05-07 at 22:55 +0400, Ivan Timofeev wrote:
this patch reverts commit
http://cgit.freedesktop.org/libreoffice/core/commit/?id=16c9d63da67897e51960f3684d8d05b06f2c8f81
Quote:
This ensures that we don't get a half visible entry at the bottom
cui/source/options/optlingu.src |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4979a3cfd43b9f79005bf76da9e2dbdffc9e91f5
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue May 8 17:40:28 2012 +0400
Revert fdo#49421: the Available language modules list
vcl/source/control/scrbar.cxx|2 ++
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx |1 -
2 files changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 092d72a5591283459eb261e26d57ad8ecf1d5280
Author: Ivan Timofeev timofeev@gmail.com
Date: Mon May 7 14:28:10 2012 +0400
Hi,
this patch reverts commit
http://cgit.freedesktop.org/libreoffice/core/commit/?id=16c9d63da67897e51960f3684d8d05b06f2c8f81
Quote:
This ensures that we don't get a half visible entry at the bottom of
the view.
Actually that creates some problems:
1. Some listboxes get too small so that
cui/source/options/optlingu.src |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 31182ed08494ed6afa3371aa246b155c6b58e8b3
Author: Ivan Timofeev timofeev@gmail.com
Date: Sun May 6 22:16:59 2012 +0400
fdo#49421: the Available language modules list is too
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
New commits:
commit c1ac12f52776c625c7a091ab864b9e99e3bc3d67
Author: Ivan Timofeev timofeev@gmail.com
Date: Sat May 5 14:34:47 2012 +0400
gtk: fix drawing of disabled
(+), 38 deletions(-)
New commits:
commit f1005e50e795a06b5504960a94e529b48e085a91
Author: Ivan Timofeev timofeev@gmail.com
Date: Sat May 5 20:07:41 2012 +0400
gtk: fix drawing of separators in vertical toolbars
(regression from 0377b99b3f50a67e7845a3d728313e5a2ef36e73
On 02.05.2012 18:44, Andras Timar wrote:
Yes. When I extract en-US strings and run po migration scripts, po
files will be correct automatically.
oh, great! :) Thank you!
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
svx/source/xoutdev/xtablend.cxx |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
New commits:
commit f4eb738cf778a337e31a864fc4a6af36f0fa60a5
Author: Ivan Timofeev timofeev@gmail.com
Date: Mon Apr 30 17:36:05 2012 +0400
fdo#48536: prevent lineends from exceeding
sc/source/ui/navipi/navipi.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 1a87849f1971bf6802cc3d6395181b6ff0ceeed1
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue Apr 24 21:22:16 2012 +0400
fdo#34999: UI: Navigator row selector pane exceeds
cui/source/tabpages/page.cxx |4 ++--
cui/source/tabpages/page.h|3 ++-
cui/source/tabpages/page.src |3 ++-
i18nutil/inc/i18nutil/paper.hxx |7 ---
i18nutil/source/utility/paper.cxx |6 --
sd/inc/sdenumdef.hxx |2 +-
Hi Rob,
thanks a lot, great work! :)
Just one detail: if you add smth to 'static const int PaperIndex'
(print.cxx), I suppose you also have to add it to RID_STR_PAPERNAMES
(print.src):
OSL_ENSURE( sal_uInt32(SAL_N_ELEMENTS(PaperIndex)) ==
aPaperStrings.Count(), localized paper name count
vcl/source/window/menu.cxx |5 -
vcl/win/source/gdi/salnativewidgets-luna.cxx | 21 +
2 files changed, 17 insertions(+), 9 deletions(-)
New commits:
commit 3a603d376a2bc2b839be3b89a8ecf8df1c42260b
Author: Ivan Timofeev timofeev@gmail.com
Date
Hi!
The bug: https://bugs.freedesktop.org/show_bug.cgi?id=42537
The fix for libreoffice-3-5 attached. It consists of the following commits:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4cc4d3ec982ac61100b337125983afa0bb6fbc3
vcl/win/source/gdi/salnativewidgets-luna.cxx | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
New commits:
commit a4cc4d3ec982ac61100b337125983afa0bb6fbc3
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Apr 11 21:34:06 2012 +0400
vcl: win: fix RTL menu
xmloff/source/chart/SchXMLExport.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9c323a4bbe0f7dec33523e87e1c1010dd832d4bf
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Apr 11 22:18:22 2012 +0400
fix windows build
diff --git a/xmloff/source/chart
Hi Luc,
On 10.04.2012 11:31, Luc Castermans wrote:
Altough not about LibreOffice we should learn from attached:
http://www.whymicrosoft.com/en-us/pages/openoffice.aspx
Don't take it to heart ;) Microsoft makes money.
Ivan
___
LibreOffice mailing
Subramanian sumu...@suse.com
Date: Mon Apr 9 18:24:11 2012 +0530
fdo43752: PPTX import fix affected odp imports.
Related bugs: n#719989, n#719997
(cherry picked from commit 1c44b263d789b4c20e9178c6432300e301df94d6)
Signed-off-by: Ivan Timofeev timofeev@gmail.com
starmath/source/node.cxx |4 ++--
starmath/source/parse.cxx |4 +---
2 files changed, 3 insertions(+), 5 deletions(-)
New commits:
commit 5f80687188db3a29fb0c3a5fe587aeeb3e13dccd
Author: Ivan Timofeev timofeev@gmail.com
Date: Sun Apr 8 14:11:11 2012 +0400
Revert fdo#41739
files changed, 11 insertions(+), 74 deletions(-)
New commits:
commit c5154a179f435cc23798057895b0db8312bcd6f6
Author: Ivan Timofeev timofeev@gmail.com
Date: Thu Apr 5 21:08:26 2012 +0400
SfxViewShell::GetScrollingMode always returns SCROLLING_DEFAULT
diff --git a/sc/source/ui/view
sw/source/ui/index/cnttab.cxx | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
New commits:
commit 33619919036457e3a37c4c47a8cef274d55253a8
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Apr 4 19:22:52 2012 +0400
reuse existent function
diff --git a/sw/source
Hi!
Please push to libreoffice-3-5:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b49f69aee6f48fb9367a2a9548182dcd84eb5296
The patch is trivial: 'it' is a loop-control variable, 'itRight' should
point to a right neighbor.
Thanks,
Ivan
___
framework/source/services/backingwindow.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 4e24d472f693c458b17d2ba1fb6c883aaf9c3b27
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue Apr 3 20:40:14 2012 +0400
fix the initial font size in the Start Center
sc/inc/chartpos.hxx | 10 +-
sc/source/core/tool/chartpos.cxx | 161 +++
2 files changed, 88 insertions(+), 83 deletions(-)
New commits:
commit 6b170f3d0aa519c6fd4e3ee92421f5a87ab511e3
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed
Hi Noel,
pushed after all (phew!) :) Added some corrections in the subsequent
commits - see the git log.
But I wonder why in the following code... (chartpos.cxx:548)
RowMap::const_iterator pPosIter = pCol2-begin();
if ( pPosIter != pCol2-end() )
{
Hi Noel,
On 14.03.2012 17:02, Noel Grandin wrote:
Note that this is not the nicest patch to review because I'm converting
complicated nested loops.
Heh - right, *two weeks* have passed. :(
I have reviewed it - some not-equal-to-null conditions got lost
(ScAddress may be NULL) and
-
Hi Michael,
On 27.03.2012 17:24, Michael Meeks wrote:
I wondered - are there any serious known issues in this anymore ?
and/or is there any reason why it's left as an experimental feature ?
There are some small (or not small) problems:
1. Ctrl+Z doesn't work.
2. Typed keywords aren't
On 27.03.2012 17:40, Ivan Timofeev wrote:
3. Impossible to write statements like 'cos x' without adding a space
between 'cos' and 'x'.
Sorry, I mean this statement becomes 'cos ~ x' - additional space is added.
Ivan
___
LibreOffice mailing list
On 27.03.2012 10:31, Ivan Timofeev wrote:
I will push this patch with some corrections towards evening,
Hum, towards *tomorrow's* evening. :)
Sorry,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org
Hi Julien,
On 24.03.2012 03:26, julien2412 wrote:
Just for the update, is there anybody who could help about this ?
I am not expert, too, but looking at vcl/source/gdi/sallayout.cxx:115
and http://www.unicode.org/charts/PDF/UFF00.pdf I'd say that the
condition should be at least
(nChar =
starmath/source/parse.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit f52138deee9e129d0566f06d1d2138b6b159d16a
Author: Ivan Timofeev timofeev@gmail.com
Date: Thu Mar 22 10:03:03 2012 +0400
fdo#41739: Math: do not skip newline on error
diff --git
Hi
On 18.03.2012 12:41, julien2412 wrote:
Just to make notice that Cppcheck reports Same expression on both sides of
'==' on sc/source/core/data/dpitemdata.cxx, line 217. Here are the lines :
...
216 if (mbStringInterned r.mbStringInterned)
217 return mpString ==
Hi Noel,
This is already done in your commit
64cba6e58263e906aba6a110937f362d1e31ebe5 but in a different way though.
Cheers,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
sc/source/filter/html/htmlpars.cxx |3 ++-
sc/source/filter/inc/eeparser.hxx |8 +---
sc/source/filter/rtf/eeimpars.cxx | 28
3 files changed, 23 insertions(+), 16 deletions(-)
New commits:
commit 96328945afe8f920df41741931163ba56b7b2820
Author: Noel
On 15.03.2012 16:55, Noel Grandin wrote:
The problem is that open-source developers cannot be motivated to work
80% on bugs and 20% on features.
Perhaps, if you mean the whole team. But note that there are some
lunatic guys like me, who are interested in bug-fixing ~completely. ;)
Ivan
Hi Noel,
pushed, thank you!
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 15.03.2012 20:23, Michael Meeks wrote:
On Thu, 2012-03-15 at 17:04 +0400, Ivan Timofeev wrote:
Perhaps, if you mean the whole team. But note that there are some
lunatic guys like me, who are interested in bug-fixing ~completely. ;)
Yep - you're a star ! :-)
*timid smile
On 15.03.2012 20:23, Michael Meeks wrote:
On Thu, 2012-03-15 at 17:04 +0400, Ivan Timofeev wrote:
Perhaps, if you mean the whole team. But note that there are some
lunatic guys like me, who are interested in bug-fixing ~completely. ;)
Yep - you're a star ! :-)
*timid smile
On 14.03.2012 16:56, Joop Kiefte wrote:
I recommend/suggest to answer in the language you speak best (I suppose
Russian in this case)
At least, I could translate from Russian to English, and I think I would
do it better then Google Translate... :)
Ivan
Hi David,
actually, your fix was my first attempt to solve the bug. It solved the
UI problem, I remember. And then I decided to clean-up the code a bit...
You might see my patch. :)
But I cannot ever understand, how it fixes the real problem (setting
paper tray).
sw/source/ui/uiview/viewport.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f1040f9fa7e3af5ccc91a4cbc0ff781dd372107d
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue Mar 13 17:19:57 2012 +0400
always use the *real* visibility of the SwScrollbar
On 09.02.2012 21:38, Ivan Timofeev wrote:
Another question is why in the code above there is
pVScrollbar-IsVisible(sal_False)
for the vertical scrollbar. I don't know. If this condition is true,
then the right border should be set:
rToFill.Right() = nTmp;
But even if you move that line
editeng/source/editeng/impedit.hxx |6 ++--
editeng/source/editeng/impedit3.cxx | 50 ++--
editeng/source/editeng/impedit4.cxx |4 +-
3 files changed, 25 insertions(+), 35 deletions(-)
New commits:
commit f2d0fcc26be481c2f872056fb3b8402169d124d8
Author:
sax/source/expatwrap/xml2utf.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 53f661b3140fe728fe3b8f421841dcb8e6f716ab
Author: Ivan Timofeev timofeev@gmail.com
Date: Mon Mar 12 22:26:05 2012 +0400
sax: no matching function for call to 'max(int
Hi Bartosz,
On 11.03.2012 01:29, Bartosz wrote:
I updates the patch.
Could you please push it to libreoffice?
Surely! Pushed:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f2d0fcc26be481c2f872056fb3b8402169d124d8
But I cannot find your license statement.
Thanks,
Ivan
Hi Noel,
for ( SCCOL nCol = nStartCol; nCol = nEndCol; nCol++ )
{
- sal_uInt16 nWidth = (sal_uInt16)(sal_uLong) pColWidths-Get( nCol );
+ sal_uInt16 nWidth = 0;
+ if ( rColWidths.find( nCol ) != rColWidths.end() )
+ nWidth = rColWidths[ nCol ];
so this code performs a search
oox/source/core/xmlfilterbase.cxx |5 -
unusedcode.easy |1 -
2 files changed, 6 deletions(-)
New commits:
commit b6ff047a572189a2b000ffbd437e573e518773db
Author: Petr Vorel petr.vo...@gmail.com
Date: Sun Mar 11 19:02:40 2012 +0400
remove unused code
diff
On 11.03.2012 17:27, Noel Grandin wrote:
please ignore this one, I need to redo it.
Ha! I was going to push it...
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Petr,
On 09.03.2012 11:39, Petr Vorel wrote:
another patch removing unused code. Actually I need an advice this time. Is
method oox::core::XmlFilterBase::getChartConverter() really unused / unwanted?
As it's used in Shape::finalizeXShape (oox/source/drawingml/shape.cxx). So feel
free to drop
sw/source/ui/inc/basesh.hxx|3 ---
sw/source/ui/shells/basesh.cxx | 11 +++
2 files changed, 3 insertions(+), 11 deletions(-)
New commits:
commit ee77e4a776de74de06ffb51ebe3a9f597e532e8a
Author: Ivan Timofeev timofeev@gmail.com
Date: Tue Mar 6 19:26:34 2012 +0400
Hi Winfried,
On 06.03.2012 11:50, Winfried Donkers wrote:
Ivan Timofeev wrote (5 maart 2012 18:08)
1. Open a new Writer doc
2. Type smth
3. Press the Background Color button
- nothing happens (?)
That is expected behaviour to me. The startup background colur is transparent
(hence
toolkit/inc/toolkit/controls/unocontrolmodel.hxx |6 -
toolkit/source/controls/unocontrolmodel.cxx | 135 +++
2 files changed, 48 insertions(+), 93 deletions(-)
New commits:
commit d578654354cc15b4d491b441412c1eb41a878b10
Author: Noel Grandin n...@peralex.com
Date:
svtools/source/edit/textdat2.hxx |8 +--
svtools/source/edit/textdata.cxx |5 --
svtools/source/edit/texteng.cxx | 84 +++
unusedcode.easy | 12 -
4 files changed, 47 insertions(+), 62 deletions(-)
New commits:
commit
Hi Noel,
On 29.02.2012 13:19, Noel Grandin wrote:
Convert tools/table.hxx usage in
toolkit/source/controls/unocontrolmodel.cxx to std::map
Pushed with some corrections, thanks, nice cleanup!
I only replaced
@@ -1252,26 +1205,29 @@ void UnoControlModel::setFastPropertyValue_NoBroadcast(
Hi Maciej,
On 25.02.2012 19:13, Maciej Rumianowski wrote:
small patches partially cleaning svltools from svarrays.
Nice patches, thank you!
I wonder why you used (*it).nStartPos instead of it-nStartPos , but
code is correct, so pushed as is.
Regards,
Ivan
Hi Bartosz,
On 29.02.2012 13:45, Bartosz wrote:
I converted the SV_DECL_VARARR_SORT and SV_IMPL_VARARR_SORT with ::std::set.
I also made some optimization (cppcheck).
Could you please check this patch and push it into libreoffice.
Oh, sorry, your patch does not apply due to
Hi Matúš,
On 02.03.2012 02:47, Matúš Kukan wrote:
Hi there,
This is my first STL C++ patch. ( I also wanted to do some conversion. )
Please review / comment / enjoy.
Sorry, that area was cleaned already
I see Tor pushed the patch
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0847fd63d773732ff3e441ef868957c55760d69a
Regards,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Hi Winfried,
On 03.03.2012 12:57, Winfried Donkers wrote:
Attached the next button with simplified code.
More to follow.
Hmmm
-else
-{
-// call without arguments, use last used background color
-aBrushItem.SetColor(
1. Open a new Writer doc
2. Type smth
3. Press the Background Color button
- nothing happens (?)
4. Select some color from the picker
- ok, it works
5. Select No Fill
- nothing happens
How to restore the transparent background?
Ivan
___
sc/inc/viewuno.hxx | 63 +++
sc/source/ui/unoobj/viewuno.cxx | 160 ++--
2 files changed, 106 insertions(+), 117 deletions(-)
New commits:
commit 07342a6aac8c32823fde4be163bb9132ed17d537
Author: Noel Grandin n...@peralex.com
Date:
Hi Noel,
On 29.02.2012 15:24, Noel Grandin wrote:
New patch with recommended fixes attached.
Great! Pushed, thanks.
I wonder, would it not be better to convert this type of listener-list
thing to boost::ptr_set?
- no chance of accidentally adding duplicates
Objects are created right
;
+}
+}
+
rOutput OOO_STRING_SVTOOLS_RTF_F;
rOutput.WriteNumber( n );
}
commit 0ecb2bd92a9dadb2e01ee5b960a48ed0552e7c06
Author: Ivan Timofeev timofeev@gmail.com
Date: Fri Mar 2 10:25:47 2012 +0400
remove traces of SvxFontTable
diff --git a/editeng/source/editeng
Hi,
-DECLARE_TABLE( SwBookmarkNodeTable, SvPtrarr* )
+typedef std::multimapsal_uLong, const ::sw::mark::IMark*
SwBookmarkNodeTable;
...
+SwBookmarkNodeTable aBkmkNodePos;
...
-SvPtrarr* pArr = (m_pImpl-pBkmkNodePos) ?
-m_pImpl-pBkmkNodePos-Get( nNd ) : 0;
-if( pArr
vcl/aqua/source/dtrans/HtmlFmtFlt.cxx |4 ++--
vcl/aqua/source/dtrans/PictToBmpFlt.cxx |4 ++--
vcl/source/gdi/print3.cxx |2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit c581d33dec47a4c411a034482876543f6357d1e8
Author: Ivan Timofeev
.
Sorry if it is insignificant for that branch.
Thanks,
Ivan
From 57acc16017ec7313b047066b1177a088aecaa2ed Mon Sep 17 00:00:00 2001
From: Ivan Timofeev timofeev@gmail.com
Date: Mon, 27 Feb 2012 16:26:39 +0400
Subject: [PATCH] fdo#31966: do not create an empty slide when printing
handouts
---
sd
Hi Christina,
On 27.02.2012 12:22, Chr. Rossmanith wrote:
some more getLength() - isEmpty() replacements. Would be nice if
someone could review the patch.
at least, aTextHtml and aData from your patch are 'Sequence's, Sequence
has not the isEmpty method IIRC, only the string classes have it.
On 27.02.2012 16:59, Ivan Timofeev wrote:
Hi Christina,
On 27.02.2012 12:22, Chr. Rossmanith wrote:
some more getLength() - isEmpty() replacements. Would be nice if
someone could review the patch.
at least, aTextHtml and aData from your patch are 'Sequence's, Sequence
has not the isEmpty
On 27.02.2012 19:01, Michael Meeks wrote:
Having said that I'm not hyper-happy with not initialising the vector's
contents - don't we really want:
std::vectorsal_uInt16 aWish( aTablCols.Count() + 1, 0 ),
aMins( aTabCols.Count() + 1, 0 );
Hmm,
On 28.02.2012 02:51, Riccardo Magliocchetti wrote:
Hello,
Il 27/02/2012 23:22, willubuntu ha scritto:
Hello guys,
I took also the opportunity to fix some indentation to get a
consistent look
in code.
Usually is better to separate the behaviour changes from the whitespace
cleanup
basegfx/inc/basegfx/polygon/b3dpolygonclipper.hxx |3 ---
1 file changed, 3 deletions(-)
New commits:
commit 0499a44cddae31dff5ce1959aba8aa64119dea90
Author: Ivan Timofeev timofeev@gmail.com
Date: Sun Feb 26 16:29:47 2012 +0400
definition was removed, remove declaration as well
Hi Elton,
On 26.02.2012 14:42, Elton Chung wrote:
Sorry, please revert the removal of line 416-500 in the original patch
which I overlooked.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0499a44cddae31dff5ce1959aba8aa64119dea90
Cheers,
Ivan
Hi,
thanks to Josh Heidenreich and his comment:
https://bugs.freedesktop.org/show_bug.cgi?id=46144#c8
http://cgit.freedesktop.org/libreoffice/core/commit/?id=996f44c310520e3d7868c62d336aaec7bb0f845a
Fixed invalid conversion from SvUShorts to std::vector... *sigh*
Please, pick to the
Hi Noel,
From: Noel Grandin noel@ubuntu.(none)
Do you really want to be @ubuntu.(none)? If not, use
$ git config --global user.email your_address_here
-for ( sal_uInt16 n=0; naActivationListeners.Count(); n++ )
+for (XActivationEventListenerVector::iterator it =
Marking as [PUSHED]:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a99083d233d0d5c5a09941ec2ee7164bc63c61db
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 21.02.2012 15:09, Noel Grandin wrote:
Thanks, that was just the suggestion I needed! Converted patch to use
boost:ptr_map.
Great! Pushed, thanks for it.
Could you prepare your future patches using 'git format-patch', please?
Best Regards,
Ivan
Hi Noel,
On 14.02.2012 15:25, Noel Grandin wrote:
Note that I tried converting these usages to boost::ptr_map, but I ran
into entirely undecipherable C++ template errors.
Sorry for the late review... :(
What line produces that error? I suppose we should do use ptr_map,
because even you
On 20.02.2012 19:12, Noel Grandin wrote:
The error was sourced several levels down in the boost stuff, and the
originating point was everywhere I tried to assign into ptr_map.
I think it had something to with the copyability of the Font class.
Did you try to use 'insert(key, value)' instead of
basegfx/inc/basegfx/polygon/b2dpolygontools.hxx | 10 --
basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx | 27 ---
basegfx/source/polygon/b2dpolygontools.cxx | 37 --
basegfx/source/polygon/b2dpolypolygontools.cxx | 26 ---
On 19.02.2012 12:25, Elton Chung wrote:
This patch removes 5 unused methods.
Pushed, thank you!
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 19.02.2012 16:01, Elton Chung wrote:
This patch converts some size() == 0 usage to empty() for performance reasons.
Pushed partially...
I dropped changes in sc/qa/unit/ucalc.cxx - there are no appropriate
empty() function; and in soltools/giparser/st_gilrw.cxx - but luckily
this stuff
svx/inc/svx/contdlg.hxx |8
unusedcode.easy |6 --
2 files changed, 14 deletions(-)
New commits:
commit 5d7b70f8c8e912ebca068cf57058a92b0b05809f
Author: Elton Chung el...@layerjet.com
Date: Sat Feb 18 23:15:40 2012 +0800
Remove unused code
diff --git
vcl/source/window/splitwin.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 46506f82d1d514194aa2b472f6a74398c404fa9d
Author: Ivan Timofeev timofeev@gmail.com
Date: Sat Feb 18 22:24:11 2012 +0400
fix build
diff --git a/vcl/source/window/splitwin.cxx b/vcl/source
On 18.02.2012 17:29, Mariusz Dykierek wrote:
I have a 'replacement' patch that actually replaces most of if...else if...else
chains with
switches.
Great!
They are more legible and seem natural when choosing branches depending on the
same variable.
On the other hand, the evaluated
On 18.02.2012 19:35, Elton Chung wrote:
This patch is an addendum to commit 600c27470380f80445fecb4b5691e0d11060494d.
Yeah, nice catch. Thanks, pushed.
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Marking this as [OUTDATED] for convenience, I don't know what is the
preferred tag for the outdated patches.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 17.02.2012 00:20, Kohei Yoshida wrote:
As far as I know those STL methods that return its element are
guaranteed to return a reference to the stored instance, not its copy.
Ah, great, I was not sure of that.
On 17.02.2012 01:01, Michael Meeks wrote:
I guess :-) I imagine the real
843eafc765a3d1d0ea4c9a89855c73e81784aa8b
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Feb 15 20:44:26 2012 +0400
tweak Convert tools/table.hxx in editeng/forbiddencharacterstable.hxx...
* remove 'const' from GetForbiddenCharacters
* CharInfoMap - Map
* pInf
Hi,
I found soltools/javadep/javadep.c that contains a very simple parser
for java class files. The problem is that it is old, at least it does
not handle the class files generated by Java 7: as far as I remember,
java guys added the new types of constant pool entries, but...
javadep.c:520:
On 15.02.2012 20:41, Stephan Bergmann wrote:
Apparently only remaining use is in the old build system (see
solenv/inc/rules.mk, where it is called STARDEP). So I would not bother
to invest any time in it -- as long as its shortcomings do not actually
cause problems (which I don't quite get from
Hi Noel,
On 15.02.2012 19:01, Noel Grandin wrote:
Updated patch implementing Ivan's suggestion. Passes make and make check.
Convert tools/table.hxx usage in
editeng/inc/editeng/forbiddencharacterstable.hxx to std::map
Looks good to me, pushed (without GetCharInfo - it was unused):
Whoa, I seem to be too naive for patch-reviewing...
Is it a safe code?
pForbiddenCharacters = maMap[ nLanguage ];
return pForbiddenCharacters;
Will pForbiddenCharacters point to the deleted object, after the return?
Terribly sorry for such a question...
Regards,
Ivan
On 14.02.2012 19:31, Michael Meeks wrote:
On Tue, 2012-02-14 at 16:16 +0100, Jan Holesovsky wrote:
Markus has implemented a nice feature that should help keeping the bugs
up to date: whenever you are committing / pushing to git, and you
ooh ! really lovely :-)
Great work
On 14.02.2012 19:31, Michael Meeks wrote:
On Tue, 2012-02-14 at 16:16 +0100, Jan Holesovsky wrote:
Markus has implemented a nice feature that should help keeping the bugs
up to date: whenever you are committing / pushing to git, and you
ooh ! really lovely :-)
Great work
301 - 400 of 584 matches
Mail list logo
