[Libreoffice-commits] core.git: oox/qa oox/source

2023-01-05 Thread Regina Henschel (via logerrit)
/drawingml/color.cxx |6 + 5 files changed, 74 insertions(+), 1 deletion(-) New commits: commit f4a568fc0553603fbf05477e0942af4e8466fba0 Author: Regina Henschel AuthorDate: Tue Jan 3 20:13:12 2023 +0100 Commit: Regina Henschel CommitDate: Thu Jan 5 09:13:37 2023

Re: Trouble with theme color in docx

2023-01-03 Thread Regina Henschel
Hi Tomaž, Tomaž Vajngerl schrieb am 03.01.2023 um 12:02: Yes, you can add the missing long keys here and map them to the dark/light variant. It turned out, that that was not the only place to change. Adding the missing long key gives the correct color, but the FillColorTheme property

[Libreoffice-commits] core.git: oox/inc oox/Library_oox.mk oox/qa oox/source

2023-01-02 Thread Regina Henschel (via logerrit)
|1 11 files changed, 1013 insertions(+), 158 deletions(-) New commits: commit cbf30153a5c776e6d1ee26f2f83c8f77503eceb9 Author: Regina Henschel AuthorDate: Sat Dec 3 15:37:49 2022 +0100 Commit: Miklos Vajna CommitDate: Mon Jan 2 08:19:37 2023 + tdf#125885 Conversion WordArt

Trouble with theme color in docx

2023-01-01 Thread Regina Henschel
Hi Miklos, hi Tomaž, hi all, Tomaž, I have put you in CC because you are currently heavily working on theme colors. I come across the problem, that my import in https://gerrit.libreoffice.org/c/core/+/143615 does not get the correct color, if theme colors other than 'accent1'..'accent6' are

Re: DOCX import: MS Office WordArt to LO Fontwork

2022-12-25 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 15.12.2022 um 09:34: Hi Regina, (B) The current import does not generate a Fontwork at all. However, LO will recreate the WordArt from the GrabBags, if the document is resaved to docx and nothing on the shape was changed. With my work, a Fontwork is created

Re: DOCX import: MS Office WordArt to LO Fontwork

2022-12-21 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 15.12.2022 um 09:34: Hi Regina, On Wed, Dec 14, 2022 at 11:39:03PM +0100, Regina Henschel wrote: (B) The current import does not generate a Fontwork at all. However, LO will recreate the WordArt from the GrabBags, if the document is resaved to docx

Re: transparency <-> opacity in import from MS Office

2022-12-16 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 16.12.2022 um 15:24: Hi Regina, On Thu, Dec 15, 2022 at 08:25:29PM +0100, Regina Henschel wrote: if a MS Office user sets 80% Transparency for a stroke, MS Office writes this as . That means, that MS Office writes it out as opacity (which corresponds

transparency <-> opacity in import from MS Office

2022-12-15 Thread Regina Henschel
Hi all, if a MS Office user sets 80% Transparency for a stroke, MS Office writes this as . That means, that MS Office writes it out as opacity (which corresponds to the OOXML spec). Our oox::drawingml::Color has for example void Color::clearTransparence() {mnAlpha = MAX_PERCENT;} or

DOCX import: MS Office WordArt to LO Fontwork

2022-12-14 Thread Regina Henschel
Hi all, you might have noticed, that I'm working on import of WordArt in DOCX. https://gerrit.libreoffice.org/c/core/+/143615 The work has now progressed to the point where it is possible to discuss the principle. Import of dashes is missing and unit tests are missing. But that is no

Re: Where to put a static method for common use in oox?

2022-12-02 Thread Regina Henschel
Hi Tomaž, isn't /core/include/oox/drawingml/shape.hxx a too wide scope? Would a new file in /core/oox/inc/drawingml/ work as well? Kind regards, Regina Tomaž Vajngerl schrieb am 02.12.2022 um 01:03: Hi Regina, On Fri, Dec 2, 2022 at 8:39 AM Regina Henschel <mailto:rb.hensc...@t-online

Where to put a static method for common use in oox?

2022-12-01 Thread Regina Henschel
Hi all, I'm going to implement generating Fontwork shapes in import of docx (bug 125884). Thereby I have noticed, that the method static void lcl_putCustomShapeIntoTextPathMode(const uno::Reference& xShape, const CustomShapePropertiesPtr&

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - sc/inc sc/qa sc/source test/source

2022-11-30 Thread Regina Henschel (via logerrit)
/xmlimprt.hxx |3 test/source/sheet/xsheetannotationshapesupplier.cxx |2 11 files changed, 361 insertions(+), 110 deletions(-) New commits: commit f43ac75e8e3d8520aef8a5baeda4543bdae44b10 Author: Regina Henschel AuthorDate: Sat Oct 10 17:55:31 2020 +0200 Commit

Re: [solved] How to remove frame in SdrCustomShape during import from docx?

2022-11-29 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 29.11.2022 um 08:18: Hi Regina, On Mon, Nov 28, 2022 at 08:19:26PM +0100, Regina Henschel wrote: I will try this now. It seems to remove the frame: uno::Reference xPropertySet(mxShape, uno::UNO_QUERY); if (xPropertySet.is()) { uno::Reference

Re: How to remove frame in SdrCustomShape during import from docx?

2022-11-28 Thread Regina Henschel
Hi Miklos, I will try this now. It seems to remove the frame: uno::Reference xPropertySet(mxShape, uno::UNO_QUERY); if (xPropertySet.is()) { uno::Reference xTextBoxContent( xPropertySet->getPropertyValue("TextBoxContent"), uno::UNO_QUERY); if (xTextBoxContent.is())

Re: How to remove frame in SdrCustomShape during import from docx?

2022-11-28 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 28.11.2022 um 09:13: Hi Regina, On Sat, Nov 26, 2022 at 10:01:56PM +0100, Regina Henschel wrote: The fact, that the shape should be a text warp (WordArt, Fontwork) is detected in WpsContext in case prstTxWarp exists. At that time a frame already exists

How to remove frame in SdrCustomShape during import from docx?

2022-11-26 Thread Regina Henschel
Hi all, Problem is: The fact, that the shape should be a text warp (WordArt, Fontwork) is detected in WpsContext in case prstTxWarp exists. At that time a frame already exists in the shape. But with a frame it is impossible to put the custom shape into text path mode. How can I remove the

Re: Test failure on some Windows systems with 125% display scaling, Chart2ImportTest::testAutomaticSizeBarChartVeryLongLabel

2022-11-20 Thread Regina Henschel
Hi Ilmari, Ilmari Lauhakangas schrieb am 19.11.2022 um 15:41: A new dev is seeing this test failure on Windows with 125% scaling, the test passes if scaling is set to 100%: C:/cygwin/home/Client/lode/dev/core/chart2/qa/extras/chart2import.cxx(2273) : error : Assertion Test name:

Re: table and section in East Asian vertical writing mode

2022-11-16 Thread Regina Henschel
schrieb am 16.11.2022 um 14:19: Mark Hung mailto:mark...@gmail.com>> 於 2022年11月16 日 週三 晚上9:12寫道: Hi, Miklos Vajna mailto:vmik...@collabora.com>> 於 2022年11月16日 週三 下午4:05寫道: Hi, On Tue, Nov 15, 2022 at 01:04:12AM +0100, Regina Henschel mailto:r

table and section in East Asian vertical writing mode

2022-11-14 Thread Regina Henschel
Hi all, with East Asian vertical writing mode I mean the file markup style:writing-mode="tb-rl", which is "Text direction Right-to-left (vertical)" in page or frame properties or "Text direction from Top to Bottom" in the UI of text boxes. Because of several issues (OASIS ODF TC) with the

[Libreoffice-commits] core.git: oox/qa oox/source sd/qa

2022-11-12 Thread Regina Henschel (via logerrit)
| 15 5 files changed, 329 insertions(+), 138 deletions(-) New commits: commit bd7f1270cf58eba7600d1b4c6c8ca9a901a04f66 Author: Regina Henschel AuthorDate: Tue Nov 8 10:28:08 2022 +0100 Commit: Regina Henschel CommitDate: Sat Nov 12 12:45:03 2022 +0100 tdf#125085 PPTX

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - oox/source sd/qa sw/qa

2022-11-10 Thread Regina Henschel (via logerrit)
/extras/ooxmlexport/ooxmlexport18.cxx| 18 + 5 files changed, 67 insertions(+), 22 deletions(-) New commits: commit 59b44e72f46021c070095a75a0d7e0ae12c43399 Author: Regina Henschel AuthorDate: Wed Nov 2 22:34:16 2022 +0100 Commit: Michael Stahl CommitDate: Thu Nov 10 11

[Libreoffice-commits] core.git: oox/source sd/qa sw/qa

2022-11-03 Thread Regina Henschel (via logerrit)
/extras/ooxmlexport/ooxmlexport18.cxx| 18 + 5 files changed, 63 insertions(+), 22 deletions(-) New commits: commit 933768ffcd8617942f45481de77e656ded9dcfe2 Author: Regina Henschel AuthorDate: Wed Nov 2 22:34:16 2022 +0100 Commit: Regina Henschel CommitDate: Thu Nov 3

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - oox/inc oox/qa oox/source

2022-11-02 Thread Regina Henschel (via logerrit)
, 24 insertions(+), 1 deletion(-) New commits: commit f0a86f50516c1f887b054fe0d042bf9be8c83975 Author: Regina Henschel AuthorDate: Sun Oct 30 22:53:55 2022 +0100 Commit: Xisco Fauli CommitDate: Wed Nov 2 11:57:35 2022 +0100 tdf#113187 exclude angle conversion from count of maGuideList

[Libreoffice-commits] core.git: oox/inc oox/qa oox/source

2022-10-31 Thread Regina Henschel (via logerrit)
, 24 insertions(+), 1 deletion(-) New commits: commit cf972fb9856957f199eb97464b83d8dc2698 Author: Regina Henschel AuthorDate: Sun Oct 30 22:53:55 2022 +0100 Commit: Regina Henschel CommitDate: Mon Oct 31 12:20:34 2022 +0100 tdf#113187 exclude angle conversion from count

[Libreoffice-commits] core.git: sc/qa sc/source

2022-10-30 Thread Regina Henschel (via logerrit)
changed, 77 insertions(+) New commits: commit 4d15adebcc492112ca88e36aa7e8799b62d86466 Author: Regina Henschel AuthorDate: Sun Oct 30 00:35:31 2022 +0200 Commit: Regina Henschel CommitDate: Sun Oct 30 13:30:21 2022 +0100 tdf#151818 xlsx SmartArt import, apply theme text color

[Libreoffice-commits] core.git: include/oox oox/qa oox/source

2022-10-28 Thread Regina Henschel (via logerrit)
insertions(+), 1 deletion(-) New commits: commit 2406ba67c8c03b0d6a4adb81f1efc1609c8dfe8c Author: Regina Henschel AuthorDate: Fri Oct 28 15:39:38 2022 +0200 Commit: Regina Henschel CommitDate: Fri Oct 28 19:49:00 2022 +0200 tdf#54095 docx SmartArt import, apply theme text color

[Libreoffice-commits] core.git: oox/source sc/qa sc/subsequent_setup.mk

2022-10-25 Thread Regina Henschel (via logerrit)
Henschel AuthorDate: Tue Oct 25 17:37:04 2022 +0200 Commit: Regina Henschel CommitDate: Wed Oct 26 00:40:00 2022 +0200 tdf#83671 SmartArt: preserve pos and size for metafile Import of a SmartArt creates a group with a background shape and then the SmartArt shapes

Re: Unittest problem with service com.sun.star.drawing.GraphicExportFilter

2022-10-25 Thread Regina Henschel
Hi Michael, Michael Stahl schrieb am 25.10.2022 um 18:36: On 25.10.22 18:24, Regina Henschel wrote: Hi all, this is about https://gerrit.libreoffice.org/c/core/+/141830 tdf#83671 SmartArt: preserve pos and size for metafile If you try the patch, you will see, that the SmartArt is imported

Unittest problem with service com.sun.star.drawing.GraphicExportFilter

2022-10-25 Thread Regina Henschel
Hi all, this is about https://gerrit.libreoffice.org/c/core/+/141830 tdf#83671 SmartArt: preserve pos and size for metafile If you try the patch, you will see, that the SmartArt is imported in Calc as group object with one child object. The child is a

[Libreoffice-commits] core.git: include/oox oox/source sc/qa sc/source solenv/clang-format

2022-10-24 Thread Regina Henschel (via logerrit)
+ sc/source/filter/oox/drawingfragment.cxx | 22 + solenv/clang-format/excludelist|2 7 files changed, 73 insertions(+), 4 deletions(-) New commits: commit 9ad7df41572d67687221cb43d53cde27a45fff0f Author: Regina Henschel

Option "Convert SmartArt to LO shapes or reverse"

2022-10-22 Thread Regina Henschel
Hi all, Find the option "Convert SmartArt to LO shapes or reverse" in Tools > Options > Load/Save > Microsoft Office. This option is 'off' as default. The feature "convert SmartArt shapes to metafile" was introduced from Andres Gomez by commit c0e3574ce0434. It keeps the group object but

[Libreoffice-commits] core.git: oox/qa oox/source

2022-10-18 Thread Regina Henschel (via logerrit)
2969900b75e288e8c626a34277250aa233dc944c Author: Regina Henschel AuthorDate: Sat Oct 15 01:25:49 2022 +0200 Commit: Regina Henschel CommitDate: Tue Oct 18 16:22:58 2022 +0200 tdf#151518 Do not tweak text area distances in Writer The fix for tdf#148321 has introduced tweaks to the upper

Re: [Solved ] How to get value out of OOXMLFastContextHandlerShape in writerfilter?

2022-10-14 Thread Regina Henschel
Regina Henschel schrieb am 11.10.2022 um 15:05: Hi all, I need some help from you. I don't know how to get a value out of OOXMLFastContextHandlerShape. I have uploaded the files as https://gerrit.libreoffice.org/c/core/+/141223 I do not get a solution, which compiles. Solved with help from

[Libreoffice-commits] core.git: include/oox oox/source writerfilter/qa writerfilter/source

2022-10-13 Thread Regina Henschel (via logerrit)
| 38 +++ 7 files changed, 158 insertions(+), 1 deletion(-) New commits: commit e4515c1305e4b7bf6e7f105636e9cf6eb50b382d Author: Regina Henschel AuthorDate: Tue Oct 11 14:46:37 2022 +0200 Commit: Miklos Vajna CommitDate: Thu Oct 13 08:56:22 2022 +0200 tdf

Commands ".uno:RegenerateDiagram" and ".uno:EditDiagram" do not work

2022-10-12 Thread Regina Henschel
Hi all, it is about bug tdf#151499. Are the ".uno:RegenerateDiagram" and ".uno:EditDiagram" commands supposed to work? Or is someone still working on it? Kind regards, Regina

How to get value out of OOXMLFastContextHandlerShape in writerfilter?

2022-10-11 Thread Regina Henschel
Hi all, I need some help from you. I don't know how to get a value out of OOXMLFastContextHandlerShape. I have uploaded the files as https://gerrit.libreoffice.org/c/core/+/141223 I do not get a solution, which compiles. The description of the problem is in a comment in

[Libreoffice-commits] core.git: oox/qa oox/source

2022-09-19 Thread Regina Henschel (via logerrit)
/drawingml.cxx| 78 ++--- 5 files changed, 165 insertions(+), 47 deletions(-) New commits: commit 439eaa8efdd8179f93f7aaf44d25ceced6ab1665 Author: Regina Henschel AuthorDate: Sun Sep 18 14:41:32 2022 +0200 Commit: Regina Henschel CommitDate: Mon Sep 19 10

[Libreoffice-commits] core.git: sd/qa

2022-09-16 Thread Regina Henschel (via logerrit)
Henschel AuthorDate: Fri Sep 16 13:11:33 2022 +0200 Commit: Regina Henschel CommitDate: Fri Sep 16 18:05:03 2022 +0200 tdf#149551 unit test writing mode in shape in Impress Commit c70ee4a6b9071468255e5d4fdb893e9c9bdf4fad has among other things enabled, that a shape in Impress

[Libreoffice-commits] core.git: sw/qa

2022-09-15 Thread Regina Henschel (via logerrit)
sw/qa/extras/ooxmlexport/data/tdf149551_mongolianVert.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 25 + 2 files changed, 25 insertions(+) New commits: commit 7d06665b7f5e7a7d1e9ac608c3bb827003fa3cb4 Author: Regina Henschel AuthorDate: Wed Sep 14

[Libreoffice-commits] core.git: editeng/source include/editeng include/svx include/xmloff offapi/com oox/inc oox/source schema/libreoffice sc/qa sd/qa svx/source sw/qa sw/source writerfilter/source xm

2022-09-14 Thread Regina Henschel (via logerrit)
deletions(-) New commits: commit c70ee4a6b9071468255e5d4fdb893e9c9bdf4fad Author: Regina Henschel AuthorDate: Wed Aug 17 02:31:44 2022 +0200 Commit: Miklos Vajna CommitDate: Wed Sep 14 08:32:08 2022 +0200 tdf#149551 use 'WritingMode' instead of TextPreRotateAngle Commit

Implement OOXML vert attribute as WritingMode property

2022-09-05 Thread Regina Henschel
Hi all, hi Miklos, To be able to save the info about OOXML vert attribute to ODF my idea is to use interally the WritingMode property and than write that as style/loext:writing-mode to graphic-properties in ODF. That would be the same as it is now done with the text directions of frames. It

Re: Problem with reading 'writing-mode' ODF attribute in Impress

2022-08-31 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 29.08.2022 um 09:28: Problem is, that style:writing-mode="tb-lr" (OOXML vert="eaVert") and style:writing-mode="tb-lr" (OOXML vert="mongolianVert") are correctly loaded into 'WritingMode' API-attribute, but loext:writing-mode="bt-lr" (OOXML vert="vert270") and

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-6' - xmloff/qa xmloff/source

2022-08-30 Thread Regina Henschel (via logerrit)
/xmlexppr.cxx| 51 ++-- 5 files changed, 217 insertions(+), 25 deletions(-) New commits: commit 927b6e72274fa19a6a43e95a7f93901183ee1690 Author: Regina Henschel AuthorDate: Sat Aug 20 20:56:11 2022 +0200 Commit: Miklos Vajna CommitDate: Tue Aug 30 11:05:50 2022

Re: Problem with reading 'writing-mode' ODF attribute in Impress

2022-08-29 Thread Regina Henschel
Hi Miklos, I think I made some progress during the weekend. Miklos Vajna schrieb am 29.08.2022 um 09:28: Hi Regina, On Fri, Aug 26, 2022 at 10:41:06AM +0200, Regina Henschel wrote: The import side is easier, simply the property map has 2 entries and we read all enum values from both

Re: Problem with reading 'writing-mode' ODF attribute in Impress

2022-08-26 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 26.08.2022 um 08:36: Hi Regina, On Thu, Aug 25, 2022 at 11:31:24AM +0200, Regina Henschel wrote: Has someone an idea, why the import for 'loext' does not work? Or can someone point me to the place, where this part of import happens? Or can someone explain

Re: Problem with reading 'writing-mode' ODF attribute in Impress

2022-08-25 Thread Regina Henschel
Hi all, I have uploaded my tries and ideas to gerrit. https://gerrit.libreoffice.org/c/core/+/138813 Besides my problem with loading 'writing-mode' ODF attribute, other comments are welcome too. Kind regards, Regina

Problem with reading 'writing-mode' ODF attribute in Impress

2022-08-25 Thread Regina Henschel
Hi Miklos, hi all, Impress saves the 'WritingMode' API-property as 'writing-mode' ODF-attribute to the paragraph properties of the paragraph style of the shape. On loading it sets the 'WritingMode' API-property. But that does not work, if the attribute is in 'loext' namespace in file markup.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - xmloff/qa xmloff/source

2022-08-24 Thread Regina Henschel (via logerrit)
/xmlexppr.cxx| 51 ++-- 5 files changed, 217 insertions(+), 25 deletions(-) New commits: commit 89552d1652bbe026f9572325056056b449d74716 Author: Regina Henschel AuthorDate: Sat Aug 20 20:56:11 2022 +0200 Commit: Michael Stahl CommitDate: Wed Aug 24 16:28:36 2022

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - xmloff/qa xmloff/source

2022-08-23 Thread Regina Henschel (via logerrit)
/xmlexppr.cxx| 51 ++-- 5 files changed, 217 insertions(+), 25 deletions(-) New commits: commit 34edaf8249107c4216fdaffe450d287a1908a0de Author: Regina Henschel AuthorDate: Sat Aug 20 20:56:11 2022 +0200 Commit: Michael Stahl CommitDate: Tue Aug 23 12:42:44 2022

How to get table:end-pos ? (appears in change tracking)

2022-08-22 Thread Regina Henschel
Hi all, ODF 1.3 has: 19.633 table:end-position The table:end-position attribute specifies the number of the last deleted row or column. The value of a table:end-position attribute is exclusive. LibreOffice has code to load and save it

[Libreoffice-commits] core.git: xmloff/qa xmloff/source

2022-08-20 Thread Regina Henschel (via logerrit)
/xmlexppr.cxx| 51 ++-- 5 files changed, 217 insertions(+), 25 deletions(-) New commits: commit 64be7052ba7e02e24841098e07a5f4106456 Author: Regina Henschel AuthorDate: Sat Aug 20 20:56:11 2022 +0200 Commit: Regina Henschel CommitDate: Sun Aug 21 01:08:33 2022

Re: How to get text area rectangle from shape type, position, size and adjustment values?

2022-07-27 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 27.07.2022 um 11:18: Hi Regina, On Sun, Jul 24, 2022 at 11:59:28PM +0200, Regina Henschel wrote: I know that the calculation of moTextOffFoo values in transform2dcontext is correct in principle. But I am very unhappy with calculating the position and size

[Libreoffice-commits] core.git: oox/source sd/qa

2022-07-25 Thread Regina Henschel (via logerrit)
files changed, 129 insertions(+), 17 deletions(-) New commits: commit 5df1bb4b1b222be00d25097660c4ee33542896ea Author: Regina Henschel AuthorDate: Sun Jul 24 01:23:32 2022 +0200 Commit: Regina Henschel CommitDate: Mon Jul 25 23:07:28 2022 +0200 tdf#135953 move txXfrm to compensate

How to get text area rectangle from shape type, position, size and adjustment values?

2022-07-24 Thread Regina Henschel
Hi all, I know that the calculation of moTextOffFoo values in transform2dcontext is correct in principle. But I am very unhappy with calculating the position and size of the required text area rectangle by hand using the preset geometry. I have now done this for the shape types that I know

[Libreoffice-commits] core.git: oox/qa oox/source

2022-07-23 Thread Regina Henschel (via logerrit)
3ade0a5fb1d39360b76c7d62eebee5a18d3f4196 Author: Regina Henschel AuthorDate: Fri Jul 22 17:54:02 2022 +0200 Commit: Regina Henschel CommitDate: Sat Jul 23 14:33:13 2022 +0200 tdf#149538 no text area rotation if upright exported This is a followup to commit 7e23cbdb. With that commit the attribute

Re: Import of short values of textDirection, used by OOXML strict

2022-07-22 Thread Regina Henschel
Hi Miklos, thank you. writerfilter/documentation/ooxml/model.rng makes indeed the relationships clearer. I have added a link to your mail to the bug report. Kind regards, Regina Miklos Vajna schrieb am 22.07.2022 um 08:27: Hi Regina, On Thu, Jul 21, 2022 at 08:47:14PM +0200, Regina

Import of short values of textDirection, used by OOXML strict

2022-07-21 Thread Regina Henschel
Hi Miklos, hi all, I can fix bug 149556 by adding the missing values to in core/writerfilter/source/ooxml/model.xml. Is that really all to do? Or do I miss something? If that is really all, it would be an Easyhack. The issue is about the fact, that a short value 'lr' instead of the long

[Libreoffice-commits] core.git: oox/source sd/qa

2022-07-21 Thread Regina Henschel (via logerrit)
c6965c5bcc95430c2a2d01051791d23f2c2f5a5b Author: Regina Henschel AuthorDate: Thu Jul 21 10:51:47 2022 +0200 Commit: Regina Henschel CommitDate: Thu Jul 21 12:41:01 2022 +0200 tdf#145528 add round1Rect to SmartArt text area corrections Some SmartArt types use text area rectangles different from defaults

[Libreoffice-commits] core.git: sd/qa

2022-07-20 Thread Regina Henschel (via logerrit)
| 106 +++ 5 files changed, 106 insertions(+) New commits: commit 2f3b87d18a688b022a18a8b20b69b10cd6af7748 Author: Regina Henschel AuthorDate: Wed Jul 20 13:16:04 2022 +0200 Commit: Regina Henschel CommitDate: Wed Jul 20 20:48:22 2022 +0200 tdf#149551 Unit tests

[Libreoffice-commits] core.git: include/svx oox/inc oox/qa oox/source sc/qa sd/qa sw/qa

2022-07-20 Thread Regina Henschel (via logerrit)
|2 24 files changed, 528 insertions(+), 177 deletions(-) New commits: commit 7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0 Author: Regina Henschel AuthorDate: Sat Jun 25 00:07:43 2022 +0200 Commit: Miklos Vajna CommitDate: Wed Jul 20 08:16:03 2022 +0200 tdf#149551 separate

Re: Review for tdf#149551 separate TextRotateAngle from TextPreRotateAngle

2022-07-18 Thread Regina Henschel
Regina Henschel schrieb am 18.07.2022 um 15:29: Hi all, the patch is now in a state, that a review would be good. The patch is in https://gerrit.libreoffice.org/c/core/+/136447 Kind regards, Regina

Review for tdf#149551 separate TextRotateAngle from TextPreRotateAngle

2022-07-18 Thread Regina Henschel
Hi all, the patch is now in a state, that a review would be good. The patch does not only include the separation of the two angles but also improvements for the calculation of insets as they are affected by rotation too. It should work fine for Impress. The visual appearance of an exported

Re: Problems in Writer with rotated text in shapes

2022-07-17 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 14.07.2022 um 16:38: Hi Regina, On Thu, Jul 07, 2022 at 01:00:03AM +0200, Regina Henschel wrote: (1) I have turned off creating a textbox associated with the shape for some cases, so I can see what happens on import. (Text rotations are still missing here

suspicious member 'mnDiagramRotation' in class Shape in oox

2022-07-16 Thread Regina Henschel
Hi all, The class Shape has a member 'mnDiagramRotation' (#376), which can be set by setDiagramRotation() (#164) https://opengrok.libreoffice.org/xref/core/include/oox/drawingml/shape.hxx It has a comment // rotates shape prior to sizing, does not affect text rotation It is set in

Re: Update of extended ODF schema

2022-07-08 Thread Regina Henschel
Hi Laurent, Laurent Balland schrieb am 08.07.2022 um 17:36: Thank you Regina for your advise. I will try it this week-end, or do without modifying v1.3+libreoffice-schema as you suggested. But from my point of view, the v1.3-schema contains an error, as the OASIS text is the core rule,

Re: Update of extended ODF schema

2022-07-08 Thread Regina Henschel
Hi Laurent, Laurent Balland schrieb am 08.07.2022 um 09:52: Hello, I'm trying to extend number format in Calc to get embedded text in decimal part [1]. ODF1.3 requires only positive position to have embedded text in integer part. I need to modify

Re: Update of extended ODF schema

2022-07-08 Thread Regina Henschel
Hi Laurent, Laurent Balland schrieb am 08.07.2022 um 13:52: Hi Regina, Actually, ODF1.3 specifies only strictly positive number: "The index of a position starts with 1" [1] and Eike asked for a loext:position attribute if negative or null position. [2] The text says "starts with 1" but the

Re: Update of extended ODF schema

2022-07-08 Thread Regina Henschel
Hi Laurent, I do not understand your problem. The schema allows already negative values in attribute number:position. 'integer' includes negative values. Could you please give an example of a number, which uses the desired number format? Kind regards, Regina

Problems in Writer with rotated text in shapes

2022-07-06 Thread Regina Henschel
Hi all, I am still working on tdf#149551 separate TextRotateAngle from TextPreRotateAngle https://gerrit.libreoffice.org/c/core/+/136447 PPTX import and export are now basically OK, but DOCX does not work at all. I have some questions about this: (1) I have turned off creating a textbox

Re: How to write OOXML attribute 'vert' of element to ODF?

2022-06-20 Thread Regina Henschel
Hi all, Regina Henschel schrieb am 20.06.2022 um 01:05: However, another option would be to enable the text in shapes to use WritingMode2 and extend its values similar to the current loext:writing-mode="bt-lr". This looks better to me for future development. Only I certainly

Re: How to write OOXML attribute 'vert' of element to ODF?

2022-06-19 Thread Regina Henschel
Hi Mark, Mark Hung schrieb am 19.06.2022 um 03:04: [..] I found that I was confused with the name "loext:text-direction", and connected it to writing-mode. > In different context direction may mean writing direction in Bidi text, as in [1]. You are right, the name is indeed misleading,

Re: How to write OOXML attribute 'vert' of element to ODF?

2022-06-17 Thread Regina Henschel
Hi Mark, Mark Hung schrieb am 17.06.2022 um 17:17: Hi Regina, Regina Henschel <mailto:rb.hensc...@t-online.de>> 於 2022年6月16日 週四 晚上8:49寫道: Hi all, Currently the "vert" attribute of element is connected to TextPreRotateAngle property. vert="vert" pr

How to write OOXML attribute 'vert' of element to ODF?

2022-06-16 Thread Regina Henschel
Hi all, Currently the "vert" attribute of element is connected to TextPreRotateAngle property. vert="vert" produces TextPreRotateAngle=-90 and vert="vert270" produces TextPreRotateAngle=-270. When converting it to ODF it produces draw:text-rotate-angle="-90" and

[Libreoffice-commits] core.git: xmloff/qa xmloff/source

2022-06-15 Thread Regina Henschel (via logerrit)
aca189d118d4351b293c089cb26584eb898e1849 Author: Regina Henschel AuthorDate: Wed Jun 15 13:15:15 2022 +0200 Commit: Regina Henschel CommitDate: Thu Jun 16 00:57:51 2022 +0200 tdf#149551 write draw:text-rotate-angle only once The attributes 'vert' and 'vert270' set property TextPreRotateAngle

Custom Shape Orientation Guide

2022-06-08 Thread Regina Henschel
Hi all, I have been working with custom shapes for quite a while now. Again and again the questions come up "How is the property actually defined in the file format?", "How is the property realized in core?" or "Where is the property set or converted in core?". I have now tried to collect

[Libreoffice-commits] core.git: svx/qa svx/source

2022-05-05 Thread Regina Henschel (via logerrit)
124382eba6aaeb475b4077920c082bf5c51ac029 Author: Regina Henschel AuthorDate: Thu May 5 17:31:39 2022 +0200 Commit: Regina Henschel CommitDate: Thu May 5 21:27:15 2022 +0200 tdf#148707 implicit moveTo on all not only on first The current solution checks implicit moveTo only

Re: Trouble with curved*Arrow shapes

2022-05-04 Thread Regina Henschel
Regina, sorry i was too distracted to notice your mail last week... On 04.05.22 08:29, Miklos Vajna wrote: On Wed, Apr 27, 2022 at 02:10:14PM +0200, Regina Henschel wrote: A different approach could be to not care about existing documents in the code. Perhaps provide a macro to repair a shape

[Libreoffice-commits] core.git: xmloff/qa xmloff/source

2022-05-03 Thread Regina Henschel (via logerrit)
8ad4fdb1687e705e31d9a4f30b385d50b91def08 Author: Regina Henschel AuthorDate: Tue May 3 00:18:00 2022 +0200 Commit: Regina Henschel CommitDate: Tue May 3 18:54:49 2022 +0200 tdf#148714 Repair path in older CurvedArrow shapes The CurvedArrow shapes had an error in their enhanced-path. The error

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - svx/qa svx/source

2022-05-02 Thread Regina Henschel (via logerrit)
fdf4390415a6956144d055a32579105deaef913a Author: Regina Henschel AuthorDate: Thu Apr 28 23:35:44 2022 +0200 Commit: Xisco Fauli CommitDate: Mon May 2 15:56:25 2022 +0200 tdf#148714 connect first and second arc with arcTo The curved*Arrows start with two arcs, which should be connected

[Libreoffice-commits] core.git: svx/qa svx/source

2022-04-28 Thread Regina Henschel (via logerrit)
4cfe46997eab3498cc519ef94c85ad2d644d3886 Author: Regina Henschel AuthorDate: Thu Apr 28 23:35:44 2022 +0200 Commit: Regina Henschel CommitDate: Fri Apr 29 07:27:48 2022 +0200 tdf#148714 connect first and second arc with arcTo The curved*Arrows start with two arcs, which should

[Libreoffice-commits] core.git: include/oox oox/qa oox/source

2022-04-27 Thread Regina Henschel (via logerrit)
oox/source/export/drawingml.cxx | 108 +++--- 6 files changed, 188 insertions(+), 39 deletions(-) New commits: commit 0818a3dcaf6d7962d043829d42a3bb9d998393d4 Author: Regina Henschel AuthorDate: Tue Apr 26 23:48:21 2022 +0200 Commit: Regina

Trouble with curved*Arrow shapes

2022-04-27 Thread Regina Henschel
Hi all, LibreOffice renders a sequence of command V or of command B not conform to ODF (bug 148707). LO connects the first and second arc (and second and third and so on) with a line, but V and B are defined to start with a moveTo. When I fix that, it becomes visible, that the segments

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - include/svx oox/qa oox/source

2022-04-26 Thread Regina Henschel (via logerrit)
(-) New commits: commit 02c59c79f30705450224fdb6eb3b001da457f81e Author: Regina Henschel AuthorDate: Wed Apr 20 18:16:50 2022 +0200 Commit: Xisco Fauli CommitDate: Tue Apr 26 21:13:28 2022 +0200 tdf#109169 export Type encoded shading to OOXML A shape might have the shading

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - svx/qa svx/source

2022-04-26 Thread Regina Henschel (via logerrit)
a9d8f86488dcd44bef4d6f8cee1d6c803f237f9c Author: Regina Henschel AuthorDate: Mon Apr 18 19:31:26 2022 +0200 Commit: Xisco Fauli CommitDate: Tue Apr 26 21:13:09 2022 +0200 tdf#148501 color shades only for filled PolyPolygons For shading parts of a shape not of Type 'ooxml-*', ColorData is used

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - oox/qa oox/source

2022-04-25 Thread Regina Henschel (via logerrit)
Author: Regina Henschel AuthorDate: Sat Apr 23 21:52:29 2022 +0200 Commit: Xisco Fauli CommitDate: Tue Apr 26 00:01:49 2022 +0200 Do not start a:path with lnTo in export to OOXML This is a follow up to commit 2029b2f6dd0109c5892e5ac5640022b31fe42fd2 The commands A, W

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - include/oox oox/source

2022-04-25 Thread Regina Henschel (via logerrit)
include/oox/export/drawingml.hxx |5 oox/source/export/drawingml.cxx | 650 ++- 2 files changed, 309 insertions(+), 346 deletions(-) New commits: commit f2458bab5d67a988feb9ba72d70e0649a979fcb1 Author: Regina Henschel AuthorDate: Mon Apr 25 11:09

[Libreoffice-commits] core.git: oox/qa oox/source

2022-04-24 Thread Regina Henschel (via logerrit)
Author: Regina Henschel AuthorDate: Sat Apr 23 21:52:29 2022 +0200 Commit: Regina Henschel CommitDate: Sun Apr 24 13:37:54 2022 +0200 Do not start a:path with lnTo in export to OOXML This is a follow up to commit 2029b2f6dd0109c5892e5ac5640022b31fe42fd2 The commands

Re: How to export 'Octagon Bevel' and 'Diamond Bevel' to OOXML

2022-04-21 Thread Regina Henschel
Hi Miklos, Hi Miklos, Miklos Vajna schrieb am 21.04.2022 um 16:31: Hi Regina, On Tue, Apr 19, 2022 at 01:32:23AM +0200, Regina Henschel wrote: The appearance we currently get (without any patch) cannot be exported to OOXML, if we want, that it remains to be a shape. And when reopening

[Libreoffice-commits] core.git: include/svx oox/qa oox/source

2022-04-21 Thread Regina Henschel (via logerrit)
(-) New commits: commit 5168d06b1302c43a305d0f670ee65079f21063b5 Author: Regina Henschel AuthorDate: Wed Apr 20 18:16:50 2022 +0200 Commit: Regina Henschel CommitDate: Thu Apr 21 12:53:41 2022 +0200 tdf#109169 export Type encoded shading to OOXML A shape might have the shading

[Libreoffice-commits] core.git: svx/qa svx/source

2022-04-20 Thread Regina Henschel (via logerrit)
d5fb8d502e77c1dfc77b2c7bdda4bb1540f3ddaf Author: Regina Henschel AuthorDate: Mon Apr 18 19:31:26 2022 +0200 Commit: Miklos Vajna CommitDate: Wed Apr 20 11:05:16 2022 +0200 tdf#148501 color shades only for filled PolyPolygons For shading parts of a shape not of Type 'ooxml-*', ColorData is used

Re: How to export 'Octagon Bevel' and 'Diamond Bevel' to OOXML

2022-04-18 Thread Regina Henschel
sary. Miklos Vajna schrieb am 13.04.2022 um 08:41: Hi Regina, On Tue, Apr 12, 2022 at 02:08:47PM +0200, Regina Henschel wrote: I have created a similar shape in OOXML including handle and guides, see attachment. The handle is correct in PowerPoint, but our import of doesn't get the handle c

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - oox/source sd/qa

2022-04-18 Thread Regina Henschel (via logerrit)
commits: commit b51e9f32410d346a9b5cba1bf3e6a485e17f119d Author: Regina Henschel AuthorDate: Fri Apr 15 15:04:16 2022 +0200 Commit: Xisco Fauli CommitDate: Mon Apr 18 13:28:09 2022 +0200 tdf#109169 use custGeom for Octagon Bevel shape The shapes 'Octagon Bevel', type col_60da8460

Re: GSOC 2022 application

2022-04-17 Thread Regina Henschel
Hi Rupesh, we appreciate that you want to work on the further development of LibreOffice. For participation in GSOC we expect that you have submitted a so-called "easyhack" to become familiar with the build process. I do not find an "easyhack" from you. Do you have submitted it with a

[Libreoffice-commits] core.git: oox/source sd/qa

2022-04-15 Thread Regina Henschel (via logerrit)
commits: commit b195cf4db4c21da3cf754689fb22f0b6a904a03e Author: Regina Henschel AuthorDate: Fri Apr 15 15:04:16 2022 +0200 Commit: Regina Henschel CommitDate: Fri Apr 15 22:16:40 2022 +0200 tdf#109169 use custGeom for Octagon Bevel shape The shapes 'Octagon Bevel', type

Re: How to export 'Octagon Bevel' and 'Diamond Bevel' to OOXML

2022-04-12 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 11.04.2022 um 08:27: Hi Regina, On Sun, Apr 10, 2022 at 12:55:42AM +0200, Regina Henschel wrote: Because there exist no suitable OOXML preset shape, we need to export them with . I could make dedicated 'Write_Octagon_Bevel' and 'Write_Diamond_Bevel

How to export 'Octagon Bevel' and 'Diamond Bevel' to OOXML

2022-04-09 Thread Regina Henschel
Hi all, Currently 'Octagon Bevel' and 'Diamond Bevel' are exported as shape 'rect'. That is bug tdf#109169. Both shape types do not exist in MS binary, therefore export to MS binary exports them as image. Because a user cannot change color or text after reopening, I think we should not do

Re: "forcepoint" ?

2022-04-08 Thread Regina Henschel
Hi Caolán, Caolán McNamara schrieb am 08.04.2022 um 15:30: On Fri, 2022-04-08 at 14:40 +0200, Regina Henschel wrote: Hi all, There are a lot of commits with "forcepoint" in subject. Is there somewhere a description about that "forcepoint" work? It's a set of documents

"forcepoint" ?

2022-04-08 Thread Regina Henschel
Hi all, There are a lot of commits with "forcepoint" in subject. Is there somewhere a description about that "forcepoint" work? Kind regards, Regina

[Libreoffice-commits] core.git: oox/qa oox/source

2022-04-04 Thread Regina Henschel (via logerrit)
1ad58c77352e418124387b804b18da2aeea22c8b Author: Regina Henschel AuthorDate: Mon Apr 4 01:55:29 2022 +0200 Commit: Regina Henschel CommitDate: Mon Apr 4 20:21:14 2022 +0200 tdf#100391 calculate true textarea rect for custGeom Without the fix the attributes for were set to 'l', 't', 'r' and 'b

[Libreoffice-commits] core.git: include/oox oox/source

2022-03-30 Thread Regina Henschel (via logerrit)
include/oox/export/drawingml.hxx |5 oox/source/export/drawingml.cxx | 650 ++- 2 files changed, 309 insertions(+), 346 deletions(-) New commits: commit 365a3ed39083389f40612dec765d7b8e0dc2377b Author: Regina Henschel AuthorDate: Tue Mar 29 16:23

<    1   2   3   4   5   6   7   8   9   10   >