Re: Import of 3D-Image from pptx
Hi Regina, On Sat, Mar 23, 2024 at 03:02:31PM +0100, Regina Henschel wrote: > I plan to meet Armin in Hamburg end of April. Are you interested in joining > the discussion? I'm happy to leave it to Armin, initially I jumped him here because I think the improvements you do are valuable and I saw no feedback from others. :-) Regards, Miklos
Re: Import of 3D-Image from pptx
Hi Miklos, sorry for not answering, but I haven't got your mail. Only Mike notified me just, that there is an answer from you. I have read your mail now from the archive. I think in both cases the ideal would be to extend SdrGrafObj, to support cropping and 3D properties if PPTX supports that. Of course, it's good to share code with SdrObjCustomShape in the implementation if possible. If that's not possible (takes too much time, too complex), then it's an option to map the images to custom shapes in our side, but sooner or later these workarounds cause some problems. So at least some TODO / FIXME comment would be nice, if you go this way. I have used a minimal solution for now that only extends the already existing way of representing a "crop to shape" image by a custom shape. That does not prevent to map images to custom shapes in case such workaround is wanted. Currently I work on adapting the export. This has priority. I want to keep the current behavior for version 24.8, that the 3D-scene is recreated on export in case of round-trip, that means in case there is a InteropGrabBag. It would be a large change to extend SdrGrafObj with 3D-abilities. I think, that we first need a general plan about what we need to do and in what order, to bring LO nearer to the 3D features of MS Office. The rendering of extruded custom shape as 3D uses a temporary 3D-Scene. But that lacks so much, that I do not like to implement a similar solution for SdrGrafObj, especially as the standard would also need to be extended. I think the latter should only be done, when we have already defined the final goal. I plan to meet Armin in Hamburg end of April. Are you interested in joining the discussion? Kind regards, Regina
Re: Import of 3D-Image from pptx
Hi all, as no one has an opinion on this topic, I have now decided to continue to import a 3D image, which is not cropped to a shape, as pure image. https://gerrit.libreoffice.org/c/core/+/165194 For further improvements in 3D import we first need a general plan, because deeper changes in code are needed. Kind regards, Regina Regina Henschel schrieb am 21.03.2024 um 23:41: Hi all, at the moment, a 3D image is imported as an image and displayed in Impress without 3D. The 3D properties are in the InteropGrabBag and are written out again on export, in addition to a rotation or mirroring that the user has made with the image in LO. The 3D image could be treated in the same way as an image that has been cropped to a shape in PowerPoint. Such an image is imported as a custom shape with bitmap filling. Such a custom shape can then be displayed in 3D mode. When saving, however, as with the cropped image, the result would not be a pure image but a shape with a bitmap fill. What do you think? Should I implement this or should I continue to import a 3D image as a pure image? Kind regards, Regina
Re: Import of 3D-Image from pptx
Hi Regina, On Thu, Mar 21, 2024 at 11:41:07PM +0100, Regina Henschel wrote: > at the moment, a 3D image is imported as an image and displayed in Impress > without 3D. The 3D properties are in the InteropGrabBag and are written out > again on export, in addition to a rotation or mirroring that the user has > made with the image in LO. > > The 3D image could be treated in the same way as an image that has been > cropped to a shape in PowerPoint. Such an image is imported as a custom > shape with bitmap filling. Such a custom shape can then be displayed in 3D > mode. When saving, however, as with the cropped image, the result would not > be a pure image but a shape with a bitmap fill. > > What do you think? Should I implement this or should I continue to import a > 3D image as a pure image? I think in both cases the ideal would be to extend SdrGrafObj, to support cropping and 3D properties if PPTX supports that. Of course, it's good to share code with SdrObjCustomShape in the implementation if possible. If that's not possible (takes too much time, too complex), then it's an option to map the images to custom shapes in our side, but sooner or later these workarounds cause some problems. So at least some TODO / FIXME comment would be nice, if you go this way. Thanks, Miklos
Import of 3D-Image from pptx
Hi all, at the moment, a 3D image is imported as an image and displayed in Impress without 3D. The 3D properties are in the InteropGrabBag and are written out again on export, in addition to a rotation or mirroring that the user has made with the image in LO. The 3D image could be treated in the same way as an image that has been cropped to a shape in PowerPoint. Such an image is imported as a custom shape with bitmap filling. Such a custom shape can then be displayed in 3D mode. When saving, however, as with the cropped image, the result would not be a pure image but a shape with a bitmap fill. What do you think? Should I implement this or should I continue to import a 3D image as a pure image? Kind regards, Regina
