Re: Can someone review a patch to fix the audio in PPTX?

Hi Vladislav, On Tue, Mar 12, 2024 at 03:08:23PM +0300, Владислав Тараканов wrote: > irgalie...@mail.ru and I recently sent a patch that adds launching media > files in presentation mode from the presentation directory if they were not > found in the absolute path. At the moment

Can someone review a patch to fix the audio in PPTX?

Hello. irgalie...@mail.ru and I recently sent a patch that adds launching media files in presentation mode from the presentation directory if they were not found in the absolute path. At the moment, we have implemented functionality only for GStreamer. Before adding implementations

Re: Missing Patch Inside LibreOffice Core Branch Master

Hi Andreas, On Wed, Dec 27, 2023 at 02:50:58PM +0100, Andreas Mantke wrote: > I found out again that at least one patch didn't make it to the > LibreOffice core repository, branch master: > https://gerrit.libreoffice.org/c/core/+/160022 > > I hope this is a lapse again and i

Missing Patch Inside LibreOffice Core Branch Master

Hi all, I found out again that at least one patch didn't make it to the LibreOffice core repository, branch master: https://gerrit.libreoffice.org/c/core/+/160022 I hope this is a lapse again and it would be good to have this patch in the LibreOffice core master tree too. It's currently only

[Libreoffice-bugs] [Bug 66826] patch 2.7 / line-ending issue

https://bugs.documentfoundation.org/show_bug.cgi?id=66826 --- Comment #8 from Mike Kaganski --- This shows, that I followed the correct path when needed to build a 4.0 version now :-) -- You are receiving this mail because: You are the assignee for the bug.

Re: Missing Patch Inside LibreOffice Core Master Branch

Hi Andreas, On Thu, Aug 10, 2023 at 09:05:06PM +0200, Andreas Mantke wrote: > I looked on the LibreOffice Gerrit and found out that a patch of the > LibreOffice kit has not been committed to the LibreOffice master branch: > https://gerrit.libreoffice.org/c/core/+/155282 > > I

Missing Patch Inside LibreOffice Core Master Branch

Hi all, I looked on the LibreOffice Gerrit and found out that a patch of the LibreOffice kit has not been committed to the LibreOffice master branch: https://gerrit.libreoffice.org/c/core/+/155282 I think it would only a lapse that it didn't make it only in branch but not into the master

Patch in Gerrit to bring Spanish dictionaries up to current version 2.7

Hi, I don't know whether it is needed or not to announce it here, but, just in case, I've just committed this changeset to Gerrit to update shipped Spanish spellcheck dictionaries to our current version 2.7: https://gerrit.libreoffice.org/c/dictionaries/+/145025 Thanks in advance, and Happy New

[RESOLVED] Re: Error when trying to submit patch on gerrit (No space left on device)

On 03/09/2022 09:12, Julien Nabet wrote: Hello, This morning when trying to submit a patch, I got: no branch specified, guessing current branch master Enumerating objects: 11, done. Counting objects: 100% (11/11), done. Delta compression using up to 12 threads Compressing objects: 100% (6/6

Error when trying to submit patch on gerrit (No space left on device)

Hello, This morning when trying to submit a patch, I got: no branch specified, guessing current branch master Enumerating objects: 11, done. Counting objects: 100% (11/11), done. Delta compression using up to 12 threads Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 622

Re: Improve WriteCustomGeometry in oox export; review of patch

Hi Regina, On Thu, Mar 24, 2022 at 07:33:24PM +0100, Regina Henschel wrote: > The commit message is quite detailed. If something is still unclear, please > send me a mail. Not only that, but the various test files you added in the tests also helped to understand the problem you solve. Thanks

Improve WriteCustomGeometry in oox export; review of patch

Hi Miklos, hi all, the patch in https://gerrit.libreoffice.org/c/core/+/131837 is now ready for review. It is a change in the way a custGeom element is generated. I have dropped the export via PolyPolygon. Instead our path commands are directly mapped to oox path commands. That is a larger

Re: submit a revised patch to an abandoned gerrit change

submit a new patch and refer to the abandoned one (I have no need for elevated permissions). Winfried I think the issue will be, however, that the authorship information will have been diluted. I guess if you note in the commit message who the original author was and that you adapted

Re: submit a revised patch to an abandoned gerrit change

> On 13 Jan 2022, at 12:11 am, Winfried Donkers > wrote: > >  >> >>> I have the same menu, but just next to the menu button (the vertical ...), >>> on the left side, there is also a RESTORE button. >>> >> Might only work for own patches.

Re: submit a revised patch to an abandoned gerrit change

I have the same menu, but just next to the menu button (the vertical ...), on the left side, there is also a RESTORE button. Might only work for own patches. OK, thanks all, I'll simply submit a new patch and refer to the abandoned one (I have no need for elevated permissions). Winfried

Re: submit a revised patch to an abandoned gerrit change

Jan-Marek Glogowski wrote: > I have the same menu, but just next to the menu button (the vertical ...), > on the left side, there is also a RESTORE button. > Might only work for own patches. Cheers, -- Thorsten signature.asc Description: PGP signature

Re: submit a revised patch to an abandoned gerrit change

On 12.01.22 08:56, Jan-Marek Glogowski wrote: On 12.01.22 07:22, Winfried Donkers wrote: Is it possible to reopen an abandoned gerrit change when you're not the original contributor? I see a restore button for every abandoned patch. But why not simply try? I can't see any restore button

Re: submit a revised patch to an abandoned gerrit change

On 12.01.22 07:22, Winfried Donkers wrote: Is it possible to reopen an abandoned gerrit change when you're not the original contributor? I see a restore button for every abandoned patch. But why not simply try? I can't see any restore button; in menu I see Cherry pick, Download patch

Re: submit a revised patch to an abandoned gerrit change

Is it possible to reopen an abandoned gerrit change when you're not the original contributor? I see a restore button for every abandoned patch. But why not simply try? I can't see any restore button; in menu I see Cherry pick, Download patch and Ignore. Winfried

Re: submit a revised patch to an abandoned gerrit change

On 11.01.22 16:16, Winfried Donkers wrote: Is it possible to reopen an abandoned gerrit change when you're not the original contributor? I see a restore button for every abandoned patch. But why not simply try?

submit a revised patch to an abandoned gerrit change

with the (still unresolved) bug report. I made changes to the patch and would like to submit 'my' patch to the same gerrit change with me and the original contributor as co-authors. However, gerrit won't accept the patch I submitted because the status of the change is 'abandoned'. I can submit as a new

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

https://bugs.documentfoundation.org/show_bug.cgi?id=146485 Collabora Productivity Ltd changed: What|Removed |Added Status|NEW |RESOLVED

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

o no objections - as long as you're happy linguistically =) > > Thanks Olivier ! No pb! Andras: thought you might be interested in this one as dictionaries expert. (I would have submitted the patch if I had remembered the mechanism of gerrit submitting for a submodule) -- You are receiv

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

https://bugs.documentfoundation.org/show_bug.cgi?id=146485 --- Comment #5 from Michael Meeks --- Thanks for checking Julien - as Olivier said - dictionaries are something of a special-case license wise: much as it would be a good idea to re-base on the LaTeX MIT base here and have a clearer

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

https://bugs.documentfoundation.org/show_bug.cgi?id=146485 --- Comment #4 from Olivier R. --- If you dig into the dictionaries repository, you’ll find other resources that are licensed only with GPL or LGPL. DE - dictionary: GPL - hyphenation: LGPL - thesaurus: LGPL ES - thesaurus: LGPL IT -

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

||, serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- I don't know if license of the patch (it seems GNU LGPL just reading the patch) is fully compatible with the requirements indicated in https://wiki.documentfoundation.org/Development/GetInvolved

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

|1 Keywords||patch --- Comment #2 from sophie --- Thanks Olivier for your patch and your work :) -- You are receiving this mail because: You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146485] [PATCH] Update for French hyphenation rules

--- Comment #1 from Olivier R. --- Created attachment 177209 --> https://bugs.documentfoundation.org/attachment.cgi?id=177209=edit Patch to update the French hyphenation rules -- You are receiving this mail because: You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146485] New: [PATCH] Update for French hyphenation rules

https://bugs.documentfoundation.org/show_bug.cgi?id=146485 Bug ID: 146485 Summary: [PATCH] Update for French hyphenation rules Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED

Re: Need help with patch for Fontwork shape

Hi Miklos, thank you for starting a next try to build. The build was now successful. Kind regards Regina Regina Henschel schrieb am 12.10.2021 um 17:00: Hi all, I need help with patch https://gerrit.libreoffice.org/c/core/+/123295 It passes Jenkins in Patchset 3. The only change

Need help with patch for Fontwork shape

Hi all, I need help with patch https://gerrit.libreoffice.org/c/core/+/123295 It passes Jenkins in Patchset 3. The only change was then a change in the commit message. But now it fails with always the same problem. I know Jenkins has a "hiccup" sometimes and tried a Rebase. B

Re: cppunit Patch feature-modernize

t 1.15.1 to modernize and use clang flags > with highest flag settings. Hopefully you can integrate this patch > inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize > <https://github.com/VXAPPS/cppunit/tree/feature-modernize> > > If you have suggestions, p

Re: cppunit Patch feature-modernize

9 PM Florian Becker > <mailto:f...@vxapps.com>> wrote: >> Hello, >> >> i have patched the libcppunit 1.15.1 to modernize and use clang flags >> with highest flag settings. Hopefully you can integrate this patch >> inside master. https://github.com/VXAPPS/c

Re: cppunit Patch feature-modernize

ard < > markus.mohrh...@googlemail.com> wrote: > >> Hey Florian, >> >> On Tue, Sep 28, 2021 at 5:59 PM Florian Becker wrote: >> >>> Hello, >>> >>> i have patched the libcppunit 1.15.1 to modernize and use clang flags >>> with hi

Re: cppunit Patch feature-modernize

dernize and use clang flags >>> with highest flag settings. Hopefully you can integrate this patch >>> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize >>> >>> If you have suggestions, please let me know. >> >> I'll h

Re: cppunit Patch feature-modernize

flags >> with highest flag settings. Hopefully you can integrate this patch >> inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize >> >> If you have suggestions, please let me know. >> > > I'll have a look during the next few days and will let y

Re: cppunit Patch feature-modernize

Hey Florian, On Tue, Sep 28, 2021 at 5:59 PM Florian Becker wrote: > Hello, > > i have patched the libcppunit 1.15.1 to modernize and use clang flags > with highest flag settings. Hopefully you can integrate this patch > inside master. https://github.com/VXAPPS/cppunit/tree/fe

Re: cppunit Patch feature-modernize

Hi Florian, On Mon, Sep 27, 2021 at 05:27:56PM +, Florian Becker wrote: > i have patched the libcppunit 1.15.1 to modernize and use clang flags > with highest flag settings. Hopefully you can integrate this patch > inside master. https://github.com/VXAPPS/cppunit/tree/feature-

cppunit Patch feature-modernize

Hello, i have patched the libcppunit 1.15.1 to modernize and use clang flags with highest flag settings. Hopefully you can integrate this patch inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize If you have suggestions, please let me know. Regards, Florian

Code Reviewer needed to review patch

I need a code reviewer for a patch I submitted to gerrit for bug tdf#104169 <https://bugs.documentfoundation.org/show_bug.cgi?id=104169>. Patch : https://gerrit.libreoffice.org/c/core/+/114679 Bug : https://bugs.documentfoundation.org/show_bug.cgi?id=104169 The bug is a difficultyInter

Re: proposition for patch in CommonSalLayout.cxx

Stanisław Jeśmanowicz wrote >> > This is not always the case, because if a platform didn't include > graphite2 shaper in its HarfBuzz > implementaion, you won't have it anyway ( like ./configure > --with-graphite2=no ) > Even if you set it the shapers list (as in >

Re: proposition for patch in CommonSalLayout.cxx

Stanisław Jeśmanowicz wrote > ... > Thank you for your advice, but getting familiar with gerrit on top of git > would take some time for > me now. > I hope, that some of your developers could commit this patch for me in vcl > module. > It is simple and won't harm anythin

Re: proposition for patch in CommonSalLayout.cxx

On 9.3.2021 20.51, Stanisław Jeśmanowicz wrote: On 3/9/21 6:34 PM, julien2412 wrote: Stanisław Jeśmanowicz wrote ... Thank you for your advice, but getting familiar with gerrit on top of git would take some time for me now. I hope, that some of your developers could commit this patch for me

Re: proposition for patch in CommonSalLayout.cxx

On 3/9/21 6:34 PM, julien2412 wrote: Stanisław Jeśmanowicz wrote ... Thank you for your advice, but getting familiar with gerrit on top of git would take some time for me now. I hope, that some of your developers could commit this patch for me in vcl module. It is simple and won't harm

Re: proposition for patch in CommonSalLayout.cxx

Hello Julien, On 3/9/21 9:18 AM, julien2412 wrote: Hello, In addition to what Miklos indicated, I think you may be interested in https://wiki.documentfoundation.org/Development/GetInvolved. Indeed, it seems you've already downloaded sources, built and tried to fix a problem with a patch. So

Re: proposition for patch in CommonSalLayout.cxx

Hello Miklos, On 3/9/21 9:14 AM, Miklos Vajna wrote: Hi Stan, On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz wrote: Dear all, I noticed that LibreOffice is using the hard coded harfbuzz shapers list in CommonSalLayout.cxx file (line 470). I recommend the patch attached

Re: proposition for patch in CommonSalLayout.cxx

Hello, In addition to what Miklos indicated, I think you may be interested in https://wiki.documentfoundation.org/Development/GetInvolved. Indeed, it seems you've already downloaded sources, built and tried to fix a problem with a patch. So you only need now a gerrit account and submit your

Re: proposition for patch in CommonSalLayout.cxx

Hi Stan, On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz wrote: > Dear all, > > I noticed that LibreOffice is using the hard coded harfbuzz shapers list in > CommonSalLayout.cxx file (line 470). > I recommend the patch attached to be more flexible. > This

proposition for patch in CommonSalLayout.cxx

Dear all, I noticed that LibreOffice is using the hard coded harfbuzz shapers list in CommonSalLayout.cxx file (line 470). I recommend the patch attached to be more flexible. This take all possible shapers in a given HarfBuzz implementation. This also allows the use of newly created shapers

Patch: fix unpack-sources to not require GNU find

Requesting review. Patch submitted here a few months ago: https://gerrit.libreoffice.org/c/core/+/107936 The find that comes with macOS is BSD find and does not have -printf. On macOS: $ man /usr/share/man/man1/find.1 | grep -F printf (No results) On Linux: $ man /usr/share/man/man1/find.1

Re: Fwd: Need help implementing a patch

Heiko gave advice already. Ilmari On 23.11.2020 17.29, Xisco Fauli wrote: Adding dev list On 23/11/20 16:22, Xisco Fauli wrote: forwarding this to the dev and ux lists for a wider audience. Forwarded Message Subject:Need help implementing a patch Date: Thu, 19

Re: Fwd: Need help implementing a patch

Adding dev list On 23/11/20 16:22, Xisco Fauli wrote: > > forwarding this to the dev and ux lists for a wider audience. > > > > Forwarded Message > Subject: Need help implementing a patch > Date: Thu, 19 Nov 2020 20:30:20 -0300 >

Re: [PATCH] Remove leftover cast of fResolutionDPI

Hi, Am 11.11.20 um 19:30 schrieb Brett T. Warden: > When building with --disable-pdfium, compilation fails due to a > reference to fResolutionDPI, which is now only defined within the > #if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block. Already fixed?

Re: [PATCH] Remove leftover cast of fResolutionDPI

Brett T. Warden kirjoitti 11.11.2020 klo 20.30: When building with --disable-pdfium, compilation fails due to a reference to fResolutionDPI, which is now only defined within the #if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block. --- vcl/source/filter/ipdf/pdfread.cxx | 1 - 1

[PATCH] Remove leftover cast of fResolutionDPI

When building with --disable-pdfium, compilation fails due to a reference to fResolutionDPI, which is now only defined within the #if HAVE_FEATURE_PDFIUM block, so unavailable in this #else block. --- vcl/source/filter/ipdf/pdfread.cxx | 1 - 1 file changed, 1 deletion(-) diff --git

Re: Patch review

anshu khare kirjoitti 10.11.2020 klo 16.27: Hi Please review my patch https://gerrit.libreoffice.org/c/core/+/105501 I have tested it. It's working fine. Please merge it. You did not address Jim's comment: "Please see https://stackoverflow.com/questions/1967370/git-replacing-lf-with

Patch review

Hi Please review my patch https://gerrit.libreoffice.org/c/core/+/105501 I have tested it. It's working fine. Please merge it. Thanks in advance ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman

New submitted patch

Hi, I have submitted my second patch on Gerrit, Here it is: https://gerrit.libreoffice.org/c/core/+/104461 It is about using " #pragma once" instead of guards, I am asking for reviewers to check what I have made. Thanks in advance. ___ L

Patch review

Hi, Could you please review my patch : https://gerrit.libreoffice.org/c/core/+/103632 Thanks and Regards Anshu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Patch Review

Hi, I have worked on Bug 134779 - Entering a table with too many columns causing Writer to lock up. Please review my patch. https://gerrit.libreoffice.org/c/core/+/101561 Regards Anshu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Patch review

Hi mentors, Please check https://gerrit.libreoffice.org/c/core/+/101242 I have worked on the Bug 87963 Thank you Regards Anshu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] libetonyek: std::for_each

On 19.05.2020 9:34, Roland Illig wrote: > On 19.05.2020 07:32, Mike Kaganski wrote: >> >> See >> https://libreoffice-dev.blogspot.com/2020/05/create-patch-for-libreoffice-directly.html >> > > Thanks for this pointer.  I had previously bailed out when I had t

Re: [PATCH] libetonyek: std::for_each

On 19.05.2020 07:32, Mike Kaganski wrote: On 19.05.2020 2:28, Jan-Marek Glogowski wrote: Am 18.05.20 um 20:57 schrieb Roland Illig: On 18.05.2020 09:21, Miklos Vajna wrote: Could you please push your patch to gerrit? Nope. I won't clone a 1 GB repository and install several tools just

Re: [PATCH] libetonyek: std::for_each

On 19.05.2020 2:28, Jan-Marek Glogowski wrote: > Am 18.05.20 um 20:57 schrieb Roland Illig: >> On 18.05.2020 09:21, Miklos Vajna wrote: >>> Could you please push your patch to gerrit? >> >> Nope. I won't clone a 1 GB repository and install several tools just for &

Re: [PATCH] libetonyek: std::for_each

Am 18.05.20 um 20:57 schrieb Roland Illig: > On 18.05.2020 09:21, Miklos Vajna wrote: >> Could you please push your patch to gerrit? > > Nope. I won't clone a 1 GB repository and install several tools just for > fixing a single line of code. It's much more efficient if you do

Re: [PATCH] libetonyek: std::for_each

On 18.05.2020 09:21, Miklos Vajna wrote: Hi Roland, Could you please push your patch to gerrit? Nope. I won't clone a 1 GB repository and install several tools just for fixing a single line of code. It's much more efficient if you do that, since you already have all the infrastructure set up

Re: [PATCH] libetonyek: std::for_each

Hi Roland, Could you please push your patch to gerrit? See <https://wiki.documentfoundation.org/Development/gerrit/setup>. It's much easier to take patches from there. Thanks, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedeskt

[PATCH] libetonyek: std::for_each

NUM3Parser.cpp: In member function 'virtual bool libetonyek::NUM3Parser::parseDocument()': NUM3Parser.cpp:46:3: error: 'for_each' is not a member of 'std' std::for_each(sheetListRefs.begin(), sheetListRefs.end(), std::bind(::parseSheet, this, std::placeholders::_1)); std::for_each needs .

[Libreoffice-bugs] [Bug 131140] [PATCH] Add a negative number to the example of NPV.

https://bugs.documentfoundation.org/show_bug.cgi?id=131140 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this

[Libreoffice-bugs] [Bug 131140] [PATCH] Add a negative number to the example of NPV.

|NEW CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #1 from Buovjaga --- Thanks for the patch! However, it should be sent to gerrit: https://wiki.documentfoundation.org/Development

[SOLVED] Re: Patch ok locally but fails on gerrit

Thank you Miklos and Stephan (who responded on gerrit). The use of rtl::isSurrogate() avoids to call ICU libs from starmath. Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing

Patch ok locally but fails on gerrit

Hello, I gave a try to tdf#129372 (FILEOPEN: PPTX: File format error found at SfxBaseModel::storeToStorage: 0x20d(row,col) – works w/ PowerPoint 2013) with https://gerrit.libreoffice.org/c/core/+/91941. The pb is it builds ok locally but it fails on Jenkins, eg on Linux gcc: [build LNK]

Re: Patch ok locally but fails on gerrit

Hi Julian, On Thu, Apr 09, 2020 at 12:20:30AM -0700, julien2412 wrote: > I gave a try to tdf#129372 (FILEOPEN: PPTX: File format error found at > SfxBaseModel::storeToStorage: 0x20d(row,col) – works w/ PowerPoint 2013) > with https://gerrit.libreoffice.org/c/core/+/91941. > The pb is it builds

[Libreoffice-bugs] [Bug 131140] [PATCH] Add a negative number to the example of NPV.

https://bugs.documentfoundation.org/show_bug.cgi?id=131140 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You

[Libreoffice-bugs] [Bug 131140] New: [PATCH] Add a negative number to the example of NPV.

https://bugs.documentfoundation.org/show_bug.cgi?id=131140 Bug ID: 131140 Summary: [PATCH] Add a negative number to the example of NPV. Product: LibreOffice Version: unspecified Hardware: All OS: All Status

Cannot review Gerrit patch

Regina Henschel wrote on Fri Jan 3 01:15:56 UTC 2020: > I can confirm, that it does not work in the old UI. The old UI works as expected now, see this issue: [1]. [1] https://redmine.documentfoundation.org/issues/3068 ___ LibreOffice mailing list

Re: Cannot review Gerrit patch

Hi Chris, I can confirm, that it does not work in the old UI. Chris Sherlock schrieb am 02-Jan-20 um 23:01: On 2 Jan 2020, at 10:24 am, Thorsten Behrens wrote: Hey Chris, Chris Sherlock wrote: Quick ping. Anyone able to assist? Not really - seems to work fine here, though not using the

Re: Cannot review Gerrit patch

On 2 Jan 2020, at 10:24 am, Thorsten Behrens wrote: > > Hey Chris, > > Chris Sherlock wrote: >> Quick ping. Anyone able to assist? >> > Not really - seems to work fine here, though not using the old UI. > > Cheers, > > — Thorsten Cool. Out of interest, how on earth do I get back to the new

Re: Cannot review Gerrit patch

Hey Chris, Chris Sherlock wrote: > Quick ping. Anyone able to assist? > Not really - seems to work fine here, though not using the old UI. Cheers, -- Thorsten signature.asc Description: PGP signature ___ LibreOffice mailing list

Re: Cannot review Gerrit patch

On 30 Dec 2019, at 10:06 pm, Chris Sherlock wrote: > > Hi all, > > Does anyone know why I can’t review the following? > > https://gerrit.libreoffice.org/#/c/core/+/83439/ > > > I click on the hex/cxx files and it doesn’t open in the old

Cannot review Gerrit patch

Hi all, Does anyone know why I can’t review the following? https://gerrit.libreoffice.org/#/c/core/+/83439/ I click on the hex/cxx files and it doesn’t open in the old classic UI. Any ideas?

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 Julien Nabet changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |dlc@gmail.com

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #16 from Commit Notification --- Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/06b01f73a2d0cc5b6a1c86942e28b1ce7b37bd91 tdf#128189:

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #15 from Michael Weghorn --- Thanks for your patch, David. Julien, thanks for submitting it to Gerrit, looks good to me. -- You are receiving this mail because: You are the assignee for the bug

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #14 from Julien Nabet --- I submitted the patch here: https://gerrit.libreoffice.org/#/c/81005/ Michael: put you in cc as you may have seen. -- You are receiving this mail because: You are the assignee for the bug

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #13 from David L. Craig --- Is there a problem? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | --- Comment #11 from Julien

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #10 from David L. Craig --- Okay, I sent it to that list, signed with my PGP-compliant key. Let me know if you need anything else. -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #9 from David L. Craig --- libreoff...@lists.freedesktop.org ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #8 from David L. Craig --- So what is the developer's list email address? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #7 from Julien Nabet --- it’s just about sending an email to a specific address with: - a specific subject - a block of text in object details here: see https://wiki.documentfoundation.org/Development/Developers I’d be

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #6 from David L. Craig --- Sigh. Very well, in my copious free time--I'll start now (maybe it's more trivial than I'm thinking)... -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #5 from Julien Nabet --- (In reply to David L. Craig from comment #4) > This patch, already attached, is against 1 file, 8 lines, 10 character > deletions/replacements. Do I really need to jump through these hoops?

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #4 from David L. Craig --- This patch, already attached, is against 1 file, 8 lines, 10 character deletions/replacements. Do I really need to jump through these hoops? -- You are receiving this mail because: You

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

, ||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- Michael: thought you might be interested in this one since it concerns kde/qt. David: I didn't see the patch but the first prerequisite is license part. We can't integrate your patch if you don't provide

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 Xisco Faulí changed: What|Removed |Added Keywords||patch Ever confirmed|0

[Libreoffice-bugs] [Bug 128189] configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 --- Comment #1 from David L. Craig --- Created attachment 155047 --> https://bugs.documentfoundation.org/attachment.cgi?id=155047=edit Patch against configure.ac -- You are receiving this mail because: You are the assig

[Libreoffice-bugs] [Bug 128189] New: configure.ac has a couple issues (patch attached)

https://bugs.documentfoundation.org/show_bug.cgi?id=128189 Bug ID: 128189 Summary: configure.ac has a couple issues (patch attached) Product: LibreOffice Version: 6.3.2.2 release Hardware: All OS: All Status

  1   2   3   4   5   6   7   8   9   10   >