[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Thorsten Wagner changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |thorsten.wagne...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #119 from Thorsten Wagner --- Some first results: Text is sharp now within dropdown windows and within application windows (Writer, Calc, etc.) on retina displays too. I am currently preparing a first revision of patch for testing (not for committing). Patch will include the following: (1) Removal of path to handle application as being linked again 10.13 SDK (2) salvd.cxx: Refactoring/rework of AquaSalVirtualDevice::SetSize to use quad storage size for retina displays (3) salgdicommon.cxx: Refactoring/rework of AquaSalGraphics::SetVirDevGraphics to apply double scaling to virtual devices too (4) salgdicommon.cxx: Refactoring/rework of AquaSalGraphics::copyBits and AquaSalGraphics::copyArea to use a new unified method AquaSalGraphics:copyScaledArea to handle sources from scaled virtual devices as well (5) salbmp.cxx: Workaround for QuartzSalBitmap to downsample bitmaps from scaled layers (this workaround has still to be replaced by an implementation of scaled bitmaps) (6) Environment variable VCL_FORCE_WINDOW_SCALING to activate window scaling on non retina displays too (should look the same as without window scaling, but very useful for testing on a non retina display) Bitmap workaround causes blurry bitmap representations on retina displays as on non retina displays as well. This is desired for now, because implementation of scaling-aware bitmaps has still to be done. On retina displays it looks similar as on Mojave or Catalina. After patch has been tested especially according to unwanted side effects, following steps have to be done: (1) QuartzSalBitmap has to be extened to handle bitmaps from scaled sources, workaround has to be removed afterwards (2) Environment variable VCL_FORCE_WINDOW_SCALING has to be removed and replaced by a scaling of 2.0f on macOS (and by a scaling from the main display on IOS). After application, windows are able to be moved between retina and non retina displays without showing blurry text again. I will post a link to the patch here as soon as it is ready for testing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #118 from Tor Lillqvist --- Interesting observation: Running > VCL_DOUBLEBUFFERING_ENABLE=1 > instdir/LibreOfficeDev.app/Contents/MacOS/soffice --writer will make the text you type into the Writer window show up crisp and nice. But running > VCL_DOUBLEBUFFERING_ENABLE=1 > instdir/LibreOfficeDev.app/Contents/MacOS/soffice /path/do/document.odt does now change how it looks. Very weird. But note that even in the soffice --writer case, even if the text shows up crisp, there are other problems, like the selection indicators don't show up at all if you select part of the text you have entered. The VCL_DOUBLEBUFFERING_ENABLE environment variable is related to an abandoned effort to make VCL and the way LO uses it saner, or something. Here is a discussion we just had on IRC (edited for clarity): > tml__: What does your comment "FIXME: this must disappear as we move to > RenderContext only" in vcl/source/window/paint.cxx mean? > > vmiklos: It means that if application code (outside vcl) would store no state > during rendering (on the outputdevice), then such copying would not > be necessary. but today i guess we learned that app code won't be > changed that way (too much work). > > tml__: Idly wonders what RenderContext is. > > vmiklos: RenderContext is just a typedef to OutputDevice; the idea was to not > paint at random times, but rather only paint when vcl gives you a > RenderContext. That's how practically all toolkits work. > But Skia, gtk3, Qt (and I would guess macOS, but haven't checked) > all gave up on changing non-vcl code, rather they maintain this > backbuffer (so non-vcl code can draw at random times) and just > copy the backbuffer to the final place when they get a drawing > context from the OS/underlying toolkit (on idle). > > tml__: I didn't even know that there had been such an attempt/wish/plan to > "move to RenderContext only". > > vmiklos: https://speakerdeck.com/kendy/rendercontext-and-double-buffering it > was an effort 6 years ago. I think the hope was that this way one > more backbuffer can be avoided for (back then) OpenGL, and the result > was that, no, too much work, just do this for OpenGL (and now Skia) > the same way as gtk3 does. Like, if this would work, then each > backend would not need their own backbuffer. (But it does not work.) > > tml__: And is this RenderContext effort then the same as that which > introduced that VCL_DOUBLEBUFFERING_ENABLE etc? Or unrelated? > > vmiklos: Same > > mmeeks: AFAIR we had some death-march to try to make it work everywhere > properly; that failed in the end, > and we did something -much- simpler that didn't burn several > engineers for weeks =) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #117 from Arne --- Installed latest daily build (date stamp 2020-12-31 10:01:10) on same Retina MacBook Pro from Comment 10. No change seen, text is still blurred as described in this bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #116 from Tor Lillqvist --- Yes, I noticed the same about the first parameter to AquaSalGraphics::SetVirDevGraphics () earlier today, and added a comment about it;) In general, it is not entirely clear to me what the benefit of wrapping a CGLayerRef in CGLayerHolder and a CGContextRef in CGContextHolder is. But I am probably missing something. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #115 from Thorsten Wagner --- Just to be complete: All blurring (combo box dropdowns, Writer main window, Calc main window, etc.) is caused by double buffering from the main code using the VCL virtual device, in this case initialized by AquaSalVirtualDevice::SetSize and AquaSalGraphics::SetVirDevGraphics. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #114 from Thorsten Wagner --- After investigation and refactoring of AquaSalVirtualDevice::SetSize and AquaSalGraphics::SetVirDevGraphics I was not able to archive sufficient results with doubeling bufferspace and scale. But there is another observation I want to share: Replacing const int nFlags = kCGImageAlphaNoneSkipFirst by const int nFlags = kCGBitmapByteOrder32Host; in AquaSalVirtualDevice::SetSize will result in problems with image alpha channel as expected. Furthermore performace is bad and application will become unresponsive from time to time. But text and graphics are sharp now although bitmap buffer size has not been increased. Will take a look in this direction next. @ Tor: The parameters for AquaSalGraphics::SetVirDevGraphics seem to allow calling with either a GCLayer on a CGBitmapContext or with a CGBitmapContext only (without a GCLayer on top). As AquaSalGraphics::SetVirDevGraphics is called from AquaSalVirtualDevice::SetSize only for now, both parameters are not required. But these parameters are not the reason of blurry text and graphics when set correctly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #113 from Commit Notification --- Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2e42a85fe0d7a1a7d0a1778f1a6d3625fc3c9d79 tdf#138122: Add comment wondering what the code does It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #111 from Theo --- (In reply to Jean from comment #109) > There is a "Big Sur" Update now. Although not targeted towards solving this > problem, let's see if there is an improvement... I hate to disappoint you, but with macOS 11.1 (Big Sur) there is no change. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #110 from Theo --- (In reply to Jean from comment #109) > There is a "Big Sur" Update now. Although not targeted towards solving this > problem, let's see if there is an improvement... I hate to disappoint you, but with macOS 11.1 (Big Sur) there is no change. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #109 from Jean --- There is a "Big Sur" Update now. Although not targeted towards solving this problem, let's see if there is an improvement... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #108 from w...@rsb.at --- I assume you know yourself that the way you draw fonts is broken. Just for completeness: In MacOS 11.1 LO still provides blurry text. I think it might help to get the latest hard- and software and correct the mistake there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Uwe Auer changed: What|Removed |Added CC||w...@rsb.at --- Comment #106 from Uwe Auer --- *** Bug 138928 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Ming Hua changed: What|Removed |Added CC||relierlesm...@gmail.com --- Comment #105 from Ming Hua --- *** Bug 138709 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #104 from Mark Simon --- Again, for what it’s worth, I am currently editing a document with tracking, and I see that the comments are clear. The ▾Comments heading above is blurry. At a zoom of 125% the document isn’t too unreadable, though I would hate to make a career of using it this way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #103 from lupu...@web.de --- I came so far: 1) The "normal" text in a Combobox is drawn in vcl/source/control/imp_listbox.cxx in void ImplListBoxWindow::DrawEntry(vcl::RenderContext& rRenderContext, sal_Int32 nPos, bool bDrawImage, bool bDrawText) in line 1728: rRenderContext.DrawText(aTextRect, aStr, nDrawStyle); 2) If you open the font combobox in the toolbar, this entry is using a different method, it uses a custom draw method in vcl/source/control/imp_listbox.cxx void ImplListBoxWindow::ImplPaint(vcl::RenderContext& rRenderContext, sal_Int32 nPos) in line 1641: UserDrawEvent aUDEvt(this, , aRect, nPos, bSelected); maUserDrawHdl.Call( ); 3) The style entry in the styles sidebar is a treeview and gets drawn in vcl/source/treelist/treelistbox.cxx void SvTreeListBox::DrawCustomEntry(vcl::RenderContext& rRenderContext, const tools::Rectangle& rRect, const SvTreeListEntry& rEntry) in line 2863: aCustomRenderHdl.Call(std::tuple(rRenderContext, rRect, rEntry)); (I cannot find, what function is calling DrawCustomEntry) So the big question is: Why is 3) sharp and 2) not? They seem to do the same. Maybe just the RenderContext is different? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #102 from lupu...@web.de --- What could be a next point to investigate: Why is the text in the Combobox sharp, but the text in the dropdown not? And why is the text in the style sidebar sharp as well? Does anyone know what is the name of the sidebar component? Where can I find it in the code? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #101 from Mark Byrn --- (In reply to Telesto from comment #100) > Not sure if relevant at all, but this might influence they font quality > https://www.macrumors.com/how-to/disable-font-smoothing-in-macos-big-sur/ Tried that but didn't have any effect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #100 from Telesto --- Not sure if relevant at all, but this might influence they font quality https://www.macrumors.com/how-to/disable-font-smoothing-in-macos-big-sur/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #99 from Tor Lillqvist --- The commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=959e8ae7ea33ce94dd80ee8ea172b6db64593873 btw says: > A known issue is that VirtualDevice also needs to take scaling > into account, which it currently doesn't, so the text is still > blurry on a HiDPI screen, but that was already true previously > and is something that will be done in a different change. But apparently that was not done while the developer still remembered what was to be done. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122
--- Comment #98 from Tor Lillqvist ---
If you add this to your changed code after the call to CGBitmapContextCreate():
SAL_DEBUG("maBitmapContext.get()=" << maBitmapContext.get());
you will see that the call actually fails. So is this much of the complexity in
there actually unnecessary? Mind-boggling...
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #97 from lupu...@web.de --- (In reply to Tor Lillqvist from comment #94) > How can that work? Surely correspondingly more space must be allocated for > the pRawData in that case, too? The docs for CGBitmapContextCreate say: > > data > A pointer to the destination in memory where the drawing is to be rendered. > The size of this memory block should be at least (bytesPerRow*height) bytes. > > and the "height" parameter we pass with such a change is nDY * fScale, and > bytesPerRow is (mnBitmapDepth * nDX) / 8, i.e. nDX * 4. The interesting thing is: I get an error in the console: 'CGBitmapContextCreate: invalid data bytes/row: should be at least ...' If I then say const int nBytesPerRow = (mnBitmapDepth * nDX * fScale) / 8; instead of const int nBytesPerRow = (mnBitmapDepth * nDX) / 8; the text gets blurred again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #96 from Tor Lillqvist --- But in AquaSalGraphics::CheckContext(), the first parameter to CGBitmapContextCreate() is nullptr, it is the function itself that allocates the necessary amount of memory. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #95 from lupu...@web.de --- Take a look at salgdiutils.cxx in bool AquaSalGraphics::CheckContext(). I copied the code from there. It's a strange problem, because some of the text was blurred and some not. So there must be a difference between for example drawing the text in the Combobox and the text in the popup of the combobox. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #94 from Tor Lillqvist --- How can that work? Surely correspondingly more space must be allocated for the pRawData in that case, too? The docs for CGBitmapContextCreate say: data A pointer to the destination in memory where the drawing is to be rendered. The size of this memory block should be at least (bytesPerRow*height) bytes. and the "height" parameter we pass with such a change is nDY * fScale, and bytesPerRow is (mnBitmapDepth * nDX) / 8, i.e. nDX * 4. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #93 from lupu...@web.de --- Go to vcl/quartz/salvd.cxx In bool AquaSalVirtualDevice::SetSize( tools::Long nDX, tools::Long nDY ) add this: float fScale = 1.0f; if (pSalFrame->getNSWindow()) fScale = [pSalFrame->getNSWindow() backingScaleFactor]; maBitmapContext.set(CGBitmapContextCreate(pRawData, nDX * fScale, nDY * fScale, 8, nBytesPerRow, GetSalData()->mxRGBSpace, nFlags)); Now everything is crispy clear. Unfortunately LO became extremely slow with that. Maybe someone knows more? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #92 from Tor Lillqvist --- No, I am *sure* this has something to do with Core Animation Layers, as I said in comment #82. That is what changed in 10.14 and 11.0, after all. But most likely the code in LO "works against the system" in some way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #91 from Emmeran Seehuber --- (In reply to Tor Lillqvist from comment #88) > Created attachment 167757 [details] > Zoomed in screenshot of LO with the above patch > > As can be seen, the letters are quite grey, you don't see many fully black > pixels at all. Are you really sure that this has nothing to do with the CALayer? For me it seems this is still blurry because it has been upscaled. Just the more gray antialised font shading makes this less obvious. I found this regarding CALayer and blurryness: https://stackoverflow.com/questions/25746368/ios-drawing-in-calayers-drawincontext-is-either-pixelated-or-blurry-on-retina It's for iOS, but maybe it applies for macOS too? At least it seems to be the same problem. No idea if the proposed fix there can be applied on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #90 from Tor Lillqvist --- Anyway, my guess is that it is not through some combination of CGContextSet* calls that affect text rendering that we should fix this problem, but that indeed there is something fundamentally wrong or unnecessarily complex in how the text is rendered and eventually ends up on the screen. At some stage the rendered text perhaps passes through a non-Retina resolution intermediate stage, and after that it is of course worthless to upscale it again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #89 from Tor Lillqvist --- Created attachment 167758 --> https://bugs.documentfoundation.org/attachment.cgi?id=167758=edit Zoomed in screenshot of NeoOffice Very crisp and black letters. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #88 from Tor Lillqvist --- Created attachment 167757 --> https://bugs.documentfoundation.org/attachment.cgi?id=167757=edit Zoomed in screenshot of LO with the above patch As can be seen, the letters are quite grey, you don't see many fully black pixels at all. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #87 from Tor Lillqvist --- Using ideas from the experimentation patch mentioned in comment #39, I think I see a clear improvement when using some combination of the tweaks from that, like: diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx index 704bba1fae9c..23f93aeb9272 100644 --- a/vcl/quartz/salgdi.cxx +++ b/vcl/quartz/salgdi.cxx @@ -450,7 +450,16 @@ void AquaSalGraphics::DrawTextLayout(const GenericSalLayout& rLayout) // The view is vertically flipped (no idea why), flip it back. CGContextScaleCTM(maContextHolder.get(), 1.0, -1.0); -CGContextSetShouldAntialias(maContextHolder.get(), !mbNonAntialiasedText); + +CGContextSetShouldAntialias(maContextHolder.get(), true); +CGContextSetAllowsAntialiasing(maContextHolder.get(), true); +CGContextSetAllowsFontSmoothing(maContextHolder.get(), false); +CGContextSetShouldSmoothFonts(maContextHolder.get(), false); +CGContextSetAllowsFontSubpixelPositioning(maContextHolder.get(), true); +CGContextSetShouldSubpixelPositionFonts(maContextHolder.get(), true); +CGContextSetAllowsFontSubpixelQuantization(maContextHolder.get(), true); +CGContextSetShouldSubpixelQuantizeFonts(maContextHolder.get(), true); + CGContextSetFillColor(maContextHolder.get(), maTextColor.AsArray()); if (rStyle.mbFauxBold) But if I zoom in a lot, I see that the text is still rendered much different than in NeoOffice, for instance. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #86 from Tor Lillqvist --- Using ideas from the experimentation patch mentioned in comment #39, I think I see a clear improvement when using some combination of the tweaks from that, like: diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx index 704bba1fae9c..23f93aeb9272 100644 --- a/vcl/quartz/salgdi.cxx +++ b/vcl/quartz/salgdi.cxx @@ -450,7 +450,16 @@ void AquaSalGraphics::DrawTextLayout(const GenericSalLayout& rLayout) // The view is vertically flipped (no idea why), flip it back. CGContextScaleCTM(maContextHolder.get(), 1.0, -1.0); -CGContextSetShouldAntialias(maContextHolder.get(), !mbNonAntialiasedText); + +CGContextSetShouldAntialias(maContextHolder.get(), true); +CGContextSetAllowsAntialiasing(maContextHolder.get(), true); +CGContextSetAllowsFontSmoothing(maContextHolder.get(), false); +CGContextSetShouldSmoothFonts(maContextHolder.get(), false); +CGContextSetAllowsFontSubpixelPositioning(maContextHolder.get(), true); +CGContextSetShouldSubpixelPositionFonts(maContextHolder.get(), true); +CGContextSetAllowsFontSubpixelQuantization(maContextHolder.get(), true); +CGContextSetShouldSubpixelQuantizeFonts(maContextHolder.get(), true); + CGContextSetFillColor(maContextHolder.get(), maTextColor.AsArray()); if (rStyle.mbFauxBold) But if I zoom in a lot, the text is still rendered much different than in NeoOffice, for instance. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #85 from Jan-Marek Glogowski --- After reading comment 82, I was curious and downloaded the NeoOffice source, which - according to their marketing and comment 83 - works correct w.r.t. "crisp fonts" on MacOS 11 / Big Sur. An "grep -ri" over the whole NeoOffice codebase for either CALayer or wantsLayer returns no hits, which IMHO strongly suggests, that the whole CALayer problem fixed by Qt mentioned in comment 82 is not the same problem LO has. If you read the original QT bug reference in the commit (https://bugreports.qt.io/browse/QTBUG-87014), you'll find that Qt has application startup problems and nothing in the bug's comments indicate anything else. So I really doubt LO needs any adoption regarding CALayer handling. Now for a different idea about the origin of the bug: my assumption is, that all this is "just" some scaling problem originating in the way Retina screens are handled in MacOS graphics layer. And IMHO a very strong indicator for a problem is commit 7c35d5f0669f461254668c1854291e1324b37c21. I introduced that assert and never saw it failing; but then I never had any Retina HW. And problems might have originally started with macOS 10.14, when commit e659c6a1857fbb8e5a6e8ff60fe241483eea32dd as a workaround, which converted the bitmap context for headless LO into a generic fallback. AFAIK this was introduced for https://bz.apache.org/ooo/show_bug.cgi?id=91990 And maybe my commit b14371703236160bf34480ef831e9b2244e140ee back then just made things worse. My suggestion would be to revert commit 7c35d5f0669f461254668c1854291e1324b37c21 to see, if LO still triggers that assert and try to find out, why commit e659c6a1857fbb8e5a6e8ff60fe241483eea32dd is needed at all. BTW: there is CGContextGetUserSpaceToDeviceSpaceTransform or CGContextConvertSizeToDeviceSpace, which could indicate some wrong mapping resulting in scaled text. P.S. I don't have any mac HW, so I can't test myself. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Ming Hua changed: What|Removed |Added CC||movinonthewa...@gmail.com --- Comment #84 from Ming Hua --- *** Bug 138613 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #83 from J-M Allier --- I upgraded my MacBook Pro to macOS Big Sur 11.0.1 and then LibreOffice from 6.4.7.2 to 7.0.3. The characters were blurry on 6.4.7.2 and on 7.0.3 as well. Because of other bugs on 7.0.3 I reverted to 6.4.7. I have done some tests with OpenOffice 4.1.8, NeoOffice 2017.23 and, unfortunately with LO6472, but I believe it gave interesting results. I hope this will help to solve the bug. I used an external 1920*1080 HD screen connected by HDMI to the MacBook Pro. First I set the main display to the Retina display and compared characters with the same file (an ods file) on the three apps. Moving windows from the main to the secondary and back to main display. The characters were crisp on the Retina display with NeoOffice and OpenOffice. Blurry in LO. Then I set the main display to the external display (1920*1080). Of course, LO characters were blurry on the Retina display. But a difference appeared between OO and NO when windows were moved to the Retina display. NeoOff displayed crisp characters on Retina, but OpenOff displayed the same blurry characters as LO. Maybe this will give some clues. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #82 from Tor Lillqvist --- Technical details: What apparently is going on is that in macOS 10.14 and 10.15, views (NSView objects) were backed by a Core Animation layer if the app was built against the 10.14 SDK or later. What Stephan Bergmann's patch (645fe53be0dc36535dba0ed684e21ca4cda80d70) does is to make the soffice binary marked as built against some unknown old SDK even if it was built with a current Xcode. But in macOS 11.0, views are always backed by Core Animation layer, the SDK version of the program executable does not matter any longer. (This is nicely summarised by the commit message (unrelated to LibreOffice) in https://codereview.qt-project.org/c/qt/qtbase/+/38 , for instance.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #81 from Tor Lillqvist --- "Roadmap"? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #80 from Alexander Barris --- (In reply to Tor Lillqvist from comment #79) > Btw, for some experimentation code, see > https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c219 . > > (In general, for anybody seriously pondering investigating and fixing this, > it probably is a good idea to read through that bug, but yeah, not all > comments are very informative.) Is this on the roadmap to get solved in LO 7.1? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #79 from Tor Lillqvist --- Btw, for some experimentation code, see https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c219 . (In general, for anybody seriously pondering investigating and fixing this, it probably is a good idea to read through that bug, but yeah, not all comments are very informative.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Xisco Faulí changed: What|Removed |Added CC||gpma...@protonmail.com --- Comment #78 from Xisco Faulí --- *** Bug 138565 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #77 from Jean --- (In reply to Tor Lillqvist from comment #69) > Feel free to use Apache OpenOffice then, we won't mind! I am too faithful for that... I have one computer on Black Sur, but that is a demonstration tool for secondary work, my main unit is still on Catalina, and I will not move till the solution has been brought. There is a slight improvement by doing this in Terminal: 1. defaults -currentHost write -g AppleFontSmoothing -int 0 2. reboot I followed the instructions on this link which recommends to proceed to steps 3. and 4. but when I do that, I again find the defect. With Steps 1 and 2, it is a little better (at least, one can work in better conditions. https://discussions.apple.com/thread/252034861 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #76 from trainma...@gmail.com --- (In reply to Jean from comment #68) > On top of that, all other Mac-compatible softwares tested (so far) do not > show such defect. > Moving from Version 5 to Version 6, only LibreOffice had such problem. > > Just loaded OpenOffice 4.1.8. and it works perfect... I've found certain areas within Audacity do the same - drop down menus are clear, other text is blurry. Doesn't help here, but LO is not alone! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #75 from Alexander Barris --- (In reply to Telesto from comment #74) > (In reply to Alexander Barris from comment #73) > > I can confirm the latest OpenOffice 4.1.8 works fine. Which old version of > > LibreOffice should be tested? > > Not having really systematic approach, but lets say > https://downloadarchive.documentfoundation.org/libreoffice/old/5.0.0.5/mac/ > x86_64/ > > if that one is also bad > https://downloadarchive.documentfoundation.org/libreoffice/old/4.2.0.4/mac/ > x86_64/ (there are no older x64 builds..) > > if 5.0.0.5 being good, take 6.0.0.3 6.1.0.1, 5.0.0.5, and 4.2.0.4 mysteriously segfaulted for me -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #74 from Telesto --- (In reply to Alexander Barris from comment #73) > I can confirm the latest OpenOffice 4.1.8 works fine. Which old version of > LibreOffice should be tested? Not having really systematic approach, but lets say https://downloadarchive.documentfoundation.org/libreoffice/old/5.0.0.5/mac/x86_64/ if that one is also bad https://downloadarchive.documentfoundation.org/libreoffice/old/4.2.0.4/mac/x86_64/ (there are no older x64 builds..) if 5.0.0.5 being good, take 6.0.0.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #73 from Alexander Barris --- (In reply to Telesto from comment #72) > Out of curiosity - based on they assumption OoO working correctly... is > there a working version in they LibreOffice archive.. > > https://downloadarchive.documentfoundation.org/libreoffice/old/ > > If so, maybe in a bibisecting range? > https://wiki.documentfoundation.org/QA/Bibisect/macOS I can confirm the latest OpenOffice 4.1.8 works fine. Which old version of LibreOffice should be tested? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #72 from Telesto --- Out of curiosity - based on they assumption OoO working correctly... is there a working version in they LibreOffice archive.. https://downloadarchive.documentfoundation.org/libreoffice/old/ If so, maybe in a bibisecting range? https://wiki.documentfoundation.org/QA/Bibisect/macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #71 from Tor Lillqvist --- No, the codebase of those is so different that it doesn't help much. Plus in the NeoOffice case, its license makes it impossible. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #70 from Mugs --- (In reply to Tor Lillqvist from comment #69) > Feel free to use Apache OpenOffice then, we won't mind! I have already done that, and as stated the interface is clear and beautiful as you would expect on a Retina display - however for some reason, certain images embedded in the files do not display. For this reason I have had to shell out dollars to pay for NeoOffice which in my opinion is still far inferior to LibreOffice, but fixes the blurring issue. Can the solution to the problem in LibreOffice not be gleaned from why OpenOffice and NeoOffice do not suffer from this problem - I would so desperately like to return to LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #69 from Tor Lillqvist --- Feel free to use Apache OpenOffice then, we won't mind! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #68 from Jean --- On top of that, all other Mac-compatible softwares tested (so far) do not show such defect. Moving from Version 5 to Version 6, only LibreOffice had such problem. Just loaded OpenOffice 4.1.8. and it works perfect... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #67 from Jean --- Version 7.0.3.1 on macOS Catalina was OK Version 7.0.3.1 on masOS Big Sur NOT OK Version 7.1.0.0.0beta1 onmasOS Big Sur NOT OK -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #66 from Jean --- (In reply to Alexander Barris from comment #4) > Probably a HiDPI and resolution issue. When I set the internal display's > resolution to 1920 x 1200, the font is clear. However, once I get it to 1680 > x 1050 (Most Space), the text becomes blurry. This happens regardless of > Retina (HiDPI) being enabled or disabled. No clear improvement when modifying resolution. We do not find the previous clarity. I remember this happened in the same way when moving from version 5.x to version 6. Quite annoying... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Alexander Barris changed: What|Removed |Added Blocks||90796 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Aron Budea changed: What|Removed |Added Priority|medium |highest Severity|normal |critical --- Comment #65 from Aron Budea --- I'm assuming the same severity/priority as bug 122218 is warranted here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Christian Lohmaier changed: What|Removed |Added Alias||blurry_text -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #64 from Telesto --- And is this still being true? https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c203 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #63 from Telesto --- (In reply to lupurus from comment #57) > (In reply to Tor Lillqvist from comment #56) > > Text is drawn in AquaSalGraphics::DrawTextLayout() in vcl/quartz/salgdi.cxx, > > as far as I recall. Look for the CTFontDrawGlyphs() call. Only a some old info which hidden in bug 122218 They temporal - now broken hack - for Catalina (instead they temporal solution of building with Xcode 10) https://gerrit.libreoffice.org/c/core/+/88667/2/desktop/Executable_soffice_bin.mk See additional comments/explanation for they old hack: https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c190 https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c194 --- FWIW: does tinkering with TinkerTool related to font make any difference? Only a thought.. There is an option or old style font rendering. There is bug report about font not being 'crisp' but kind of different of being blurry. So who knows... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Mike Kaganski changed: What|Removed |Added CC||alessandro.ma...@cwnet.it --- Comment #62 from Mike Kaganski --- *** Bug 138460 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 G changed: What|Removed |Added CC||guillermo_...@hotmail.com --- Comment #61 from G --- Created attachment 167439 --> https://bugs.documentfoundation.org/attachment.cgi?id=167439=edit Sharp Text (Selected) vs Blurry (Text) The issue is now with BigSur, it was fixed before in Catalina with a patch. I would say that is a new issue as with the same Libreoffice 6.4.7.2, before the Update the fonts where all right, and after the MacOs update to BigSur, the same version of Libreoffice 6.4.7.2 and Libreoffice 7.0.3.1 are Blurry. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Jan-Marek Glogowski changed: What|Removed |Added CC||rucab...@yahoo.com --- Comment #60 from Jan-Marek Glogowski --- *** Bug 138381 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #59 from Emmeran Seehuber --- (In reply to lupurus from comment #57) > (In reply to Tor Lillqvist from comment #56) > > Text is drawn in AquaSalGraphics::DrawTextLayout() in vcl/quartz/salgdi.cxx, > > as far as I recall. Look for the CTFontDrawGlyphs() call. > > Thank you. I am kind of frustrated right now, I tried a lot of different > settings like 'CGContextSetAllowsFontSmoothing' for example... nothing > helped. I am still wondering: Why is the font in the main view, the status > bar, the combobox area blurred, but the text in the TOC or where you can > select the text styles for example or in other menus not? Are they using > different methods? I don't think that the problem is related to the way the text is painted, as it not only affects text, but also lines. Just open a Draw document and do some diagonal lines. You'll see that they are blurry also, but it's not that visible and apparent as it is with text. The AquaSalGraphics have the right scaling for their CGLayer used (i.e. fScale is 2 for retina in AquaSalGraphics::CheckContext()). For me it seems that all drawing on this CGLayer is done with a 0.5 scale and the final copy to the parent CGContext is done with a 2 scale (i.e. to compensate the 0.5 scale while drawing). I found an Object-C snippet that should allow to export a CGLayer into a PNG to valid it's contents (https://stackoverflow.com/questions/525609/use-c-with-cocoa-instead-of-objective-c), but as I have no clue about Objective-C I can not integrate that. Is there any other way to inspect whats in a CGLayer? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #58 from Telesto --- (In reply to lupurus from comment #57) > (In reply to Tor Lillqvist from comment #56) > > Text is drawn in AquaSalGraphics::DrawTextLayout() in vcl/quartz/salgdi.cxx, > > as far as I recall. Look for the CTFontDrawGlyphs() call. > > Thank you. I am kind of frustrated right now, I tried a lot of different > settings like 'CGContextSetAllowsFontSmoothing' for example... nothing > helped. I am still wondering: Why is the font in the main view, the status > bar, the combobox area blurred, but the text in the TOC or where you can > select the text styles for example or in other menus not? Are they using > different methods? Not having Big Sur installed, yet (and kind a reluctant to do so). So not having much to go on.. based on screenshots tend say that they stuff is painted as an image at low resolution (72/96 dpi) (without prior anti-aliasing) Bit like saving QR code into DOCX format (and file reload). They SVG rendering simply quality simply bad (looks like miniature thumbnail quality being over-sized). And File -> Export formats do have also a bad ugly compression flaw somewhere. But surely depends on code paths :-( So not all export formats are affected And also which branch did you use? Master or 7.0? There where more code changes also related to anti-aliasing and image rendering (see Skia meta). Not sure if they his code simply limited to Skia or having large reach. If so, bugs might have stacked up (worst case)? I assume you build without or include they Stephan hack while nobody actually has clue what it does? As it did work previously? Also there is a risk that Apple dropped support for XYZ in Big Sur (or didn't notice they broke some legacy stuff nobody supposed to use anymore). So maybe Catalina without Stephan Bergmans patch? Not even remembering when/how the initial bug started. Except they Xcode magic an later-on they hack? Note: only few things crossing my mind :-). Not saying it's of any use. However prefer to exclude some possibility's. Or might open a different perspective. Anyhow thanks for attempting for solving the mystery :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #57 from lupu...@web.de --- (In reply to Tor Lillqvist from comment #56) > Text is drawn in AquaSalGraphics::DrawTextLayout() in vcl/quartz/salgdi.cxx, > as far as I recall. Look for the CTFontDrawGlyphs() call. Thank you. I am kind of frustrated right now, I tried a lot of different settings like 'CGContextSetAllowsFontSmoothing' for example... nothing helped. I am still wondering: Why is the font in the main view, the status bar, the combobox area blurred, but the text in the TOC or where you can select the text styles for example or in other menus not? Are they using different methods? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 --- Comment #56 from Tor Lillqvist --- Text is drawn in AquaSalGraphics::DrawTextLayout() in vcl/quartz/salgdi.cxx, as far as I recall. Look for the CTFontDrawGlyphs() call. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138122] LibreOffice text blurry on Retina displays on macOS 11
https://bugs.documentfoundation.org/show_bug.cgi?id=138122 Tor Lillqvist changed: What|Removed |Added Summary|LibreOffice font blurry on |LibreOffice text blurry on |MacBook Pro's Internal |Retina displays on macOS 11 |HiDPI Retina Display| |running macOS Big Sur | |11.0.1 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
