Re: [PATCH] tests/testsuite.at: Don't use $as_echo

2020-03-16 Thread Eric Blake
HO='printf %s\n'} for tool in ACLOCAL AUTOHEADER AUTOCONF AUTOMAKE AUTORECONF; do if eval \$$tool --version >/dev/null 2>&1; then :; else eval $tool=no; fi done -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH] tests/testsuite.at: Don't use $as_echo

2020-03-16 Thread Eric Blake
rue regardless of this patch, and I did not bother auditing whether we violate that usage pattern anywhere (perhaps we could make $ECHO expand to a function call, where the function loudly complains about $# > 1, if we wanted to make such an audit easier). -- Eric Blake, Principal Soft

Re: [PATCH 2/2] tests: fix helldl rule generation in _LT_DEMO_SETUP macro

2019-03-14 Thread Eric Blake
things. If that fails, m4sh supports quadrigraphs, where you can write @S|@@ to get $@ in the resulting file. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature

Re: Regd. use of libtool in commercial applications

2019-03-14 Thread Eric Blake
t which would be happy to take you on as a customer and help you figure out the legal ramifications of incorporating Free and Open Source products into your company - but you're still better off contacting a sales rep than an engineer if you want to engage another company's services] -- Eric Bla

Re: help

2018-02-15 Thread Eric Blake
On 02/15/2018 12:26 AM, sea star wrote: We need a bit more than a single-word message if you expect any help. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org ___ https

Re: Spelling fixes

2017-04-24 Thread Eric Blake
actual patches to this list, rather than making us chase a URL (in particular, github is notorious for requiring the use of non-free client-side javascript for the full experience, while posting a patch to the mailing list frees recipients from having to decline non-free software). -- Eric Blake, Pri

Re: How to build libtool from git sources properly?

2016-05-19 Thread Eric Blake
be merged back upstream with gnulib's bootstrap. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature ___ https://lists.gnu.org/mailman/listinfo/libtool

Re: small fix of libtool.m4

2016-05-06 Thread Eric Blake
. I did some > > cfgfile=${ofile}T > trap "$RM \"$cfgfile\"; exit 1" 1 2 15 > -$RM "$cfgfile" > +if test -e "$cfgfile" ; then > + $RM "$cfgfile" > +fi That's a TOCTTOU data race. Wouldn't it be better to just us

Re: [PATCH 1/4] Fix func_echo_all inside configure.

2016-03-10 Thread Eric Blake
nd comparable to what we have a few lines earlier: eval 'cat <<_LTECHO_EOF $[]1 _LTECHO_EOF' } ECHO='func_fallback_echo' fi # func_echo_all arg... # Invoke $ECHO with all args, space-separated. func_echo_all () { $ECHO "$*" -- Eric Blake eblake redhat com+1-919-301-32

Re: [PATCH 3/4] Use POSIX nm to simplify AIX export_symbols_cmds.

2016-03-10 Thread Eric Blake
on no leading space and one space only as separator. No, POSIX states that " " means at least one whitespace (could be multiple; implementations can align at will), and "Δ" means exactly one space character. Since nm didn't use the delta character, the code is correct at looking f

Re: Export AIX TLS symbols

2015-11-25 Thread Eric Blake
On 11/24/2015 09:22 AM, Eric Blake wrote: > On 11/05/2015 10:43 AM, David Edelsohn wrote: >> TLS symbols in AIX display a new, different symbol type in nm output. >> Libtool explicitly creates a list of exported symbols for AIX shared >> libraries using nm and does not

Re: Export AIX TLS symbols

2015-11-24 Thread Eric Blake
uot; weak" } else { print \$ 1 } > } }'\'' | sort -u > $export_symbols' > + _LT_TAGVAR(export_symbols_cmds, $1)='`func_echo_all $NM | $SED -e > '\''s/B\([[^B]]*\)$/P\1/'\''` -PCpgl $libobjs $convenience | awk '\''{ if > (((\$ 2 == "T") || (\$ 2 == "D") || (\$ 2 == "B") || (\$ 2 == "L") || (\$ 2 > == "W") || (\$ 2 == "V") || (\$ 2 == "Z")) && ([substr](\$ 1,1,1) != ".")) { > if ((\$ 2 == "W") || (\$ 2 == "V") || (\$ 2 == "Z")) { print \$ 1 " weak" } > else { print \$ 1 } } }'\'' | sort -u > $export_symbols' > fi > aix_use_runtimelinking=no > > -- > 2.4.3 > I'm not an AIX expert, and have no way to test it, but the explanation is reasonable and I don't see how it can hurt (particularly since the two changes are under "aix[[4-9]]*)" case blocks). I'll go ahead and push this patch (assuming my commit rights are still active) in 24 hours if no one speaks up to the contrary. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Bash-specific performance by avoiding sed

2015-10-07 Thread Eric Blake
bash version converts it into 'a\ \ \*\"b'. > @@ -8596,8 +8597,8 @@ EOF > relink_command="$var=$func_quote_for_eval_result; export $var; > $relink_command" > fi > done > - relink_command="(cd `pwd`; $relink_command)" > - relink_command=`$ECHO "$relink_command" | $SED "$sed_quote_subst"` > + func_quote "(cd `pwd`; $relink_command)" > + relink_command=$func_quote_result Unrelated to your patch, but doesn't this fail if pwd is called in an absolute directory containing spaces? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature ___ https://lists.gnu.org/mailman/listinfo/libtool

Re: Bash-specific performance by avoiding sed

2015-10-05 Thread Eric Blake
'Shellology' > section haven't helped me. In particular, the problem is here: It is portable to use 'set +f' to disable wildcard globbing, then 'set -f' to turn them back on. (POSIX requires it). > > x='a"[a-z]*"c' > IFS='"' > for i in $x; do # Here we wan't to

Re: [PATCH] Re: libtool-2.4.2 is fine but libtool-2.4.6 very slow.

2015-09-23 Thread Eric Blake
call to this 'version' > macro gone to infinite recursion (until ENOMEM). So rather s/gone to infinite/enters an infinite/ > re-define all potentially dangerous macros by empty strings, > suggested by Eric Blake. > > While we are on it, merge the macro-"blacklist" w

Re: [PATCH] Re: libtool-2.4.2 is fine but libtool-2.4.6 very slow.

2015-09-23 Thread Eric Blake
call to this 'version' > macro gone to infinite recursion (until ENOMEM). So rather s/gone to infinite/enters an infinite/ > re-define all potentially dangerous macros by empty strings, > suggested by Eric Blake. > > While we are on it, merge the macro-"blacklist" w

Re: [PATCH] Re: libtool-2.4.2 is fine but libtool-2.4.6 very slow.

2015-09-19 Thread Eric Blake
e > +# macros of the same name as file included in their bodies - which > +# results in infinite recursion. > +m4_define([m4_include], []) I'd recommend that you use the same fix as gettext, and define ALL of these macros to an empty string, rather than special-casing m4_include as

Re: [PATCH] Re: libtool-2.4.2 is fine but libtool-2.4.6 very slow.

2015-09-19 Thread Eric Blake
e > +# macros of the same name as file included in their bodies - which > +# results in infinite recursion. > +m4_define([m4_include], []) I'd recommend that you use the same fix as gettext, and define ALL of these macros to an empty string, rather than special-casing m4_include as

Re: Bash-specific performance by avoiding sed

2015-03-09 Thread Eric Blake
, $pre, $post, $char, $quoted] so as to be less likely to collide with other variables in use) So, where we were previously doing: _G_unquoted_arg=`printf '%s\n' $1 | $SED $sed_quote_subst` we would now do: func_quote $1 _G_unquoted_arg=$quoted for the same result, without any forking. -- Eric

Re: [SCM] GNU Libtool branch, master, updated. v2.4.5-5-gc60e054

2015-01-20 Thread Eric Blake
be output captured from some tool that includes \ in its output? If so, you'd want to use printf to make sure you don't run foul of a shell where \ is interpolated by echo. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [PATCH] question mark is extended regex for non-GNU grep

2014-11-21 Thread Eric Blake
\{0,1\} instead of \?. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [SCM] GNU Libtool branch, master, updated. v2.4.3-32-g8c2154f

2014-11-18 Thread Eric Blake
(so now you need a patch to build/git-log-fix...) -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: bootstrap patch

2014-01-27 Thread Eric Blake
On 01/26/2014 11:08 AM, Bruce Korb wrote: Hi, test -f .git? Do you mean test -d .git? No, because .git can be a symlink, in which case test -d .git fails but test -f .git passes. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: bootstrap patch

2014-01-27 Thread Eric Blake
On 01/27/2014 12:24 PM, Gary V. Vaughan wrote: Hi Eric, On Jan 28, 2014, at 2:30 AM, Eric Blake ebl...@redhat.com wrote: On 01/26/2014 11:08 AM, Bruce Korb wrote: Hi, test -f .git? Do you mean test -d .git? No, because .git can be a symlink, in which case test -d .git fails but test

Re: git commit forces bootstrap

2013-12-06 Thread Eric Blake
'. I really ought to port that to upstream gnulib's maint.mk, where we could then adapt it to libtool. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH v4 1/2] maint.mk: handle missing git with more grace

2012-12-31 Thread Eric Blake
(+), 2 deletions(-) Thanks for resending, and sorry for my abysmal reply delay. This one is now simple enough that I have pushed it. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: git-version-gen w/o git

2012-12-31 Thread Eric Blake
saw this thread; I'll make sure that I'm using v5 for the 2/2 patch. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH v4 2/2] git-version-gen: add --fallback option to use if git is not present

2012-12-31 Thread Eric Blake
. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] Add Bitrig support

2012-11-16 Thread Eric Blake
. Any comments? ping. Is this project dead? No, but it does see rather sporadic bursts of activity when actual maintainers have time free from their daily routines. Your patch hasn't been forgotten, and gentle pings do help. Alas, I'm not one of the actual maintainers. -- Eric Blake

Re: no .pc file

2012-10-26 Thread Eric Blake
into this problem -- here's the file I used # Copyright 2012 Google Inc. All Rights Reserved. I stopped reading right here. That license is not open, and therefore, it cannot be incorporated into other projects. Are you able to relicense this under an open license? -- Eric Blake ebl

Re: no .pc file

2012-10-20 Thread Eric Blake
files. If you think it should use pkg-config, then please provide patches and rationale for those patches. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: git-version-gen w/o git

2012-10-18 Thread Eric Blake
)\ git submodule --quiet foreach test '$$(git rev-parse $$sha1)' \ = '$$(git merge-base origin $$sha1)' \ -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: Windows Line Endings [WAS Re: [SCM] GNU Libtool branch, master, updated. v2.4.2-273-ge24f183]

2012-10-05 Thread Eric Blake
on the request to install a Windows trial version, and then everything else from downloading the correct iso and installing it is all automated), but haven't tried that yet. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: Can you force the use of the internal argz?

2012-09-10 Thread Eric Blake
, and that's what suppression files were invented for. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature ___ https://lists.gnu.org/mailman/listinfo

Re: Broken workflow

2012-03-16 Thread Eric Blake
of errors. Can anything be done to make things work in a git checkout without having git available after bootstrap? Please? It should already be possible. To skip that check, run: make check gl_public_submodule_commit= -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization

Re: Broken workflow

2012-03-16 Thread Eric Blake
[adding bug-gnulib] On 03/16/2012 04:19 PM, Bob Friesenhahn wrote: On Fri, 16 Mar 2012, Eric Blake wrote: Can anything be done to make things work in a git checkout without having git available after bootstrap? Please? It should already be possible. To skip that check, run: make check

Re: [SCM] GNU Libtool branch, master, updated. v2.4.2-141-g4099c12

2011-12-19 Thread Eric Blake
+ \ ${BASH_VERSINFO[1]}))' /bin/sh: bad substitution -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: FYI: [PATCH] bootstrap: adopt autoconf echo normalization code.

2011-12-19 Thread Eric Blake
would have expected something more like $lt_echo. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: FYI [PATCH] libtool: minimise forks per invocation under bash.

2011-12-19 Thread Eric Blake
Ah, true... I guess I was too focussed on a straight forward one liner, and missed the obvious one. D'oh! I'll switch to that and push presently. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: FYI: [PATCH] libtool: make fork minimisation compatible with dash and zsh.

2011-12-19 Thread Eric Blake
=yes} -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.

2011-12-08 Thread Eric Blake
if there is a reliable forkless way to detect dash. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.

2011-12-08 Thread Eric Blake
for users (or scripts) to export BASH_VERSION to child processes. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.

2011-12-08 Thread Eric Blake
how much difference += makes (especially since it is not shaving on forks, but is reducing O(n^2) malloc behavior for large piece-wise constructions), but do know that XSI variable usage definitely shaves a lot of forkes. As for actual timing comparisons, I have not done any recently. -- Eric

Re: [PATCH 6/7] syntax-check: fix violations and implement sc_prohibit_test_const_follows_var.

2011-11-22 Thread Eric Blake
trend. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 8/7] syntax-check: fix violations and implement sc_useless_quotes_in_case_branch.

2011-11-22 Thread Eric Blake
other shells) are buggy. And I stand corrected - variable expansion in case labels _must_ be quoted if you want to literally match all characters that occur in that variable expansion. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case.

2011-11-21 Thread Eric Blake
the result into func_replace_sysroot_result. func_replace_sysroot () { - case $lt_sysroot:$1 in + case $lt_sysroot:$1 in ?*:$lt_sysroot*) Likewise in the pattern expression; you could further change this to: case $lt_sysroot:$1 in ?*:$lt_sysroot*) -- Eric Blake ebl...@redhat.com+1

Re: [PATCH 5/7] syntax-check: fix violations and implement sc_useless_braces_in_variable_derefs.

2011-11-21 Thread Eric Blake
slightly easier to maintain. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 6/7] syntax-check: fix violations and implement sc_prohibit_test_const_follows_var.

2011-11-21 Thread Eric Blake
(for example, if you did b=$?, then you KNOW that b is a numeric tring with no problematic characters), then you might as well use the more idiomatic comparison of variable to constant. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [PATCH 7/7] syntax-check: fix violations and implement sc_prohibit_sed_s_comma.

2011-11-21 Thread Eric Blake
not, which means a user is more likely to have a filename containing comma than they are to have a filename containing a pipe. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 2/7] syntax-check: fix violations and implement sc_useless_quotes_in_assignment.

2011-11-21 Thread Eric Blake
. It's merely changing: var=$expanded'literal' to the equivalent var=$expanded'literal' where the literal portion includes newline characters. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-16 Thread Eric Blake
implementations that do not accept macros in targets. I suppose we can resuscitate make portability if anyone complains loudly enough. We may want to also ask on the automake list if this is still a real limitation, or whether automake has given up on worrying about this as well. -- Eric Blake

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-16 Thread Eric Blake
. Then it's not NEWS-worthy. It's worth keeping that analysis in the git commit message (as you say, for repo archaeology), but let's limit it to just there, rather than potentially causing users to worry about some perceived loss of portability when they read NEWS. -- Eric Blake ebl...@redhat.com

Re: [PATCH 03/25] syntax-check: fix violations and re-enable sc_cast_of_argument_to_free.

2011-11-15 Thread Eric Blake
-check exception in cfg.mk for the particular files where we define the macros that cast away const). -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value.

2011-11-15 Thread Eric Blake
cast the result of allocation functions (only C lets you get away with going from void* to any other pointer without cast). Are we sure that no one tries to compile libtool with a C++ compiler? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-15 Thread Eric Blake
a setting of _makefile_at_at_check_exceptions in cfg.mk that exempts just @LIBLTDL@. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/4] libtoolize: simplify file-copying and -linking call-graph.

2011-11-15 Thread Eric Blake
-visible change, so we either need to document it in NEWS that it is intentional, or we need to keep providing $TAR (even though we no longer use it) to keep our namespace pollution constant, all so that users upgrading to newer libtool don't complain about an undocumented change. -- Eric Blake ebl

Re: [PATCH 1/3] maint: rename `libltdl/config' directory to standard `build-aux'.

2011-11-01 Thread Eric Blake
config --global diff.renames true'. At any rate, I'm certainly in favor of this series, in the name of easier maintenance, although I didn't review it closely. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: rpath's with colons

2011-10-07 Thread Eric Blake
, for the same reason that using directories with : in their name as part of $PATH is not possible. Sorry. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org ___ https://lists.gnu.org/mailman/listinfo

Re: [PATCH 01/10] Add -shortname option.

2011-04-15 Thread Eric Blake
to specify a short name for a DLL (OS/2 only) Long options should start with --, not -, per GNU coding conventions (gcc is an exception, but libtool should not be). -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: make test with a program that dlopen()s a shared lib peer

2011-03-28 Thread Eric Blake
spawning the wrapped uninstalled program so that it will correctly pick up the .libs/*.so files in preference to anything installed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: How does one specify linking to 64 bit libraries when there is a choice?

2010-12-20 Thread Eric Blake
interest to also ship a config.site variable that defaults --libdir to the appropriate /usr/lib64 location. You should raise this as a bug report with any distro that doesn't make out-of-the-box installation into distro-specific defaults more automatic. -- Eric Blake ebl...@redhat.com+1

Re: How does one specify linking to 64 bit libraries when there is a choice?

2010-12-20 Thread Eric Blake
they passed. Suggestions in improving the example config.site file here: http://www.gnu.org/software/autoconf/manual/autoconf.html#Site-Defaults in order to be more robust to common multi-arch uses are more than welcome. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization

Re: Rebuild menus in the manual.

2010-11-15 Thread Eric Blake
manual symlinks (the existence of the anchor will mean that the old name still goes somewhere in the web). For example, see how autoconf.texi @node Specifying Target Triplets has an @anchor{Specifying Names}. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http

Re: [patch] allow --with-pic to accept package names

2010-10-22 Thread Eric Blake
since the problematic quoting needed fixing, and since that is fixed I don't see any need to do a re-spin just because of this. Agreed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Eric Blake
. Moreover, help2man is something the user is expected to not have to install prior to building Libtool. Is it acceptable instead to use a nested $(MAKE) invocation prior to running help2man to ensure the binary is up-to-date? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Eric Blake
On 09/22/2010 12:22 PM, Ralf Wildenhues wrote: * Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST: $(srcdir)/doc/libtool.1: $(srcdir)/$(auxdir)/ltmain.sh + $(MAKE) libtool $(update_mans) --help-option=--help-all libtool When -jN has been passed, the two makes may both

[SCM] GNU Libtool branch, master, updated. v2.2.10-203-g3122192

2010-09-20 Thread Eric Blake
31221926db25f9d8b34ac5d79412355896f3c70d Author: Eric Blake ebl...@redhat.com Date: Mon Sep 20 12:04:50 2010 -0600 build: ship autobuild.m4, to reduce bootstrap requirement Shipping a copy of autobuild.m4 makes it so that users need not pre-install autobuild just for aclocal to find the macro AB_INIT

[SCM] GNU Libtool branch, master, updated. v2.2.10-204-g6273735

2010-09-20 Thread Eric Blake
627373516c5b0f0228b004eb03a397b782638128 Author: Eric Blake ebl...@redhat.com Date: Mon Sep 20 14:40:09 2010 -0600 maint: drop autobuild requirement * HACKING: Update. Signed-off-by: Eric Blake ebl...@redhat.com --- Summary of changes

[PATCH] build: ship autobuild.m4, to reduce bootstrap requirement

2010-09-20 Thread Eric Blake
-by: Eric Blake ebl...@redhat.com --- Be sure to *not* list autobuild.m4 anywhere else, e.g., in Makefile.am. It is picked up automatically. You can make the AB_INIT call in configure.ac unconditional, but then again, no loss in leaving it as it is. I've tested that 'make dist' does include

Re: [PATCH] build: ship autobuild.m4, to reduce bootstrap requirement

2010-09-20 Thread Eric Blake
On 09/20/2010 12:44 PM, Ralf Wildenhues wrote: * Eric Blake wrote on Mon, Sep 20, 2010 at 08:13:25PM CEST: Shipping a copy of autobuild.m4 makes it so that users need not pre-install autobuild just for aclocal to find the macro AB_INIT. * libltdl/m4/.gitignore: Drop autobuild.m4. * libltdl/m4

[PATCH] maint: drop autobuild requirement

2010-09-20 Thread Eric Blake
* HACKING: Update. Signed-off-by: Eric Blake ebl...@redhat.com --- I'm pushing this under the obvious rule, given that the whole point of my previous patch was to remove this dependency, and since this is a docs-only patch. ChangeLog |3 +++ HACKING |4 +--- 2 files changed, 4

Re: 2.4 Release in 24hrs

2010-09-20 Thread Eric Blake
libtool 2.4 to cygwin: http://cygwin.com/ml/cygwin-apps/2010-09/msg00121.html -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org ___ http://lists.gnu.org/mailman/listinfo/libtool

Re: [PATCH] maint: ship .xz, not .lzma

2010-09-14 Thread Eric Blake
On 09/14/2010 07:58 AM, Eric Blake wrote: * configure.ac (AM_INIT_AUTOMAKE): Prefer better file format. * Makefile.maint (git-release, git-dist, prev-tarball) (new-tarball, diffs): Use correct extension. * HACKING: Update instructions. Hmm - I mentioned it in ChangeLog, but hadn't yet saved

Re: tests: avoid empty AT_DATA contents, for zsh.

2010-09-13 Thread Eric Blake
a nasty bug. Have you reported it to the zsh list yet? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: tests: avoid empty AT_DATA contents, for zsh.

2010-09-13 Thread Eric Blake
On 09/13/2010 08:16 AM, Eric Blake wrote: On 09/12/2010 09:30 AM, Ralf Wildenhues wrote: This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. catfileEOF EOF produces an empty file with sh, but a file containing a newline with zsh, even after 'emulate sh'. autoconf.texi

Re: tests: avoid empty AT_DATA contents, for zsh.

2010-09-13 Thread Eric Blake
[adding bug-autoconf] On 09/13/2010 08:18 AM, Eric Blake wrote: On 09/13/2010 08:16 AM, Eric Blake wrote: On 09/12/2010 09:30 AM, Ralf Wildenhues wrote: This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. catfileEOF EOF produces an empty file with sh, but a file

[PATCH] maint: ship .xz, not .lzma

2010-09-13 Thread Eric Blake
* configure.ac (AM_INIT_AUTOMAKE): Prefer better file format. Signed-off-by: Eric Blake ebl...@redhat.com --- Any objections to this patch? xz is a more robust successor to lzma. ChangeLog|5 + configure.ac |2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git

Re: .cvsignore files still relevant?

2010-09-13 Thread Eric Blake
the cvs repository is read-only, they can't inadvertently turn local files into new vcs files. I removed the .cvsignore files from m4 a while ago, and no one complained. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

git log - changelog [was: [PATCH] Path conversion documentation]

2010-09-02 Thread Eric Blake
anything before the email, but can't add (tiny change) afterwards (in other words, git hard-codes the email address to be last). I'd rather not munge --author, since 'git shortlog' would be noticeably worse with annotations like that. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

Re: git log - changelog

2010-09-02 Thread Eric Blake
On 09/02/2010 03:16 PM, Charles Wilson wrote: On 9/2/2010 5:08 PM, Eric Blake wrote: On 09/02/2010 03:00 PM, Charles Wilson wrote: Two people worked on a single patch, or someone submitted it, and then one of the people with commit access modified the patch slightly. The GCS says you should

Re: [PATCH 1/6] Add --gnulib-version and --news options to announce-gen.

2010-08-31 Thread Eric Blake
. Are you planning on swapping over to gnulib's announce-gen once gnulib is fully integrated? And in the meantime, what good does it do to have a --gnulib-version option if we aren't using gnulib yet? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http

Re: ${var:+quo ted} and similar, inside unquoted here-docs

2010-08-30 Thread Eric Blake
(no word splitting, no filename expansion) than normal, so /bin/sh does NOT have the bug related to bad parameter messages if you omit the quotes. All shells that I had access to reliably gave the same output for: cat EOF ${var-quo ted} EOF quo ted -- Eric Blake ebl...@redhat.com+1-801

Re: ${var:+quo ted} and similar, inside unquoted here-docs

2010-08-30 Thread Eric Blake
)} instead of the if/fi? +AS_BOX([Configuring AC_PACKAGE_TARNAME$timestamp_string AC_PACKAGE_VERSION]) Or, since we know the workaround is to remove the inside here-docs, why not: AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+ (Build:$TIMESTAMP)} AC_PACKAGE_VERSION]) -- Eric Blake

Re: ${var:+quo ted} and similar, inside unquoted here-docs

2010-08-30 Thread Eric Blake
On 08/30/2010 08:57 AM, Eric Blake wrote: [adding bug-bash] On 08/29/2010 08:48 AM, Ralf Wildenhues wrote: With Solaris 10 sh (and others): catEOF ${var-quo ted} EOF quo ted Whereas with bash (and others): quo ted Ouch. New one to me. ksh, zsh, and dash do not echo the quotes, so I'm

Re: ${var:+quo ted} and similar, inside unquoted here-docs

2010-08-30 Thread Eric Blake
to document that : is reliable for null substitutions is reasonable for all shells that support functions. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: tests: skip -Wall -Werror with Tru64 cc in cwrapper test.

2010-08-30 Thread Eric Blake
/foo Invalid flag usage: Wall, -Wx,-option must appear after -_SYSTYPE_SVR4 ld: Usage: ld [options] file [...] stdout: ./../libtool/tests/cwrapper.at:77: exit code was 1, expected 0 Does this have any ramifications for autoconf's AC_LANG_WERROR? -- Eric Blake ebl...@redhat.com+1-801-349-2682

Re: linux to windows cross compile af a dll

2010-08-24 Thread Eric Blake
of it. It seems to be related to http://ricardo.ecn.wfu.edu/~cottrell/cross-gtk/libtool.html Is the hack that is mentioned necessary or is there another solution? This seems like it is a question more appropriate for the libtool list. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization

Re: [PATCH] Autotest 2.62 bug?

2010-08-09 Thread Eric Blake
-- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Support new platform Andestech Platform

2010-08-06 Thread Eric Blake
the corresponding field in your package’s config.sub file. *$ diff -u config.sub.orig config.sub* Please send patches to config.sub upstream to config-patc...@gnu.org, per the directions embedded in config.sub. No need to cc all of these downstream projects when doing so. -- Eric Blake

Re: Support new platform Andestech Platform

2010-08-06 Thread Eric Blake
the corresponding field in your package’s config.sub file. *$ diff -u config.sub.orig config.sub* Please send patches to config.sub upstream to config-patc...@gnu.org, per the directions embedded in config.sub. No need to cc all of these downstream projects when doing so. -- Eric Blake

Re: Fix testsuite errors due to shell quoted parameter expansion issue.

2010-08-04 Thread Eric Blake
to word splitting, then it must result in the two words '' and 'val', not the single word 'val'. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Fix testsuite errors due to shell quoted parameter expansion issue.

2010-08-03 Thread Eric Blake
that requires a space between the ) and {, even though the ) is a metacharacter and should not need trailing space (even Solaris /bin/sh got that right). -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-29 Thread Eric Blake
. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-29 Thread Eric Blake
'as_fn_append () { eval $1+=\$2 }' else as_fn_append () { eval $1=\$$1\$2 } fi # as_fn_append which works just fine with retarded Solaris /bin/sh. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-28 Thread Eric Blake
No, ${parameter:offset} and ${parameter:offset:length} are bash specific not XSI mandated. But we don't need bash-specific hacks. ${parameter#??} serves as a great XSI alternative to ${parameter:2}, and with a (lot) more thought, ${1:1:1} can be written without forks and without bash-isms as:

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-28 Thread Eric Blake
On 06/28/2010 04:19 PM, Ralf Wildenhues wrote: Hi Eric, thanks for the suggestion. I had considered the idea for a second, but failed to see the nontrivial half. * Eric Blake wrote on Mon, Jun 28, 2010 at 02:49:40PM CEST: tmp=${1#?} patt= i=2 while test $i -lt ${#1}; do patt=?$patt

Re: Compiler warning in libltdl/m4/libtool.m4 test program

2010-06-16 Thread Eric Blake
throughout the project. You can check out coreutils' ./configure --enable-gcc-warnings option. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Enable colored Autotest testsuite output if available.

2010-06-14 Thread Eric Blake
in the PREPARE_TESTS diversion a bit, which should be harmless (I checked the diff with current git Autoconf). Thanks, Ralf Enable colored Autotest testsuite output if available. Looks nice to me; in fact, it's probably okay to commit even without autoconf's colored output patch committed yet. -- Eric

Re: MSVC: Find potential libs regardless of case.

2010-06-14 Thread Eric Blake
'' if the `` is interrupted. You want: str=`$EGREP '^(old_library)=' $libdir/libbar.la` eval $str or possibly even $libdir in the first line to be robust to spaces in file names. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: Windows Patches [Was: GNU Libtool 2.2.8 released (stable)]

2010-06-08 Thread Eric Blake
are the day I push upstream, the author date is still my original date of writing the patch. And since 'git log' prefers author date over committer date, that means that I often see out-of-order dates in the git log. So I can go either way. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

  1   2   3   4   >