Re: [PATCH] tests/testsuite.at: Don't use $as_echo

2020-03-16 Thread Eric Blake
HO='printf %s\n'} for tool in ACLOCAL AUTOHEADER AUTOCONF AUTOMAKE AUTORECONF; do if eval \$$tool --version >/dev/null 2>&1; then :; else eval $tool=no; fi done -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH] tests/testsuite.at: Don't use $as_echo

2020-03-16 Thread Eric Blake
rue regardless of this patch, and I did not bother auditing whether we violate that usage pattern anywhere (perhaps we could make $ECHO expand to a function call, where the function loudly complains about $# > 1, if we wanted to make such an audit easier). -- Eric Blake, Principal Soft

Re: [PATCH 2/2] tests: fix helldl rule generation in _LT_DEMO_SETUP macro

2019-03-14 Thread Eric Blake
things. If that fails, m4sh supports quadrigraphs, where you can write @S|@@ to get $@ in the resulting file. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature

Re: Spelling fixes

2017-04-24 Thread Eric Blake
actual patches to this list, rather than making us chase a URL (in particular, github is notorious for requiring the use of non-free client-side javascript for the full experience, while posting a patch to the mailing list frees recipients from having to decline non-free software). -- Eric Blake, Pri

Re: small fix of libtool.m4

2016-05-06 Thread Eric Blake
. I did some > > cfgfile=${ofile}T > trap "$RM \"$cfgfile\"; exit 1" 1 2 15 > -$RM "$cfgfile" > +if test -e "$cfgfile" ; then > + $RM "$cfgfile" > +fi That's a TOCTTOU data race. Wouldn't it be better to just us

Re: [PATCH 1/4] Fix func_echo_all inside configure.

2016-03-10 Thread Eric Blake
nd comparable to what we have a few lines earlier: eval 'cat <<_LTECHO_EOF $[]1 _LTECHO_EOF' } ECHO='func_fallback_echo' fi # func_echo_all arg... # Invoke $ECHO with all args, space-separated. func_echo_all () { $ECHO "$*" -- Eric Blake eblake redhat com+1-919-301-32

Re: [PATCH 3/4] Use POSIX nm to simplify AIX export_symbols_cmds.

2016-03-10 Thread Eric Blake
on no leading space and one space only as separator. No, POSIX states that " " means at least one whitespace (could be multiple; implementations can align at will), and "Δ" means exactly one space character. Since nm didn't use the delta character, the code is correct at looking f

Re: Export AIX TLS symbols

2015-11-25 Thread Eric Blake
On 11/24/2015 09:22 AM, Eric Blake wrote: > On 11/05/2015 10:43 AM, David Edelsohn wrote: >> TLS symbols in AIX display a new, different symbol type in nm output. >> Libtool explicitly creates a list of exported symbols for AIX shared >> libraries using nm and does not

Re: Export AIX TLS symbols

2015-11-24 Thread Eric Blake
uot; weak" } else { print \$ 1 } > } }'\'' | sort -u > $export_symbols' > + _LT_TAGVAR(export_symbols_cmds, $1)='`func_echo_all $NM | $SED -e > '\''s/B\([[^B]]*\)$/P\1/'\''` -PCpgl $libobjs $convenience | awk '\''{ if > (((\$ 2 == "T") || (\$ 2 == "D") || (\$ 2 == "B") || (\$ 2 == "L") || (\$ 2 > == "W") || (\$ 2 == "V") || (\$ 2 == "Z")) && ([substr](\$ 1,1,1) != ".")) { > if ((\$ 2 == "W") || (\$ 2 == "V") || (\$ 2 == "Z")) { print \$ 1 " weak" } > else { print \$ 1 } } }'\'' | sort -u > $export_symbols' > fi > aix_use_runtimelinking=no > > -- > 2.4.3 > I'm not an AIX expert, and have no way to test it, but the explanation is reasonable and I don't see how it can hurt (particularly since the two changes are under "aix[[4-9]]*)" case blocks). I'll go ahead and push this patch (assuming my commit rights are still active) in 24 hours if no one speaks up to the contrary. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] Re: libtool-2.4.2 is fine but libtool-2.4.6 very slow.

2015-09-23 Thread Eric Blake
call to this 'version' > macro gone to infinite recursion (until ENOMEM). So rather s/gone to infinite/enters an infinite/ > re-define all potentially dangerous macros by empty strings, > suggested by Eric Blake. > > While we are on it, merge the macro-"blacklist" w

Re: [PATCH] Re: libtool-2.4.2 is fine but libtool-2.4.6 very slow.

2015-09-19 Thread Eric Blake
e > +# macros of the same name as file included in their bodies - which > +# results in infinite recursion. > +m4_define([m4_include], []) I'd recommend that you use the same fix as gettext, and define ALL of these macros to an empty string, rather than special-casing m4_include as

Re: [PATCH] question mark is extended regex for non-GNU grep

2014-11-21 Thread Eric Blake
\{0,1\} instead of \?. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH v4 1/2] maint.mk: handle missing git with more grace

2012-12-31 Thread Eric Blake
(+), 2 deletions(-) Thanks for resending, and sorry for my abysmal reply delay. This one is now simple enough that I have pushed it. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: git-version-gen w/o git

2012-12-31 Thread Eric Blake
saw this thread; I'll make sure that I'm using v5 for the 2/2 patch. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH v4 2/2] git-version-gen: add --fallback option to use if git is not present

2012-12-31 Thread Eric Blake
. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] Add Bitrig support

2012-11-16 Thread Eric Blake
. Any comments? ping. Is this project dead? No, but it does see rather sporadic bursts of activity when actual maintainers have time free from their daily routines. Your patch hasn't been forgotten, and gentle pings do help. Alas, I'm not one of the actual maintainers. -- Eric Blake

Re: git-version-gen w/o git

2012-10-18 Thread Eric Blake
)\ git submodule --quiet foreach test '$$(git rev-parse $$sha1)' \ = '$$(git merge-base origin $$sha1)' \ -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: Windows Line Endings [WAS Re: [SCM] GNU Libtool branch, master, updated. v2.4.2-273-ge24f183]

2012-10-05 Thread Eric Blake
on the request to install a Windows trial version, and then everything else from downloading the correct iso and installing it is all automated), but haven't tried that yet. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [SCM] GNU Libtool branch, master, updated. v2.4.2-141-g4099c12

2011-12-19 Thread Eric Blake
+ \ ${BASH_VERSINFO[1]}))' /bin/sh: bad substitution -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: FYI: [PATCH] bootstrap: adopt autoconf echo normalization code.

2011-12-19 Thread Eric Blake
would have expected something more like $lt_echo. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: FYI [PATCH] libtool: minimise forks per invocation under bash.

2011-12-19 Thread Eric Blake
Ah, true... I guess I was too focussed on a straight forward one liner, and missed the obvious one. D'oh! I'll switch to that and push presently. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: FYI: [PATCH] libtool: make fork minimisation compatible with dash and zsh.

2011-12-19 Thread Eric Blake
=yes} -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.

2011-12-08 Thread Eric Blake
if there is a reliable forkless way to detect dash. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.

2011-12-08 Thread Eric Blake
for users (or scripts) to export BASH_VERSION to child processes. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] libtool: minimise forks per invocation on cygwin and mingw.

2011-12-08 Thread Eric Blake
how much difference += makes (especially since it is not shaving on forks, but is reducing O(n^2) malloc behavior for large piece-wise constructions), but do know that XSI variable usage definitely shaves a lot of forkes. As for actual timing comparisons, I have not done any recently. -- Eric

Re: [PATCH 6/7] syntax-check: fix violations and implement sc_prohibit_test_const_follows_var.

2011-11-22 Thread Eric Blake
trend. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 8/7] syntax-check: fix violations and implement sc_useless_quotes_in_case_branch.

2011-11-22 Thread Eric Blake
other shells) are buggy. And I stand corrected - variable expansion in case labels _must_ be quoted if you want to literally match all characters that occur in that variable expansion. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case.

2011-11-21 Thread Eric Blake
the result into func_replace_sysroot_result. func_replace_sysroot () { - case $lt_sysroot:$1 in + case $lt_sysroot:$1 in ?*:$lt_sysroot*) Likewise in the pattern expression; you could further change this to: case $lt_sysroot:$1 in ?*:$lt_sysroot*) -- Eric Blake ebl...@redhat.com+1

Re: [PATCH 5/7] syntax-check: fix violations and implement sc_useless_braces_in_variable_derefs.

2011-11-21 Thread Eric Blake
slightly easier to maintain. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 6/7] syntax-check: fix violations and implement sc_prohibit_test_const_follows_var.

2011-11-21 Thread Eric Blake
(for example, if you did b=$?, then you KNOW that b is a numeric tring with no problematic characters), then you might as well use the more idiomatic comparison of variable to constant. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [PATCH 7/7] syntax-check: fix violations and implement sc_prohibit_sed_s_comma.

2011-11-21 Thread Eric Blake
not, which means a user is more likely to have a filename containing comma than they are to have a filename containing a pipe. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 2/7] syntax-check: fix violations and implement sc_useless_quotes_in_assignment.

2011-11-21 Thread Eric Blake
. It's merely changing: var=$expanded'literal' to the equivalent var=$expanded'literal' where the literal portion includes newline characters. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-16 Thread Eric Blake
implementations that do not accept macros in targets. I suppose we can resuscitate make portability if anyone complains loudly enough. We may want to also ask on the automake list if this is still a real limitation, or whether automake has given up on worrying about this as well. -- Eric Blake

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-16 Thread Eric Blake
. Then it's not NEWS-worthy. It's worth keeping that analysis in the git commit message (as you say, for repo archaeology), but let's limit it to just there, rather than potentially causing users to worry about some perceived loss of portability when they read NEWS. -- Eric Blake ebl...@redhat.com

Re: [PATCH 03/25] syntax-check: fix violations and re-enable sc_cast_of_argument_to_free.

2011-11-15 Thread Eric Blake
-check exception in cfg.mk for the particular files where we define the macros that cast away const). -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value.

2011-11-15 Thread Eric Blake
cast the result of allocation functions (only C lets you get away with going from void* to any other pointer without cast). Are we sure that no one tries to compile libtool with a C++ compiler? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.

2011-11-15 Thread Eric Blake
a setting of _makefile_at_at_check_exceptions in cfg.mk that exempts just @LIBLTDL@. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/4] libtoolize: simplify file-copying and -linking call-graph.

2011-11-15 Thread Eric Blake
-visible change, so we either need to document it in NEWS that it is intentional, or we need to keep providing $TAR (even though we no longer use it) to keep our namespace pollution constant, all so that users upgrading to newer libtool don't complain about an undocumented change. -- Eric Blake ebl

Re: [PATCH 1/3] maint: rename `libltdl/config' directory to standard `build-aux'.

2011-11-01 Thread Eric Blake
config --global diff.renames true'. At any rate, I'm certainly in favor of this series, in the name of easier maintenance, although I didn't review it closely. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [PATCH 01/10] Add -shortname option.

2011-04-15 Thread Eric Blake
to specify a short name for a DLL (OS/2 only) Long options should start with --, not -, per GNU coding conventions (gcc is an exception, but libtool should not be). -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: Rebuild menus in the manual.

2010-11-15 Thread Eric Blake
manual symlinks (the existence of the anchor will mean that the old name still goes somewhere in the web). For example, see how autoconf.texi @node Specifying Target Triplets has an @anchor{Specifying Names}. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http

Re: [patch] allow --with-pic to accept package names

2010-10-22 Thread Eric Blake
since the problematic quoting needed fixing, and since that is fixed I don't see any need to do a re-spin just because of this. Agreed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Eric Blake
. Moreover, help2man is something the user is expected to not have to install prior to building Libtool. Is it acceptable instead to use a nested $(MAKE) invocation prior to running help2man to ensure the binary is up-to-date? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Eric Blake
On 09/22/2010 12:22 PM, Ralf Wildenhues wrote: * Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST: $(srcdir)/doc/libtool.1: $(srcdir)/$(auxdir)/ltmain.sh + $(MAKE) libtool $(update_mans) --help-option=--help-all libtool When -jN has been passed, the two makes may both

[PATCH] build: ship autobuild.m4, to reduce bootstrap requirement

2010-09-20 Thread Eric Blake
-by: Eric Blake ebl...@redhat.com --- Be sure to *not* list autobuild.m4 anywhere else, e.g., in Makefile.am. It is picked up automatically. You can make the AB_INIT call in configure.ac unconditional, but then again, no loss in leaving it as it is. I've tested that 'make dist' does include

Re: [PATCH] build: ship autobuild.m4, to reduce bootstrap requirement

2010-09-20 Thread Eric Blake
On 09/20/2010 12:44 PM, Ralf Wildenhues wrote: * Eric Blake wrote on Mon, Sep 20, 2010 at 08:13:25PM CEST: Shipping a copy of autobuild.m4 makes it so that users need not pre-install autobuild just for aclocal to find the macro AB_INIT. * libltdl/m4/.gitignore: Drop autobuild.m4. * libltdl/m4

[PATCH] maint: drop autobuild requirement

2010-09-20 Thread Eric Blake
* HACKING: Update. Signed-off-by: Eric Blake ebl...@redhat.com --- I'm pushing this under the obvious rule, given that the whole point of my previous patch was to remove this dependency, and since this is a docs-only patch. ChangeLog |3 +++ HACKING |4 +--- 2 files changed, 4

Re: [PATCH] maint: ship .xz, not .lzma

2010-09-14 Thread Eric Blake
On 09/14/2010 07:58 AM, Eric Blake wrote: * configure.ac (AM_INIT_AUTOMAKE): Prefer better file format. * Makefile.maint (git-release, git-dist, prev-tarball) (new-tarball, diffs): Use correct extension. * HACKING: Update instructions. Hmm - I mentioned it in ChangeLog, but hadn't yet saved

Re: tests: avoid empty AT_DATA contents, for zsh.

2010-09-13 Thread Eric Blake
a nasty bug. Have you reported it to the zsh list yet? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: tests: avoid empty AT_DATA contents, for zsh.

2010-09-13 Thread Eric Blake
On 09/13/2010 08:16 AM, Eric Blake wrote: On 09/12/2010 09:30 AM, Ralf Wildenhues wrote: This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. catfileEOF EOF produces an empty file with sh, but a file containing a newline with zsh, even after 'emulate sh'. autoconf.texi

Re: tests: avoid empty AT_DATA contents, for zsh.

2010-09-13 Thread Eric Blake
[adding bug-autoconf] On 09/13/2010 08:18 AM, Eric Blake wrote: On 09/13/2010 08:16 AM, Eric Blake wrote: On 09/12/2010 09:30 AM, Ralf Wildenhues wrote: This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. catfileEOF EOF produces an empty file with sh, but a file

[PATCH] maint: ship .xz, not .lzma

2010-09-13 Thread Eric Blake
* configure.ac (AM_INIT_AUTOMAKE): Prefer better file format. Signed-off-by: Eric Blake ebl...@redhat.com --- Any objections to this patch? xz is a more robust successor to lzma. ChangeLog|5 + configure.ac |2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git

git log - changelog [was: [PATCH] Path conversion documentation]

2010-09-02 Thread Eric Blake
anything before the email, but can't add (tiny change) afterwards (in other words, git hard-codes the email address to be last). I'd rather not munge --author, since 'git shortlog' would be noticeably worse with annotations like that. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

Re: git log - changelog

2010-09-02 Thread Eric Blake
On 09/02/2010 03:16 PM, Charles Wilson wrote: On 9/2/2010 5:08 PM, Eric Blake wrote: On 09/02/2010 03:00 PM, Charles Wilson wrote: Two people worked on a single patch, or someone submitted it, and then one of the people with commit access modified the patch slightly. The GCS says you should

Re: [PATCH 1/6] Add --gnulib-version and --news options to announce-gen.

2010-08-31 Thread Eric Blake
. Are you planning on swapping over to gnulib's announce-gen once gnulib is fully integrated? And in the meantime, what good does it do to have a --gnulib-version option if we aren't using gnulib yet? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http

Re: ${var:+quo ted} and similar, inside unquoted here-docs

2010-08-30 Thread Eric Blake
(no word splitting, no filename expansion) than normal, so /bin/sh does NOT have the bug related to bad parameter messages if you omit the quotes. All shells that I had access to reliably gave the same output for: cat EOF ${var-quo ted} EOF quo ted -- Eric Blake ebl...@redhat.com+1-801

Re: ${var:+quo ted} and similar, inside unquoted here-docs

2010-08-30 Thread Eric Blake
)} instead of the if/fi? +AS_BOX([Configuring AC_PACKAGE_TARNAME$timestamp_string AC_PACKAGE_VERSION]) Or, since we know the workaround is to remove the inside here-docs, why not: AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+ (Build:$TIMESTAMP)} AC_PACKAGE_VERSION]) -- Eric Blake

Re: ${var:+quo ted} and similar, inside unquoted here-docs

2010-08-30 Thread Eric Blake
On 08/30/2010 08:57 AM, Eric Blake wrote: [adding bug-bash] On 08/29/2010 08:48 AM, Ralf Wildenhues wrote: With Solaris 10 sh (and others): catEOF ${var-quo ted} EOF quo ted Whereas with bash (and others): quo ted Ouch. New one to me. ksh, zsh, and dash do not echo the quotes, so I'm

Re: ${var:+quo ted} and similar, inside unquoted here-docs

2010-08-30 Thread Eric Blake
to document that : is reliable for null substitutions is reasonable for all shells that support functions. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: tests: skip -Wall -Werror with Tru64 cc in cwrapper test.

2010-08-30 Thread Eric Blake
/foo Invalid flag usage: Wall, -Wx,-option must appear after -_SYSTYPE_SVR4 ld: Usage: ld [options] file [...] stdout: ./../libtool/tests/cwrapper.at:77: exit code was 1, expected 0 Does this have any ramifications for autoconf's AC_LANG_WERROR? -- Eric Blake ebl...@redhat.com+1-801-349-2682

Re: [PATCH] Autotest 2.62 bug?

2010-08-09 Thread Eric Blake
-- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Support new platform Andestech Platform

2010-08-06 Thread Eric Blake
the corresponding field in your package’s config.sub file. *$ diff -u config.sub.orig config.sub* Please send patches to config.sub upstream to config-patc...@gnu.org, per the directions embedded in config.sub. No need to cc all of these downstream projects when doing so. -- Eric Blake

Re: Fix testsuite errors due to shell quoted parameter expansion issue.

2010-08-04 Thread Eric Blake
to word splitting, then it must result in the two words '' and 'val', not the single word 'val'. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Fix testsuite errors due to shell quoted parameter expansion issue.

2010-08-03 Thread Eric Blake
that requires a space between the ) and {, even though the ) is a metacharacter and should not need trailing space (even Solaris /bin/sh got that right). -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-29 Thread Eric Blake
. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-29 Thread Eric Blake
'as_fn_append () { eval $1+=\$2 }' else as_fn_append () { eval $1=\$$1\$2 } fi # as_fn_append which works just fine with retarded Solaris /bin/sh. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-28 Thread Eric Blake
No, ${parameter:offset} and ${parameter:offset:length} are bash specific not XSI mandated. But we don't need bash-specific hacks. ${parameter#??} serves as a great XSI alternative to ${parameter:2}, and with a (lot) more thought, ${1:1:1} can be written without forks and without bash-isms as:

Re: [PATCH] Add an XSI replacement for func_split_short_opt.

2010-06-28 Thread Eric Blake
On 06/28/2010 04:19 PM, Ralf Wildenhues wrote: Hi Eric, thanks for the suggestion. I had considered the idea for a second, but failed to see the nontrivial half. * Eric Blake wrote on Mon, Jun 28, 2010 at 02:49:40PM CEST: tmp=${1#?} patt= i=2 while test $i -lt ${#1}; do patt=?$patt

Re: Compiler warning in libltdl/m4/libtool.m4 test program

2010-06-16 Thread Eric Blake
throughout the project. You can check out coreutils' ./configure --enable-gcc-warnings option. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Enable colored Autotest testsuite output if available.

2010-06-14 Thread Eric Blake
in the PREPARE_TESTS diversion a bit, which should be harmless (I checked the diff with current git Autoconf). Thanks, Ralf Enable colored Autotest testsuite output if available. Looks nice to me; in fact, it's probably okay to commit even without autoconf's colored output patch committed yet. -- Eric

Re: MSVC: Find potential libs regardless of case.

2010-06-14 Thread Eric Blake
'' if the `` is interrupted. You want: str=`$EGREP '^(old_library)=' $libdir/libbar.la` eval $str or possibly even $libdir in the first line to be robust to spaces in file names. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: Avoid autom4te warning about unnamed diversion.

2010-06-07 Thread Eric Blake
that warning. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [SCM] GNU Libtool branch, master, updated. v2.2.7b-4-gaa75582

2010-06-07 Thread Eric Blake
piece available. So it does seem like a better (eventual) home for these recent libtool m4sh scripts. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Repost: [PATCH] [cygwin|mingw] Create UAC manifest files.

2010-03-17 Thread Eric Blake
On 03/16/2010 04:24 AM, Dave Korn wrote: On 16/03/2010 06:17, Ralf Wildenhues wrote: Microsoft @sc{dos} and Windows systems. The @sc{gnu} Should capitalise DOS and GNU. @sc{} does the capitalization for you. This is correct texinfo usage. -- Eric Blake ebl...@redhat.com+1-801

Re: Repost: [PATCH] [cygwin|mingw] Create UAC manifest files.

2010-03-17 Thread Eric Blake
On 03/17/2010 01:23 PM, Dave Korn wrote: On 17/03/2010 17:14, Eric Blake wrote: On 03/16/2010 04:24 AM, Dave Korn wrote: On 16/03/2010 06:17, Ralf Wildenhues wrote: Microsoft @sc{dos} and Windows systems. The @sc{gnu} Should capitalise DOS and GNU. @sc{} does the capitalization for you

Re: [patch] sort 'find' output to enable deterministic builds.

2010-03-15 Thread Eric Blake
ensure deterministic behavior across different default locales? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Happy New Year

2010-01-06 Thread Eric Blake
build-aux/update-copyright from gnulib in order to achieve that action (it also has the benefit of normalizing copyrights into a consistent format). -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net signature.asc Description: OpenPGP digital signature

Re: Remove meaningless conditional op from lt_dlerror.

2009-12-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Peter Rosin on 12/29/2009 7:25 PM: Hi! I'm about to push this too as obvious, I hope I'm not getting too bold... It looks obvious enough; go ahead. - -- Don't work too hard, make some time for fun as well! Eric Blake e

avoid compiler warning

2009-11-02 Thread Eric Blake
a const * instead of an array silences the warning. OK to commit this? From: Eric Blake e...@byu.net Date: Mon, 2 Nov 2009 11:58:28 -0700 Subject: [PATCH] Allow gcc builds with -Wall -Werror. * libltdl/ltdl.c (libext): Declare as pointer rather than array to silence gcc warning. Signed-off

Re: [PATCH, take 3][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-14 Thread Eric Blake
to the root using .. the result may be empty now. if test -z $func_normal_abspath_result ; then func_normal_abspath_result=/ fi break fi done } - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE

Re: [PATCH, take 3][cygwin|mingw] Control where win32 DLLs get installed.

2009-08-14 Thread Eric Blake
to memorize loads of information to write portable shell, but at least these public reviews catch a lot of the pitfalls. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key

Re: [PATCH] [cygwin|mingw] Create UAC manifest files.

2009-06-30 Thread Eric Blake
to func_emit_exe_manifest? Does the .manifest need +x permissions? - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using

Re: Strange LT_INIT behavior

2009-05-22 Thread Eric Blake
to wait 72 hours for anyone else to also chime in with a review, that would be fine with me. If the three days pass without further comment, then consider my review as sufficient. -- Eric Blake

Re: compiler version checks

2009-04-27 Thread Eric Blake
some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Re: Rebase of the pr-msvc-support branch?

2009-01-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Peter Rosin on 1/9/2009 3:11 AM: Den 2009-01-09 03:58 skrev Eric Blake: Check out Bruno Haible's git-merge-changelog, currently in the gnulib repository. It handles rebasing/merging of ChangeLog entries with minimal I don't have

Re: Rebase of the pr-msvc-support branch?

2009-01-08 Thread Eric Blake
for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Re: Fix ltmain.sh

2008-12-19 Thread Eric Blake
that while we are adjusting the line, we might as well wrap to fit in 80 columns. And we need a ChangeLog entry. I'm pushing this: - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public

Re: Avoid accidental disastrous space cleanups

2008-12-19 Thread Eric Blake
, or is it sufficient to entirely delete libtool's IFS initialization in favor of m4sugar's, thanks to Paolo's recent cleanups to use m4sugar as documented? - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin

Re: Fix ltmain.sh

2008-12-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Peter Rosin on 12/19/2008 6:45 AM: Den 2008-12-19 14:10 skrev Eric Blake: *snipped* +Fix copyright notice. +* libltdl/config/ltmain.m4sh: Add missing comma. Oooaa, excellent (and while we are all nitpicking

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

2008-11-23 Thread Eric Blake
fallback used in /bin/sh. I think the last line has to be: ( PATH=/empty FPATH=/empty; export PATH FPATH test X`printf %s $ECHO` = X$ECHO \ || test X`print -r -- $ECHO` = X$ECHO ) }])]) - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

2008-11-22 Thread Eric Blake
='\\\' ECHO=$ECHO$ECHO$ECHO$ECHO$ECHO ECHO=$ECHO$ECHO$ECHO$ECHO$ECHO$ECHO test X`print -r -- $ECHO` = X$ECHO \ || test X`printf %s $ECHO` = X$ECHO]) - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP

Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

2008-11-22 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 11/22/2008 7:31 AM: Maybe a better suggested test would be one that checks for either print or printf (that way, a Solaris machine will let ksh pass the suggested test). Since the overall test is running with stderr

Re: Revenge of the $ECHO. Kill most uses of Xsed.

2008-11-18 Thread Eric Blake
that doesn't eat \. But that doesn't help if you are doing a Solaris-mingw cross. I'm also stumped on thinking of any better alternative, though. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9

Re: help2man missing

2008-11-12 Thread Eric Blake
+) Try './configure --disable-nls', and see if that helps. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG

Re: [PATCH 6/6] use print or printf or cat as $ECHO

2008-11-10 Thread Eric Blake
options, prior to printf %s\\n, during _AS_ECHO_PREPARE. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using

Re: [PATCH 6/6] use printf as $ECHO

2008-11-10 Thread Eric Blake
'. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Re: [PATCH 1/6] Avoid that autom4te complains about unexpanded macros

2008-11-07 Thread Eric Blake
quadrigraphs everywhere. So I'm okay with this patch as-is. That said, it would be nicer if libtoolize could use autom4te --trace rather than sed scripts to learn some of what it scans from configure.ac, but that's unrelated to this patch series... -- Eric Blake

Re: [PATCH 2/6] run sh.test on the m4sh source

2008-11-07 Thread Eric Blake
sources. Looks sane to me (and it gives M4sh a bit more freedom; we've already had patches in the past month where we intentionally added bulk to M4sh to work around libtool's sh.test, and I would like to break that reverse dependency). -- Eric Blake

Re: [PATCH 3/6] use documented m4sh interfaces

2008-11-07 Thread Eric Blake
. This move seems a bit unrelated to the others and a bit more cosmetic in nature, but I guess it's okay as part of this patch. -- Eric Blake

Re: [PATCH 6/6] use printf as $ECHO

2008-11-07 Thread Eric Blake
be based on 'printf', even if a shell has a builtin 'echo' that fills the job. Is it worth still checking whether 'echo' fits the bill, in case it can avoid the forks of lt_func_ECHO? -- Eric Blake

  1   2   3   >