HO='printf %s\n'}
for tool in ACLOCAL AUTOHEADER AUTOCONF AUTOMAKE AUTORECONF; do
if eval \$$tool --version >/dev/null 2>&1; then :; else eval $tool=no; fi
done
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
rue regardless of this patch, and I did not bother auditing whether we
violate that usage pattern anywhere (perhaps we could make $ECHO expand
to a function call, where the function loudly complains about $# > 1, if
we wanted to make such an audit easier).
--
Eric Blake, Principal Soft
things. If
that fails, m4sh supports quadrigraphs, where you can write @S|@@ to get
$@ in the resulting file.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
actual patches to this list, rather
than making us chase a URL (in particular, github is notorious for
requiring the use of non-free client-side javascript for the full
experience, while posting a patch to the mailing list frees recipients
from having to decline non-free software).
--
Eric Blake, Pri
. I did some
>
> cfgfile=${ofile}T
> trap "$RM \"$cfgfile\"; exit 1" 1 2 15
> -$RM "$cfgfile"
> +if test -e "$cfgfile" ; then
> + $RM "$cfgfile"
> +fi
That's a TOCTTOU data race. Wouldn't it be better to just us
nd
comparable to what we have a few lines earlier:
eval 'cat <<_LTECHO_EOF
$[]1
_LTECHO_EOF'
}
ECHO='func_fallback_echo'
fi
# func_echo_all arg...
# Invoke $ECHO with all args, space-separated.
func_echo_all ()
{
$ECHO "$*"
--
Eric Blake eblake redhat com+1-919-301-32
on no leading space and one space only as separator.
No, POSIX states that " " means at least one whitespace (could be
multiple; implementations can align at will), and "Δ" means exactly one
space character. Since nm didn't use the delta character, the code is
correct at looking f
On 11/24/2015 09:22 AM, Eric Blake wrote:
> On 11/05/2015 10:43 AM, David Edelsohn wrote:
>> TLS symbols in AIX display a new, different symbol type in nm output.
>> Libtool explicitly creates a list of exported symbols for AIX shared
>> libraries using nm and does not
uot; weak" } else { print \$ 1 }
> } }'\'' | sort -u > $export_symbols'
> + _LT_TAGVAR(export_symbols_cmds, $1)='`func_echo_all $NM | $SED -e
> '\''s/B\([[^B]]*\)$/P\1/'\''` -PCpgl $libobjs $convenience | awk '\''{ if
> (((\$ 2 == "T") || (\$ 2 == "D") || (\$ 2 == "B") || (\$ 2 == "L") || (\$ 2
> == "W") || (\$ 2 == "V") || (\$ 2 == "Z")) && ([substr](\$ 1,1,1) != ".")) {
> if ((\$ 2 == "W") || (\$ 2 == "V") || (\$ 2 == "Z")) { print \$ 1 " weak" }
> else { print \$ 1 } } }'\'' | sort -u > $export_symbols'
> fi
> aix_use_runtimelinking=no
>
> --
> 2.4.3
>
I'm not an AIX expert, and have no way to test it, but the explanation
is reasonable and I don't see how it can hurt (particularly since the
two changes are under "aix[[4-9]]*)" case blocks).
I'll go ahead and push this patch (assuming my commit rights are still
active) in 24 hours if no one speaks up to the contrary.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
call to this 'version'
> macro gone to infinite recursion (until ENOMEM). So rather
s/gone to infinite/enters an infinite/
> re-define all potentially dangerous macros by empty strings,
> suggested by Eric Blake.
>
> While we are on it, merge the macro-"blacklist" w
e
> +# macros of the same name as file included in their bodies - which
> +# results in infinite recursion.
> +m4_define([m4_include], [])
I'd recommend that you use the same fix as gettext, and define ALL of
these macros to an empty string, rather than special-casing m4_include
as
\{0,1\} instead of \?.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
(+), 2 deletions(-)
Thanks for resending, and sorry for my abysmal reply delay. This one is
now simple enough that I have pushed it.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
saw this thread; I'll make sure
that I'm using v5 for the 2/2 patch.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
.
Any comments?
ping.
Is this project dead?
No, but it does see rather sporadic bursts of activity when actual
maintainers have time free from their daily routines. Your patch hasn't
been forgotten, and gentle pings do help. Alas, I'm not one of the
actual maintainers.
--
Eric Blake
)\
git submodule --quiet foreach test '$$(git rev-parse $$sha1)' \
= '$$(git merge-base origin $$sha1)' \
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
on the request to install a Windows trial version, and
then everything else from downloading the correct iso and installing it
is all automated), but haven't tried that yet.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description
+ \
${BASH_VERSINFO[1]}))'
/bin/sh: bad substitution
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
would have expected something more like $lt_echo.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Ah, true... I guess I was too focussed on a straight forward one liner, and
missed
the obvious one. D'oh! I'll switch to that and push presently.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
=yes}
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
if there is a reliable forkless way to detect dash.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
for users (or scripts) to export BASH_VERSION to
child processes.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
how much difference += makes (especially since
it is not shaving on forks, but is reducing O(n^2) malloc behavior for
large piece-wise constructions), but do know that XSI variable usage
definitely shaves a lot of forkes.
As for actual timing comparisons, I have not done any recently.
--
Eric
trend.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
other
shells) are buggy.
And I stand corrected - variable expansion in case labels _must_ be
quoted if you want to literally match all characters that occur in that
variable expansion.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
the result into func_replace_sysroot_result.
func_replace_sysroot ()
{
- case $lt_sysroot:$1 in
+ case $lt_sysroot:$1 in
?*:$lt_sysroot*)
Likewise in the pattern expression; you could further change this to:
case $lt_sysroot:$1 in
?*:$lt_sysroot*)
--
Eric Blake ebl...@redhat.com+1
slightly easier to maintain.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
(for example, if you did b=$?, then you KNOW that b
is a numeric tring with no problematic characters), then you might as
well use the more idiomatic comparison of variable to constant.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
not, which means a user is more likely to have
a filename containing comma than they are to have a filename containing
a pipe.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
. It's merely changing:
var=$expanded'literal'
to the equivalent
var=$expanded'literal'
where the literal portion includes newline characters.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
implementations that do not accept macros in targets.
I suppose we can resuscitate make portability if anyone complains loudly
enough. We may want to also ask on the automake list if this is still a
real limitation, or whether automake has given up on worrying about this
as well.
--
Eric Blake
.
Then it's not NEWS-worthy. It's worth keeping that analysis in the git
commit message (as you say, for repo archaeology), but let's limit it to
just there, rather than potentially causing users to worry about some
perceived loss of portability when they read NEWS.
--
Eric Blake ebl...@redhat.com
-check exception in cfg.mk for the particular files where we
define the macros that cast away const).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
cast the result of allocation functions (only C lets you get away with
going from void* to any other pointer without cast). Are we sure that
no one tries to compile libtool with a C++ compiler?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
a setting of
_makefile_at_at_check_exceptions in cfg.mk that exempts just @LIBLTDL@.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-visible change, so we either need to
document it in NEWS that it is intentional, or we need to keep providing
$TAR (even though we no longer use it) to keep our namespace pollution
constant, all so that users upgrading to newer libtool don't complain
about an undocumented change.
--
Eric Blake ebl
config
--global diff.renames true'.
At any rate, I'm certainly in favor of this series, in the name of
easier maintenance, although I didn't review it closely.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
to specify a short name for a DLL (OS/2 only)
Long options should start with --, not -, per GNU coding conventions
(gcc is an exception, but libtool should not be).
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description
manual symlinks (the existence of the anchor will mean
that the old name still goes somewhere in the web). For example, see
how autoconf.texi @node Specifying Target Triplets has an
@anchor{Specifying Names}.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http
since the problematic
quoting needed fixing, and since that is fixed I don't see any need
to do a re-spin just because of this.
Agreed.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
. Moreover,
help2man is something the user is expected to not have to install prior
to building Libtool.
Is it acceptable instead to use a nested $(MAKE) invocation prior to
running help2man to ensure the binary is up-to-date?
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt
On 09/22/2010 12:22 PM, Ralf Wildenhues wrote:
* Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST:
$(srcdir)/doc/libtool.1: $(srcdir)/$(auxdir)/ltmain.sh
+ $(MAKE) libtool
$(update_mans) --help-option=--help-all libtool
When -jN has been passed, the two makes may both
-by: Eric Blake ebl...@redhat.com
---
Be sure to *not* list autobuild.m4 anywhere else, e.g., in Makefile.am.
It is picked up automatically. You can make the AB_INIT call in
configure.ac unconditional, but then again, no loss in leaving it as it
is.
I've tested that 'make dist' does include
On 09/20/2010 12:44 PM, Ralf Wildenhues wrote:
* Eric Blake wrote on Mon, Sep 20, 2010 at 08:13:25PM CEST:
Shipping a copy of autobuild.m4 makes it so that users need not
pre-install autobuild just for aclocal to find the macro AB_INIT.
* libltdl/m4/.gitignore: Drop autobuild.m4.
* libltdl/m4
* HACKING: Update.
Signed-off-by: Eric Blake ebl...@redhat.com
---
I'm pushing this under the obvious rule, given that the whole point
of my previous patch was to remove this dependency, and since this
is a docs-only patch.
ChangeLog |3 +++
HACKING |4 +---
2 files changed, 4
On 09/14/2010 07:58 AM, Eric Blake wrote:
* configure.ac (AM_INIT_AUTOMAKE): Prefer better file format.
* Makefile.maint (git-release, git-dist, prev-tarball)
(new-tarball, diffs): Use correct extension.
* HACKING: Update instructions.
Hmm - I mentioned it in ChangeLog, but hadn't yet saved
a nasty bug. Have you reported it to the zsh list yet?
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
On 09/13/2010 08:16 AM, Eric Blake wrote:
On 09/12/2010 09:30 AM, Ralf Wildenhues wrote:
This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD.
catfileEOF
EOF
produces an empty file with sh, but a file containing a newline with
zsh, even after 'emulate sh'. autoconf.texi
[adding bug-autoconf]
On 09/13/2010 08:18 AM, Eric Blake wrote:
On 09/13/2010 08:16 AM, Eric Blake wrote:
On 09/12/2010 09:30 AM, Ralf Wildenhues wrote:
This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD.
catfileEOF
EOF
produces an empty file with sh, but a file
* configure.ac (AM_INIT_AUTOMAKE): Prefer better file format.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Any objections to this patch? xz is a more robust successor to lzma.
ChangeLog|5 +
configure.ac |2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git
anything before the email, but can't add (tiny change)
afterwards (in other words, git hard-codes the email address to be
last). I'd rather not munge --author, since 'git shortlog' would be
noticeably worse with annotations like that.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt
On 09/02/2010 03:16 PM, Charles Wilson wrote:
On 9/2/2010 5:08 PM, Eric Blake wrote:
On 09/02/2010 03:00 PM, Charles Wilson wrote:
Two people worked on a single patch, or someone submitted it, and then
one of the people with commit access modified the patch slightly. The
GCS says you should
.
Are you planning on swapping over to gnulib's announce-gen once gnulib
is fully integrated? And in the meantime, what good does it do to have
a --gnulib-version option if we aren't using gnulib yet?
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http
(no word
splitting, no filename expansion) than normal, so /bin/sh does NOT have
the bug related to bad parameter messages if you omit the quotes.
All shells that I had access to reliably gave the same output for:
cat EOF
${var-quo ted}
EOF
quo ted
--
Eric Blake ebl...@redhat.com+1-801
)}
instead of the if/fi?
+AS_BOX([Configuring AC_PACKAGE_TARNAME$timestamp_string AC_PACKAGE_VERSION])
Or, since we know the workaround is to remove the inside here-docs,
why not:
AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+ (Build:$TIMESTAMP)}
AC_PACKAGE_VERSION])
--
Eric Blake
On 08/30/2010 08:57 AM, Eric Blake wrote:
[adding bug-bash]
On 08/29/2010 08:48 AM, Ralf Wildenhues wrote:
With Solaris 10 sh (and others):
catEOF
${var-quo ted}
EOF
quo ted
Whereas with bash (and others):
quo ted
Ouch. New one to me. ksh, zsh, and dash do not echo the quotes, so I'm
to
document that : is reliable for null substitutions is reasonable for all
shells that support functions.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
/foo
Invalid flag usage: Wall, -Wx,-option must appear after -_SYSTYPE_SVR4
ld: Usage: ld [options] file [...]
stdout:
./../libtool/tests/cwrapper.at:77: exit code was 1, expected 0
Does this have any ramifications for autoconf's AC_LANG_WERROR?
--
Eric Blake ebl...@redhat.com+1-801-349-2682
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
the corresponding field in your package’s config.sub
file.
*$ diff -u config.sub.orig config.sub*
Please send patches to config.sub upstream to config-patc...@gnu.org,
per the directions embedded in config.sub. No need to cc all of these
downstream projects when doing so.
--
Eric Blake
to word splitting, then it must result in the
two words '' and 'val', not the single word 'val'.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
that requires a space between the ) and {, even
though the ) is a metacharacter and should not need trailing space (even
Solaris /bin/sh got that right).
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
'as_fn_append ()
{
eval $1+=\$2
}'
else
as_fn_append ()
{
eval $1=\$$1\$2
}
fi # as_fn_append
which works just fine with retarded Solaris /bin/sh.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP
No, ${parameter:offset} and ${parameter:offset:length} are bash specific
not XSI mandated.
But we don't need bash-specific hacks.
${parameter#??} serves as a great XSI alternative to ${parameter:2},
and with a (lot) more thought, ${1:1:1} can be written without forks
and without bash-isms as:
On 06/28/2010 04:19 PM, Ralf Wildenhues wrote:
Hi Eric,
thanks for the suggestion. I had considered the idea for a second, but
failed to see the nontrivial half.
* Eric Blake wrote on Mon, Jun 28, 2010 at 02:49:40PM CEST:
tmp=${1#?}
patt=
i=2
while test $i -lt ${#1}; do
patt=?$patt
throughout
the project. You can check out coreutils' ./configure
--enable-gcc-warnings option.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
in the PREPARE_TESTS diversion a bit, which
should be harmless (I checked the diff with current git Autoconf).
Thanks,
Ralf
Enable colored Autotest testsuite output if available.
Looks nice to me; in fact, it's probably okay to commit even without
autoconf's colored output patch committed yet.
--
Eric
'' if the `` is interrupted. You want:
str=`$EGREP '^(old_library)=' $libdir/libbar.la`
eval $str
or possibly even $libdir in the first line to be robust to spaces in
file names.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description
that warning.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
piece available. So it does seem like a better (eventual) home
for these recent libtool m4sh scripts.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 03/16/2010 04:24 AM, Dave Korn wrote:
On 16/03/2010 06:17, Ralf Wildenhues wrote:
Microsoft @sc{dos} and Windows systems. The @sc{gnu}
Should capitalise DOS and GNU.
@sc{} does the capitalization for you. This is correct texinfo usage.
--
Eric Blake ebl...@redhat.com+1-801
On 03/17/2010 01:23 PM, Dave Korn wrote:
On 17/03/2010 17:14, Eric Blake wrote:
On 03/16/2010 04:24 AM, Dave Korn wrote:
On 16/03/2010 06:17, Ralf Wildenhues wrote:
Microsoft @sc{dos} and Windows systems. The @sc{gnu}
Should capitalise DOS and GNU.
@sc{} does the capitalization for you
ensure deterministic behavior across
different default locales?
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
build-aux/update-copyright from
gnulib in order to achieve that action (it also has the benefit of
normalizing copyrights into a consistent format).
--
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
signature.asc
Description: OpenPGP digital signature
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Peter Rosin on 12/29/2009 7:25 PM:
Hi!
I'm about to push this too as obvious, I hope I'm not getting too bold...
It looks obvious enough; go ahead.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e
a const * instead of an array silences
the warning. OK to commit this?
From: Eric Blake e...@byu.net
Date: Mon, 2 Nov 2009 11:58:28 -0700
Subject: [PATCH] Allow gcc builds with -Wall -Werror.
* libltdl/ltdl.c (libext): Declare as pointer rather than array to
silence gcc warning.
Signed-off
to the root using .. the result may be empty now.
if test -z $func_normal_abspath_result ; then
func_normal_abspath_result=/
fi
break
fi
done
}
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE
to memorize loads of information to write portable shell,
but at least these public reviews catch a lot of the pitfalls.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key
to
func_emit_exe_manifest? Does the .manifest need +x permissions?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using
to wait
72 hours for anyone else to also chime in with a review, that would be fine
with me. If the three days pass without further comment, then consider my
review as sufficient.
--
Eric Blake
some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Peter Rosin on 1/9/2009 3:11 AM:
Den 2009-01-09 03:58 skrev Eric Blake:
Check out Bruno Haible's git-merge-changelog, currently in the gnulib
repository. It handles rebasing/merging of ChangeLog entries with
minimal
I don't have
for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
that while we are adjusting
the line, we might as well wrap to fit in 80 columns. And we need a
ChangeLog entry. I'm pushing this:
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public
, or is it sufficient to
entirely delete libtool's IFS initialization in favor of m4sugar's, thanks
to Paolo's recent cleanups to use m4sugar as documented?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Peter Rosin on 12/19/2008 6:45 AM:
Den 2008-12-19 14:10 skrev Eric Blake:
*snipped*
+Fix copyright notice.
+* libltdl/config/ltmain.m4sh: Add missing comma.
Oooaa, excellent (and while we are all nitpicking
fallback used in /bin/sh. I think the last line
has to be:
( PATH=/empty FPATH=/empty; export PATH FPATH
test X`printf %s $ECHO` = X$ECHO \
|| test X`print -r -- $ECHO` = X$ECHO ) }])])
- --
Don't work too hard, make some time for fun as well!
Eric Blake [EMAIL PROTECTED
='\\\'
ECHO=$ECHO$ECHO$ECHO$ECHO$ECHO
ECHO=$ECHO$ECHO$ECHO$ECHO$ECHO$ECHO
test X`print -r -- $ECHO` = X$ECHO \
|| test X`printf %s $ECHO` = X$ECHO])
- --
Don't work too hard, make some time for fun as well!
Eric Blake [EMAIL PROTECTED]
-BEGIN PGP
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 11/22/2008 7:31 AM:
Maybe a better suggested test would be one that checks for either print or
printf (that way, a Solaris machine will let ksh pass the suggested test).
Since the overall test is running with stderr
that doesn't eat \. But
that doesn't help if you are doing a Solaris-mingw cross. I'm also
stumped on thinking of any better alternative, though.
- --
Don't work too hard, make some time for fun as well!
Eric Blake [EMAIL PROTECTED]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9
+)
Try './configure --disable-nls', and see if that helps.
- --
Don't work too hard, make some time for fun as well!
Eric Blake [EMAIL PROTECTED]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG
options, prior to printf %s\\n, during _AS_ECHO_PREPARE.
- --
Don't work too hard, make some time for fun as well!
Eric Blake [EMAIL PROTECTED]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using
'.
- --
Don't work too hard, make some time for fun as well!
Eric Blake [EMAIL PROTECTED]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
quadrigraphs everywhere. So
I'm okay with this patch as-is.
That said, it would be nicer if libtoolize could use autom4te --trace rather
than sed scripts to learn some of what it scans from configure.ac, but that's
unrelated to this patch series...
--
Eric Blake
sources.
Looks sane to me (and it gives M4sh a bit more freedom; we've already had
patches in the past month where we intentionally added bulk to M4sh to work
around libtool's sh.test, and I would like to break that reverse dependency).
--
Eric Blake
.
This move seems a bit unrelated to the others and a bit more cosmetic in
nature, but I guess it's okay as part of this patch.
--
Eric Blake
be based on 'printf', even if a shell has a builtin 'echo' that
fills the job. Is it worth still checking whether 'echo' fits the bill, in
case it can avoid the forks of lt_func_ECHO?
--
Eric Blake
1 - 100 of 202 matches
Mail list logo