Re: [PATCH 4/6] Rewrite bootstrap script for consistency with our other shell code.

2010-08-31 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:18AM CEST: > * bootstrap: Add a proper option parsing loop, along with copies > of supporting functions from `libltd/m4/getopt.m4sh' and > `libltdl/m4/general.m4sh'. > Reformat header comments to work with `func_help' and > `func_version'. > (my

Re: [PATCH 3/6] Support missing detached signatures, like gnulib implementation.

2010-08-31 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:17AM CEST: > * libltdl/config/announce-gen.m4sh (func_print_locations): Don't > bail out or print garbage when trying to find the size of a > non-existent file. OK thanks. While you're at it, TAB before space is a little less likely to be garb

Re: [PATCH 2/6] Fix partial commit support.

2010-08-31 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:16AM CEST: > * clcommit.m4sh (func_commit): Commit only staged files instead > of passing `-a' when no file list was given on the command line. FWIW, I've never used clcommit since we moved to git; I just use plain git. Here's a c

Re: [PATCH 1/6] Add --gnulib-version and --news options to announce-gen.

2010-08-31 Thread Ralf Wildenhues
Hello Gary, this is a review, not an approval. * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:15AM CEST: > * libltdl/config/announce-gen.m4sh: Add support for gnulib > announce-gen options, previously missing from our m4sh > implementation, and enforce specifying --gnulib-version when > `g

Re: Backport non-gnulib dependent parts of my use-gnulib topic branch

2010-08-31 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:14AM CEST: > Okay to push? For your information: I'm getting more reluctant to approve your patches, based on how much I expect we have to fix regressions stemming from them later on, when you are not present. Please state if and

Re: Extract the archive name from the .la file and use $AR (not ar).

2010-08-31 Thread Ralf Wildenhues
* Peter Rosin wrote on Tue, Aug 31, 2010 at 07:21:34PM CEST: > Den 2010-08-31 19:11 skrev Ralf Wildenhues: > > libtool --mode=link $CC ... -o libfoo.a baz.o libbar.a > > > > should be adding baz.o and all objects in libbar.a to libfoo.a, i.e., it > > should extrac

Re: Extract the archive name from the .la file and use $AR (not ar).

2010-08-31 Thread Ralf Wildenhues
* Peter Rosin wrote on Tue, Aug 31, 2010 at 07:09:30PM CEST: > Den 2010-08-31 19:04 skrev Ralf Wildenhues: > > * Peter Rosin wrote on Tue, Aug 31, 2010 at 11:49:18AM CEST: > >> Pushing as attached, expected fail on Cygwin/ar and unexpected pass on > >> MSYS/lib just as b

Re: Extract the archive name from the .la file and use $AR (not ar).

2010-08-31 Thread Ralf Wildenhues
* Peter Rosin wrote on Tue, Aug 31, 2010 at 11:49:18AM CEST: > Pushing as attached, expected fail on Cygwin/ar and unexpected pass on > MSYS/lib just as before. Why does it pass with MSYS/lib? Does lib expand the individual objects of the passed library-to-add? If no, then can we make the test s

Re: Fix archiver @FILE support test

2010-08-31 Thread Ralf Wildenhues
* Peter Rosin wrote on Tue, Aug 31, 2010 at 06:54:28PM CEST: > Den 2010-08-31 18:49 skrev Ralf Wildenhues: > > AC_TRY_EVAL already redirects stderr in config.log, and that was quite > > helpful when debugging the macro recently. Why not, instead of your > > patch,

Re: Fix archiver @FILE support test

2010-08-31 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Tue, Aug 31, 2010 at 01:44:00PM CEST: > Microsoft lib prints a failure message though. I assume other > archivers are not unlikely to also do so... > > Pushing the attached as obvious. AC_TRY_EVAL already redirects stderr in config.log, and that was quite helpful

Re: tests: skip -Wall -Werror with Tru64 cc in cwrapper test.

2010-08-30 Thread Ralf Wildenhues
* Eric Blake wrote on Mon, Aug 30, 2010 at 11:13:22PM CEST: > On 08/30/2010 03:06 PM, Ralf Wildenhues wrote: > >Don't you love those permissive compilers where only the linker fails > >later with: > > > >libtool: link: /opt/fsw/bin/cc -g -Wall -Werror -o .libs/

tests: skip -Wall -Werror with Tru64 cc in cwrapper test.

2010-08-30 Thread Ralf Wildenhues
http://autobuild.josefsson.org/libtool/log-201008291316239205000.txt Don't you love those permissive compilers where only the linker fails later with: libtool: link: /opt/fsw/bin/cc -g -Wall -Werror -o .libs/usea usea.o ./.libs/liba.so -rpath /foo Invalid flag usage: Wall, -Wx,-option must appea

tests: avoid getopt-m4sh failures when autom4te is not available.

2010-08-30 Thread Ralf Wildenhues
See testsuite failures 1-5 here: http://autobuild.josefsson.org/libtool/log-20100829151228732.txt I'm applying an obvious fix: Cheers, Ralf tests: avoid getopt-m4sh failures when autom4te is not available. * tests/getopt-m4sh.at (_LT_AT_GETOPT_M4SH_SETUP): Check $M4SH --versi

tests: mark 'syntax of .la files' as XFAIL, expose failure.

2010-08-30 Thread Ralf Wildenhues
Starting to go through the test logs that I posted (I sent a patch for autobuild to have them sorted by mode as well), here's a testsuite addition Bob has suggested before: let's not rely on Solaris printf to catch NULL return from lt_dlerror for us; also, mark the test as XFAIL as the bug itself i

Re: [PATCH] Path conversion documentation

2010-08-30 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Aug 30, 2010 at 09:45:00PM CEST: > On 8/30/2010 2:48 PM, Ralf Wildenhues wrote: > >Looks fine to me too, only one or two issues are not markup or typo > >nits (but I have been very nitpicky below). > > I expected that. This is really only a fi

Re: ${var:+"quo ted"} and similar, inside unquoted here-docs

2010-08-30 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Mon, Aug 30, 2010 at 05:09:05PM CEST: > On 08/29/2010 08:59 AM, Ralf Wildenhues wrote: > >-AS_BOX([Configuring AC_PACKAGE_TARNAME${TIMESTAMP:+" (Build:$TIMESTAMP)"} > >AC_PACKAGE_VERSION]) > >+timestamp_string= &g

Re: Extract the archive name from the .la file and use $AR (not ar).

2010-08-30 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Aug 30, 2010 at 03:25:30PM CEST: > The archive-in-archive.at test uses ar "blindly". It also assumes that > the "old archive" of libfoo.la is named libfoo.a, but both that's not > portable. See attached patch. OK with nits below. I don't like that we don't h

Re: [PATCH] Path conversion documentation

2010-08-30 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Mon, Aug 30, 2010 at 01:50:12AM CEST: > * doc/libtool.texi (Platform quirks): Add new subsections > 'Cross compiling' and 'File name/path conversion'. > OK to push? Looks fine to me too, only one or two issues are not markup or typo nits (but I have been ver

Re: [PATCH 0/3]: Another go at LTO support

2010-08-29 Thread Ralf Wildenhues
Test results for this patch series more or less look the way they did with the old proposed patch, and more reflect the state of binutils and GCC than that of Libtool I would say; there might be ways to work around them though, dunno yet. 1) With -flto in CC, CXX, F77, FC and LDFLAGS, I get failur

[PATCH 0/3]: Another go at LTO support

2010-08-29 Thread Ralf Wildenhues
OK, so the issues I had with was both changing output_verbose_link_cmd to something that might work worse in a number of setups, and on the other hand having a reliable way to get at postdeps in presence of -flto or -fwhopr or so. Here'

[PATCH 3/3] Support GCC LTO on GNU/Linux.

2010-08-29 Thread Ralf Wildenhues
] : Likewise. (_LT_SYS_HIDDEN_LIBDEPS): Ignore files matching *.lto.o. * NEWS: Update. Signed-off-by: Ralf Wildenhues --- ChangeLog | 12 NEWS |1 + libltdl/config/ltmain.m4sh |4 +++- libltdl/m4/libtool.m4 |8 +--- 4 files changed

[PATCH 2/3] Disable GCC LTO for verbose library extraction.

2010-08-29 Thread Ralf Wildenhues
* libltdl/m4/libtool.m4 (_LT_SYS_HIDDEN_LIBDEPS): Temporarily append -fno-lto or -fno-whopr to CFLAGS if CC or CFLAGS (which are substituted with the per-language variables here) contain -flto or match -fwhopr*, respectively. Signed-off-by: Ralf Wildenhues --- ChangeLog |6

Re: proposed autobuild_mode naming scheme

2010-08-29 Thread Ralf Wildenhues
Hello Simon, * Ralf Wildenhues wrote on Sun, Aug 22, 2010 at 08:44:57PM CEST: > > configure: autobuild mode... default > [...] > > Autobuild uses a few strings to categorize log results: package version, > $build, $host, hostname, time and date, and a so-called "mode"

[PATCH 1/3] Save and restore CFLAGS properly inside libtool.m4 macros.

2010-08-29 Thread Ralf Wildenhues
restore $CFLAGS, and override it with per-language flags, so that in case output_verbose_link_cmd uses $CFLAGS, the right flags are used. Signed-off-by: Ralf Wildenhues --- ChangeLog | 10 ++ libltdl/m4/libtool.m4 | 31 +++ 2 files changed, 33

Re: ${var:+"quo ted"} and similar, inside unquoted here-docs

2010-08-29 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sun, Aug 29, 2010 at 04:48:34PM CEST: > With Solaris 10 sh (and others): > > cat < ${var-"quo ted"} > EOF > > "quo ted" I'm working around the issue in Libtool like this. Cheers, Ralf Work arou

${var:+"quo ted"} and similar, inside unquoted here-docs

2010-08-29 Thread Ralf Wildenhues
With Solaris 10 sh (and others): cat

Re: [PATCH] [cygwin] Minor sysroot fixups.

2010-08-28 Thread Ralf Wildenhues
* Charles Wilson wrote on Sun, Aug 29, 2010 at 12:27:15AM CEST: > libltdl/m4/libtool.m4 (_LT_WITH_SYSROOT): Fix typo. > tests/sysroot.at: Search also for crt0.o to accommodate cygwin. > --- > Somehow this patch got dropped when the sysroot branch > was merged. Rebased against master... > > OK to

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Ralf Wildenhues
* Charles Wilson wrote on Sat, Aug 28, 2010 at 05:31:57PM CEST: > On 8/28/2010 11:31 AM, Ralf Wildenhues wrote: > > * Charles Wilson wrote on Sat, Aug 28, 2010 at 05:13:38PM CEST: > >> On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: > >>> [__WINDOWS__, _

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sat, Aug 28, 2010 at 05:13:38PM CEST: > On 8/28/2010 9:21 AM, Ralf Wildenhues wrote: > > [__WINDOWS__, __CYGWIN__, _WIN32_WCE]: Define LT_DLSYM_CONST > I don't think __WINDOWS__ is the correct symbol; that is only defined by > Watcom

Re: [PATCH 4/4] Add $pic_flag to archive_cmds and archive_expsym_cmds.

2010-08-28 Thread Ralf Wildenhues
[ <http://thread.gmane.org/gmane.comp.gnu.libtool.general/10794/focus=9770> ] * Ralf Wildenhues wrote on Sun, Apr 04, 2010 at 10:57:04AM CEST: > * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS) > > [GNU ld, netbsd]: Add $pic_flag if ELF. > [GNU ld, solaris]: Likewise. >

Re: [PATCH 3/4] Uniform const'ness of symlist variable lt_preloaded_symbols.

2010-08-28 Thread Ralf Wildenhues
Since the question asked in: * Ralf Wildenhues wrote on Tue, Jun 29, 2010 at 06:49:39AM CEST: > > <http://thread.gmane.org/gmane.comp.gnu.libtool.general/10794/focus=9769>. was now answered in <http://thread.gmane.org/gmane.comp.gnu.libtool.general/11039/focus=11045> I fee

Re: [PATCH 1/4] Support GCC LTO on GNU/Linux.

2010-08-28 Thread Ralf Wildenhues
I'm going to at least try to see how much we can get Libtool in shape for LTO. This one should be easy: * Dave Korn wrote on Wed, Apr 07, 2010 at 01:13:08AM CEST: > On 06/04/2010 22:39, Paolo Bonzini wrote: > > On 04/06/2010 04:01 AM, Charles Wilson wrote: > >>> > As for whether it would get

Fix quoting in non-XSI func_xform, for IRIX sh.

2010-08-28 Thread Ralf Wildenhues
Another regression from some post-2.2.10 patch I didn't bother to track down now. Hopefully fixes all of the 20-some failures I'm seeing on IRIX ... Pushed to master. Cheers, Ralf Fix quoting in non-XSI func_xform, for IRIX sh. * libltdl/config/ltmain.m4sh (func_xform): Remove spur

Fix archiver @FILE support test

2010-08-28 Thread Ralf Wildenhues
Yay for IRIX ar handing back a useless exit status: configure:6118: checking for archiver @FILE support configure:6135: cc -c -g conftest.c >&5 configure:6135: $? = 0 configure:6138: ar cru libconftest.a @conftest.lst ar: Error: @conftest.lst cannot open configure:6141: $? = 0 configure:6152: res

Re: Fix AC_LANG_PROGRAM warnings from git Autoconf.

2010-08-28 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sat, Aug 28, 2010 at 09:25:41AM CEST: > On 28 Aug 2010, at 14:10, Ralf Wildenhues wrote: > > OK to commit? > > I didn't test, but by inspection everything looks good from here. > > >Fix AC_LANG_PROGRAM warnings from git Autoc

Re: ChangeLog entries for sysroot branch, and merge

2010-08-28 Thread Ralf Wildenhues
Good afternoon Gary, * Gary V. Vaughan wrote on Sat, Aug 28, 2010 at 10:29:01AM CEST: > On 28 Aug 2010, at 15:16, Ralf Wildenhues wrote: > > > OK to apply to the sysroot branch and merge? > > I'm not sure if I need to ask, so I'll leave a bit of time for comments

ChangeLog entries for sysroot branch, and merge

2010-08-28 Thread Ralf Wildenhues
, Ralf diff --git a/ChangeLog b/ChangeLog index 5f5e23a..9ba1343 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,91 @@ +2010-08-22 Ralf Wildenhues

Fix AC_LANG_PROGRAM warnings from git Autoconf.

2010-08-28 Thread Ralf Wildenhues
This patch should fix all warnings emitted by git Autoconf due to the new AC_LANG_PROGRAM check: http://lists.gnu.org/archive/html/autoconf-patches/2010-08/msg00080.html As far as I can see, the first two instances were fairly benign *before* the Autoconf patch, but the last one exposed a real bug

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-28 Thread Ralf Wildenhues
* Charles Wilson wrote on Sat, Aug 28, 2010 at 08:57:04AM CEST: > This is just an FYI. The take-away here is that I did go ahead and > rename all the functions to > func_convert_{file|path}_X_to_Y > and moved them to just before func_mode_compile. I changed all comments > and function names to

git and branches (was: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6))

2010-08-27 Thread Ralf Wildenhues
Maybe a bit more explanation: * Ralf Wildenhues wrote on Sat, Aug 28, 2010 at 07:22:42AM CEST: > * Charles Wilson wrote on Sat, Aug 28, 2010 at 07:10:25AM CEST: > > On 8/27/2010 3:47 PM, Ralf Wildenhues wrote: > > > * Charles Wilson wrote on Fri, Aug 27, 2010 at 08:49:24PM CE

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-27 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sat, Aug 28, 2010 at 07:10:25AM CEST: > On 8/27/2010 3:47 PM, Ralf Wildenhues wrote: > > * Charles Wilson wrote on Fri, Aug 27, 2010 at 08:49:24PM CEST: > >> However, once I have finished the requested changes above and the > >> re

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-27 Thread Ralf Wildenhues
I'm ok with everything in this.

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-27 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Aug 27, 2010 at 10:23:31PM CEST: > Original: > real25m3.886s > user6m24.620s > sys 11m13.787s > > With the functions moved ahead of func_mode_compile: > real24m34.235s > user6m30.590s > sys 11m23.878s > > So, when compiling about 325 source

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-27 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Aug 27, 2010 at 08:49:24PM CEST: > On 8/26/2010 4:18 PM, Ralf Wildenhues wrote: > >> + lt_cv_to_host_path_cmd="$(to_host_path_cmd)" > > > > I don't understand why this change should be necessary. In your > > testing

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-27 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Aug 27, 2010 at 08:17:15PM CEST: > On 8/27/2010 2:10 PM, Ralf Wildenhues wrote: > > Another questions regarding this patch: > > > > Do you know whether all of the conversion functions are idempotent > > (f(f(x)) = f(x))? IOW, when th

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-27 Thread Ralf Wildenhues
Another questions regarding this patch: Do you know whether all of the conversion functions are idempotent (f(f(x)) = f(x))? IOW, when the user passes names already converted, do we do the right things in all cases? Thanks, Ralf

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-27 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Aug 27, 2010 at 06:35:31PM CEST: > It appears the problem is that the mdemo{2}_static.exe tests don't work, > when mdemo{2}-conf.test is used. They DO work when mdemo-static.test is > used (there is no mdemo2-static.test). > > Now, this is a little disturbing, since

parallel-tests branch merged

2010-08-26 Thread Ralf Wildenhues
I've merged parallel-tests now, to allow test buildds to pick it up. I was going to start with the sysroot branch, but that needs ChangeLog entries written still, which I don't have time for *right* now ... Cheers, Ralf

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-26 Thread Ralf Wildenhues
is not good enough for your needs, not one "it cannot be done". Please don't get into the habit of saying that something cannot be done if there's just another TODO item which you (understandably) may not want to fix yourself. That is very confusing in a technical discussion.

Re: [PATCH] [cygwin|mingw]: Add cross-compile support to cwrapper (take 6)

2010-08-26 Thread Ralf Wildenhues
Hi Charles, first off, a few general comments: thanks for doing this work, thanks for being so persistent. Then, please just move the new functions where Peter needs them, if they really need moving, that is. Then, since the next few days might see a number of commits: in case your redone patch

Re: [PATCH] Allow the use of a listing file if the archiver supports it.

2010-08-24 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Tue, Aug 24, 2010 at 11:48:50AM CEST: > Hmmm, your cross-post on bug-libtool@ and gcc@ made me look > one more time at this, and I realized that I have previously > completely misunderstood the failure. There isn't any piecewise > linking ($CC -r -o) going on in th

Re: [PATCH: sysroot branch] [cygwin] Minor sysroot fixups.

2010-08-22 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Aug 23, 2010 at 07:35:59AM CEST: > libltdl/m4/libtool.m4 (_LT_WITH_SYSROOT): Fix typo. > tests/sysroot.at: Search also for crt0.o to accomodate cygwin. accommodate > Discovered a few minor issues while testing with linux->cygwin > cross compiler. How did the crt2.o

Re: [PATCH] Fix syntax for cygwin-cross

2010-08-22 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Mon, Aug 23, 2010 at 07:18:18AM CEST: > libltdl/m4/argz.m4: Add quotes around variable, which > may contain the multiword value 'guessing no'. OK, thanks! > This should probably also go upstream to gnulib. Yes, will sync there later. Cheers, Ralf

Re: autobuild logs for Libtool

2010-08-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Mon, Aug 23, 2010 at 05:04:18AM CEST: > On 23 Aug 2010, at 01:38, Ralf Wildenhues wrote: > > * Ralf Wildenhues wrote on Mon, Aug 09, 2010 at 08:50:55PM CEST: > > OK to commit? > > My other comments on this thread notwithstanding, please go ahead...

proposed autobuild_mode naming scheme (was: autobuild logs for Libtool)

2010-08-22 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sun, Aug 22, 2010 at 08:38:19PM CEST: > configure: autobuild mode... default [...] Autobuild uses a few strings to categorize log results: package version, $build, $host, hostname, time and date, and a so-called "mode" which my patch sets with the $a

Re: autobuild logs for Libtool

2010-08-22 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Aug 09, 2010 at 08:50:55PM CEST: > I think Libtool should use Autobuild, <http://josefsson.org/autobuild/>, > for testing, and developers as well as users should be encouraged to > send results to the gathering site. It's about time I try to ge

Re: [PATCH v2 0/3] sysroot followup patches

2010-08-22 Thread Ralf Wildenhues
Hi Charles, I agree with all you wrote. * Charles Wilson wrote on Sun, Aug 22, 2010 at 08:05:33PM CEST: > Anyway, this test series will take DAYS to complete...so I'd appreciate > it if the review (or, the reviewER's refresh/reread of the OLD reviews, > whose links I will post) could commence con

Re: [PATCH 1/6] Require Automake 1.11.1 for Libtool, enable color-tests.

2010-08-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sun, Aug 22, 2010 at 05:24:05PM CEST: > On 22 Aug 2010, at 22:09, Ralf Wildenhues wrote: > > # consider using shallow clones here, to ease server load. > > git clone git://git.sv.gnu.org/autoconf.git > > git clone git://git.sv.gnu.org/automake.git &

Re: [PATCH v2 0/3] sysroot followup patches

2010-08-22 Thread Ralf Wildenhues
Hello Paolo, Charles, I think these are the leftover items, right? * Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:02AM CEST: > 4) patch for old libtool, to not barf on '=' > 6) support in libltdl for '=' in .la files 7) doc updates. I think the sysroot branch is in pretty good shape and all

Re: using git Libtool with Autoconf 2.59, Automake 1.9.6

2010-08-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sat, Aug 21, 2010 at 12:27:12PM CEST: > On 21 Aug 2010, at 12:06, Ralf Wildenhues wrote: > > I tried running the Libtool test suites with old Autoconf 2.59 and > > Automake 1.9.6 (on GNU/Linux only) after 'autoreconf -fvi'-ing all > >

Re: [PATCH 1/6] Require Automake 1.11.1 for Libtool, enable color-tests.

2010-08-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sun, Aug 22, 2010 at 04:17:49PM CEST: > I'm still a little worried that the Automake 1.11.1 requirement > might leak out of 'required to bootstrap' and into 'required to > use' however, which is why I'd like to test it some more to > convince myself that I'm just being pa

Re: [PATCH 5/6] Adjust docs for renaming and for parallel-tests.

2010-08-22 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sun, Aug 22, 2010 at 12:57:31PM CEST: > * README: Update example TESTS setting. > * README.alpha: Likewise. > * NEWS: Update. > * doc/libtool.texi (Test descriptions): Update for test renaming, > adjust descriptions accordingly. > --- a/NEWS > +++ b

Re: [PATCH 0/6] Allow to run the old testsuite in parallel

2010-08-22 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sun, Aug 22, 2010 at 04:05:12PM CEST: > On 22 Aug 2010, at 17:55, Ralf Wildenhues wrote: > > I've had this patch series half-done in my tree for a long time, > > and have now taken the time to fix the missing bits. > > Do you have

[PATCH 5/6] Adjust docs for renaming and for parallel-tests.

2010-08-22 Thread Ralf Wildenhues
* README: Update example TESTS setting. * README.alpha: Likewise. * NEWS: Update. * doc/libtool.texi (Test descriptions): Update for test renaming, adjust descriptions accordingly. Signed-off-by: Ralf Wildenhues --- ChangeLog|6 ++ NEWS | 10 +++ README

[PATCH 4/6] Update VERBOSE handling for parallel-tests driver.

2010-08-22 Thread Ralf Wildenhues
-suite.log summary file. Signed-off-by: Ralf Wildenhues --- ChangeLog|9 + README | 14 +- README.alpha | 14 +- doc/libtool.texi | 14 +- tests/defs.m4sh |9 ++--- 5 files changed, 26 insertions(+), 34 deletions(-)

[PATCH 3/6] Enable parallel-tests test driver for the old testsuite.

2010-08-22 Thread Ralf Wildenhues
_inst-*' directories as well. Prompted by suggestion from Bob Friesenhahn. Signed-off-by: Ralf Wildenhues --- ChangeLog | 14 +++ Makefile.am | 297 +-- configure.ac| 30 ++- tests/defs.m4sh |2 +- 4 files changed, 287

[PATCH 6/6] check-interactive and check-noninteractive for both testsuites.

2010-08-22 Thread Ralf Wildenhues
targets. (check-interactive, check-noninteractive): Depend on the respective targets for the old and the new test suites. * doc/libtool.texi (Test descriptions): Simplify description about check-interactive and check-noninteractive. Add index entries. * NEWS: Update. Signed-off-by: Ralf Wildenhues

[PATCH 2/6] New alias scripts for old tests run more than once.

2010-08-22 Thread Ralf Wildenhues
-static-unst.test, tests/tagdemo-shared-exec.test, tests/tagdemo-shared-make.test, tests/tagdemo-static-exec.test, tests/tagdemo-static-make.test, tests/tagdemo-undef-exec.test, tests/tagdemo-undef-make.test: New files. Signed-off-by: Ralf Wildenhues --- The new tests currently depend on the fact that

[PATCH 1/6] Require Automake 1.11.1 for Libtool, enable color-tests.

2010-08-22 Thread Ralf Wildenhues
Autoconf 2.59 and Automake 1.9.6. Signed-off-by: Ralf Wildenhues --- ChangeLog| 11 +++ Makefile.am |9 - bootstrap| 14 -- configure.ac | 10 ++ 4 files changed, 13 insertions(+), 31 deletions(-) diff --git a/ChangeLog b/ChangeLog index

[PATCH 0/6] Allow to run the old testsuite in parallel

2010-08-22 Thread Ralf Wildenhues
I've had this patch series half-done in my tree for a long time, and have now taken the time to fix the missing bits. The old testsuite is, well, old, and unloved. But it also covers crucial aspects, so as long as there's no rewrite, we might as well enable some parallelism and have a decent log

Re: Tidy and fix clean and distclean rules for old testsuite.

2010-08-22 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sun, Aug 22, 2010 at 06:46:55AM CEST: > On 22 Aug 2010, at 11:23, Ralf Wildenhues wrote: > > > > OK to apply? > > Well, it is an improvement over what we have, so... sure, go ahead. Thanks for the quick review! > However, I continue

Tidy and fix clean and distclean rules for old testsuite.

2010-08-21 Thread Ralf Wildenhues
In the Libtool tree, invoking 'make distclean' after 'make clean' or before 'make check' has ever run, fails because there are no Makefiles in the old test subdirectories (and automake's distclean rule looks at DIST_SUBDIRS not SUBDIRS). This patch fixes this long-standing error by creating stub M

Re: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit

2010-08-21 Thread Ralf Wildenhues
* Rainer Tammer wrote on Sat, Aug 07, 2010 at 09:35:56AM CEST: > I have added one additional patch (as I did for the last run): > > # diff /daten/source/libtool-2.2.11a/tests/defs.in defs.in [...] > < # On AIX, shared libraries remain loaded in memory after use if they > < # are world-readable, un

Re: versioning test on AIX

2010-08-21 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sat, Aug 07, 2010 at 12:30:01AM CEST: > The test tries to ensure that with an incompatible library upgrade, > programs previously linked against the old library still work. This > usually works on systems where different major versions of a library > have di

Re: [PATCH] Do not absolutize paths eagerly.

2010-08-20 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Fri, Aug 20, 2010 at 06:34:58AM CEST: > * libltdl/config/ltmain.m4sh (func_resolve_sysroot): Partly > revert v2.2.10-83-gc45a288: Do not absolutize path here, only do > sysroot replacement. > (func_mode_link): Adjust. > Fixes AIX testsuite regression.

using git Libtool with Autoconf 2.59, Automake 1.9.6

2010-08-20 Thread Ralf Wildenhues
I tried running the Libtool test suites with old Autoconf 2.59 and Automake 1.9.6 (on GNU/Linux only) after 'autoreconf -fvi'-ing all but the toplevel directory with those tools. I was surprised to see that it still works more or less! :-) This patch fixes the fall-out. OK to push if the use of

Bump copyright years in manual.

2010-08-19 Thread Ralf Wildenhues
Pushed as obvious. Bump copyright years in manual. * doc/libtool.texi: Bump copyright years. diff --git a/doc/libtool.texi b/doc/libtool.texi index f508015..d0eaec4 100644 --- a/doc/libtool.texi +++ b/doc/libtool.texi @@ -26,7 +26,7 @@ @ifnottex This file documents GNU Libtool @val

Remove superfluous dependency in Makefile.am.

2010-08-19 Thread Ralf Wildenhues
Pushed as obvious: there is nothing that would generate demo-conf.test and I couldn't find any reason for the test result to depend on the libtool script in particular. Cheers, Ralf Remove superfluous dependency in Makefile.am. * Makefile.am (tests/demo-conf.test): Remove dependency

Don't hide the table of contents in the manual.

2010-08-19 Thread Ralf Wildenhues
This moves the ToC to the beginning in the PDF output, and IMHO looks so much nicer. Will push soon unless somebody complains. Thanks Bruno! Ralf Don't hide the table of contents in the manual. * doc/libtool.texi: Move the table of contents to the beginning. Prompted by patch fr

[PATCH] Do not absolutize paths eagerly.

2010-08-19 Thread Ralf Wildenhues
AM, Ralf Wildenhues wrote: > >Why does this function absolutize paths that have nothing to do with > >sysroot, even in-tree deplib paths? > >Is there a deeper reason in this? If yes, there should probably be a > >test which is fixed by it. > > It's a bug, I think

Re: [RFT PATCH v4 3/8] teach libtool -L= and -R=

2010-08-18 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Thu, Aug 19, 2010 at 06:58:31AM CEST: > * Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:29PM CEST: > > +# func_resolve_sysroot PATH > > +# Change PATH to an absolute path or replace a leading = with a > > +# sysroot. Store the result into func_r

Re: [RFT PATCH v4 3/8] teach libtool -L= and -R=

2010-08-18 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:29PM CEST: > * libltdl/config/ltmain.m4sh (func_resolve_sysroot): New. > (func_mode_link): Always pass result of stripping -L and -R to > func_resolve_sysroot before using it. Remove absolute path expansion > when func_resolve_sysroot subsumes it

Re: [PATCH v2 0/3] sysroot followup patches

2010-08-16 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Aug 16, 2010 at 10:50:21PM CEST: > On 8/16/2010 4:42 PM, Ralf Wildenhues wrote: > > > > Can you run > > VERBOSE=yes $srcdir/tests/fcdemo-conf.test; echo $? > > > > and post the output of that? VERBOSE=debug is even more info

Re: [PATCH v2 0/3] sysroot followup patches

2010-08-16 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Aug 16, 2010 at 10:27:46PM CEST: > Taking all of this together, I wonder if a good approach might be the > following: libltdl replaces the '=' with the value of the environment > variable LIBLTDL_SYSROOT. So usually -- with this variable empty -- '=' > is just stripp

Re: [PATCH v2 0/3] sysroot followup patches

2010-08-16 Thread Ralf Wildenhues
Hi Charles, Paolo, * Charles Wilson wrote on Mon, Aug 16, 2010 at 05:12:03PM CEST: > On 8/12/2010 9:23 PM, Paolo Bonzini wrote: > > These cover bullets 3/5 of Charles' list: > > > > 3) issue with '# Collect and forward deplibs of preopened libtool libs' > >In progress? Anything? > > 4,5) > >

Re: [PATCH v2 4/4] add libtool --mode=finish mode for sysroot

2010-08-16 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Sun, Aug 15, 2010 at 03:46:06PM CEST: > On 08/13/2010 12:59 AM, Ralf Wildenhues wrote: > >Erm, you should be mentioning the files you change in your log entries, > >and Libtool also doesn't auto-generate its ChangeLog (yet), so you need > >that, t

Re: [PATCH] improve code for sysroot --mode=finish

2010-08-16 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Sun, Aug 15, 2010 at 06:57:18PM CEST: > Here are the improvements you suggested. I'll send a patch for > sed_make_literal_regex soon. > > Ok? Yes, with the nit addressed. Thanks! Ralf > * libltdl/config/ltmain.m4sh (func_mode_finish): Change sysroot_regex > and sysroot

Re: [PATCH] Factor the sed command used to make a regex from a literal.

2010-08-16 Thread Ralf Wildenhues
eneral.m4sh (sed_make_literal_regex): New. > * libltdl/config/ltmain.m4sh (func_generate_dlsyms, FWIW, I think GCS style is * file-name (function-name) (function-name, ...): i.e., close and reopen parens at EOL. > func_cygming_dll_for_implib_fallback_core): Use it. Suggested > by Ralf Wildenhues.

Re: [PATCH 0/2] sysroot patches followup

2010-08-14 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Thu, Aug 12, 2010 at 11:28:31PM CEST: > Thanks. So far, with a merge of sysroot to master, I see one regression > on AIX with runtimelinking (configure LDFLAGS=-Wl,-brtl) and a different > one on Solaris, The Solaris issue is shown below and is actual

Re: [PATCH 0/2] sysroot patches followup

2010-08-14 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Thu, Aug 12, 2010 at 11:28:31PM CEST: > Thanks. So far, with a merge of sysroot to master, I see one regression > on AIX with runtimelinking (configure LDFLAGS=-Wl,-brtl) OK so this one really is a regression with the patch series. bisect converges at the

Re: MSVC status

2010-08-13 Thread Ralf Wildenhues
* Christopher Hulbert wrote on Fri, Aug 13, 2010 at 01:45:37PM CEST: > Is there interest (besides mine) in libtool being able to use native > Windows compilers from cygwin. I just find cygwin easier to > use/maintain than mingw/msys. > > In the branch I had been working on, I defined the libtool v

Re: [PATCH v2 4/4] add libtool --mode=finish mode for sysroot

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:06AM CEST: > --- Erm, you should be mentioning the files you change in your log entries, and Libtool also doesn't auto-generate its ChangeLog (yet), so you need that, too, also for all the other patches in the sysroot branch. Sorry for not notic

Re: [PATCH v2 3/4] reorganize parsing of --mode=finish arguments

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:05AM CEST: > * libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for > directories and *.la files. Add .la files for all directories. Ah, there's another nit. > --- a/libltdl/config/ltmain.m4sh > +++ b/libltdl/config/ltmain.m4sh >

Re: [PATCH v2 3/4] reorganize parsing of --mode=finish arguments

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:05AM CEST: > * libltdl/config/ltmain.m4sh (func_mode_finish): Split arguments for > directories and *.la files. Add .la files for all directories. OK if you fix the log entry. IIUC the last sentence is wrong. Thanks, Ralf

Re: [PATCH v2 2/4] fix sysroot handling for deplibs of preopened libtool libs

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:04AM CEST: > * libltdl/config/ltmain.m4sh: Pass $dependency_libs of preopened libtool > through func_resolve_sysroot. This looks ok, but is it covered in the testsuite? (If not, I can try to do it later, but at least would like to be sure we make

Re: [PATCH v2 1/4] fix sysroot tests to pass on Fedora 13

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Fri, Aug 13, 2010 at 03:23:03AM CEST: > * tests/sysroot.at: Link $prefix/include into the sysroot as well, as > required by newer GCC. Obviously. Thanks! Ralf

Re: [PATCH 0/2] sysroot patches followup

2010-08-12 Thread Ralf Wildenhues
* Paolo Bonzini wrote on Thu, Aug 12, 2010 at 06:12:15AM CEST: > Hi, I pushed the first 8 sysroot patches to refs/heads/sysroot on > Savannah. Thanks. So far, with a merge of sysroot to master, I see one regression on AIX with runtimelinking (configure LDFLAGS=-Wl,-brtl) and a different one on So

Re: [PATCH] Allow the use of a listing file if the archiver supports it.

2010-08-12 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Thu, Aug 12, 2010 at 03:28:57PM CEST: > This is a patch that makes use of @FILE support in the > archiver, if the archiver supports it. That makes linking > succeed for long command lines when using MSVC, as MSVC > can't do piecewise linking (-r -o) which is the cu

Re: How to maintain compatibility with Automake.

2010-08-10 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Tue, Aug 10, 2010 at 11:15:21AM CEST: > * Gary V. Vaughan wrote on Tue, Aug 10, 2010 at 11:09:33AM CEST: > > On 10 Aug 2010, at 15:19, Peter Rosin wrote: > > > m4_defun([AM_PROG_AR], > > > [AC_CHECK_TOOLS(AR, [ar], false) > > >

Re: How to maintain compatibility with Automake.

2010-08-10 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Aug 10, 2010 at 11:09:33AM CEST: > On 10 Aug 2010, at 15:19, Peter Rosin wrote: > > m4_defun([AM_PROG_AR], > > [AC_CHECK_TOOLS(AR, [ar], false) > > : ${AR=ar} > > AC_SUBST([AR])dnl > > ])# AM_PROG_AR > > ]) > > Just like that! NAK. I don't have time to explain now

<    1   2   3   4   5   6   7   8   9   10   >