Re: [libvirt] [PATCH] iptables: don't log command probe failures

2014-03-11 Thread Ján Tomko
On 03/10/2014 11:00 PM, Eric Blake wrote: Commit b9dd878f caused a regression in iptables interaction by logging non-zero status at a higher level than VIR_INFO. Revert that portion of the commit, as well as adding a comment explaining why we check the status ourselves. Reported by Nehal J

[libvirt] [PATCH v3] qemu: cleanup tap devices on FreeBSD

2014-03-11 Thread Roman Bogorodskiy
We have to explicitly destroy TAP devices on FreeBSD because they're not freed after being closed, otherwise we end up with orphaned TAP devices after destroying a domain. --- src/qemu/qemu_process.c | 14 -- src/util/virnetdevtap.h | 6 ++ 2 files changed, 18 insertions(+), 2

Re: [libvirt] [PATCH v2] qemu: cleanup tap devices on FreeBSD

2014-03-11 Thread Roman Bogorodskiy
Laine Stump wrote: This is also needed if virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_NETWORK (since a libvirt virtual network is implemented using a bridge device connected to tap devices - see the corresponding create a tap device code for a network device at

Re: [libvirt] [PATCH] qemu: Forbid sgio support for SCSI generic host device

2014-03-11 Thread Osier Yang
On 07/03/14 22:23, Osier Yang wrote: The kernel didn't support the unprivileged SGIO for SCSI generic device finally, and since it's unknow whether the way to support unprivileged SGIO for SCSI generic device will be similar as for SCSI block device or not, even it's simliar (I.e. via sysfs, for

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-11 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/07/2014 02:54 AM, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: On 03/05/2014 07:36 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added

Re: [libvirt] [PATCH] BZ1072677: Avoid freeing of 0 file descriptor

2014-03-11 Thread Michal Privoznik
On 09.03.2014 00:29, Stefan Berger wrote: From: Stefan Berger stef...@linux.vnet.ibm.com Avoid the freeing of an array of zero file descriptors in case of error. Introduce a macro VIR_INIT_N_FD to initialize such an array's elements to -1. Signed-off-by: Stefan Berger

Re: [libvirt] [PATCH] Load CPU map from builddir when run uninstalled

2014-03-11 Thread Jiri Denemark
On Mon, Mar 10, 2014 at 12:31:00 -0600, Eric Blake wrote: On 03/10/2014 09:26 AM, Jiri Denemark wrote: When libvirtd is run from a build directory without being installed, it should not depend on files from a libvirt package installed in the system. Not only because there may not be any

Re: [libvirt] [PATCH v2 3/3] Cache result of QEMU capabilities extraction

2014-03-11 Thread Daniel P. Berrange
On Mon, Mar 10, 2014 at 12:50:20PM -0600, Eric Blake wrote: On 03/10/2014 10:54 AM, Daniel P. Berrange wrote: Extracting capabilities from QEMU takes a notable amount of time when all QEMU binaries are installed. Each system emulator needs about 200-300ms multiplied by 26 binaries == ~5-8

[libvirt] [PATCH] tests: Distribute securityselinuxhelperdata

2014-03-11 Thread Jiri Denemark
Signed-off-by: Jiri Denemark jdene...@redhat.com --- Notes: Pushed as a build-breaker since 'make distcheck' fails without this patch. tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 5c1f420..3267ad3 100644 ---

Re: [libvirt] [PATCH] libxl: support sexpr in native to XML conversion

2014-03-11 Thread Daniel P. Berrange
On Mon, Mar 10, 2014 at 11:52:50AM -0600, Jim Fehlig wrote: Supporting sexpr in connectDomainXMLFromNative in the libxl driver adds flexibility for users importing legacy Xen configuration into libvirt. E.g. this patch allows importing previous xend-managed domains from

[libvirt] [libvirt-java] [PATCH] Implement equals and hashCode methods for Connect and Domain

2014-03-11 Thread Claudio Bley
Signed-off-by: Claudio Bley cb...@av-test.de --- src/main/java/org/libvirt/Connect.java | 39 + src/main/java/org/libvirt/Domain.java | 52 ++- src/test/java/org/libvirt/TestJavaBindings.java |4 ++ 3 files changed, 94 insertions(+),

[libvirt] [java] Re: [PATCH 29/65] Implement equals and hashCode methods for Connect and Domain

2014-03-11 Thread Claudio Bley
At Fri, 21 Feb 2014 10:56:36 +, Daniel P. Berrange wrote: This causes a violation of the hashCode API contract. Per the java api docs for java.lang.Object Of course, right you're. I've change the implementation of the hashCode methods accordingly in order to take the URI and UUID into

Re: [libvirt] [PATCH v2 2/3] Change QEMU capabilities cache to check ctime instead of mtime

2014-03-11 Thread Christophe Fergeau
On Mon, Mar 10, 2014 at 04:54:29PM +, Daniel P. Berrange wrote: Debian's package manager will preserve mtime timesatmp on binaries There's a 'timestamp' typo here if this hasn't been pushet yet. Christophe pgpPyhpgrqjpZ.pgp Description: PGP signature -- libvir-list mailing list

[libvirt] [PATCH] nwfilter: Fix rule priority problem

2014-03-11 Thread Stefan Berger
From: Stefan Berger stef...@linux.vnet.ibm.com Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1072292 Fix a problem related to rule priorities that did not allow to have rules applied that had a higher priority than the chain they were in. In this case the chain did not exist yet when the

Re: [libvirt] Suspending access to opened/active /dev/nodes during application runtime

2014-03-11 Thread David Herrmann
Hi On Fri, Mar 7, 2014 at 7:45 PM, Lukasz Pawelczyk hav...@gmail.com wrote: Problem: Has anyone thought about a mechanism to limit/remove an access to a device during an application runtime? Meaning we have an application that has an open file descriptor to some /dev/node and depending on

[libvirt] [PATCH] Added example script on how to convert LXC container config

2014-03-11 Thread Cédric Bosdonnat
--- Makefile.am | 2 +- configure.ac | 1 + examples/lxcconvert/Makefile.am | 19 ++ examples/lxcconvert/virt-lxc-convert | 67 4 files changed, 88 insertions(+), 1 deletion(-) create mode 100644

[libvirt] How to apply for Google Summer of Code

2014-03-11 Thread Stefan Hajnoczi
Dear students, Applications for Google Summer of Code opened on Monday, 10th of March and will continue until Friday, 21st of March. The common question we are getting is How do I apply? :). Here is the application checklist: 1. Choose a project idea and get in touch with the mentor. The

Re: [libvirt] Get disk size for disk type=network

2014-03-11 Thread Eric Blake
On 03/10/2014 07:09 PM, Qiang Fu wrote: Hi, In the output of virsh dumpxml command the disk section is as follows: disk type='network' device='disk' driver name='qemu' type='raw' cache='writeback'/ auth username='svl-cc1-cinder-user' secret type='ceph'

[libvirt] Google Summer of Code 2014 - Rewriting Virtual-Box Driver

2014-03-11 Thread prashanth sunder
Hello, I am applying for the project idea Rewriting Virtual-Box Driver suggested by Michal Privoznik(mpriv...@redhat.com) in the Qemu ideas page ( http://wiki.qemu.org/Google_Summer_of_Code_2014). In the short span of time that I had after my discussion with Mr. Privoznik, the current Virtual

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-11 Thread Eric Blake
On 03/11/2014 03:04 AM, Markus Armbruster wrote: '-cdrom filename' could easily be re-written [in a future qemu version] to use QemuOpts with an implied parameter name (we've done that elsewhere, such as for '-machine'). Incompatible change for funny filenames: -cdrom you,break=me.

[libvirt] [PATCH] Fix sec label setup when attaching to QEMU processes

2014-03-11 Thread Daniel P. Berrange
When attaching to a QEMU process, the def-seclabels array is going to be empty. The qemuProcessAttach method must thus populate it with data for the security drivers. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/qemu/qemu_process.c | 19 +-- 1 file changed, 17

Re: [libvirt] [PATCH] Fix sec label setup when attaching to QEMU processes

2014-03-11 Thread Eric Blake
On 03/11/2014 09:17 AM, Daniel P. Berrange wrote: When attaching to a QEMU process, the def-seclabels array is going to be empty. The qemuProcessAttach method must thus populate it with data for the security drivers. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH] Fix sec label setup when attaching to QEMU processes

2014-03-11 Thread Daniel P. Berrange
On Tue, Mar 11, 2014 at 10:06:37AM -0600, Eric Blake wrote: On 03/11/2014 09:17 AM, Daniel P. Berrange wrote: When attaching to a QEMU process, the def-seclabels array is going to be empty. The qemuProcessAttach method must thus populate it with data for the security drivers.

Re: [libvirt] Google Summer of Code 2014 - Rewriting Virtual-Box Driver

2014-03-11 Thread Laine Stump
On 03/11/2014 08:35 AM, prashanth sunder wrote: Hello, I am applying for the project idea Rewriting Virtual-Box Driver suggested by Michal Privoznik(mpriv...@redhat.com mailto:mpriv...@redhat.com) in the Qemu ideas page (http://wiki.qemu.org/Google_Summer_of_Code_2014). In the short span

Re: [libvirt] [lxc-devel] [systemd-devel] Suspending access to opened/active /dev/nodes during application runtime

2014-03-11 Thread Oren Laadan
On Fri, Mar 7, 2014 at 3:51 PM, Lukasz Pawelczyk hav...@gmail.com wrote: On 7 Mar 2014, at 20:24, Lennart Poettering mzerq...@0pointer.de wrote: On Fri, 07.03.14 19:45, Lukasz Pawelczyk (hav...@gmail.com) wrote: Problem: Has anyone thought about a mechanism to limit/remove an access to

[libvirt] [PATCH v2] nwfilter: Deactivate iptables MAC address check where needed

2014-03-11 Thread Stefan Berger
From: Stefan Berger stef...@linux.vnet.ibm.com Recent Linux iptables (3.11.7) refuses to create iptables MAC address check rules using -m mac --mac-source addr where previous versions still allowed it. So we now need to deactivate the filtering rules for when the incoming traffic is filtered

[libvirt] [PATCH] storage: Fix bugs in VIR_APPEND_ELEMENT series

2014-03-11 Thread John Ferlan
From commit id 'd53bbfd1' Found one core and one possible memory leak. Core seen during local virt-test/tp_libvirt run for the vol_create_from test. The memory leak was seen by inspection during a review of all VIR_APPEND_ELEMENT changes In

Re: [libvirt] [PATCH v2] nwfilter: Deactivate iptables MAC address check where needed

2014-03-11 Thread Eric Blake
On 03/11/2014 01:33 PM, Stefan Berger wrote: From: Stefan Berger stef...@linux.vnet.ibm.com Recent Linux iptables (3.11.7) refuses to create iptables MAC address check rules using -m mac --mac-source addr where previous versions still allowed it. So we now need to deactivate the filtering

Re: [libvirt] [PATCH] storage: Fix bugs in VIR_APPEND_ELEMENT series

2014-03-11 Thread Eric Blake
On 03/11/2014 01:54 PM, John Ferlan wrote: From commit id 'd53bbfd1' Found one core and one possible memory leak. Core seen during local virt-test/tp_libvirt run for the vol_create_from test. The memory leak was seen by inspection during a review of all VIR_APPEND_ELEMENT changes In

Re: [libvirt] [PATCH] libxl: support sexpr in native to XML conversion

2014-03-11 Thread Jim Fehlig
Daniel P. Berrange wrote: On Mon, Mar 10, 2014 at 11:52:50AM -0600, Jim Fehlig wrote: Supporting sexpr in connectDomainXMLFromNative in the libxl driver adds flexibility for users importing legacy Xen configuration into libvirt. E.g. this patch allows importing previous xend-managed

Re: [libvirt] Get disk size for disk type=network

2014-03-11 Thread Qiang Fu
Hi Eric, Thanks for your reply. In this case the openstack is integrated with ceph and the volume in ceph is attached to the VMs in openstack. The VM is able to access the volume using the authentication included in the disk section. So there will not be any pool on the KVM side. I tried 'virsh

[libvirt] [PATCH v3] nwfilter: Deactivate iptables MAC address check where needed

2014-03-11 Thread Stefan Berger
From: Stefan Berger stef...@linux.vnet.ibm.com Recent Linux iptables (3.11.7) refuses to create iptables MAC address check rules using -m mac --mac-source addr where previous versions still allowed it. So we now need to deactivate the filtering rules for when the incoming traffic is filtered

Re: [libvirt] [PATCH] iptables: don't log command probe failures

2014-03-11 Thread Eric Blake
On 03/11/2014 12:34 AM, Ján Tomko wrote: On 03/10/2014 11:00 PM, Eric Blake wrote: Commit b9dd878f caused a regression in iptables interaction by logging non-zero status at a higher level than VIR_INFO. Revert that portion of the commit, as well as adding a comment explaining why we check

Re: [libvirt] [PATCH] build: work around FreeBSD stdlib.h bug

2014-03-11 Thread Eric Blake
On 03/08/2014 09:57 AM, Roman Bogorodskiy wrote: Eric Blake wrote: POSIX requires that stdlib.h expose WIFEXITED and friends, but FreeBSD and others fail to comply. We can work around it manually by including sys/wait.h, or we can work around it automatically by using gnulib's

Re: [libvirt] [PATCH v5 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-11 Thread Eric Blake
On 03/06/2014 11:09 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have parameters, and all options which have no parameter aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will

Re: [libvirt] [PATCH] qemu: don't munge user input during block commit

2014-03-11 Thread Eric Blake
On 03/07/2014 03:58 AM, Michal Privoznik wrote: On 07.03.2014 00:47, Eric Blake wrote: While investigating https://bugzilla.redhat.com/show_bug.cgi?id=1061827 I noticed that we pass user input unscathed for block-pull, but always pass a canonical absolute name through for block-commit. *