On Tue, Dec 10, 2019 at 17:25:40 +0100, Pavel Mores wrote:
> Since blockcommit is asynchronous, libvirtd can be restarted while the
> operation runs. To ensure the information necessary to finish up the job
> is not lost, serialisation to and deserialisation from the status XML is
> added.
>
>
On Tue, Dec 10, 2019 at 17:25:39 +0100, Pavel Mores wrote:
> When blockcommit finishes successfully, one of the
> qemuBlockJobProcessEventCompletedCommit() and
> qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called.
> This is where the delete flag (stored in
On Tue, Dec 10, 2019 at 17:25:38 +0100, Pavel Mores wrote:
> Propagate the delete flag from qemuDomainBlockCommit() (which was just
> ignoring it until now) to qemuBlockJobDiskNewCommit() where it can be
> stored in the qemuBlockJobCommitData structure which holds information
> necessary to finish
On Tue, Dec 10, 2019 at 17:25:41 +0100, Pavel Mores wrote:
> With all plumbing in place, we can now enable the new functionality.
>
> Signed-off-by: Pavel Mores
> ---
> src/qemu/qemu_driver.c | 12 ++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git
On Tue, Dec 10, 2019 at 19:45:01 -0300, Daniel Henrique Barboza wrote:
>
>
> On 12/10/19 5:00 AM, Peter Krempa wrote:
> > On Mon, Dec 09, 2019 at 20:15:05 -0300, Daniel Henrique Barboza wrote:
> > > (series based on master commit 97cafa610ecf5)
> > >
> > > This work was proposed by Cole in [1].
On Wed, Dec 11, 2019 at 12:38:05AM +0800, Alex Williamson wrote:
> On Tue, 10 Dec 2019 02:44:44 -0500
> Yan Zhao wrote:
>
> > On Tue, Dec 10, 2019 at 05:16:08AM +0800, Alex Williamson wrote:
> > > On Mon, 9 Dec 2019 01:22:12 -0500
> > > Yan Zhao wrote:
> > >
> > > > On Fri, Dec 06, 2019 at
On Wed, Dec 11, 2019 at 12:58:24AM +0800, Alex Williamson wrote:
> On Mon, 9 Dec 2019 21:44:23 -0500
> Yan Zhao wrote:
>
> > > > > > Currently, yes, i40e has build dependency on vfio-pci.
> > > > > > It's like this, if i40e decides to support SRIOV and compiles in vf
> > > > > > related code who
On 12/6/19 9:50 AM, Daniel P. Berrangé wrote:
> As part of the goal to eliminate Perl from libvirt, this gets rid of the
> use of POD format for man pages. There's nothing especially bad about
> POD as a markup language compared to other lightweight markup languages
> like RST or Markdown. It
On 12/6/19 12:26 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/Makefile.am | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Cole Robinson
- Cole
--
libvir-list mailing list
libvir-list@redhat.com
On 12/10/19 5:26 AM, Daniel P. Berrangé wrote:
> This reverts commit 7be5fe66cd024b9ffba7c52cdbf5effedeac2c0d.
>
> This commit broke resctrl, because it missed the fact that the
> virResctrlInfoGetCache() has side-effects causing it to actually
> change the virResctrlInfo parameter, not merely
On 12/10/19 5:00 AM, Peter Krempa wrote:
On Mon, Dec 09, 2019 at 20:15:05 -0300, Daniel Henrique Barboza wrote:
(series based on master commit 97cafa610ecf5)
This work was proposed by Cole in [1]. This is Cole's reasoning for
it, copy/pasted from [1]:
Nice work. Doing this was long
On 12/10/19 6:41 PM, Cole Robinson wrote:
On 12/9/19 6:15 PM, Daniel Henrique Barboza wrote:
(series based on master commit 97cafa610ecf5)
[...]
The hotplug code should already be calling into Validate code. When a
device is hotplugged via qemu_driver, we get:
qemu_driver.c
->
On 12/9/19 6:15 PM, Daniel Henrique Barboza wrote:
> (series based on master commit 97cafa610ecf5)
>
> This work was proposed by Cole in [1]. This is Cole's reasoning for
> it, copy/pasted from [1]:
>
> ---
> The benefits of moving to validate time is that XML is rejected by
> 'virsh define'
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> This is slightly more complicated because NVMe disk source is not
> a simple attribute to element. The format in which the
> PCI address and namespace ID are printed is the same as QEMU
> accepts them:
>
> nvme://:XX:XX.X/X
>
> Signed-off-by:
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 58 +
> src/qemu/qemu_hostdev.c | 22
> src/qemu/qemu_hostdev.h | 6 +
> 3 files changed, 86 insertions(+)
Reviewed-by:
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> With NVMe disks, one can start a blockjob with a NVMe disk
> that is not visible in domain XML (at least right away). Usually,
> it's fairly easy to override this limitation of
> qemuDomainGetMemLockLimitBytes() - for instance for hostdevs we
>
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> At the very beginning of the attach function the
> qemuDomainStorageSourceChainAccessAllow() is called which
> modifies CGroups, locks and seclabels for new disk and its
> backing chain. This must be followed by a counterpart which
> reverts back all
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> Because this is a HMP we're dealing with, there is nothing like
> class of reply message, so we have to do some string comparison
> to guess if the command fails. Well, with NVMe disks whole new
> class of errors comes to play because qemu needs to
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> This capability tracks if qemu is capable of:
>
> -drive file.driver=nvme
>
> The feature was added in QEMU's commit of v2.12.0-rc0~104^2~2.
>
> Signed-off-by: Michal Privoznik
Reviewed-by: Cole Robinson
- Cole
--
libvir-list mailing list
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> Now, that we have everything prepared, we can generate command
> line for NVMe disks.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_block.c | 25 +++-
> src/qemu/qemu_command.c | 3 +
>
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> This function is currently not called for any type of storage
> source that is not considered 'local' (as defined by
> virStorageSourceIsLocalStorage()). Well, NVMe disks are not
> 'local' from that point of view and therefore we will need to
> call
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> If a domain has an NVMe disk configured, then we need to allow it
> on devices CGroup so that qemu can access it. There is one caveat
> though - if an NVMe disk is read only we need CGroup to allow
> write too. This is because when opening the device,
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> If a domain has an NVMe disk configured, then we need to create
> /dev/vfio/* paths in domain's namespace so that qemu can open
> them.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 67
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> There are couple of places where a domain with a VFIO device gets
> special treatment: in CGroups when enabling/disabling access to
> /dev/vfio/vfio, and when creating/removing nodes in domain mount
> namespace. Well, a NVMe disk is a VFIO device too.
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> We have this beautiful function that does crystal ball
> divination. The function is named
> qemuDomainGetMemLockLimitBytes() and it calculates the upper
> limit of how much locked memory is given guest going to need. The
> function bases its guess on
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> The qemu driver has its own wrappers around virHostdev module (so
> that some arguments are filled in automatically). Extend these to
> include NVMe devices too.
>
> Signed-off-by: Michal Privoznik
> ACKed-by: Peter Krempa
> ---
>
On Tue, Dec 10, 2019 at 11:32:18AM -0500, Cole Robinson wrote:
> On 12/10/19 5:57 AM, Daniel P. Berrangé wrote:
> >
> >> Another issue: other drivers use the machine= setting too, libxl at
> >> least. This appears to drop filling in a default machine type for them,
> >> at least at XML parse
On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio
> ---
> guests/playbooks/build/jobs/defaults.yml| 2 ++
> guests/playbooks/build/projects/libosinfo.yml | 1 +
> guests/playbooks/build/projects/libvirt-dbus.yml| 2 ++
>
On Mon, 9 Dec 2019 21:44:23 -0500
Yan Zhao wrote:
> > > > > Currently, yes, i40e has build dependency on vfio-pci.
> > > > > It's like this, if i40e decides to support SRIOV and compiles in vf
> > > > > related code who depends on vfio-pci, it will also have build
> > > > > dependency
> > > > >
On 12/5/19 12:11 PM, Arnaud Patard wrote:
> When emulating smartcard with host certificates, qemu needs to
> be able to read the certificates files. Add necessary code to
> add the smartcard certificates file path to the apparmor profile.
>
> Passthrough support has been tested with spicevmc and
On Tue, 10 Dec 2019 02:44:44 -0500
Yan Zhao wrote:
> On Tue, Dec 10, 2019 at 05:16:08AM +0800, Alex Williamson wrote:
> > On Mon, 9 Dec 2019 01:22:12 -0500
> > Yan Zhao wrote:
> >
> > > On Fri, Dec 06, 2019 at 11:20:38PM +0800, Alex Williamson wrote:
> > > > On Fri, 6 Dec 2019 01:04:07
On 12/10/19 5:57 AM, Daniel P. Berrangé wrote:
>
>> Another issue: other drivers use the machine= setting too, libxl at
>> least. This appears to drop filling in a default machine type for them,
>> at least at XML parse time.
>
> I thought that was the case too, but I couln't find any functional
This version incorporates Peter's feedback to v3.
Pavel Mores (4):
qemu: block: propagate the delete flag to where it can actually be
used
qemu: block: use the delete flag to delete snapshot images if
requested
qemu: block: store the delete flag in libvirtd's status XML
qemu:
With all plumbing in place, we can now enable the new functionality.
Signed-off-by: Pavel Mores
---
src/qemu/qemu_driver.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9c07b6b393..0cbc746c22 100644
---
When blockcommit finishes successfully, one of the
qemuBlockJobProcessEventCompletedCommit() and
qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called.
This is where the delete flag (stored in qemuBlockJobCommitData since the
previous commit) can actually be used to delete the
Since blockcommit is asynchronous, libvirtd can be restarted while the
operation runs. To ensure the information necessary to finish up the job
is not lost, serialisation to and deserialisation from the status XML is
added.
To unittest this, the new element was only added to the active commit
Propagate the delete flag from qemuDomainBlockCommit() (which was just
ignoring it until now) to qemuBlockJobDiskNewCommit() where it can be
stored in the qemuBlockJobCommitData structure which holds information
necessary to finish the job asynchronously.
In the actual qemuBlockJobDiskNewCommit()
On 12/10/19 7:43 AM, Daniel P. Berrangé wrote:
> The use of the parseOpaque parameter was mistakenly removed in
>
> commit 4a4132b4625778cf80acb9c92d06351b44468ac3
> Author: Daniel P. Berrangé
> Date: Tue Dec 3 10:49:49 2019 +
>
> conf: don't use passed in caps in post parse
On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio
> ---
> guests/host_vars/libvirt-centos-8/main.yml | 15 +++
> 1 file changed, 15 insertions(+)
The cover letter contained the following remark:
> The projects which were not added due to
> On 10 Dec 2019, at 16:08, marcandre.lur...@redhat.com wrote:
>
> From: Marc-André Lureau
>
> Support by usage name can be considered separately (with a 'usage'
> attribute?).
>
> Cc: Stefan Berger
> Signed-off-by: Marc-André Lureau
> ---
> docs/formatsecret.html.in | 4 ++--
> 1 file
On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> In order to build our projects on a CentOS 8 machine / container, some
> changes will be required:
>
> - libssh2, libvirt dependency, is not longer present:
> -
>
On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> This commit allows calling `lcitool install libvirt-centos-8`.
>
> `lcitool update libvirt-centos-8 $project` does *not* work as:
> - EPEL repository is only enabled for CentOS 7;
> - The reason EPEL is needed because of some base
On 12/9/19 11:55 PM, Cole Robinson wrote:
On 12/2/19 9:26 AM, Michal Privoznik wrote:
There is this class of PCI devices that act like disks: NVMe.
Therefore, they are both PCI devices and disks. While we already
have (and can assign a NVMe device to a domain
successfully) we don't have disk
On 12/10/19 12:43 AM, Cole Robinson wrote:
On 12/2/19 9:26 AM, Michal Privoznik wrote:
To simplify implementation, some restrictions are added. For
instance, an NVMe disk can't go to any bus but virtio and has to
be type of 'disk' and can't have startupPolicy set.
Signed-off-by: Michal
On 12/10/19 5:56 AM, Peter Krempa wrote:
> On Tue, Dec 10, 2019 at 09:58:38 +, Daniel Berrange wrote:
>> On Mon, Dec 09, 2019 at 08:15:05PM -0300, Daniel Henrique Barboza wrote:
>>> (series based on master commit 97cafa610ecf5)
>>>
>>> This work was proposed by Cole in [1]. This is Cole's
Let's always generate the unattended script file as, by doing this, we
can treat the files we have as templates, being able to change them
accordingly to whatever is needed by specific distros.
It's important to note that we *must* be careful and keep generating
those files using their "expected"
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/build/jobs/defaults.yml| 2 ++
guests/playbooks/build/projects/libosinfo.yml | 1 +
guests/playbooks/build/projects/libvirt-dbus.yml| 2 ++
guests/playbooks/build/projects/libvirt.yml | 1 +
In order to build our projects on a CentOS 8 machine / container, some
changes will be required:
- libssh2, libvirt dependency, is not longer present:
-
In order to add CentOS 8 to jenkins-ci, we had to:
- Adjust lcitool to generate unattended scripts based on templates
instead of using the templates themselves, as a new parameter is
expected on kickstart files for RHEL / CentOS 8 (or newer);
- Enable the EPEL and PowerTools repos;
Then, the
This commit allows calling `lcitool install libvirt-centos-8`.
`lcitool update libvirt-centos-8 $project` does *not* work as:
- EPEL repository is only enabled for CentOS 7;
- The reason EPEL is needed because of some base packages (as screen);
- There's no task to enable PowerTools repository;
Passing `url --url={{ install_url }}` to a kickstart file is, according
to Red Hat official documentation[0], mandatory for RHEL 8 and onwards
(which includes CentOS 8).
Using it for RHEL 7, CentOS 7, and Fedora does not cause any issue.
[0]:
This is needed as all the development packages will come from the
PowerTools repository, which is not enabled by default.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/playbooks/update/tasks/base.yml | 8
1 file changed, 8 insertions(+)
diff --git
EPEL repository should be enabled on all supported CentOS guests as it
brings in packages which are part of the "base packages" for
libvirt-jenkins-ci.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/playbooks/update/tasks/base.yml | 1 -
1 file changed, 1 deletion(-)
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 15 +++
1 file changed, 15 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index a147183..aae2313 100644
---
On 12/10/19 10:03 AM, Pavel Hrdina wrote:
> On Tue, Dec 10, 2019 at 03:57:59PM +0100, Ján Tomko wrote:
>> On Tue, Dec 10, 2019 at 03:29:43PM +0100, Pavel Hrdina wrote:
>>> On Tue, Dec 10, 2019 at 03:14:40PM +0100, Christophe de Dinechin wrote:
> On 10 Dec 2019, at 15:11, Pavel Hrdina
On Tue, 2019-12-10 at 14:54 +, Daniel P. Berrangé wrote:
> On Tue, Dec 10, 2019 at 02:54:22PM +0100, Andrea Bolognani wrote:
> > The only reason why I'm even questioning whether this should be done
> > is capacity for the hypervisor host: the machine we're running all
> > builders on has
> >
From: Marc-André Lureau
Support by usage name can be considered separately (with a 'usage'
attribute?).
Cc: Stefan Berger
Signed-off-by: Marc-André Lureau
---
docs/formatsecret.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatsecret.html.in
On Tue, Dec 10, 2019 at 04:03:56PM +0100, Pavel Hrdina wrote:
> On Tue, Dec 10, 2019 at 03:57:59PM +0100, Ján Tomko wrote:
> > On Tue, Dec 10, 2019 at 03:29:43PM +0100, Pavel Hrdina wrote:
> > > On Tue, Dec 10, 2019 at 03:14:40PM +0100, Christophe de Dinechin wrote:
> > > >
> > > >
> > > > > On
On Tue, Dec 10, 2019 at 03:57:59PM +0100, Ján Tomko wrote:
> On Tue, Dec 10, 2019 at 03:29:43PM +0100, Pavel Hrdina wrote:
> > On Tue, Dec 10, 2019 at 03:14:40PM +0100, Christophe de Dinechin wrote:
> > >
> > >
> > > > On 10 Dec 2019, at 15:11, Pavel Hrdina wrote:
> > > >
> > > > Clang
On Tue, Dec 10, 2019 at 03:29:43PM +0100, Pavel Hrdina wrote:
On Tue, Dec 10, 2019 at 03:14:40PM +0100, Christophe de Dinechin wrote:
> On 10 Dec 2019, at 15:11, Pavel Hrdina wrote:
>
> Clang complains about condition being always true:
>
> src/util/virkeyfile.c:113:23: error: result of
On Tue, Dec 10, 2019 at 02:54:22PM +0100, Andrea Bolognani wrote:
> This patch is intended to start a slightly larger discussion about
> our plans for the CentOS CI environment going forward.
>
> At the moment, we have active builders for
>
> CentOS 7
> Debian 9
> Debian 10
> Fedora 30
>
This is a significant rework of v1 as
- patch 1 was dropped because an equivalent change was accidentally committed
in the meantime in 4c53267b70fc5c548b6530113c3f96870d8d7fc1
- patch 2 was dropped as it was just a mostly formal clean-up of patch 1
- patch 3 was redone using a different
This commit aims to fix
https://bugzilla.redhat.com/show_bug.cgi?id=1610207
The cause was apparently incorrect handling of jobs in snapshot revert code
which allowed a thread executing snapshot delete to begin job while
snapshot revert was still running on another thread. The snapshot delete
On Tue, Dec 10, 2019 at 03:14:40PM +0100, Christophe de Dinechin wrote:
>
>
> > On 10 Dec 2019, at 15:11, Pavel Hrdina wrote:
> >
> > Clang complains about condition being always true:
> >
> > src/util/virkeyfile.c:113:23: error: result of comparison of constant 128
> > with expression of
> On 10 Dec 2019, at 15:11, Pavel Hrdina wrote:
>
> Clang complains about condition being always true:
>
> src/util/virkeyfile.c:113:23: error: result of comparison of constant 128
> with expression of type 'const char' is always true
>
On 12/10/19 2:17 PM, Daniel P. Berrangé wrote:
Daniel P. Berrangé (6):
Fix typo breaking some migrate parameter handling
Add handling for VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS
Add support for VIR_MIGRATE_PARAM_TLS_DESTINATION constant
Add missing create_checkpoint method
Remove
Clang complains about condition being always true:
src/util/virkeyfile.c:113:23: error: result of comparison of constant 128 with
expression of type 'const char' is always true
[-Werror,-Wtautological-constant-out-of-range-compare]
while (!IS_EOF && IS_ASCII(CUR) && CUR != ']')
We've supported both Ubuntu 16.04 and Ubuntu 18.04 as build targets
for a long time now, and we are even building on the latter on
Travis CI, but we've never actually deployed the corresponding VMs
in the CentOS CI environment. Start doing that now.
Signed-off-by: Andrea Bolognani
---
This patch is intended to start a slightly larger discussion about
our plans for the CentOS CI environment going forward.
At the moment, we have active builders for
CentOS 7
Debian 9
Debian 10
Fedora 30
Fedora 31
Fedora Rawhide
FreeBSD 11
FreeBSD 12
but we don't have builder for
Signed-off-by: Daniel P. Berrangé
---
Changes | 1 +
lib/Sys/Virt/DomainCheckpoint.pm | 5 -
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/Changes b/Changes
index f36d401..9d9a5c8 100644
--- a/Changes
+++ b/Changes
@@ -10,6 +10,7 @@ Revision history
Signed-off-by: Daniel P. Berrangé
---
Changes | 2 ++
lib/Sys/Virt.xs | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Changes b/Changes
index 37529ac..2ba87bb 100644
--- a/Changes
+++ b/Changes
@@ -4,6 +4,8 @@ Revision history for perl module Sys::Virt
- Add
Signed-off-by: Daniel P. Berrangé
---
Changes | 2 ++
lib/Sys/Virt.xs | 12 ++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/Changes b/Changes
index 2ba87bb..ba33d40 100644
--- a/Changes
+++ b/Changes
@@ -6,6 +6,8 @@ Revision history for perl module Sys::Virt
Signed-off-by: Daniel P. Berrangé
---
Changes| 1 +
lib/Sys/Virt.xs| 13 +++--
lib/Sys/Virt/Domain.pm | 9 +
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/Changes b/Changes
index ba33d40..09d1dca 100644
--- a/Changes
+++ b/Changes
@@
Daniel P. Berrangé (6):
Fix typo breaking some migrate parameter handling
Add handling for VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS
Add support for VIR_MIGRATE_PARAM_TLS_DESTINATION constant
Add missing create_checkpoint method
Remove docs for has_metadata method which doesn't exist
Signed-off-by: Daniel P. Berrangé
---
Changes| 1 +
lib/Sys/Virt/Domain.pm | 17 +
2 files changed, 18 insertions(+)
diff --git a/Changes b/Changes
index 09d1dca..f36d401 100644
--- a/Changes
+++ b/Changes
@@ -9,6 +9,7 @@ Revision history for perl module
Signed-off-by: Daniel P. Berrangé
---
Changes | 2 ++
lib/Sys/Virt.xs | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Changes b/Changes
index 9d9a5c8..e90e736 100644
--- a/Changes
+++ b/Changes
@@ -11,6 +11,8 @@ Revision history for perl module Sys::Virt
- Add
On Tue, Dec 10, 2019 at 02:09:35PM +0100, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> Changes| 1 +
> lib/Sys/Virt.xs| 1 +
> lib/Sys/Virt/Domain.pm | 9 +
> 3 files changed, 11 insertions(+)
>
> diff --git a/Changes b/Changes
> index
On Tue, 10 Dec 2019 11:34:32 +0100
Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > +Markus
> >
> > On Tue, Dec 03, 2019 at 03:43:03PM +0100, Igor Mammedov wrote:
> >> On Tue, 3 Dec 2019 09:56:15 +0100
> >> Thomas Huth wrote:
> >>
> >> > On 02/12/2019 22.00, Eduardo Habkost
Signed-off-by: Michal Privoznik
---
Changes| 1 +
lib/Sys/Virt.xs| 1 +
lib/Sys/Virt/Domain.pm | 9 +
3 files changed, 11 insertions(+)
diff --git a/Changes b/Changes
index 37529ac..cf5d8cc 100644
--- a/Changes
+++ b/Changes
@@ -4,6 +4,7 @@ Revision history for
On Sun, Dec 08, 2019 at 06:36:22PM -0500, Cole Robinson wrote:
> On 11/20/19 9:48 AM, Pavel Hrdina wrote:
> > Changes in v2:
> > - fixed missing parentheses in patch 01
> > - added patch 02 to cover c_isascii
> >
>
> With the two issues I pointed out fixed:
>
> Reviewed-by: Cole
The use of the parseOpaque parameter was mistakenly removed in
commit 4a4132b4625778cf80acb9c92d06351b44468ac3
Author: Daniel P. Berrangé
Date: Tue Dec 3 10:49:49 2019 +
conf: don't use passed in caps in post parse method
causing the method to re-fetch qemuCaps that were
On Tue, Dec 10, 2019 at 12:41 PM Henning Schild
wrote:
> Am Tue, 10 Dec 2019 12:01:24 +0100
> schrieb Christian Ehrhardt :
>
> > On Tue, Dec 10, 2019 at 10:46 AM Henning Schild
> > wrote:
> >
> > > Hi all,
> > >
> > > the systemd shutdown scripts work sequentially with a 300s timeout
> > >
On Tuesday, December 10, 2019, Andrea Bolognani wrote:
> Andrea Bolognani (2):
> guests: Enable Go projects on CentOS 7 once again
> Build Go projects on CentOS 7 once again
>
> guests/host_vars/libvirt-centos-7/main.yml | 2 ++
> guests/playbooks/build/projects/libvirt-go-xml.yml
Now that we have a recent Go compiler installed, we can once again
start building all projects written in that language on the target.
Signed-off-by: Andrea Bolognani
---
guests/playbooks/build/projects/libvirt-go-xml.yml | 13 +
guests/playbooks/build/projects/libvirt-go.yml |
We had disabled this a year ago with 72afaed959f8; however, a few
months ago we started enabling EPEL on CentOS 7 with d63d6a59cc11,
and from that source we can install a recent Go compiler.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-centos-7/main.yml | 2 ++
1 file changed, 2
Andrea Bolognani (2):
guests: Enable Go projects on CentOS 7 once again
Build Go projects on CentOS 7 once again
guests/host_vars/libvirt-centos-7/main.yml | 2 ++
guests/playbooks/build/projects/libvirt-go-xml.yml | 13 +
guests/playbooks/build/projects/libvirt-go.yml
On Tue, Dec 10, 2019 at 10:57:44AM +, Daniel P. Berrangé wrote:
> On Mon, Dec 09, 2019 at 01:21:05PM -0500, Cole Robinson wrote:
> > On 12/4/19 9:20 AM, Daniel P. Berrangé wrote:
> > > The XML parser currently calls virCapabilitiesDomainDataLookup during
> > > parsing to find the domain
Am Tue, 10 Dec 2019 12:01:24 +0100
schrieb Christian Ehrhardt :
> On Tue, Dec 10, 2019 at 10:46 AM Henning Schild
> wrote:
>
> > Hi all,
> >
> > the systemd shutdown scripts work sequentially with a 300s timeout
> > (seen on Debian). If a VM does not have ACPI support, or the ACPI
> > support
On 10/12/2019 12.06, Markus Armbruster wrote:
> Thomas Huth writes:
>
>> It's been deprecated since QEMU v3.1, so it's time to finally
>> remove it. The "id" parameter can simply be used instead.
>>
>> Signed-off-by: Thomas Huth
> [...]
>> diff --git a/qapi/net.json b/qapi/net.json
>> index
Thomas Huth writes:
> Now that the "name" parameter is gone, there is hardly any difference
> between NetLegacy and Netdev anymore. Drop NetLegacy and always use
> Netdev to simplify the code quite a bit.
>
> Signed-off-by: Thomas Huth
Took me a minute to see the actual difference.
Here's
Thomas Huth writes:
> It's been deprecated since QEMU v3.1, so it's time to finally
> remove it. The "id" parameter can simply be used instead.
>
> Signed-off-by: Thomas Huth
[...]
> diff --git a/qapi/net.json b/qapi/net.json
> index 335295be50..ff280ccd16 100644
> --- a/qapi/net.json
> +++
Some comments were only present in the Ansible part and not in
the Jenkins part and vice versa.
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
guests/playbooks/build/projects/libvirt-tck.yml | 2 ++
jenkins/projects/libosinfo.yaml | 2 --
2 files changed, 2
On Tue, Dec 10, 2019 at 10:46 AM Henning Schild
wrote:
> Hi all,
>
> the systemd shutdown scripts work sequentially with a 300s timeout
> (seen on Debian). If a VM does not have ACPI support, or the ACPI
> support failed for some reason, you are looking at a 300s timeout per
> instance for a
On Mon, Dec 09, 2019 at 01:21:05PM -0500, Cole Robinson wrote:
> On 12/4/19 9:20 AM, Daniel P. Berrangé wrote:
> > The XML parser currently calls virCapabilitiesDomainDataLookup during
> > parsing to find the domain capabilities matching the triple
> >
> > (virt type, os type, arch)
> >
> >
On Tue, Dec 10, 2019 at 09:58:38 +, Daniel Berrange wrote:
> On Mon, Dec 09, 2019 at 08:15:05PM -0300, Daniel Henrique Barboza wrote:
> > (series based on master commit 97cafa610ecf5)
> >
> > This work was proposed by Cole in [1]. This is Cole's reasoning for
> > it, copy/pasted from [1]:
> >
On Tue, 10 Dec 2019 10:36:36 +
Daniel P. Berrangé wrote:
> On Tue, Dec 10, 2019 at 11:24:44AM +0100, Cornelia Huck wrote:
> > On Tue, 10 Dec 2019 10:09:34 +
> > Daniel P. Berrangé wrote:
> >
> > > On Mon, Dec 09, 2019 at 02:23:38PM -0600, Jonathon Jongsma wrote:
> > > > mdevctl
On Tue, Dec 10, 2019 at 07:22:37AM -0300, Daniel Henrique Barboza wrote:
> Hi,
>
> I failed to make a reservation about what I've done in patch in the
> cover letter. In the commit msg I mentioned about the XML files
> considering SPICE support as default to ppc64, aarch64 and s390 archs and
>
On Tue, Dec 10, 2019 at 11:24:44AM +0100, Cornelia Huck wrote:
> On Tue, 10 Dec 2019 10:09:34 +
> Daniel P. Berrangé wrote:
>
> > On Mon, Dec 09, 2019 at 02:23:38PM -0600, Jonathon Jongsma wrote:
> > > mdevctl also supports assigning arbitrary sysfs attributes to a device.
> > > These
Eduardo Habkost writes:
> +Markus
>
> On Tue, Dec 03, 2019 at 03:43:03PM +0100, Igor Mammedov wrote:
>> On Tue, 3 Dec 2019 09:56:15 +0100
>> Thomas Huth wrote:
>>
>> > On 02/12/2019 22.00, Eduardo Habkost wrote:
>> > > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote:
>> > >> On
On Tue, Dec 10, 2019 at 03:27:06PM +0800, Wang Huaqiang wrote:
> This patch introduced a bug and broke the 'resctrl' feature.
>
> It introduced a 'divide by zero' error if you defined any 'resctrl'
>
> allocation group through .
>
>
> Reason is 'caps->resctrl' is fully initialized through two
1 - 100 of 117 matches
Mail list logo
