Juan Quintela wrote:
> Use blocked-mirror with NBD instead.
>
> Signed-off-by: Juan Quintela
> Acked-by: Stefan Hajnoczi
> Reviewed-by: Thomas Huth
> Reviewed-by: Markus Armbruster
Hi Kevin and Stefan
Can we change the iotest output to fix this?
On Tue, Oct 17, 2023 at 10:54:19AM -0600, Alex Williamson wrote:
> On Tue, 17 Oct 2023 12:28:30 -0300
> Jason Gunthorpe wrote:
>
> > On Tue, Oct 17, 2023 at 09:21:16AM -0600, Alex Williamson wrote:
> >
> > > Do we therefore need some programatic means for the kernel driver to
> > > expose the
It is obsolete. It is better to use driver-mirror with NBD instead.
CC: Kevin Wolf
CC: Eric Blake
CC: Stefan Hajnoczi
CC: Hanna Czenczek
Signed-off-by: Juan Quintela
Acked-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
---
docs/about/deprecated.rst | 10 ++
Signed-off-by: Juan Quintela
Acked-by: Stefan Hajnoczi
Acked-by: Peter Xu
Reviewed-by: Markus Armbruster
---
docs/about/deprecated.rst | 8 +
qapi/migration.json | 63 ++-
migration/options.c | 13
3 files changed, 64
Use blockdev-mirror with NBD instead.
Reviewed-by: Thomas Huth
Acked-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 9 +
qapi/migration.json| 8 +++-
migration/migration-hmp-cmds.c | 5 +
The new line was only printed when command options were used. When we
used migration parameters and capabilities, it wasn't.
Signed-off-by: Juan Quintela
Reviewed-by: Fabiano Rosas
---
migration/migration-hmp-cmds.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
Use blocked-mirror with NBD instead.
Signed-off-by: Juan Quintela
Acked-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
Reviewed-by: Markus Armbruster
---
docs/about/deprecated.rst | 9 +
qapi/migration.json| 7 ---
migration/migration-hmp-cmds.c | 5 +
Based on: Message-ID: <20231017083003.15951-1-quint...@redhat.com>
Migration 20231017 patches
On this v6:
- Fixed Markus comments
- 1st patch is reviewed
- dropped the RFC ones.
Later, Juan.
On this v5:
- Rebased on top of last migration pull requesnt:
- address markus co
Markus Armbruster wrote:
> Juan Quintela writes:
>
>> Signed-off-by: Juan Quintela
>> Acked-by: Stefan Hajnoczi
>> Acked-by: Peter Xu
>> # @deprecated: Member @disk is deprecated because block migration is.
>> +# Member @compression is deprecated because it is unreliable and
>> +#
On Tue, 17 Oct 2023 12:28:30 -0300
Jason Gunthorpe wrote:
> On Tue, Oct 17, 2023 at 09:21:16AM -0600, Alex Williamson wrote:
>
> > Do we therefore need some programatic means for the kernel driver to
> > expose the node configuration to userspace? What interfaces would
> > libvirt like to see
Juan Quintela writes:
> The new line was only printed when command options were used. When we
> used migration parameters and capabilities, it wasn't.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Fabiano Rosas
Markus Armbruster wrote:
> Juan Quintela writes:
>
>> #
>> +# @deprecated: Member @block-incremental is deprecated. Use
>
> Two spaces between sentences for consistency, please.
Done. At least here I did the copy and paste right.
>> diff --git a/migration/block.c b/migration/block.c
>> index
Markus Armbruster wrote:
> Juan Quintela writes:
>
>> Use blocked-mirror with NBD instead.
>>
>> Signed-off-by: Juan Quintela
>> Acked-by: Stefan Hajnoczi
>> Reviewed-by: Thomas Huth
>>
>> ---
>>
>> Improve documentation and style (markus)
>> ---
>> docs/about/deprecated.rst | 10
On Tue, Oct 17, 2023 at 09:21:16AM -0600, Alex Williamson wrote:
> Do we therefore need some programatic means for the kernel driver to
> expose the node configuration to userspace? What interfaces would
> libvirt like to see here? Is there an opportunity that this could
> begin to define
Markus Armbruster wrote:
> Juan Quintela writes:
>
>> Use blockdev-mirror with NBD instead.
>>
>> Reviewed-by: Thomas Huth
>> Acked-by: Stefan Hajnoczi
>> Signed-off-by: Juan Quintela
>>
>> ---
>>
>> Improve documentation and style (thanks Markus)
>> ---
>> docs/about/deprecated.rst | 8
On Tue, 17 Oct 2023 14:00:54 +
Ankit Agrawal wrote:
> >> -device
> >>vfio-pci-nohotplug,host=0009:01:00.0,bus=pcie.0,addr=04.0,rombar=0,id=dev0 \
> >> -object
> >>nvidia-acpi-generic-initiator,id=gi0,device=dev0,numa-node-start=2,numa-node-count=8
> >>
> >
> > Why didn't
Juan Quintela writes:
> Signed-off-by: Juan Quintela
> Acked-by: Stefan Hajnoczi
> Acked-by: Peter Xu
> ---
> docs/about/deprecated.rst | 8
> qapi/migration.json | 79 +--
> migration/options.c | 13 +++
> 3 files changed, 72
Juan Quintela writes:
> It is obsolete. It is better to use driver-mirror with NBD instead.
>
> CC: Kevin Wolf
> CC: Eric Blake
> CC: Stefan Hajnoczi
> CC: Hanna Czenczek
>
> Signed-off-by: Juan Quintela
> Acked-by: Stefan Hajnoczi
> ---
> docs/about/deprecated.rst | 10 ++
>
Juan Quintela writes:
> Use blocked-mirror with NBD instead.
>
> Signed-off-by: Juan Quintela
> Acked-by: Stefan Hajnoczi
> Reviewed-by: Thomas Huth
>
> ---
>
> Improve documentation and style (markus)
> ---
> docs/about/deprecated.rst | 10 ++
> qapi/migration.json|
Juan Quintela writes:
> Use blockdev-mirror with NBD instead.
>
> Reviewed-by: Thomas Huth
> Acked-by: Stefan Hajnoczi
> Signed-off-by: Juan Quintela
>
> ---
>
> Improve documentation and style (thanks Markus)
> ---
> docs/about/deprecated.rst | 8
> qapi/migration.json
Based on: Message-ID: <20231017083003.15951-1-quint...@redhat.com>
Migration 20231017 patches
On this v5:
- Rebased on top of last migration pull requesnt:
- address markus comments. Basically we recommend always
blockdev-mirror + NBD. In deprecated.rst we also put the pos
[DON'T MERGE]
Block migration is obsolete, users should use blockdev-mirror
instead.
Make it one error to set them.
Signed-off-by: Juan Quintela
---
migration/migration-hmp-cmds.c | 13 +++--
migration/migration.c | 33 ++---
2 files changed, 13
Use blockdev-mirror with NBD instead.
Reviewed-by: Thomas Huth
Acked-by: Stefan Hajnoczi
Signed-off-by: Juan Quintela
---
Improve documentation and style (thanks Markus)
---
docs/about/deprecated.rst | 8
qapi/migration.json| 8 +++-
It is obsolete. It is better to use driver-mirror with NBD instead.
CC: Kevin Wolf
CC: Eric Blake
CC: Stefan Hajnoczi
CC: Hanna Czenczek
Signed-off-by: Juan Quintela
Acked-by: Stefan Hajnoczi
---
docs/about/deprecated.rst | 10 ++
qapi/migration.json | 29
[DON'T MERGE]
We were abusing capabilities and parameters to implement -i/-b.
Previous patch convert that options into one error. Remove all the
helpers needed to implement them.
Signed-off-by: Juan Quintela
---
migration/migration.h | 4
migration/options.h | 6 --
Signed-off-by: Juan Quintela
Acked-by: Stefan Hajnoczi
Acked-by: Peter Xu
---
docs/about/deprecated.rst | 8
qapi/migration.json | 79 +--
migration/options.c | 13 +++
3 files changed, 72 insertions(+), 28 deletions(-)
diff --git
Use blocked-mirror with NBD instead.
Signed-off-by: Juan Quintela
Acked-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
---
Improve documentation and style (markus)
---
docs/about/deprecated.rst | 10 ++
qapi/migration.json| 6 --
migration/migration-hmp-cmds.c |
The new line was only printed when command options were used. When we
used migration parameters and capabilities, it wasn't.
Signed-off-by: Juan Quintela
---
migration/migration-hmp-cmds.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/migration/migration-hmp-cmds.c
ping1
On Thu, Oct 12, 2023 at 10:39 AM ~hyman wrote:
> In qemu>=8.1, the dirty-limit functionality for live
> migration was included. In the live migration
> scenario, it implements the force convergence
> using the dirty-limit approach, which results in
> better reliable read performance. A
use '%u' to printf unsigned int
Signed-off-by: zhujun2
---
examples/c/misc/event-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/c/misc/event-test.c b/examples/c/misc/event-test.c
index 813bca2699..07d86500cd 100644
--- a/examples/c/misc/event-test.c
+++
use '%u' to printf unsigned int
Signed-off-by: zhujun2
---
examples/c/misc/event-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/c/misc/event-test.c b/examples/c/misc/event-test.c
index 813bca2699..07d86500cd 100644
--- a/examples/c/misc/event-test.c
+++
31 matches
Mail list logo