Signed-off-by: Fabiano Fidêncio
---
src/rpc/virnetclient.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index 47a17d30f7..75e653fec8 100644
--- a/src/rpc/virnetclient.c
+++ b/src/rpc/virnetclient.c
Let's use the defines provided by GLib, instead of keeping our own.
Fabiano Fidêncio (2):
util: Use G_DIR_SEPARATOR instead of VIR_FILE_DIR_SEPARATOR
util: Remove VIR_FILE_*_SEPARATOR*
src/util/virfile.c | 2 +-
src/util/virfile.h | 19 ---
2 files changed, 1 inse
None of those are used and we should prefer using the ones provided by
GLib, as G_DIR_SEPARATOR, G_DIR_SEPARATOR_S, G_SEARCHPATH_SEPARATOR, and
G_SEARCHPATH_SEPARATOR_S.
Signed-off-by: Fabiano Fidêncio
---
src/util/virfile.h | 19 ---
1 file changed, 19 deletions(-)
diff --git
Signed-off-by: Fabiano Fidêncio
---
src/util/virfile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virfile.c b/src/util/virfile.c
index b72d18b3d2..0f0d607c59 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -3278,7 +3278,7
The define is not used since virFileIsAbsPath() has been dropped.
Signed-off-by: Fabiano Fidêncio
---
src/util/virfile.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/util/virfile.h b/src/util/virfile.h
index 550d06ce94..3fd1795813 100644
--- a/src/util/virfile.h
+++ b/src/util
- virFileSkipRoot() is no longer used since faf2d811f3e9a4;
- virFileIsAbsPath() is no longer used since faf2d811f3e9a4;
- VIR_FILE_IS_DIR_SEPARATOR is no longer used since virFileIsAbsPath has
been dropped;
Fabiano Fidêncio (3):
util: Remove virFileSkipRoot()
util: Remove virFileIsAbsPath
The function is no longer used since commit faf2d811f3e9a4.
Signed-off-by: Fabiano Fidêncio
---
src/libvirt_private.syms | 1 -
src/util/virfile.c | 19 ---
src/util/virfile.h | 1 -
3 files changed, 21 deletions(-)
diff --git a/src/libvirt_private.syms b/src
The function is no longer used since commit faf2d811f3e9a4.
Signed-off-by: Fabiano Fidêncio
---
src/libvirt_private.syms | 1 -
src/util/virfile.c | 54
src/util/virfile.h | 1 -
3 files changed, 56 deletions(-)
diff --git a/src
> --
> 2.23.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Let's just use the plain g_get_home_dir(), from GLib, instead of
maintaining a code adapted from the GLib's one.
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 92 +-
1 file changed, 1 insertion(+), 91 deletions(-)
diff --git
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 39 ++-
1 file changed, 10 insertions(+), 29 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 7008c3119c..9d98b0051a 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 57 --
1 file changed, 10 insertions(+), 47 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 9d98b0051a..db9378fa57 100644
--- a/src/util/virutil.c
+++ b/src/util
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 39 ++-
1 file changed, 10 insertions(+), 29 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index db9378fa57..a28feb3daa 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
on Windows;
Changes since v1:
https://www.redhat.com/archives/libvir-list/2019-December/msg01055.html
- Don't check for the return of g_get_*_dir(), as it cannot be NULL;
Fabiano Fidêncio (4):
util: Rewrite virGetUserDirectory() using g_get_home_dir()
util: Rewrite virGetUserCon
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index ed1f696e37..7008c3119c 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -582,7 +582,7 @@ virGetHostnameQuiet(void
On Wed, Dec 18, 2019 at 5:08 PM Daniel P. Berrangé wrote:
>
> On Wed, Dec 18, 2019 at 10:53:41AM -0500, Cole Robinson wrote:
> > On 12/18/19 5:34 AM, Fabiano Fidêncio wrote:
> > > On Wed, Dec 18, 2019 at 11:19 AM Marc Hartmayer
> > > wrote:
> > >>
>
On Wed, Dec 18, 2019 at 11:19 AM Marc Hartmayer wrote:
>
> On Tue, Dec 17, 2019 at 05:41 PM +0100, Fabiano Fidêncio
> wrote:
> > Signed-off-by: Fabiano Fidêncio
> > ---
> > src/util/virutil.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 39 ++-
1 file changed, 10 insertions(+), 29 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 2e8b4e95b7..52b12126d7 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
_dir(), as it cannot be NULL;
Fabiano Fidêncio (4):
util: Rewrite virGetUserDirectory() using g_get_home_dir()
util: Rewrite virGetUserConfigDirectory() using
g_get_user_config_dir()
util: Rewrite virGetUserCacheDirectory() using g_get_user_cache_dir()
util: Rewrite virGetUserRunt
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 57 --
1 file changed, 10 insertions(+), 47 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 1bcdde9ad6..2e8b4e95b7 100644
--- a/src/util/virutil.c
+++ b/src/util
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index ed1f696e37..7008c3119c 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -582,7 +582,7 @@ virGetHostnameQuiet(void
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 39 ++-
1 file changed, 10 insertions(+), 29 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 7008c3119c..1bcdde9ad6 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 53 ++
1 file changed, 6 insertions(+), 47 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 63680974b8..9485316e05 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index ed1f696e37..8c255abd7f 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -582,7 +582,7 @@ virGetHostnameQuiet(void
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 35 ++-
1 file changed, 6 insertions(+), 29 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 9485316e05..10bf96f193 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -598,6
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 35 ++-
1 file changed, 6 insertions(+), 29 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 8c255abd7f..63680974b8 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -586,6
r the return of g_get_*_dir(), as it cannot be NULL;
Fabiano Fidêncio (4):
util: Rewrite virGetUserDirectory() using g_get_home_dir()
util: Rewrite virGetUserConfigDirectory() using
g_get_user_config_dir()
util: Rewrite virGetUserCacheDirectory() using g_get_user_cache_dir()
util: Re
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 40 +++-
1 file changed, 11 insertions(+), 29 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 993a959555..62cb3390f8 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
By rewriting virGetUser*Directory() functions using g_get_*_dir()
functions allows us to drop all the different implementations we
keep, as GLib already takes care of those for us.
Fabiano Fidêncio (4):
util: Rewrite virGetUserDirectory() using g_get_home_dir()
util: Rewrite
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 40 +++-
1 file changed, 11 insertions(+), 29 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 70a05e3c9b..6fae3e8288 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 58 +-
1 file changed, 11 insertions(+), 47 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 6fae3e8288..993a959555 100644
--- a/src/util/virutil.c
+++ b/src/util
Signed-off-by: Fabiano Fidêncio
---
src/util/virutil.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index ed1f696e37..70a05e3c9b 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -582,7 +582,13 @@ virGetHostnameQuiet
OpenVZ has been added as part of commit 0a7993d3ed30ae. However, it's
wrongly set to be installed on any supported CentOS.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/update/tasks/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/playbooks/update/tasks/base.y
This series consists in two simple patches:
- Mention CentOS8 as a valid OS version;
- Only install OpenVZ on CentOS 7;
Fabiano Fidêncio (2):
guests: Mention CentOS8 as a valid OS version
guests: Only install OpenVZ on CentOS 7
guests/playbooks/update/tasks/base.yml | 1 +
guests/vars
CentOS8 has been added as part of 03fd3a8ef16a3c4. However, it was not
mentioned as a valid OS version.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index
| 5 +
> guests/vars/projects/libvirt.yml | 1 +
> 5 files changed, 20 insertions(+), 9 deletions(-)
> create mode 100644 guests/host_vars/libvirt-opensuse-151/docker.yml
>
> --
> 2.23.0
>
There's one suggestion in the last patch. Please, t
On Thu, Dec 12, 2019 at 3:31 PM Andrea Bolognani wrote:
>
> Some distributions package augeas and the default lenses separately,
> so we need a mapping for the latter.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/vars/mappings.yml | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git
> +
IMHO, it'd be easier to follow / cleaner if we do:
if os_name != "OpenSUSE:"
commands.extend([
"{package_manager} autoremove -y",
])
And then, later on ...
commands.extend([
"{package_manager} clean all -y",
])
[snip]
Best Regards,
-
On Thu, Dec 12, 2019 at 3:05 PM Andrea Bolognani wrote:
>
> On Thu, 2019-12-12 at 14:49 +0100, Fabiano Fidêncio wrote:
> > > +commands.extend([
> > > +"{package_manager} update -y",
> > > +
33 insertions(+), 33 deletions(-)
>
> --
> 2.23.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
t do you think?
Mind, I'm not pushing for the mapping, just pointing it out. :-). I'm
fine with an `if os_name != "OpenSUSE": ...`
[snip]
Best Regards,
--
Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Dec 12, 2019 at 12:43 PM Andrea Bolognani wrote:
>
> Both the 'X' and 'centosX' tags are available on the registry, and
> they point to the same image; the former looks more natural though,
> so let's use that one.
>
> Signed-off-by: Andre
a, that was *my* bad. Sorry.
>
> Signed-off-by: Andrea Bolognani
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
glibc-langpack-en is present on all supported Fedoras and CentOS 8. It's
needed in order to set a locale to en_US, which is done as part of
osinfo-db tests (at least).
Signed-off-by: Fabiano Fidêncio
---
guests/vars/projects/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/g
Unfortunately, due to really stripped CentOS 8 containers, we have to
explicitly add glibc-langpack-en package in order to fulfil the osinfo-db
tests needs.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/guests/vars
INTERNALERROR> File "/builds/fidencio/osinfo-db/tests/conftest.py", line
27, in pytest_configure
1233 INTERNALERROR> locale.setlocale(locale.LC_CTYPE, 'en_US.UTF-8')
1234 INTERNALERROR> File "/usr/lib64/python3.6/locale.py", line 598, in
setlocale
1235 INTE
this point I'd rather disable CentOS 7 builds than not enable CentOS 8.
Anyways, Reviewed-by: Fabiano Fidêncio
Best Regards,
--
Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
- libvirt-fedora-30
> - libvirt-fedora-31
> - libvirt-fedora-rawhide
> +- libvirt-freebsd-11
> +- libvirt-freebsd-12
>- python-distutils-rpm-job:
>parent_jobs: 'virt-manager-check'
>machines:
On Wed, Dec 11, 2019 at 1:33 PM Andrea Bolognani wrote:
>
> On Wed, 2019-12-11 at 13:26 +0100, Fabiano Fidêncio wrote:
> > And this is the fixup for this one:
> > ```
> > diff --git a/guests/lcitool b/guests/lcitool
> > index 059b789..c28c414 100755
> > -
On Wed, Dec 11, 2019 at 10:32 AM Andrea Bolognani wrote:
>
> On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> > +++ b/guests/playbooks/update/tasks/base.yml
> > +- name: Enable PowerTools repository
> > + command: '{{ package_manager }} config-manager --s
On Wed, Dec 11, 2019 at 10:44 AM Fabiano Fidêncio wrote:
>
> On Wed, Dec 11, 2019 at 10:31 AM Andrea Bolognani wrote:
> >
> > On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> > > +++ b/guests/playbooks/update/tasks/base.yml
> > > @@ -15
On Wed, Dec 11, 2019 at 10:31 AM Andrea Bolognani wrote:
>
> On Tue, 2019-12-10 at 16:38 +0100, Fabiano Fidêncio wrote:
> > +++ b/guests/playbooks/update/tasks/base.yml
> > @@ -15,7 +15,6 @@
> > state: latest
> >when:
> > - os_name == 'Cent
On Sat, Dec 7, 2019 at 4:43 PM Fabiano Fidêncio wrote:
>
> Fedora 29 has reached its EOL on November 26th 2019;
> librbd1-devel has been replaced by librbd-devel;
> librados2-devel has been replaced by librados;
>
> Fabiano Fidêncio (2):
> spec: Update Fedora minimum suppo
"expected" filename, preferably using the same
name of the template, as some of the distros require that.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/lcitool | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/guests/lcit
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/build/jobs/defaults.yml| 2 ++
guests/playbooks/build/projects/libosinfo.yml | 1 +
guests/playbooks/build/projects/libvirt-dbus.yml| 2 ++
guests/playbooks/build/projects/libvirt.yml | 1 +
guests/playbooks/build
and gtk-vnc2-devel, virt-viewer dependencies, are not
present anymore:
-
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html-single/considerations_in_adopting_rhel_8/index#removed-packages_changes-to-packages
Signed-off-by: Fabiano Fidêncio
---
guests/vars
ssing dependencies are:
- libvirt-cim
- libvirt-sandbox
- libvirt-tck
Fabiano Fidêncio (8):
lcitool: Generate the unattended script file
lcitool: Use install_url in the unattended install files
guests: Add CentOS 8
mappings: Adjustments for CentOS 8
guests: Install EPEL repo on all CentOS g
itory;
- PowerTools is needed because the development packages are
distributed via this repo;
- There's *no* project supported;
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/docker.yml | 2 ++
guests/host_vars/libvirt-centos-8/install.yml | 2 ++
guests/host_va
/red_hat_enterprise_linux/8/html/performing_an_advanced_rhel_installation/kickstart-commands-and-options-reference_installing-rhel-as-an-experienced-user
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/configs/kickstart.cfg | 6 ++
guests/lcitool | 9
This is needed as all the development packages will come from the
PowerTools repository, which is not enabled by default.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/playbooks/update/tasks/base.yml | 8
1 file changed, 8 insertions(+)
diff --git a/guests
EPEL repository should be enabled on all supported CentOS guests as it
brings in packages which are part of the "base packages" for
libvirt-jenkins-ci.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/playbooks/update/tasks/base.yml | 1 -
1 file changed,
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 15 +++
1 file changed, 15 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index a147183..aae2313 100644
--- a/guests/host_vars
0 deletions(-)
>
> --
> 2.23.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/osinfo-db-tools.yml | 1 +
jenkins/projects/osinfo-db-tools.yaml | 1 +
3 files changed, 3 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index 61ef995..e764964 100644
--- a/guests/host_vars/libvirt-centos-8
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/libvirt-go.yml | 1 +
jenkins/projects/libvirt-go.yaml | 1 +
3 files changed, 3 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml| 1 +
guests/playbooks/build/projects/libosinfo.yml | 1 +
jenkins/projects/libosinfo.yaml | 1 +
3 files changed, 3 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index 793ad3e..63ac54b 100644
--- a/guests/host_vars/libvirt-centos-8
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index 93e66e3..793ad3e 100644
--- a/guests/host_vars/libvirt-centos-8
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/libvirt-go-xml.yml | 1 +
jenkins/projects/libvirt-go-xml.yaml | 1 +
3 files changed, 3 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8
Seems that for all OSes where run libvirt-dbus tests python3-entrypoints
is pulled together when installing flake8. However, this is not the case
for CentOS 8 and that's the reason for explicitly adding the dependency
here.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mapping
Seems that for all OSes where run libvirt-dbus tests python3-pyflakes is
pulled together when installing flake8. However, this is not the case
for CentOS 8 and that's the reason for explicitly adding the dependency
here.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mapping
itory;
- PowerTools is needed because the development packages are
distributed via this repo;
- There's *no* project supported;
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/docker.yml | 2 ++
guests/host_vars/libvirt-centos-8/install.yml | 2 ++
guests/host_va
/red_hat_enterprise_linux/8/html/performing_an_advanced_rhel_installation/kickstart-commands-and-options-reference_installing-rhel-as-an-experienced-user
Signed-off-by: Fabiano Fidêncio
---
guests/configs/kickstart.cfg | 4
guests/lcitool | 10 ++
2 files changed, 14
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/libvirt-dbus.yml | 2 ++
jenkins/projects/libvirt-dbus.yaml | 2 ++
3 files changed, 5 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/playbooks/build/projects/virt-manager.yml | 3 +++
jenkins/projects/virt-manager.yaml | 3 +++
3 files changed, 7 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index 7a55c4b..93e66e3 100644
--- a/guests/host_vars/libvirt-centos-8
/considerations_in_adopting_rhel_8/index#removed-packages_changes-to-packages
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
guests/vars/mappings.yml | 2 ++
2 files changed, 3 insertions(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
Seems that for all OSes where we run libvirt-dbus tests python3-mccabe
is pulled together when installing flake8. However, this is not the case
for CentOS 8 and that's the reason for explicitly adding the dependency
here.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mapping
#literal_libssh2_literal_is_not_available_in_rhel_8
- librbd1-devel has been replaced by librdb-devel:
-
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html-single/considerations_in_adopting_rhel_8/index#package-replacements_changes-to-packages
Signed-off-by: Fabiano
Seems that for all OSes where run libvirt-dbus tests python3-pycodestile
is pulled together when installing flake8. However, this is not the case
for CentOS 8 and that's the reason for explicitly adding the dependency
here.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mapping
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-8/main.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/host_vars/libvirt-centos-8/main.yml
b/guests/host_vars/libvirt-centos-8/main.yml
index b924f1f..06a7844 100644
--- a/guests/host_vars/libvirt-centos-8
"expected" filename, preferrably using the same
name of the template, as some of the distros require that.
Signed-off-by: Fabiano Fidêncio
---
guests/lcitool | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/guests/lcitool b/guests/lcitool
index 8436ce7..
ssing dependencies are:
- libvirt-cim
- libvirt-sandbox
- libvirt-tck
This series is written atop of:
https://www.redhat.com/archives/libvir-list/2019-December/msg00461.html
Fabiano Fidêncio (22):
lcitool: Generate the unattended script file
guests,lcitool: Use install_url in the unattended in
EPEL repository should be enabled on all supported CentOS guests as it
brings in packages which are part of the "base packages" for
libvirt-jenkins-ci.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/update/tasks/base.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests
This is needed as all the development packages will come from the
PowerTools repository, which is not enabled by default.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/update/tasks/base.yml | 8
1 file changed, 8 insertions(+)
diff --git a/guests/playbooks/update/tasks/base.yml
nvention to existing Ubuntu
> targets in order to maintain consistency.
>
> Signed-off-by: Andrea Bolognani
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Sat, Dec 7, 2019 at 4:43 PM Fabiano Fidêncio wrote:
>
> Fedora 29 has reached its end of life on November 26th 2019.
>
> For more info, please, refer to the following e-mail:
> https://lists.fedoraproject.org/archives/list/devel-annou...@lists.fedoraproject.org/thread/
&g
'Linux'
distribution = 'Opensuse-leap'
strategy_class = SystemdStrategy
```
Maybe it's worth a bug report in order to have it backported to the
ansible package you have in your distro.
The same goes with the patch I've submitted adding Opensuse-tumbleweed.
B
Fedora 29 has reached its end of life on November 26th 2019.
For more info, please, refer to the following e-mail:
https://lists.fedoraproject.org/archives/list/devel-annou...@lists.fedoraproject.org/thread/
Signed-off-by: Fabiano Fidêncio
---
libvirt.spec.in | 2 +-
1 file changed, 1
/red_hat_enterprise_linux/8/html-single/considerations_in_adopting_rhel_8/index
Signed-off-by: Fabiano Fidêncio
---
libvirt.spec.in | 5 +
1 file changed, 5 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 2b2761674c..42ef43aa11 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -335,9 +335,14
Fedora 29 has reached its EOL on November 26th 2019;
librbd1-devel has been replaced by librbd-devel;
librados2-devel has been replaced by librados;
Fabiano Fidêncio (2):
spec: Update Fedora minimum supported version
spec: Adjust librbd / librados dependency names
libvirt.spec.in | 7
stros
will just ignore the argument passed.
Signed-off-by: Fabiano Fidêncio
---
I've verified this solution works on a CentOS 7 host. I've verified this
solution doesn't cause regressions on a Fedora 31 host.
---
guests/lcitool | 9 +++--
1 file changed, 7 insertions(+), 2 del
ckage_format: 'rpm'
> package_manager: 'yum'
> os_name: 'CentOS'
> os_version: '7'
> -
> -ansible_python_interpreter: /usr/bin/python2
We cannot do that, unfortunately.
I've tried, in the past, but "yum" ansible module req
very same approach.
Signed-off-by: Fabiano Fidêncio
---
docs/libvirt-glib/Libvirt-glib-docs.xml | 4
1 file changed, 4 deletions(-)
diff --git a/docs/libvirt-glib/Libvirt-glib-docs.xml
b/docs/libvirt-glib/Libvirt-glib-docs.xml
index f2f3572..505f138 100644
--- a/docs/libvirt-glib/Libvirt
> > > > 'lci update ... libvirt' fails in task "Configure hostname":
> > > >
> > > > fatal: [libvirt-opensuse-tumbleweed]: FAILED! => {"changed": false,
> > > > "msg": "hostname module cannot be used on platform Linux
> > > > (Opensuse-tumbleweed)"}
> > >
> > > It seems to be an Ansible bug:
> >
Andrea,
> It sounds like we can just provide install= unconditionally, same as
> we currently do with ks=? We'd have to verify doing so doesn't cause
> any unintended side-effects for existing guest types.
I'd rather have it done in a more explicit way, just for the sake of
someone else trying to
the "install=" to the kernel command line, we're fine.
I'll cook some patches in the afternoon and post them.
An important question ... can't we have / use a CentOS 8 machine?
Would be lovely to not have to work those issues around on lcitool.
Best Regards,
--
Fabiano Fi
On Mon, Dec 2, 2019 at 8:33 PM Andrea Bolognani wrote:
>
> On Mon, 2019-12-02 at 16:41 +0100, Fabiano Fidêncio wrote:
> > Jim,
> >
> > Firstly, sorry it took so long for me to give it a try in your patch.
> >
> > Now, comments inline ...
> >
> > O
Create group and user separately
>
> guests/playbooks/update/tasks/paths.yml | 2 +-
> guests/playbooks/update/tasks/users.yml | 6 ++
> 2 files changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Fabiano Fidêncio
And also feels like Signed-off-by: Fabiano Fidêncio :-)
Best Regards,
101 - 200 of 626 matches
Mail list logo
