Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-03 Thread Andrea Bolognani
On Mon, 2019-12-02 at 20:33 +0100, Andrea Bolognani wrote: > > On Tue, Nov 26, 2019 at 1:52 AM Jim Fehlig wrote: > > > +++ b/guests/host_vars/libvirt-opensuse-15/main.yml > > > @@ -0,0 +1,22 @@ > > > +--- > > > +projects: > > > + - libosinfo > > > + - libvirt > > > + - libvirt-cim > > > + -

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-03 Thread Andrea Bolognani
On Tue, 2019-12-03 at 13:54 +0100, Fabiano Fidêncio wrote: > > > > > 'lci update ... libvirt' fails in task "Configure hostname": > > > > > > > > > > fatal: [libvirt-opensuse-tumbleweed]: FAILED! => {"changed": false, > > > > > "msg": "hostname module cannot be used on platform Linux > > > > >

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-03 Thread Fabiano Fidêncio
> > > > 'lci update ... libvirt' fails in task "Configure hostname": > > > > > > > > fatal: [libvirt-opensuse-tumbleweed]: FAILED! => {"changed": false, > > > > "msg": "hostname module cannot be used on platform Linux > > > > (Opensuse-tumbleweed)"} > > > > > > It seems to be an Ansible bug: >

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-03 Thread Andrea Bolognani
On Tue, 2019-12-03 at 11:50 +0100, Fabiano Fidêncio wrote: > > It sounds like we can just provide install= unconditionally, same as > > we currently do with ks=? We'd have to verify doing so doesn't cause > > any unintended side-effects for existing guest types. > > I'd rather have it done in a

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-03 Thread Fabiano Fidêncio
Andrea, > It sounds like we can just provide install= unconditionally, same as > we currently do with ks=? We'd have to verify doing so doesn't cause > any unintended side-effects for existing guest types. I'd rather have it done in a more explicit way, just for the sake of someone else trying

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-03 Thread Andrea Bolognani
On Tue, 2019-12-03 at 11:05 +0100, Fabiano Fidêncio wrote: > > Speaking of which: I've run into a fairly major problem with > > the Leap 15.1 support enabled by this patch: while unattended > > installation works as expected on my laptop (Fedora 31), when I try > > the same steps on the CentOS CI

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-03 Thread Fabiano Fidêncio
Andrea, > > Speaking of which: I've run into a fairly major problem with > the Leap 15.1 support enabled by this patch: while unattended > installation works as expected on my laptop (Fedora 31), when I try > the same steps on the CentOS CI production environment (CentOS 7.5) > it doesn't seem to

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-02 Thread Fabiano Fidêncio
On Mon, Dec 2, 2019 at 8:33 PM Andrea Bolognani wrote: > > On Mon, 2019-12-02 at 16:41 +0100, Fabiano Fidêncio wrote: > > Jim, > > > > Firstly, sorry it took so long for me to give it a try in your patch. > > > > Now, comments inline ... > > > > On Tue, Nov 26, 2019 at 1:52 AM Jim Fehlig wrote:

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-02 Thread Andrea Bolognani
On Mon, 2019-12-02 at 16:41 +0100, Fabiano Fidêncio wrote: > Jim, > > Firstly, sorry it took so long for me to give it a try in your patch. > > Now, comments inline ... > > On Tue, Nov 26, 2019 at 1:52 AM Jim Fehlig wrote: > > This change adds support for the latest openSUSE Leap and > >

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-02 Thread Fabiano Fidêncio
On Mon, Dec 2, 2019 at 4:41 PM Fabiano Fidêncio wrote: > > Jim, > > Firstly, sorry it took so long for me to give it a try in your patch. > > Now, comments inline ... > > On Tue, Nov 26, 2019 at 1:52 AM Jim Fehlig wrote: > > > > This change adds support for the latest openSUSE Leap and > >

Re: [libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-12-02 Thread Fabiano Fidêncio
Jim, Firstly, sorry it took so long for me to give it a try in your patch. Now, comments inline ... On Tue, Nov 26, 2019 at 1:52 AM Jim Fehlig wrote: > > This change adds support for the latest openSUSE Leap and > openSUSE Tumbleweed guests. > > Signed-off-by: Jim Fehlig > --- > > This

[libvirt] [PATCH RFC V2] guests: Add support for openSUSE

2019-11-25 Thread Jim Fehlig
This change adds support for the latest openSUSE Leap and openSUSE Tumbleweed guests. Signed-off-by: Jim Fehlig --- This version of the patch overcomes the 'lci build' issues noted in V1 and works well for openSUSE Leap 15.1 and Tumbleweed. I'm still of the opinion of only supporting the latest