Am 18.01.2012 17:22, schrieb Eric Blake:
On 11/23/2011 02:18 AM, Stefan Hajnoczi wrote:
Notes: Now all the planed features were implemented (#1#2 were
implemented by
Zhi Yong Wu), the previous comments were all fixed up too. And the qemu
part patches
have been accepted upstream and are
- Original Message -
From: Alex Jia a...@redhat.com
To: Guan Nan Ren g...@redhat.com
Cc: libvir-list@redhat.com
Sent: Thursday, January 19, 2012 1:39:58 PM
Subject: Re: [libvirt] [PATCH] Add two NUMA tuning python bindings APIs
On 01/19/2012 11:29 AM, Alex Jia wrote:
On 01/19/2012
*virDomainSetNumaParameters
*virDomainGetNumaParameters
---
python/libvirt-override-api.xml | 13 +++
python/libvirt-override.c | 186 +++
2 files changed, 199 insertions(+), 0 deletions(-)
diff --git a/python/libvirt-override-api.xml
On 01/19/2012 04:54 PM, Guan Nan Ren wrote:
- Original Message -
From: Alex Jiaa...@redhat.com
To: Guan Nan Reng...@redhat.com
Cc: libvir-list@redhat.com
Sent: Thursday, January 19, 2012 1:39:58 PM
Subject: Re: [libvirt] [PATCH] Add two NUMA tuning python bindings APIs
On 01/19/2012
On Wed, Jan 18, 2012 at 05:07:16PM -0700, Eric Blake wrote:
If others like my thoughts, can you respin your patch series to adjust
your API accordingly?
Sounds good to me.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual
On 18.01.2012 19:56, berra...@redhat.com wrote:
Overall status: failed
Start date: Wed Jan 18 2012
Start time: 18:32:52 UTC / 18:32:52 GMT
Build counter: 1326911571
Build timestamp: 1326911571
URL: http://dhcp-0-241.camlab.fab.redhat.com/index.html
Module: libvirt
Status: failed
URL:
On Thu, Jan 19, 2012 at 11:07:54AM +0100, Michal Privoznik wrote:
On 18.01.2012 19:56, berra...@redhat.com wrote:
Overall status: failed
Start date: Wed Jan 18 2012
Start time: 18:32:52 UTC / 18:32:52 GMT
Build counter: 1326911571
Build timestamp: 1326911571
URL:
On Wed, Jan 18, 2012 at 09:22:01AM -0700, Eric Blake wrote:
On 11/23/2011 02:18 AM, Stefan Hajnoczi wrote:
Notes: Now all the planed features were implemented (#1#2 were
implemented by
Zhi Yong Wu), the previous comments were all fixed up too. And the qemu
part patches
have been
Overall status: failed
Start date: Thu Jan 19 2012
Start time: 12:26:32 UTC / 12:26:32 GMT
Build counter: 1326975992
Build timestamp: 1326975992
URL: http://t500wlan.home.berrange.com/index.html
Module: libvirt
Status: failed
URL: http://t500wlan.home.berrange.com/module-libvirt.html
--
On Wed, Jan 18, 2012 at 05:28:47PM +0100, Michal Privoznik wrote:
On 04.01.2012 00:47, Peter Krempa wrote:
-if (verr verr-code == VIR_ERR_NO_SUPPORT) {
-/* Missing RPC - old server - ignore */
-virResetLastError();
-return 0;
+if
This patch introduces a new structure called virErrorsPtr which can get all
the errors that occurred since the connection open. The error callback function
is being used as many times as necessary. The new public function called
virGetAllErrors() has been introduced to get all the errors that
On 01/19/2012 03:07 AM, Michal Privoznik wrote:
On 18.01.2012 19:56, berra...@redhat.com wrote:
Overall status: failed
Start date: Wed Jan 18 2012
Start time: 18:32:52 UTC / 18:32:52 GMT
Build counter: 1326911571
Build timestamp: 1326911571
URL:
Oops, I'm sorry as this didn't pass the syntax check.
To pass the syntax check the new add-on patch is necessary:
diff --git a/src/util/virterror.c b/src/util/virterror.c
index b03ae7c..55269b9 100644
--- a/src/util/virterror.c
+++ b/src/util/virterror.c
@@ -198,8 +198,7 @@
On Thu, Jan 19, 2012 at 02:13:59PM +0100, Michal Novotny wrote:
This patch introduces a new structure called virErrorsPtr which can get all
the errors that occurred since the connection open. The error callback
function
is being used as many times as necessary. The new public function called
On 01/19/2012 02:20 PM, Daniel P. Berrange wrote:
On Thu, Jan 19, 2012 at 02:13:59PM +0100, Michal Novotny wrote:
This patch introduces a new structure called virErrorsPtr which can get all
the errors that occurred since the connection open. The error callback
function
is being used as many
On Thu, Jan 19, 2012 at 02:25:55PM +0100, Michal Novotny wrote:
On 01/19/2012 02:20 PM, Daniel P. Berrange wrote:
On Thu, Jan 19, 2012 at 02:13:59PM +0100, Michal Novotny wrote:
This patch introduces a new structure called virErrorsPtr which can get all
the errors that occurred since the
On 01/19/2012 02:28 PM, Daniel P. Berrange wrote:
On Thu, Jan 19, 2012 at 02:25:55PM +0100, Michal Novotny wrote:
On 01/19/2012 02:20 PM, Daniel P. Berrange wrote:
On Thu, Jan 19, 2012 at 02:13:59PM +0100, Michal Novotny wrote:
This patch introduces a new structure called virErrorsPtr which
From: Daniel P. Berrange berra...@redhat.com
* daemon/remote.c: remoteSASLFinish called the method
virNetSASLSessionGetIdentity twice, remove second call
---
daemon/remote.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index
The following patches aren't really needed on their own, rather
they are part of the role based access control work I'm doing.
In order to keep my patch queue small, I'm sending these out
now, since there is no harm in merging them
--
libvir-list mailing list
libvir-list@redhat.com
From: Daniel P. Berrange berra...@redhat.com
To avoid a namespace clash with forthcoming identity APIs,
rename the virNet*GetLocalIdentity() APIs to have the form
virNet*GetUNIXIdentity()
* daemon/remote.c, src/libvirt_private.syms: Update
for renamed APIs
* src/rpc/virnetserverclient.c,
From: Daniel P. Berrange berra...@redhat.com
---
src/libvirt_private.syms |1 +
src/util/util.c | 55 ++
src/util/util.h |1 +
3 files changed, 57 insertions(+), 0 deletions(-)
diff --git a/src/libvirt_private.syms
From: Daniel P. Berrange berra...@redhat.com
* daemon/remote.c, src/rpc/virnetserverclient.c,
src/rpc/virnetserverclient.h, src/rpc/virnetsocket.c,
src/rpc/virnetsocket.h: Add gid parameter
---
daemon/remote.c |9 ++---
src/rpc/virnetserverclient.c |4 ++--
From: Daniel P. Berrange berra...@redhat.com
The RPC generator transforms methods matching certain
patterns like 'id' or 'uuid', etc but does not anchor
its matches to the end of the word. So if a method
contains 'id' in the middle (eg virIdentity) then the
RPC generator munges that.
*
On 01/19/2012 06:51 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
To avoid a namespace clash with forthcoming identity APIs,
rename the virNet*GetLocalIdentity() APIs to have the form
virNet*GetUNIXIdentity()
* daemon/remote.c, src/libvirt_private.syms: Update
On 01/19/2012 07:21 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The RPC generator transforms methods matching certain
patterns like 'id' or 'uuid', etc but does not anchor
its matches to the end of the word. So if a method
contains 'id' in the middle (eg
sir
i am trying to create ssh connention and i am able to connect with out
password from terminal using
virsh -c qemu+ssh://punit@192.168.102.133/system
but this is not working with libvirt-php binding
error :for libvirt-php ssh connection
Libvirt last error: cannot recv data: Resource
sir
i am able to connect to local system an gett all the parameters but i am
not able to get screen shots
it gives error
Cannot find gvnccapture binary
--
Punit Gupta
M-Tect (jiit noida)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Hi,
you have to install gvnc-tools package on your Fedora box (as you
mentioned you're using Fedora). This is having the gvnccapture binary.
Michal
On 01/19/2012 04:43 PM, punit gupta wrote:
sir
i am able to connect to local system an gett all the parameters but
i am not able to get screen
Oh, that's interesting. So you can connect fine with the virsh but not
libvirt-php?
Now I may see your point, the issue is in the apache user. You need to
use the apache-key-copy utility (bundled with the php-virt-control) to
generate a key to your apache user account (provided the fact your
On Wed, Jan 18, 2012 at 04:50:41PM +0100, Christophe Fergeau wrote:
By changing gvir_config_xml_foreach_child to make it robust against
current node deletion in the foreach callback, we can use
gvir_config_object_foreach_child to implement
gvir_config_object_delete_child
---
On Wed, Jan 18, 2012 at 04:50:42PM +0100, Christophe Fergeau wrote:
---
libvirt-gconfig/libvirt-gconfig-object-private.h |1 +
libvirt-gconfig/libvirt-gconfig-object.c | 13 +
2 files changed, 14 insertions(+), 0 deletions(-)
ACK
Daniel
--
|: http://berrange.com
On Wed, Jan 18, 2012 at 04:50:43PM +0100, Christophe Fergeau wrote:
Most of the time we want gvir_config_object_attach to replace
existing nodes, but sometimes (for devices subnodes) we want
it to append the new node and to keep the existing nodes with
the same name. This commit solves this by
On Wed, Jan 18, 2012 at 04:50:44PM +0100, Christophe Fergeau wrote:
These 2 GVirObject helpers are declared in libvirt-gobject-private.h
and so shouldn't be exported.
---
libvirt-gconfig/libvirt-gconfig.sym |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git
On 01/19/2012 08:56 AM, Luiz Capitulino wrote:
Long ago, commit 625a5be added the guest provided memory statistics to
the query-balloon command. Unfortunately, it also introduced a severe
bug: query-balloon would hang if the guest didn't respond. This, in turn,
would also cause a hang in
Hello All,
When using a systemtap to get a call chain of functions that are executed
during the migration of a vm from one host to another I realised that many of
the symbols in libvirt are hidden and not visible to systemtap.
Is there a way I can make all the symbols visible just for
On Thu, Jan 19, 2012 at 05:16:48PM +, Shradha Shah wrote:
Hello All,
When using a systemtap to get a call chain of functions that are executed
during the migration of a vm from one host to another I realised that many of
the symbols in libvirt are hidden and not visible to systemtap.
We had a memory leak on a very arcane OOM situation (unlikely to ever
hit in practice, but who knows if libvirt.so would ever be linked
into some other program that exhausts all thread-local storage keys?).
I found it by code inspection, while analyzing a valgrind report
generated by Alex Jia.
*
Gnulib claims that there are some classes of warnings that are
worth enabling during development, but where silencing those
warnings causes code bloat that is not necessary in an optimized
build. The code bloat to silence the warnings is only enabled
by -Dlint. Follow the lead of coreutils in
Based on qemu changes made in commits ae523427 and 659ded58.
* src/lxc/lxc_driver.c (lxcSetSchedulerParametersFlags)
(lxcGetSchedulerParametersFlags, lxcDomainSetBlkioParameters)
(lxcDomainGetBlkioParameters): Use helpers.
(lxcDomainSetBlkioParameters): Allow setting live and config at
once.
---
While we still don't want to enable gcc's new -Wformat-literal
warning, I found a rather easy case where the warning could be
reduced, by getting rid of obsolete error-reporting practices.
This is the last place where we were passing the (unused) net
and conn arguments for constructing an error.
Preparation for another patch that refactors common patterns
into the new file for fewer lines of code overall.
* src/util/util.h (virTypedParameterArrayClear): Move...
* src/util/virtypedparam.h: ...to new file.
(virTypedParameterArrayValidate, virTypedParameterAssign): New
prototypes.
*
On Thu, Jan 19, 2012 at 11:44:46AM -0700, Eric Blake wrote:
While we still don't want to enable gcc's new -Wformat-literal
warning, I found a rather easy case where the warning could be
reduced, by getting rid of obsolete error-reporting practices.
This is the last place where we were passing
On Thu, Jan 19, 2012 at 11:44:41AM -0700, Eric Blake wrote:
We had a memory leak on a very arcane OOM situation (unlikely to ever
hit in practice, but who knows if libvirt.so would ever be linked
into some other program that exhausts all thread-local storage keys?).
I found it by code
I think I've posted all of these before, but with no reviews yet.
Eric Blake (6):
threads: check for failure to set thread-local value
build: silence some compiler warnings from gnulib
lxc: use live/config helper
util: add new file for virTypedParameter utils
util: use new
On Thu, Jan 19, 2012 at 11:44:43AM -0700, Eric Blake wrote:
Based on qemu changes made in commits ae523427 and 659ded58.
* src/lxc/lxc_driver.c (lxcSetSchedulerParametersFlags)
(lxcGetSchedulerParametersFlags, lxcDomainSetBlkioParameters)
(lxcDomainGetBlkioParameters): Use helpers.
On Thu, Jan 19, 2012 at 11:44:42AM -0700, Eric Blake wrote:
Gnulib claims that there are some classes of warnings that are
worth enabling during development, but where silencing those
warnings causes code bloat that is not necessary in an optimized
build. The code bloat to silence the
On Thu, Jan 19, 2012 at 11:44:44AM -0700, Eric Blake wrote:
Preparation for another patch that refactors common patterns
into the new file for fewer lines of code overall.
* src/util/util.h (virTypedParameterArrayClear): Move...
* src/util/virtypedparam.h: ...to new file.
On Thu, Jan 19, 2012 at 11:44:45AM -0700, Eric Blake wrote:
Reusing common code makes things smaller; it also buys us some
additional safety, such as now rejecting duplicate parameters
during a set operation.
* src/qemu/qemu_driver.c (qemuDomainSetBlkioParameters)
On 01/19/2012 12:01 PM, Daniel P. Berrange wrote:
+
+VIR_ENUM_DECL(virTypedParameter)
+VIR_ENUM_IMPL(virTypedParameter, VIR_TYPED_PARAM_STRING + 1,
I'm slowly coming to the view that we should juust add _LAST to
every single one of our public enums.
But perhaps have them disabled by
On 01/19/2012 12:21 PM, Daniel P. Berrange wrote:
On Thu, Jan 19, 2012 at 11:44:45AM -0700, Eric Blake wrote:
Reusing common code makes things smaller; it also buys us some
additional safety, such as now rejecting duplicate parameters
during a set operation.
@@ -2968,42 +2922,25 @@
On 01/18/2012 03:04 AM, a...@redhat.com wrote:
From: Alex Jia a...@redhat.com
Detected by valgrind. Leaks introduced in commit 973af236.
* src/network/bridge_driver.c: fix memory leaks on failure and successful
path.
* How to reproduce?
% make -C tests check TESTS=networkxml2argvtest
On Wed, Jan 18, 2012 at 12:59:29PM -0500, Federico Simoncelli wrote:
- Original Message -
From: Adam Litke a...@us.ibm.com
To: Dave Allan dal...@redhat.com
Cc: libvir-list@redhat.com
Sent: Friday, January 13, 2012 9:51:23 PM
Subject: [libvirt] [PATCH] BlockJob: Support
On Thu, Jan 19, 2012 at 01:32:08PM -0700, Eric Blake wrote:
On 01/18/2012 12:38 AM, Taku Izumi wrote:
I am now wondering if we should do this in a different way. ie if
there is some XML configuration parameter for the disk that
indicates the need for rawio, then libvirt could automatically
On Thu, Jan 19, 2012 at 01:16:01PM -0700, Eric Blake wrote:
On 01/19/2012 12:01 PM, Daniel P. Berrange wrote:
+
+VIR_ENUM_DECL(virTypedParameter)
+VIR_ENUM_IMPL(virTypedParameter, VIR_TYPED_PARAM_STRING + 1,
I'm slowly coming to the view that we should juust add _LAST to
every single
On 01/19/2012 02:10 PM, Daniel P. Berrange wrote:
On Thu, Jan 19, 2012 at 01:32:08PM -0700, Eric Blake wrote:
On 01/18/2012 12:38 AM, Taku Izumi wrote:
I am now wondering if we should do this in a different way. ie if
there is some XML configuration parameter for the disk that
indicates the
On 01/17/2012 04:44 AM, Michal Privoznik wrote:
There is now a standard QEMU guest agent that can be installed
and given a virtio serial channel
channel type='unix'
source mode='bind' path='/var/lib/libvirt/qemu/f16x86_64.agent'/
Do we really want to be documenting a path in the
On 01/17/2012 04:44 AM, Michal Privoznik wrote:
Add a new API virDomainShutdownFlags and define:
VIR_DOMAIN_SHUTDOWN_DEFAULT= 0,
VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN = (1 0),
VIR_DOMAIN_SHUTDOWN_GUEST_AGENT= (1 1),
Also define some flags for the reboot API
On 01/17/2012 04:44 AM, Michal Privoznik wrote:
This makes use of the QEMU guest agent to implement the
virDomainShutdownFlags and virDomainReboot APIs. With
no flags specified, it will prefer to use the agent, but
fallback to ACPI. Explicit choice can be made by using
a suitable flag
*
On 01/17/2012 04:44 AM, Michal Privoznik wrote:
Extend the 'shutdown' and 'reboot' methods so that they both
accept a new argument
--mode acpi|agent
* tools/virsh.c: New args for shutdown/reboot
* tools/virsh.pod: Document new args
---
tools/virsh.c | 47
On 01/13/2012 01:51 PM, Adam Litke wrote:
Qemu has changed the semantics of the block_job_cancel API. Originally, the
operation was synchronous (ie. upon command completion, the operation was
guaranteed to be completely stopped). With the new semantics, a
block_job_cancel merely requests
On 01/19/2012 02:00 PM, Adam Litke wrote:
Without the VIR_DOMAIN_BLOCK_JOB_ABORT_ASYNC flag, libvirt will
internally poll
using qemu's query-block-jobs API and will not return until the
operation has
been completed.
Why do you raise the event VIR_DOMAIN_BLOCK_JOB_CANCELLED also in the
case
---
utils/Python/format.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/utils/Python/format.py b/utils/Python/format.py
index 5de8eb0..9c119dd 100644
--- a/utils/Python/format.py
+++ b/utils/Python/format.py
@@ -33,7 +33,7 @@ class Format(object):
def
* switch rpartition with rsplit
* adjust the style
---
generator.py | 15 +++
1 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/generator.py b/generator.py
index 9a2ed06..6108963 100644
--- a/generator.py
+++ b/generator.py
@@ -124,10 +124,14 @@ class
On Thu, 19 Jan 2012 14:48:41 -0700
Eric Blake ebl...@redhat.com wrote:
On 01/19/2012 02:10 PM, Daniel P. Berrange wrote:
On Thu, Jan 19, 2012 at 01:32:08PM -0700, Eric Blake wrote:
On 01/18/2012 12:38 AM, Taku Izumi wrote:
I am now wondering if we should do this in a different way. ie if
Other virsh domifXXX commands can accept target name
as a parameter to specify interface. From viewpoint of
consistency, virsh domif-getlink command should accept
target name as a parameter. This patch achieves this.
Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
---
tools/virsh.c |
Other virsh domifXXX commands can accept target name
as a parameter to specify interface. From viewpoint of
consistency, virsh domif-setlink command should accept
target name as a parameter. This patch achieves this.
Signd-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
---
tools/virsh.c | 25
66 matches
Mail list logo
