Re: [libvirt] [PATCH] virt-aa-helper: Allow parsing supported features for qemu/kvm

2018-01-12 Thread Michal Privoznik
On 01/11/2018 11:09 AM, Shivaprasad G Bhat wrote: > The virt-aa-helper fails to parse the xmls with the memory/cpu > hotplug features or user assigned aliases. Set the features in > xmlopt->config for the parsing to succeed. > > Signed-off-by: Shivaprasad G Bhat > --- >

[libvirt] [PATCH v2] libvirtd: clarify the TLS conf default vaule setting

2018-01-12 Thread Chen Hanxiao
From: Chen Hanxiao As the description of daemon/libvirtd.conf, setting key_file, cert_file or key_file will override the default value. But if we set any one of them, we need to set all the rest of them. This patch clarify that description. Signed-off-by: Chen Hanxiao

[libvirt] [jenkins-ci PATCH] guests: Install rpcgen when building libvirt

2018-01-12 Thread Andrea Bolognani
The dependency on rpcgen had not been made explicit up until now because the command was part of the base glibc development packages; however, Fedora Rawhide now ships it in a separate package, so we need to list it along with all other dependencies in order for it to get installed.

Re: [libvirt] [PATCH] fixed bug:if expand thread pool, will lose some one

2018-01-12 Thread Peter Krempa
On Thu, Jan 11, 2018 at 23:30:41 +0800, Di Wei wrote: > --- Could you please provide more information on when this is happening and what the consequences are? It's really not obvious from the summary and it's required to be part of the commit message. signature.asc Description: PGP signature --

Re: [libvirt] [PATCH] m4: Don't enable bash-completion by default

2018-01-12 Thread Pavel Hrdina
On Thu, Jan 11, 2018 at 10:22:16PM +0100, Michal Privoznik wrote: > Due to the way that check logic was written we basically enabled > bash completion whenever readline was enabled. This is not right > because it made bash-completion pkg-config module required. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [resend][PATCH] deamon: use default value if ca_file, cert_file or key_file not set

2018-01-12 Thread Pavel Hrdina
On Fri, Jan 12, 2018 at 05:09:10PM +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > As the description of daemon/libvirtd.conf, setting > key_file, cert_file or key_file will override the default value. > But if we set any one of them, we need to set all the rest of

Re: [libvirt] [resend][PATCH] deamon: use default value if ca_file, cert_file or key_file not set

2018-01-12 Thread Jiri Denemark
On Fri, Jan 12, 2018 at 17:09:10 +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > As the description of daemon/libvirtd.conf, setting > key_file, cert_file or key_file will override the default value. > But if we set any one of them, we need to set all the rest of them.

Re: [libvirt] [resend][PATCH] deamon: use default value if ca_file, cert_file or key_file not set

2018-01-12 Thread Chen Hanxiao
At 2018-01-12 17:44:38, "Jiri Denemark" wrote: >On Fri, Jan 12, 2018 at 17:09:10 +0800, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> As the description of daemon/libvirtd.conf, setting >> key_file, cert_file or key_file will override the default

[libvirt] [resend][PATCH] deamon: use default value if ca_file, cert_file or key_file not set

2018-01-12 Thread Chen Hanxiao
From: Chen Hanxiao As the description of daemon/libvirtd.conf, setting key_file, cert_file or key_file will override the default value. But if we set any one of them, we need to set all the rest of them. This patch set default value to them as daemon/libvirtd.conf

Re: [libvirt] [PATCH] qemu: Fix type of a completed job

2018-01-12 Thread Pavel Hrdina
On Thu, Jan 11, 2018 at 10:48:55PM +0100, Jiri Denemark wrote: > Libvirt 3.7.0 and earlier libvirt reported a migration job as completed > immediately after QEMU finished sending migration data at which point > migration was not really complete yet. Commit v3.7.0-29-g3f2d6d829e > fixed this, but

[libvirt] [PATCH] libvirtd: clarify the TLS conf default vaule setting

2018-01-12 Thread Chen Hanxiao
From: Chen Hanxiao As the description of daemon/libvirtd.conf, setting key_file, cert_file or key_file will override the default value. But if we set any one of them, we need to set all the rest of them. This patch clarify that description. Signed-off-by: Chen Hanxiao

Re: [libvirt] [jenkins-ci PATCH] guests: Install rpcgen when building libvirt

2018-01-12 Thread Michal Privoznik
On 01/12/2018 11:44 AM, Andrea Bolognani wrote: > The dependency on rpcgen had not been made explicit up until now > because the command was part of the base glibc development packages; > however, Fedora Rawhide now ships it in a separate package, so we > need to list it along with all other

Re: [libvirt] [PATCH python 2/7] Allow override of which sub-RPMs to build

2018-01-12 Thread Pavel Hrdina
On Thu, Jan 11, 2018 at 04:43:34PM +, Daniel P. Berrange wrote: > Allow using > > rpmbuild --define "with_python2 0" > > to override the default logic about which python sub-RPMs to build > > Signed-off-by: Daniel P. Berrange > --- > libvirt-python.spec.in | 9

Re: [libvirt] [PATCH python 5/7] Adapt to rename of py2 RPMs from python- to python2- prefix

2018-01-12 Thread Pavel Hrdina
On Thu, Jan 11, 2018 at 04:43:37PM +, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > libvirt-python.spec.in | 12 > 1 file changed, 12 insertions(+) Reviewed-by: Pavel Hrdina In addition we should rename __python

[libvirt] [PATCH v2 0/2] processor frequency information on S390

2018-01-12 Thread Bjoern Walk
Since kernel version 4.7, processor frequency information is available on S390. This patch series extends the parser for system information. Let's also add a testcase to the test suite for a S390 CPU configuration running kernel version 4.14 on LPAR. This is basically patch 3 of this series:

[libvirt] [PATCH v2 2/2] tests: sysinfotest: add new test case for S390

2018-01-12 Thread Bjoern Walk
Let's add a test case for S390 with CPU frequency information available. Test data is sampled from an IBM z13 system running kernel 4.14 on LPAR. Reviewed-by: Boris Fiuczynski Signed-off-by: Bjoern Walk ---

[libvirt] [PATCH v2 1/2] util: virsysinfo: parse frequency information on S390

2018-01-12 Thread Bjoern Walk
Let's also parse the available processor frequency information on S390 so that it can be utilized by virsh sysinfo: # virsh sysinfo ... 2964 IBM/S390 00 5000 145F07 ... Reviewed-by: Marc Hartmayer

[libvirt] [PATCH 0/2] travis: Fix build failure

2018-01-12 Thread Andrea Bolognani
It would be nice to have all greens before the release :) Andrea Bolognani (2): travis: Sync packages with libvirt-jenkins-ci travis: Skip nfs-common installation .travis.yml | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.14.3 -- libvir-list mailing list

[libvirt] [PATCH 1/2] travis: Sync packages with libvirt-jenkins-ci

2018-01-12 Thread Andrea Bolognani
Make sure we install the same packages lcitool would install on the CentOS CI so that we have consistent results. The package list is current as of libvirt-jenkins-ci commit 3a559ae7bc08. --- .travis.yml | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.travis.yml

[libvirt] [PATCH 2/2] travis: Skip nfs-common installation

2018-01-12 Thread Andrea Bolognani
Installing nfs-common is broken on trusty since build #807 https://travis-ci.org/libvirt/libvirt/builds/326705054 It's probably a transient error on Travis' side, so just comment it out for the time being to allow builds to proceed. Signed-off-by: Andrea Bolognani ---

Re: [libvirt] [PATCH python 4/7] Add emacs mode marker to activate rpm-spec highlighting

2018-01-12 Thread Pavel Hrdina
On Thu, Jan 11, 2018 at 04:43:36PM +, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > libvirt-python.spec.in | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Pavel Hrdina How about adding the same marker for vim? :) #

[libvirt] [jenkins-ci PATCH] guests: Make rpcgen mapping more future-proof

2018-01-12 Thread Andrea Bolognani
Since whatever is in Fedora Rawhide will end up in future Fedora releases, it makes sense to use the newer package as default and override it for existing releases (as well as CentOS), so that no tweaking will be needed when Fedora 28 and later are added to the CI setup. Suggested-by: Peter

Re: [libvirt] [PATCH v2 2/2] tests: sysinfotest: add new test case for S390

2018-01-12 Thread Pino Toscano
On Friday, 12 January 2018 12:38:02 CET Bjoern Walk wrote: > Let's add a test case for S390 with CPU frequency information available. > Test data is sampled from an IBM z13 system running kernel 4.14 on LPAR. > > Reviewed-by: Boris Fiuczynski > Signed-off-by: Bjoern

Re: [libvirt] [PATCH python 6/7] Turn on python3 sub-RPMs for RHEL > 7

2018-01-12 Thread Pavel Hrdina
On Thu, Jan 11, 2018 at 04:43:38PM +, Daniel P. Berrange wrote: > It is expected that future RHEL-8 will have python3 by default, so enable > that. > It is unclear whether python2 will still be available, so leave that enabled > for now. > > Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH v2 1/2] util: virsysinfo: parse frequency information on S390

2018-01-12 Thread Pino Toscano
On Friday, 12 January 2018 12:38:01 CET Bjoern Walk wrote: > +while ((tmp_base = strstr(tmp_base, "cpu number")) && > + (tmp_base = virSysinfoParseS390Line(tmp_base, "cpu number", > ))) { > +unsigned int n; > +char *mhz = NULL; > [...] > +if (n >=

Re: [libvirt] [PATCH python 1/7] Allow disabling of python2 RPM build

2018-01-12 Thread Pavel Hrdina
On Thu, Jan 11, 2018 at 04:43:33PM +, Daniel P. Berrange wrote: > With Fedora modularity, it is possible to have add-on repos for multiple > versions of python3. It is thus desirable to be able to build libvirt-python > in these repos, with only the python3 sub-RPMs enabled. > > Thus also

Re: [libvirt] [PATCH python 3/7] Add checks for min supported distros

2018-01-12 Thread Pavel Hrdina
On Thu, Jan 11, 2018 at 04:43:35PM +, Daniel P. Berrange wrote: > Be clear about which distros we aim to support with the specfile, so we know > what we can cleanup in the spec later. Do we really want to have this limitation? If so, maybe we can alter the "requires" message to only warn

Re: [libvirt] [PATCH python 3/7] Add checks for min supported distros

2018-01-12 Thread Ján Tomko
On Fri, Jan 12, 2018 at 12:36:23PM +0100, Pavel Hrdina wrote: On Thu, Jan 11, 2018 at 04:43:35PM +, Daniel P. Berrange wrote: Be clear about which distros we aim to support with the specfile, so we know what we can cleanup in the spec later. Do we really want to have this limitation?

[libvirt] [PATCH 8/8] virsh: Introduce virshSnapshotNameCompleter

2018-01-12 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 51 + tools/virsh-completer.h | 4 tools/virsh-snapshot.c | 21 +--- 3 files changed, 69 insertions(+), 7 deletions(-) diff --git

[libvirt] [PATCH 4/8] virsh: Introduce virshNetworkNameCompleter

2018-01-12 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 51 + tools/virsh-completer.h | 4 tools/virsh-network.c | 24 --- 3 files changed, 68 insertions(+), 11 deletions(-) diff --git

[libvirt] Ping Re: [PATCH V4] blockjob: Fix error checking of blockjob status

2018-01-12 Thread WangJie (Captain)
ping On 2018/1/5 10:53, Jie Wang wrote: > offset and len can also be equal to 0 on failed if blockjob return > status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", > so we need to check 'error' in this case. > --- > src/qemu/qemu_monitor_json.c | 2 +- > 1 file changed, 1

[libvirt] [PATCH 9/8] docs: Mention bash completion feature

2018-01-12 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 064b9ae83..e5ed89504 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -47,6 +47,17 @@ qemu: Add support for hot

[libvirt] [PATCH python v2 9/9] Use python*_sitearch macros instead of manually defining the dir

2018-01-12 Thread Daniel P. Berrange
Note we use python_sitearch not python2_sitearch, since the former is more portable. Signed-off-by: Daniel P. Berrange --- libvirt-python.spec.in | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libvirt-python.spec.in

[libvirt] [PATCH] vshReadlineOptionsPrune: Fix possible leak

2018-01-12 Thread Michal Privoznik
The function should prune list of --options so that options already specified are not offered to user for completion again. However, if the list of offered options contains a string that doesn't start with double dash the function returns leaking partially constructed list. There's not much

[libvirt] [PATCH python v2 7/9] Require libvirt native version matching py version by default

2018-01-12 Thread Daniel P. Berrange
Although we're capable of building against any libvirt >= 0.9.11, 99% of the time we want RPM builds to be done against matching libvirt version, otherwise we might silently build against an unexpected/wrong version. We don't support building against a native libvirt that's newer than the python

[libvirt] [PATCH 5/8] virsh: Introduce virshNodeDeviceNameCompleter

2018-01-12 Thread Michal Privoznik
Yet again, we don't need listing by device capabilities, so flags are unused. Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 45 + tools/virsh-completer.h | 4 tools/virsh-nodedev.c | 16 +++- 3

[libvirt] [PATCH 1/8] virsh: Introduce virshStoragePoolNameCompleter

2018-01-12 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 51 + tools/virsh-completer.h | 4 tools/virsh-pool.c | 28 +-- tools/virsh-volume.c| 42

[libvirt] [PATCH 0/8] virsh: Introduce more completers

2018-01-12 Thread Michal Privoznik
It'd be nice if we could autocomplete the basic types like pools, volumes, networks, ... before the release. Michal Privoznik (8): virsh: Introduce virshStoragePoolNameCompleter virsh: Introduce virshStorageVolNameCompleter virsh: Introduce virshInterfaceNameCompleter virsh: Introduce

[libvirt] [PATCH 6/8] virsh: Introduce virshNWFilterNameCompleter

2018-01-12 Thread Michal Privoznik
The virConnectListAllNWFilters() has no extra flags yet, which simplifies things a bit. Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 45 + tools/virsh-completer.h | 4 tools/virsh-nwfilter.c | 9 ++---

Re: [libvirt] [PATCH python 1/7] Allow disabling of python2 RPM build

2018-01-12 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 03:42:57PM +, Daniel P. Berrange wrote: > On Fri, Jan 12, 2018 at 12:15:19PM +0100, Pavel Hrdina wrote: > > On Thu, Jan 11, 2018 at 04:43:33PM +, Daniel P. Berrange wrote: > > > With Fedora modularity, it is possible to have add-on repos for multiple > > > versions

Re: [libvirt] [PATCH python 3/7] Add checks for min supported distros

2018-01-12 Thread Pavel Hrdina
On Fri, Jan 12, 2018 at 03:43:55PM +, Daniel P. Berrange wrote: > On Fri, Jan 12, 2018 at 12:36:23PM +0100, Pavel Hrdina wrote: > > On Thu, Jan 11, 2018 at 04:43:35PM +, Daniel P. Berrange wrote: > > > Be clear about which distros we aim to support with the specfile, so we > > > know > >

Re: [libvirt] [PATCH] fixed bug:if expand thread pool, will lose some one

2018-01-12 Thread diwei
Sorry for that the information is not obvious. I hope that the information below is sufficient.If need more information,let me know. Bug’s consequence: Assume that there is a threadpool like [ thread 1 | thread 2 | thread 3 ] After expanding this threadpool with

[libvirt] [PATCH python v2 6/9] Turn on python3 sub-RPMs for RHEL > 7

2018-01-12 Thread Daniel P. Berrange
It is expected that future RHEL-8 will have python3 by default, so enable that. It is unclear whether python2 will still be available, so leave that enabled for now. Reviewed-by: Pavel Hrdina Signed-off-by: Daniel P. Berrange --- libvirt-python.spec.in

[libvirt] [PATCH python v2 3/9] Add checks for min supported distros

2018-01-12 Thread Daniel P. Berrange
Be clear about which distros we aim to support with the specfile, so we know what we can cleanup in the spec later. Signed-off-by: Daniel P. Berrange --- libvirt-python.spec.in | 16 1 file changed, 16 insertions(+) diff --git a/libvirt-python.spec.in

[libvirt] [PATCH python v2 5/9] Adapt to rename of py2 RPMs from python- to python2- prefix

2018-01-12 Thread Daniel P. Berrange
Reviewed-by: Pavel Hrdina Signed-off-by: Daniel P. Berrange --- libvirt-python.spec.in | 12 1 file changed, 12 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index b667ebe..b13e961 100644 ---

[libvirt] [PATCH python v2 8/9] Fix filtering of RPM provides for .so files

2018-01-12 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- libvirt-python.spec.in | 5 + 1 file changed, 5 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 2dfc84a..f658496 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -54,7 +54,12 @@

Re: [libvirt] [PATCH python 3/7] Add checks for min supported distros

2018-01-12 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 05:32:32PM +0100, Pavel Hrdina wrote: > On Fri, Jan 12, 2018 at 03:43:55PM +, Daniel P. Berrange wrote: > > On Fri, Jan 12, 2018 at 12:36:23PM +0100, Pavel Hrdina wrote: > > > On Thu, Jan 11, 2018 at 04:43:35PM +, Daniel P. Berrange wrote: > > > > Be clear about

Re: [libvirt] [jenkins-ci PATCH v2 0/2] guests: Make rpcgen mapping more future-proof

2018-01-12 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 02:50:47PM +0100, Andrea Bolognani wrote: > Changes from [v1]: > > * use the rpcgen name instead of glibc-rpcgen, which is a just > temporary hack and will go away. > > [v1] https://www.redhat.com/archives/libvir-list/2018-January/msg00422.html > > Andrea Bolognani

Re: [libvirt] [PATCH 13/18] vsh: Filter --options

2018-01-12 Thread John Ferlan
On 01/02/2018 12:12 PM, Michal Privoznik wrote: > Similarly to the previous commit, once we've presented an > --option for a command to the user it makes no sense to offer it > again. Therefore, we can prune all already specified options. For > instance, after this patch: > > virsh # migrate

Re: [libvirt] [PATCH python 5/7] Adapt to rename of py2 RPMs from python- to python2- prefix

2018-01-12 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 12:31:46PM +0100, Pavel Hrdina wrote: > On Thu, Jan 11, 2018 at 04:43:37PM +, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange > > --- > > libvirt-python.spec.in | 12 > > 1 file changed, 12 insertions(+) > >

Re: [libvirt] [PATCH python v2 0/9] Various improvements to RPM spec

2018-01-12 Thread Pavel Hrdina
On Fri, Jan 12, 2018 at 04:06:36PM +, Daniel P. Berrange wrote: > Daniel P. Berrange (9): > Allow disabling of python2 RPM build > Allow override of which sub-RPMs to build > Add checks for min supported distros > Add emacs mode marker to activate rpm-spec highlighting > Adapt to

Re: [libvirt] [PATCH python 3/7] Add checks for min supported distros

2018-01-12 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 12:36:23PM +0100, Pavel Hrdina wrote: > On Thu, Jan 11, 2018 at 04:43:35PM +, Daniel P. Berrange wrote: > > Be clear about which distros we aim to support with the specfile, so we know > > what we can cleanup in the spec later. > > Do we really want to have this

[libvirt] [PATCH python v2 1/9] Allow disabling of python2 RPM build

2018-01-12 Thread Daniel P. Berrange
With Fedora modularity, it is possible to have add-on repos for multiple versions of python3. It is thus desirable to be able to build libvirt-python in these repos, with only the python3 sub-RPMs enabled. Thus also helps if future RHEL/Fedora drop python2 entirely from their default repos.

[libvirt] [PATCH python v2 0/9] Various improvements to RPM spec

2018-01-12 Thread Daniel P. Berrange
Daniel P. Berrange (9): Allow disabling of python2 RPM build Allow override of which sub-RPMs to build Add checks for min supported distros Add emacs mode marker to activate rpm-spec highlighting Adapt to rename of py2 RPMs from python- to python2- prefix Turn on python3 sub-RPMs for

[libvirt] [PATCH python v2 2/9] Allow override of which sub-RPMs to build

2018-01-12 Thread Daniel P. Berrange
Allow using rpmbuild --define "with_python2 0" to override the default logic about which python sub-RPMs to build Reviewed-by: Pavel Hrdina Signed-off-by: Daniel P. Berrange --- libvirt-python.spec.in | 9 ++--- 1 file changed, 6 insertions(+),

[libvirt] [PATCH python v2 4/9] Add emacs mode marker to activate rpm-spec highlighting

2018-01-12 Thread Daniel P. Berrange
Reviewed-by: Pavel Hrdina Signed-off-by: Daniel P. Berrange --- libvirt-python.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index a98b902..b667ebe 100644 --- a/libvirt-python.spec.in +++

[libvirt] [PATCH 3/8] virsh: Introduce virshInterfaceNameCompleter

2018-01-12 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 47 +++ tools/virsh-completer.h | 4 tools/virsh-interface.c | 16 +--- 3 files changed, 60 insertions(+), 7 deletions(-) diff --git

[libvirt] [PATCH 2/8] virsh: Introduce virshStorageVolNameCompleter

2018-01-12 Thread Michal Privoznik
This one is a bit simpler since virStoragePoolListAllVolumes() has no flags yet. Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 52 + tools/virsh-completer.h | 4 tools/virsh-volume.c| 3 ++- 3 files

[libvirt] [PATCH 7/8] virsh: Introduce virshSecretUUIDCompleter

2018-01-12 Thread Michal Privoznik
This is a slight change from previous patches since virSecret does not have a name only UUID strings. Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 46 ++ tools/virsh-completer.h | 4 tools/virsh-secret.c

[libvirt] Entering freeze for libvirt-4.0.0

2018-01-12 Thread Daniel Veillard
Hi all, as planned I just tagged the Release Candidate 1 in git for 4.0.0, I also pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ No issue found in my limited testing, weirdly the CI says master is red for 4 days but it build just fine here so there has to

Re: [libvirt] [PATCH python 1/7] Allow disabling of python2 RPM build

2018-01-12 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 12:15:19PM +0100, Pavel Hrdina wrote: > On Thu, Jan 11, 2018 at 04:43:33PM +, Daniel P. Berrange wrote: > > With Fedora modularity, it is possible to have add-on repos for multiple > > versions of python3. It is thus desirable to be able to build libvirt-python > > in

Re: [libvirt] Entering freeze for libvirt-4.0.0

2018-01-12 Thread Andrea Bolognani
On Fri, 2018-01-12 at 16:12 +0100, Daniel Veillard wrote: > No issue found in my limited testing, weirdly the CI says master is > red for 4 days but it build just fine here so there has to be something > on jenkins: https://ci.centos.org/view/libvirt/ Yeah, the CentOS CI failures are due to

[libvirt] [PATCH] docs: formatdomain: Document the CPU feature 'name' attribute

2018-01-12 Thread Kashyap Chamarthy
Currently, the CPU feature 'name' XML attribute, as in: [...] IvyBridge Intel [...] isn't explicitly documented in formatdomain.html. Document it now. Signed-off-by: Kashyap Chamarthy --- docs/formatdomain.html.in | 17

[libvirt] [PATCH] virsh: fix build without readline

2018-01-12 Thread Roman Bogorodskiy
Completion in virsh is enabled when readline is available. However, when it's not available, we should: * avoid defining completers with completion functions; * in cmdComplete(), mark unused arguments when there's no readline with ATTRIBUTE_UNUSED. --- tools/virsh-domain-monitor.c | 6

Re: [libvirt] [PATCH] vshReadlineOptionsPrune: Fix possible leak

2018-01-12 Thread John Ferlan
On 01/12/2018 11:08 AM, Michal Privoznik wrote: > The function should prune list of --options so that options > already specified are not offered to user for completion again. > However, if the list of offered options contains a string that > doesn't start with double dash the function returns

Re: [libvirt] [PATCH v2 2/2] qemu_hotplug: introduce VIR_ERR_DEVICE_MISSING for failing to find desired device

2018-01-12 Thread John Ferlan
$SUBJ: There should be two patches... One just for the error message (see commit id 'f0e7f90bff' for the last change to add a new error)... Thus commit message 1 becomes: qemu: Introduce VIR_ERR_DEVICE_MISSING and commit message 2 becomes: qemu: Use VIR_ERR_DEVICE_MISSING for various hotplug

Re: [libvirt] [PATCH v2 1/2] qemu_hotplug: more proper error messages when target detaching device is not found

2018-01-12 Thread John Ferlan
$SUBJ: qemu: Add some more details for hotplug errors when device not found On 01/05/2018 05:28 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > More proper/detail error messages updated.> > Signed-off-by: Chen Hanxiao > --- >

Re: [libvirt] [RFC PATCH] lxc: Up back the veth interfaces by default

2018-01-12 Thread Benjamin Cama
Hi again, Le jeudi 11 janvier 2018 à 18:08 +0100, Benjamin Cama a écrit : > Upping an interface without configuring it is not a “cardinal sin” but a > sensible way to achieve auto-configuration, e.g. with IPv6 SLAAC (RFC > 4862). If NetworkManager has troube with interfaces having only a >

Re: [libvirt] [PATCH] qemu: Ignore fallback CPU attribute on reconnect

2018-01-12 Thread Pavel Hrdina
On Thu, Jan 11, 2018 at 10:30:04AM +0100, Jiri Denemark wrote: > When reconnecting to a running domain with host-model CPU started by old > libvirt which did not store the actual CPU in the status XML, we need to > ignore the fallback attribute to make sure we can translate the detected > host CPU

Re: [libvirt] [PATCH v2] domain_conf: skip boot order check of CD-ROM or floppy device when change-media

2018-01-12 Thread Chen Hanxiao
At 2018-01-11 21:36:29, "Ján Tomko" wrote: >On Thu, Jan 11, 2018 at 06:16:37PM +0800, Chen Hanxiao wrote: >>From: Chen Hanxiao >> >>If we insert or eject a CD-ROM/floppy device by: >> 'virsh change-media VM --eject/--insert some.iso --live', >>and the

Re: [libvirt] [PATCH v2 2/2] tests: sysinfotest: add new test case for S390

2018-01-12 Thread John Ferlan
On 01/12/2018 06:38 AM, Bjoern Walk wrote: > Let's add a test case for S390 with CPU frequency information available. > Test data is sampled from an IBM z13 system running kernel 4.14 on LPAR. > > Reviewed-by: Boris Fiuczynski > Signed-off-by: Bjoern Walk

Re: [libvirt] [PATCH 0/2] travis: Fix build failure

2018-01-12 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 12:43:58PM +0100, Andrea Bolognani wrote: > It would be nice to have all greens before the release :) > > Andrea Bolognani (2): > travis: Sync packages with libvirt-jenkins-ci > travis: Skip nfs-common installation Reviewed-by: Daniel P. Berrange

Re: [libvirt] [PATCH v2 2/2] tests: sysinfotest: add new test case for S390

2018-01-12 Thread Bjoern Walk
Pino Toscano [2018-01-12, 01:44PM +0100]: > On Friday, 12 January 2018 12:38:02 CET Bjoern Walk wrote: > > Let's add a test case for S390 with CPU frequency information available. > > Test data is sampled from an IBM z13 system running kernel 4.14 on LPAR. > > > >

Re: [libvirt] [PATCH v2 2/2] tests: sysinfotest: add new test case for S390

2018-01-12 Thread John Ferlan
On 01/12/2018 07:44 AM, Pino Toscano wrote: > On Friday, 12 January 2018 12:38:02 CET Bjoern Walk wrote: >> Let's add a test case for S390 with CPU frequency information available. >> Test data is sampled from an IBM z13 system running kernel 4.14 on LPAR. >> >> Reviewed-by: Boris Fiuczynski

Re: [libvirt] [jenkins-ci PATCH] guests: Make rpcgen mapping more future-proof

2018-01-12 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 01:31:22PM +0100, Andrea Bolognani wrote: > Since whatever is in Fedora Rawhide will end up in future Fedora > releases, it makes sense to use the newer package as default and > override it for existing releases (as well as CentOS), so that > no tweaking will be needed when

Re: [libvirt] [PATCH v2 1/2] util: virsysinfo: parse frequency information on S390

2018-01-12 Thread Bjoern Walk
Pino Toscano [2018-01-12, 01:37PM +0100]: > On Friday, 12 January 2018 12:38:01 CET Bjoern Walk wrote: > > +while ((tmp_base = strstr(tmp_base, "cpu number")) && > > + (tmp_base = virSysinfoParseS390Line(tmp_base, "cpu number", > > ))) { > > +unsigned

Re: [libvirt] [jenkins-ci PATCH] guests: Make rpcgen mapping more future-proof

2018-01-12 Thread Andrea Bolognani
On Fri, 2018-01-12 at 13:17 +, Daniel P. Berrange wrote: > >rpcgen: > > deb: libc-dev-bin > > -rpm: glibc-common > > -FedoraRawhide: glibc-rpcgen > > +rpm: glibc-rpcgen > > You shouldn't refer to glibc-rpcgen - use the name 'rpcgen' which > is a virtual provide, because

[libvirt] [jenkins-ci PATCH v2 1/2] guests: Fix package name for rpcgen

2018-01-12 Thread Andrea Bolognani
The glibc-rpcgen package is just a temporary hack, so we should use the rpcgen name from the get-go instead. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/vars/mappings.yml

[libvirt] [jenkins-ci PATCH v2 0/2] guests: Make rpcgen mapping more future-proof

2018-01-12 Thread Andrea Bolognani
Changes from [v1]: * use the rpcgen name instead of glibc-rpcgen, which is a just temporary hack and will go away. [v1] https://www.redhat.com/archives/libvir-list/2018-January/msg00422.html Andrea Bolognani (2): guests: Fix package name for rpcgen guests: Make rpcgen mapping more

[libvirt] [jenkins-ci PATCH v2 2/2] guests: Make rpcgen mapping more future-proof

2018-01-12 Thread Andrea Bolognani
Since whatever is in Fedora Rawhide will end up in future Fedora releases, it makes sense to use the newer package as default and override it for existing releases (as well as CentOS), so that no tweaking will be needed when Fedora 28 and later are added to the CI setup. Suggested-by: Peter

Re: [libvirt] [PATCH v2 2/2] tests: sysinfotest: add new test case for S390

2018-01-12 Thread Bjoern Walk
John Ferlan [2018-01-12, 08:04AM -0500]: > > > On 01/12/2018 07:44 AM, Pino Toscano wrote: > > On Friday, 12 January 2018 12:38:02 CET Bjoern Walk wrote: > >> Let's add a test case for S390 with CPU frequency information available. > >> Test data is sampled from an IBM z13