Re: [libvirt] qemu-kvm blocked for more than 120 seconds when "libvirt-guests" is enabled

Hi, I have modified libvirt-guests.service in order to add a dependency for the ganseha service. After=network.target libvirtd.service time-sync.target *nfs-ganesha.service* *Requires=nfs-ganesha.service* But it looks system does not stop vms: [image: Imágenes integradas 1] Any help will be

[libvirt] [PATCH 1/2] util: Turn virFirewallAddRule() into a macro

Clang 3.9 refuses to compile the existing code with the following error: util/virfirewall.c:425:20: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]

[libvirt] [PATCH 0/2] Attempt, and fail, to fix build with Clang 3.9 / Linux

Martin asked for this a while ago. I was surprised, at first, because according to my experience the only issue with Clang builds were a couple of test cases failing to run, but trying again on Clang 3.9 / Fedora rawhide caused me to run into at least three separate compilation issues. Two of

[libvirt] [PATCH 2/2] util: Cast to 'long double' when calling isnan()

Clang 3.9 chokes when calling isnan() on a double variable: util/virxml.c:153:21: error: implicit conversion increases floating-point precision: 'double' to 'long double' [-Werror,-Wdouble-promotion] (isnan(obj->floatval))) {

Re: [libvirt] [PATCH] qemu: Don't assume secret provided for LUKS encryption

On Thu, Dec 22, 2016 at 09:12:43AM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1405269 If a secret was not provided for what was determined to be a LUKS encrypted disk (during virStorageFileGetMetadata processing when called from qemuDomainDetermineDiskChain as a

Re: [libvirt] [PATCH 11/11] iscsi: Add parent wwnn/wwpn or fabric capability for createVport

On Fri, Nov 18, 2016 at 09:26:37AM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1349696 As it turns out using only the 'parent' to achieve the goal of a consistent vHBA parent has issues with reboots where the scsi_hostX parent could change to scsi_hostY causing either

Re: [libvirt] [PATCH 10/11] util: Introduce virGetFCHostNameByFabricWWN

On Fri, Nov 18, 2016 at 09:26:36AM -0500, John Ferlan wrote: Create a utility routine in order to read the scsi_host fabric_name files looking for a match to a passed fabric_name Signed-off-by: John Ferlan --- src/libvirt_private.syms | 1 + src/util/virutil.c | 86

Re: [libvirt] [PATCH 04/11] nodedev: Add the ability to create vHBA by parent wwnn/wwpn or fabric_wwn

On Fri, Nov 18, 2016 at 09:26:30AM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1349696 When creating a vHBA, the process is to feed XML to nodeDeviceCreateXML that lists the scsi_hostX to use to create the vHBA. However, between reboots, it's possible that the

Re: [libvirt] [PATCH 09/11] util: Remove need for extra VIR_FREE's in virGetFCHostNameByWWN

On Fri, Nov 18, 2016 at 09:26:35AM -0500, John Ferlan wrote: Rather than extraneous VIR_FREE's depending on where we are in the code, move them to the top of the loop and in the cleanup path. Signed-off-by: John Ferlan --- src/util/virutil.c | 27 +--

Re: [libvirt] [PATCH 08/11] iscsi: Converge more createVport checks

On Fri, Nov 18, 2016 at 09:26:34AM -0500, John Ferlan wrote: Remove duplicated code - make one path through Signed-off-by: John Ferlan --- src/storage/storage_backend_scsi.c | 35 +++ 1 file changed, 11 insertions(+), 24 deletions(-) diff

Re: [libvirt] [PATCH 07/11] iscsi: Change order of checks in createVport

On Fri, Nov 18, 2016 at 09:26:33AM -0500, John Ferlan wrote: Move the check for an already existing vHBA to the top of the function. No sense in first decoding a provided parent if the next thing we're going to do is fail if a provided wwnn/wwpn already exists. Signed-off-by: John Ferlan

Re: [libvirt] [PATCH 06/11] iscsi: Clean up createVport exit paths

s/iscsi/scsi/ in the commit summary On Fri, Nov 18, 2016 at 09:26:32AM -0500, John Ferlan wrote: Use the ret = -1, goto cleanup, etc. rather than current hodgepodge. Signed-off-by: John Ferlan --- src/storage/storage_backend_scsi.c | 34 -- 1

Re: [libvirt] [PATCH 03/11] nodedev: Add ability to find a vport capable vHBA

On Fri, Nov 18, 2016 at 09:26:29AM -0500, John Ferlan wrote: If a is not supplied in the XML used to create a non-persistent vHBA, then instead of failing, let's try to find a "vports" capable node device and use that. Signed-off-by: John Ferlan ---

Re: [libvirt] [PATCH 02/11] nodedev: Create helpers to search for vport capable nodedevs

On Fri, Nov 18, 2016 at 09:26:28AM -0500, John Ferlan wrote: Extract out code from virNodeDeviceGetParentHost into helpers - it's going to be reused in upcoming patches to search on more fields Create virNodeDeviceFindVPORTCapDef in order to return a virNodeDevCapsDefPtr of the VPORT_OPS and

Re: [libvirt] [PATCH 01/11] nodedev: Fix crash in libvirtd on vHBA creation path

On Fri, Nov 18, 2016 at 09:26:27AM -0500, John Ferlan wrote: Providing XML such as: vhba would crash libvirt because the '' isn't a required field, but for vHBA creation it's expected (day 1 issue - see commit id '81d0ffbc'). The nodedev.rng added in commit id '2c22a68c' has

Re: [libvirt] qemu-kvm blocked for more than 120 seconds when "libvirt-guests" is enabled

Hi, Yes, I use ganesha-nfs for storing *.qcow2 files. Is there any way to stop NFS after libvirt-guests service? Thanks a lot. 2017-01-02 14:24 GMT+01:00 Tomáš Golembiovský : > Hi, > > this is just a guess, but from the screenshot I see that NFS is already > down. Are

Re: [libvirt] [PATCH 3/3] networkxml2conftest: Fix build on BSD

On Mon, 2017-01-02 at 13:10 +0100, Michal Privoznik wrote: > > > I vote for Michal's approach as it doesn't require us to > > > disable VIR_TEST_REGENERATE_OUTPUT. > > > > Well, it does. Kinda. You *must not* regenerate output on FreeBSD with > > his patch, so it should be explicitly disabled.

Re: [libvirt] qemu-kvm blocked for more than 120 seconds when "libvirt-guests" is enabled

Hi, this is just a guess, but from the screenshot I see that NFS is already down. Are your VMs local or do you use NFS storage or some other network storage pool? That would be a reason for qemu process to hang. Best regards, Tomas On Mon, 2 Jan 2017 12:49:55 +0100 Oscar Segarra

Re: [libvirt] [PATCH 3/3] networkxml2conftest: Fix build on BSD

On 02.01.2017 12:04, Martin Kletzander wrote: > On Mon, Jan 02, 2017 at 09:57:04AM +0100, Andrea Bolognani wrote: >> On Sun, 2017-01-01 at 12:35 +0400, Roman Bogorodskiy wrote: >>> > No rush, I see Michal has yet another proposal for this that we >>> haven't >>> > considered and even though there

Re: [libvirt] qemu-kvm blocked for more than 120 seconds when "libvirt-guests" is enabled

Hi, anybody has experienced the same issue? Thanks a lot! El 31 dic. 2016 5:25 p. m., "Oscar Segarra" escribió: > Hi, > > I just have two virtual machines in my environment, I want them to > gracefully stop when host is powered off gracefully. > > Nevertheless, system

Re: [libvirt] [PATCH 7/9] bhyvexml2argvdata: Fix addresses

Michal Privoznik wrote: > On 01.01.2017 17:24, Roman Bogorodskiy wrote: > > Michal Privoznik wrote: > > > >> After c07d1c1c4f got merged it uncovered couple of broken domain > >> XMLs for bhyvexml2argv test. Some disk drives had incompatible > >> type of address configured. > >> > >>

[libvirt] [PATCH] maint: Sync bootstrap after gnulib update

7fa7fe22d844 updated gnulib to the latest upstream commit, but forgot to include the corresponding bootstrap changes. --- Pushed under the gnulib rule. bootstrap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bootstrap b/bootstrap index 5d3c289..26066b2 100755 ---

Re: [libvirt] [PATCH 3/3] networkxml2conftest: Fix build on BSD

On Mon, Jan 02, 2017 at 09:57:04AM +0100, Andrea Bolognani wrote: On Sun, 2017-01-01 at 12:35 +0400, Roman Bogorodskiy wrote: > No rush, I see Michal has yet another proposal for this that we haven't > considered and even though there are somedrawbacks to that as well, it > looks nicer than

Re: [libvirt] [PATCH 0/2] virmacmap: Fix crash

Michal Privoznik wrote: > I was notified about a virmacmaptest crash that happens on FreeBSD. > Interestingly, the problem occurs on Linux too, but for some reason > the process is not getting SIGSEGV. > > Michal Privoznik (2): > virmacmap: Fix variable handling > virmacmap: Don't use hash

[libvirt] [PATCH] maint: update to latest gnulib

Required for the copyright year bump to keep 'make syntax-check' happy, and also pulls in several portability fixes. * .gnulib: Update to latest. * bootstrap: Resync from upstream. Signed-off-by: Michal Privoznik --- Pushed under gnulib-free-to-push rule. .gnulib | 2 +-

Re: [libvirt] [PATCH 7/9] bhyvexml2argvdata: Fix addresses

On 01.01.2017 17:24, Roman Bogorodskiy wrote: > Michal Privoznik wrote: > >> After c07d1c1c4f got merged it uncovered couple of broken domain >> XMLs for bhyvexml2argv test. Some disk drives had incompatible >> type of address configured. >> >> Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH 1/3] networkxml2conftest: Rename outxml to outconf

On Wed, 2016-12-28 at 23:10 +0100, Martin Kletzander wrote: > Just a name, I know, but it bothered me a lot since it does not refer > to XML. Please push this regardless of which approach we end up choosing for the actual fix :) ACK -- Andrea Bolognani / Red Hat / Virtualization --

[libvirt] [PATCH] maint: Update to latest gnulib

In particular, this fixes the ./.gnulib/lib/version-etc.c maint.mk: out of date copyright in ./.gnulib/lib/version-etc.c; update it maint.mk:1196: recipe for target 'sc_copyright_check' failed error when running 'make syntax-check' in 2017. --- .gnulib | 2 +- bootstrap | 2 +- 2 files

Re: [libvirt] [PATCH 6/9] networkxml2conftest: s/lo/lo0/ on non-Linux

On 01.01.2017 17:14, Roman Bogorodskiy wrote: > Michal Privoznik wrote: > >> After 478ddedc12 a bug is fixed where we wrongly presumed loopack >> device name on non-Linux systems. It's lo0. However, the fix is >> not reflected in the tests which are failing now. >> >> Signed-off-by: Michal

[libvirt] [PATCH 0/2] virmacmap: Fix crash

I was notified about a virmacmaptest crash that happens on FreeBSD. Interestingly, the problem occurs on Linux too, but for some reason the process is not getting SIGSEGV. Michal Privoznik (2): virmacmap: Fix variable handling virmacmap: Don't use hash table dataFree callback

[libvirt] [PATCH 1/2] virmacmap: Fix variable handling

In virMacMapRemoveLocked() we have two variables: @macsList and @newMacsList. Obviously, @newMacsList is supposed to hold pointer to modified list but in fact it holds pointer to the old list. It's confusing. Signed-off-by: Michal Privoznik --- src/util/virmacmap.c | 4 ++--

[libvirt] [PATCH 2/2] virmacmap: Don't use hash table dataFree callback

Due to nature of operations we do over the string list (more precisely due to how virStringListRemove() works), it is not the best idea to use dataFree callback. Problem is, on MAC address remove, the string list remove function modifies the original list in place. Then, virHashUpdateEntry() is

Re: [libvirt] [PATCH 1/9] tests: Run virmacmaptest iff WITH_YAJL

On 01.01.2017 17:11, Roman Bogorodskiy wrote: > Michal Privoznik wrote: > >> Since the internal implementation relies on a json parser being >> available, it make no sense to run this test if there's none >> available. >> >> Signed-off-by: Michal Privoznik >> --- >>

Re: [libvirt] [PATCH 6/9] networkxml2conftest: s/lo/lo0/ on non-Linux

On Tue, 2016-12-27 at 10:30 +0100, Michal Privoznik wrote: > After 478ddedc12 a bug is fixed where we wrongly presumed loopack > device name on non-Linux systems. It's lo0. However, the fix is > not reflected in the tests which are failing now. >  > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH 3/3] networkxml2conftest: Fix build on BSD

On Sun, 2017-01-01 at 12:35 +0400, Roman Bogorodskiy wrote: > > No rush, I see Michal has yet another proposal for this that we haven't > > considered and even though there are somedrawbacks to that as well, it > > looks nicer than this. > >  > > After all the ideas I'm starting to like the