Re: [PATCH] util: virdaemon: fix waiting for child processes

2020-04-07 Thread Rafael Fonseca
On Tue, 7 Apr 2020, 22:14 Rafael Fonseca, wrote: > Unlike `waitpid`, `virProcessWait` only returns -1 (error) or 0 > (success), so comparing that to `pid` will always be false and the > parent will report failure with: > > error : main:851 : Failed to fork as daemon: No such file or directory >

Re: A few XML modeling questions

2020-04-07 Thread Jim Fehlig
On 4/7/20 12:02 PM, Jim Fehlig wrote: Hi All, [...] e820_host is a bit trickier. For this setting, which is PV-specific, the man page says:  Selects whether to expose the host e820 (memory map) to the guest via the  virtual e820. When this option is false (0) the guest pseudo-physical  

Re: [PATCH 03/36] qemu: convert virQEMUCaps to GObject

2020-04-07 Thread Jonathon Jongsma
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote: > virFileCache had to also be changed to properly unref the QEMUCaps > objects; in turn, virfilecachetest was also converted to GObject so > it > plays nicely with virFileCache. There is still some documentation in virfilecache.h that says

Re: [PATCH 01/36] util: virresctrl: convert classes to GObject

2020-04-07 Thread Jonathon Jongsma
A couple minor notes below On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/conf/capabilities.c | 3 +- > src/conf/domain_conf.c | 21 +++--- > src/util/virresctrl.c | 137 ++-- > >

[PATCH] util: virdaemon: fix waiting for child processes

2020-04-07 Thread Rafael Fonseca
Unlike `waitpid`, `virProcessWait` only returns -1 (error) or 0 (success), so comparing that to `pid` will always be false and the parent will report failure with: error : main:851 : Failed to fork as daemon: No such file or directory even though the grandchild process is succesfully running.

Re: [PATCH ocaml] build: skip github lockdown file in manifest check

2020-04-07 Thread Pino Toscano
On Tuesday, 7 April 2020 20:14:44 CEST Daniel P. Berrangé wrote: > The github lockdown file is not intended to be included in any built > dist, so should be excluded when checking the manifest. > > Signed-off-by: Daniel P. Berrangé > --- > > Pushed as a CI build fix > > Makefile.in | 2 +- >

Re: Domain backup file explodes on s3fs

2020-04-07 Thread Eric Blake
[adding libvirt list] On 4/7/20 2:13 PM, Tim Haley wrote: Hi all, Have been playing with `virsh backup-begin` of late and think it's an excellent feature. I've noticed one behavior I'm not sure I understand. It looks like https://bugzilla.redhat.com/show_bug.cgi?id=1814664 is a similar

Re: [virttools-planet PATCH 2/4] Introduce use of GitLab CI for publishing to GitLab Pages

2020-04-07 Thread Andrea Bolognani
On Tue, 2020-04-07 at 18:18 +0100, Daniel P. Berrangé wrote: > On Tue, Apr 07, 2020 at 04:04:16PM +0200, Andrea Bolognani wrote: > > On Tue, 2020-03-31 at 11:08 +0100, Daniel P. Berrangé wrote: > > > + script: > > > +- python2 planet.py virt-tools/config.ini > > > > Python 2, EW! > >

[PATCH ocaml] build: skip github lockdown file in manifest check

2020-04-07 Thread Daniel P . Berrangé
The github lockdown file is not intended to be included in any built dist, so should be excluded when checking the manifest. Signed-off-by: Daniel P. Berrangé --- Pushed as a CI build fix Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in

Re: [libvirt PATCH 02/10] docs: Add glib-adoption.rst

2020-04-07 Thread Daniel P . Berrangé
On Mon, Apr 06, 2020 at 06:20:02PM +0200, Andrea Bolognani wrote: > This part is very specific and doesn't quite fit into the "coding > style" section, so let's move it to its own page. > > Signed-off-by: Andrea Bolognani > --- > docs/glib-adoption.rst | 96

Re: [libvirt PATCH 00/10] docs: Convert hacking to rst, split and rework it

2020-04-07 Thread Daniel P . Berrangé
On Mon, Apr 06, 2020 at 06:20:00PM +0200, Andrea Bolognani wrote: > hacking.html is the canonical entry point for people looking to help > with libvirt's development, but its sheer size makes it a farily > ineffective tool. > > Move most non-critical information off to separate pages and brush >

A few XML modeling questions

2020-04-07 Thread Jim Fehlig
Hi All, I've been struggling a bit deciding how to model Xen's max_event_channels and e820_host xl.cfg(5) settings. For max_event_channels the man page says: Limit the guest to using at most N event channels (PV interrupts). Guests use hypervisor resources for each event channel they use.

Re: [libvirt PATCH 01/10] docs: Convert hacking.html to reStructuredText

2020-04-07 Thread Daniel P . Berrangé
On Mon, Apr 06, 2020 at 06:20:01PM +0200, Andrea Bolognani wrote: > The conversion has been performed by using pandoc as a first pass, > and then tweaking the result manually until it looked satisfactory. > > Signed-off-by: Andrea Bolognani > --- > build-aux/syntax-check.mk |4 +- >

Re: [libvirt] [PATCH v2 1/1] qemu: hide details of fake reboot

2020-04-07 Thread Don Koch
On Thu, 19 Dec 2019 13:50:19 +0300 Nikolay Shirokovskiy wrote: > If we use fake reboot then domain goes thru running->shutdown->running > state changes with shutdown state only for short period of time. At > least this is implementation details leaking into API. And also there is > one real case

Re: [virttools-planet PATCH 2/4] Introduce use of GitLab CI for publishing to GitLab Pages

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 04:04:16PM +0200, Andrea Bolognani wrote: > On Tue, 2020-03-31 at 11:08 +0100, Daniel P. Berrangé wrote: > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > new file mode 100644 > > index 000..cfc6bf6 > > --- /dev/null > > +++ b/.gitlab-ci.yml > > @@ -0,0 +1,14 @@ > >

Re: [libvirt PATCH 39/39] cpu_map: Distinguish Cascadelake-Server from Skylake-Server

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: The signatures of these two CPU model differ only in stepping as both report family 6 and model 85. Skylake-Server uses stepping 4 or less and Cascadelake-Server uses stepping 5..7. https://bugzilla.redhat.com/show_bug.cgi?id=1761678 Signed-off-by:

Re: [libvirt PATCH 37/39] cputest: Add data for Intel(R) Xeon(R) Platinum 9242 CPU

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Cascadelake-Server with family 6, model 85, stepping 7. Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + ...6_64-cpuid-Xeon-Platinum-9242-disabled.xml |7 + ...86_64-cpuid-Xeon-Platinum-9242-enabled.xml | 10

Re: [libvirt PATCH 38/39] cputest: Add data for Intel(R) Xeon(R) Gold 6130 CPU

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Skylake-Server with family 6, model 85, stepping 4, which is currently mis-detected as Cascadelake-Server CPU model. Signed-off-by: Jiri Denemark --- tests/cputest.c |1 + .../x86_64-cpuid-Xeon-Gold-6130-disabled.xml |

Re: [libvirt PATCH 36/39] cpu_x86: Add support for stepping part of CPU signature

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: CPU models defined in the cpu_map can use signature/@stepping attribute to match a limited set of stepping numbers. The value is a bitmap for bits 0..15 each corresponding to a single stepping value. For example, stepping='4-6,9' will match 4, 5, 6, and

Re: [libvirt PATCH 35/39] cpu_x86: Don't check return value of x86ModelCopy

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Thanks to glib allocation functions which abort on OOM the function cannot ever return NULL. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt PATCH 34/39] cpu_x86: Replace 32b signatures in virCPUx86Model with a struct

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: The CPU models in our cpu_map define their signatures using separate family and model numbers. Let's store the signatures in the same way in our runtime representation of the cpu_map. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 149

Re: [libvirt PATCH 32/39] cpu_x86: Introduce virCPUx86SignaturesFree

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: The function will be used for freeing virCPUx86Signatures structure introduced later in this series. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt PATCH 33/39] cpu_x86: Introduce virCPUx86SignatureFromCPUID

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: It can be used for separating family, model, and stepping numbers from a single 32b integer as reported by CPUID. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-)

Re: [libvirt PATCH 31/39] cpu_x86: Move and rename x86FormatSignatures

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Later in this series the function will work on a newly introduced virCPUx86Signatures structure. Let's move it to the place were all s/were/where/ related functions will be added and rename the function as virCPUx86SignaturesFormat for easier review

ALERT: cimtest.git repository history recreated

2020-04-07 Thread Daniel P . Berrangé
In attempting to import the cimtest.git repository to gitlab I discovered some serious problems in the current git history. Specifically the author and committer email addresses were badly mangled for many commits. For example an author of: Deepti B. Kalakeri > This is so badly malformed

Re: [libvirt-go-xml PATCH 1/2] gitlab: add CI definition for GitLab

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 04:38:39PM +0200, Andrea Bolognani wrote: > On Tue, 2020-03-31 at 14:34 +0100, Daniel P. Berrangé wrote: > > +++ b/README.md > > @@ -1,4 +1,4 @@ > > -# libvirt-go-xml [![Build > >

Re: [libvirt-go-xml PATCH 1/2] gitlab: add CI definition for GitLab

2020-04-07 Thread Andrea Bolognani
On Tue, 2020-03-31 at 14:34 +0100, Daniel P. Berrangé wrote: > +++ b/README.md > @@ -1,4 +1,4 @@ > -# libvirt-go-xml [![Build > Status](https://travis-ci.org/libvirt/libvirt-go-xml.svg?branch=master)](https://travis-ci.org/libvirt/libvirt-go-xml) > >

Re: [libvirt-go-xml PATCH 2/2] travis: delete CI configuration

2020-04-07 Thread Andrea Bolognani
On Tue, 2020-03-31 at 14:34 +0100, Daniel P. Berrangé wrote: > We are standardizing on GitLab, so no longer need to run CI tests on > Travis. > > Signed-off-by: Daniel P. Berrangé > --- > .travis.yml | 13 - > 1 file changed, 13 deletions(-) > delete mode 100644 .travis.yml

Re: [libvirt-jenkins-ci PATCH v2 2/6] guests: users: Create a bin/ directory in the flavor user's home

2020-04-07 Thread Erik Skultety
On Tue, Apr 07, 2020 at 12:48:34PM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 07, 2020 at 01:45:46PM +0200, Erik Skultety wrote: > > On Tue, Apr 07, 2020 at 12:37:01PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Apr 07, 2020 at 01:31:17PM +0200, Erik Skultety wrote: > > > > We're creating a

Re: [virttools-web PATCH 0/3] Switch www.virt-tools.org over to use GitLab Pages

2020-04-07 Thread Andrea Bolognani
On Tue, 2020-03-31 at 11:21 +0100, Daniel P. Berrangé wrote: > This introduces use of GitLab CI + Pages to replace the current > OpenShift application which is only admin accessible by myself. > It also has automatic integration with LetsEncrypt guaranteeing > that we'll never have expired

Re: [virttools-planet PATCH 4/4] Drop Amit Shah and Nathan Gauër

2020-04-07 Thread Andrea Bolognani
On Tue, 2020-03-31 at 11:08 +0100, Daniel P. Berrangé wrote: > +++ b/virt-tools/config.ini > -[https://log.amitshah.net/feed/] > -name = Amit Shah This looks good. > -[http://www.studiopixl.com/blog/index.php/feeds/rss] > -name = Nathan Gauër For this one, the feed seems to have simply moved to

Re: [virttools-planet PATCH 2/4] Introduce use of GitLab CI for publishing to GitLab Pages

2020-04-07 Thread Andrea Bolognani
On Tue, 2020-03-31 at 11:08 +0100, Daniel P. Berrangé wrote: > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > new file mode 100644 > index 000..cfc6bf6 > --- /dev/null > +++ b/.gitlab-ci.yml > @@ -0,0 +1,14 @@ > + > +image: centos:7 CentOS 7, ewww. > +pages: > + stage: build > + cache: > +

Re: [virttools-planet PATCH 3/4] Remove obsolete openshift hosting configuration

2020-04-07 Thread Andrea Bolognani
On Tue, 2020-03-31 at 11:08 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > openshift/templates/.gitignore| 2 - > openshift/templates/update-tls.sh | 16 - > openshift/templates/virttools-planet-tls.json | 82 >

Re: [virttools-planet PATCH 1/4] Convert README to markdown format

2020-04-07 Thread Andrea Bolognani
On Tue, 2020-03-31 at 11:08 +0100, Daniel P. Berrangé wrote: > +How to add your blog > + > +Add a config.ini section for your blog to `updater/virt-tools/config.ini`: > + > +``` > + [https://example.org/my/blog/feed/] > + name = John Doe > + face = jdoe.png > + facewidth =

Re: [libvirt PATCH 30/39] cpu_x86: Move and rename x86ModelHasSignature

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Later in this series the function will work on a newly introduced virCPUx86Signatures structure. Let's move it to the place were all related functions will be added and rename the function as virCPUx86SignaturesMatch for easier review of the

Re: [libvirt PATCH 29/39] cpu_x86: Move and rename x86ModelCopySignatures

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Later in this series the function will work on a newly introduced virCPUx86Signatures structure. Let's move it to the place were all related functions will be added and rename the function as virCPUx86SignaturesCopy for easier review of the

Re: [libvirt PATCH 28/39] cpu_x86: Use g_auto* in virCPUx86CopyMigratable

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 27/39] cpu_x86: Use g_auto* in virCPUx86ExpandFeatures

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 26/39] cpu_x86: Use g_auto* in virCPUx86Translate

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 25/39] cpu_x86: Use g_auto* in virCPUx86UpdateLive

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 42 +++--- 1 file changed, 15 insertions(+), 27 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 24/39] cpu_x86: Use g_auto* in virCPUx86Update

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

[PATCH] storage: use local dom_disk parameter

2020-04-07 Thread Yi Li
replace vm->def->disks[i] with dom_disk parameter Signed-off-by: Yi Li --- src/qemu/qemu_driver.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index daa3cb397d..27f43124ac 100644 --- a/src/qemu/qemu_driver.c +++

Re: [libvirt PATCH 23/39] cpu_x86: Use g_auto* in x86UpdateHostModel

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 22/39] cpu_x86: Use g_auto* in virCPUx86Baseline

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 46 +- 1 file changed, 17 insertions(+), 29 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt-jenkins-ci PATCH v2 2/6] guests: users: Create a bin/ directory in the flavor user's home

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 01:45:46PM +0200, Erik Skultety wrote: > On Tue, Apr 07, 2020 at 12:37:01PM +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 07, 2020 at 01:31:17PM +0200, Erik Skultety wrote: > > > We're creating a dedicated user to run the gitlab agent, so why not > > > store the agent

Re: [libvirt-jenkins-ci PATCH v2 2/6] guests: users: Create a bin/ directory in the flavor user's home

2020-04-07 Thread Erik Skultety
On Tue, Apr 07, 2020 at 12:37:01PM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 07, 2020 at 01:31:17PM +0200, Erik Skultety wrote: > > We're creating a dedicated user to run the gitlab agent, so why not > > store the agent within the user profile and execute it from there. > > I'm wary of this

Re: [libvirt-jenkins-ci PATCH v2 2/6] guests: users: Create a bin/ directory in the flavor user's home

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 01:31:17PM +0200, Erik Skultety wrote: > We're creating a dedicated user to run the gitlab agent, so why not > store the agent within the user profile and execute it from there. I'm wary of this as it seems like it can create a exploit vector. ie malicious code running as

[libvirt-jenkins-ci PATCH v2 3/6] guests: templates: Introduce a gitlab-runner systemd service template

2020-04-07 Thread Erik Skultety
Signed-off-by: Erik Skultety --- .../update/templates/gitlab-runner.service.j2 | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 guests/playbooks/update/templates/gitlab-runner.service.j2 diff --git a/guests/playbooks/update/templates/gitlab-runner.service.j2

Re: [PATCHv2 1/1] cpu: Use g_autoptr and g_autofree in cpu.c

2020-04-07 Thread Ján Tomko
On a Monday in 2020, Seeteena Thoufeek wrote: Signed-off-by: Seeteena Thoufeek --- src/cpu/cpu.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko and pushed Jano signature.asc Description: PGP signature

[libvirt-jenkins-ci PATCH v2 0/6] Introduce the new 'gitlab' flavor

2020-04-07 Thread Erik Skultety
since v1: - .bash_logout is removed from the user home environment (causes builds to fail on Debian) - gitlab-runner is now downloaded to and executed from user's bin/ directory instead of using /usr/local/bin - both RC and systemd service files now define the user explicitly that the init

[libvirt-jenkins-ci PATCH v2 4/6] guests: templates: Introduce a gitlab-runner RC init service template

2020-04-07 Thread Erik Skultety
Based on https://docs.gitlab.com/runner/install/freebsd.html#installing-gitlab-runner Signed-off-by: Erik Skultety --- .../update/templates/gitlab-runner.j2 | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 guests/playbooks/update/templates/gitlab-runner.j2

[libvirt-jenkins-ci PATCH v2 6/6] guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script

2020-04-07 Thread Erik Skultety
Signed-off-by: Erik Skultety --- guests/lcitool | 50 +- 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 689a8cf..d9b2372 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -175,7 +175,7 @@

[libvirt-jenkins-ci PATCH v2 1/6] guests: users: Discard the .bash_logout skeleton file

2020-04-07 Thread Erik Skultety
As part of the users tasks, we remove the .profile file after we create our own .bash_profile. As part of that effort, let's remove the .bash_logout skeleton file as well, the reason being gitlab's runner agent which has a hard time initializing a build environment on Debian where the system

[libvirt-jenkins-ci PATCH v2 2/6] guests: users: Create a bin/ directory in the flavor user's home

2020-04-07 Thread Erik Skultety
We're creating a dedicated user to run the gitlab agent, so why not store the agent within the user profile and execute it from there. Signed-off-by: Erik Skultety --- guests/playbooks/update/tasks/users.yml | 7 +++ 1 file changed, 7 insertions(+) diff --git

[libvirt-jenkins-ci PATCH v2 5/6] guests: Introduce the new 'gitlab' flavor

2020-04-07 Thread Erik Skultety
With the recent efforts in upstream libvirt to centralize our CI on gitlab, let's add a new gitlab-specific flavor along with related playbook tasks. This flavour revolves around installing and configuring the gitlab-runner agent binary which requires the per-project registration token to be

Re: [libvirt PATCH 00/15] RFC: basic CGroup support with qemu:///session

2020-04-07 Thread Pavel Hrdina
On Tue, Apr 07, 2020 at 12:48:26PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Apr 7, 2020 at 10:55 AM Pavel Hrdina wrote: > > > > On Mon, Apr 06, 2020 at 11:26:57PM +0200, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Hi, > > > > > > This is a small series

Re: [libvirt PATCH 00/15] RFC: basic CGroup support with qemu:///session

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 12:48:26PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Apr 7, 2020 at 10:55 AM Pavel Hrdina wrote: > > > > On Mon, Apr 06, 2020 at 11:26:57PM +0200, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Hi, > > > > > > This is a small series

ANNOUNCE: primary git repos switched to https://gitlab.com/libvirt/

2020-04-07 Thread Daniel P . Berrangé
Hello All, As of this email, the primary host for libvirt project git repositories has been switched to gitlab.com with all projects under the following group: https://gitlab.com/libvirt The development process remains the same for now, with patches still to be submitted to this mailing

Re: [libvirt PATCH 00/15] RFC: basic CGroup support with qemu:///session

2020-04-07 Thread Marc-André Lureau
Hi On Tue, Apr 7, 2020 at 10:55 AM Pavel Hrdina wrote: > > On Mon, Apr 06, 2020 at 11:26:57PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > This is a small series that allows basic QEMU VM CGroup support with > > the help of machined --user: > >

Re: [libvirt PATCH 15/39] cpu_x86: Use g_auto* in x86Compute

2020-04-07 Thread Jiri Denemark
On Tue, Apr 07, 2020 at 12:08:37 +0200, Ján Tomko wrote: > On a Friday in 2020, Jiri Denemark wrote: > >Signed-off-by: Jiri Denemark > >--- > > src/cpu/cpu_x86.c | 64 ++- > > 1 file changed, 24 insertions(+), 40 deletions(-) > > > >diff --git

Re: [libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 12:29:29PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Apr 7, 2020 at 11:50 AM Ján Tomko wrote: > > > > On a Monday in 2020, marcandre.lur...@redhat.com wrote: > > >From: Marc-André Lureau > > > > > >Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the

Re: [libvirt PATCH 01/39] cpu_x86: Drop noTSX hint for incompatible CPUs

2020-04-07 Thread Jiri Denemark
On Tue, Apr 07, 2020 at 08:39:10 +0200, Ján Tomko wrote: > On a Friday in 2020, Jiri Denemark wrote: > >The hint was introduced a long time ago when broken TSX implementation > >was found in Haswell and Broadwell CPUs. Since then many more CPUs with > >TSX were introduced and and disabled due to

Re: [libvirt PATCH 21/39] cpu_x86: Use g_auto* in virCPUx86GetHost

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

2020-04-07 Thread Marc-André Lureau
Hi On Tue, Apr 7, 2020 at 11:50 AM Ján Tomko wrote: > > On a Monday in 2020, marcandre.lur...@redhat.com wrote: > >From: Marc-André Lureau > > > >Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the > >presence of machine1 service"), the code checks for systemd1 > >registration.

Re: [libvirt PATCH 20/39] cpu_x86: Use g_auto* in virCPUx86CheckFeature

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 19/39] cpu_x86: Use g_auto* in x86Encode

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 51 +++ 1 file changed, 21 insertions(+), 30 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 17/39] cpu_x86: Use g_auto* in x86Decode

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) Both copy and features are unused as of: commit d8b3dd16cb947cc16c0700c4836367b4fcb15525 cpu: Move feature

Re: [libvirt PATCH 18/39] cpu_x86: Use g_auto* in x86EncodePolicy

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 16/39] cpu_x86: Use g_auto* in virCPUx86Compare

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 6758fcc170..e4e21fbed4 100644 --- a/src/cpu/cpu_x86.c +++

Re: [libvirt PATCH 15/39] cpu_x86: Use g_auto* in x86Compute

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 64 ++- 1 file changed, 24 insertions(+), 40 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 6c3f9fc0be..6758fcc170 100644 ---

Re: [libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

2020-04-07 Thread Daniel P . Berrangé
On Tue, Apr 07, 2020 at 11:50:31AM +0200, Ján Tomko wrote: > On a Monday in 2020, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the > > presence of machine1 service"), the code checks for systemd1 > >

Re: [libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration

2020-04-07 Thread Ján Tomko
On a Monday in 2020, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the presence of machine1 service"), the code checks for systemd1 registration. Not totally unreasonable, but that seems odd since we actually check

Re: backport new changes to 4.0.0

2020-04-07 Thread Peter Krempa
On Tue, Apr 07, 2020 at 13:57:09 +0800, Jiatong Shen wrote: > Hello, > > Sorry in advance if I am asking questions at the wrong place. > > I would like know if we have plans to backport new features to old > releases, for example block copy remote disks. If the answer is no, then Definitely

Re: backport new changes to 4.0.0

2020-04-07 Thread Andrea Bolognani
On Tue, 2020-04-07 at 13:57 +0800, Jiatong Shen wrote: > Hello, > > Sorry in advance if I am asking questions at the wrong place. A better venue for this kind of question would be the libvirt-users mailing list, so please keep that in mind for next time :) > I would like know if we have plans

Re: [libvirt PATCH 00/15] RFC: basic CGroup support with qemu:///session

2020-04-07 Thread Pavel Hrdina
On Mon, Apr 06, 2020 at 11:26:57PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > This is a small series that allows basic QEMU VM CGroup support with > the help of machined --user: > https://github.com/systemd/systemd/pull/15312 > > The first few patches are

backport new changes to 4.0.0

2020-04-07 Thread Jiatong Shen
Hello, Sorry in advance if I am asking questions at the wrong place. I would like know if we have plans to backport new features to old releases, for example block copy remote disks. If the answer is no, then where can I find some guidance on building a libvirt debian packages? Thank you very

Re: [libvirt PATCH 13/39] cpu_x86: Use g_auto* in virCPUx86LoadMap

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 14/39] cpu_x86: Use g_auto* in virCPUx86DataParse

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 12/39] cpu_x86: Use g_auto* in x86ModelParse

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 11/39] cpu_x86: Use g_auto* in x86ModelFromCPU

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 10/39] cpu_x86: Use g_auto* in x86FeatureParse

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 09/39] cpu_x86: Use g_auto* in x86VendorParse

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 08/39] cpu_x86: Use g_auto* in x86DataToCPU

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 07/39] cpu_x86: Use glib allocation in virCPUx86GetModels

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index bcb87d6f93..fce7a2b8c5 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@

Re: [libvirt PATCH 06/39] cpu_x86: Use glib allocation for virCPUx86Map

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 05/39] cpu_x86: Use glib allocation for virCPUx86Model

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 31 --- 1 file changed, 8 insertions(+), 23 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 04/39] cpu_x86: Use glib allocation for virCPUx86Feature

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 03/39] cpu_x86: Use glib allocation for virCPUx86Vendor

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 02/39] cpu_x86: Use glib allocation for virCPU{, x86}Data

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 45 ++--- 1 file changed, 22 insertions(+), 23 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 01/39] cpu_x86: Drop noTSX hint for incompatible CPUs

2020-04-07 Thread Ján Tomko
On a Friday in 2020, Jiri Denemark wrote: The hint was introduced a long time ago when broken TSX implementation was found in Haswell and Broadwell CPUs. Since then many more CPUs with TSX were introduced and and disabled due to TAA vulnerability. Thus the hint is not very useful and I think