Hi jiri,
Please help to review this patches.
Thanks,
Chen
On Fri, 2014-09-12 at 12:32 +0800, Chen Fan wrote:
This version differs from the patch set
conf: Check migration_host is valid or not during libvirt restarts
I posted 2 weeks ago, I droped checking the migration_host on target
On 09/13/14 15:27, John Ferlan wrote:
Coverity complains that on the first pass through the for loop that
'params' cannot be true, thus the ternary setting to cannot be
done - which is I believe true - thus this really is a deadcode
situation.
It doesn't complain on the following
On 09/13/14 15:27, John Ferlan wrote:
Coverity complains that because of how 'offset' is initialized to
0 (zero), the resulting math and comparison on rem is pointless.
According to the origin commit id '3ec128989', the code is a
replacement for gmtime(), but without the localtime() or GMT
On 09/13/14 15:27, John Ferlan wrote:
Seems when commit id 'ea130e3b' added the checks to ensure each of
the hard_limit, soft_limit, and swap_hard_limit wasn't set at
VIR_DOMAIN_MEMORY_PARAM_UNLIMITED - a copy/paste error of using
the 'hard_limit' for each comparison was done. Adjust the code.
On Thu, Sep 11, 2014 at 09:54:51AM -0400, Laine Stump wrote:
On 09/08/2014 07:40 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/schemas/basictypes.rng | 19 --
docs/schemas/capability.rng | 10 +--
docs/schemas/domaincaps.rng | 5 +-
On Wed, Sep 10, 2014 at 04:46:27PM +0100, Daniel P. Berrange wrote:
On Wed, Sep 10, 2014 at 05:36:58PM +0200, Ján Tomko wrote:
On 09/08/2014 01:40 PM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
docs/formatdomain.html.in | 7
On Wed, Sep 10, 2014 at 06:48:48PM -0400, John Ferlan wrote:
On 09/08/2014 01:46 AM, Martin Kletzander wrote:
There were various problems introduced by the series on FD passing.
The path for the socket was not created, the socket was not removed
before binding it, etc. Let's see if it's any
On 09/13/14 15:27, John Ferlan wrote:
Coverity complained that checking the return of virDomainCreate()
was not consistent amongst the callers - so added the return check
to the objecteventtest.c and adjust the virt-login-shell to compare
0 rather than just non zero for the failure condition.
On 09/13/14 15:27, John Ferlan wrote:
Coverity complains about the calculation of the buf len within
the PROBE macro. So to quiet things down, do the calculation prior
to usage in either write() or qemuMonitorIOWriteWithFD() calls and
then have the PROBE use the calculated values - which
On 09/13/14 15:27, John Ferlan wrote:
Coverity complains that the condition size + 1 == 0 cannot happen.
It's already been determined that offset+size is not larger than
buf_size (and buf_size is smaller than UINT_MAX); and also that
buff_size smaller than UINT_MAX isn't guaranteed in this
This patch implements the VIR_DOMAIN_STATS_BALLOON
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 6 ++
src/qemu/qemu_driver.c | 38 ++
3 files changed,
Future patches which will implement more
bulk stats groups for QEMU will need to access
the connection object.
To accomodate that, a few changes are needed:
* enrich internal prototype to pass qemu driver object.
* add per-group flag to mark if one collector needs
monitor access or not.
* if
This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 7 +++
src/qemu/qemu_driver.c | 41 +
3 files
Management software wants to be able to allocate disk space on demand.
To support this they need keep track of the space occupation
of the block device.
This information is reported by qemu as part of block stats.
This patch extend the block information in the bulk stats with
the allocation
This patchset enhances the QEMU support
for the new bulk stats API to include
equivalents of these APIs:
virDomainBlockInfo
virDomainGetInfo - for balloon stats
virDomainGetCPUStats
virDomainBlockStatsFlags
virDomainInterfaceStats
virDomainGetVcpusFlags
virDomainGetVcpus
This subset of API is
On 13.09.2014 17:21, ban...@openmailbox.org wrote:
Hello. Under Hypevisor Features for Domain elements, I noticed new
features being added like
kvm
hidden state='on'/
/kvm
Probably more will be added later I am guessing.
-Is this a performance feature?
-Can it also be applied to qemu only
On Mon, Sep 15, 2014 at 09:47:45AM +0200, Martin Kletzander wrote:
On Wed, Sep 10, 2014 at 04:46:27PM +0100, Daniel P. Berrange wrote:
On Wed, Sep 10, 2014 at 05:36:58PM +0200, Ján Tomko wrote:
On 09/08/2014 01:40 PM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
On Sun, Sep 14, 2014 at 06:35:19PM +0100, Ian Campbell wrote:
On Wed, 2014-09-10 at 12:20 +0200, Michal Privoznik wrote:
+/*
+ * Workaround older glibc. While kernel may support the setns
+ * syscall, the glibc wrapper might not exist. If that's the
+ * case, use our own.
+ */
On 09/15/14 10:48, Francesco Romani wrote:
Future patches which will implement more
bulk stats groups for QEMU will need to access
the connection object.
To accomodate that, a few changes are needed:
* enrich internal prototype to pass qemu driver object.
* add per-group flag to mark if
On Sat, Sep 13, 2014 at 12:00:53PM +0530, Pradipta Kr. Banerjee wrote:
cpu: Handle only high order 16 bits of PVR for IBM Power processors
IBM Power processors encode PVR as CPU family in higher
16 bits and a CPU version in lower 16 bits. Since there is no significant
change in behavior
On Fri, Sep 12, 2014 at 06:42:08PM +0200, Pavel Hrdina wrote:
On 09/12/2014 06:25 PM, Daniel P. Berrange wrote:
On Fri, Sep 12, 2014 at 06:10:44PM +0200, Pavel Hrdina wrote:
There was a bug that if libvirtd binary has been updated than the
capability file wasn't reloaded therefore new
On 09/15/14 11:20, Peter Krempa wrote:
On 09/15/14 10:48, Francesco Romani wrote:
Future patches which will implement more
bulk stats groups for QEMU will need to access
the connection object.
To accomodate that, a few changes are needed:
* enrich internal prototype to pass qemu driver
Hi Eric,
We initially commented the code with our company name to help us to identify it
easily internally.
I totally agree that this comment should not appear in the upstream code; I
apologize about that.
No problem; I will make another submission after a code cleaning.
Thanks,
Yves.
On Sat, Sep 13, 2014 at 09:27:45AM -0400, John Ferlan wrote:
Coverity complains that the comparison:
if (nfds nfds ((int)!!sock_path + (int)!!sock_path_ro))
could mean 'sock_path' is NULL. Later in virNetSocketNewListenUNIX
there's a direct dereference of path in the error path:
if
We already are checking for negative value, reporting an error, but
using wrong function, so the check never succeeds. This patch provides
just a minor change in call of the right version of function virStrToLong.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138539
---
On 09/15/14 10:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 7 +++
src/qemu/qemu_driver.c | 41
On 09/15/2014 11:24 AM, Daniel P. Berrange wrote:
On Fri, Sep 12, 2014 at 06:42:08PM +0200, Pavel Hrdina wrote:
On 09/12/2014 06:25 PM, Daniel P. Berrange wrote:
On Fri, Sep 12, 2014 at 06:10:44PM +0200, Pavel Hrdina wrote:
There was a bug that if libvirtd binary has been updated than the
When spanning tree protocol is allowed in bridge settings, forward delay
value is set as well (default is 0 if omitted). Until now, there was no
check for delay value validity. Delay makes sense only as a positive
numerical value.
Note: However, even if you provide positive numerical value,
On 09/15/14 10:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_BALLOON
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 6 ++
src/qemu/qemu_driver.c | 38
On 09/15/14 10:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_VCPU
group of statistics.
To do so, this patch also extracts a helper to gather the
VCpu information.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
This patch implements the VIR_DOMAIN_STATS_BLOCK
group of statistics.
To do so, an helper function to get the block stats
of all the disks of a domain is added.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 20
This patch implements the VIR_DOMAIN_STATS_VCPU
group of statistics.
To do so, this patch also extracts a helper to gather the
VCpu information.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 12 +++
On Mon, Sep 15, 2014 at 11:43:10AM +0200, Pavel Hrdina wrote:
On 09/15/2014 11:24 AM, Daniel P. Berrange wrote:
On Fri, Sep 12, 2014 at 06:42:08PM +0200, Pavel Hrdina wrote:
On 09/12/2014 06:25 PM, Daniel P. Berrange wrote:
On Fri, Sep 12, 2014 at 06:10:44PM +0200, Pavel Hrdina wrote:
There
On 09/13/14 15:27, John Ferlan wrote:
Since 98b9acf5aa02551dd37d0209339aba2e22e4004a
This was a false positive where Coverity was complaining that the
remoteDeserializeTypedParameters() could allocate 'params', but
none of the callers could return the allocated memory back to their
caller
Exports to the domstats commands the new bulk stats groups.
Signed-off-by: Francesco Romani from...@redhat.com
---
tools/virsh-domain-monitor.c | 35 +++
tools/virsh.pod | 4 +++-
2 files changed, 38 insertions(+), 1 deletion(-)
diff --git
This patch implements the VIR_DOMAIN_STATS_INTERFACE
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 14 +++
src/qemu/qemu_driver.c | 89
3 files
On Mon, Sep 15, 2014 at 10:20:01AM +0100, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 09:47:45AM +0200, Martin Kletzander wrote:
On Wed, Sep 10, 2014 at 04:46:27PM +0100, Daniel P. Berrange wrote:
On Wed, Sep 10, 2014 at 05:36:58PM +0200, Ján Tomko wrote:
On 09/08/2014 01:40 PM, Martin
On 09/15/14 10:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_INTERFACE
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 14 +++
src/qemu/qemu_driver.c | 89
On Mon, Sep 15, 2014 at 01:19:25PM +0200, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 10:20:01AM +0100, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 09:47:45AM +0200, Martin Kletzander wrote:
On Wed, Sep 10, 2014 at 04:46:27PM +0100, Daniel P. Berrange wrote:
On Wed, Sep 10, 2014 at
As of 136ad4974 it is possible to specify different huge pages per
guest NUMA node. However, there's no check if nodeset specified in
./hugepages/page contains only those guest NUMA nodes that exist.
In other words with current code it is possible to define meaningless
combination:
*** BLURB HERE ***
Michal Privoznik (2):
conf: Disallow nonexistent NUMA nodes for hugepages
qemu: Honor hugepages for UMA domains
src/qemu/qemu_command.c| 49 --
.../qemuxml2argv-hugepages-pages4.xml | 45
On 09/15/2014 04:36 AM, Martin Kletzander wrote:
On Sat, Sep 13, 2014 at 09:27:45AM -0400, John Ferlan wrote:
Coverity complains that the comparison:
if (nfds nfds ((int)!!sock_path + (int)!!sock_path_ro))
could mean 'sock_path' is NULL. Later in virNetSocketNewListenUNIX
there's a
There are two ways how to tell qemu to use huge pages. The first one
is suitable for domains with NUMA nodes: the path to hugetlbfs mount
is appended to NUMA node definition on the command line. The second
one is suitable for UMA domains: here there's this global '-mem-path'
argument that accepts
On 09/12/2014 08:47 PM, John Ferlan wrote:
On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virstring.c | 25 +
src/util/virstring.h | 20
3 files
On 09/15/14 10:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_BLOCK
group of statistics.
To do so, an helper function to get the block stats
of all the disks of a domain is added.
Signed-off-by: Francesco Romani from...@redhat.com
---
On 09/15/14 10:48, Francesco Romani wrote:
Exports to the domstats commands the new bulk stats groups.
Signed-off-by: Francesco Romani from...@redhat.com
---
tools/virsh-domain-monitor.c | 35 +++
tools/virsh.pod | 4 +++-
2 files changed, 38
On Mon, Sep 15, 2014 at 07:49:09AM -0400, John Ferlan wrote:
On 09/15/2014 04:36 AM, Martin Kletzander wrote:
On Sat, Sep 13, 2014 at 09:27:45AM -0400, John Ferlan wrote:
Coverity complains that the comparison:
if (nfds nfds ((int)!!sock_path + (int)!!sock_path_ro))
could mean 'sock_path'
On 07.09.2014 05:30, Hongbin Lu wrote:
The OpenVZ driver reported an error on parsing some OpenVZ config
parameters (e.g. diskspace). This issue is due to the driver made
two incorrect assumptions about the value of the parameters:
1. Assume paramaeter is just a number (without unit suffix).
2.
On Mon, Sep 15, 2014 at 12:40:48PM +0100, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 01:19:25PM +0200, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 10:20:01AM +0100, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 09:47:45AM +0200, Martin Kletzander wrote:
On Wed, Sep 10, 2014 at
On 09/15/14 10:48, Francesco Romani wrote:
Management software wants to be able to allocate disk space on demand.
To support this they need keep track of the space occupation
of the block device.
This information is reported by qemu as part of block stats.
This patch extend the block
On 09/15/14 10:48, Francesco Romani wrote:
This patchset enhances the QEMU support
for the new bulk stats API to include
equivalents of these APIs:
virDomainBlockInfo
virDomainGetInfo - for balloon stats
virDomainGetCPUStats
virDomainBlockStatsFlags
virDomainInterfaceStats
On 09/12/2014 09:46 PM, John Ferlan wrote:
On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend the cputune.
With typedParameters we don't have to worry about creating
On 09/15/2014 02:56 PM, Daniel P. Berrange wrote:
On Sat, Sep 13, 2014 at 12:00:53PM +0530, Pradipta Kr. Banerjee wrote:
cpu: Handle only high order 16 bits of PVR for IBM Power processors
IBM Power processors encode PVR as CPU family in higher
16 bits and a CPU version in lower 16 bits.
- Original Message -
From: Peter Krempa pkre...@redhat.com
To: Francesco Romani from...@redhat.com, libvir-list@redhat.com
Sent: Monday, September 15, 2014 2:25:08 PM
Subject: Re: [libvirt] [PATCHv5 0/8] bulk stats: QEMU implementation
[...]
ChangeLog
v5: address reviewer's
On 09/15/14 10:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 7 +++
src/qemu/qemu_driver.c | 41
On 09/13/2014 12:12 AM, Eric Blake wrote:
On 09/10/2014 06:08 AM, Pavel Hrdina wrote:
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend the cputune.
With typedParameters we don't have to worry about creating some
- Original Message -
From: Peter Krempa pkre...@redhat.com
To: Francesco Romani from...@redhat.com, libvir-list@redhat.com
Sent: Monday, September 15, 2014 2:49:50 PM
Subject: Re: [libvirt] [PATCHv5 2/8] qemu: bulk stats: implement CPU stats
group
+static int
On 09/12/2014 10:31 PM, John Ferlan wrote:
s//something to describe what's being done!
Might be nice to see what the event would look like when it's triggered.
May help in that documentation effort in the future.
On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
On 05.09.2014 04:25, Hongbin Lu wrote:
This patch adds initial migration support to the OpenVZ driver,
using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration
functions.
---
src/openvz/openvz_conf.h |5 +-
src/openvz/openvz_driver.c | 348
On 09/15/14 10:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_INTERFACE
group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 14 +++
src/qemu/qemu_driver.c | 89
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
v2:
- memShared='o{n|ff}' - memAccess='{shared|private}'
- whitespaces
docs/formatdomain.html.in | 7 +++-
docs/schemas/domaincommon.rng | 8
src/conf/cpu_conf.c
Changes to v1:
- 1/3 is now not connected to the rest of the patches any more
- whitespaces
- memShared='on/off' - memAccess='private/shared'
Martin Kletzander (3):
schemas: finish virTristate{Bool,Switch} transition
docs, conf, schema: add support for shared memory mapping
qemu: add
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
v2:
- memShared - memAccess
src/qemu/qemu_command.c| 27 ++
.../qemuxml2argv-hugepages-shared.args | 16 +
tests/qemuxml2argvtest.c
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
v2:
- s/virBool/virYesNo/
- s/virSwitch/virOnOff/
docs/schemas/basictypes.rng | 19 --
docs/schemas/capability.rng | 10 +--
docs/schemas/domaincaps.rng | 5 +-
docs/schemas/domaincommon.rng | 155
On 09/13/2014 12:12 AM, Eric Blake wrote:
On 09/10/2014 06:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/qemu/qemu_cgroup.c | 18 -
src/qemu/qemu_driver.c | 73 ++
2 files changed, 90
On 09/14/2014 05:46 AM, Roman Bogorodskiy wrote:
- Provide an implementation for buildPool and deletePool operations
for the ZFS storage backend.
- Add VIR_STORAGE_POOL_SOURCE_DEVICE flag to ZFS pool poolOptions
as now we can specify devices to build pool from
- storagepool.rng: add
On 09/15/2014 04:42 AM, Peter Krempa wrote:
On 09/13/14 15:27, John Ferlan wrote:
Coverity complains that the condition size + 1 == 0 cannot happen.
It's already been determined that offset+size is not larger than
buf_size (and buf_size is smaller than UINT_MAX); and also that
buff_size
On 09/14/2014 07:24 AM, Roman Bogorodskiy wrote:
- docs/formatstorage.html.in: document 'zfs' pool type, add it
to a list of pool types that could use source physical devices
- docs/storage.html.in: update a ZFS pool example XML with
source physical devices, mention that starting from
On 09/15/14 10:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_VCPU
group of statistics.
To do so, this patch also extracts a helper to gather the
VCpu information.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
Currently, the setns() wrapper is supported only for x86_64 and i686
which leaves us failing to build on other platforms like arm, aarch64
and so on. This means, that the wrapper needs to be extended to those
platforms and make to fail on runtime not compile time.
The syscall numbers for other
On 09/09/2014 02:20 PM, Lubomir Rintel wrote:
The manufacurer and product from USB device itself are usually not
particularly
useful -- they tend to be missing, or ugly (all-uppercase, padded with spaces,
etc.). Prefer what's in the usb id database and fall back to descriptors only
if the
On 09/15/14 10:48, Francesco Romani wrote:
This patch implements the VIR_DOMAIN_STATS_BLOCK
group of statistics.
To do so, an helper function to get the block stats
of all the disks of a domain is added.
Signed-off-by: Francesco Romani from...@redhat.com
---
On Tue, Sep 09, 2014 at 02:20:43PM +0200, Lubomir Rintel wrote:
The manufacurer and product from USB device itself are usually not particularly
useful -- they tend to be missing, or ugly (all-uppercase, padded with spaces,
etc.). Prefer what's in the usb id database and fall back to descriptors
On 09/15/2014 03:43 PM, Michal Privoznik wrote:
Currently, the setns() wrapper is supported only for x86_64 and i686
which leaves us failing to build on other platforms like arm, aarch64
and so on. This means, that the wrapper needs to be extended to those
platforms and make to fail on runtime
On 09/13/2014 05:28 PM, Pradipta Kr. Banerjee wrote:
qemu: Add support for multiple versions of 'pseries' machine type
qemu for IBM Power processor architecture is adding functionality for
supporting multiple 'pseries' machine type versions, each with different
capabilities. This patch is
On 09/15/2014 03:43 PM, Michal Privoznik wrote:
Currently, the setns() wrapper is supported only for x86_64 and i686
which leaves us failing to build on other platforms like arm, aarch64
and so on. This means, that the wrapper needs to be extended to those
platforms and make to fail on runtime
The backing store string location offset 0 determines that the file
isn't present. The string size shouldn't be then checked:
from qemu.git/docs/specs/qcow2.txt
== Header ==
The first cluster of a qcow2 image contains the file header:
Byte 0 - 3: magic
QCOW magic string
On 09/15/14 15:23, John Ferlan wrote:
On 09/15/2014 04:42 AM, Peter Krempa wrote:
On 09/13/14 15:27, John Ferlan wrote:
Coverity complains that the condition size + 1 == 0 cannot happen.
It's already been determined that offset+size is not larger than
buf_size (and buf_size is smaller
On 09/15/2014 04:22 PM, Peter Krempa wrote:
The backing store string location offset 0 determines that the file
isn't present. The string size shouldn't be then checked:
from qemu.git/docs/specs/qcow2.txt
== Header ==
The first cluster of a qcow2 image contains the file header:
Byte
On 09/15/2014 10:22 AM, Peter Krempa wrote:
The backing store string location offset 0 determines that the file
isn't present. The string size shouldn't be then checked:
from qemu.git/docs/specs/qcow2.txt
== Header ==
The first cluster of a qcow2 image contains the file header:
On 09/03/2014 06:15 PM, John Ferlan wrote:
In order to support cpuset setting, introduce qemuSetupCgroupIOThreadsPin
and qemuSetupCgroupForIOThreads to mimic the existing Vcpu API's.
These will support having an 'iotrhreadpin' element in the 'cpuset' in
order to pin named IOThreads to
On 09/03/2014 06:15 PM, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1101574
Add an option 'iothreadpin' to the cpuset to allow for setting the
CPU affinity for each IOThread.
The iothreadspin will mimic the vcpupin with respect to being able to
assign each iothread to a
On 09/15/2014 04:09 AM, Peter Krempa wrote:
On 09/13/14 15:27, John Ferlan wrote:
Coverity complains about the calculation of the buf len within
the PROBE macro. So to quiet things down, do the calculation prior
to usage in either write() or qemuMonitorIOWriteWithFD() calls and
then have
On 09/15/14 16:57, John Ferlan wrote:
On 09/15/2014 04:09 AM, Peter Krempa wrote:
On 09/13/14 15:27, John Ferlan wrote:
Coverity complains about the calculation of the buf len within
the PROBE macro. So to quiet things down, do the calculation prior
to usage in either write() or
On 09/03/2014 06:15 PM, John Ferlan wrote:
The following patches will add more support for IOThreads not completed
from the initial patches. These changes support the remaining elements of
bz https://bugzilla.redhat.com/show_bug.cgi?id=1101574 (working through
unsetting the private bits - as
On 15.09.2014 16:20, Pavel Hrdina wrote:
On 09/15/2014 03:43 PM, Michal Privoznik wrote:
Currently, the setns() wrapper is supported only for x86_64 and i686
which leaves us failing to build on other platforms like arm, aarch64
and so on. This means, that the wrapper needs to be extended to
Cleanup virDomanDef structure from other nested structure and create
separate type definition for them.
Fix a typo in virDomainHugePage.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/conf/domain_conf.h | 98 ++
1 file changed, 59
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
examples/object-events/event-test.c | 52 -
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/examples/object-events/event-test.c
b/examples/object-events/event-test.c
index d6cfe46..f1b9cda 100644
This patch series introduce new cputune event to inform
management applications about every change of cputune values
for running domains.
There is missing documentation for all events so the documentation
for this event will be part of the patches to document all events.
Changes from v2:
-
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/qemu/qemu_cgroup.c | 18 +++-
src/qemu/qemu_driver.c | 74 ++
2 files changed, 91 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend the cputune.
With typedParameters we don't have to worry about creating some sort of
v2 of cputune event if there will be new features implemented for cputune.
On Mon, Sep 15, 2014 at 03:43:55PM +0200, Michal Privoznik wrote:
Currently, the setns() wrapper is supported only for x86_64 and i686
which leaves us failing to build on other platforms like arm, aarch64
and so on. This means, that the wrapper needs to be extended to those
platforms and make to
On Mon, Sep 15, 2014 at 05:12:12PM +0200, Pavel Hrdina wrote:
This patch series introduce new cputune event to inform
management applications about every change of cputune values
for running domains.
There is missing documentation for all events so the documentation
for this event will be
On Mon, Sep 15, 2014 at 05:08:01PM +0200, Michal Privoznik wrote:
On 15.09.2014 16:20, Pavel Hrdina wrote:
On 09/15/2014 03:43 PM, Michal Privoznik wrote:
Currently, the setns() wrapper is supported only for x86_64 and i686
which leaves us failing to build on other platforms like arm, aarch64
On 15.09.2014 17:15, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 03:43:55PM +0200, Michal Privoznik wrote:
Currently, the setns() wrapper is supported only for x86_64 and i686
which leaves us failing to build on other platforms like arm, aarch64
and so on. This means, that the wrapper
On 09/13/2014 09:27 AM, John Ferlan wrote:
After this pile of changes I am back down to zero issues.
Patch 1 - is a repeat offender - this is the 3rd try, but I think
I have a better solution here. Details are in the commit message.
Patch 2-3 - are repeats from the last series as patches
On Mon, 2014-09-15 at 10:21 +0100, Daniel P. Berrange wrote:
On Sun, Sep 14, 2014 at 06:35:19PM +0100, Ian Campbell wrote:
On Wed, 2014-09-10 at 12:20 +0200, Michal Privoznik wrote:
+/*
+ * Workaround older glibc. While kernel may support the setns
+ * syscall, the glibc wrapper
Allow qemu driver to save the configuration use by bps_max and they friends.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/conf/domain_conf.c | 89 +-
1 file changed, 88 insertions(+), 1 deletion(-)
diff --git
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed,
This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
qemuDomainSetBlockIoTune and qemuDomainGetBlockIoTune.
The last patch add support for terse parameters to the virsh blkdeviotune
command.
v2: spellfix
1 - 100 of 168 matches
Mail list logo
