Re: [libvirt] [RFC v2] external (pull) backup API

On 04/13/2018 05:16 AM, Nikolay Shirokovskiy wrote: > > > On 13.04.2018 00:16, John Snow wrote: >> >> >> On 04/03/2018 08:01 AM, Nikolay Shirokovskiy wrote: >>> Hi, all. >>> >>>

Re: [libvirt] [PATCH v4 04/14] qemu: Generate alias and socket path for pr-helper

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > While we're not generating the command line just yet (look for > the next commits), we can generate the alias for pr-manager. > A domain can have up to one managed pr-manager (in which case > socket path is decided by libvirt and pr-helper is

Re: [libvirt] [PATCH v2 59/73] qemu: Add support for sending capabilities in migration cookie

On Wed, Apr 11, 2018 at 04:41:49PM +0200, Jiri Denemark wrote: Some migration capabilities may be enabled automatically, but only if both sides of migration support them. Thus we need to be able transfer the list of supported migration capabilities in migration cookie. Signed-off-by: Jiri

Re: [libvirt] [PATCH v4 05/14] qemu: Store pr runtime data in status XML

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > Now that we generate pr-manager alias and socket path store them > in status XML so that they are preserved across daemon restarts. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 64 >

[libvirt] [PATCH 1/2] vmware: Fix initialization of VMware Fusion

On 2018-04-11 14:02, John Ferlan wrote: > > > On 04/03/2018 05:32 AM, Rainer Müller wrote: >> The vmware driver wants to execute vmware-vmx from the same directory in >> which vmrun was found. However, on VMware Fusion 10 vmrun at >> /Applications/VMware Fusion.app/Contents/Public/vmrun is a

Re: [libvirt] [RFC v2] external (pull) backup API

On 04/13/2018 08:01 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 1. It looks unsafe to use nbd server + backup(sync=none) on same node, >>> synchronization is needed, like in block/replication, which uses >>> backup_wait_for_overlapping_requests, backup_cow_request_begin, >>>

Re: [libvirt] [PATCH v4 02/14] qemuDomainDiskChangeSupported: Deny changing reservations

On 04/10/2018 10:58 AM, Michal Privoznik wrote: > Couple of reasons for that: > > a) there's no monitor command to change path where the pr-helper > connects to, or > b) there's no monitor command to introduce a new pr-helper for a > disk that already exists. > > Signed-off-by: Michal

Re: [libvirt] [PATCH] Add function that raises error if domain is not active

On Thu, Apr 12, 2018 at 07:49:15PM +, Clementine Hayat wrote: Add a function named virDomainObjCheckIsActive in src/conf/domain_conf.c. It calls virDomainObjIsActive, raises error and returns. *raises error if necessary There is a lot of occurence of this pattern and it will save 3

[libvirt] [PATCHv2] Remove redundant virFileIsExecutable check

Remove unnecessary virFileIsExecutable check after virFindFileInPath. Since commit 9ae992f, virFindFileInPath will reject non-executables. 9ae992f24353d6506f570fc9dd58355b165e4472 virFindFileInPath: only find executable non-directory Signed-off-by: Radostin Stoyanov ---

Re: [libvirt] [dbus PATCH v2 03/22] Introduce virtDBusDomainMemoryStatTypeToString helper function

On Thu, Apr 12, 2018 at 04:32:42PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > src/domain.c | 14 ++ > 1 file changed, 14 insertions(+) This patch can be squashed into the following one. Pavel signature.asc Description: PGP

Re: [libvirt] [PATCH] Remove redundant virFileIsExecutable check

On 04/13/2018 08:01 AM, Radostin Stoyanov wrote: > Remove unnecessary virFileIsExecutable check after virFindFileInPath. > Since the commit 9ae992f virFindFileInPath will reject non-executables. > > 9ae992f24353d6506f570fc9dd58355b165e4472 > virFindFileInPath: only find executable non-directory >

Re: [libvirt] [dbus PATCH v2 04/22] Implement MemoryStats for Domain Interface

On Thu, Apr 12, 2018 at 04:32:43PM +0200, Katerina Koukiou wrote: > This method is not tested for now since the test driver > doesn't support this API. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 7 ++ > src/domain.c| 52 >

Re: [libvirt] [dbus PATCH v2 07/22] Introduce virtDBusDomainJobTypeToString function

On Thu, Apr 12, 2018 at 04:32:46PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > src/domain.c | 10 ++ > 1 file changed, 10 insertions(+) This can be squashed into the following patch. Pavel signature.asc Description: PGP signature --

Re: [libvirt] [dbus PATCH v2 08/22] Implement GetJobInfo method for Domain interface

On Thu, Apr 12, 2018 at 04:32:47PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/domain.c| 35 +++ > 2 files changed, 40 insertions(+) > > diff --git

[libvirt] [PATCH] Remove redundant virFileIsExecutable check

Remove unnecessary virFileIsExecutable check after virFindFileInPath. Since the commit 9ae992f virFindFileInPath will reject non-executables. 9ae992f24353d6506f570fc9dd58355b165e4472 virFindFileInPath: only find executable non-directory Signed-off-by: Radostin Stoyanov ---

Re: [libvirt] [PATCH] Add function that raises error if domain is not active

On 04/13/2018 09:31 AM, Ján Tomko wrote: > On Thu, Apr 12, 2018 at 07:49:15PM +, Clementine Hayat wrote: >> Add a function named virDomainObjCheckIsActive in src/conf/domain_conf.c. >> It calls virDomainObjIsActive, raises error and returns. > > *raises error if necessary > >> >> There is a

Re: [libvirt] [PATCH] Add function that raises error if domain is not active

On Fri, Apr 13, 2018 at 09:45:48AM +0200, Michal Privoznik wrote: > On 04/13/2018 09:31 AM, Ján Tomko wrote: > > On Thu, Apr 12, 2018 at 07:49:15PM +, Clementine Hayat wrote: > >> Add a function named virDomainObjCheckIsActive in src/conf/domain_conf.c. > >> It calls virDomainObjIsActive,

Re: [libvirt] [PATCH v2 05/73] qemu: Move qemuMigrationCapsGet

On Wed, Apr 11, 2018 at 04:40:55PM +0200, Jiri Denemark wrote: The function is connected with the code which handles migration parameters and capabilities, let's move it to qemu_migration_params.c. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 14

Re: [libvirt] [PATCH v2 04/73] qemu: Move qemuDomainCheckMigrationCapabilities

On Wed, Apr 11, 2018 at 04:40:54PM +0200, Jiri Denemark wrote: Since the function is tightly connected to migration, it was renamed as qemuMigrationCapsCheck and moved to qemu_migration_params.c. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 72

Re: [libvirt] [PATCH v2 07/73] qemu: Make qemuMigrationParamsFree follow common pattern

On Wed, Apr 11, 2018 at 04:40:57PM +0200, Jiri Denemark wrote: Our *Free functions usually do not take a double pointer and the caller has to make sure it doesn't use the stale pointer after the *Free function returns. Signed-off-by: Jiri Denemark ---

Re: [libvirt] [dbus PATCH v2 02/22] Implement SchedulerType property for Domain Interface

On Thu, Apr 12, 2018 at 04:32:41PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 4 > src/domain.c| 23 +++ > test/test_domain.py | 3 +++ > 3 files changed, 30

Re: [libvirt] [dbus PATCH v2 04/22] Implement MemoryStats for Domain Interface

On Thu, Apr 12, 2018 at 04:32:43PM +0200, Katerina Koukiou wrote: > This method is not tested for now since the test driver > doesn't support this API. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 7 ++ > src/domain.c| 52 >

Re: [libvirt] [dbus PATCH v2 06/22] Implement DetachDevice method for Domain Interface

On Thu, Apr 12, 2018 at 04:32:45PM +0200, Katerina Koukiou wrote: > This method is not tested for now since the test driver > doesn't suport this API. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 25

Re: [libvirt] [dbus PATCH v2 04/22] Implement MemoryStats for Domain Interface

On Thu, Apr 12, 2018 at 04:32:43PM +0200, Katerina Koukiou wrote: > This method is not tested for now since the test driver > doesn't support this API. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 7 ++ > src/domain.c| 52 >

Re: [libvirt] [PATCH v2 03/73] qemu: New file for all APIs related to migration parameters

On Wed, Apr 11, 2018 at 04:40:53PM +0200, Jiri Denemark wrote: In the end, this will allow us to have most of the logic around migration parameters and capabilities done in one place. Signed-off-by: Jiri Denemark --- po/POTFILES.in | 1 +

Re: [libvirt] [PATCH v2 06/73] qemu: Reindent qemuMigrationParamsSetEmptyTLS

On Wed, Apr 11, 2018 at 04:40:56PM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Thank you. Reviewed-by: Ján Tomko Jano

Re: [libvirt] [RFC v2] external (pull) backup API

On 13.04.2018 00:16, John Snow wrote: > > > On 04/03/2018 08:01 AM, Nikolay Shirokovskiy wrote: >> Hi, all. >> >> >>

Re: [libvirt] [RFC v2] external (pull) backup API

On 13.04.2018 01:10, John Snow wrote: > > On 04/12/2018 04:58 AM, Nikolay Shirokovskiy wrote: >> On 11.04.2018 19:32, Eric Blake wrote: >>> On 04/03/2018 07:01 AM, Nikolay Shirokovskiy wrote: > > > [snip] > > >>> >>> I'm trying to figure out how BlockCheckpoint and BlockSnapshots relate.

Re: [libvirt] [PATCH] Add function that raises error if domain is not active

On Thu, Apr 12, 2018 at 19:49:15 +, Clementine Hayat wrote: > Add a function named virDomainObjCheckIsActive in src/conf/domain_conf.c. > It calls virDomainObjIsActive, raises error and returns. > > There is a lot of occurence of this pattern and it will save 3 lines on > each call. Knowing

Re: [libvirt] [dbus PATCH v2 17/22] Implement GetBlkioParameters method for domain Interface

On Thu, Apr 12, 2018 at 04:32:56PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 37 + > 2 files changed, 43 insertions(+) [...] >

Re: [libvirt] [PATCH v2 21/73] qemu: Set tlsHostname inside qemuMigrationParamsEnableTLS

On Wed, Apr 11, 2018 at 04:41:11PM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 31 --- src/qemu/qemu_migration_params.c | 9 +++-- src/qemu/qemu_migration_params.h | 1 + 3 files changed, 20

Re: [libvirt] [PATCH v2 11/73] qemu: Introduce qemuMigrationParams struct

On Wed, Apr 11, 2018 at 04:41:01PM +0200, Jiri Denemark wrote: Currently migration parameters are stored in a structure which mimics the QEMU migration parameters handled by query-migrate-parameters and migrate-set-parameters. The new structure will become a libvirt's abstraction on top of QEMU

Re: [libvirt] [dbus PATCH v2 13/22] Implement HasManagedSaveImage method for Domain Interface

On Thu, Apr 12, 2018 at 04:32:52PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 29 + > test/test_domain.py | 2 +- > 3 files changed, 36

Re: [libvirt] [PATCH v2 20/73] qemu: Rename qemuMigrationParamsAddTLSObjects

On Wed, Apr 11, 2018 at 04:41:10PM +0200, Jiri Denemark wrote: The new name is qemuMigrationParamsEnableTLS. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 12 ++-- src/qemu/qemu_migration_params.c | 18 +-

[libvirt] crash in libxlDoMigrateDstReceive in error case

Jim, while fixing and debugging virNetSocketNewListenTCP in master, I had breakpoints in virNetSocketNewListenTCP and virNetSocketNew. After starting a migration the receiving libvirtd went into both functions. I hit continue a 4 times, but forgot to do it for the fifth call to let it proceed.

Re: [libvirt] [RFC v2] external (pull) backup API

On Tue, Apr 03, 2018 at 03:01:22PM +0300, Nikolay Shirokovskiy wrote: > *Temporary snapshot API* > > In previous version it is called 'Fleece API' after qemu terms and I'll still > use BlockSnapshot prefix for commands as in previous RFC instead of > TmpSnapshots which I inclined more now. > >

Re: [libvirt] [dbus PATCH v2 11/22] Implement MigrateGetMaxDowntime method for Domain Interface

On Thu, Apr 12, 2018 at 04:32:50PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 31 +++ > 2 files changed, 37 insertions(+) [...] > +static void

Re: [libvirt] [PATCH v2 14/73] qemu: Typedef struct qemuDomainJobObj

On Wed, Apr 11, 2018 at 04:41:04PM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 6 +++--- src/qemu/qemu_domain.h | 8 +--- src/qemu/qemu_process.c | 4 ++-- 3 files changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Ján

Re: [libvirt] [dbus PATCH v2 16/22] Implement GetMemoryParameters method for Domain Interface

On Thu, Apr 12, 2018 at 04:32:55PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 37 + > 2 files changed, 43 insertions(+) > > diff --git

Re: [libvirt] [PATCH v2 16/73] qemu: Reset all migration parameters

On Wed, Apr 11, 2018 at 04:41:06PM +0200, Jiri Denemark wrote: Restore the original values of all migration parameters we store in qemuDomainJobObj instead of explicitly resting only a limited set of them. The result is not strictly equivalent to the previous code wrt reseting TLS state because

Re: [libvirt] [PATCH v2 17/73] qemu: Drop qemuMigrationParamsCheckSetupTLS

On Wed, Apr 11, 2018 at 04:41:07PM +0200, Jiri Denemark wrote: The code can be merged directly in qemuMigrationParamsAddTLSObjects. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 15 --- src/qemu/qemu_migration_params.c | 73

Re: [libvirt] [RFC v2] external (pull) backup API

On 13.04.2018 14:41, Vladimir Sementsov-Ogievskiy wrote: > 13.04.2018 11:51, Nikolay Shirokovskiy wrote: >> >> On 13.04.2018 03:04, John Snow wrote: >>> >>> On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote: I propose, not to say that bitmap represents a checkpoint. It is simpler

Re: [libvirt] [PATCH v2 47/73] qemu: Drop qemuMigrationCompression structure

On Wed, Apr 11, 2018 at 04:41:37PM +0200, Jiri Denemark wrote: By merging qemuMigrationAnyCompressionParse into qemuMigrationParamsSetCompression we can drop the useless intermediate qemuMigrationCompression structure and parse compression related typed parameters and flags directly into

Re: [libvirt] [RFC v2] external (pull) backup API

13.04.2018 18:05, Nikolay Shirokovskiy wrote: On 13.04.2018 14:41, Vladimir Sementsov-Ogievskiy wrote: 13.04.2018 11:51, Nikolay Shirokovskiy wrote: On 13.04.2018 03:04, John Snow wrote: On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote: I propose, not to say that bitmap represents

Re: [libvirt] [PATCH v2 50/73] qemumonitorjsontest: Drop migration params test

On Wed, Apr 11, 2018 at 04:41:40PM +0200, Jiri Denemark wrote: The test is mostly useless and we want to refactor migration parameters even further. The refactoring will allow us to introduce enhanced tests for migration parameters. Signed-off-by: Jiri Denemark ---

Re: [libvirt] [PATCH v2 51/73] util: Introduce virJSONValueObjectStealObject

On Wed, Apr 11, 2018 at 04:41:41PM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/libvirt_private.syms | 1 + src/util/virjson.c | 8 src/util/virjson.h | 2 ++ 3 files changed, 11 insertions(+) Reviewed-by: Ján Tomko

Re: [libvirt] [PATCH v2 52/73] qemu: Move migration parameters JSON parsing

On Wed, Apr 11, 2018 at 04:41:42PM +0200, Jiri Denemark wrote: We want to have all migration parameters parsing and formatting at once place, i.e., in qemu_migration_params.c. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 74

Re: [libvirt] [PATCH v2 54/73] qemu: Export qemuMigrationParams{To, From}JSON for tests

On Wed, Apr 11, 2018 at 04:41:44PM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/qemu/Makefile.inc.am | 1 + src/qemu/qemu_migration_params.c | 5 +++-- src/qemu/qemu_migration_paramspriv.h | 31 3 files

Re: [libvirt] [PATCH v2 55/73] qemu: Move qemuMonitorMigrationParams structure

On Wed, Apr 11, 2018 at 04:41:45PM +0200, Jiri Denemark wrote: It's no longer used by the monitor code so we can hide it inside qemu_migration_params.c. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 36

Re: [libvirt] [PATCH v2 57/73] qemu: Move migration capabilities JSON formatting

On Wed, Apr 11, 2018 at 04:41:47PM +0200, Jiri Denemark wrote: We want to have all migration capabilities parsing and formatting at one place, i.e., in qemu_migration_params.c. The parsing is already there in qemuMigrationCapsCheck. Signed-off-by: Jiri Denemark ---

Re: [libvirt] [PATCH v2 58/73] qemu: Move qemuMonitorMigrationCaps enum

On Wed, Apr 11, 2018 at 04:41:48PM +0200, Jiri Denemark wrote: Since the monitor code no longer needs to see this enum, we move it to the place where migration parameters are defined and drop the "monitor" reference from the name. Signed-off-by: Jiri Denemark ---

Re: [libvirt] [dbus PATCH v2 20/22] Implement MigrateSetMaxSpeed method for Domain Interface

On Thu, Apr 12, 2018 at 04:32:59PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 25 + > 2 files changed, 31 insertions(+) [...] > +static void >

Re: [libvirt] [dbus PATCH v2 19/22] Implement MigrateGetMaxSpeed method for Domain Interface

On Thu, Apr 12, 2018 at 04:32:58PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 28 > 2 files changed, 34 insertions(+) [...] > +static void >

Re: [libvirt] [RFC v2] external (pull) backup API

13.04.2018 11:51, Nikolay Shirokovskiy wrote: On 13.04.2018 03:04, John Snow wrote: On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote: I propose, not to say that bitmap represents a checkpoint. It is simpler to say (and it reflects the reality) that bitmap is a difference between

Re: [libvirt] [PATCH v2 29/73] qemu: Add support for xbzrle-cache-size migration parameter

On Wed, Apr 11, 2018 at 04:41:19PM +0200, Jiri Denemark wrote: Originally QEMU provided query-migrate-cache-size and migrate-set-cache-size QMP commands for querying/setting XBZRLE cache size. In version 2.11 QEMU added support for XBZRLE cache size to the general migration paramaters commands.

Re: [libvirt] [RFC v2] external (pull) backup API

13.04.2018 00:35, John Snow wrote: On 04/12/2018 08:26 AM, Vladimir Sementsov-Ogievskiy wrote: 1. It looks unsafe to use nbd server + backup(sync=none) on same node, synchronization is needed, like in block/replication, which uses backup_wait_for_overlapping_requests, backup_cow_request_begin,

Re: [libvirt] [RFC v2] external (pull) backup API

On Fri, Apr 13, 2018 at 03:02:07PM +0300, Nikolay Shirokovskiy wrote: > > > On 13.04.2018 12:07, Daniel P. Berrangé wrote: > > On Tue, Apr 03, 2018 at 03:01:22PM +0300, Nikolay Shirokovskiy wrote: > >> *Temporary snapshot API* > >> > >> In previous version it is called 'Fleece API' after qemu

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: [...] > + mingw32-gtk-vnc: > +FedoraRawhide: mingw32-gtk-vnc This (and the corresponding mingw64 entry) will drag in the version of the library based on GTK+ 2 rather than the one based on GTK+ 3, which is not what we want. It

Re: [libvirt] [PATCH v2 32/73] qemu: Move ParamsCheck closer to ParamsApply on Src side

On Wed, Apr 11, 2018 at 04:41:22PM +0200, Jiri Denemark wrote: We reached the point when qemuMigrationParamsApply is the only API which sends migration parameters and capabilities to QEMU. Thus all but the TLS parameters can be set before we ask QEMU for the current values of all parameters in

[libvirt] [dbus PATCH v3 18/20] Implement MigrateSetMaxSpeed method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 25 + 2 files changed, 31 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index eec9dcb..838ebed 100644

[libvirt] [dbus PATCH v3 11/20] Implement HasManagedSaveImage method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 29 + test/test_domain.py | 2 +- 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/data/org.libvirt.Domain.xml

Re: [libvirt] [dbus PATCH v3 01/20] Implement Setter for Autostart property for Domain interface

On Fri, Apr 13, 2018 at 01:15:12PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 +++-- > src/domain.c| 22 +- > test/test_domain.py | 7 +++ > 3 files changed, 31

Re: [libvirt] [PATCH v2 24/73] qemu: Hide internals of qemuMigrationParams struct

On Wed, Apr 11, 2018 at 04:41:14PM +0200, Jiri Denemark wrote: All users of migration parameters are supposed to use APIs provided by qemu_migration_params.c without having to worry about the internals. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 5

Re: [libvirt] [PATCH v5 05/10] qemu: add support to launch SEV guest

On Mon, Apr 02, 2018 at 07:04:25PM -0400, John Ferlan wrote: > > > On 04/02/2018 10:18 AM, Brijesh Singh wrote: > > QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted > > VMs on AMD platform using SEV feature. The various inputs required to > > launch SEV guest is provided

Re: [libvirt] [dbus PATCH v3 03/20] Implement MemoryStats for Domain Interface

On Fri, Apr 13, 2018 at 01:15:14PM +0200, Katerina Koukiou wrote: > This method is not tested for now since the test driver > doesn't support this API. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 > src/domain.c| 72 >

Re: [libvirt] [PATCH jenkins-ci 0/2] Enable virt-viewer mingw build

On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > Daniel P. Berrangé (2): > Enable mingw build for libvirt-glib project > Enable mingw build for virt-viewer project > > guests/vars/mappings.yml | 72 > +++ >

Re: [libvirt] [PATCH v2 30/73] qemu: Set XBZRLE cache size via migration parameters

On Wed, Apr 11, 2018 at 04:41:20PM +0200, Jiri Denemark wrote: Prefer xbzrle-cache-size migration parameter over the special migrate-set-cache-size QMP command. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c| 6 ++--- src/qemu/qemu_migration_params.c |

Re: [libvirt] [PATCH v2 28/73] qemu: Drop unused qemuMonitorSetMigrationCapability

On Wed, Apr 11, 2018 at 04:41:18PM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor.c | 14 -- src/qemu/qemu_monitor.h | 3 -- src/qemu/qemu_monitor_json.c | 53

Re: [libvirt] [PATCH jenkins-ci 1/2] Enable mingw build for libvirt-glib project

On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > diff --git a/guests/vars/projects/libvirt-glib.yml > b/guests/vars/projects/libvirt-glib.yml > index 13a5128..bb21ae0 100644 > --- a/guests/vars/projects/libvirt-glib.yml > +++ b/guests/vars/projects/libvirt-glib.yml > @@ -5,4 +5,6 @@

Re: [libvirt] [PATCH jenkins-ci 1/2] Enable mingw build for libvirt-glib project

On Fri, 2018-04-13 at 13:20 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 13, 2018 at 02:17:45PM +0200, Andrea Bolognani wrote: > > On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > > >- gtk-doc > > >- intltool > > >- libxml2 > > > + - mingw32-glib2 > > > + -

Re: [libvirt] [PATCH] Add function that raises error if domain is not active

2018-04-13 8:25 GMT+00:00 Erik Skultety : > On Fri, Apr 13, 2018 at 09:45:48AM +0200, Michal Privoznik wrote: >> On 04/13/2018 09:31 AM, Ján Tomko wrote: >> > On Thu, Apr 12, 2018 at 07:49:15PM +, Clementine Hayat wrote: >> >> Add a function named virDomainObjCheckIsActive

[libvirt] [dbus PATCH v3 10/20] Implement ManagedSave method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 5 + src/domain.c| 24 test/test_domain.py | 15 +++ 3 files changed, 44 insertions(+) diff --git a/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v3 06/20] Implement GetJobInfo method for Domain interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 5 + src/domain.c| 49 + 2 files changed, 54 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

[libvirt] [dbus PATCH v3 01/20] Implement Setter for Autostart property for Domain interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 5 +++-- src/domain.c| 22 +- test/test_domain.py | 7 +++ 3 files changed, 31 insertions(+), 3 deletions(-) diff --git a/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v3 12/20] Implement ManagedSaveRemove method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 5 + src/domain.c| 24 test/test_domain.py | 2 ++ 3 files changed, 31 insertions(+) diff --git a/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v3 03/20] Implement MemoryStats for Domain Interface

This method is not tested for now since the test driver doesn't support this API. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 src/domain.c| 72 + 2 files changed, 78 insertions(+)

[libvirt] [dbus PATCH v3 09/20] Implement MigrateGetMaxDowntime method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 31 +++ 2 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index c3c64fa..10c4da8

[libvirt] [dbus PATCH v3 00/20] More APIs for Domain Interface

Changes from v2: Adjusted to reviews. Katerina Koukiou (20): Implement Setter for Autostart property for Domain interface Implement SchedulerType property for Domain Interface Implement MemoryStats for Domain Interface Implement AttachDevice method for Domain Interface Implement

[libvirt] [dbus PATCH v3 02/20] Implement SchedulerType property for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 4 src/domain.c| 23 +++ test/test_domain.py | 3 +++ 3 files changed, 30 insertions(+) diff --git a/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v3 04/20] Implement AttachDevice method for Domain Interface

This method is not tested for now since the test driver doesn't suport this API. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 25 + 2 files changed, 31 insertions(+) diff --git

[libvirt] [dbus PATCH v3 07/20] Implement AbortJob for Domain interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 4 src/domain.c| 21 + 2 files changed, 25 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index c672053..074dd62 100644 ---

[libvirt] [dbus PATCH v3 14/20] Implement GetMemoryParameters method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 36 2 files changed, 42 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

Re: [libvirt] [PATCH v2 23/73] qemu: Rename qemuMigrationParamsSet

On Wed, Apr 11, 2018 at 04:41:13PM +0200, Jiri Denemark wrote: The new name is qemuMigrationParamsApply and it will soon become the only API which will send all requested migration parameters and capabilities to QEMU. All other qemuMigrationParams* APIs will just operate on the

Re: [libvirt] [PATCH v2 27/73] qemu: Do not use qemuMonitorSetMigrationCapability

On Wed, Apr 11, 2018 at 04:41:17PM +0200, Jiri Denemark wrote: Rework all remaining callers of qemuMonitorSetMigrationCapability to use the new qemuMonitorSetMigrationCapabilities API. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 11 ---

[libvirt] [jenkins-ci PATCH] guests: Add icoutils dependency to virt-viewer project

The icotool command is used to manipulate Windows icon files. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 4 guests/vars/projects/virt-viewer.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml

Re: [libvirt] [dbus PATCH v3 06/20] Implement GetJobInfo method for Domain interface

On Fri, Apr 13, 2018 at 01:15:17PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/domain.c| 49 > + > 2 files changed, 54 insertions(+) > >

Re: [libvirt] [PATCH v2 31/73] qemu: Move ParamsCheck closer to ParamsApply on Dst side

On Wed, Apr 11, 2018 at 04:41:21PM +0200, Jiri Denemark wrote: We reached the point when qemuMigrationParamsApply is the only API which sends migration parameters and capabilities to QEMU. Thus all but the TLS parameters can be set before we ask QEMU for the current values of all parameters in

Re: [libvirt] [PATCH jenkins-ci 1/2] Enable mingw build for libvirt-glib project

On Fri, 2018-04-13 at 13:20 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 13, 2018 at 02:17:45PM +0200, Andrea Bolognani wrote: > > On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > > > diff --git a/guests/vars/projects/libvirt-glib.yml > > > b/guests/vars/projects/libvirt-glib.yml

Re: [libvirt] [PATCH] Add function that raises error if domain is not active

On 04/13/2018 02:49 PM, Clementine Hayat wrote: > > I'll take a look into coccinelle. It may take a bit more time thought. > Yeah, don't waste too much time on it. I merely just wanted to mention it. It not that trivial to learn. But once you do, it's awesome tool. Michal -- libvir-list

Re: [libvirt] [PATCH v2 34/73] qemu: Introduce qemuMigrationParty enum

On Wed, Apr 11, 2018 at 04:41:24PM +0200, Jiri Denemark wrote: Some migration parameters and capabilities are supposed to be set on both sides of migration while others should only be set on one side. For example, CPU throttling parameters make no sense on the destination and they can be used

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Fri, 2018-04-13 at 13:44 +0100, Daniel P. Berrangé wrote: > > Because of the missing dependencies mentioned below, you also need > > > > mingw32-hicolor-icon-theme: > > FedoraRawhide: mingw32-hicolor-icon-theme > > There's no such package AFAIK There sure is: $ dnf info

Re: [libvirt] [PATCH v2 43/73] qemu: Move qemuMigrationParamsSetCompression

On Wed, Apr 11, 2018 at 04:41:33PM +0200, Jiri Denemark wrote: The API will soon be called from qemuMigrationParamsFromFlags. Let's move it to avoid the need to add a forward declaration. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_params.c | 59

Re: [libvirt] [PATCH v2 42/73] qemu: Drop qemuMigrationParamsSetCapability

On Wed, Apr 11, 2018 at 04:41:32PM +0200, Jiri Denemark wrote: It's become only a tiny wrapper around virBitmapSetBit, which can easily be called directly. We don't need to call virBitmapClearBit since migParams->caps bitmap is initialized with zeros. Signed-off-by: Jiri Denemark

[libvirt] [PATCH 8/9] virobject: Check if @parent is the first member in class

Our virObject code relies heavily on the fact that the first member of the class struct is type of virObject (or some derivation of if). Let's check for that. Signed-off-by: Michal Privoznik --- src/util/virobject.c | 31 +-- src/util/virobject.h

[libvirt] [PATCH 7/9] virobject: Introduce VIR_CLASS_NEW() macro

So far we are repeating the following lines over and over: virClassNew(virClassForObject(), "virSomeObject", sizeof(virSomeObject), virSomeObjectDispose); While this works, it is impossible to do some checking. Firstly, the class name (the 2nd

[libvirt] [PATCH 0/9] virClassNew rework

This is inspired by commit of f574e2e5214fb9. Also, the more the code is unified the easier it is to maintain. Michal Privoznik (9): domain_event: s/MetadataCange/MetadataChange/g util: Make structs follow our naming convention datatypes: Rename @parent to @parentName in virNodeDevice

[libvirt] [PATCH 3/9] datatypes: Rename @parent to @parentName in virNodeDevice

In next patches this name will be needed for a different memeber. Also, it makes sense to rename the variable because it does not contain reference to parent device, just its name. Signed-off-by: Michal Privoznik --- src/conf/virnodedeviceobj.c | 2 +-

[libvirt] [PATCH 2/9] util: Make structs follow our naming convention

There are two structs virMacMap and virFDStreamData that don't have the underscore prefix. Put it there so that they follow the rest of the code. Signed-off-by: Michal Privoznik --- src/util/virfdstream.c | 4 ++-- src/util/virmacmap.c | 2 +- src/util/virmacmap.h | 2

[libvirt] [PATCH 9/9] cfg.mk: Introduce syntax-check rule to prefer VIR_CLASS_NEW

Now that we have macro that does some checks lets forbid raw usage of virClassNew() in favor of VIR_CLASS_NEW(). Signed-off-by: Michal Privoznik --- cfg.mk | 8 1 file changed, 8 insertions(+) diff --git a/cfg.mk b/cfg.mk index 4078bc2c63..5b7a9728d2 100644 ---

[libvirt] [PATCH 1/9] domain_event: s/MetadataCange/MetadataChange/g

There's a typo in struct name. Signed-off-by: Michal Privoznik --- src/conf/domain_event.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 7baccd5b57..fdb48a1eaa 100644 ---

  1   2   >