Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 1:15 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé > wrote: > >> On Wed, May 09, 2018 at 10:38:59AM +0200, Peter Krempa wrote: >> > On Wed, May 09, 2018 at 08:51:01 +0100, Daniel Berrange

Re: [libvirt] Question about using cpu mode "host-model" while providing a cpu model name

On Tue, May 08, 2018 at 10:44:22 -0400, Collin Walling wrote: > Hi > > I have noticed something that may be misconstrued regarding the libvirt > domain xml format > for defining a cpu model. There seems to be a misalignment where the libvirt > documentation > states something that is not

Re: [libvirt] [PATCH 0/3] spec: drop deprecated el5 bits

On Tue, 2018-05-08 at 09:53 -0400, Cole Robinson wrote: > 2 patches from a Fedora contributor, 1 from me, dropping spec bits > that aren't required on el6 and later builds Note that we no longer support building on CentOS 6 either, so maybe there are more cleanup opportunities there... --

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 10:38:59AM +0200, Peter Krempa wrote: > > On Wed, May 09, 2018 at 08:51:01 +0100, Daniel Berrange wrote: > > > On Wed, May 09, 2018 at 09:14:29AM +0300, David Kiarie wrote: > > > > > > > >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 1:18 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 1:15 PM, David Kiarie > wrote: > >> >> >> On Wed, May 9, 2018 at 12:02 PM, Daniel P. Berrangé >> wrote: >> >>> On Wed, May 09, 2018 at

Re: [libvirt] Question about verifying same uid:gid in src and dst for live migration

On Wed, May 09, 2018 at 01:45:53PM +0800, Fei Li wrote: > Hi, > > When I do live migration using virsh command line based on NFS shared > storage between two systems > having the same security mechanism and having the same kvm/qemu/libvirt > version, I encounter the > following error: > > debug

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 09, 2018 at 10:38:59AM +0200, Peter Krempa wrote: > On Wed, May 09, 2018 at 08:51:01 +0100, Daniel Berrange wrote: > > On Wed, May 09, 2018 at 09:14:29AM +0300, David Kiarie wrote: > > > > > > This is okay but this definitely wrong. And it does indeed sound wrong. > > > And > > > it

[libvirt] [PATCH v2] rpc: fixing compilation error due to deprecated ssh_get_publickey().

After 0.7.5 release, libssh deprecated ssh_get_publickey() method to introduce ssh_get_server_publickey(). This commit check the current version of libssh and use the proper method during the compilation. See the error: make[3]: Entering directory '/home/julio/Desktop/virt/libvirt/src' CC

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 09, 2018 at 01:36:35PM +0300, David Kiarie wrote: > On Wed, May 9, 2018 at 1:18 PM, David Kiarie wrote: > > > > > > > On Wed, May 9, 2018 at 1:15 PM, David Kiarie > > wrote: > > > >> > >> > >> On Wed, May 9, 2018 at 12:02 PM, Daniel P.

Re: [libvirt] [PATCH] Add a MAINTAINERS file to suggest reviewers for patches

On Wed, May 09, 2018 at 10:46:19AM +0200, Jiri Denemark wrote: > On Tue, May 08, 2018 at 14:07:31 +0100, Daniel P. Berrangé wrote: > > Currently all patches are simply sent to the main libvirt development > > mailing list. Sometimes individual developers are also CC'd but this is > > typically the

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 09, 2018 at 09:14:29AM +0300, David Kiarie wrote: > > This is okay but this definitely wrong. And it does indeed sound wrong. And > it will always sound wrong. > > Being involved in a GSoC project is not about contributions. And also > considering the scale of our project(some of the

Re: [libvirt] Question about verifying same uid:gid in src and dst for live migration

On Wed, May 9, 2018 at 7:45 AM, Fei Li wrote: > Hi, > When I do live migration using virsh command line based on NFS shared > storage between two systems > having the same security mechanism and having the same kvm/qemu/libvirt > version, I encounter the > following error: > >

Re: [libvirt] [PATCH] Add a MAINTAINERS file to suggest reviewers for patches

On Tue, May 08, 2018 at 14:07:31 +0100, Daniel P. Berrangé wrote: > Currently all patches are simply sent to the main libvirt development > mailing list. Sometimes individual developers are also CC'd but this is > typically the exception. > > Libvirt does not follow a subsystem maintainer model,

Re: [libvirt] [PATCH] Add a MAINTAINERS file to suggest reviewers for patches

On Tue, May 08, 2018 at 02:07:31PM +0100, Daniel P. Berrangé wrote: Currently all patches are simply sent to the main libvirt development mailing list. Sometimes individual developers are also CC'd but this is typically the exception. Libvirt does not follow a subsystem maintainer model, so

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 1:43 PM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 01:36:35PM +0300, David Kiarie wrote: > > On Wed, May 9, 2018 at 1:18 PM, David Kiarie > wrote: > > > > > > > > > > > On Wed, May 9, 2018 at 1:15 PM, David Kiarie

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 09, 2018 at 08:51:01 +0100, Daniel Berrange wrote: > On Wed, May 09, 2018 at 09:14:29AM +0300, David Kiarie wrote: > > > > This is okay but this definitely wrong. And it does indeed sound wrong. And > > it will always sound wrong. > > > > Being involved in a GSoC project is not about

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Tue, May 8, 2018 at 6:09 PM, Jim Fehlig wrote: > On 05/08/2018 03:22 AM, David Kiarie wrote: > >> >> >> On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig jfeh...@suse.com>> wrote: >> >> On 05/07/2018 08:57 AM, David Kiarie wrote: >> >> >> >> On Mon,

Re: [libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

On Tue, 2018-05-08 at 16:15 +0100, Daniel P. Berrangé wrote: > On Thu, May 03, 2018 at 06:25:19PM +0200, Andrea Bolognani wrote: > > Up until now, we had to skip it on FreeBSD due to some > > portability issues in the test suite, but as of libvirt > > commit 0b86e23d2569 they've all been fixed. >

[libvirt] [dbus PATCH 00/13] Secret APIs

Katerina Koukiou (13): Introduce Secret Interface Implement ListSecrets method for Connect Interface Register Secret Lifecycle Events Implement UUID property for Secret Interface Implement UsageID property for Secret Interface Implement UsageType property for Secret Interface

[libvirt] [dbus PATCH 01/13] Introduce Secret Interface

Signed-off-by: Katerina Koukiou --- data/Makefile.am| 1 + data/org.libvirt.Secret.xml | 7 + src/Makefile.am | 1 + src/connect.c | 6 + src/connect.h | 1 + src/secret.c| 64

Re: [libvirt] [Qemu-devel] [qemu PATCH] docs/interop: add "firmware.json"

On 05/09/18 17:04, Laszlo Ersek wrote: > Add a schema that describes the different uses and properties of virtual > machine firmware. > > Each firmware executable installed on a host system should come with at > least one JSON file that conforms to this schema. Each file informs the > management

[libvirt] [PATCH 12/12] docs: Add news entry for new API virDomainCreateWithParams

Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 80181415c635..06693985839a 100644 --- a/docs/news.xml +++

[libvirt] [PATCH 11/12] virsh: Add with-{bootdevice, kernel, initrd, cmdline} options for start

Add the options with-bootdevice, with-kernel, with-initrd, and with-cmdline to 'virsh start'. They allow to temporarily boot from another boot device, to use another kernel, initrd, and cmdline than defined in the persistent domain definition. Signed-off-by: Marc Hartmayer

[libvirt] [PATCH 07/12] qemu: Add support for virDomainCreateWithParams

Add support for the API virDomainCreateWithParams to the QEMU driver. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_driver.c | 49 + 1 file changed, 45

[libvirt] [PATCH 09/12] test: Add support for virDomainCreateWithParams

Add support for virDomainCreateWithParams to the test driver. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- src/test/test_driver.c | 74 ++ 1 file changed, 62 insertions(+), 12

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 3:24 PM, Michal Privoznik wrote: > On 05/09/2018 01:51 PM, David Kiarie wrote: > > On Wed, May 9, 2018 at 2:29 PM, David Kiarie > wrote: > > > >> > >> > >> On Wed, May 9, 2018 at 1:56 PM, John Ferlan wrote:

[libvirt] [dbus PATCH 12/13] Implement SetValue method for Secret Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Secret.xml | 6 ++ src/secret.c| 34 ++ 2 files changed, 40 insertions(+) diff --git a/data/org.libvirt.Secret.xml b/data/org.libvirt.Secret.xml index 563167b..3a5d742

[libvirt] [dbus PATCH 02/13] Implement ListSecrets method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 37 + 2 files changed, 43 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [dbus PATCH 03/13] Register Secret Lifecycle Events

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 13 + src/connect.h| 1 + src/events.c | 42 ++ 4 files changed, 63

[libvirt] [dbus PATCH 09/13] Implement SecretLookupByUsage method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 30 ++ 2 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index cb70af9..fc29165

[libvirt] [dbus PATCH 07/13] Implement GetXMLDesc method for Secret Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Secret.xml | 6 ++ src/secret.c| 28 2 files changed, 34 insertions(+) diff --git a/data/org.libvirt.Secret.xml b/data/org.libvirt.Secret.xml index 4270182..d35af38 100644

[libvirt] [dbus PATCH 05/13] Implement UsageID property for Secret Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Secret.xml | 5 + src/secret.c| 22 ++ 2 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Secret.xml b/data/org.libvirt.Secret.xml index 8ee6f0c..5cce9d3 100644 ---

[libvirt] [dbus PATCH 10/13] Implement Undefine method for Secret Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Secret.xml | 4 src/secret.c| 21 + 2 files changed, 25 insertions(+) diff --git a/data/org.libvirt.Secret.xml b/data/org.libvirt.Secret.xml index d35af38..509c46a 100644 ---

[libvirt] [dbus PATCH 06/13] Implement UsageType property for Secret Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Secret.xml | 5 + src/secret.c| 22 ++ 2 files changed, 27 insertions(+) diff --git a/data/org.libvirt.Secret.xml b/data/org.libvirt.Secret.xml index 5cce9d3..4270182 100644 ---

[libvirt] [dbus PATCH 04/13] Implement UUID property for Secret Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Secret.xml | 5 + src/secret.c| 42 ++ 2 files changed, 47 insertions(+) diff --git a/data/org.libvirt.Secret.xml b/data/org.libvirt.Secret.xml index

[libvirt] [qemu PATCH] docs/interop: add "firmware.json"

Add a schema that describes the different uses and properties of virtual machine firmware. Each firmware executable installed on a host system should come with at least one JSON file that conforms to this schema. Each file informs the management applications about - the firmware's properties and

[libvirt] [PATCH python] Implement virDomainCreateWithParams API

This patch adds the Python binding for virDomainCreateWithParams API. The Python side can be generated automatically, the C side not. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- generator.py | 1 +

Re: [libvirt] Question about using cpu mode "host-model" while providing a cpu model name

On 05/09/2018 01:35 PM, Kashyap Chamarthy wrote: On Tue, May 08, 2018 at 10:44:22AM -0400, Collin Walling wrote: Hi I have noticed something that may be misconstrued regarding the libvirt domain xml format for defining a cpu model. There seems to be a misalignment where the libvirt

Re: [libvirt] [PATCH v3 14/14] qemu: Add swtpm to emulator cgroup

On 05/04/2018 04:21 PM, Stefan Berger wrote: > Add the external swtpm to the emulator cgroup so that upper limits of CPU > usage can be enforced on the emulated TPM. > > To enable this we need to have the swtpm write its process id (pid) into a > file. We then read it from the file to configure

[libvirt] [qemu PATCH v2] docs/interop: add "firmware.json"

Add a schema that describes the different uses and properties of virtual machine firmware. Each firmware executable installed on a host system should come with at least one JSON file that conforms to this schema. Each file informs the management applications about - the firmware's properties and

[libvirt] [PATCH 04/12] utils: Add virStringUpdate

If @src is an empty string then @dst will be freed otherwise @dst will be a duplicate of @src. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann --- src/libvirt_private.syms | 1 +

[libvirt] [PATCH 06/12] qemu: Add the functionality to override the boot configuration

Add the functionality to override the boot configuration of a domain at the start time to the QEMU driver. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann ---

[libvirt] [PATCH 10/12] tests: Add tests for virDomainCreateWithParams

Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- src/test/test_driver.c | 6 + tests/objecteventtest.c | 321 2 files changed, 327 insertions(+) diff --git

[libvirt] [PATCH 05/12] conf: Add functions to change the boot configuration of a domain

Add functions for changing the boot configuration of a domain in preparation for upcoming patches. It's possible to change the used kernel, initrd, cmdline, and the used boot device. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski

[libvirt] [PATCH 03/12] remote: Add support for virDomainCreateWithParams

Add support for virDomainCreateWithParams to the remote driver. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann --- src/remote/remote_driver.c | 1 +

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

On Wed, May 09, 2018 at 04:56:12PM +0200, Marc Hartmayer wrote: > Introduce new libvirt API virDomainCreateWithParams that allows to > temporarily boot from another boot device, to use another kernel, > initrd, and cmdline than defined in the persistent domain > definition. All typed parameters

Re: [libvirt] [PATCH v2] rpc: fixing compilation error due to deprecated ssh_get_publickey().

On Wed, 2018-05-09 at 07:42 -0300, Julio Faracco wrote: [...] > +#if LIBSSH_VERSION_INT <= 0x0705 /* 0.7.5 */ > +# define ssh_get_server_publickey ssh_get_publickey > +#endif > + > +if (ssh_get_server_publickey(sess->session, ) != SSH_OK) { > virReportError(VIR_ERR_LIBSSH, "%s", >

[libvirt] [dbus PATCH 13/13] Implement SecretDefineXML method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 30 ++ 2 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index fc29165..8691762

[libvirt] [dbus PATCH 11/13] Implement GetValue method for Secret Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Secret.xml | 6 ++ src/secret.c| 37 + 2 files changed, 43 insertions(+) diff --git a/data/org.libvirt.Secret.xml b/data/org.libvirt.Secret.xml index

[libvirt] [dbus PATCH 08/13] Implement SecretLookupByUUID method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + 2 files changed, 35 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 3aae9fe..cb70af9

[libvirt] [PATCH 08/12] test: Implement virConnectSupportsFeature

Implement virConnectSupportsFeature for the test driver as this API is used by various API functions (the functions usually use the macro VIR_DRV_SUPPORTS_FEATURE for calling virConnectSupportsFeature). The support for the feature VIR_DRV_FEATURE_TYPED_PARAM_STRING is needed for the upcoming test

[libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

Introduce new libvirt API virDomainCreateWithParams that allows to temporarily boot from another boot device, to use another kernel, initrd, and cmdline than defined in the persistent domain definition. All typed parameters are optional. The design of the API was chosen to ease future extensions.

[libvirt] [PATCH 01/12] virsh: Force boot emulation is only required for virDomainCreateWithFlags

The force boot emulation is only required for virDomainCreateWithFlags as the flag VIR_DOMAIN_START_FORCE_BOOT was introduced with the commit 27c85260532f879be5674a4eed0811c21fd34f94 (2011). But virDomainCreateXMLWithFiles is newer and therefore already had support for VIR_DOMAIN_START_FORCE_BOOT.

[libvirt] [PATCH 00/12] Temporarily use other boot configuration

This patch series implements a new API that allows us to temporarily use another boot configuration than defined in the persistent domain definition. The s390 architecture knows only one boot device and therefore the boot order settings doesn't work the way it would work on x86, for example. If

Re: [libvirt] Question about using cpu mode "host-model" while providing a cpu model name

On 05/09/2018 12:41 PM, Jiri Denemark wrote: On Tue, May 08, 2018 at 10:44:22 -0400, Collin Walling wrote: Hi I have noticed something that may be misconstrued regarding the libvirt domain xml format for defining a cpu model. There seems to be a misalignment where the libvirt documentation

Re: [libvirt] [jenkins-ci PATCH] Build libosinfo and osinfo-db-tools on mingw platform

On Wed, May 09, 2018 at 01:34:53PM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-08 at 14:37 +0100, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > guests/host_vars/libvirt-fedora-rawhide/main.yml | 2 ++ > > guests/vars/mappings.yml

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 09, 2018 at 02:29:35PM +0300, David Kiarie wrote: > We don't have a new company here. We have an almost four year old cat. IANAL, but I think there's a precedent [1] for this, where at least a US court ruled that "Specifically, the Copyright Office will not register works produced by

Re: [libvirt] [PATCH] Add a MAINTAINERS file to suggest reviewers for patches

On 05/09/2018 04:57 AM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 10:46:19AM +0200, Jiri Denemark wrote: >> On Tue, May 08, 2018 at 14:07:31 +0100, Daniel P. Berrangé wrote: >>> Currently all patches are simply sent to the main libvirt development >>> mailing list. Sometimes individual

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

[...] > > >> Suse copyright notice has been on this file since the day this > file got > > >> merged. To be honest, I did most of the original work so why > should Suse > > >> copyright appear here while me doesn't ? > > >> > > > > > > Contrary to the fact that

Re: [libvirt] Question about using cpu mode "host-model" while providing a cpu model name

On Tue, May 08, 2018 at 10:44:22AM -0400, Collin Walling wrote: > Hi > > I have noticed something that may be misconstrued regarding the libvirt > domain xml format > for defining a cpu model. There seems to be a misalignment where the libvirt > documentation > states something that is not

Re: [libvirt] [PATCH 1/3] util: cleanup: using virGetLastErrorMessage instead of err->message

On Sat, May 05, 2018 at 01:04:19PM +0100, ramyelkest wrote: > Signed-off-by: Ramy Elkest > --- > src/util/virfilecache.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c > index dab7216..96ae96d

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 2:08 PM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 02:05:54PM +0300, David Kiarie wrote: > > On Wed, May 9, 2018 at 2:01 PM, Daniel P. Berrangé > > wrote: > > > > > On Wed, May 09, 2018 at 01:47:26PM +0300, David Kiarie

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 2:14 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 2:10 PM, David Kiarie > wrote: > >> >> >> On Wed, May 9, 2018 at 2:08 PM, Daniel P. Berrangé >> wrote: >> >>> On Wed, May 09, 2018 at 02:05:54PM

Re: [libvirt] [PATCH 3/3] all: replacing virGetLastError with virGetLastErrorCode where we can

On Sat, May 05, 2018 at 01:04:21PM +0100, ramyelkest wrote: > Replaced instances where we called virGetLastError just to > either get the code or to check if an error exists with > virGetLastErrorCode to avoid a validity pre-check. > > Signed-off-by: Ramy Elkest > --- >

Re: [libvirt] [PATCH v2 0/3] adding virGetLastErrorCode/Domain to paritally replace virGetLastError

On Sat, May 05, 2018 at 01:04:18PM +0100, ramyelkest wrote: > Changes from v1[1]: > > * removed virHasLastError() and s/virHasLastError/virGetLastErrorCode/g > * replaced in missed files: virmodule.c and virnetlibsshsession.c > * better split of patches > > [1]

Re: [libvirt] [jenkins-ci PATCH] Build libosinfo and osinfo-db-tools on mingw platform

On Wed, 2018-05-09 at 12:39 +0100, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 01:34:53PM +0200, Andrea Bolognani wrote: > > 3) change libosinfo's autogen.sh not to mandate gtk-doc for all > > builds. > > > > Option 3) looks like the best one to me, mostly because I think > > the

[libvirt] [jenkins-ci PATCH] guests: Fix os_version for development branches

We currently know about three development branches: Fedora Rawhide, Debian sid and FreeBSD -CURRENT. For all three, we use the name of the development branch in the guest name; however, the value of os_version is not set consistently, making it awkward to create package mappings specific to these

Re: [libvirt] [PATCH] qemu: domain: Replace qemuDomainFilePathIsHostCDROM with virFileIsCDROM

On Mon, May 07, 2018 at 13:13:42 -0400, Laine Stump wrote: > On 05/07/2018 11:21 AM, Peter Krempa wrote: > > Use the new helper when checking that the VM needs to be tainted as a > > host-cdrom passthrough. > > > > Signed-off-by: Peter Krempa > > --- > >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 2:01 PM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 01:47:26PM +0300, David Kiarie wrote: > > On Wed, May 9, 2018 at 1:43 PM, Daniel P. Berrangé > > wrote: > > > > > On Wed, May 09, 2018 at 01:36:35PM +0300, David Kiarie

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 2:10 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 2:08 PM, Daniel P. Berrangé > wrote: > >> On Wed, May 09, 2018 at 02:05:54PM +0300, David Kiarie wrote: >> > On Wed, May 9, 2018 at 2:01 PM, Daniel P. Berrangé

Re: [libvirt] [jenkins-ci PATCH] Build libosinfo and osinfo-db-tools on mingw platform

On Tue, 2018-05-08 at 14:37 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > guests/host_vars/libvirt-fedora-rawhide/main.yml | 2 ++ > guests/vars/mappings.yml | 6 ++ > guests/vars/projects/libosinfo+mingw.yml

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 5:09 PM, Fabian Freyer < fabian.fre...@physik.tu-berlin.de> wrote: > On Wed, May 09, 2018 at 02:29:35PM +0300, David Kiarie wrote: > > We don't have a new company here. We have an almost four year old cat. > > IANAL, but I think there's a precedent [1] for this, where at

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On 05/09/2018 01:51 PM, David Kiarie wrote: > On Wed, May 9, 2018 at 2:29 PM, David Kiarie wrote: > >> >> >> On Wed, May 9, 2018 at 1:56 PM, John Ferlan wrote: >> >>> [...] >>> >>> > >> Suse copyright notice has been on this file since the

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 09, 2018 at 01:47:26PM +0300, David Kiarie wrote: > On Wed, May 9, 2018 at 1:43 PM, Daniel P. Berrangé > wrote: > > > On Wed, May 09, 2018 at 01:36:35PM +0300, David Kiarie wrote: > > > On Wed, May 9, 2018 at 1:18 PM, David Kiarie > >

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 1:56 PM, John Ferlan wrote: > [...] > > > > > >> Suse copyright notice has been on this file since the day this > > file got > > > >> merged. To be honest, I did most of the original work so why > > should Suse > > > >> copyright

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 9, 2018 at 2:29 PM, David Kiarie wrote: > > > On Wed, May 9, 2018 at 1:56 PM, John Ferlan wrote: > >> [...] >> >> >> > > >> Suse copyright notice has been on this file since the day this >> > file got >> > > >> merged. To be

Re: [libvirt] [dbus PATCH 00/19] StoragePool APIs till libvirt 3.0

On Mon, May 07, 2018 at 04:40:41PM +0200, Katerina Koukiou wrote: > Katerina Koukiou (19): > Introduce StoragePool Interface > Implement ListStoragePools method for Connect Interface > Register StoragePool Lifecycle Events > Implement Destroy method for StoragePool Interface > Implement

Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On Wed, May 09, 2018 at 02:05:54PM +0300, David Kiarie wrote: > On Wed, May 9, 2018 at 2:01 PM, Daniel P. Berrangé > wrote: > > > On Wed, May 09, 2018 at 01:47:26PM +0300, David Kiarie wrote: > > > On Wed, May 9, 2018 at 1:43 PM, Daniel P. Berrangé > >

Re: [libvirt] [PATCH 2/3] util: added virGetLastErrorCode/Domain

On Sat, May 05, 2018 at 01:04:20PM +0100, ramyelkest wrote: > Many places in the code call virGetLastError() just to check the > raised error code, or domain. However virGetLastError() can return > NULL, so the code has to check for that first. This patch therefore > introduces

Re: [libvirt] [PATCH v5 00/11] Basic implementation of persistent reservations

On 04/23/2018 09:14 AM, Michal Privoznik wrote: > v5 of: > > https://www.redhat.com/archives/libvir-list/2018-April/msg00736.html > > diff to v4: > - John's review worked in. Partially. > > Michal Privoznik (11): > virstoragefile: Introduce virStoragePRDef > qemuDomainDiskChangeSupported:

Re: [libvirt] [dbus PATCH 05/19] Implement Build method for StoragePool Interface

On Mon, May 07, 2018 at 04:40:46PM +0200, Katerina Koukiou wrote: > VIR_STORAGE_POOL_EVENT_CREATED event was added in 3.1. > Test should be fixed later on to use signal handler. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.StoragePool.xml | 5 + >

Re: [libvirt] [dbus PATCH 10/19] Implement Name property for StoragePool Interface

On Mon, May 07, 2018 at 04:40:51PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.StoragePool.xml | 4 > src/storagepool.c| 23 +++ > tests/test_storage.py| 1 + > 3 files

Re: [libvirt] [dbus PATCH 15/19] Implement StoragePoolLookupByName method for Connect Interface

On Mon, May 07, 2018 at 04:40:56PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 30 ++ > tests/test_connect.py| 15 +++ > 3

Re: [libvirt] [PATCH 0/3] spec: drop deprecated el5 bits

On 05/09/2018 05:01 AM, Andrea Bolognani wrote: > On Tue, 2018-05-08 at 09:53 -0400, Cole Robinson wrote: >> 2 patches from a Fedora contributor, 1 from me, dropping spec bits >> that aren't required on el6 and later builds > > Note that we no longer support building on CentOS 6 either, so >

Re: [libvirt] [RFC 3/3] lxc: Mount NBD devices before clone

On 04/26/2018 08:09 PM, John Ferlan wrote: > > > On 04/15/2018 05:25 PM, Radostin Stoyanov wrote: >> When user-namespace is enabled we are not allowed >> to mount block/NBD devices. >> >> Instead, mount /dev/nbdX to /run/libvirt/lxc/.root >> and set: >> >> fs->src->path =

Re: [libvirt] [PATCH v3 06/14] security: Add DAC and SELinux security for tpm-emulator

On 05/08/2018 04:01 PM, John Ferlan wrote: On 05/04/2018 04:21 PM, Stefan Berger wrote: Extend the DAC and SELinux modules with support for the tpm-emulator. Signed-off-by: Stefan Berger --- src/security/security_dac.c | 4

Re: [libvirt] [PATCH v3 07/14] util: Extend virtpm.c with tpm-emulator support

On 05/08/2018 04:30 PM, John Ferlan wrote: On 05/04/2018 04:21 PM, Stefan Berger wrote: Add functions for managing the storage of the external swtpm as well as starting and stopping it. Also implement functions to use swtpm_setup, which simulates the manufacturing of a TPM which includes

Re: [libvirt] [PATCH v3 08/14] qemu: Extend qemu_conf with tpm-emulator support

On 05/08/2018 04:30 PM, John Ferlan wrote: On 05/04/2018 04:21 PM, Stefan Berger wrote: Extend qemu_conf with user and group for running the tpm-emulator and add directories to the configuration for the locations of the log, state, and socket of the tpm-emulator. Signed-off-by: Stefan Berger

Re: [libvirt] [PATCH libvirt v2 4/9] remote: Use domainClientEventCallbacks for remoteReplayConnectionClosedEvent

[...] > +callback->program = virObjectRef(remoteProgram); > +/* eventID, callbackID, and legacy are not used */ > +callback->eventID = -1; > +callback->callbackID = -1; > if (virConnectRegisterCloseCallback(priv->conn, >

Re: [libvirt] [PATCH 1/2] virTypedParamsSerialize: minor fixes

On 05/07/2018 11:24 AM, Marc Hartmayer wrote: > On Mon, Apr 30, 2018 at 03:20 PM +0200, John Ferlan > wrote: >> On 04/25/2018 11:55 AM, Marc Hartmayer wrote: >>> 1. Don't allocate if there is nothing that needs to be >>>allocated. Especially as the result of calling

Re: [libvirt] [PATCH v3 09/14] qemu: Implement a layer for external devices like tpm-emulator

On 05/08/2018 04:50 PM, John Ferlan wrote: On 05/04/2018 04:21 PM, Stefan Berger wrote: + + cleanup: +VIR_FREE(shortName); +VIR_FREE(errbuf); +virCommandFree(cmd); + +virObjectUnref(cfg); + +return ret; + + error: +VIR_FREE(tpm->data.emulator.source.data.nix.path);

Re: [libvirt] [PATCH v3 10/14] qemu: Add support for external swtpm TPM emulator

On 05/08/2018 05:07 PM, John Ferlan wrote: On 05/04/2018 04:21 PM, Stefan Berger wrote: This patch adds support for an external swtpm TPM emulator. The XML for this type of TPM looks as follows: The XML will currently only start a TPM 1.2. Upon first start, libvirt will run

Re: [libvirt] [PATCH v3 11/14] tests: Add test cases for external swtpm TPM emulator

On 05/08/2018 05:15 PM, John Ferlan wrote: On 05/04/2018 04:21 PM, Stefan Berger wrote: This patch adds extensions to existing test cases and specific test cases for the tpm-emulator. Signed-off-by: Stefan Berger --- tests/qemuxml2argvdata/tpm-emulator.args | 27

Re: [libvirt] [PATCH v3 13/14] tpm: Add support for choosing emulation of a TPM 2

On 05/08/2018 05:38 PM, John Ferlan wrote: On 05/04/2018 04:21 PM, Stefan Berger wrote: This patch extends the TPM's device XML with TPM 2 support. This only works for the emulator type backend and looks as follows: Perhaps this would be better as just version='2' since you're

Re: [libvirt] Question about verifying same uid:gid in src and dstfor live migration

Hi Daniel, On 05/09/2018 03:55 PM, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 01:45:53PM +0800, Fei Li wrote: >> Hi, >> >> When I do live migration using virsh command line based on NFS shared >> storage between two systems >> having the same security mechanism and having the same

Re: [libvirt] [PATCH v3 12/14] security: Label the external swtpm with SELinux labels

On 05/08/2018 05:28 PM, John Ferlan wrote: On 05/04/2018 04:21 PM, Stefan Berger wrote: In this patch we label the swtpm process with SELinux labels. We give it the same label as the QEMU process has. We label its state directory and files as well. The file and process labels now look as