Re: [LSR 2.20] broken: #506

Am So., 15. März 2020 um 11:24 Uhr schrieb Werner LEMBERG : > > > > I've fixed it in LSR by reordering engravers. > > http://lsr.di.unimi.it/LSR/Item?id=506 > > Great! > > > Werner, seems said snippet is based on your idea. Could you have a > > look, if the output is now as wished again? > > I

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On 2020/03/14 20:26:45, lemzwerg wrote: > this looks like a good idea, thanks! > > https://codereview.appspot.com/553700043/diff/547740044/mf/invoke-mf2pt.sh > File mf/invoke-mf2pt.sh (right): > > https://codereview.appspot.com/553700043/diff/547740044/mf/invoke-mf2pt.sh#newcode4 >

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On Sun, Mar 15, 2020 at 8:32 PM David Kastrup wrote: > > I decided for Python in this case, because recursion seems like > > something I don't want to do in a sh script. > > So apparently you want to use Python for recursive scripting, or why > bring it up? I'm talking about a recursive

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On Sun, Mar 15, 2020 at 8:44 PM wrote: > On 2020/03/15 18:54:44, hanwenn wrote: > > On Sun, Mar 15, 2020 at 7:14 PM > wrote: > > > > I very much agree with you, but out of the existing language > within > > > > our tree (Perl, Python, Shell, C++, Make), it is the

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On 2020/03/15 18:52:27, hanwenn wrote: > > Not doing this at all. > > In cases like this, I begin to question the very fundamental > > assumptions. In this case: Do we really need to dynamically generate the > > dependencies if there's really no tool for it? My answer is "no" after > > seeing that

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

Han-Wen Nienhuys writes: > On Sun, Mar 15, 2020 at 5:03 PM David Kastrup wrote: >> Makefiles are an established technique well-known to most contributors. >> Recursive python scripts for writing human-unreadable controlling files > > What recursive script are you talking about ? It is you who

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On Sun, Mar 15, 2020 at 7:14 PM wrote: > > I very much agree with you, but out of the existing language within > > our tree (Perl, Python, Shell, C++, Make), it is the least worst > > option. Make is too limited (see the mess that our makefiles are > > today), Shell has all the problems of Make.

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On Sun, Mar 15, 2020 at 7:14 PM wrote: > > On Sun, Mar 15, 2020 at 5:04 PM > wrote: > > > I did so now and ... does this mean you want to write yet another > meta > > > build system? That sounds horrible to maintain. > > > > It doesn't have to be a *meta* build

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On 2020/03/15 16:16:06, hanwenn wrote: > On Sun, Mar 15, 2020 at 5:04 PM wrote: > > I did so now and ... does this mean you want to write yet another meta > > build system? That sounds horrible to maintain. > > It doesn't have to be a *meta* build system, because

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On Sun, Mar 15, 2020 at 5:03 PM David Kastrup wrote: > Makefiles are an established technique well-known to most contributors. > Recursive python scripts for writing human-unreadable controlling files What recursive script are you talking about ? > in some build system that is the current fad

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On 2020/03/15 18:11:44, hanwenn wrote: > On Sun, Mar 15, 2020 at 5:03 PM David Kastrup wrote: > > Makefiles are an established technique well-known to most contributors. > > Recursive python scripts for writing human-unreadable controlling files > > What recursive script are

Re: Remove compat hack for Solaris7 and HP-UX (issue 579480047 by hanw...@gmail.com)

On 2020/03/15 16:47:55, dak wrote: > https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4 > File aclocal.m4 (right): > > https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4#newcode694 > aclocal.m4:694: AC_PATH_PROG(BASH, bash, $SHELL) > This sets BASH with a fallback

Re: Tidy check on Ubuntu Xenial

On Sun, Mar 15, 2020 at 6:00 PM Dan Eble wrote: > > On Mar 15, 2020, at 10:26, Han-Wen Nienhuys wrote: > > > > On Sun, Mar 15, 2020 at 2:33 AM Dan Eble wrote: > >> > >> On Mar 14, 2020, at 19:39, Han-Wen Nienhuys wrote: > >>> > >>> On Sat, Mar 14, 2020 at 9:16 PM Dan Eble wrote: > I

Re: Fix output-distance tests (issue 569540043 by hanw...@gmail.com)

On Mar 15, 2020, at 12:21, David Kastrup wrote: > > Han-Wen Nienhuys writes: >> suggests that OSX actually uses bash. > > Paywalled site. The current macOS (10.15.3, "Catalina") sets zsh as the default shell for new users. bash is still provided. $ zsh --version zsh 5.7.1

Re: Tidy check on Ubuntu Xenial

On Mar 15, 2020, at 10:26, Han-Wen Nienhuys wrote: > > On Sun, Mar 15, 2020 at 2:33 AM Dan Eble wrote: >> >> On Mar 14, 2020, at 19:39, Han-Wen Nienhuys wrote: >>> >>> On Sat, Mar 14, 2020 at 9:16 PM Dan Eble wrote: I assume the warnings are incorrect, otherwise you would be asking for

Re: Remove compat hack for Solaris7 and HP-UX (issue 579480047 by hanw...@gmail.com)

https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4#newcode694 aclocal.m4:694: AC_PATH_PROG(BASH, bash, $SHELL) This sets BASH with a fallback to /bin/sh , meaning that $BASH is not

Re: Fix output-distance tests (issue 569540043 by hanw...@gmail.com)

Han-Wen Nienhuys writes: > On Sun, Mar 15, 2020 at 5:10 PM David Kastrup wrote: >> >> hanw...@gmail.com writes: >> >> > On 2020/03/14 21:58:52, lemzwerg wrote: >> >> Just skimming the code: LGTM >> >> >> >> >> >

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On 2020/03/15 14:39:06, hanwenn wrote: > On Sun, Mar 15, 2020 at 12:05 PM wrote: > > On 2020/03/14 23:57:48, hanwenn wrote: > > > I have been experimenting with Ninja (https://ninja-build.org/), but > > Ninja has a > > > very restricted model. Make functions,

Re: Fix output-distance tests (issue 569540043 by hanw...@gmail.com)

On Sun, Mar 15, 2020 at 5:10 PM David Kastrup wrote: > > hanw...@gmail.com writes: > > > On 2020/03/14 21:58:52, lemzwerg wrote: > >> Just skimming the code: LGTM > >> > >> > > https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py > >> File

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On Sun, Mar 15, 2020 at 5:04 PM wrote: > > On 2020/03/15 14:39:06, hanwenn wrote: > > On Sun, Mar 15, 2020 at 12:05 PM > wrote: > > > On 2020/03/14 23:57:48, hanwenn wrote: > > > > I have been experimenting with Ninja (https://ninja-build.org/), > but > > > Ninja

Remove compat hack for Solaris7 and HP-UX (issue 579480047 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/579480047/

Re: make: remove unused mutopia templates (issue 559600043 by hanw...@gmail.com)

Reviewers: lemzwerg, Message: commit 3baa13d1a519f34b658d06026c386e7490439366 Author: Han-Wen Nienhuys Date: Fri Mar 6 19:26:32 2020 +0100 make: remove unused mutopia templates Remove unused -inclusions.make rule https://sourceforge.net/p/testlilyissues/issues/5825

Re: Fix output-distance tests (issue 569540043 by hanw...@gmail.com)

hanw...@gmail.com writes: > On 2020/03/14 21:58:52, lemzwerg wrote: >> Just skimming the code: LGTM >> >> > https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py >> File scripts/build/output-distance.py (right): >> >> >

Re: Use $(MAKE) instead of 'make' throughout (issue 565720043 by hanw...@gmail.com)

Reviewers: lemzwerg, Message: commit 9812f6b989753cf5dfb42525c45839cbecd79ade Author: Han-Wen Nienhuys Date: Sat Feb 22 22:35:27 2020 +0100 Use $(MAKE) instead of 'make' throughout https://sourceforge.net/p/testlilyissues/issues/5818 http://codereview.appspot.com/565720043

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

Carl Sorensen writes: > On 3/15/20, 8:39 AM, "lilypond-devel on behalf of Han-Wen Nienhuys" > hanw...@gmail.com> wrote: > > On Sun, Mar 15, 2020 at 12:05 PM wrote: > > > > > > What I'm not really happy with is replacing all of this with custom > > Python scripts, however

Re: Remove unused .1 => .txt rule (issue 557560044 by hanw...@gmail.com)

commit bc730a2410aa2d6f65904235d11c473f0b46 Author: Han-Wen Nienhuys Date: Sat Feb 29 23:18:34 2020 +0100 Remove unused .1 => .txt rule Remove @GROFF@ config.make.in var https://codereview.appspot.com/557560044/

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On 3/15/20, 8:39 AM, "lilypond-devel on behalf of Han-Wen Nienhuys" wrote: On Sun, Mar 15, 2020 at 12:05 PM wrote: > > > What I'm not really happy with is replacing all of this with custom > Python scripts, however small they are. Skimming over scan-mf-deps.py, >

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

Werner LEMBERG writes: >>> What's the motivation to use Python for all of this? >> >> What's the motivation to use sh for all this? >> >> You can certainly make it shorter with shell, but will it be >> significantly simpler, easier to understand or easier to maintain? >> >> I decided for Python

Re: Move metafont stepmake templates into mf/GNUmakefile (issue 577610043 by hanw...@gmail.com)

commit 19faa30b9771b519c120344eda5fea262dd60c74 Author: Han-Wen Nienhuys Date: Fri Mar 6 19:55:04 2020 +0100 Move metafont stepmake templates into mf/GNUmakefile https://sourceforge.net/p/testlilyissues/issues/5827 http://codereview.appspot.com/577610043

Re: Do not allow page breaks on the first column of a score (issue 581720054 by hanw...@gmail.com)

commit ad039e1de14135b9d3bc1bb6d71f729abdc53311 Author: Han-Wen Nienhuys Date: Fri Feb 28 17:02:38 2020 +0100 Do not allow page breaks on the first column of a score This duplicates a column index in the vector of allowed break points, causing a crash. Do some more

Re: Fix output-distance tests (issue 569540043 by hanw...@gmail.com)

> Are there still systems that run without bash that we care about? I guess all BSD variants might miss bash since it is evil, evil GNU software. https://codereview.appspot.com/569540043/

Re: Add comments to code related to page breaking/layout (issue 563630043 by hanw...@gmail.com)

commit 0b9804f7ed4ac285a432c12b0dea5ab9c67a5eb0 Author: Han-Wen Nienhuys Date: Fri Feb 28 14:01:38 2020 +0100 Add comments to code related to page breaking/layout https://sourceforge.net/p/testlilyissues/issues/5802 http://codereview.appspot.com/563630043

Re: Do not run GC after processing every file. (issue 579330043 by hanw...@gmail.com)

commit e36b7c7ea986418bcfebfba6c6c971db05b77afb Author: Han-Wen Nienhuys Date: Tue Feb 25 21:39:10 2020 +0100 GUILE2: Do not run GC after processing every file. https://codereview.appspot.com/579330043/

Re: Add some const declarations to page breaking code (issue 569490044 by hanw...@gmail.com)

Reviewers: lemzwerg, Message: commit e3c676f1f477818504992ac6c4c938aa56e69b78 Author: Han-Wen Nienhuys Date: Fri Feb 28 14:48:56 2020 +0100 Add some const declarations to page breaking code https://sourceforge.net/p/testlilyissues/issues/5820

Re: stepmake: use patsubst for finding build-dir (issue 575750043 by hanw...@gmail.com)

commit febe487bb45c97f97377536a5d15da80cce80297 Author: Han-Wen Nienhuys Date: Sun Mar 1 14:03:36 2020 +0100 stepmake: use patsubst for finding build-dir The previous approach used $(subst ) which replaces all occurrences. This lead to surprising results when the top-build-dir

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

>> What's the motivation to use Python for all of this? > > What's the motivation to use sh for all this? > > You can certainly make it shorter with shell, but will it be > significantly simpler, easier to understand or easier to maintain? > > I decided for Python in this case, because recursion

Re: sources: fix handling of non-existent include files (issue 547700043 by hanw...@gmail.com)

On 2020/02/28 18:43:35, hanwenn wrote: commit 1bba00b04f1379972c9dd24717067aa10643229c Author: Han-Wen Nienhuys Date: Fri Feb 28 19:03:23 2020 +0100 sources: fix handling of non-existent include files https://codereview.appspot.com/547700043/

Re: Fix output-distance tests (issue 569540043 by hanw...@gmail.com)

On 2020/03/14 21:58:52, lemzwerg wrote: > Just skimming the code: LGTM > > https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py > File scripts/build/output-distance.py (right): > >

Re: Added transition lines for lyrics (issue 565750043 by davidgrant...@gmail.com)

I tried looking at your patch, but: branch 'issue565750043_553710043' set up to track remote branch 'master' from 'origin'. Switched to a new branch 'issue565750043_553710043' % Total% Received % Xferd Average Speed TimeTime Time Current Dload

Re: Added transition lines for lyrics (issue 565750043 by davidgrant...@gmail.com)

https://codereview.appspot.com/565750043/diff/553710043/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/565750043/diff/553710043/Documentation/notation/vocal.itely#newcode894 Documentation/notation/vocal.itely:894: ah

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On Sun, Mar 15, 2020 at 12:05 PM wrote: > > On 2020/03/14 23:57:48, hanwenn wrote: > > I have been experimenting with Ninja (https://ninja-build.org/), but > Ninja has a > > very restricted model. Make functions, wildcards, etc. are not > possible. In > > order to advance my experiments, I'm

Re: Fix test target name in python/GNUmakefile (issue 581770043 by hanw...@gmail.com)

On 2020/03/11 11:49:17, hanwenn wrote: > On Wed, Mar 11, 2020 at 11:16 AM wrote: > > > > > > > https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile > > File scripts/build/GNUmakefile (right): > > > > >

Re: Tidy check on Ubuntu Xenial

On Sun, Mar 15, 2020 at 2:33 AM Dan Eble wrote: > > On Mar 14, 2020, at 19:39, Han-Wen Nienhuys wrote: > > > > On Sat, Mar 14, 2020 at 9:16 PM Dan Eble wrote: > >> I assume the warnings are incorrect, otherwise you would be asking for > >> help to fix them rather than asking whether checking

PATCHES - Countdown for March 15th

Hello, Here is the current patch countdown list. The next countdown will be on March 17th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5833 Fix MinGW UTF-8 locale settings - Masamichi Hosoda

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

On 2020/03/14 23:57:48, hanwenn wrote: > I have been experimenting with Ninja (https://ninja-build.org/), but Ninja has a > very restricted model. Make functions, wildcards, etc. are not possible. In > order to advance my experiments, I'm trying to clean up the build so I can port > more of the

Re: Upgrading to current makeinfo

Le 14/03/2020 à 21:34, Torsten Hämmerle a écrit : Apart from the fact that it's super-inelegant, you can use raw code within your @ifhtml branch to get a real superscript even in HTML, as in: … and fastidious in matter of typing,and don't forget to add a space before the next word:

Re: [LSR 2.20] broken: #506

> I've fixed it in LSR by reordering engravers. > http://lsr.di.unimi.it/LSR/Item?id=506 Great! > Werner, seems said snippet is based on your idea. Could you have a > look, if the output is now as wished again? I would remove the second, redundant 6/4 in the viola voice. Werner

Re: [LSR 2.20] broken: #889

Am Sa., 14. März 2020 um 13:43 Uhr schrieb David Kastrup : > > Thomas Morley writes: > > > Hi all, > > > > Werner recently asked about lsr-upgrade, thus I had a first look. > > http://lsr.di.unimi.it/LSR/Item?id=889 > > "Automatically coloring grobs to indicate when their direction has > > been

Re: [LSR 2.20] broken: #506

Am Sa., 14. März 2020 um 15:16 Uhr schrieb Thomas Morley : > > http://lsr.di.unimi.it/LSR/Item?id=506 > "Polymetric section: synchronizing different groups of staves" > is broken as well, probably for a long time. > Currently it prints a mess with BarLines and the MultiMeasureRest ist >