Looks nicely done to me. It was a big job!
Thanks,
Carl
http://codereview.appspot.com/1543042/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
Benjamin has sent a revised patch that addresses Neil's concerns.
Please review the patch.
THanks,
Carl
Description:
fix ly:parser-parse-file in an ly file
This switches to using the flex buffer stack.
Please review this at http://codereview.appspot.com/1345041/show
The new patch worked.
I've put some comments in line.
Great job, Mike!
http://codereview.appspot.com/1425041/diff/1/8
File scm/lily-library.scm (right):
http://codereview.appspot.com/1425041/diff/1/8#newcode492
scm/lily-library.scm:492: (cons
In general, I prefer to have the first argument
Mike,
I'm sorry, but I had some comments earlier that I somehow erased with
inadvertent keystrokes, so I added them back in.
Thanks,
Carl
http://codereview.appspot.com/1425041/diff/1/8
File scm/lily-library.scm (right):
http://codereview.appspot.com/1425041/diff/1/8#newcode522
LGTM.
I think the first example is no longer needed.
Thanks,
Carl
http://codereview.appspot.com/1136044/diff/6001/7001
File Documentation/notation/repeats.itely (right):
http://codereview.appspot.com/1136044/diff/6001/7001#newcode126
Documentation/notation/repeats.itely:126: Repeats that
Hi Mark,
I think it's an improvement. I've made specific comments inline.
Thanks!
Carl
http://codereview.appspot.com/1056041/diff/11001/12001
File Documentation/learning/common-notation.itely (right):
http://codereview.appspot.com/1056041/diff/11001/12001#newcode313
I'm out of time to finish this review today, so I thought it would be
best to publish what I have.
My overall thought is that in the Learning Manual, we shouldn't enforce
yet-to-be-explained coding standards. Instead, we ought to format the
examples to do the best job possible of explaining the
http://codereview.appspot.com/1056041/diff/1/2
File Documentation/learning/common-notation.itely (right):
http://codereview.appspot.com/1056041/diff/1/2#newcode101
Documentation/learning/common-notation.itely:101: aeses1
On 2010/05/03 14:19:08, Graham Percival wrote:
On 2010/05/03 13:48:52,
http://codereview.appspot.com/1056041/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
I like the new suggestions. Just a couple of comments.
http://codereview.appspot.com/970044/diff/1/2
File Documentation/extending/programming-interface.itely (left):
http://codereview.appspot.com/970044/diff/1/2#oldcode38
Documentation/extending/programming-interface.itely:38: * Music
LGTM.
Thanks for getting us in line with standards.
Carl
http://codereview.appspot.com/813048/diff/5001/6001
File Documentation/changes.tely (right):
http://codereview.appspot.com/813048/diff/5001/6001#newcode72
Documentation/changes.tely:72: @example
I think it would be better to show both
Thanks,
Carl
http://codereview.appspot.com/931041/diff/1/9
File scm/define-grob-properties.scm (right):
http://codereview.appspot.com/931041/diff/1/9#newcode756
scm/define-grob-properties.scm:756: (spacing-pair ,pair? A pair of
booleans which set the spacing for a
Should the name of this
Reviewers: Neil Puttock,
http://codereview.appspot.com/906045/diff/1/3
File lily/articulations.cc (right):
http://codereview.appspot.com/906045/diff/1/3#newcode4
lily/articulations.cc:4: Copyright (C) 2010--2010 Carl Sorensen
c_soren...@byu.edu
On 2010/04/12 20:12:31, Neil Puttock wrote:
Looks good to me, with the exception of the hardcoded value stuff.
Thanks,
Carl
http://codereview.appspot.com/181144/diff/4008/5018
File lily/bar-line.cc (right):
http://codereview.appspot.com/181144/diff/4008/5018#newcode242
lily/bar-line.cc:242: m.add_at_edge (X_AXIS, RIGHT, thick, 2.5 *
The patch set now seems to be complete. I've responded to Neil's
comments, and regression tests all pass.
Please review.
Thanks,
Carl
http://codereview.appspot.com/186268/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
OK, so I added the optional default to ly:context-property, and fixed
the indentation.
make check works.
I think it's good to go now.
http://codereview.appspot.com/186268/diff/1/7
File scm/translation-functions.scm (right):
http://codereview.appspot.com/186268/diff/1/7#newcode236
I've found a bug in this code that showed up with the latest changes in
the regression tests.
I'll have a new patch set later; don't spend any time on this one right
now.
THanks,
Carl
http://codereview.appspot.com/186268/show
___
lilypond-devel
I've found a bug in this code that showed up with the latest changes in
the regression tests.
I'll have a new patch set later; don't spend any time on this one right
now.
THanks,
Carl
http://codereview.appspot.com/186268/show
___
lilypond-devel
Reviewers: Neil Puttock,
Message:
Neil,
Thanks for the careful review.
I think I've dealt with everything, but there is still an open question
on ly:context-property. As far as I can see, there is not currently a
means of putting a default in the ly:context-property call. I can see
that it
Looks great to me.
I have a couple of comments.
Thanks for doing this!
Carl
http://codereview.appspot.com/164063/diff/2001/3008
File scm/translation-functions.scm (right):
http://codereview.appspot.com/164063/diff/2001/3008#newcode393
scm/translation-functions.scm:393: (define-public
A few whitespace errors (tab following spaces) and one indenting
mistake. Then I think it's good to go.
http://codereview.appspot.com/150044/diff/11/1015
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/150044/diff/11/1015#newcode611
ly/music-functions-init.ly:611:
Ian,
I found some indentation errors in the .ly file.
Thanks for your patience,
Carl
http://codereview.appspot.com/143055/diff/19/1019
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/143055/diff/19/1019#newcode616
Line 616: (let* ( (get-notes (lambda (ev-chord)
I like what you've done.
I've put a couple of comments in. They are not mandatory, but just for
your consideration.
Carl
http://codereview.appspot.com/115065/diff/1001/1003
File scm/paper.scm (right):
http://codereview.appspot.com/115065/diff/1001/1003#newcode220
Line 220:
LGTM. I do have one comment about tests for != SCM_UNDEFINED. It think
there's less chance of confusion when testing for undefined rather
than not undefined, which is defined. The double negative (not
undefined) can potentially be confusing.
But this is just my opinion, and you can feel free
Reviewers: Neil Puttock, joeneeman,
Message:
OK, I've responded to Joe's comments.
I've created a new file lily/beam-scheme.cc, and put c++ and scheme
callable routines in it. Then I've used those calls from auto-beam.scm,
measure-grouping-engraver.cc, and beaming-pattern.cc. I also added a
Code looks good to me.
I have a couple of optional minor nitpicks.
Thanks,
Carl
http://codereview.appspot.com/8874/diff/5202/4204
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/8874/diff/5202/4204#newcode2623
Line 2623: (ly:font-get-glyph font (string-append
On 7/8/09 8:41 AM, John Mandereau john.mander...@gmail.com wrote:
009/7/7 Graham Percival gra...@percival-music.ca:
I'm not, but almost all updates are in the form
\\oldCommand - \\newCommand
I suppose that somebody might have tried to speed up convert-ly
processing by doing
\\old -
On 7/7/09 1:56 AM, Marc Hohl m...@hohlart.de wrote:
Joe Neeman schrieb:
On Tue, 2009-06-23 at 12:53 -0600, Carl D. Sorensen wrote:
http://codereview.appspot.com/67174/diff/1/2#newcode237
Line 237: \layout {
It seems to me that we have 3 versions of tablature now: the default
version
On 7/7/09 12:20 PM, Marc Hohl m...@hohlart.de wrote:
[...]
I don't particularly mind breaking existing scores (as long as there is
a convert-ly rule to at least warn about the problem), but I don't think
the situation in the patch is particularly friendly. We've a long
tradition of
On 7/3/09 1:02 PM, Graham Percival gra...@percival-music.ca wrote:
On Fri, Jul 03, 2009 at 12:41:32PM -0500, Jonathan Kulp wrote:
Graham Percival wrote:
On Wed, Jul 01, 2009 at 10:50:07PM +0100, Trevor Daniels wrote:
Does this still compile the lilypond examples? That would take
take
On 7/1/09 1:32 AM, Graham Percival gra...@percival-music.ca wrote:
On Tue, Jun 30, 2009 at 04:07:08PM -0600, Carl D. Sorensen wrote:
On 6/30/09 1:30 PM, Mark Polesky markpole...@yahoo.com wrote:
regarding this...
http://lists.gnu.org/archive/html/lilypond-devel/2009-06/msg00294.html
Mark,
Thanks for the updated feedback!
On 7/1/09 8:59 AM, Mark Polesky markpole...@yahoo.com wrote:
Carl D. Sorensen wrote:
Yep, sounds good. Would you prefer that I send text for review
and then create the patch when we like it, or should I just
create a patch to be reviewed
I'm trying to get the CG instructions for using gdb up-to-date. And I'm
trying to debug a problem with the new autobeam stuff I'm working on.
So I checked out a fresh master.
Then I did
./configure --enable-debugging
make
gdb lilypond
GNU gdb 6.3.50-20050815 (Apple version gdb-768) (Tue Oct
On 6/30/09 11:02 AM, Patrick McCarty pnor...@gmail.com wrote:
On Tue, Jun 30, 2009 at 08:40:05AM -0600, Carl D. Sorensen wrote:
I'm trying to get the CG instructions for using gdb up-to-date. And I'm
trying to debug a problem with the new autobeam stuff I'm working on.
So I checked out
On 6/30/09 12:16 PM, Patrick McCarty pnor...@gmail.com wrote:
On Tue, Jun 30, 2009 at 11:53:34AM -0600, Carl D. Sorensen wrote:
On 6/30/09 11:02 AM, Patrick McCarty pnor...@gmail.com wrote:
However, on a hunch I decided to look at the .gdbinit file. I had been
using the .gdbinit file
On 6/30/09 1:30 PM, Mark Polesky markpole...@yahoo.com wrote:
regarding this...
http://lists.gnu.org/archive/html/lilypond-devel/2009-06/msg00294.html
http://lists.gnu.org/archive/html/lilypond-devel/2009-06/msg00303.html
Jonathan Kulp wrote:
After making the .iso I tested it in Sun
On 6/29/09 12:50 PM, Mark Polesky markpole...@yahoo.com wrote:
Neil Puttock wrote:
1) I'd like to have all of type-p-name-alist listed in NR 6.1.1
Overview of music functions (programming-interface.itely, line
76). Any objections?
None here, as long as you automate it (perhaps
On 6/29/09 7:08 PM, Mark Polesky markpole...@yahoo.com wrote:
Carl D. Sorensen wrote:
Well it might require some serious hacking. But it ought to be possible to
create a python script to do your regex search (and maybe even eliminate the
duplicates). This could be stored as a .scm
On 6/24/09 8:49 PM, Mark Polesky markpole...@yahoo.com wrote:
One thing I don't understand: why do I need to use (load ...) to
retrieve functions that are defined with define-public in the same
directory?
The loading of the scm files is actually not taken care of by just being in
the
Mark,
I like this, because it makes the out-of-order stuff be only a programmer's
problem, and programmers can use searches to find the code they're looking
for.
A couple of other comments:
The name of the file is lily-sort.scm, but the comment in the header says
ly-sort.scm. I much prefer
On 6/25/09 1:23 PM, Mark Polesky markpole...@yahoo.com wrote:
Carl D. Sorensen wrote:
I like this, because it makes the out-of-order stuff be only a
programmer's problem, and programmers can use searches to find
the code they're looking for.
To an extent, I would say. There's
On 6/25/09 4:51 PM, Mark Polesky markpole...@yahoo.com wrote:
Here are 2 versions of the same procedure.
Is the second one *too* concise and cryptic?
- Mark
I actually like the general format of the second one better.
But I'd rewrite it a bit: It's a string-compare-? function, so
On 6/25/09 5:18 PM, Mark Polesky markpole...@yahoo.com wrote:
With Carl's help, I've created a new file that contains procedures
for sorting lists and alists according to a specific algorithm
that generates more intuitively-ordered lists, which will make it
a lot easier to locate things in
About 10 weeks ago I proposed a new architecture for autobeaming rules,
which placed all the rules in a single nested alist, with one entry per time
signature.
As part of the discussion, I proposed creating a non-displaying grob that
would allow the use of \override and \revert to adjust the
-- Forwarded Message
snip
My current proposal is to add an autoBeamSettings property to the Beam grob.
The autoBeamSettings can then be adjusted by overriding this property.
snip
-- End of Forwarded Message
Oops, I guess this is named wrong. I would need to eliminate
autoBeamSettings
On 6/24/09 9:04 AM, Han-Wen Nienhuys hanw...@gmail.com wrote:
On Wed, Jun 24, 2009 at 10:47 AM, Carl D. Sorensenc_soren...@byu.edu wrote:
My current proposal is to add an autoBeamSettings property to the Beam grob.
The autoBeamSettings can then be adjusted by overriding this property.
On 6/23/09 11:48 PM, Mark Polesky markpole...@yahoo.com wrote:
Han-Wen Nienhuys wrote:
I mean to have an automated set of tests, that checks for example that
(eq? (split-at-predicate odd? '(2 3 6 8 9 0))
'((2) (6 8) (0)))
holds. It would be .ly file that runs Scheme
On 6/24/09 12:09 PM, Hans Aberg hab...@math.su.se wrote:
On 24 Jun 2009, at 15:47, Carl D. Sorensen wrote:
About 10 weeks ago I proposed a new architecture for autobeaming
rules,
which placed all the rules in a single nested alist, with one entry
per time
signature.
To me
On 6/24/09 2:33 PM, Neil Puttock n.putt...@gmail.com wrote:
2009/6/24 Carl D. Sorensen c_soren...@byu.edu:
Shouldn't we do this by eliminating Dynamic_engraver and renaming
New_dynamic_engraver to Dynamic_engraver?
I'm not sure, since New_dynamic_engraver doesn't have all
On 6/24/09 10:36 AM, Mark Polesky markpole...@yahoo.com wrote:
Han-Wen Nienhuys wrote:
(eq? (split-at-predicate odd? '(2 3 6 8 9 0))
'((2) (6 8) (0)))
holds. It would be .ly file that runs Scheme function on a
set of inputs, and compares them to a set of outputs to make
Thanks, Joe.
On 6/23/09 12:31 PM, joenee...@gmail.com joenee...@gmail.com wrote:
I don't know much about the issues here, but here's a review, fwiw. Of
course, you'll need to update the docs also (and a regression test or 2
would be nice).
Yep, docs and regressions are in the works.
On 6/23/09 4:07 PM, Neil Puttock n.putt...@gmail.com wrote:
Hi everybody,
Since the Dynamic_engraver is no longer used due to being replaced
just over a year ago, I'd like to remove it completely.
Shouldn't we do this by eliminating Dynamic_engraver and renaming
New_dynamic_engraver to
On 6/20/09 3:18 PM, Mark Polesky markpole...@yahoo.com wrote:
Nicolas Sceaux wrote:
#(begin
(define foo 0)
(define bar 1)
)
The formatting is bad.
#(begin
(define foo 0)
(define bar 1))
Parentheses are never left alone on a line.
I respectfully*
And here's Graham's reply about where the filenames should go.
I second his opinion that it ought to be in \paper for the printed output.
By symmetry, it would seem that that drives us to needing to include it in
\midi for the midi output.
Declaring the file name twice seems to be unseemly, but
On 6/21/09 6:29 PM, Graham Percival gra...@percival-music.ca wrote:
As a result, I'm thinking that the following branches should be
deleted:
csorensen
dev/rlittle
dev/jmandereau
dev/rune(if anybody wants to grab a copy of this as a
memorium, go ahead)
dev/texi2html
On 6/20/09 2:17 PM, Mark Polesky markpole...@yahoo.com wrote:
Here are some proposed additions to LM B. Scheme tutorial
Good for you! Thanks!
***new paragraph and example:
Multiple consecutive scheme expressions in a music file can be
combined using the *begin* operator. This
On 6/20/09 2:21 PM, Graham Percival gra...@percival-music.ca wrote:
On Sat, Jun 20, 2009 at 09:57:20AM -0700, Patrick McCarty wrote:
On Sat, Jun 20, 2009 at 01:54:30PM +0200, John Mandereau wrote:
Le 13/06/2009 20:14, Graham Percival a écrit :
- also, if we end up going this route,
On 6/18/09 10:17 PM, Graham Percival gra...@percival-music.ca wrote:
On Thu, Jun 18, 2009 at 08:55:08PM -0700, Mark Polesky wrote:
Any reason why properties listed in define-grobs.scm
are not in alphabetical order? Sometimes I get a little
frustrated looking stuff up in IR 3.1.
That
Mark,
This would be a good time for you to learn about testing.
See AU 1.2.5 for information about how to test and make sure your changes
haven't broken anything.
You should do this, and then you will know if you've broken anything.
Thanks,
Carl
On 6/19/09 2:17 AM, Mark Polesky
On 6/19/09 2:17 AM, Mark Polesky markpole...@yahoo.com wrote:
Actually it's 2 patches.
Could someone test it out, make sure I didn't
accidentally do something stupid? Should be okay,
but it's such a big change... If it looks good,
you know what to do!
Mark does not have the
On 6/16/09 1:51 PM, Mark Polesky markpole...@yahoo.com wrote:
Trevor, could you add a bit to your recent LM 4.3.1 patch about
empty-stencil and point-stencil? They are suitable substitutes for
#'stencil = ##f.
\override grob #'stencil = #empty-stencil
\override grob #'stencil =
On 6/17/09 9:59 AM, Federico Bruni brunol...@gmx.com wrote:
Graham Percival wrote:
On Sun, Jun 14, 2009 at 01:04:13AM +0200, John Mandereau wrote:
After that, it would be best translating the lilypond.org main web site
before translating the rest of the documentation, as the former has
to remember its usage with infrequent work, so I
just use separate windows for vim, gdb, lilypond, etc.
HTH,
Carl
Bert
Original message
From: Carl D. Sorensen c_soren...@byu.edu
Sent: 13 Jun 2009 20:15 -06:00
To: Bertalan Fodor lilypondt...@organum.hu, Jonathan Kulp
jonlancek
On 6/13/09 11:25 AM, Federico Bruni brunol...@gmx.com wrote:
Carl D. Sorensen wrote:
On 6/9/09 10:39 AM, Federico Bruni brunol...@gmx.com wrote:
Great!
John Mandereau is the translation meister. I've copied him on this reply.
The first step toward developing a translation
On 6/13/09 8:43 AM, Bertalan Fodor lilypondt...@organum.hu wrote:
What tools can be used to develop? To debug, browse the source, etc?
Compiling: gcc
Debugging: gdb
Guile/Scheme testing: guile
Browse the source: more, vi
Search the source: git grep
HTH,
Carl
On 6/11/09 4:50 PM, Jonathan Kulp jonlancek...@gmail.com wrote:
Bertalan Fodor (LilyPondTool) wrote:
The goal of this iso to make it usable on a virtualization tool. The
open source Sun VirtualBox can for example mount this as the virtual
hard disk.
Once it's ready maybe I can create
Please review Mark Hohl's patch for improved tablature.
It's available at
http://codereview.appspot.com/67174
Thanks,
Carl
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 6/10/09 8:07 AM, Carl D. Sorensen c_soren...@byu.edu wrote:
Please review Mark Hohl's patch for improved tablature.
It's available at
http://codereview.appspot.com/67174
Marc,
I have a few comments on the patch:
1) I think you should create a new file: scm/tablature.scm
On 6/9/09 2:12 AM, Jan Nieuwenhuizen janneke-l...@xs4all.nl wrote:
... the stable branch that I now recreated, from master
at tag release/2.12.2-1, *was* that actually bugfixing,
cautious development?
Or does our 2.12.2 release include new, risky development?
As far as I know, 2.12.2
On 6/9/09 7:56 AM, Jan Nieuwenhuizen janneke-l...@xs4all.nl wrote:
Op dinsdag 09-06-2009 om 07:16 uur [tijdzone -0600], schreef Carl D.
Sorensen:
There was an announced policy of rapid releases that discouraged spending
time on backporting, since we were going to move forward more
On 6/9/09 10:39 AM, Federico Bruni brunol...@gmx.com wrote:
Hi all,
as far as I can see there is not an italian documentation for lilypond.
I'd like to help with that, could you please tell me how can I contribute?
If other italians want to join, either for just proofreading or
On 6/5/09 12:18 PM, Graham Percival gra...@percival-music.ca wrote:
Do we need a separate branch (or even repository) for web/ stuff?
I propose that we merge this with the main branch.
I thought that the previous discussion was actually to separate the web from
the source, i.e., more,
On 6/2/09 2:55 AM, Johannes Schindelin johannes.schinde...@gmx.de wrote:
Hi,
On Tue, 2 Jun 2009, John Mandereau wrote:
Graham Percival a écrit :
According to
http://savannah.gnu.org/forum/forum.php?forum_id=5828
a push is precisely what we should do -- since git is a
decentralized
On 6/1/09 5:16 AM, Werner LEMBERG w...@gnu.org wrote:
In the docs there are references to both `beam-grouping' and
`beat-grouping'. This is confusing. However, `beam-grouping' doesn't
exist in the source code. I thus suggest to replace `beam-grouping'
with `auto-beam beat-grouping'
On 6/1/09 5:29 PM, Peter Chubb lily.u...@chubb.wattle.id.au wrote:
Hi,
I've put up a page on how to get more realistic sounding MIDI output
from current LilyPond, along with the scripts and scheme code used, at
http://www.nicta.com.au/people/chubbp/articulate
Peter,
I haven't
I've posted Marc Hohl's excellent work on improved tab support on rietveld
for your review.
Please review the patch, located at
http://codereview.appspot.com/63163
Thanks,
Carl
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 5/26/09 3:55 PM, Neil Puttock n.putt...@gmail.com wrote:
2009/5/24 Carl D. Sorensen c_soren...@byu.edu:
On a more general note, do you have any suggestions for how to check
convert-ly rules? For code, we have regression tests. For convert-ly, as
far as I know, we have nothing
On 5/26/09 3:48 PM, Neil Puttock n.putt...@gmail.com wrote:
2009/5/25 Andrew Hawryluk ahawry...@gmail.com:
Yes, I'll take a look at it. Thanks, Neil for catching those!
No problem.
I'm sorry I didn't respond earlier; though I'd taken a cursory look at
the patch (and noticed the
On 5/27/09 3:17 AM, Mark Polesky markpole...@yahoo.com wrote:
line 408 of define-grobs.scm lists staff in a break-align-orders
vector. Is that a typo?
line 49 of lsr/creating-simultaneous-rehearsal-marks.ly reads:
\once \override Score.RehearsalMark #'break-align-symbols =
On 5/27/09 9:31 AM, herm...@operador.net.ar herm...@operador.net.ar
wrote:
If by internal representation of scores you mean the structure of user
created input files, the best place to start is the tutorial.
Actually I mean the parsed user input. Consider the following snippet from the
-- Forwarded Message
From: Mark Polesky markpole...@yahoo.com
Date: Tue, 26 May 2009 02:46:02 -0600
To: Carl D. Sorensen c_soren...@byu.edu
Conversation: two patches
Subject: two patches
Carl,
here are two more patches. By the way, *nobody* replied
to my nifty proposal on -devel. Boo hoo
On 5/27/09 11:11 AM, John Mandereau john.mander...@gmail.com wrote:
Carl D. Sorensen a écrit :
Mark,
I appreciate your good work on these patches.
So do I :-)
2) I'm not sure how to handle patches to translated documents. I know that
the translations need to follow
Mark,
I have pushed 0001, 0002, 0003, and 0008.
I modified 0007 and pushed it as well (I wanted to avoid the possessive ',
as it can cause difficulty for non-native speakers, so I changed fot to
for in the patch).
I have *not* pushed patches 0004, 0005, or 0006, because they contain
changes
On 5/27/09 5:51 PM, John Mandereau john.mander...@gmail.com wrote:
Carl D. Sorensen a écrit :
OK, so to make sure I understand correctly,
a) The changes to Documentation/de/* that move Lilypond - LilyPond are OK
to commit, even though the commitish in the header of this file won't
On 5/26/09 2:57 AM, Trevor Daniels t.dani...@treda.co.uk wrote:
Johannes Schindelin Tuesday, May 26, 2009 9:37 AM
4) Recommend a CR/LF behavior.
Use Unix style line endings?
Use Windows style line endings?
Commit line endings as they are?
Again, I think the default
On 5/26/09 7:10 AM, Johannes Schindelin johannes.schinde...@gmx.de
wrote:
Hi,
On Tue, 26 May 2009, Carl D. Sorensen wrote:
When I make my own patches, they're Unix line endings.
Trevor, could you do a quick search for the fixes you've pushed, and
identify the patches that caused
Hi,
In checking this out, it appears that nearly all of the MacOS line endings
(CR-only) were in musicxml regression test files from Reinhold.
So apparently my hypothesis/concern was invalid. Fortunately, I haven't
been adding CR-only endings when I pushed other people's patches.
Carl
On 5/25/09 5:38 AM, Jonathan Kulp jonlancek...@gmail.com wrote:
Jonathan Kulp wrote:
Cool! I'm going to run them one more time to be sure, then I'll send
you the tarball privately, Valentin.
Jon
One snippet won't compile (attached). If someone wants to have a go at
it that'd
On 5/24/09 10:46 PM, Mark Polesky markpole...@yahoo.com wrote:
And how do I exit the EDIT_COMMITMSG window? I've included an
image showing the window. If I click on the X button, the whole
git bash shell closes along with it. That can't be right.
Okay, this one I figured out. It says
On 5/24/09 10:57 PM, Patrick McCarty pnor...@gmail.com wrote:
On Sun, May 24, 2009 at 07:40:08PM -0700, Mark Polesky wrote:
The already up to date means that all of your remote tracking
branches reflect the current state of the branches at git.sv.gnu.org,
and that your local branch has
Thanks, Applied.
Valentin,
Can you change the status of 708 to fixed in 2.13.1? And verify, at your
convenience?
Thanks,
Carl
On 5/22/09 9:11 PM, Andrew Hawryluk ahawry...@gmail.com wrote:
This patch will allow convert-ly to process this:
\version 2.11.0
{
c d'4 ees
\set
On 5/23/09 6:48 PM, Joe Neeman joenee...@gmail.com wrote:
On Sat, 2009-05-23 at 23:38 +0100, Neil Puttock wrote:
2009/5/23 Joe Neeman joenee...@gmail.com:
If I understand this correctly, you're suggesting that we pad each
instrument name according to the largest (wrt X-extent)
On 5/22/09 7:25 AM, Bertalan Fodor (LilyPondTool)
lilypondt...@organum.hu wrote:
By the way, who's offering to spend the 5-20 hours required to
implement such changes to the parser? (whatever we end up
deciding)
And also in the LilyPondTool parser? ;)
Bert,
As mucn as I like
On 5/22/09 3:18 PM, Jonathan Kulp jonlancek...@gmail.com wrote:
Mats Bengtsson wrote:
Jonathan Kulp wrote:
Carl D. Sorensen wrote:
This is a good idea, Carl. I wouldn't mind trying it myself. My son's
laptop has XP on one partition but I don't know if I'll be able to get
On 5/22/09 5:33 PM, Jonathan Kulp jonlancek...@gmail.com wrote:
Carl D. Sorensen wrote:
On 5/22/09 3:48 PM, Jonathan Kulp jonlancek...@gmail.com wrote:
Carl D. Sorensen wrote:
You may want to make sure you have the right make:
which make
make --version
GNU Make 3.81
That's
On 5/22/09 4:46 PM, Neil Puttock n.putt...@gmail.com wrote:
2009/5/20 Francisco Vila paconet@gmail.com:
2009/5/20 Francisco Vila paconet@gmail.com:
The key code is this. Given a (big) amount of time I could figure out
how it works and try to improve it.
On 5/22/09 8:41 PM, Jonathan Kulp jonlancek...@gmail.com wrote:
Carl D. Sorensen wrote:
I would agree with that.
Sometimes stuff is in My Documents, which has a space.
Carl
I've made some progress. When I try to run make score on Windows XP,
I get the following message
On 5/19/09 11:58 PM, Mark Polesky markpole...@yahoo.com wrote:
Carl D. Sorensen wrote:
3. git pull origin master
From git://git.sv.gnu.org/lilypond
* branchmaster- FETCH_HEAD
Already up-to-date.
OK, this says everything is working just fine, so I don't know
why
On 5/19/09 9:32 AM, Valentin Villenave v.villen...@gmail.com wrote:
2009/5/19 Graham Percival gra...@percival-music.ca:
Valentin, have you made contact with Sebastiano yet? If not, it's
time to send him another email.
Yes, he was busy but he now does seem to be available.
He asked
- origin yields:
Fetching new changes from origin
...
Error: Command Failed
It's not supposed to say that, is it?
Carl D. Sorensen wrote:
Were you following the instructions from 1.5 Git on
Windows, or those on 1.1 Getting the source code?
1.5 Git on Windows
Please try
601 - 700 of 1173 matches
Mail list logo
