Re: Fix crash when a stencil routine is missing

2009-07-16 Thread Patrick McCarty
On Thu, Jul 16, 2009 at 05:42:25AM +, joenee...@gmail.com wrote: lgtm http://codereview.appspot.com/83046 Thanks, Joe. It's applied. -Patrick ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: musicxml2ly bug?

2009-07-16 Thread Valentin Villenave
2009/7/15 ArnoWaschk hamama...@gmx.de: while trying to import some scores into lilypond i was given as xml export from a finale using collegue, i stumbled across some problems... Hi Arno, Added as http://code.google.com/p/lilypond/issues/detail?id=806 (please use the bug-lilypond mailing list

Re: [trivial patch] fix bracket padding

2009-07-16 Thread Valentin Villenave
2009/7/9 Graham Percival gra...@percival-music.ca: Since this contains a patch, I forward it to lilypond-devel.  Does anybody think it looks reasonable? On Mon, Jul 06, 2009 at 11:08:42PM +, Thomas Morgan wrote: Consider this input:   \version 2.13.2   \markup {     \column {      

Re: Snippets in doc compile different from stand-alone

2009-07-16 Thread John Mandereau
Le mardi 14 juillet 2009 à 16:21 -0600, Carl Sorensen a écrit : Hmm -- I read through the CG and missed it. Now that I know what I'm looking for, I see where it is. I'll add something to the CG. Thanks. The general problem when I write instructions in the CG (besides the fact that I still

Re: proposal for doc+web sources

2009-07-16 Thread John Mandereau
Le samedi 11 juillet 2009 à 03:21 -0700, Graham Percival a écrit : Here's my proposal for the source/makefile view of documentation. (this is the big argument one) ...and here is my big reply :-P My understanding is that linking between texinfo manuals is easier if the main files are in the

Re: Obsolete snippets

2009-07-16 Thread John Mandereau
Le mercredi 15 juillet 2009 à 18:40 -0600, Carl Sorensen a écrit : I'll delete all the English and just leave the corrected snippets in the Spanish docs. How about french and german? What would you prefer? Let's not have different policies for different languages, or all contributors and

Re: proposal for doc+web sources

2009-07-16 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Donnerstag, 16. Juli 2009 01:30:56 schrieb John Mandereau: Speaking of cross-references, I'll add sooner or later a makefile hook that runs the cross-reference checking script I wrote and/or some Texi2html-internal hook, which will break the doc

Re: proposal for doc+web sources

2009-07-16 Thread Graham Percival
On Thu, Jul 16, 2009 at 01:30:56AM +0200, John Mandereau wrote: Le samedi 11 juillet 2009 à 03:21 -0700, Graham Percival a écrit : docs/ I assume you mean Documentation. No; I really want to rename that dir. I've wanted to rename it since I first got involved in lilypond. Typing shift-d

Re: proposal for doc+web sources

2009-07-16 Thread Valentin Villenave
2009/7/16 John Mandereau john.mander...@gmail.com: The hourly script is useful to allow any web site maintainer to react quickly against typos and minor bugs that don't require fixing the Makefile or Python scripts, whereas it could take much longer if you (or another maintainer) are the only

Re: proposal for doc+web sources

2009-07-16 Thread Graham Percival
On Thu, Jul 16, 2009 at 04:02:28PM +0200, Valentin Villenave wrote: Another point is that, as far as I can see, we're ready to happily break any existing links to the former documentation, as well as URLs we've been using for years such as lily.org/web/install... and it's a bit frightening to

Re: proposal for doc+web sources

2009-07-16 Thread John Mandereau
Le jeudi 16 juillet 2009 à 04:46 -0700, Graham Percival a écrit : On Thu, Jul 16, 2009 at 01:30:56AM +0200, John Mandereau wrote: I assume you mean Documentation. No; I really want to rename that dir. I've wanted to rename it since I first got involved in lilypond. Typing shift-d has been

Re: Minor corrections to the contrib-guide

2009-07-16 Thread John Mandereau
Hi Till, Sorry for the delay :-/ Le dimanche 28 juin 2009 à 11:00 +0300, Till Rettig a écrit : first time I consulted the contributor's guide. It's never too late :-) (it's never too late either for me to work on it again :-P) in 3.7.2 Documentation translation details you have different

Re: Snippets in doc compile different from stand-alone

2009-07-16 Thread John Mandereau
Le jeudi 16 juillet 2009 à 09:12 -0600, Carl Sorensen a écrit : I tried running make ISOLANG=fr snippet-update from Documentation/. It ran, but most of the files were not able to be updated because they had a different snippet count. So at the present time, make snippet-update is not

Re: Snippets in doc compile different from stand-alone

2009-07-16 Thread Carl Sorensen
On 7/16/09 9:31 AM, John Mandereau john.mander...@gmail.com wrote: So, just to make sure I'm clear on this, I'd like to propose the following for addition to the CG: When a snippet is changed or deleted from the english documentation, the same change (or deletion) should be applied to

Re: Snippets in doc compile different from stand-alone

2009-07-16 Thread John Mandereau
Le jeudi 16 juillet 2009 à 09:40 -0600, Carl Sorensen a écrit : However, when non-snippet text is changed, added, or removed from the english documentation, no corresponding changes should be made to the translated versions of the documentation. All right, this is clearer. Cheers, John

PATCH: Improved tablature support

2009-07-16 Thread Carl Sorensen
Marc Hohl has completed a patch for improved tablature support. It is available for review at: http://codereview.appspot.com/95059 Please review and comment. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org

Regression test information

2009-07-16 Thread Carl Sorensen
I'd like permission to move the information on regression testing from make test-baseline and make check from the AU to the CG (There's a placeholder there already; section 7). Any concerns about doing this? Carl ___ lilypond-devel mailing list

Re: PATCH: Improved tablature support

2009-07-16 Thread Jonathan Kulp
Carl Sorensen wrote: Marc Hohl has completed a patch for improved tablature support. It is available for review at: http://codereview.appspot.com/95059 Please review and comment. Thanks, Carl I like the features, especially the moderntab clef. Is it best for numbersOnly to be default?

Re: PATCH: Improved tablature support

2009-07-16 Thread Carl Sorensen
On 7/16/09 4:00 PM, Jonathan Kulp jonlancek...@gmail.com wrote: Carl Sorensen wrote: Marc Hohl has completed a patch for improved tablature support. It is available for review at: http://codereview.appspot.com/95059 Please review and comment. Thanks, Carl I like the

Re: PATCH: Improved tablature support

2009-07-16 Thread Carl Sorensen
On 7/16/09 9:56 AM, Carl Sorensen c_soren...@byu.edu wrote: Marc Hohl has completed a patch for improved tablature support. It is available for review at: http://codereview.appspot.com/95059 Please review and comment. Thanks, Marc, Here are some comments. 1) All regression tests

Re: New markup commands: \left-brace \right-brace.

2009-07-16 Thread n . puttock
Reviewers: Patrick McCarty, Message: Thanks for the review, Patrick. On 2009/07/16 03:40:58, Patrick McCarty wrote: http://codereview.appspot.com/8874/diff/2201/3202 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/8874/diff/2201/3202#newcode2625 Line 2625:

Re: New instrument name positioning in Scheme.

2009-07-16 Thread n . puttock
Reviewers: joeneeman, Message: On 2009/07/16 05:52:35, joeneeman wrote: Just one corner case, otherwise lgtm Thanks, Joe. I'll add a convert-ly rule for ly:system-start-text::print, a regtest and NEWS entry before pushing. http://codereview.appspot.com/91119/diff/1/10 File

Re: New markup commands: \left-brace \right-brace.

2009-07-16 Thread n . puttock
Add exported function ly:otf-glyph-count. * use this function to remove hard-coded value in binary search and brace lookup. * normalize type assertion messages * fix potential null dereference in ly:otf-font-glyph-info * tidy formatting http://codereview.appspot.com/8874

Re: PATCH: Improved tablature support

2009-07-16 Thread Jonathan Kulp
Carl Sorensen wrote: So, while I asked Marc to provide documentation, I didn't require it. I did, however, require regtests. As soon as we get the patch applied, we can ask one of the people who is clamoring for improved tab support on -user to get involved in writing the documentation for

Re: PATCH: Improved tablature support

2009-07-16 Thread Carl Sorensen
On 7/16/09 5:54 PM, Jonathan Kulp jonlancek...@gmail.com wrote: Carl Sorensen wrote: So, while I asked Marc to provide documentation, I didn't require it. I did, however, require regtests. As soon as we get the patch applied, we can ask one of the people who is clamoring for improved

Re: New markup commands: \left-brace \right-brace.

2009-07-16 Thread Carl . D . Sorensen
Code looks good to me. I have a couple of optional minor nitpicks. Thanks, Carl http://codereview.appspot.com/8874/diff/5202/4204 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/8874/diff/5202/4204#newcode2623 Line 2623: (ly:font-get-glyph font (string-append

change clef inside a grob-callback?

2009-07-16 Thread Mark Polesky
Is there a way to change the clef from within a grob callback? I'm trying to create an auto-clef-change function that will find the average staff-position within a chord and change the clef if needed. But I'm a little stuck. I found a way to calculate each chord's average staff-position, but

Re: change clef inside a grob-callback?

2009-07-16 Thread Joe Neeman
On Thu, 2009-07-16 at 19:10 -0700, Mark Polesky wrote: Is there a way to change the clef from within a grob callback? Not really. You can change the clef's glyph, but you can't really change the clef's influence on the following notes. Reason being, the NoteHead grobs are created around the same