On Tue, Sep 17, 2019 at 02:49:51PM +0800, Sun Ke wrote:
> Add the test case to check nbd devices.This test case catches regressions
> fixed by commit 92b5c8f0063e4 "nbd: replace kill_bdev() with
> __invalidate_device() again".
>
> Establish the nbd connection.Run two processes.One do mount and umo
On Wed, Sep 11, 2019 at 04:53:43PM +0800, Yi Zhang wrote:
> Add one test to cover NVMe SSD rescan/reset/remove operation during
> IO, the steps found several issues during my previous testing, check
> them here:
> http://lists.infradead.org/pipermail/linux-nvme/2017-February/008358.html
> http://li
On Wed, Sep 11, 2019 at 11:20:21AM -0600, Logan Gunthorpe wrote:
> A number of bug fixes have been submitted to the kernel to
> fix bugs when a controller is removed immediately after it is
> set up. This new test ensures this doesn't regress.
>
> Signed-off-by: Logan Gunthorpe
> Reviewed-by: Sag
On Tue, Sep 10, 2019 at 12:55:06AM +0800, Yi Zhang wrote:
> Signed-off-by: Yi Zhang
> ---
> tests/block/027 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/block/027 b/tests/block/027
> index 0ff9e4c..e818bf7 100755
> --- a/tests/block/027
> +++ b/tests/block/027
>
On Tue, Sep 03, 2019 at 04:17:52PM +0800, Yi Zhang wrote:
> Add one test to cover NVMe SSD rescan/reset/remove operation during
> IO, the steps found several issues during my previous testing, check
> them here:
> http://lists.infradead.org/pipermail/linux-nvme/2017-February/008358.html
> http://li
On Wed, Sep 04, 2019 at 10:49:13AM -0700, Bart Van Assche wrote:
> On 8/8/19 1:05 PM, Bart Van Assche wrote:
> > Hi Omar,
> >
> > This series includes one improvement for the NVMe tests, two improvements
> > for
> > the NVMeOF-multipath tests and version two of the SRP test that triggers a
> > S
On Wed, Sep 04, 2019 at 11:32:29AM +0800, Sun Ke wrote:
> Add the test case to check nbd devices.This test case catches regressions
> fixed by commit 92b5c8f0063e4 "nbd: replace kill_bdev() with
> __invalidate_device() again".
>
> Establish the nbd connection.Run two processes.One do mount and umo
On Mon, Aug 05, 2019 at 04:25:12PM -0700, Bart Van Assche wrote:
> When running blktests with kernel debugging enabled it can happen that
> _find_nvme_loop_dev() returns before the NVMe block device has appeared
> in sysfs. This patch avoids that the NVMe tests fail as follows:
>
> +cat: /sys/bloc
On Thu, Aug 01, 2019 at 03:09:37PM -0700, Bart Van Assche wrote:
Hi, Bart, a few comments.
> This test triggers the task management function handling code in the SRP
> initiator and target drivers. This test verifies the following kernel
> patch: fd5614124406 ("scsi: RDMA/srp: Fix a sleep-in-inva
On Wed, Jul 17, 2019 at 11:12:47AM -0600, Logan Gunthorpe wrote:
> Changes since v1:
> * Use second sed expression instead of another call to grep
>in _filter_discovery() for Patch 2 (per Omar)
> * Redirect error output to $FULL in for nvme/018 in Patch 7
>(Per Johannes)
> * Rework _have
On Fri, Jul 12, 2019 at 05:57:30PM -0600, Logan Gunthorpe wrote:
> Hi,
>
> This patchset cleans up a number of issues and pain points
> I've had with getting the nvme blktests to pass and run cleanly.
>
> The first three patches are meant to fix the Generation Counter
> issue that's been discusse
On Fri, Jul 12, 2019 at 05:57:32PM -0600, Logan Gunthorpe wrote:
> Comparing the entire output of nvme-cli for discovery is fragile
> and error prone as things change. There's already been the
> long standing issue of the generation counter mismatching
> and also some versions of nvme-cli print an
if (waitqueue_active(&ws->wait)) {
> > - int o = atomic_read(&sbq->wake_index);
> > -
> > - if (wake_index != o)
> > - atomic_cmpxchg(&sbq->wake_index, o, wake_index);
> > + if (wake_index != atomic_read(&sbq->wake_index))
> > + atomic_set(&sbq->wake_index, wake_index);
This hunk used to imply a memory barrier and no longer does. I don't
think that's a problem, though.
Reviewed-by: Omar Sandoval
On Tue, Jun 11, 2019 at 07:35:06AM +0800, Bob Liu wrote:
> Reproduce the hang fixed by
> 7996a8b5511a ("blk-mq: fix hang caused by freeze/unfreeze sequence").
Thanks, applied.
On Tue, Jun 18, 2019 at 04:09:26PM -0700, Bart Van Assche wrote:
> On 6/9/19 11:14 AM, Theodore Ts'o wrote:
> > I recently noticed that block/002 from blktests started failing:
> >
> > root@kvm-xfstests:~# cd blktests/
> > root@kvm-xfstests:~/blktests# ./check block/002
> > block/002 (remove a dev
On Fri, May 31, 2019 at 10:59:12AM +0900, Shin'ichiro Kawasaki wrote:
> As a preparation for the zone mapping test case, add several helper
> functions. _find_last_sequential_zone() and
> _find_sequential_zone_in_middle() help to select test target zones.
> _test_dev_is_logical() checks TEST_DEV is
On Fri, May 31, 2019 at 10:59:13AM +0900, Shin'ichiro Kawasaki wrote:
> Add the test case to check zones sector mapping of logical devices. This
> test case requires that such a logical device be specified in TEST_DEVS
> in config. The test is skipped for devices that are identified as not
> logica
On Mon, May 27, 2019 at 07:48:35PM +0800, Peng Wang wrote:
> From: Peng Wang
>
> Use the preferred KMEM_CACHE helper for brevity.
Reviewed-by: Omar Sandoval
> Signed-off-by: Peng Wang
> ---
> block/blk-core.c | 3 +--
> block/blk-ioc.c | 3 +--
> 2 files cha
On Sat, May 25, 2019 at 04:42:11PM +0300, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov
>
> Commit 4bc6339a583cec650b05 ("block: move blk_stat_add() to
> __blk_mq_end_request()") moved blk_stat_add(), so now it's called after
> blk_update_request(), which zeroes rq->__data_len. Without l
On Fri, Apr 26, 2019 at 10:39:37AM +0800, Ming Lei wrote:
> When T10 verification fails, the error code of BLK_STS_PROTECTION
> may not be propagated to user space, see mpage_end_io().
>
> So seems the only reliable way for detecting the failure is to
> check dmesg.
>
> Cc: Martin K . Petersen
>
On Sat, Apr 06, 2019 at 10:27:22PM +0800, Xiao Liang wrote:
> When system has large count of cpus(eg. 96), the test failed as aio-nr over
> aio-max-nr limitation.
>
> This patch continues to use 1024 as default iodepth, but change it if
> iodepth*$(nproc) > aio-max-nr.
Thank you, applied.
On Mon, Apr 15, 2019 at 09:22:29AM +0800, Ming Lei wrote:
> It is observed that nvme/012 may take ~17 minutes to complete on aarch64,
> even worse it may trigger IO timeout on nvme-loop.
>
> Eric and Dave replied that it is because of too small log size on small
> disk.
>
> So pass '-l size=32m'
On Mon, Apr 01, 2019 at 11:38:00AM +0800, Xiao Liang wrote:
> When system has large count of cpus(eg. 96), the test failed as aio-nr over
> aio-max-nr limitation.
>
> This patch continues to use 1024 as default iodepth, but change it if
> iodepth*$(nproc) > aio-max-nr.
>
> Signed-off-by: Xiao Lia
On Fri, Mar 29, 2019 at 03:14:32PM -0700, Dennis Zhou wrote:
> Previously, the test was broken as "$fio_jobs" was considered as a
> string instead of additional parameters. This is fixed here.
>
> Second, there was an issue with earlier kernels when request lists
> existed such that request_queues
On Mon, Mar 25, 2019 at 12:58:47PM -0600, Jens Axboe wrote:
> On 3/25/19 12:56 PM, Omar Sandoval wrote:
> > On Mon, Mar 25, 2019 at 10:22:50AM -0600, Jens Axboe wrote:
> >> We now wrap sbitmap waitqueues in an active counter, so we can avoid
> >> iterating wakeups u
On Mon, Mar 25, 2019 at 10:22:50AM -0600, Jens Axboe wrote:
> We now wrap sbitmap waitqueues in an active counter, so we can avoid
> iterating wakeups unless we have waiters there. This works as long as
> everyone that's manipulating the waitqueues use the proper helpers. For
> the tag wait case fo
ing like this?
Thread 1Thread 2
sbitmap_queue_get()
...
write to request _
sbitmap_queue_clear() \
\sbitmap_queue_get()
\__ observes write
If so, you can add
Reviewed-by: Omar Sandoval
On Fri, Mar 22, 2019 at 04:12:28PM +0800, Yi Zhang wrote:
> Some kernel may not have zoned sysfs node, e.g. RHEL7, checking if
> it exists first in _test_dev_is_zoned.
>
> Signed-off-by: Yi Zhang
Applied, thanks.
On Fri, Mar 22, 2019 at 10:23:01AM +0800, Dongli Zhang wrote:
>
>
> On 3/22/19 7:26 AM, Omar Sandoval wrote:
> > On Fri, Mar 15, 2019 at 10:00:27AM +0800, Dongli Zhang wrote:
> >>
> >>
> >> On 3/15/19 1:55 AM, Omar Sandoval wrote:
> >>>
On Fri, Mar 22, 2019 at 09:04:54AM +0800, Ming Lei wrote:
> On Thu, Mar 21, 2019 at 03:36:26PM -0700, Omar Sandoval wrote:
> > On Mon, Mar 11, 2019 at 01:55:05PM -0700, Omar Sandoval wrote:
> > > On Tue, Mar 05, 2019 at 09:50:26AM +0800, Ming Lei wrote:
> > > > Ad
On Fri, Mar 15, 2019 at 10:00:27AM +0800, Dongli Zhang wrote:
>
>
> On 3/15/19 1:55 AM, Omar Sandoval wrote:
> > On Thu, Mar 14, 2019 at 07:45:17PM +0800, Dongli Zhang wrote:
> >> loop/001 does not test whether all partitions are removed successfully
> >> duri
On Mon, Mar 11, 2019 at 01:55:05PM -0700, Omar Sandoval wrote:
> On Tue, Mar 05, 2019 at 09:50:26AM +0800, Ming Lei wrote:
> > Add one test to cover changes on block passthrough IO interface,
> > such as blk_rq_map_user(), blk_rq_map_user_iov(), blk_rq_unmap_user()
> >
On Thu, Mar 14, 2019 at 12:46:33PM +0900, Shin'ichiro Kawasaki wrote:
> Since SCSI scanning occurs asynchronously, the kernel function
> blk_revalidate_disk_zones() called from sd_revalidate_disk() may be
> executed while write I/Os are ongoing. As a result,
> blk_revalidate_disk_zones() must not c
On Wed, Mar 13, 2019 at 03:13:17PM +0800, Xiao Liang wrote:
> Signed-off-by: Xiao Liang
> ---
> tests/nvme/002 | 2 +-
> tests/nvme/003 | 2 +-
> tests/nvme/004 | 2 +-
> tests/nvme/015 | 2 +-
> tests/nvme/018 | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
Thanks, applied.
On Thu, Mar 14, 2019 at 07:45:17PM +0800, Dongli Zhang wrote:
> loop/001 does not test whether all partitions are removed successfully
> during loop device partition scanning. As a result, the regression
> introduced by 0da03cab87e6 ("loop: Fix deadlock when calling
> blkdev_reread_part()") can not
On Wed, Mar 13, 2019 at 03:05:11PM +0800, Xiao Liang wrote:
Applied, thanks!
> Signed-off-by: Xiao Liang
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 0c354a2..71e27c3 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -33
On Wed, Mar 13, 2019 at 02:41:05PM +0800, Xiao Liang wrote:
Thanks for the fix! A couple of comments below.
> Signed-off-by: Xiao Liang
> ---
> common/rc | 2 +-
> tests/nvme/002 | 2 +-
> tests/nvme/003 | 2 +-
> tests/nvme/004 | 2 +-
> tests/nvme/015 | 2 +-
> tests/nvme/018 | 2 +-
> 6
On Tue, Mar 05, 2019 at 09:50:26AM +0800, Ming Lei wrote:
> Add one test to cover changes on block passthrough IO interface,
> such as blk_rq_map_user(), blk_rq_map_user_iov(), blk_rq_unmap_user()
> and blk_rq_map_kern().
>
> Signed-off-by: Ming Lei
> ---
> tests/block/029 | 111
> +
On Tue, Mar 05, 2019 at 11:33:19AM +0800, Yi Zhang wrote:
> The return value of a failing test was masked by the zoned test check.
> Make sure to return either the original or zoned run failed value.
>
> Fixes: e840e15 ("config: Introduce RUN_ZONED_TESTS variable and
> CAN_BE_ZONED flag")
> Signed
On Tue, Mar 05, 2019 at 02:24:44PM +0900, Shin'ichiro Kawasaki wrote:
> This patch series fixes test failures found in the zbd test group when run on
> partition devices. The failure cause is a block device sysfs attributes access
> problem if the target device is a partition.
>
> This series rese
On Mon, Mar 04, 2019 at 04:15:01PM +0800, Ming Lei wrote:
> Add one test to cover changes on block passthrough IO interface,
> such as blk_rq_map_user(), blk_rq_map_user_iov(), blk_rq_unmap_user()
> and blk_rq_map_kern().
>
> Signed-off-by: Ming Lei
> ---
> tests/block/029 | 111
> +
> Do not refer sysfs nr_zones parameter for the partition devices. Instead,
> calculate the expected nr_zones from device capacity and zone size.
Reviewed-by: Omar Sandoval
> Signed-off-by: Shin'ichiro Kawasaki
> ---
> tests/zbd/rc | 8 ++--
> 1 file changed, 6 insertions
On Wed, Feb 20, 2019 at 05:12:30PM +0900, Shin'ichiro Kawasaki wrote:
> To control test conditions unique for partition devices, introduce the
> _test_dev_is_partition() helper function. Refer TEST_DEV_PART_SYSFS
> variable to tell if the TEST_DEV is a partition device or not.
Rev
On Wed, Feb 20, 2019 at 05:12:29PM +0900, Shin'ichiro Kawasaki wrote:
> When partition devices are specified in TEST_DEV, TEST_DEV_SYSFS
> variable points to the sysfs paths of holder devices of the partition
> devices (e.g., /sys/block/sda). This sysfs path is different from the
> sysfs path of th
On Fri, Mar 01, 2019 at 03:59:53PM +, Chaitanya Kulkarni wrote:
> Hi Omar,
>
> Everything looks good.
>
> On 2/27/19, 1:50 PM, "Omar Sandoval" wrote:
>
> On Wed, Feb 20, 2019 at 08:42:40PM -0800, Chaitanya Kulkarni wrote:
> > Hi Omar,
>
On Fri, Feb 22, 2019 at 12:00:43AM +, Chaitanya Kulkarni wrote:
> On 02/21/2019 07:04 AM, Theodore Y. Ts'o wrote:
> > On Wed, Feb 20, 2019 at 11:35:00AM -0800, Omar Sandoval wrote:
> >>> It should fail on older cli versions, we want latest cli/tools to be
>
On Wed, Feb 20, 2019 at 08:42:40PM -0800, Chaitanya Kulkarni wrote:
> Hi Omar,
> This is a small patch series which follows the blktests coding
> style format as pointed out by Bart. Also minimizes the overall
> code for the review.
>
> -Regards,
> Chaitanya
>
> Changes since V1:-
> 1. Add testca
On Wed, Feb 20, 2019 at 05:38:06PM +0800, zhengbin wrote:
> When i test blktests, loop/004 will be fail. The Key test steps
> are as follows:
> 1. losetup -f --show /dev/sda
> 2. src/loblksize /dev/loop0 4096
>
> step 1 will create /dev/loop0. after that, daemon systemd-udevd
> will visit and clo
On Wed, Feb 20, 2019 at 06:28:50PM +, Chaitanya Kulkarni wrote:
> On 02/20/2019 10:04 AM, Omar Sandoval wrote:
> > On Tue, Feb 19, 2019 at 12:23:53PM -0800, Chaitanya Kulkarni wrote:
> >> Signed-off-by: Chaitanya Kulkarni
> >> ---
>
On Wed, Feb 20, 2019 at 06:19:58PM +, Chaitanya Kulkarni wrote:
> On 02/20/2019 10:11 AM, Omar Sandoval wrote:
> > On Tue, Feb 19, 2019 at 03:28:18PM -0800, Chaitanya Kulkarni wrote:
> >> ---
> >> tests/nvme/021 | 15 ++-
> >> tests/nvme/0
On Wed, Feb 20, 2019 at 05:12:26PM +0900, Shin'ichiro Kawasaki wrote:
> This patch series addresses two incorrect test failures found in the zbd test
> group. Two other problems with the check script and the common rc script are
> also fixed.
>
> More specifically,
> * Patch 1 addresses an incorre
On Tue, Feb 19, 2019 at 03:28:18PM -0800, Chaitanya Kulkarni wrote:
> ---
> tests/nvme/021 | 15 ++-
> tests/nvme/021.out | 1 -
> 2 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/tests/nvme/021 b/tests/nvme/021
> index 8e9512a..f204a2f 100755
> --- a/tests/nvme
On Tue, Feb 19, 2019 at 12:23:53PM -0800, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni
> ---
> tests/nvme/002.out | 4996
> ++--
> 1 file changed, 2498 insertions(+), 2498 deletions(-)
>
> diff --git a/tests/nvme/002.out b/tests/n
On Wed, Feb 13, 2019 at 01:07:54PM -0500, Theodore Y. Ts'o wrote:
> This should probably be folded into other testing proposals but I'd
> like to discuss ways that we can improve storage and file systems
> testing. Specifically,
>
> 1) Adding some kind of "smoke test" group. The "quick" group in
On Thu, Feb 14, 2019 at 01:10:40PM +0100, Lukas Czerner wrote:
> On Wed, Feb 13, 2019 at 01:07:54PM -0500, Theodore Y. Ts'o wrote:
> >
> > 2) Documenting what are known failures should be for various tests on
> > different file systems and kernel versions. I think we all have our
> > own way of e
On Wed, Feb 13, 2019 at 10:54:04AM -0800, Bart Van Assche wrote:
> On Wed, 2019-02-13 at 10:43 -0800, Omar Sandoval wrote:
> > On Wed, Feb 13, 2019 at 10:11:14AM -0800, Bart Van Assche wrote:
> > > - Is it acceptable that patches get accepted in the blktests repository
> &
On Wed, Feb 13, 2019 at 10:11:14AM -0800, Bart Van Assche wrote:
> On Wed, 2019-02-06 at 05:21 +, Chaitanya Kulkarni wrote:
> > For storage track, we would like to propose a session dedicated to
> > blktests. It is a great
> > opportunity for the storage developers to gather and have a discuss
Hi,
I'd like to attend LSF/MM to discuss:
- Blktests (see Chaitanya's topic proposal [1], which we hope to present
together).
- Core block layer work.
- Filesystem topics, especially relating to Btrfs.
Thanks!
1: https://www.spinics.net/lists/linux-block/msg36761.html
On Fri, Jan 18, 2019 at 06:44:46PM +0900, Shin'ichiro Kawasaki wrote:
> To analyze dd command failures found by blktests, need to confirm dd
> command options. Introduce the helper function which executes dd and
> records dd command options in FULL file for quick analysis.
>
> Reviewed-by: Chaitan
On Fri, Jan 18, 2019 at 06:44:45PM +0900, Shin'ichiro Kawasaki wrote:
> These optional functions can be defined by a test case script. When
> defined and TEST_DEVS is empty, the fallback_device() is executed before
> runing the test case. The fallback_device() function intializes a virtual
> device
On Fri, Jan 18, 2019 at 06:44:44PM +0900, Shin'ichiro Kawasaki wrote:
> Define CAN_BE_ZONED=1 in block/005, block/006, block/010, block/011,
> block/016, block/017, block/020, block/021 and block/023 as all these
> tests should execute without any problem against null_blk with zoned
> mode enabled
On Fri, Jan 18, 2019 at 06:44:43PM +0900, Shin'ichiro Kawasaki wrote:
> For a random write pattern to a zoned block device, fio requires --direct=1
> and --zonemode=zbd options as well as deadline I/O scheduler to be
> specified. Specify these options and set the I/O scheduler if the target
> devic
On Fri, Jan 18, 2019 at 06:44:41PM +0900, Shin'ichiro Kawasaki wrote:
> To allow running tests using a null_blk device with the zoned mode
> disabled (current setup) as well as enabled, introduce the config
> the RUN_ZONED_TESTS config variable and the per-test flag CAN_BE_ZONED.
>
> RUN_ZONED_TES
On Mon, Jan 21, 2019 at 01:02:03PM +0100, Jan Kara wrote:
> Add test for changing capacity of a loop device when a filesystem with
> non-default block size is mounted on it. This is a regression test for
> "blockdev: Fix livelocks on loop device".
>
> Signed-off-by: Jan Kara
Thanks, Jan, applied
On Tue, Jan 22, 2019 at 04:21:04PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: "Ed L. Cashin"
> Cc: Jens Axboe
On Thu, Jan 17, 2019 at 11:44:25AM +0800, Ming Lei wrote:
> Use scsi_debug's dif/dix to cover block layer's integrity function
> test, then it can serve as block integrity regeression test.
>
> Signed-off-by: Ming Lei
> ---
> tests/block/028 | 42 ++
>
On Thu, Jan 10, 2019 at 06:37:13PM +0900, Shin'ichiro Kawasaki wrote:
> Fio zbd zone mode is necessary for zoned block devices. Introduce the
> helper function _have_fio_zbd_zonemode() to check that the installed
> fio version supports the option --zonemode=zbd.
Testing version numbers is fragile.
On Thu, Jan 10, 2019 at 06:37:12PM +0900, Shin'ichiro Kawasaki wrote:
> set_scheduler() function defined in common/multipath-over-rdma is useful
> to set up a specific IO scheduler not only for multipath tests but also
> for zoned block device tests. Move this function to common/rc to allow
> its u
On Thu, Jan 10, 2019 at 06:37:09PM +0900, Shin'ichiro Kawasaki wrote:
> The current blktests infrastucture and test cases do not support zoned block
> devices and no specific test cases exist to test these block devices special
> features (zone report and reset, sequential write constraint). This p
e and remove LUNs)
> > runtime 4.067s ...
> > common/cgroup: line 25: CGROUP2_DIR: unbound variable
> >
> > Is this a known issue?
>
> Hi Josef,
>
> Had you noticed this e-mail?
>
> Thanks,
>
> Bart.
Hey, Bart, I just pushed a fix for this:
com
On Thu, Dec 20, 2018 at 12:18:24PM -0600, Dennis Zhou wrote:
> Hi,
>
> v2:
> There was a minor typo in 0001 pointed out by Omar which I fixed here.
> 0002 was refactored to use common/scsi_debug. I also rebased onto the
> top of osandov#josef changing the test from block/022 -> block/027.
>
> Fro
On Wed, Dec 05, 2018 at 10:34:03AM -0500, Josef Bacik wrote:
> In order to test io.latency and other cgroup related things we need some
> supporting helpers to setup and tear down cgroup2. This adds support
> for checking that we can even configure cgroup2 things, set them up if
> need be, and the
del(wait_entry) type operations, and
> still work with the optimized wakeup checking.
>
> Second one converts kyber to use it, fixing a hang with domain tokens.
Lame, I should've caught this on the original patch. For the series:
Reviewed-by: Omar Sandoval
On Thu, Dec 13, 2018 at 01:28:44PM -0500, Dennis Zhou wrote:
> This test exposed a race condition with shutting down a request_queue
> and the new blkg association. The issue ended up being that while the
> request_queue will just start failing requests, blkg destruction sets
> the q->root_blkg to
On Wed, Dec 12, 2018 at 06:09:58PM -0500, Dennis Zhou wrote:
> This is a prep patch for a new test that will race blkg association and
> request_queue cleanup. As blkg association is a underlying cgroup io
> controller feature, we need the ability to check if the controller is
> available.
>
> Sig
On Wed, Dec 12, 2018 at 04:58:53PM -0500, Josef Bacik wrote:
> There have been a few issues with turning wbt on and off while IO is in
> flight, so add a test that just does some random rw IO and has a
> background thread that toggles wbt on and off.
>
> Signed-off-by: Josef Bacik
> ---
> tests/
On Wed, Dec 12, 2018 at 04:38:24PM -0500, Josef Bacik wrote:
> There's currently no tests to verify wbt is working properly, this patch
> fixes that. Simply run a varied workload and measure the read latencies
> with wbt off, and then turn it on and verify that the read latencies go
> down.
>
> S
On Wed, Dec 12, 2018 at 10:45:52AM -0500, Josef Bacik wrote:
> The original test just did 4g of IO and figured out how long it took to
> determine if io.latency was working properly. However this can run
> really long on slow disks, so instead run for a constant time and check
> the bandwidth of t
On Mon, Dec 17, 2018 at 02:51:08PM +0900, Damien Le Moal wrote:
> Fix strncpy length to "sizeof(buf) - 1" to avoid the compiler warning:
> cc -O2 -Wall -Wshadow -o sg/syzkaller1 sg/syzkaller1.c
> sg/syzkaller1.c: In function ‘syz_open_dev.constprop’:
> sg/syzkaller1.c:204:16: warning: ‘strncpy’ s
On Wed, Dec 05, 2018 at 10:34:02AM -0500, Josef Bacik wrote:
> v1->v2:
> - dropped my python library, TIL about jq.
> - fixed the spelling mistakes in the test.
>
> -- Original message --
>
> This patchset is to add a test to verify io.latency is working properly, and
> to
> add all the supporti
On Thu, Nov 15, 2018 at 12:00:17PM +0800, Ming Lei wrote:
> This test covers the following two issues:
>
> 1) discard sector need to be aligned with logical block size
>
> 2) make sure 'sector_t' instead of 'unsigned int' is used when comparing
> with discard sector size
>
> Signed-off-by: Ming
From: Omar Sandoval
We need to ignore bits in the cleared mask when iterating over all set
bits.
Fixes: ea86ea2cdced ("sbitmap: ammortize cost of clearing bits")
Signed-off-by: Omar Sandoval
---
include/linux/sbitmap.h | 10 ++
1 file changed, 6 insertions(+), 4 deletion
On Mon, Dec 03, 2018 at 02:56:17PM -0700, Jens Axboe wrote:
> When we are iterating the set bits in a word, we also need to factor in
> the cleared bits. Don't call fn() unless the bit is also not set in
> the cleared word.
>
> Fixes: ea86ea2cdced ("sbitmap: ammortize cost of clearing bits")
> Sig
On Fri, Nov 30, 2018 at 02:13:54PM -0700, Jens Axboe wrote:
> We only need the request fields and the end_io time if we have
> stats enabled, or if we have a scheduler attached as those may
> use it for completion time stats.
Reviewed-by: Omar Sandoval
> Signed-off-by
On Fri, Nov 30, 2018 at 01:10:47PM -0700, Jens Axboe wrote:
> On 11/30/18 1:03 PM, Omar Sandoval wrote:
> > On Fri, Nov 30, 2018 at 09:01:17AM -0700, Jens Axboe wrote:
> >> sbitmap maintains a set of words that we use to set and clear bits, with
> >> each bit represen
users of sbitmap with waiting, blk-mq-tag and iSCSI.
Reviewed-by: Omar Sandoval
> Signed-off-by: Jens Axboe
> ---
> block/blk-mq-tag.c | 11
> drivers/target/iscsi/iscsi_target_util.c | 12 +
> include/linux/sbitmap.h
On Fri, Nov 30, 2018 at 09:01:17AM -0700, Jens Axboe wrote:
> sbitmap maintains a set of words that we use to set and clear bits, with
> each bit representing a tag for blk-mq. Even though we spread the bits
> out and maintain a hint cache, one particular bit allocated will end up
> being cleared i
On Fri, Nov 30, 2018 at 04:32:40AM -0500, Huijin Park wrote:
> From: "huijin.park"
>
> This patch changes the 'sectors' type to an u64.
> In 32 bit system, the 'sectors' can accumulate up to about 2TiB.
> If a 32 bit system makes i/o over 2TiB while running,
> the 'sectors' will overflow.
> As a
On Thu, Nov 29, 2018 at 01:00:25PM -0700, Jens Axboe wrote:
> sbitmap maintains a set of words that we use to set and clear bits, with
> each bit representing a tag for blk-mq. Even though we spread the bits
> out and maintain a hint cache, one particular bit allocated will end up
> being cleared i
> bit looping, and since we're fetching this cacheline, we may as well
> check the whole word from the start.
Reviewed-by: Omar Sandoval
> Signed-off-by: Jens Axboe
>
> ---
>
> Since v1:
>
> - Reset alloc_hint if we loop for the round-robin case
> - Updat
On Thu, Nov 29, 2018 at 12:34:12PM -0700, Jens Axboe wrote:
> If we aren't forced to do round robin tag allocation, just use the
> allocation hint to find the index for the tag word, don't use it for the
> offset inside the word.
Maybe also add "We're already fetching that cache line, so we might
On Tue, Nov 27, 2018 at 04:59:14PM -0700, Jens Axboe wrote:
> On 11/27/18 4:49 PM, Jens Axboe wrote:
> > On 11/27/18 4:31 PM, Omar Sandoval wrote:
> >> On Mon, Nov 26, 2018 at 09:35:50AM -0700, Jens Axboe wrote:
> >>> Do it for the nr_hw_queues == 1 case, but
On Tue, Nov 27, 2018 at 04:49:27PM -0700, Jens Axboe wrote:
> On 11/27/18 4:31 PM, Omar Sandoval wrote:
> > On Mon, Nov 26, 2018 at 09:35:50AM -0700, Jens Axboe wrote:
> >> Do it for the nr_hw_queues == 1 case, but only do it for the multi queue
> >> case if we have re
On Mon, Nov 26, 2018 at 09:35:55AM -0700, Jens Axboe wrote:
> If we are issuing a list of requests, we know if we're at the last one.
> If we fail issuing, ensure that we call ->commits_rqs() to flush any
> potential previous requests.
One comment below, otherwise
Reviewed-
On Mon, Nov 26, 2018 at 09:35:54AM -0700, Jens Axboe wrote:
> We need this for blk-mq to kick things into gear, if we told it that
> we had more IO coming, but then failed to deliver on that promise.
Who converted this one? Oh yeah, it was me...
Reviewed-by: Omar Sandoval
> Signed-off
On Mon, Nov 26, 2018 at 09:35:53AM -0700, Jens Axboe wrote:
> We need this for blk-mq to kick things into gear, if we told it that
> we had more IO coming, but then failed to deliver on that promise.
Reviewed-by: Omar Sandoval
But also cc'd the virtio-blk maintainers.
> Signe
responsible for flushing pending requests, if it uses bd->last to
> optimize that part. This works like before, no changes there.
Reviewed-by: Omar Sandoval
> Signed-off-by: Jens Axboe
> ---
> include/linux/blk-mq.h | 10 ++
> 1 file changed, 10 insertions(+)
>
>
On Mon, Nov 26, 2018 at 09:35:50AM -0700, Jens Axboe wrote:
> Do it for the nr_hw_queues == 1 case, but only do it for the multi queue
> case if we have requests for multiple devices in the plug.
>
> Signed-off-by: Jens Axboe
> ---
> block/blk-core.c | 1 +
> block/blk-mq.c | 7 +++
On Thu, Nov 15, 2018 at 12:00:17PM +0800, Ming Lei wrote:
> This test covers the following two issues:
>
> 1) discard sector need to be aligned with logical block size
>
> 2) make sure 'sector_t' instead of 'unsigned int' is used when comparing
> with discard sector size
>
> Signed-off-by: Ming
On Mon, Nov 26, 2018 at 10:17:16AM +0800, Ming Lei wrote:
> This patch pulls the trigger for multi-page bvecs.
Reviewed-by: Omar Sandoval
> Signed-off-by: Ming Lei
> ---
> block/bio.c | 22 +++---
> fs/iomap.c | 4 ++--
> fs/xfs
1 - 100 of 795 matches
Mail list logo
