From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Suppress the following warning displayed on building 32bit (i686) kernel.
===
...
CC [M] fs/btrfs/extent_io.o
fs/btrfs/extent_io.c: In function
Hi Yang,
On 2014/12/26 10:32, Dongsheng Yang wrote:
Hi Satoru,
I saw your mail of [BUG] Quota Ignored On write problem still exist with 3.16-rc5
http://news.gmane.org/find-root.php?message_id=53C8DEB0.1060404%40jp.fujitsu.com in gmane.
I guess this patch will fix the problem you mentioned.
Hi Russel and all,
On 2014/12/24 10:02, Russell Coker wrote:
I've attached the kernel message log that I get after booting kernel 3.16.7
from Debian/Unstable. This is the kernel branch that will go into
Debian/Jessie so it's important to get it fixed.
Below has the start of the errors, the
Hi Russel, Petr and all
# Add Timofey to the Cc list.
On 2014/12/24 10:02, Russell Coker wrote:
I've attached the kernel message log that I get after booting kernel 3.16.7
from Debian/Unstable. This is the kernel branch that will go into
Debian/Jessie so it's important to get it fixed.
On 2014/12/18 5:14, Goffredo Baroncelli wrote:
Add -v -q switches to mkfs.btrfs, to control the verbosity of mkfs.btrfs.
Signed-off-by: Goffredo Baroncelli kreij...@inwind.it
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
mkfs.c | 16 ++--
1 file changed
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
mkfs.c | 3 ++-
utils.c | 7 ---
utils.h | 2 +-
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/mkfs.c b/mkfs.c
index a5f19cc..042d12e 100644
--- a/mkfs.c
+++ b/mkfs.c
@@ -1638,7 +1638,8 @@ int main(int
.
The code is goods. However, I have a comment to the description.
In this case, describing the purpose of this patch is better.
I consider your purpose is to use fs_uuid after make_btrfs()
when user doesn't passed -U option.
Anyway,
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Thanks
On 2014/12/25 10:16, Gui Hecheng wrote:
The check_arg_type() function does quite generic thing,
move it to utils.c.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
cmds-filesystem.c | 32
, '%s' is not a block device\n, av[optind]);
fprintf(stderr, ERROR: '%s' is ...) is better since
other error messages in btrfs-progs have this convention.
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Thanks,
Satoru
+ print_usage();
+ }
+
info
Hi Goffredo,
On 2014/12/23 4:07, Goffredo Baroncelli wrote:
On 12/22/2014 12:34 PM, Satoru Takeuchi wrote:
On 2014/12/22 3:07, Goffredo Baroncelli wrote:
Change a spagetti-style code (there are some interlaced gotos) to
a more modern style...
This patch removes also some #define from
Hi Gui,
On 2014/12/23 10:59, Gui Hecheng wrote:
On Mon, 2014-12-22 at 19:39 +0900, Satoru Takeuchi wrote:
Sorry, I forgot to add Signed-off-by line.
---
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
notused is not necessary. Set 1 to the first entry is enough.
Hi Satoru,
Actually
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
notused is not necessary. Set 1 to the first entry is enough.
Signed-off-by: Takeuchi Satoru takeuchi_sat...@jp.fujitsu.com
Cc: Gui Hecheng guihc.f...@cn.fujitsu.com
---
I once submit the similar patch to btrfs-progs.
Then Gui Hecheng tell me
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
notused is not necessary. Set 1 to the first entry is enough.
---
ioctl.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ioctl.h b/ioctl.h
index 2c2c7c1..c377b96 100644
--- a/ioctl.h
+++ b/ioctl.h
@@ -474,8 +474,7
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
There are 25 enums in btrfs-progs and only two of them use
lower case letters for the name of elements. Capitalize
them to readability.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
cmds-property.c | 18
Sorry, I forgot to add Signed-off-by line.
---
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
notused is not necessary. Set 1 to the first entry is enough.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
ioctl.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions
On 2014/12/22 3:07, Goffredo Baroncelli wrote:
Change a spagetti-style code (there are some interlaced gotos) to
a more modern style...
This patch removes also some #define from utils.h, which define
constants used only in cmds-filesystems.c . Instead an enum
is used locally in
On 2014/12/19 22:36, David Sterba wrote:
On Fri, Dec 19, 2014 at 06:56:43PM +0900, Satoru Takeuchi wrote:
+There are some options to set unit. See the description of *df* subcommand
+from '-b' option to '-t' option.
The unit options exist only for very few subcommands so I found it more
Hi,
On 2014/12/22 6:32, Robert White wrote:
On 12/21/2014 08:32 AM, Charles Cazabon wrote:
Hi, Robert,
Thanks for the response. Many of the things you mentioned I have tried, but
for completeness:
Have you taken SMART (smartmotools etc) to these disks
There are no errors or warnings from
-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Thanks,
Satoru
---
cmds-check.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/cmds-check.c b/cmds-check.c
index 3e7a4eb..aa47984 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -2302,7 +2302,7 @@ static int
)/or \'E\'(EiB)/ is better.
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Thanks,
Satoru
+
If \'max' is passed, the filesystem will occupy all available space on the
device devid.
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body
Hi,
Sorry for late reply. Let me ask some questions.
On 2014/12/17 11:42, Charles Cazabon wrote:
Hi,
I've been running btrfs for various filesystems for a few years now, and have
recently run into problems with a large filesystem becoming *really* slow for
basic reading. None of the
://patchwork.kernel.org/patch/5499981/
Btrfs: fix a warning of qgroup account on shared extents
Signed-off-by: Liu Bo bo.li@oracle.com
Tested-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
V4 also passed my test,
Thanks,
Satoru
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
a clang dead-judgement warning in disk-io.c.
btrfs-progs: Remove a unused function root_gtp_mask().
btrfs-progs: Remove a unused function offset_to_bitmap()
btrfs-progs: Remove deprecated _BSD_SOURCE macro.
All these patches looks good to me.
Reviewed-by: Satoru Takeuchi takeuchi_sat
.
...
===
I consider it can prevent mistakes caused by further changes.
This patch seems to already be in devel/integration-20141218.
Here is the patch example.
---
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Subject: [PATCH] btrfs-progs: Cleanup
Hi David,
On 2014/12/18 23:27, David Sterba wrote:
Signed-off-by: David Sterba dste...@suse.cz
---
Documentation/btrfs-filesystem.txt | 28
1 file changed, 28 insertions(+)
diff --git a/Documentation/btrfs-filesystem.txt
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
Tested with dev/integration-20141218 + this patch
---
cmds-fi-disk_usage.c | 8
cmds-filesystem.c| 8
utils.h | 3 +++
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/cmds-fi-disk_usage.c
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Enhance the document of btrfs property as follows.
- Add the description about the candidates of name.
- Enrich the description of object.
- Fix typos and some redundancy.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Reported
(2014/12/17 17:14), Liu Bo wrote:
run_most is not used anymore.
Signed-off-by: Liu Bo bo.li@oracle.com
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Thanks,
Satoru
---
fs/btrfs/extent-tree.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs
-off-by: Liu Bo bo.li@oracle.com
Reviewed-by: Eryu Guan eg...@redhat.com
It looks good to me.
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Tested-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
* Test result
** The latest upstream kernel without your patch
Failed
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Date: Thu, 18 Dec 2014 14:35:22 +0900
@tmp is freed even if its allocation fails.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
cmds-property.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
When / is Btrfs, btrfs property subcommand / regards it
as non-root by mistake.
check_is_root() regards @object as a file system root if
the following two conditions are satisfied.
a) Both @object and its parent directory are Btrfs object
On 2014/12/18 16:03, Gui Hecheng wrote:
On Thu, 2014-12-18 at 15:09 +0900, Satoru Takeuchi wrote:
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Date: Thu, 18 Dec 2014 14:35:22 +0900
@tmp is freed even if its allocation fails.
Signed-off-by: Satoru Takeuchi takeuchi_sat
On 2014/12/18 16:09, Gui Hecheng wrote:
On Thu, 2014-12-18 at 15:42 +0900, Satoru Takeuchi wrote:
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
When / is Btrfs, btrfs property subcommand / regards it
as non-root by mistake.
check_is_root() regards @object as a file system root
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
When / is Btrfs, btrfs property subcommand / regards it
as non-root by mistake.
check_is_root() regards @object as a file system root if
the following two conditions are satisfied.
a) Both @object and its parent directory are Btrfs object
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
As Chris reported at the following mail, although
btrfs property has its own manpage, man 8 btrfs-property,
there is no explanation about it in man 8 btrfs.
https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg40134.html
Signed-off
Hi,
(2014/12/16 18:52), Joe Doliner wrote:
Using `btrfs subvolume show path` I can get information about what a
subvolume's parent is by uuid.
I'd like to use that information to perform a find-new between the
subvolume and its parent. To do that though I need the path of the
parent and I'm not
Hi Liu,
(2014/12/16 21:10), Eryu Guan wrote:
On Tue, Dec 16, 2014 at 05:43:24PM +0800, Liu Bo wrote:
This is a regression test of
'commit fcebe4562dec (Btrfs: rework qgroup accounting)'
It can produce qgroup related warnings.
Signed-off-by: Liu Bo bo.li@oracle.com
I have trouble
a scrub which produced the following warning:
BTRFS: checksum error at logical 42123264 on dev /dev/sde, sector 15840:
metadata node (level 24) in tree 5
Signed-off-by: Filipe Manana fdman...@suse.com
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
In addition, build v3.18
(2014/12/16 5:02), Goffredo Baroncelli wrote:
This patch print the summary of the filesystem after the creation.
The main fileds printed are:
- devices list with their uuid, devid, path and size
- raid profile (dup,single,raid0...)
- leafsize/nodesize/sectorsize
- filesystem features
(2014/12/16 5:02), Goffredo Baroncelli wrote:
Add -v -q switches to mkfs.btrfs, to control the verbosity of mkfs.btrfs.
Signed-off-by: Goffredo Baroncelli kreij...@inwind.it
Although this patch provides the interface of two new switches,
it doesn't work at all only by this patch. I consider
Hi Ali,
(2014/12/16 11:01), Ali AlipourR wrote:
Hi
I think it will be to add option to btrfs subvolume list command to
also show the property of sub volumes (ro, compression,...)? do this
is possible?
Of course it's possible by writing some code :-D
Is btrfs property get subvol (and some
the parameter of struct map_lookup * with a profile type.
Then we can use it more easily.
Signed-off-by: Dongsheng Yang yangds.f...@cn.fujitsu.com
Although patch 1/3 and patch 3/3 is being discussed, at least
this patch (patch 2/3) looks fine to me.
Reviewed-by: Satoru Takeuchi takeuchi_sat
Hi David,
(2014/12/04 4:12), David Sterba wrote:
On Wed, Dec 03, 2014 at 09:11:48AM +0900, Satoru Takeuchi wrote:
It's not a Btrfs itself's feature. It's a snapper's feature.
It works as a helper of snapshot management.
1. You takes /snap by snapper create command.
2. You delete /snap
Hi,
(2014/12/02 16:39), Brendan Hide wrote:
On 2014/12/02 09:31, Brendan Hide wrote:
On 2014/12/02 07:54, MegaBrutal wrote:
Hi all,
I know there is a btrfstune, but it doesn't provide all the
functionality I'm thinking of.
For ext2/3/4 file systems I can get a bunch of useful data with
(2014/12/03 0:17), Shriramana Sharma wrote:
On Tue, Dec 2, 2014 at 12:41 PM, Satoru Takeuchi
takeuchi_sat...@jp.fujitsu.com wrote:
Snapper can automatically take a snapshot just before
taking/deleting snapshots. So, if you delete a snapshot
by mistake, it's still alive.
Sorta contradicts
Hi,
(2014/12/03 14:03), Ed Tomlinson wrote:
Hi,
I'd really like to see these patches included in btrfsck - they repaired my fs.
Once
Qu got them working they found additional corruptions. This time there was no
crash or stall
just an umount that left (chromium) files unlinked... The bug
Hi,
(2014/11/30 12:33), Shriramana Sharma wrote:
IIUC with BtrFS while it is possible to easily undelete a file or
ordinary directory if a snapshot of the containing subvol exists, it
seems that it's not elementary to undelete a subvol itself, because
all subvols are under the root-level subvol
Hi David and Chris,
(2014/09/29 18:36), David Sterba wrote:
On Fri, Sep 19, 2014 at 05:45:49PM +0900, Satoru Takeuchi wrote:
In the current implementation, compression property == has
the two different meanings: one is with BTRFS_INODE_NOCOMPRESS,
and the other is without this flag.
So, even
Hi David,
(2014/09/22 21:01), David Sterba wrote:
On Fri, Sep 19, 2014 at 05:52:17PM +0900, Satoru Takeuchi wrote:
@@ -99,7 +99,7 @@ find_prop_handler(const char *name,
return NULL;
}
-static int __btrfs_set_prop(struct btrfs_trans_handle *trans,
+int __btrfs_set_prop(struct
and aggregates this work to
btrfs_set_prop_trans() at all.
Signed-off-by: Naohiro Aota na...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
changelog
v1-v2: Reflect the following comment from David
https://www.mail-archive.com/linux-btrfs
Hi Qu,
Thank you for your comment.
(2014/09/19 11:03), Qu Wenruo wrote:
Original Message
Subject: [PATCH 2/5] btrfs: correct a message on setting nodatacow
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
To: linux-btrfs@vger.kernel.org linux-btrfs@vger.kernel.org
Date
the 51f39 commit and reduce an unneeded extent map tree search.
Reported-by: Tsutomu Itoh t-i...@jp.fujitsu.com
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
Reviewed-by: Liu Bo bo.li@oracle.com
Tested-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Sorry to late reply. I confirmed
[1];
int fd = open(name, O_RDONLY);
long x;
ioctl(fd, FS_IOC_GETFLAGS, x);
printf(0x%lx\n, x);
return 0;
}
===
Signed-off-by: Naohiro Aota na...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs/props.c | 4 ++--
1 file changed, 2
From: Naohiro Aota na...@elisp.net
This new compression property, off, to disable compression of
the file at all.
Signed-off-by: Naohiro Aota na...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs/props.c | 13 +
1 file changed, 13 insertions
From: Naohiro Aota na...@elisp.net
Export __btrfs_set_prop() to be able to call it
with running transaction.
Signed-off-by: Naohiro Aota na...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs/props.c | 2 +-
fs/btrfs/props.h | 6 ++
2 files changed, 7
and aggregates this work to __btrfs_set_prop()
at all.
Signed-off-by: Naohiro Aota na...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs/ioctl.c | 32 +++-
1 file changed, 11 insertions(+), 21 deletions(-)
diff --git a/fs/btrfs
)
===
This behavior collides with Documentation/filesystems/btrfs.txt:
===
...
If compression is enabled, nodatacow and nodatasum are disabled.
...
===
This patch drops the compress flags upon nodatasum flag.
Signed-off-by: Naohiro Aota na...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat
] BTRFS info (device vda2): setting nodatacow
[ 3845.719055] BTRFS info (device vda2): disk space caching is enabled
===
Signed-off-by: Naohiro Aota na...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index d131098..7ad4293 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -464,9 +464,9
From: Naohiro Aota na...@elisp.net
Remount operation always tells you it enabled space cache.
I consider it's a bit verbose and is better not to show
this message on remounting.
Signed-off-by: Naohiro Aota na...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs
...@elisp.net
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs/super.c | 57 +++-
1 file changed, 40 insertions(+), 17 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 03131c5..83433e15 100644
--- a/fs
From: Naohiro Aota na...@elisp.net
There are many trivial typos in Documentation/*.txt.
All of these use exist status to mean exit status
by mistake. I guess someone first made this mistake
and it has spread by copy-and-paste :-D
Signed-off-by: Naohiro Aota na...@elisp.net
Signed-off-by: Satoru
Hi Filipe,
# I added Chris to the CC list since this topic is to discuss
# whether the current behavior is correct or not.
(2014/09/11 18:48), Filipe David Manana wrote:
On Thu, Sep 11, 2014 at 5:41 AM, Satoru Takeuchi
takeuchi_sat...@jp.fujitsu.com wrote:
Hi Filipe,
(2014/09/11 0:10
Hi Gui,
(2014/09/12 10:15), Gui Hecheng wrote:
For btrfs fi show, -d|--all-devices -m|--mounted will
overwrite each other, so if specified both, let the user
know that he should not use them at the same time.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
changelog:
Hi Filipe,
(2014/09/11 0:10), Filipe Manana wrote:
The behaviour of a 'chattr -c' consists of getting the current flags,
clearing the FS_COMPR_FL bit and then sending the result to the set
flags ioctl - this means the bit FS_NOCOMP_FL isn't set in the flags
passed to the ioctl. This results
From: Naohiro Aota na...@elisp.net
man 8 btrfs-property refers to `setattr(8)` which does not actually exist.
It should refer to `chattr (1)` instead.
Signed-off-by: Naohiro Aota na...@elisp.net
---
Documentation/btrfs-property.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
(2014/08/12 17:30), Satoru Takeuchi wrote:
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Just fix the following misformatting in 'man btrfs-replace'.
Please ignore this patch.
It's part of the following Qu's patch.
https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg36116.html
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
- Simplify the description of both man and usage.
- Add the description about short options for '--all-devices
and '--mounted', '-d' and '-m' respectively.
- Fix to show -d and -m is not exclusive
with 'path|uuid|device|label
Oops, I sent a wrong patch. Here is the correct one.
===
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
- Simplify the description of both man and usage.
- Add the description about short options for '--all-devices'
and '--mounted', '-d' and '-m' respectively.
- Fix to show -d
Here is the *really* correct one. I seems to need a break ;-(
===
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
- Simplify the description of both man and usage.
- Add the description about short options for '--all-devices'
and '--mounted', '-d' and '-m' respectively.
- Fix to show
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Just fix the following misformatting in 'man btrfs-replace'.
===
-f
Hi all,
I'll be offline as summer vacation for several days.
So, until Aug 18, probably I can't send any reply...
Thanks,
Satoru
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
- Simplify and unify the description of both man and usage.
- Fix to show -m and -d is not exclusive
with path|uuid|device|label.
- Add the description about short options for --mounted and
--all-devices, -m and -d respectively
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Replace a numeric literal to more descriptive macro for
the size of uuid buffer.
Signed-of-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
cmds-filesystem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmds
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Current btrfs doesn't display any error message if this command
failed to find any btrfs filesystem corresponding to
path|uuid|device|label which user specified.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
cmds
] ? mntput_no_expire+0x17/0x1f0
[86304.300036] [811e0517] SyS_umount+0x97/0x100
(...)
Signed-off-by: Filipe Manana fdman...@suse.com
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Tested-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs/inode.c
we weren't aligning the extent's length to
the sector size, and therefore incorrectly treating the range
[inline_extent_length; sector_size[ as a hole.
Signed-off-by: Filipe Manana fdman...@suse.com
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs/ioctl.c | 3
Hi Eric,
(2014/08/12 2:05), Eric Sandeen wrote:
On 8/11/14, 2:11 AM, Satoru Takeuchi wrote:
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
- Simplify and unify the description of both man and usage.
- Fix to show -m and -d is not exclusive
with path|uuid|device|label.
- Add
Hi Eric,
(2014/08/12 2:14), Eric Sandeen wrote:
On 8/11/14, 10:05 AM, Eric Sandeen wrote:
On 8/11/14, 2:11 AM, Satoru Takeuchi wrote:
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
- Simplify and unify the description of both man and usage.
- Fix to show -m and -d is not exclusive
) {
disk = one_device-bdev-bd_part;
disk_kobj = part_to_dev(disk)-kobj;
Applied to 3.16.0 and tested, problem is fixed.
Chris Murphy
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Tested-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
I confirmed both
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
- Add missing description about -R option in the command
usage of btrfs scrub resume.
- Add missing comma to avoid the following misformatted command
usage of btrfs scrub start. See the line of -R option.
===
usage: btrfs scrub start
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Fix the lack of description of --max-erros option in
both man and command usage of btrfs receive.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
Documentation/btrfs-receive.txt | 2 +-
cmds-receive.c | 4
(2014/08/04 16:28), Qu Wenruo wrote:
Missing '+'s cause '-B' option not displayed correctly, add it to fix.
Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Tested-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Hi Qu,
(2014/08/01 12:27), Qu Wenruo wrote:
According to Documentations/filesystem/btrfs.txt, ssd/ssd_spread/nossd
has their own dependency(See below), but only ssd_spread implying ssd is
implemented.
ssd_spread implies ssd, conflicts nossd.
ssd conflicts nossd.
nossd conflicts ssd and
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
There are many duplicated codes to check if the given string is
correct subvolume name. Introduce test_issubvolname() for this
purpose for simplicity.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Cc: David Sterba dste
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
Since test_isdir() is a utility function, it's better to
move it to utils.c. In addition, const char * is
more appropriate type as its path argument because
this argument is not changed in this function.
Signed-off-by: Satoru Takeuchi
(2014/07/31 21:21), David Sterba wrote:
Make it consistent with kernel status and documentation.
Signed-off-by: David Sterba dste...@suse.cz
Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
I'm glad to see this patch :-)
Thanks,
Satoru
---
mkfs.c | 5 ++---
1 file changed
Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
o Return 0 to indicate success,
when detected errors were corrected during scrubbing.
P.s. This is also to facilitate scripting when return value
is to be checked.
o Warn the users if there are uncorrectable errors detected.
Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
The scrub_read_file function is always on a branch,
which has (fd = 0), so there is not need to judgment
the pasted in arg.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
cmds-scrub.c | 3 ---
1 file changed, 3 deletions(-)
Hi Gui,
(2014/07/30 14:39), Gui Hecheng wrote:
On Wed, 2014-07-30 at 14:20 +0900, Satoru Takeuchi wrote:
Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
The -f option of scrub means to skip checking running scrub,
not to force checking.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
Hi Gui,
(2014/07/30 15:03), Satoru Takeuchi wrote:
Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
o Return 0 to indicate success,
when detected errors were corrected during scrubbing.
P.s. This is also to facilitate scripting when return value
is to be checked.
o Warn
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
If get_df() returns 0, sargs surely points to malloc'ed region.
So NULL check of sargs is not necessary.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
cmds-filesystem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Hi David,
(2014/07/29 22:32), David Sterba wrote:
On Fri, Jul 25, 2014 at 03:16:58PM +0900, Satoru Takeuchi wrote:
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
There are many duplicated codes to check if the given string is
correct subvolume name. Introduce test_issubvolname
Hi Gui,
(2014/07/17 11:40), Gui Hecheng wrote:
The -f option of scrub means to skip checking running scrub,
not to force checking.
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
Documentation/btrfs-scrub.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
formats
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
- There are many format to show snapshot name in error messages,
'%s', '%s, %s, ('%s'), and ('%s). Since it's messy,
unify these to '%s' format.
- Fix a type: s/uncorrect/incorrect/
Signed-off-by: Satoru Takeuchi takeuchi_sat
Hi Qu,
(2014/07/25 17:16), Qu Wenruo wrote:
Original Message
Subject: Re: [PATCH v2] btrfs: Return right extent when fiemap gives unaligned
offset and len.
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
There are many duplicated codes to check if the given string is
correct subvolume name. Introduce test_issubvolname() for this
purpose for simplicity.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
cmds-subvolume.c | 21
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
- There are many format to show snapshot name in error messages,
'%s', '%s, %s, ('%s'), and ('%s). Since it's messy,
unify these to '%s' format.
- Fix a type: s/uncorrect/incorrect/
Signed-off-by: Satoru Takeuchi takeuchi_sat
Hi Qu,
(2014/07/25 10:49), Qu Wenruo wrote:
When page aligned start and len passed to extent_fiemap(), the result is
good, but when start and len is not aligned, e.g. start = 1 and len =
4095 is passed to extent_fiemap(), it returns no extent.
The problem is that start and len is all
From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
btrfs_lookup_csums_range() uses ALIGN() to check if start
and end + 1 are aligned to root-sectorsize. It's better to
replace these with IS_ALIGNED() for simplicity.
Signed-off-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com
---
fs/btrfs
101 - 200 of 258 matches
Mail list logo
