Re: [Request for review] [RFC] Add label support for snapshots and subvols

2012-11-05 Thread David Sterba
On Mon, Nov 05, 2012 at 03:24:48PM +0800, Anand Jain wrote: > featurexattr btrfs-kernel-way > [1] NoYes > [2] NoYes > [3] Yes No > > > [1]. Ability to read subvol label without mount It is possible to read it offline, one can traverse th

Re: [Request for review] [RFC] Add label support for snapshots and subvols

2012-11-04 Thread Anand Jain
Thanks for all the comments and inputs. featurexattr btrfs-kernel-way [1] NoYes [2] NoYes [3] Yes No [1]. Ability to read subvol label without mount [2]. Full-ability to log and track the property when it is modified [3]. ri

Re: [Request for review] [RFC] Add label support for snapshots and subvols

2012-11-01 Thread Goffredo Baroncelli
On 11/01/2012 11:28 PM, Fajar A. Nugraha wrote: > On Fri, Nov 2, 2012 at 5:16 AM, cwillu wrote: >>> btrfs fi label -t /btrfs/snap1-sv1 >>> Prod-DB-sand-box-testing >> >> Why is this better than: >> >> # btrfs su snap /btrfs/Prod-DB /btrfs/Prod-DB-sand-box-testing >> # mv /btrfs/Prod-DB-sand-box-t

Re: [Request for review] [RFC] Add label support for snapshots and subvols

2012-11-01 Thread Fajar A. Nugraha
On Fri, Nov 2, 2012 at 5:32 AM, Hugo Mills wrote: > On Fri, Nov 02, 2012 at 05:28:01AM +0700, Fajar A. Nugraha wrote: >> On Fri, Nov 2, 2012 at 5:16 AM, cwillu wrote: >> >> btrfs fi label -t /btrfs/snap1-sv1 >> >> Prod-DB-sand-box-testing >> > >> > Why is this better than: >> > >> > # btrfs su s

Re: [Request for review] [RFC] Add label support for snapshots and subvols

2012-11-01 Thread Hugo Mills
On Fri, Nov 02, 2012 at 05:28:01AM +0700, Fajar A. Nugraha wrote: > On Fri, Nov 2, 2012 at 5:16 AM, cwillu wrote: > >> btrfs fi label -t /btrfs/snap1-sv1 > >> Prod-DB-sand-box-testing > > > > Why is this better than: > > > > # btrfs su snap /btrfs/Prod-DB /btrfs/Prod-DB-sand-box-testing > > # mv

Re: [Request for review] [RFC] Add label support for snapshots and subvols

2012-11-01 Thread Fajar A. Nugraha
On Fri, Nov 2, 2012 at 5:16 AM, cwillu wrote: >> btrfs fi label -t /btrfs/snap1-sv1 >> Prod-DB-sand-box-testing > > Why is this better than: > > # btrfs su snap /btrfs/Prod-DB /btrfs/Prod-DB-sand-box-testing > # mv /btrfs/Prod-DB-sand-box-testing /btrfs/Prod-DB-production-test > # ls /btrfs/ > Pr

Re: [Request for review] [RFC] Add label support for snapshots and subvols

2012-11-01 Thread cwillu
> Below is a demo of this new feature. > > btrfs fi label -t /btrfs/sv1 "Prod-DB" > > btrfs fi label -t /btrfs/sv1 > Prod-DB > > btrfs su snap /btrfs/sv1 /btrfs/snap1-sv1 > Create a snapshot of '/btrfs/sv1' in '/btrfs/snap1-sv1' > btrfs fi label -t /btrfs/snap1-sv1 > > btrfs fi la

[Request for review] [RFC] Add label support for snapshots and subvols

2012-11-01 Thread Anand jain
From: Anand Jain (This patch is for the review/test not yet for the integration). Here is an implementation of the feature to add label to the subvolume and snapshots. Which would help sysadmin to better manager the subvol and snapshots. This can be done in two ways, one - using attr which