Re: [PADLOCK] PadLock SHA1 / SHA256 support

2006-07-05 Thread Michal Ludvig
Herbert Xu wrote: The only thing I'd like to tweak is to use the newly added template mechanism to pick the fallback. But you don't have to worry about this. I'll see if it fits or not first :) Anything else to be done from my side? Or can I go ahead and send you the whole patchset with all

Re: [PADLOCK] PadLock SHA1 / SHA256 support

2006-07-05 Thread Herbert Xu
On Thu, Jul 06, 2006 at 12:21:07PM +1200, Michal Ludvig wrote: Anything else to be done from my side? Or can I go ahead and send you the whole patchset with all prerequisities (sha*-generic aliases and two new accessors) for commit? I guess you can add the improved fallback selection later.

[PADLOCK] PadLock SHA1 / SHA256 support

2006-07-04 Thread Michal Ludvig
Hi Herbert and others, attached is a patch with support for VIA C7 crypto engine providing SHA1/SHA256 digests. It compiles into a new module padlock-sha.ko. Currently it allocates 1 page for its buffer and if there are more data to be hashed it falls back to software SHA implementation. By

Re: [PADLOCK] PadLock SHA1 / SHA256 support

2006-07-04 Thread Herbert Xu
On Wed, Jul 05, 2006 at 04:57:55PM +1200, Michal Ludvig wrote: Here are some benchmarks from tcrypt.ko (mode=303 for sha1 and mode=304 for sha256): Looks impressive! The only thing I'd like to tweak is to use the newly added template mechanism to pick the fallback. But you don't have to

Re: [PADLOCK] PadLock SHA1 / SHA256 support

2006-07-04 Thread Herbert Xu
On Wed, Jul 05, 2006 at 03:21:41PM +1000, herbert wrote: Also, we can probably bring down the 16-byte numbers if we change the digest layer to cater for a direct digest interface that takes one sg entry, i.e., if it's one sg entry then feed it directly to the algo's digest function,