Re: OCF or Acrypto for IPSec and dm-crypt

2005-09-04 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 5/5] crypto/sha1.c: final cleanup

2005-11-05 Thread Herbert Xu
care of one or more of these steps for me. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [PATCH 1/5] crypto/sha1.c: avoid useless memcpy()

2005-11-12 Thread Herbert Xu
On Sat, Nov 12, 2005 at 03:29:24PM -0500, Nicolas Pitre wrote: Looks fine indeed. Thanks. I ended up moving src = data out of the if clause as well. So this is what I committed in the end. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

Re: [2.6 patch] crypto/aes.c: array overrun

2006-03-10 Thread Herbert Xu
. It's just a trick that makes the code slightly nicer (and no I didn't write this nor am I necessarily condoning it :) Thanks for reporting this though. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: [PATCH] crypto: fix key alignment in tcrypt

2006-03-13 Thread Herbert Xu
-of-2 sized members come first. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux

Re: AES optimized for x86-64

2006-03-16 Thread Herbert Xu
with your code or the existing x86-64 asm module? If it's the existing one, what are the figures above then? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

[CRYPTO] all: Remove duplicate zeroing during init

2006-05-16 Thread Herbert Xu
Hi: The context area is already zeroed by crypto_alloc_tfm so there is no need for individual algorithms to zero it in their init functions. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

[CRYPTO] padlock: Rearrange context structure to reduce code size

2006-05-16 Thread Herbert Xu
Hi: i386 assembly has more compact instructions for accessing 7-bit offsets. So by moving the large members to the end of the structure we can save quite a bit of code size. This patch shaves about 10% or 300 bytes off the padlock-aes file. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers

Re: Add missing accessors for new crypto_alg fields.

2006-05-21 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL

[1/3] [CRYPTO] api: Added cra_init/cra_exit

2006-05-23 Thread Herbert Xu
are used for exactly that purpose (unlike the dia_init function which is called for each transaction). In fact the coa_exit path is currently buggy as it may get called twice when an error is encountered during initialisation. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan

[3/3] [CRYPTO] api: Allow replacement when registering new algorithms

2006-05-23 Thread Herbert Xu
-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt diff --git a/crypto/api.c b/crypto/api.c --- a/crypto/api.c +++ b

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-29 Thread Herbert Xu
growing tcrypt.[ch] that are starting to look scary. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [CRYPTO] tcrypt: Call tests by algorithm names instead of arbitrary numbers

2006-05-30 Thread Herbert Xu
On Tue, May 30, 2006 at 04:09:42PM +1200, Michal Ludvig wrote: Attached. Patch applied. Thank you very much Michal. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Herbert Xu
Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-06 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 1/4] Twofish cipher - split out common c code

2006-06-18 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: crypto_cipher_encrypt_iv and null cipher

2006-06-19 Thread Herbert Xu
for cipher_null with a block chaining mode you will soon ask for cbc(cipher_null) or ecb(cipher_null). So there should be no ambiguity as to which mode is being requested. Also the generic CBC algorithm will support arbitrary block sizes. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [PATCH 1/4] Twofish cipher - split out common c code

2006-06-20 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/4] Twofish cipher - split out common c code

2006-06-20 Thread Herbert Xu
certainly is. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-20 Thread Herbert Xu
/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: crypto_cipher_encrypt_iv and null cipher

2006-06-20 Thread Herbert Xu
optimisations for an algorithm. All you have to do is to register under the name cbc(yourname) and off you go. Basically from crytpo API's point of view having things like CBC hardcoded is unnecessary and unscalable. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

Re: Creating diff from 2.6.16 from cryptodev-2.6 git tree

2006-06-29 Thread Herbert Xu
do something like this when backporting to make sure that you haven't missed patches merged in ways that you didn't anticipate. Although I'm not aware of any such patches in the time frame that Michal has in mind. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI

[0/13] [CRYPTO]: Parameterised algorithms

2006-07-02 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message

[2/13] [CRYPTO] api: Add crypto_alg reference counting

2006-07-02 Thread Herbert Xu
algorithms a crypto_alg object may need two or more modules to operate. This means that we need to count the references to the crypto_alg object directly. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

[4/13] [CRYPTO] api: Added event notification

2006-07-02 Thread Herbert Xu
Hi: [CRYPTO] api: Added event notification This patch adds a notifier chain for algorithm/template registration events. This will be used to register compound algorithms such as cbc(aes). In future this will also be passed onto user-space through netlink. Signed-off-by: Herbert Xu [EMAIL

[5/13] [CRYPTO] api: Add cryptomgr

2006-07-02 Thread Herbert Xu
combinations or multiple parameters, a netlink module will be created which allows arbitrary expressions to be parsed in user-space. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

[6/13] [CRYPTO] api: Allow algorithm lookup by type

2006-07-02 Thread Herbert Xu
internally. Eventually it will be made available through crypto_alloc_tfm. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

[7/13] [CRYPTO] api: Added spawns

2006-07-02 Thread Herbert Xu
Hi: [CRYPTO] api: Added spawns Spawns lock a specific crypto algorithm in place. They can then be used with crypto_spawn_tfm to allocate a tfm for that algorithm. When the base algorithm of a spawn is deregistered, all its spawns will be automatically removed. Signed-off-by: Herbert Xu [EMAIL

[8/13] [CRYPTO] digest: Added direct SG update and digest interface

2006-07-02 Thread Herbert Xu
will be directly responsible for walking the SG list. If the digest function is present, it will take precedence over the generic digest function. This can be used by hardware that is able (and/or only able) to digest in one operation. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit

[9/13] [CRYPTO] hmac: Add crypto template implementation

2006-07-02 Thread Herbert Xu
are converted. The same structure can be used by other MACs such as AES-XCBC-MAC. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

[11/13] [IPSEC]: Use HMAC template

2006-07-02 Thread Herbert Xu
Hi: [IPSEC]: Use HMAC template This patch converts IPsec to use the new HMAC template. The names of existing simple digest algorithms may still be used to refer to their HMAC composites. The same structure can be used by other MACs such as AES-XCBC-MAC. Signed-off-by: Herbert Xu [EMAIL

[13/13] [CRYPTO] digest: Removed old HMAC implementation

2006-07-02 Thread Herbert Xu
Hi: [CRYPTO] digest: Removed old HMAC implementation This patch removes the old HMAC implementation now that nobody uses it anymore. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [3/13] [CRYPTO] api: Add template registration

2006-07-02 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [4/13] [CRYPTO] api: Added event notification

2006-07-02 Thread Herbert Xu
the pre-canned solution. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux

[2/2] [CRYPTO] api: Retry when modules are removed

2006-07-03 Thread Herbert Xu
will succeed if a replacement module is available. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff

Re: [1/2] [CRYPTO] api: Avoid refilling larval-adult

2006-07-03 Thread Herbert Xu
On Mon, Jul 03, 2006 at 07:49:19PM -0700, David Miller wrote: Would you like me to merge these 2 fixes or will you do so directly with your crypto-2.6 tree? I'll put them into the cryptodev-2.6 tree which'll go into mm. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [PADLOCK] PadLock SHA1 / SHA256 support

2006-07-04 Thread Herbert Xu
the usual sg walker. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto

Re: [PADLOCK] PadLock SHA1 / SHA256 support

2006-07-04 Thread Herbert Xu
. By the time we evolve away from a linear ESP implementation, hopefully VIA would've produced a proper SHA1 CPU by then :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PADLOCK] PadLock SHA1 / SHA256 support

2006-07-05 Thread Herbert Xu
. Yes please send away. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto

Re: [CRYPTO 4/4] padlock: Get rid of padlock-generic.c

2006-07-09 Thread Herbert Xu
-by: Michal Ludvig [EMAIL PROTECTED] Thanks Michal, I've applied patches 1, 2 and 4. -int __init padlock_init_aes(void) +static int __init +padlock_init(void) I reverted this back to the original style since that is the Linux way. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: [CRYPTO 3/4] padlock: Driver for SHA1 / SHA256 algorithms

2006-07-09 Thread Herbert Xu
to crypto_alloc_tfm we can also get rid of the fallback module parameter and instead let the crypto API pick the best fallback. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

Re: [CRYPTO 3/4] padlock: Driver for SHA1 / SHA256 algorithms

2006-07-09 Thread Herbert Xu
. So when you pick your fallback you simply request that the REQUIRES_FALLBACK bit be clear. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [CRYPTO 3/4] padlock: Driver for SHA1 / SHA256 algorithms

2006-07-09 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [CRYPTO 3/4] padlock: Driver for SHA1 / SHA256 algorithms

2006-07-09 Thread Herbert Xu
to be negative to really be an error (something like -ENOENT or -ENOMEM would do for your case). Pretty soon I'll make crypto_alloc_tfm return an ERR_PTR instead of NULL so you could just return that. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

Re: [CRYPTO 3/4] padlock: Driver for SHA1 / SHA256 algorithms

2006-07-10 Thread Herbert Xu
to indicate error you should always return an errno value. This is so that if the caller then has to return the error as part of a pointer using ERR_PTR (which is indeed the case here), it doesn't get turned into a non-error. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

[1/5] [CRYPTO] padlock: Add compatibility alias after rename

2006-07-10 Thread Herbert Xu
[CRYPTO] padlock: Add compatibility alias after rename Whenever we rename modules we should add an alias to ensure that existing users can still locate the new module. This patch also gets rid of the now unused module function prototypes from padlock.h. Signed-off-by: Herbert Xu [EMAIL

[2/5] [CRYPTO] crc32c: Fix unconventional setkey usage

2006-07-10 Thread Herbert Xu
that sets the key is tcrypt. This patch adds the necessary init calls there. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

[5/5] [CRYPTO] digest: Fix dit_final typo and remove dia_digest

2006-07-10 Thread Herbert Xu
that for ESP the hash offset is off the encryption offset by 24 bytes for AES. Since padlock requires the input to be 16-byte aligned, at least one of them (or both) will have to cope with copying. If something else needs it in future we can always add it back. Signed-off-by: Herbert Xu [EMAIL

[3/5] [CRYPTO] api: Get rid of flags argument to setkey

2006-07-10 Thread Herbert Xu
that the key length is within the bounds specified by the algorithm. Rather than testing dia_setkey every time, this patch does it only once during crypto_alloc_tfm. The redundant check from crypto_digest_setkey is also removed. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan

[4/5] [CRYPTO] digest: Store temporary digest in tfm

2006-07-10 Thread Herbert Xu
. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/crypto/digest.c b/crypto/digest.c

Re: [1/5] [CRYPTO] padlock: Add compatibility alias after rename

2006-07-10 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info

[CRYPTO] api: Fix potential cra_users leak in crypto_remove_spawns

2006-07-10 Thread Herbert Xu
happens to be the last of the spawns list, the newly added entries will not be processed. Thie patch fixes it by changing n if the it is the last entry of spawns. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: [ACRYPTO] new release of asynchronous crrypto layer.

2006-07-11 Thread Herbert Xu
the same IV more than once is definitely not a good idea. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send

[1/2] [CRYPTO] crc32c: Fixed reversed endian annotation

2006-07-11 Thread Herbert Xu
Hi: [CRYPTO] crc32c: Fixed reversed endian annotation The input rather than the internal state is supposed to be little-endian. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [0/2] [CRYPTO] padlock: SHA1 / SHA256 support

2006-07-11 Thread Herbert Xu
of the alignment mask altogether since you can handle arbitrary input/output and your ctx has no alignment requirement. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: [CRYPTO] padlock: Fix alignment after aes_ctx rearrange

2006-07-14 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL

Re: [1/5] [CRYPTO] padlock: Add compatibility alias after rename

2006-07-14 Thread Herbert Xu
) { + success++; + crypto_free_tfm(tfm); + } +#endif It's easier to call crypto_alg_available. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [1/5] [CRYPTO] padlock: Add compatibility alias after rename

2006-07-16 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More

Re: padlock-sha: TFMs don't need to be static

2006-07-16 Thread Herbert Xu
On Sat, Jul 15, 2006 at 10:55:49PM +1200, Michal Ludvig wrote: this is a trivial patch merging two variables into one and make it non-static in padlock-sha.c Thanks, patch applied. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

[3/7] [CRYPTO] api: Split out low-level API

2006-08-04 Thread Herbert Xu
-level API can now be modularised if all algorithms are built as modules. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

[5/7] [CRYPTO] api: Added asynchronous flag

2006-08-04 Thread Herbert Xu
Hi: [CRYPTO] api: Added asynchronous flag This patch adds the asynchronous flag and changes all existing users to only look up algorithms that are synchronous. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

[6/6] [CRYPTO] s390: Added missing driver name and priority

2006-08-04 Thread Herbert Xu
Hi: Doh! I can't count. This is the last one for now. [CRYPTO] s390: Added missing driver name and priority Accelerated versions of crypto algorithms must carry a distinct driver name and priority in order to distinguish themselves from their generic counter- part. Signed-off-by: Herbert Xu

[CRYPTO] api: Fixed crypto_tfm context alignment

2006-08-06 Thread Herbert Xu
. This patch changes it to use kmalloc's minimum alignment. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Warning: cryptodev-2.6 to be rebased

2006-08-06 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[0/16] Add block cipher operations

2006-08-13 Thread Herbert Xu
days. Once the digest/compress conversion is complete, I will add the first asynchronous algorithm and then begin converting IPsec over. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

[PATCH 1/16] [CRYPTO] api: Added crypto_type support

2006-08-13 Thread Herbert Xu
, in particular, there will be a different crypto_type objects for asynchronous algorithms. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/api.c| 32 +++- include/crypto/algapi.h |6 ++ include/linux/crypto.h |3 +++ 3 files changed, 32

[PATCH 7/16] [CRYPTO] s390: Added block cipher versions of CBC/ECB

2006-08-13 Thread Herbert Xu
[CRYPTO] s390: Added block cipher versions of CBC/ECB This patch adds block cipher algorithms for S390. Once all users of the old cipher type have been converted the existing CBC/ECB non-block cipher operations will be removed. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- arch/s390/crypto

[PATCH 3/16] [CRYPTO] scatterwalk: Prepare for block ciphers

2006-08-13 Thread Herbert Xu
of the hack by not advancing the address returned by scatterwalk_map. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/cipher.c | 27 +++--- crypto/scatterwalk.c| 89 +--- crypto/scatterwalk.h| 48

[PATCH 12/16] [IPSEC] ESP: Use block ciphers where applicable

2006-08-13 Thread Herbert Xu
[IPSEC] ESP: Use block ciphers where applicable This patch converts IPSec/ESP to use the new block cipher type where applicable. Similar to the HMAC conversion, existing algorithm names have been kept for compatibility. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- include/net/esp.h

[PATCH 4/16] [CRYPTO] cipher: Added block cipher type

2006-08-13 Thread Herbert Xu
performance for all algorithms as it reduces the total number of indirect calls by one. In future the existing cipher algorithm will be converted to only have a single-block interface. This will be done after all existing users have switched over to the new block cipher type. Signed-off-by: Herbert Xu

[PATCH 10/16] [BLOCK] dm-crypt: Use block ciphers where applicable

2006-08-13 Thread Herbert Xu
[BLOCK] dm-crypt: Use block ciphers where applicable This patch converts dm-crypt to use the new block cipher type where applicable. It also changes simple cipher operations to use the new encrypt_one/decrypt_one interface. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- drivers/md/dm-crypt.c

[PATCH 11/16] [IPSEC]: Add compatibility algorithm name support

2006-08-13 Thread Herbert Xu
[IPSEC]: Add compatibility algorithm name support This patch adds a compatibility name field for each IPsec algorithm. This is needed when parameterised algorithms are used. For example, md5 will become hmac(md5), and aes will become cbc(aes). Signed-off-by: Herbert Xu [EMAIL PROTECTED

[PATCH 5/16] [CRYPTO] cipher: Added block ciphers for CBC/ECB

2006-08-13 Thread Herbert Xu
-by: Herbert Xu [EMAIL PROTECTED] --- crypto/Kconfig | 17 ++ crypto/Makefile |2 crypto/cbc.c| 337 crypto/ecb.c| 181 + crypto/internal.h |1 include/crypto/algapi.h

[PATCH 6/16] [CRYPTO] padlock: Added block cipher versions of CBC/ECB

2006-08-13 Thread Herbert Xu
[CRYPTO] padlock: Added block cipher versions of CBC/ECB This patch adds block cipher algorithms for cbc(aes) and ecb(aes) for the PadLock device. Once all users to the old cipher type have been converted the old cbc/ecb PadLock operations will be removed. Signed-off-by: Herbert Xu [EMAIL

[PATCH 16/16] [CRYPTO] cipher: Remove obsolete block cipher operations

2006-08-13 Thread Herbert Xu
time. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/api.c |4 crypto/cipher.c| 430 - crypto/internal.h | 13 - crypto/scatterwalk.h |7 include/linux/crypto.h | 134 +-- 5 files changed, 15

Re: [-mm patch] Kconfig: move CRYPTO to the Cryptographic options menu

2006-08-13 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More

[2/2] [CRYPTO] api: Mark parts of cipher interface as deprecated

2006-08-15 Thread Herbert Xu
Hi: [CRYPTO] api: Mark parts of cipher interface as deprecated Mark the parts of the cipher interface that have been replaced by block ciphers as deprecated. Thanks to Andrew Morton for suggesting doing this before removing them completely. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers

Re: [PATCH] cit_encrypt_iv/cit_decrypt_iv for ECB mode

2006-08-20 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] cit_encrypt_iv/cit_decrypt_iv for ECB mode

2006-08-20 Thread Herbert Xu
, with block ciphers you can no longer select CFB/CTR until someone writes support for them so this is no longer an issue. For 2.4, I don't really mind either way what nocrypt does. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: [-mm patch] CRYPTO_DEV_PADLOCK_AES must select CRYPTO_BLKCIPHER

2006-08-20 Thread Herbert Xu
aabffae140135096195f6fb04d165bb204517db2 Author: Herbert Xu [EMAIL PROTECTED] Date: Tue Aug 15 22:49:54 2006 +1000 [CRYPTO] Kconfig: Added missing selects on BLKCIPHER Since padlock-aes and aes-s390/des-s390 now use the block cipher interface, they need to select the BLKCIPHER Kconfig option. Signed

[PATCH 2/7] [CRYPTO] hmac: Add crypto template implementation

2006-08-21 Thread Herbert Xu
are converted. The same structure can be used by other MACs such as AES-XCBC-MAC. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Signed-off-by: David S. Miller [EMAIL PROTECTED] --- crypto/Kconfig |1 crypto/hmac.c | 241 +++-- 2 files changed

[PATCH 7/7] [CRYPTO] digest: Remove old HMAC implementation

2006-08-21 Thread Herbert Xu
[CRYPTO] digest: Remove old HMAC implementation This patch removes the old HMAC implementation now that nobody uses it anymore. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Signed-off-by: David S. Miller [EMAIL PROTECTED] --- crypto/Kconfig |2 crypto/digest.c|3

Re: LRW implementation, please comment

2006-08-31 Thread Herbert Xu
be good if you can fix them up before I apply the patches. Could you also convert the test vectors to use tcrypt.h/tcrypt.c? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: LRW implementation, please comment

2006-09-01 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message

Re: Dead code in crypto/tcrypt.c

2006-09-27 Thread Herbert Xu
put the following patch into the tree. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 8330742

Re: [PATCH 1/2] Add PCBC crypto template support

2006-12-15 Thread Herbert Xu
On Fri, Dec 15, 2006 at 10:26:37AM +, David Howells wrote: Add PCBC crypto template support as used by RxRPC. Signed-Off-By: David Howells [EMAIL PROTECTED] Thanks David! I'll push this to mm via cryptodev. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

[PATCH 1/6] [CRYPTO] tcrypt: Removed vestigial crypto_alloc_tfm call

2007-01-24 Thread Herbert Xu
[CRYPTO] tcrypt: Removed vestigial crypto_alloc_tfm call The crypto_comp conversion missed the last remaining crypto_alloc_tfm call. This patch replaces it with crypto_alloc_comp. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/tcrypt.c |2 +- 1 files changed, 1 insertion(+), 1

[PATCH 3/6] [CRYPTO] api: Add type-safe spawns

2007-01-24 Thread Herbert Xu
[CRYPTO] api: Add type-safe spawns This patch allows spawns of specific types (e.g., cipher) to be allocated. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/algapi.c | 13 +++-- crypto/cbc.c|9 + crypto/ecb.c|9 + crypto

[PATCH 2/6] [CRYPTO] api: Remove deprecated interface

2007-01-24 Thread Herbert Xu
[CRYPTO] api: Remove deprecated interface This patch removes the old cipher interface and related code. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/algapi.c|2 crypto/api.c | 63 -- crypto/cipher.c| 447

[PATCH 4/6] [CRYPTO] api: Allow multiple frontends per backend

2007-01-24 Thread Herbert Xu
[CRYPTO] api: Allow multiple frontends per backend This patch adds support for multiple frontend types for each backend algorithm by passing the type and mask through to the backend type init function. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/algapi.c |2 +- crypto

[PATCH 6/6] [CRYPTO] api: Use structs for cipher/compression

2007-01-24 Thread Herbert Xu
[CRYPTO] api: Use structs for cipher/compression Now that all cipher/compression users have switched over to the new allocation scheme, we can get rid of the compatility defines and use proper structs for them. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- include/linux/crypto.h | 21

Re: [PATCH] geode-aes.c: Convert pci_module_init() to pci_register_driver()

2007-01-24 Thread Herbert Xu
On Fri, Jan 12, 2007 at 02:36:25PM +0100, Richard Knutsson wrote: Signed-off-by: Richard Knutsson [EMAIL PROTECTED] Patch applied. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Crypto Update for 2.6.21

2007-02-07 Thread Herbert Xu
in preparation for async. Andrew Donofrio (1): [CRYPTO] tcrypt: Added test vectors for sha384/sha512 David Howells (2): [CRYPTO] pcbc: Add Propagated CBC template [CRYPTO] fcrypt: Add FCrypt from RxRPC Herbert Xu (7): [CRYPTO] all: Check for usage in hard IRQ context [CRYPTO

Re: Crypto Update for 2.6.21

2007-02-09 Thread Herbert Xu
Jan Glauber [EMAIL PROTECTED] wrote: Would it be better if I send patches that also touch common crypto code to Herbert for integration? I'm certainly happy to take them. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: Asynchronus crypto API

2007-02-13 Thread Herbert Xu
I get home next week. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto

Re: Problem with key sizes

2007-03-16 Thread Herbert Xu
time the merge window opens. If you find no source code after the clone all you have to do is check them out with 'git-checkout-index -a'. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH] crypto: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-19 Thread Herbert Xu
over to the next page in scatterwalk_copychunks. So perhaps the bug is elsewhere in the original patch? Your patch looks like a good clean-up anyway but I just wanted to make sure that I understand what the problem is first. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [PATCH] crypto: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-20 Thread Herbert Xu
[1].page = page2 sg[1].offset = 0 sg[1].length = 37 OK I see what you mean now. I'll apply your patch. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

[CRYPTO] api: Proc functions should be marked as unused

2007-03-29 Thread Herbert Xu
Hi: I'm adding this patch to the cryptodev-2.6 tree. [CRYPTO] api: Proc functions should be marked as unused The proc functions were incorrectly marked as used rather than unused. They may be unused if proc is disabled. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan

[CRYPTO] api: Flush the current page right than the next

2007-03-30 Thread Herbert Xu
fixes the off-by-one error. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/crypto

  1   2   3   4   5   6   7   8   9   10   >