On 12/12, Chao Yu wrote:
> On 2022/12/12 20:51, Yangtao Li wrote:
> > This patch adds support for counting the average time and
> > peak time of submit discard command, and we can see its
> > value in debugfs.
> >
> > It is not sure whether the block layer has recorded these
> > data, and these da
On 12/12, Chao Yu wrote:
> On 2022/12/12 22:14, Yangtao Li wrote:
> > Hi Chao,
> >
> > > The difference here is, if we use f2fs_realtime_discard_enable() in
> > > f2fs_put_super(), we will only write checkpoint w/ CP_TRIMMED flag
> > > when discard option is enable and device supports discard.
> >
On 12/08, zhoudan8 wrote:
> In compress_mode=user, f2fs_release_compress_blocks()
> does not verify whether it has been compressed and
> sets FI_COMPRESS_RELEASED directly. which will lead to
> return -EINVAL after calling compress.
> To fix it,let's do not set FI_COMPRESS_RELEASED if file
> is n
On 11/29, Yangtao Li wrote:
> This patch adds support for counting the average time of submit discard
> command, and we can see its value in debugfs.
What about peak latencies as well?
>
> Signed-off-by: Yangtao Li
> ---
> fs/f2fs/debug.c | 7 +--
> fs/f2fs/f2fs.h| 5 +
> fs/f2
Let's descrbie it's read extent cache.
Signed-off-by: Jaegeuk Kim
---
Change log from v1:
- keep showing the mount option
fs/f2fs/extent_cache.c | 4 ++--
fs/f2fs/f2fs.h | 10 +-
fs/f2fs/inode.c| 2 +-
fs/f2fs/node.c | 2 +-
fs/f2fs/node.h
On 12/09, Chao Yu wrote:
> On 2022/12/9 1:29, Jaegeuk Kim wrote:
> > On 12/08, Chao Yu wrote:
> > > On 2022/12/6 2:54, Jaegeuk Kim wrote:
> > > > Let's descrbie it's read extent cache.
> > > >
> > > > Signed-off-by:
On 12/08, Chao Yu wrote:
> On 2022/12/6 2:54, Jaegeuk Kim wrote:
> > Let's descrbie it's read extent cache.
> >
> > Signed-off-by: Jaegeuk Kim
> > ---
> > fs/f2fs/extent_cache.c | 4 ++--
> > fs/f2fs/f2fs.h | 10 +-
> >
ge of test device is large enough(128G) so that it will not
switch to SSR mode during the test.
Benefit: dirty segment count increment reduce about 14%
- before: Dirty +21110
- after: Dirty +18286
Signed-off-by: qixiaoyu1
Signed-off-by: xiongping1
Signed-off-by: Jaegeuk Kim
---
Change l
This patch prepares extent_cache to get more use-cases.
Signed-off-by: Jaegeuk Kim
---
Change log from v1:
- fix a bug
fs/f2fs/data.c | 14 +++
fs/f2fs/debug.c| 53 +-
fs/f2fs/extent_cache.c | 85 +++---
3
On 11/28, Jaegeuk Kim wrote:
> On 11/28, qixiaoyu1 wrote:
> > From: xiongping1
> >
> > Signed-off-by: xiongping1
> > Signed-off-by: qixiaoyu1
> > ---
> > fs/f2fs/Kconfig | 7 +++
> > fs/f2fs/Makefile| 1 +
> > fs/f2fs/block_a
This patch prepares extent_cache to be ready for addition.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/data.c | 20 +-
fs/f2fs/debug.c | 65 +++--
fs/f2fs/extent_cache.c | 463 +---
fs/f2fs/f2fs.h | 108 ++---
fs/f2fs
Let's descrbie it's read extent cache.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/extent_cache.c | 4 ++--
fs/f2fs/f2fs.h | 10 +-
fs/f2fs/inode.c| 2 +-
fs/f2fs/node.c | 2 +-
fs/f2fs/node.h | 2 +-
fs/f2fs/segment.c | 4 ++--
fs/f2
ge of test device is large enough(128G) so that it will not
switch to SSR mode during the test.
Benefit: dirty segment count increment reduce about 14%
- before: Dirty +21110
- after: Dirty +18286
Signed-off-by: qixiaoyu1
Signed-off-by: xiongping1
Signed-off-by: Jaegeuk Kim
---
Documentation/A
Let's allocate it to remove the runtime complexity.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/extent_cache.c | 38 +++---
fs/f2fs/f2fs.h | 3 ++-
fs/f2fs/inode.c| 6 --
fs/f2fs/namei.c| 4 ++--
4 files changed, 27 insertions(+
Added into the caller.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/extent_cache.c | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 2a8e31e6d518..c6810347e205 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs
No functional change.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/extent_cache.c | 88 +-
fs/f2fs/f2fs.h | 69 +
2 files changed, 81 insertions(+), 76 deletions(-)
diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs
On 11/28, Eric Biggers wrote:
> From: Eric Biggers
>
> Add a f2fs/compress configuration which causes all files to be
> automatically compressed, similar to how f2fs/encrypt causes all files
> to be automatically encrypted.
>
> Signed-off-by: Eric Biggers
Acked-by:
On 11/28, Eric Biggers wrote:
> On Mon, Nov 28, 2022 at 10:48:41PM -0800, Jaegeuk Kim wrote:
> > > static void f2fs_finish_read_bio(struct bio *bio, bool in_task)
> > > {
> > > struct bio_vec *bv;
> > > struct bvec_iter_all iter_all;
> > > +
On 11/25, Eric Biggers wrote:
> From: Eric Biggers
>
> As a step towards freeing the PG_error flag for other uses, change ext4
> and f2fs to stop using PG_error to track verity errors. Instead, if a
> verity error occurs, just mark the whole bio as failed. The coarser
> granularity isn't really
On 11/28, qixiaoyu1 wrote:
> From: xiongping1
>
> Signed-off-by: xiongping1
> Signed-off-by: qixiaoyu1
> ---
> fs/f2fs/Kconfig | 7 +++
> fs/f2fs/Makefile| 1 +
> fs/f2fs/block_age.c | 28
> fs/f2fs/debug.c | 7 +++
> fs/f2fs/f2fs.h | 15
Need to run checkpatch?
On 11/23, Yangtao Li wrote:
> This patch adds support for counting the average time of submit discard
> command, and we can see its value in debugfs.
>
> Signed-off-by: Yangtao Li
> ---
> fs/f2fs/debug.c | 7 +--
> fs/f2fs/f2fs.h| 5 +
> fs/f2fs/segment.c
If you don't mind, let me merge this patch into Chao's patch, since both
are same topic.
On 11/28, Yangtao Li wrote:
> It's better to use bugzilla.kernel.org for reporting bugs.
>
> Signed-off-by: Yangtao Li
> ---
> Documentation/filesystems/f2fs.rst | 6 +-
> 1 file changed, 5 insertions(+
On 11/28, Christoph Hellwig wrote:
> Hi Jaegeuk and Chao,
>
> this series cleans up the segment allocation code a bit.
Thanks, applied for test.
>
> Diffstat
> segment.c | 71
> ++
> segment.h |6 -
> 2 files changed, 30 in
ore
> complicated than desired, but the basic premise still works.
>
> Note: there are still a few uses of PageError in f2fs, but they are on
> the write path, so they are unrelated and this patch doesn't touch them.
>
> Reviewed-by: Chao Yu
Acked-by: Jaegeuk Kim
Thanks
On 11/23, Chao Yu wrote:
> On 2022/11/12 1:04, Daeho Jeong wrote:
> > From: Daeho Jeong
> >
> > introduce a new ioctl to replace the whole content of a file atomically,
> > which means it induces truncate and content update at the same time.
> > We can start it with F2FS_IOC_START_ATOMIC_REPLACE
(), which do extension check, in
f2fs_should_compress() to check extensions before setting inline
data flag.
Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode
conversion")
Signed-off-by: Sheng Yong
Signed-off-by: Jaegeuk Kim
---
Change log from v4
On 11/23, Chao Yu wrote:
> On 2022/11/17 9:12, Jaegeuk Kim wrote:
> > If compress_extension is set, and a newly created file matches the
> > extension, the file could be marked as compression file. However,
> > if inline_data is also enabled, there is no chance to check it
On 11/16, Sheng Yong wrote:
>
>
> On 2022/11/16 7:00, Jaegeuk Kim wrote:
> > If compress_extension is set, and a newly created file matches the
> > extension, the file could be marked as compression file. However,
> > if inline_data is also enabled, there is no chance
(), which do extension check, in
f2fs_should_compress() to check extensions before setting inline
data flag.
Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode
conversion")
Signed-off-by: Sheng Yong
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 2 +-
fs/f2
(), which do extension check, in
f2fs_should_compress() to check extensions before setting inline
data flag.
Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode
conversion")
Signed-off-by: Sheng Yong
Signed-off-by: Jaegeuk Kim
---
Checking this version.
fs/f
eturns false.
>
> This patch moves set_compress_inode(), which do extension check, in
> f2fs_should_compress() to check extensions before setting inline
> data flag.
>
> Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode
> conversion")
> Signe
eturns false.
>
> This patch moves set_compress_inode(), which do extension check, in
> f2fs_should_compress() to check extensions before setting inline
> data flag.
>
> Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode
> conversion")
> Signe
On 11/14, Jaegeuk Kim wrote:
> If compress_extension is set, and a newly created file matches the
> extension, the file could be marked as compression file. However,
> if inline_data is also enabled, there is no chance to check its
> extension since f2fs_should_compress() always r
On 11/11, Yangtao Li wrote:
> This patch adds a new proc entry to show discard_plist
> information in more detail, which is very helpful to
> know the discard pend list count clearly.
>
> Such as:
>
> Discard pending list(Show diacrd command count on each entry):
> 04943 1
On 11/12, Yangtao Li wrote:
> Complaint from Matthew Wilcox in another similar place:
>
> "submit? You don't submit anything at the 'submit' label.
> it should be called 'skip' or something. But I think this
> is just badly written and you don't need a goto at all."
>
> Let's
On 11/14, Chao Yu wrote:
> On 2022/11/8 9:17, Chao Yu wrote:
> > Jaegeuk,
> >
> > On 2022/11/8 5:49, Jaegeuk Kim wrote:
> > > Chao,
> > >
> > > Could you please run xfstests since I met some issues with this?
> > > I had to drop this to t
Since the file name has already passed to f2fs_new_inode(), let's
move set_file_temperature() into f2fs_new_inode().
Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/namei.c | 62 +++--
1 file change
(), which do extension check, in
f2fs_should_compress() to check extensions before setting inline
data flag.
Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode
conversion")
Signed-off-by: Sheng Yong
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/nam
Does thes make sense?
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=608460dfae20b9d23aa222f7448710a086778222
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=962379487b5cb9f3b85ea367b130c2c6ca584edf
Second one is neede
On 11/10, Yangtao Li wrote:
> Hi Jaegeuk,
>
> > Hi,
>
> > I modified and integrated some patches as below. Could you please take a
> > look?
>
> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=d34f1e7212c1965a409d4581a32a92a1c91495fc
>
> I've looked at the r
If block address is still alive, we should give a valid node block even after
shutdown. Otherwise, we can see zero data when reading out a file.
Cc: sta...@vger.kernel.org
Fixes: 83a3bfdb5a8 ("f2fs: indicate shutdown f2fs to allow unmount
successfully")
Signed-off-by: Jaegeuk Kim
If block address is still alive, we should give a valid node block even after
shutdown. Otherwise, we can see zero data when reading out a file.
Fixes: 83a3bfdb5a8 ("f2fs: indicate shutdown f2fs to allow unmount
successfully")
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/node.c | 3 +
; Signed-off-by: Jaegeuk Kim
> ---
> v6:
> - rebase the code
> Documentation/filesystems/f2fs.rst | 4 +
> fs/f2fs/checkpoint.c | 7 +-
> fs/f2fs/f2fs.h | 18 +++-
> fs/f2fs/file.c | 5 --
> fs/f2fs/gc.c
s total written kbytes issued to
> disk.
> What: /sys/fs/f2fs//features
> Date:July 2017
> Contact: "Jaegeuk Kim"
> -Description: /feature_list/
> +Description: : should use /sys/fs/f2fs//feature_list/
> Shows all e
Hi,
I merged two patches and modified a bit. Please take a look.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=28ea9479410bab555db26e8437ea61b180e768d6
On 10/25, Yangtao Li wrote:
> gc_mode sysfs node can show the current gc_mode as a string.
> Introducing it
Let's use sysfs_emit.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/sysfs.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index 66c88220d319..aaf93bb6c64d 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sy
On 10/28, Chao Yu wrote:
> On 2022/10/28 11:22, Jaegeuk Kim wrote:
> > On 10/28, Chao Yu wrote:
> > > On 2022/10/25 14:50, Yangtao Li wrote:
> > > > Added a new sysfs node called gc_urgent_idle_remaining.
> > > > The user can set the trial count limit for
On 10/28, Chao Yu wrote:
> Jaegeuk,
>
> There is a generic fix [1], let's drop this one...
Ok, thanks.
>
> https://lore.kernel.org/lkml/20221025071549.1280528-1-yangyingli...@huawei.com/T/
>
> On 2022/10/20 16:45, Chao Yu wrote:
> > On 2022/10/18 15:32, Yang Yingliang wrote:
> > > Inject fault
_attr *a,
> > return count;
> > }
> > - if (!strcmp(a->attr.name, "gc_urgent_high_remaining")) {
> > - spin_lock(&sbi->gc_urgent_high_lock);
> > - sbi->gc_urgent_high_remaining = t;
&
On 10/28, Chao Yu wrote:
> On 2022/10/28 10:33, Yangtao Li wrote:
> > > It won't pollute global namespace since it's a static function just be
> > > used in f2fs/super.c...
> >
> > emm, I think it would be nice to see the f2fs_record_error_work symbol
> > in the stack, it can be explicitly a func
Let's stop threads first to avoid irq context.
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/super.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index a241e4073f1d..14b4bb0f8ce6 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/su
I integrated two patches into single one. I think we don't need Fixes.
On 10/27, Chao Yu wrote:
> On 2022/10/27 18:24, Yangtao Li wrote:
> > Return PTR_ERR(cprc->f2fs_issue_ckpt) instead of -ENOMEM;
> >
>
> Fixes line?
>
> > Signed-off-by: Yangtao Li
>
> Reviewed-by: Chao Yu
>
> Thanks,
_
As f2fs becomes more resilient for GCs, let's give the marginal overprovision
space back to user.
Fix an issue where reserved_space > ovp_space, reported by Shinichiro.
Signed-off-by: Shinichiro Kawasaki
Signed-off-by: Jaegeuk Kim
---
Change log from v1:
- adjust ovp should be lar
The below commit disallows to set compression on empty created file which
has a inline_data. Let's fix it.
Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode
conversion")
Signed-off-by: Jaegeuk Kim
---
Change log from v1:
- add returning an error
On 10/26, Chao Yu wrote:
> On 2022/10/26 1:46, Jaegeuk Kim wrote:
> > On 10/25, Chao Yu wrote:
> > > On 2022/10/25 7:36, Jaegeuk Kim wrote:
> > > > The below commit disallows to set compression on empty created file
> > > > which
> > > > h
On 10/25, Chao Yu wrote:
> On 2022/10/25 7:36, Jaegeuk Kim wrote:
> > The below commit disallows to set compression on empty created file which
> > has a inline_data. Let's fix it.
> >
> > Fixes: 7165841d578e ("f2fs: fix to check inline_data during compress
The below commit disallows to set compression on empty created file which
has a inline_data. Let's fix it.
Fixes: 7165841d578e ("f2fs: fix to check inline_data during compressed inode
conversion")
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/file.c | 3 +++
1 file changed, 3 inse
On 10/21, Shinichiro Kawasaki wrote:
> On Oct 20, 2022 / 16:18, Jaegeuk Kim wrote:
>
> ...
>
> > Thanks, I think that fix looks good to me. I applied into the original
> > patch.
> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f
On 10/20, Shinichiro Kawasaki wrote:
> On Oct 10, 2022 / 15:15, Jaegeuk Kim wrote:
> > As f2fs becomes more resilient for GCs, let's give the marginal
> > overprovision
> > space back to user.
> >
> > Signed-off-by: Jaegeuk Kim
>
> Hello Jaegeuk,
>
f2fs_unlink
-> f2fs_lock_op
-> d_invalidate
-> shrink_dentry_list
-> iput_final
-> f2fs_evict_inode
-> f2fs_lock_op
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/
It'd be good to generate zone-aware sequential writes to both of HA and HM
zoned devices.
Signed-off-by: Jaegeuk Kim
---
fsck/mount.c| 2 +-
mkfs/f2fs_format.c | 2 +-
mkfs/f2fs_format_main.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fsck/moun
We need to set the c.zoned_model appropriately for further usages.
Signed-off-by: Jaegeuk Kim
---
fsck/mount.c | 8
1 file changed, 8 insertions(+)
diff --git a/fsck/mount.c b/fsck/mount.c
index 0597220b3bc0..cd8a07538150 100644
--- a/fsck/mount.c
+++ b/fsck/mount.c
@@ -1095,6
As f2fs becomes more resilient for GCs, let's give the marginal overprovision
space back to user.
Signed-off-by: Jaegeuk Kim
---
fsck/resize.c | 8
include/f2fs_fs.h | 6 --
mkfs/f2fs_format.c | 9 ++---
3 files changed, 14 insertions(+), 9 deletions(-)
diff --git a
ile inodes
f2fs: change to use atomic_t type form sbi.atomic_files
Christian Brauner (1):
f2fs: port to vfs{g,u}id_t and associated helpers
Eric Biggers (1):
f2fs: use memcpy_{to,from}_page() where possible
Jaegeuk Kim (6):
f2fs: LFS mode does not support ATGC
f2fs: fix wron
On 10/08, Chao Yu wrote:
> On 2022/10/8 3:53, Jaegeuk Kim wrote:
> > Merged into the original patch.
>
> Thanks, so it looks it's not too later to update commit id of original
> patch since it's close to the end of merge window.
I put this in the next pull request.
Merged into the original patch.
On 10/06, Chao Yu wrote:
> fs/f2fs/super.c:3886:6: warning: no previous prototype for
> 'f2fs_record_stop_reason' [-Wmissing-prototypes]
>
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/
On 10/05, Chao Yu wrote:
> On 2022/10/5 4:28, Jaegeuk Kim wrote:
> > On 10/04, Chao Yu wrote:
> > > This patch supports errors=remount-ro|continue|panic mount option.
> > >
> > > Signed-off-by: Chao Yu
> > > ---
> > > - clean up codes
> &
On 10/01, Chao Yu wrote:
> On 2022/10/1 6:33, Jaegeuk Kim wrote:
> > On 09/30, Chao Yu wrote:
> > > On 2022/9/30 2:27, Jaegeuk Kim wrote:
> > > > On 09/28, Chao Yu wrote:
> > > > > On 2022/9/28 11:15, Jaegeuk Kim wrote:
> > > > > > On
o
read IOs.
Cc: sta...@vger.kernel.org
Fixes: dbf8e63f48af ("f2fs: remove device type check for direct IO")
Signed-off-by: Eunhee Rho
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.
On 09/30, Chao Yu wrote:
> On 2022/9/30 2:27, Jaegeuk Kim wrote:
> > On 09/28, Chao Yu wrote:
> > > On 2022/9/28 11:15, Jaegeuk Kim wrote:
> > > > On 09/28, Chao Yu wrote:
> > > > > On 2022/9/28 0:40, Jaegeuk Kim wrote:
> > > > > >
On 09/29, Chao Yu wrote:
> This patch supports errors=remount-ro|continue|panic mount option.
>
> Signed-off-by: Chao Yu
> ---
> v2:
> - fix to load sb.s_stop_reason during fill_super().
> Documentation/filesystems/f2fs.rst | 4 +
> fs/f2fs/checkpoint.c | 7 +-
> fs/f2fs/f2fs.h
On 09/28, Chao Yu wrote:
> On 2022/9/28 11:15, Jaegeuk Kim wrote:
> > On 09/28, Chao Yu wrote:
> > > On 2022/9/28 0:40, Jaegeuk Kim wrote:
> > > > On 09/25, Chao Yu wrote:
> > > > > Update allocation policy for ro feature:
> > > &g
On 09/28, Chao Yu wrote:
> On 2022/9/28 0:40, Jaegeuk Kim wrote:
> > On 09/25, Chao Yu wrote:
> > > Update allocation policy for ro feature:
> > > - hot_data: allocating blocks by LBA ascending order
> > > - hot_node: allocating blocks by LBA descending orde
On 09/25, Chao Yu wrote:
> Update allocation policy for ro feature:
> - hot_data: allocating blocks by LBA ascending order
> - hot_node: allocating blocks by LBA descending order
This will increase the RO image size.
>
> Signed-off-by: Chao Yu
> ---
> mkfs/f2fs_format.c | 4 ++--
> 1 file chan
I modified a bit.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=a9a1592fa175be43f54f175a972757c47919
Thanks,
On 09/22, Chao Yu wrote:
> Ping,
>
> On 2022/9/13 15:48, Chao Yu wrote:
> > It is possible that ino of dirent or orphan inode is corrupted in
On 09/20, Chao Yu wrote:
> On 2022/9/20 8:56, Jaegeuk Kim wrote:
> > On 09/13, Chao Yu wrote:
> > > Once CP_ERROR_FLAG is set, checkpoint is disallowed to be triggered to
> > > persist CP_FSCK_FLAG, fsck won't repair the image due to lack of
> > > CP_FSCK_
On 09/13, Chao Yu wrote:
> Once CP_ERROR_FLAG is set, checkpoint is disallowed to be triggered to
> persist CP_FSCK_FLAG, fsck won't repair the image due to lack of
> CP_FSCK_FLAG.
>
> This patch proposes to persist newly introduced SB_NEED_FSCK flag into
> super block if CP_ERROR_FLAG and SBI_NEE
Hi Philippe,
Kernel 4.1 is really old one, so is there any chance to upgrade the kernel
at least 4.14? You can find all the backports from below.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-stable.git
On 09/16, Philippe De Muyter wrote:
> Tnank you for your patch.
>
> I have ap
On 09/14, Wu Bo wrote:
> As Philippe De Muyter reported:
> https://lore.kernel.org/linux-f2fs-devel/20220913224908.GA25100@172.21.0.10/T/#u
>
> The warning log showed that when finding a new space for nat the journal
> space turned out to be full. This because the journal_rwsem is not
> locked bef
On 09/14, Chao Yu wrote:
> On 2022/9/14 23:15, Jaegeuk Kim wrote:
> > On 09/14, Chao Yu wrote:
> > > On 2022/8/31 11:05, Jaegeuk Kim wrote:
> > > > On 08/30, Jaegeuk Kim wrote:
> > > > > On 08/30, Chao Yu wrote:
> > > > > > On 2022/8/3
On 09/14, Chao Yu wrote:
> On 2022/9/13 14:04, Jaegeuk Kim wrote:
> > On 09/13, Chao Yu wrote:
> > > On 2022/9/12 23:37, Jaegeuk Kim wrote:
> > > > On 09/08, Chao Yu wrote:
> > > > > Sometimes we can get a cached meta_inode which has no aops yet. Let&
On 09/14, Chao Yu wrote:
> On 2022/8/31 11:05, Jaegeuk Kim wrote:
> > On 08/30, Jaegeuk Kim wrote:
> > > On 08/30, Chao Yu wrote:
> > > > On 2022/8/30 5:52, Jaegeuk Kim wrote:
> > > > > Sometimes we can get a cached meta_inode which has no aops yet. L
On 09/13, Zhang Qilong wrote:
> Found serveral code type errors when review the code and fix it.
> There is no function change.
Could you please combine them into single patch?
Thanks,
>
> Zhang Qilong (3):
> f2fs: insert a space around colon
> f2fs: replace spaces with tabs
> f2fs: fix a
On 09/13, Chao Yu wrote:
> On 2022/9/12 23:37, Jaegeuk Kim wrote:
> > On 09/08, Chao Yu wrote:
> > > Sometimes we can get a cached meta_inode which has no aops yet. Let's set
> > > it
> > > all the time to fix the below panic.
> > >
> &g
On 09/13, Chao Yu wrote:
> On 2022/9/12 23:39, Jaegeuk Kim wrote:
> > On 09/08, Chao Yu wrote:
> > > On 2022/9/8 10:19, Jaegeuk Kim wrote:
> > > > On 09/08, Chao Yu wrote:
> > > > > On 2022/9/8 10:02, Jaegeuk Kim wrote:
> > > >
On 09/08, Chao Yu wrote:
> On 2022/9/8 10:19, Jaegeuk Kim wrote:
> > On 09/08, Chao Yu wrote:
> > > On 2022/9/8 10:02, Jaegeuk Kim wrote:
> > > > On 08/31, Chao Yu wrote:
> > > > > From: Chao Yu
> > > > >
> > > >
k in f2fs_iget() to avoid finding stale
> inode during inner inode initialization.
>
> Cc: sta...@vger.kernel.org
> Reported-by: syzbot+775a3440817f74fdd...@syzkaller.appspotmail.com
> Signed-off-by: Jaegeuk Kim
> Signed-off-by: Chao Yu
> ---
> fs/f2fs/inode.c | 11 +++
On 09/07, Weichao Guo wrote:
> Cold files may be fragmented due to SSR, defragment is needed as
> sequential reads are dominant scenarios of these files. FI_OPU_WRITE
> should override FADVISE_COLD_BIT to avoid defragment fails.
>
> Signed-off-by: Weichao Guo
> Signed-off-by: Chao Yu
> ---
> fs
On 09/08, Chao Yu wrote:
> On 2022/9/8 10:02, Jaegeuk Kim wrote:
> > On 08/31, Chao Yu wrote:
> > > From: Chao Yu
> > >
> > > Introduce f2fs_iget_inner() for f2fs_fill_super() to get inner inode:
> > > meta inode, node inode or compressed inode, and
LZ4_STREAMSIZE_U64 is undefined in new lz4 lib.
Signed-off-by: Jaegeuk Kim
---
fsck/compress.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fsck/compress.c b/fsck/compress.c
index b41349207e38..b15f0a41c46e 100644
--- a/fsck/compress.c
+++ b/fsck/compress.c
@@ -32,10
On 08/31, Chao Yu wrote:
> From: Chao Yu
>
> Introduce f2fs_iget_inner() for f2fs_fill_super() to get inner inode:
> meta inode, node inode or compressed inode, and add f2fs_check_nid_range()
> in f2fs_iget() to avoid getting inner inode from external interfaces.
So, we don't want to check the r
athan Corbet
> Cc: linux-fsde...@vger.kernel.org
> Cc: linux-f2fs-devel@lists.sourceforge.net
> Cc: linux-...@vger.kernel.org
> Cc: Christian Brauner
> Cc: Seth Forshee
> Cc: Al Viro
> Cc: Theodore Ts'o
> Cc: Jaegeuk Kim
> Reviewed-by: Darrick J. Wong
>
On 08/30, Jaegeuk Kim wrote:
> On 08/30, Chao Yu wrote:
> > On 2022/8/30 5:52, Jaegeuk Kim wrote:
> > > Sometimes we can get a cached meta_inode which has no aops yet. Let's set
> > > it
> > > all the time to fix the below panic.
> > >
> &g
On 08/30, Chao Yu wrote:
> On 2022/8/30 5:52, Jaegeuk Kim wrote:
> > Sometimes we can get a cached meta_inode which has no aops yet. Let's set it
> > all the time to fix the below panic.
> >
> > Unable to handle kernel NULL pointer dereference at virtual addre
s-devel@lists.sourceforge.net
> Cc: linux-...@vger.kernel.org
> Cc: Christian Brauner
> Cc: Seth Forshee
For f2fs,
Reviewed-by: Jaegeuk Kim
Thanks,
> ---
> Documentation/filesystems/f2fs.rst |2 +-
> Documentation/filesystems
On 08/30, Chao Yu wrote:
> From: Chao Yu
>
> Introduce f2fs_iget_inner() for f2fs_fill_super() to get inner inode:
> meta inode, node inode or compressed inode, and add f2fs_check_nid_range()
> in f2fs_iget() to avoid getting inner inode from external interfaces.
>
> Signed-off-by: Chao Yu
> --
On 08/29, Jaegeuk Kim wrote:
> On 08/29, Matthew Wilcox wrote:
> > On Mon, Aug 29, 2022 at 10:52:57AM -0700, Jaegeuk Kim wrote:
> > > On 08/25, Andrew Morton wrote:
> > > > (cc fsf2 developers)
> > > >
> > > > On Thu, 25 Aug 2022 08:29:32
: sta...@vger.kernel.org
Reported-by: syzbot+775a3440817f74fdd...@syzkaller.appspotmail.com
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/inode.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index 6d11c365d7b4..1feb0a8a699e 100644
---
On 08/29, Matthew Wilcox wrote:
> On Mon, Aug 29, 2022 at 10:52:57AM -0700, Jaegeuk Kim wrote:
> > On 08/25, Andrew Morton wrote:
> > > (cc fsf2 developers)
> > >
> > > On Thu, 25 Aug 2022 08:29:32 -0700 syzbot
> > > wrote:
> > >
> >
On 08/25, Andrew Morton wrote:
> (cc fsf2 developers)
>
> On Thu, 25 Aug 2022 08:29:32 -0700 syzbot
> wrote:
>
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit:a41a877bc12d Merge branch 'for-next/fixes' into for-kernelci
> > git tree:
> > git://git.kernel
501 - 600 of 1005 matches
Mail list logo
