FS_SINGLE queries

2000-06-10 Thread Richard Gooch
Hi, all. I've just been looking at the FS_SINGLE implementation, and have a few comments: - although not documented, you need to do kern_mount() before trying normal mounts of a FS_SINGLE; perhaps kern_mount()/kern_umount() should be called automatically in

Re: FS_SINGLE queries

2000-06-10 Thread Alexander Viro
On Sat, 10 Jun 2000, Richard Gooch wrote: I see your point. However, that suggests that the naming of /proc/mounts is wrong. Perhaps we should have a /proc/namespace that shows all these VFS bindings, and separately a list of real mounts. What's "real"? /proc/mounts would better left as it

Re: FS_SINGLE queries

2000-06-10 Thread Richard Gooch
Alexander Viro writes: On Sat, 10 Jun 2000, Richard Gooch wrote: I see your point. However, that suggests that the naming of /proc/mounts is wrong. Perhaps we should have a /proc/namespace that shows all these VFS bindings, and separately a list of real mounts. What's "real"?

Re: FS_SINGLE queries

2000-06-10 Thread Alexander Viro
On Sat, 10 Jun 2000, Richard Gooch wrote: What I mean by "real" mounts is a table that shows how each FS was brought into the namespace (or each namespace, once you implement CLONE_NEWNS). So for example: #device filesystem roots /dev/hda1 ext2/

Re: FS_SINGLE queries

2000-06-10 Thread Richard Gooch
Alexander Viro writes: On Sat, 10 Jun 2000, Richard Gooch wrote: What I mean by "real" mounts is a table that shows how each FS was brought into the namespace (or each namespace, once you implement CLONE_NEWNS). So for example: #device filesystem roots /dev/hda1

Re: FS_SINGLE queries

2000-06-10 Thread Richard Gooch
Alexander Viro writes: On Sat, 10 Jun 2000, Richard Gooch wrote: Yeah, sure. I did say "for example". Your format looks fine. One question: is the mount ID really needed? Can't you distinguish based on what FS you're mounting (and mountpoint root)? First of all, interface is

Re: FS_SINGLE queries

2000-06-10 Thread Alexander Viro
On Sat, 10 Jun 2000, Richard Gooch wrote: Will it really make much difference? What would be harder to do without mount IDs? And how much harder? Beware of functions with many arguments... Besides, what about "kill the component of union-mount on /barf NFS-mounted from venus:/foo/bar"? What

Re: FS_SINGLE queries

2000-06-10 Thread Richard Gooch
Alexander Viro writes: On Sat, 10 Jun 2000, Richard Gooch wrote: Will it really make much difference? What would be harder to do without mount IDs? And how much harder? Beware of functions with many arguments... Besides, what about "kill the component of union-mount on /barf NFS-mounted