Re: [Linux-ha-dev] [RFC] Change the behavior of cibadmin on dangerous options

2007-12-04 Thread Andrew Beekhof
ah, sorry, i hadn't seen this patch when i replied earlier. i'll apply something like this tomorrow (i might standardize the on -- force though as its used in other tools too). On Dec 4, 2007, at 6:14 PM, Xinwei Hu wrote: 2007/12/5, Lars Marowsky-Bree <[EMAIL PROTECTED]>: On 2007-12-04T21:2

Re: [Linux-ha-dev] [RFC] Change the behavior of cibadmin on dangerous options

2007-12-04 Thread Andrew Beekhof
i'll implement the --force|-f approach tomorrow. On Dec 4, 2007, at 6:24 PM, Joachim Banzhaf wrote: Hi Hu, Am Dienstag 04 Dezember 2007 14:29:35 schrieb Xinwei Hu: 2007/12/4, Lars Marowsky-Bree <[EMAIL PROTECTED]>: On 2007-12-04T00:20:15, Xinwei Hu <[EMAIL PROTECTED]> wrote: Hi all, We h

Re: [Linux-ha-dev] [RFC] Change the behavior of cibadmin on dangerous options

2007-12-04 Thread Joachim Banzhaf
Hi Hu, Am Dienstag 04 Dezember 2007 14:29:35 schrieb Xinwei Hu: > 2007/12/4, Lars Marowsky-Bree <[EMAIL PROTECTED]>: > > On 2007-12-04T00:20:15, Xinwei Hu <[EMAIL PROTECTED]> wrote: > > > Hi all, > > > > > >We have a instance about cibadmin recently. A typo of 'cibadmin -r > > > blahblah' forc

Re: [Linux-ha-dev] [RFC] Change the behavior of cibadmin on dangerous options

2007-12-04 Thread Xinwei Hu
2007/12/5, Lars Marowsky-Bree <[EMAIL PROTECTED]>: > On 2007-12-04T21:29:35, Xinwei Hu <[EMAIL PROTECTED]> wrote: > > > > The more dangerous commands usually require a --force option on other > > > tools. (fsck, mkfs, rpm, drbdadm, ...) > > The reason that I don't go this way is concerning the port

Re: [Linux-ha-dev] [RFC] Change the behavior of cibadmin on dangerous options

2007-12-04 Thread Lars Marowsky-Bree
On 2007-12-04T21:29:35, Xinwei Hu <[EMAIL PROTECTED]> wrote: > > The more dangerous commands usually require a --force option on other > > tools. (fsck, mkfs, rpm, drbdadm, ...) > The reason that I don't go this way is concerning the portability. > getopt_long is not a POSIX standard AFAIK. Then

[Linux-ha-dev] Re: Heartbeat - Dev: changeset 11628:e4a4c6fd5649

2007-12-04 Thread Alan Robertson
Andrew Beekhof wrote: this commit is wrong - only the children indicated in the process definition are allowed to die please revert this change asap http://hg.linux-ha.org/dev/rev/e4a4c6fd5649 Well... That's not what happens in reality, and as far as I can tell it's expected. When one of y

Re: [Linux-ha-dev] [RFC] Change the behavior of cibadmin on dangerous options

2007-12-04 Thread Xinwei Hu
2007/12/4, Lars Marowsky-Bree <[EMAIL PROTECTED]>: > On 2007-12-04T00:20:15, Xinwei Hu <[EMAIL PROTECTED]> wrote: > > > Hi all, > > > >We have a instance about cibadmin recently. A typo of 'cibadmin -r > > blahblah' forces the HA into RO mode without any warning, and the > > field engineer almo

Re: [Linux-ha-dev] [RFC] Change the behavior of cibadmin on dangerous options

2007-12-04 Thread Lars Marowsky-Bree
On 2007-12-04T00:20:15, Xinwei Hu <[EMAIL PROTECTED]> wrote: > Hi all, > >We have a instance about cibadmin recently. A typo of 'cibadmin -r > blahblah' forces the HA into RO mode without any warning, and the > field engineer almost panic. ;) I like the direction. The more dangerous command

Re: [Linux-ha-dev] [RFC] Change the behavior of cibadmin on dangerous options

2007-12-04 Thread Dejan Muhamedagic
On Mon, Dec 03, 2007 at 07:40:11PM +0100, Andrew Beekhof wrote: > > On Dec 3, 2007, at 7:23 PM, Dejan Muhamedagic wrote: > > >Hi, > > > >On Tue, Dec 04, 2007 at 12:20:15AM +0800, Xinwei Hu wrote: > >>Hi all, > >> > >> We have a instance about cibadmin recently. A typo of 'cibadmin -r > >>blahbla

Re: [Linux-ha-dev] [RFC] Change the behavior of cibadmin on dangerous options

2007-12-04 Thread Dejan Muhamedagic
Hi, On Tue, Dec 04, 2007 at 09:56:50AM +0800, Xinwei Hu wrote: > 2007/12/4, Andrew Beekhof <[EMAIL PROTECTED]>: > > > > On Dec 3, 2007, at 7:23 PM, Dejan Muhamedagic wrote: > > > > > Hi, > > > > > > On Tue, Dec 04, 2007 at 12:20:15AM +0800, Xinwei Hu wrote: > > >> Hi all, > > >> > > >> We have a