Re: [PATCH] hwmon: (nct6775) Integrated new model nct6116

Thanks for the review Guenter, I checked your proposals. Here comes an update of the patch, and I hope this time the format fits as it should. Changes: - simplified differences in register addresses - although kept NCT6116_REG_TEMP_SOURCE, because otherwise the module throughs „Invalid

Re: [PATCH] hwmon: (nct6775) Integrated new model nct6116

Thanks for the review Guenter, I checked your proposals, and here I comes an update of the patch. Changes: - simplified differences in register addresses - fixed fan enablements - simplified case statement Signed-off-by: Bjoern Gerhart --- diff -Naur a/drivers/hwmon/nct6775.c

Re: [PATCH] hwmon: (nct6775) Integrated new model nct6116

Hi Guenter, I reworked the code after studying the details of the spec. Changes: - patch created against the tree of the kernel sources base dir - only define the different registers in contrast to nct6106 - fixed details of the fan configuration Signed-off-by: Bjoern Gerhart --- diff -Naur

Re: [PATCH] hwmon: (nct6775) Integrated new model nct6116

Thanks Guenter! Please see my comments below. > Am 16.07.2019 um 15:44 schrieb Guenter Roeck : > > On 7/15/19 9:47 AM, Björn Gerhart wrote: >> Hello again and thanks for the early feedback! This is the re-worked patch >> of the one I sent last week. It’s created

[PATCH] hwmon: (nct6775) Integrated new model nct6116

Hello again and thanks for the early feedback! This is the re-worked patch of the one I sent last week. It’s created against kernel 5.1.15 and already depends on the preceding patch concerning the same code. The nct6116 is the successor model of nct6106. Mainly, I’m unsure if certain details

[PATCH] hwmon: (nct6775) Fix register address and added missed tolerance for nct6106

Hi Guenter, the patch was created against kernel 5.1.15. Is the corresponding „baseline“ 5.1 then? - Fixed address of third NCT6106_REG_WEIGHT_DUTY_STEP - added missed NCT6106_REG_TOLERANCE_H Signed-off-by: Bjoern Gerhart — Index: nct6775.c

Re: [PATCH] hwmon: (nct6775) Integrated new model nct6116

oh no, the patch is WRONG as I noticed right now. Sorry for the noise! I’ll re-work it and come back! > Am 10.07.2019 um 21:19 schrieb Björn Gerhart : > > The nct6116 is the successor model of nct6106. Mainly I’m unsure about my > changes related to: > - NCT6116_BEEP_BITS >

[PATCH] hwmon: (nct6775) Integrated new model nct6116

The nct6116 is the successor model of nct6106. Mainly I’m unsure about my changes related to: - NCT6116_BEEP_BITS - int cr24 (cr23 is new, and I’m unsure if the code has to get modified therefore) - NCT6116_REG_FAN_PULSES - NCT6116_FAN_PULSE_SHIFT - NCT6116_ALARM_BITS With the nct6116 wired on

[PATCH] hwmon: (nct6775) Fix register address and added missing tolerance

In the process of adding the new model nct6116, two tiny details of the nct6106 attracted my attention. Please find the patch therefore below: Index: nct6775.c === --- nct6775.c (revision 16326) +++ nct6775.c (working copy) @@

(nct6775) adding support for NCT6116D

In September of 2018, Nuvoton released the new SuperIO series 6112D, 6114D and 6116D. On the mainboard I need support for, the NCT6116D is built in, so that’s the model I can test against. Also, I have the datasheet of the series. I would like to add support for the NCT6116D to the nct6775