Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2016-01-04 Thread Ben Dooks
s this behavior(multi-speed) violate the I2C spec? I can't remember if the spec says it, but I would say the bus should run at the speed of the slowest attached peripheral as they all have to listen for the address-byte being sent at the start of each i2c transaction. -- Ben Dooks

Re: [PATCH] i2c: i2c-gpio: fix some of gpio sleep issues

2015-04-22 Thread Ben Dooks
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 27/03/15 17:46, Wolfram Sang wrote: On Tue, Mar 17, 2015 at 12:04:29PM +, Ben Dooks wrote: The i2c-gpio driver can be used in systems where the GPIO itself is provided by a GPIO driver that may be sleeping (for example, SPI or USB

Re: [PATCH] i2c-gpio: add board_info to pdata

2015-04-22 Thread Ben Dooks
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 27/03/15 17:48, Wolfram Sang wrote: On Tue, Mar 17, 2015 at 12:14:55PM +, Ben Dooks wrote: Add board_info so that the i2c-gpio driver can probe devices on probe so that i2c_register_board_info() does not need to be used

Re: [Linux-kernel] [PATCH] i2c: i2c-gpio: fix some of gpio sleep issues

2015-04-22 Thread Ben Dooks
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 22/04/15 11:40, Ben Dooks wrote: On 27/03/15 17:46, Wolfram Sang wrote: On Tue, Mar 17, 2015 at 12:04:29PM +, Ben Dooks wrote: The i2c-gpio driver can be used in systems where the GPIO itself is provided by a GPIO driver that may

[PATCH] i2c: i2c-gpio: fix some of gpio sleep issues

2015-03-17 Thread Ben Dooks
provides open-drain outputs as there are no gpio_direction_xxx_cansleep() provided. This removes the issues on the customer system with the console constantly showing the following warning: WARNING: CPU: 0 PID: 1 at drivers/gpio/gpiolib.c:2389 gpiod_set_raw_value Signed-off-by: Ben Dooks ben.do

[PATCH] i2c-gpio: add board_info to pdata

2015-03-17 Thread Ben Dooks
Add board_info so that the i2c-gpio driver can probe devices on probe so that i2c_register_board_info() does not need to be used. This is preferable for devices that get hotplugged as otherwise we need to do i2c_unregister_board_info() which would be more code. Signed-off-by: Ben Dooks ben.do

Re: [PATCH 3/6] i2c: rcar: do not print error if device nacks transfer

2014-05-09 Thread Ben Dooks
On 08/05/14 23:03, Sergei Shtylyov wrote: Hello. On 01/26/2014 07:05 PM, Ben Dooks wrote: The i2c-rcar driver currently prints an error message if the master_xfer callback fails. However if the bus is being probed then lots of NAKs will be generated, causing the output of a number of errors

[PATCH] i2c-gpio: OF gpio code does not handle defered probe case

2014-03-13 Thread Ben Dooks
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/i2c/busses/i2c-gpio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c index d9f7e18..02d2d4a 100644 --- a/drivers/i2c/busses/i2c-gpio.c +++ b/drivers/i2c/busses/i2c

rcar-i2c: always reads a byte

2014-03-11 Thread Ben Dooks
) rcar_i2c_status_bit_clear(priv, MAT | MDR); else rcar_i2c_status_bit_clear(priv, MAT); } else { rcar_i2c_bus_phase(priv, RCAR_BUS_PHASE_DATA); rcar_i2c_recv_restart(priv); } -- Ben Dooks

Re: rcar-i2c: always reads a byte

2014-03-11 Thread Ben Dooks
On 11/03/14 16:40, Wolfram Sang wrote: On Tue, Mar 11, 2014 at 04:15:02PM +, Ben Dooks wrote: I have noticed the following behaviour with the i2c-rcar driver with the following single i2c_msg structure: msg[0].addr = 0x12; msg[0].flags = I2C_M_RD; msg[0].len = 0

Re: rcar-i2c: always reads a byte

2014-03-11 Thread Ben Dooks
On 11/03/14 16:41, Ben Dooks wrote: On 11/03/14 16:40, Wolfram Sang wrote: On Tue, Mar 11, 2014 at 04:15:02PM +, Ben Dooks wrote: I have noticed the following behaviour with the i2c-rcar driver with the following single i2c_msg structure: msg[0].addr = 0x12; msg[0].flags

Re: rcar-i2c: always reads a byte

2014-03-11 Thread Ben Dooks
On 11/03/14 17:24, Wolfram Sang wrote: or you wait until I posted my IIC enablement series for Lager. I'll post it this evening, forgot to mention that. erm, I already posted patches for i2c on lager. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer

Re: [PATCH 3/4] i2c: rcar: do not print error if device nacks transfer

2014-01-26 Thread Ben Dooks
On 24/01/14 17:11, Wolfram Sang wrote: On Fri, Jan 17, 2014 at 06:11:37PM +, Ben Dooks wrote: The i2c-rcar driver currently prints an error message if the master_xfer callback fails. However if the bus is being probed then lots of NAKs will be generated, causing the output of a number

Re: [PATCH 4/4] i2c: rcar: use devm_clk_get to ensure clock is properly ref-counted

2014-01-26 Thread Ben Dooks
On 24/01/14 17:12, Wolfram Sang wrote: On Fri, Jan 17, 2014 at 06:11:38PM +, Ben Dooks wrote: The current i2c-rcar driver does clk_get() without a corresponding clk_put(). Add the clk to the driver private data and then get it with the devm functions so that it is released when the driver

Re: [PATCH 3/4] i2c: rcar: do not print error if device nacks transfer

2014-01-26 Thread Ben Dooks
On 24/01/14 17:11, Wolfram Sang wrote: On Fri, Jan 17, 2014 at 06:11:37PM +, Ben Dooks wrote: The i2c-rcar driver currently prints an error message if the master_xfer callback fails. However if the bus is being probed then lots of NAKs will be generated, causing the output of a number

[PATCH 6/6] i2c: rcar: fix NACK error code

2014-01-26 Thread Ben Dooks
The response to a bus NACK is to return -ENXIO instead of the -EREMOTEIO being currently returned by the driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Cc: Wolfram Sang w...@the-dreams.de Cc: Simon Horman horms+rene...@verge.net.au Cc: Magnus Damm d...@opensource.se Cc: linux-i2c

[PATCH 4/6] i2c: rcar: use devm_clk_get to ensure clock is properly ref-counted

2014-01-26 Thread Ben Dooks
that is being done by the pm_runtime system underneath the driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Changes since v1: - use PTR_ERR() if devm_clk_get() fails Cc: Simon Horman horms+rene...@verge.net.au Cc: Wolfram Sang w...@the-dreams.de Cc: linux-i2c@vger.kernel.org

[PATCH 3/6] i2c: rcar: do not print error if device nacks transfer

2014-01-26 Thread Ben Dooks
: error -121 : 15 -- i2c-rcar e653.i2c: error -121 : 15 Cc: Simon Horman horms+rene...@verge.net.au Cc: Wolfram Sang w...@the-dreams.de Cc: linux-i2c@vger.kernel.org Cc: linux...@vger.kernel.org Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/i2c/busses/i2c-rcar.c | 2 +- 1 file

[PATCH 5/6] i2c: update i2c_algorithm documentation

2014-01-26 Thread Ben Dooks
Add some kerneldoc style documentaton to the i2c_algorithm structure, and point the master_xfer return codes at the right place in Documentation/i2c/fault_codes Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Cc: Linux I2C List linux-i2c@vger.kernel.org Cc: Wolfram Sang w...@the-dreams.de

[PATCH 3/4] i2c: rcar: do not print error if device nacks transfer

2014-01-18 Thread Ben Dooks
: error -121 : 15 -- i2c-rcar e653.i2c: error -121 : 15 Cc: Simon Horman horms+rene...@verge.net.au Cc: Wolfram Sang w...@the-dreams.de Cc: linux-i2c@vger.kernel.org Cc: linux...@vger.kernel.org Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/i2c/busses/i2c-rcar.c | 2 +- 1 file

Re: [PATCH] EMMA: Add em i2c driver

2013-09-03 Thread Ben Dooks
. also MODULE_DESCRIPTION() is missing MODULE_AUTHOR() is missing -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message

Re: [PATCH] EMMA: Add em i2c driver

2013-08-29 Thread Ben Dooks
that needs to be passed through the device tree binding or something we can detect from the SoC itself? -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] EMMA: Add em i2c driver

2013-08-28 Thread Ben Dooks
(em_i2c_exit); I think there is also a shortcut for the module init/exit for a module that just does platform drivers. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line

Re: [PATCH] MAINTAINERS: fix tree for current i2c-embedded development

2012-09-13 Thread Ben Dooks
/jdelvare-i2c/ -T: git git://git.fluff.org/bjdooks/linux.git +T: git git://git.pengutronix.de/git/wsa/linux.git S: Maintained F: Documentation/i2c/ F: drivers/i2c/ Acked-by: Ben Dooks ben-li...@fluff.org -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada

Re: another i2c/for-next branch

2012-03-02 Thread Ben Dooks
/for-next Would be good to have this in linux-next, yes. Thanks Wolfram for your help! Seconded, Thankyou. I have asked Wolfram to handle things for this merge window as I am currently too busy to give adequate time to it. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron

Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep

2012-03-01 Thread Ben Dooks
. - + * + * Copyright 2012 Freescale Semiconductor, Inc. + * I'd think the change is too trivial to claim copyright on the file. I agree with that. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from

Re: [PATCH] i2c-s3c2410: move resume state flag to end of resume

2012-02-13 Thread Ben Dooks
On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote: From: Kisoo Yu ksoo...@samsung.com need to set flag after finishing its work Signed-off-by: Kisoo Yu ksoo...@samsung.com Signed-off-by: Huisung Kang hs1218.k...@samsung.com --- drivers/i2c/busses/i2c-s3c2410.c |2 +- 1

Re: [PATCH] i2c-s3c2410: move resume state flag to end of resume

2012-02-13 Thread Ben Dooks
On Sun, Feb 12, 2012 at 01:12:31PM +, Mark Brown wrote: On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote: From: Kisoo Yu ksoo...@samsung.com need to set flag after finishing its work - i2c-suspended = 0; clk_enable(i2c-clk); s3c24xx_i2c_init(i2c);

Re: [PATCH 1/4 v2] i2c/gpio: add DT support

2012-02-13 Thread Ben Dooks
On Thu, Feb 09, 2012 at 03:25:05AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: linux-i2c@vger.kernel.org Cc: devicetree-disc...@lists.ozlabs.org --- v2: use devm

Re: Xilinx iic i2c bus interface GPIO support for i2c-mux in Linux.

2012-02-13 Thread Ben Dooks
On Wed, Feb 08, 2012 at 01:46:15PM -0600, Robin Holt wrote: We are using a Xilinx FPGA which implements a series of i2c bus interfaces. We are planning on implementing a single-bit GPIO (XIIC_GPO_REG_OFFSET) which is included in that logic block to act as a MUX selector (also in the FPGA)

Re: [PATCH 1/4] i2c/gpio-i2c add: add DT support

2012-02-13 Thread Ben Dooks
On Mon, Feb 06, 2012 at 07:38:29PM +0100, Karol Lewandowski wrote: On 05.02.2012 11:38, Jean-Christophe PLAGNIOL-VILLARD wrote: Hi! +Device-Tree bindings for i2c gpio driver + +Required properties: +- compatible = gpio-i2c; Driver name is i2c-gpio in file i2c-gpio.c. Previous

Re: [PATCH 2/2] i2c: tegra: Remove unnecessary write to INT_STATUS

2012-02-13 Thread Ben Dooks
On Fri, Feb 03, 2012 at 05:10:17PM -0700, Stephen Warren wrote: From: Alok Chauhan al...@nvidia.com The write is not necessary and may cause the I2C controller to misbehave. With this fix, I2C on Tegra30 works (at least, running i2cdump repeatedly on the WM8903 on Cardhu's I2C5/DVC bus).

Re: [PATCH 3.3 v2] I2C: OMAP: fix build breakage when CONFIG_OF is not set

2012-02-13 Thread Ben Dooks
On Wed, Feb 08, 2012 at 01:18:21PM +0200, Luciano Coelho wrote: Since commit 6145197 (i2c: OMAP: Add DT support for i2c controller), building i2c_omap.c breaks if CONFIG_OF is not set: drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_probe': drivers/i2c/busses/i2c-omap.c:1021: error:

Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt

2012-02-13 Thread Ben Dooks
On Thu, Jan 26, 2012 at 04:13:34PM +, Alan Cox wrote: From: Kristen Carlson Accardi kris...@linux.intel.com Don't call i2c_enable on resume because it causes a spurious interrupt. Signed-off-by: Kristen Carlson Accardi kris...@linux.intel.com Signed-off-by: Kirill A. Shutemov

Re: [PATCH] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Ben Dooks
On Sun, Jan 22, 2012 at 09:39:53PM +, Mark Brown wrote: On Sun, Jan 22, 2012 at 06:48:36PM +0100, Sylwester Nawrocki wrote: On 01/22/2012 06:27 PM, Bill Gatliff wrote: I for one would rather see in-kernel drivers that require it, and then In fact we have to deal with the opposite

Re: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support

2012-02-13 Thread Ben Dooks
: linux-i2c@vger.kernel.org Cc: Ben Dooks ben-li...@fluff.org Cc: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: Sekhar Nori nsek...@ti.com Cc: Wolfgang Denk w...@denx.de --- .../devicetree/bindings/arm/davinci/i2c.txt| 39 ++ drivers

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-02-13 Thread Ben Dooks
On Sat, Jan 21, 2012 at 05:10:22PM +0100, Sylwester Nawrocki wrote: On 01/21/2012 02:28 PM, Mark Brown wrote: Saves remembering to call kfree(). There's some kfree()s used by the resource still, these will be removed in 3.3 using the newly added devm_request_and_ioremap().

Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Ben Dooks
On Sat, Jan 21, 2012 at 01:28:47PM +, Mark Brown wrote: Add stub runtime_pm calls which go through the flow of enabling and disabling but don't actually do anything with the device itself as there's nothing useful we can do. This provides the core PM framework with information about when

Current backlog of email

2012-02-13 Thread Ben Dooks
I'm at the point where I have been so busy that email to both my own account and to several mailing-list boxes is now at the level where there are items from early December 2011 that have not been looked at. Efforts to try and sort this out just make the backlog worse so as of tomorrow I will be

Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt

2012-01-29 Thread Ben Dooks
-designware as the start of the subject. Jean, thanks for clairfying ownership, -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

Re: [PATCH] i2c-davinci: dev-irq is used instead of IRQ_I2C by free_irq

2012-01-19 Thread Ben Dooks
unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from

Re: [PATCH] MAINTAINERS: List i2c-omap and i2c-davinci drivers

2012-01-17 Thread Ben Dooks
On Tue, Jan 10, 2012 at 03:36:40PM +0100, Jean Delvare wrote: This will ensure that the right people and lists are notified when these drivers are modified. sounds like a good idea. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Tony Lindgren t...@atomide.com Cc: Sekhar Nori

Re: [PATCH V2 1/4] i2c: tegra: Add __devinit/exit to probe/remove

2012-01-06 Thread Ben Dooks
with __devexit_p to ensure that it nulls it out. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord

Re: [PATCH V2 1/4] i2c: tegra: Add __devinit/exit to probe/remove

2012-01-06 Thread Ben Dooks
: Acked-by: Ben Dooks ben-li...@fluff.org -- nvpublic -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http

Re: [PATCH v2] i2c: tegra: Add delay before reset the controller

2012-01-06 Thread Ben Dooks
majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord

Re: [GIT PULL] I2C: OMAP: misc. updates for v3.3

2012-01-06 Thread Ben Dooks
/i2c/omap-i2c.txt -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large

Please pull bjdooks' for-linus/i2c-32-rc6 branch

2011-12-18 Thread Ben Dooks
The following changes since commit a36bfddd65b58dd8c8364dba919c04922e04f2f5: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci (2011-12-17 10:40:51 -0800) are available in the git repository at: git://git.fluff.org/bjdooks/linux.git for-linus/i2c-32-rc6

Re: [PATCH] i2c multiplexer driver for Proliant microserver N36L

2011-11-27 Thread Ben Dooks
:/usr/src/lm-sensors/eddi# patch should go inline so it can be reviewed, thanks. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

Re: [PATCH v7 0/5] AT91: replace broken TWI driver i2c-at91.c

2011-11-23 Thread Ben Dooks
.h -- 1.7.5.4 -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada

Re: Still problems wit egt20 i2c driver

2011-11-23 Thread Ben Dooks
on starting -next up again at the weekend. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 3/5] SPI: Add helper macro for spi_driver boilerplate

2011-11-23 Thread Ben Dooks
...@secretlab.ca I'm begining to think we need to make some of these driver and device bits more generic... there seems to be so much similar but not quite the same code. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear

Re: [PATCH] i2c: remove i2c-intel-mid

2011-10-31 Thread Ben Dooks
...@linux.intel.com Cc: Ben Dooks ben-li...@fluff.org Cc: Dirk Brandewie dirk.brande...@gmail.com I will sort this out once the first set of changes is merged, it should be applyable sometime during the early -rc phase. --- drivers/i2c/busses/Kconfig | 10 - drivers/i2c/busses/Makefile|1

Please pull bjdooks' for-linus/i2c-3.2 branch

2011-10-31 Thread Ben Dooks
as well I2C: OMAP1: set i2c unit feature implementation flags in platform data I2C: OMAP2+: Convert omap I2C driver to use feature implementation flags from platform data I2C: OMAP1/OMAP2+: prepend I2C IP version to probed version shown in dev_info Ben Dooks (3): Merge

Re: Problems with i2c_eg20t

2011-10-20 Thread Ben Dooks
. As a result, the test is OK. Let me know how to do your test ? -- tomoya ROHM Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b

Re: [PATCH 00/13] V5 Split i2c-designware.c to support PCI drivers.

2011-10-10 Thread Ben Dooks
On Thu, Oct 06, 2011 at 11:26:24AM -0700, dirk.brande...@gmail.com wrote: From: Dirk Brandewie dirk.brande...@gmail.com This patch set reworks i2c-designware.c to enable supporting multiple Right, applied to branch for-32/i2c/i2c-designware and will be in -next as soon as possible. -- To

Re: [PATCH 3/7] i2c-eg20t: delete 10bit access processing

2011-10-04 Thread Ben Dooks
On Wed, Sep 21, 2011 at 04:51:45PM +0900, Tomoya MORINAGA wrote: Linux I2C core doesn't support 10bit access formally. Additionally, we can't test with 10bit mode. This patch deletes the 10bit access processing. do we want to keep this patch in the series? if not, can you post a new series

Re: [PATCH]1/1 gpio-pca953x.c dynamic assignment and higher verbosity

2011-10-04 Thread Ben Dooks
On Mon, Oct 03, 2011 at 11:53:44PM +0200, Hartmut Knaack wrote: Hi there, this patch adds the following features to gpio-pca953x.c: - set gpiobase to auto (-1) in case no platform data or openfirmware config are provided - show some details about the registered gpio-chip in kernel log (highly

Re: [PATCH 32/55] i2c: irq: Remove IRQF_DISABLED

2011-10-04 Thread Ben Dooks
[b738a50a: genirq: Warn when handler enables interrupts]). So now this flag is a NOOP and can be removed. ok, applied thanks. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send

Re: [GIT PULL] I2C: OMAP: misc. cleanup for v3.2

2011-10-04 Thread Ben Dooks
On Mon, Sep 26, 2011 at 03:30:50PM -0700, Kevin Hilman wrote: ping On 09/06/2011 03:31 PM, Kevin Hilman wrote: Hi Ben, On 08/23/2011 05:10 PM, Kevin Hilman wrote: Ben, Here's one more I2C cleanup series for v3.2. It applies on top of my for_3.2/i2c-fixes branch just submitted.

Re: [PATCH 1/2 v3] i2c: i2c-riic: add support for Renesas RIIC

2011-10-04 Thread Ben Dooks
On Mon, Sep 26, 2011 at 05:41:48PM +0900, Yoshihiro Shimoda wrote: This driver supports the RIIC module. The SH7757 has it. The driver doesn't use any IRQ handler. This is because the module has errata in an interrupt. So, we cannot use the interrupt for transfer. anyone care to comment on

Re: [PATCH v3 0/2] Add device tree support for Samsung's I2C driver

2011-09-15 Thread Ben Dooks
On Tue, Sep 13, 2011 at 09:46:03AM +0530, Thomas Abraham wrote: This patchset adds device tree support for Samsung's I2C driver. I've applied these after a brief review. I'll give them a better review before the weekend. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in

Re: [PATCH v3 0/2] Add device tree probe for i2c-imx driver

2011-09-15 Thread Ben Dooks
| 46 +-- 3 files changed, 40 insertions(+), 28 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b

Re: [PATCH RESEND] i2c-pxa2xx: return proper error code in ce4100_i2c_probe error paths

2011-09-06 Thread Ben Dooks
On Tue, Aug 30, 2011 at 02:37:37PM +0800, Axel Lin wrote: Signed-off-by: Axel Lin axel@gmail.com Acked-by: Sebastian Andrzej Siewior bige...@linutronix.de A message in the patch description body is always useful. Will apply. --- Hi Ben, Seems this patch is not yet upstream. Here is the

Please pull bjdooks' for-31-rc5/i2c-fixes branch

2011-09-06 Thread Ben Dooks
The following changes since commit 9e79e3e9dd9672b37ac9412e9a926714306551fe: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc (2011-08-30 11:28:18 -0700) are available in the git repository at: git://git.fluff.org/bjdooks/linux.git for-31-rc5/i2c-fixes Axel Lin (1):

Re: [PATCH REPOST 0/3] i2c: tegra: Outstanding patches

2011-09-06 Thread Ben Dooks
On Tue, Aug 30, 2011 at 11:46:07AM -0600, Stephen Warren wrote: For convenience, here's a repost of the outstanding patches for the Tegra I2C driver. applied all of them. in future, it would be helpful to have just i2c-tegra on the front of the subject. fixed these up and put them in pull req

Re: [GIT PULL] I2C: OMAP: major cleanup for v3.2 (was for v3.1)

2011-08-24 Thread Ben Dooks
deletions(-) -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PULL] Please pull i2c fixes

2011-08-24 Thread Ben Dooks
The following changes since commit a53e77fa57145cef6e2a63925db3d426128b2335: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid (2011-08-24 11:25:08 -0700) are available in the git repository at: git://git.fluff.org/bjdooks/linux.git for-31-rc3/i2c-fixes

Re: [PATCH] i2c: tegra: Check for overflow errors with BUG_ON.

2011-08-23 Thread Ben Dooks
On Mon, Aug 15, 2011 at 11:03:50PM +0300, Felipe Balbi wrote: HI, On Mon, Aug 15, 2011 at 12:52:36PM -0700, Doug Anderson wrote: Felipe, On Mon, Aug 15, 2011 at 12:17 PM, Felipe Balbi ba...@ti.com wrote: so due to a FIFO overflow you lock up the whole system ? Can't you e.g. reset

Re: [PATCH 0/2] lost i2c-nomadik patches

2011-08-11 Thread Ben Dooks
insertions(+), 4 deletions(-) -- 1.7.3.2 -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org

Re: Tegra I2C driver compilation failure (was: RE: [PATCH] dt: add empty of_get_property for non-dt)

2011-08-11 Thread Ben Dooks
is probably a better function to call. -- nvpublic -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord

Re: [PATCH] i2c: tegra: Add CONFIG_OF guards for device tree bits

2011-08-05 Thread Ben Dooks
of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] i2c-designware: add OF binding support

2011-08-04 Thread Ben Dooks
-disc...@lists.ozlabs.org Cc: Ben Dooks ben-li...@fluff.org Cc: linux-i2c@vger.kernel.org --- Documentation/devicetree/bindings/i2c/dw-i2c.txt | 23 ++ drivers/i2c/busses/i2c-designware.c | 13 2 files changed, 36 insertions(+), 0 deletions

Re: [PATCH] i2c: imx: choose the better clock divider

2011-08-04 Thread Ben Dooks
of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe

omap patches

2011-08-02 Thread Ben Dooks
Hi, should I have been queing these, or is someone else dealing with the dependencies between the omap arch and these driver updates? -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h

2011-07-31 Thread Ben Dooks
. Applied to module.h-split, thanks. ok, so I don't need to apply this one? Acked-by: Ben Dooks ben-li...@fluff.org P. Signed-off-by: Randy Dunlap rdun...@xenotime.net ---  drivers/i2c/busses/i2c-pxa-pci.c |    1 +  1 file changed, 1 insertion(+) --- linux-next-20110729.orig

Re: [PATCH v2 0/3] Add device tree support for Samsung's I2C driver

2011-07-27 Thread Ben Dooks
/samsung-i2c.txt -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large

Re: [PATCH 2/2] arm: dt: Add device tree support for i2c instance 1 on exynos4 dt machine

2011-07-18 Thread Ben Dooks
part of the SoC, I don't really want to see n different .dts files hanging around with the same information in it. Maybe it is time for a standardised callback to allow devices to connect themselves to the pins they need, and have dt capability of over-riding the information if it needs it. -- Ben

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

2011-07-13 Thread Ben Dooks
On Tue, Jul 05, 2011 at 05:01:01PM -0700, Kevin Hilman wrote: Shubhrajyoti D shubhrajy...@ti.com writes: Currently the fifo depth is set to zero for OMAP4 which disables the FIFO usage. This patch enables the FIFO usage for I2C transactions on OMAP4 also. Tested on omap4430 and 3430.

Re: [PATCH][RFC] OMAP4: I2C : I2C context save

2011-07-13 Thread Ben Dooks
On Tue, Jul 05, 2011 at 02:50:46PM +0530, Shubhrajyoti D wrote: Currently the OMAP4 doesnot hit device off still the driver may have support for it.Adding support for the same. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com I guess since the previous set has been taken by Kevin then

Re: [PATCH 2/2] i2c: i2c-riic: add dmaengine supporting

2011-07-13 Thread Ben Dooks
On Fri, Jul 01, 2011 at 10:00:50AM +0900, Yoshihiro Shimoda wrote: We can use the dmaengine for the driver, if the dma_tx and/or dma_rx in riic_platform_data is set. If we use it, we have to set the irq number for EEI in the resource. Signed-off-by: Yoshihiro Shimoda

Re: [PATCH] i2c: Support for Netlogic XLR/XLS on-chip I2C controller.

2011-07-13 Thread Ben Dooks
On Thu, Jun 23, 2011 at 07:21:03PM +0530, Jayachandran C. wrote: From: Ganesan Ramalingam ganes...@netlogicmicro.com - platform.c : add i2c platform device - i2c-xlr.c : algorithm and i2c adaptor - Kconfig/Makefile: add CONFIG_I2C_XLR option Signed-off-by: Ganesan Ramalingam

Re: [PATCH RESEND] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality

2011-07-13 Thread Ben Dooks
On Mon, Jul 11, 2011 at 12:49:33AM -0700, Colin Cross wrote: On Mon, Jul 11, 2011 at 12:37 AM, m...@compulab.co.il wrote: Hi Ben, This patch has been waiting for quite a long time and I've got no response from you concerning it. Can you _please_ at last merge it so it'll make to 3.1?

Re: [PATCH v4 00/18] I2C: OMAP: I2C fixes, removal of cpu_is... from driver

2011-07-07 Thread Ben Dooks
via the OMAP tree if at all possible so we can properly handle the conflicts. Do you mind dropping it from your next-i2c so we can merge it via linux-omap (with your Ack.) Yes, and if you could indicate all the other omap i2c patches and I'll add my ack to yours. Acked-by: Ben Dooks ben-li

[PULL] Please pull i2c fixes

2011-07-07 Thread Ben Dooks
/all-i2c Ben Dooks (1): Merge branches 'for-30-rc4/i2c-bfin', 'for-30-rc4/i2c-omap', 'for-30-rc4/i2c-s3c' and 'for-30-rc4/i2c-tegra' into for-30-rc5/all-i2c Huisung Kang (1): i2c-s3c2410: Fix typo 'i2s' - 'i2c' Jonghwan Choi (1): i2c-s3c2410: Remove useless break code Sonic

[PULL] Please pull i2c fixes

2011-07-07 Thread Ben Dooks
..BRANCH.NOT.VERIFIED.. Ben Dooks (1): Merge branches 'for-30-rc4/i2c-bfin', 'for-30-rc4/i2c-omap', 'for-30-rc4/i2c-s3c' and 'for-30-rc4/i2c-tegra' into for-30-rc5/all-i2c Huisung Kang (1): i2c-s3c2410: Fix typo 'i2s' - 'i2c' Jonghwan Choi (1): i2c-s3c2410: Remove useless break code

Re: [PATCH] i2c-eg20t: Do not print error message if no ACK is received

2011-06-28 Thread Ben Dooks
the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear

Re: [PATCH 05/13] i2c-designware: split of i2c-designware.c into core and bus specific parts

2011-06-15 Thread Ben Dooks
as a note: Applying: i2c-designware: split of i2c-designware.c into core and bus specific parts /home/ben/linux.git/.git/rebase-apply/patch:56: new blank line at EOF. + warning: 1 line adds whitespace errors. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large

Re: [PATCH 13/13] i2c-intel-mid.c: Remove i2c-intel-mid.c

2011-06-15 Thread Ben Dooks
Applying: i2c-intel-mid.c: Remove i2c-intel-mid.c error: patch failed: drivers/i2c/busses/i2c-intel-mid.c:1 error: drivers/i2c/busses/i2c-intel-mid.c: patch does not apply Patch failed at 0013 i2c-intel-mid.c: Remove i2c-intel-mid.c -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large

Re: [PATCH v4 00/18] I2C: OMAP: I2C fixes, removal of cpu_is... from driver

2011-06-15 Thread Ben Dooks
-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] i2c: tegra: Assign unused slave address

2011-06-15 Thread Ben Dooks
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

Re: [PATCH] i2c-au1550: increase timeout waiting for transactions to finish

2011-06-15 Thread Ben Dooks
/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] staging iio: Replace kmalloc with local variable

2011-06-07 Thread Ben Dooks
in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line

Re: [PATCH v4 00/18] I2C: OMAP: I2C fixes, removal of cpu_is... from driver

2011-06-07 Thread Ben Dooks
://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More

[PULL] please pull bjdooks' i2c branch

2011-05-24 Thread Ben Dooks
Ben Dooks (1): Merge branches 'for-2639/i2c-eg20t', 'for-2639/i2c-shmobile', 'for-2639/i2c-tegra' and 'for-2639/i2c-nomadik2' into for-linus/2640/i2c Erik Gilling (1): i2c: tegra: fix repeated start handling Jay Cheng (1): i2c: tegra: Add de-bounce cycles. Jonas Aberg (1

bjdooks' current i2c-next

2011-05-12 Thread Ben Dooks
/tiwai/sound-2.6 (2011-05-12 12:41:30 -0700) are available in the git repository at: git://git.fluff.org/bjdooks/linux.git next-i2c Ben Dooks (2): Merge branches 'for-2639/i2c-shmobile', 'for-2639/i2c-eg20t' and 'for-2639/i2c-tegra' into next-i2c Merge branch 'for-2639/i2c-nomadik

Re: [PATCH] i2c: Adding the i2c-bit-platform bus

2011-05-10 Thread Ben Dooks
On Sat, May 07, 2011 at 02:53:05PM +0300, Eran Duchan wrote: Hi guys, Following the discussion on the matter of i2c-gpio performance, I'm submitting this very simple patch which adds i2c-bit-platform. Using this driver, a platform can register callbacks called by i2c-bit-algo so that it can

Re: [PATCH 09/13] i2c/i2c-nomadik: add code to retry on timeout failure

2011-05-10 Thread Ben Dooks
On Mon, May 09, 2011 at 11:38:19PM +0200, Linus Walleij wrote: From: Virupax Sadashivpetimath virupax.sadashivpetim...@stericsson.com It is seen that i2c-nomadik controller randomly stops generating the interrupts leading to a i2c timeout. As a workaround to this problem, add retries to the

Re: [PATCH 00/13] Various updates to the Nomadik I2C controller

2011-05-10 Thread Ben Dooks
On Mon, May 09, 2011 at 11:34:37PM +0200, Linus Walleij wrote: A lot of internal refining of this driver has happened on this driver inside ST-Ericsson since last kernel cycle. Here are the accumulated changes. I have NOT squashed any development history this time, since I was severely beat up

Re: [PATCH] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality

2011-05-04 Thread Ben Dooks
(struct i2c_adapter *adap, struct i2c_msg msgs[], static u32 tegra_i2c_func(struct i2c_adapter *adap) { - return I2C_FUNC_I2C; + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; } I think this is ok, but will check tomorrow -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben

Re: [REPOST PATCH] i2c: pxa2xx: remove ifdef CONFIG_OF

2011-05-04 Thread Ben Dooks
removed this ifdefs from all driver which were in tree at the time, this one was merged later. Acked-by: Grant Likely grant.lik...@secretlab.ca Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Hey Ben, Can you pick up this patch? ok, will sort this out. -- Ben Dooks

  1   2   3   4   >