[PATCH 1/2] i2c: xiic: Implement Power management

Enable power management. This patch enables the clocks before transfer and disables after the transfer. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/i2c/busses/i2c-xiic.c | 86 +--- 1 files changed, 79 insertions(+), 7 del

[PATCH 2/2] bindings: i2c: Add clock entries for i2c-xiic

Add clock description for i2c-xiic Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- Documentation/devicetree/bindings/i2c/i2c-xiic.txt |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-xiic.txt b/Documen

Re: [PATCH 0/2] i2c: proper RuntimePM for the adapter device

On Fri, Dec 25, 2015 at 3:55 AM, Wolfram Sang wrote: >> I think the below drivers >> >> drivers/i2c/busses/i2c-at91.c >> drivers/i2c/busses/i2c-designware-core.c >> drivers/i2c/busses/i2c-designware-platdrv.c >> drivers/i2c/busses/i2c-rcar.c >>

Re: [PATCH 0/2] i2c: proper RuntimePM for the adapter device

> >> Also maybe we can add a flag that the driver enables. >> that way for a short period till the driver removes the call >> the double call is not there. > > The only driver I found was the s3c2410 and I fixed it. Is there another > one? Then, I'd update my series because I want a consistent

Re: [PATCH 0/2] i2c: proper RuntimePM for the adapter device

On Wed, Dec 23, 2015 at 10:49 PM, Wolfram Sang wrote: > RuntimePM for the logical adapter device should be handled in a central place > by the core, and not by drivers. This series does exactly that. This is good idea. > > This is the first step of harmonizing RuntimePM

Re: [PATCH v2] i2c: cadence: Move to sensible power management

On Tue, Nov 24, 2015 at 12:17 AM, Sören Brinkmann <soren.brinkm...@xilinx.com> wrote: > On Sat, 2015-11-21 at 07:00PM +0530, Shubhrajyoti Datta wrote: >> On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta >> <shubhrajyoti.da...@gmail.com> wrote: >> > On

[PATCHv3 2/2] i2c: cadence: Remove the suspended flag

The suspended flag is a flag holding the device's PM status. The runtime framework does that for us. Use pm_runtime_suspended call instead. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- v3: split the patches drivers/i2c/busses/i2c-cadence.c |7 +-- 1 files chan

[PATCHv3 1/2] i2c: cadence: Move to sensible power management

. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- v2: update the cc list v3: split the runtime and the suspended flag change drivers/i2c/busses/i2c-cadence.c | 66 ++ 1 files changed, 45 insertions(+), 21 deletions(-) diff --git a/drive

Re: [PATCH v2] i2c: cadence: Move to sensible power management

On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta <shubhrajyoti.da...@gmail.com> wrote: > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann > <soren.brinkm...@xilinx.com> wrote: >> Hi Shubhrajyoti, >> >> >> On Wed, 2015-10-28 at 12:56PM +0530, Shubhraj

Re: [PATCH 1/3] i2c: Revert "i2c: xiic: Do not reset controller before every transfer"

On Wed, Nov 18, 2015 at 3:31 PM, Lars-Peter Clausen <l...@metafoo.de> wrote: > On 11/17/2015 03:28 PM, Shubhrajyoti Datta wrote: >> On Tue, Nov 17, 2015 at 1:04 PM, Lars-Peter Clausen <l...@metafoo.de> wrote: >>> On 11/17/2015 06:17 AM, Shubhrajyoti Datta wrote: >

Re: [PATCH 1/3] i2c: Revert "i2c: xiic: Do not reset controller before every transfer"

On Tue, Nov 17, 2015 at 1:04 PM, Lars-Peter Clausen <l...@metafoo.de> wrote: > On 11/17/2015 06:17 AM, Shubhrajyoti Datta wrote: >> On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen <l...@metafoo.de> wrote: >>> Commit d701667bb331 ("i2c: xiic: Do not reset c

Re: [PATCH 3/3] i2c: xiic: Replace spinlock with mutex

On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen wrote: > All protected sections are only called from sleep-able context, so there is > no need to use a spinlock. Looks good to me. Feel free to add my reviewed by. > > Signed-off-by: Lars-Peter Clausen > ---

Re: [PATCH 1/3] i2c: Revert "i2c: xiic: Do not reset controller before every transfer"

On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen wrote: > Commit d701667bb331 ("i2c: xiic: Do not reset controller before every > transfer") removed the reinitialization of the controller before the start > of each transfer. Apparently this change is not safe to make and the

Re: [PATCH 3/3] i2c: xiic: Replace spinlock with mutex

On Tue, Nov 17, 2015 at 10:48 AM, Shubhrajyoti Datta <shubhrajyoti.da...@gmail.com> wrote: > On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen <l...@metafoo.de> wrote: >> All protected sections are only called from sleep-able context, so there is >> no need to use

Re: [PATCH 2/3] i2c: xiic: Prevent concurrent running of the IRQ handler and __xiic_start_xfer()

[] (do_vfs_ioctl) from [] (SyS_ioctl+0x34/0x5c) > [] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x34) > Code: e283300c e5843210 eafffe64 e5943210 (e1d320b4) > > The issue can easily be reproduced by performing I2C access under high > system load or IO load. > > To

Re: [PATCH 1/3] i2c: Revert "i2c: xiic: Do not reset controller before every transfer"

On Tue, Nov 17, 2015 at 10:47 AM, Shubhrajyoti Datta <shubhrajyoti.da...@gmail.com> wrote: > On Mon, Nov 16, 2015 at 7:12 PM, Lars-Peter Clausen <l...@metafoo.de> wrote: >> Commit d701667bb331 ("i2c: xiic: Do not reset controller before every >> transfe

Re: [PATCH v2] i2c: cadence: Move to sensible power management

On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann <soren.brinkm...@xilinx.com> wrote: > Hi Shubhrajyoti, > > > On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote: >> Currently the clocks are enabled at probe and disabled at remove. >> Which keeps the clocks

Re: [PATCH] i2c: cadence: Move to sensible power management

On Sun, Oct 25, 2015 at 9:10 PM, Wolfram Sang <w...@the-dreams.de> wrote: > On Thu, Oct 15, 2015 at 05:56:55PM +0530, Shubhrajyoti Datta wrote: >> Currently the clocks are enabled at probe and disabled at remove. >> Which keeps the clocks enabled even if no transaction is go

[PATCH v2] i2c: cadence: Move to sensible power management

ead. converts dev pm to const to silence a checkpatch warning. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- changes since v2 update the cc list drivers/i2c/busses/i2c-cadence.c | 73 -- 1 files changed, 46 insertions(+), 27 deletions(-) d

Re: [PATCHv2] i2c: cadence: Enable power management

On Wed, Oct 28, 2015 at 11:34 AM, Shubhrajyoti Datta <shubhrajyoti.da...@xilinx.com> wrote: > Currently the clocks are enabled at probe and disabled at remove. > This patch enables the clocks at the start of transfer and disables > after it. > > Also adapts to runtime pm. >

[PATCHv2] i2c: cadence: Enable power management

ned-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- changes since v1: update the cc list. drivers/i2c/busses/i2c-cadence.c | 74 -- 1 files changed, 47 insertions(+), 27 deletions(-) diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/b

Re: [PATCH] i2c: pnx: fix warnings caused by enabling unprepared clock

On Mon, Oct 19, 2015 at 11:49 PM, Vladimir Zapolskiy <v...@mleia.com> wrote: > On 19.10.2015 19:21, Shubhrajyoti Datta wrote: >> On Sun, Oct 18, 2015 at 12:22 AM, Vladimir Zapolskiy <v...@mleia.com> wrote: >>> If common clock framework is configured, the driver

Re: [PATCH] i2c: pnx: fix warnings caused by enabling unprepared clock

On Sun, Oct 18, 2015 at 12:22 AM, Vladimir Zapolskiy wrote: > If common clock framework is configured, the driver generates a warning, > which is fixed by this change: Maybe just describe the issue and the fix. Is it just a warning or the clk enable doesn't work ? I feel the

Re: [PATCH] i2c: cadence: Move to sensible power management

On Thu, Oct 15, 2015 at 5:56 PM, Shubhrajyoti Datta <shubhrajyoti.da...@xilinx.com> wrote: > Currently the clocks are enabled at probe and disabled at remove. > Which keeps the clocks enabled even if no transaction is going on. > This patch enables the clocks at the start of transf

[PATCH] i2c: cadence: Move to sensible power management

ead. converts dev pm to const to silence a checkpatch warning. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/i2c/busses/i2c-cadence.c | 73 -- 1 files changed, 46 insertions(+), 27 deletions(-) diff --git a/drivers/i2c/busses/i2c-ca

Re: [Patch V8] i2c: imx: add runtime pm support to improve the performance

clk_enable is called here. enables the clock here. > > The calling sequence is: > pm_runtime_use_autosuspend(>dev); > pm_runtime_set_active(>dev); > pm_runtime_enable(>dev); > pm_runtime_get_sync(>dev); are we not enabling it again? there by effectively disabling pm. Or did I missing something.

Re: [PATCH-v5 2/5] i2c: pxa: enable/disable i2c module across msg xfer

hi , On Tue, Jul 21, 2015 at 6:11 PM, Vaibhav Hiremath vaibhav.hirem...@linaro.org wrote: From: Yi Zhang yizh...@marvell.com Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be disturbed if the slave device, typically a touch,

Re: [PATCHv2 2/9] i2c: xiic: move the xiic_process to thread context

On Fri, Jul 10, 2015 at 1:23 PM, Wolfram Sang w...@the-dreams.de wrote: On Fri, Jul 10, 2015 at 10:38:11AM +0530, Shubhrajyoti Datta wrote: On Thu, Jul 9, 2015 at 11:01 PM, Wolfram Sang w...@the-dreams.de wrote: static int xiic_bus_busy(struct xiic_i2c *i2c) @@ -602,16 +601,21 @@ static

Re: [PATCHv2 6/9] i2c: xiic: Add a debug msg in case of timeout

On Thu, Jul 9, 2015 at 10:59 PM, Wolfram Sang w...@the-dreams.de wrote: On Wed, Jun 17, 2015 at 08:48:16PM +0530, Shubhrajyoti Datta wrote: Currently we return silently upon a timeout. Adding an error message to aid debugability. Not a functional change. Signed-off-by: Shubhrajyoti Datta

Re: [PATCHv2 0/9] i2c: xiic: cleanups

On Thu, Jul 9, 2015 at 11:05 PM, Wolfram Sang w...@the-dreams.de wrote: On Wed, Jun 17, 2015 at 08:48:10PM +0530, Shubhrajyoti Datta wrote: This is a series of cleanups for the axi iic. tested on zc702 and microblaze. Changes from v1 Updated the commit message. Shubhrajyoti Datta (9

RE: [PATCH 1/9] i2c: xiic: Do not continue in case of errors in Rx

-Original Message- From: Wolfram Sang [mailto:w...@the-dreams.de] Sent: Wednesday, June 17, 2015 5:12 PM To: Shubhrajyoti Datta Cc: linux-i2c@vger.kernel.org; Shubhrajyoti Datta Subject: Re: [PATCH 1/9] i2c: xiic: Do not continue in case of errors in Rx Hi, On Mon, Jun 15, 2015

[PATCHv2 3/9] i2c: xiic: Do not reset controller before every transfer

Currently before every transfer the controller is reinitialised. We are already resetting the controller upon errors so upon every transfer is a performance kill. Remove the same. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |1 - 1 files changed, 0

[PATCHv2 4/9] i2c: xiic: Remove the disabling of interrupts

-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 92ea52a..d9501ab 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c

[PATCHv2 8/9] i2c: xiic: Service all interrupts in isr

Currently only one interrupt is serviced in the isr. In case the multiple interrupts happen simultenously we service and ack only one of them. Check for all the causes in the isr and service them. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c | 24

[PATCHv2 9/9] i2c: xiic: Do not continue in case of errors in Rx

In case of error conditions like Arbitration lost or NACK lets signal the waiting process. Handle error cases in the Rx path Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCHv2 6/9] i2c: xiic: Add a debug msg in case of timeout

Currently we return silently upon a timeout. Adding an error message to aid debugability. Not a functional change. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses

[PATCHv2 0/9] i2c: xiic: cleanups

This is a series of cleanups for the axi iic. tested on zc702 and microblaze. Changes from v1 Updated the commit message. Shubhrajyoti Datta (9): i2c: xiic: Remove the disabling of interrupts i2c: xiic: move the xiic_process to thread context i2c: xiic: Do not reset controller before

[PATCHv2 5/9] i2c: xiic: Remove busy loop while waiting for bus busy

Remove the busy loop while waiting for bus busy. Instead let the processor sleep. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses

[PATCHv2 1/9] i2c: xiic: Remove the disabling of interrupts

-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 4dda23f..912780a 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c

[PATCHv2 7/9] i2c: xiic: Remove the Addressed as slave interrupt

Currently there is no slave mode support in the driver also in the isr we just ack it and do nothing. So disable the AAS interrupt. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCHv2 2/9] i2c: xiic: move the xiic_process to thread context

The xiic_process is a 154 line code that runs in isr context currently move it to thread context. Also the name xiic_process suggests that the intension was to run in process context. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c | 33

[PATCH 0/9] i2c: xiic: cleanups

This is a series of cleanups for the axi iic. tested on zc702 and microblaze. Shubhrajyoti Datta (9): i2c: xiic: Do not continue in case of errors in Rx i2c: xiic: Remove the disabling of interrupts i2c: xiic: move the xiic_process to thread context i2c: xiic: Do not reset controller

[PATCH 6/9] i2c: xiic: Remove busy loop while waiting for bus busy

Remove the busy loop while waiting for bus busy. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 7b81aac..8142c2e

[PATCH 2/9] i2c: xiic: Remove the disabling of interrupts

Currently the interrupts are disabled at the start of the isr and enabled at the end of the isr. Remove the same. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses

[PATCH 7/9] i2c: xiic: Add a msg in case of timeout

Timing out is one of the serious errors. Currently we return silently upon a timeout. Adding an error message. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c

[PATCH 1/9] i2c: xiic: Do not continue in case of errors in Rx

Handle error cases in the Rx path Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 4dda23f..cea842e 100644

[PATCH 5/9] i2c: xiic: Remove the disabling of interrupts

Currently before every transfer the interrupts are disabled. Remove the same. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses

[PATCH 4/9] i2c: xiic: Do not reset controller before every transfer

Currently before every transfer the controller is reinitialised. Remove the same. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses

[PATCH 8/9] i2c: xiic: Remove the Addressed as slave interrupt

Currently there is no slave mode. Do not enable the AAS interrupt. Signed-off-by: Shubhrajyoti Datta shubh...@xilinx.com --- drivers/i2c/busses/i2c-xiic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index

Re: [PATCH-V2 03/12] i2c: pxa: Return I2C_RETRY when timeout in pio mode

On Mon, Jun 15, 2015 at 9:19 PM, Vaibhav Hiremath vaibhav.hirem...@linaro.org wrote: From: Shouming Wang wang...@marvell.com In case of timeout in pio mode of operation return I2C_RETRY. This behavior will be same as interrupt mode of operation. Signed-off-by: Shouming Wang

Re: [Patch v1] i2c: imx: add runtime pm support to improve the performance

On Thu, Jun 11, 2015 at 7:20 AM, Gao Pan b54...@freescale.com wrote: In our former i2c driver, i2c clk is enabled and disabled in xfer function, which contributes to power saving. However, the clk enable process brings a busy wait delay until the core is stable. As a result, the performance is

Re: [Patch v1] i2c: imx: add runtime pm support to improve the performance

snip static irqreturn_t i2c_imx_isr(int irq, void *dev_id) @@ -583,6 +582,9 @@ static irqreturn_t i2c_imx_isr(int irq, void *dev_id) struct imx_i2c_struct *i2c_imx = dev_id; unsigned int temp; + if (pm_runtime_suspended(i2c_imx-adapter.dev.parent)) +

Re: [PATCH] i2c: tegra: remove warning dump if timeout happen in transfer

On Thu, Feb 14, 2013 at 6:13 PM, Laxman Dewangan ldewan...@nvidia.com wrote: If timeout error occurs in the i2c transfer then it was dumping warning of call stack. Remove the warning dump as there is may be possibility that some slave devices are busy and not responding the i2c communication.

Re: [PATCH RFC] i2c: omap: Remove the OMAP_I2C_IP_VERSION_*

On Mon, Nov 26, 2012 at 5:22 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Nov 26, 2012 at 05:09:42PM +0530, Shubhrajyoti D wrote: The OMAP_I2C_IP_VERSION_1 and OMAP_I2C_IP_VERSION_2 was needed as on VER2 we were not reading all the 32-bits. Since now that we read the hi register we do

Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera tushar.beh...@linaro.org wrote: This patchset cleans up the probe function of i2c-s3c2410 driver. These have been tested on Exynos4210 based Origen board. Tushar Behera (7): i2c: s3c2410: Remove unnecessary label err_noclk i2c: s3c2410:

Re: [PATCH 065/493] i2c: remove use of __devexit_p

On Mon, Nov 19, 2012 at 11:50 PM, Bill Pemberton wf...@virginia.edu wrote: CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. Reviewed-by: Shubhrajyoti D shubhrajy...@ti.com -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a

Re: [PATCHv3] i2c: omap: Move the remove constraint

On Fri, Nov 16, 2012 at 7:50 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Thu, Nov 15, 2012 at 02:19:21PM +0530, Shubhrajyoti D wrote: Currently we just queue the transfer and release the qos constraints, however we do not wait for the transfer to complete to release the constraint. Move

Re: [PATCHv2] i2c: omap: Move the remove constraint

On Thu, Nov 15, 2012 at 1:46 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi Shubhrajyoti, On Thu, Nov 15, 2012 at 8:34 AM, Shubhrajyoti D shubhrajy...@ti.com wrote: Currently we just queue the transfer and release the qos constraints, however we donot wait for the transfer Typo: donot

Re: [PATCH] i2c: omap: don't save a value only needed for read-clearing

On Thu, Nov 15, 2012 at 12:20 AM, Wolfram Sang w.s...@pengutronix.de wrote: This makes one of my code analyzers happy and makes me a part of the anything open source which we could all be using ? :-) 'my' as in 'one of those I am using'. It was cppcheck which found that flaw. Its use for

Re: [PATCHv3 0/7] i2c: omap: updates

On Mon, Nov 5, 2012 at 5:53 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: Does the followiing - Make the revision a 32- bit consisting of rev_lo amd rev_hi each of 16 bits. - Also use the revision register for the erratum i207. - Refactor the i2c_omap_init code. Adds a patch to remove the

Re: [PATCH 2/2] i2c-s3c2410: Convert to devm_request_and_ioremap()

On Tue, Nov 6, 2012 at 1:40 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Nov 05, 2012 at 05:21:03PM +0530, Shubhrajyoti Datta wrote: On Mon, Nov 5, 2012 at 2:03 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: A small code saving and less error handling to worry

Re: [PATCH] Revert ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

On Tue, Nov 6, 2012 at 10:01 PM, Paul Walmsley p...@pwsan.com wrote: This reverts commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc. This commit causes I2C timeouts to appear on several OMAP3430/3530-based boards: http://marc.info/?l=linux-arm-kernelm=135071372426971w=2

Re: [PATCHv2 1/7] i2c: omap: Fix the revision register read

On Mon, Nov 5, 2012 at 2:34 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Nov 05, 2012 at 02:04:56PM +0530, Shubhrajyoti wrote: @@ -1155,7 +1187,7 @@ omap_i2c_probe(struct platform_device *pdev) dev-fifo_size = (dev-fifo_size / 2); - if (dev-rev

Re: [PATCH 2/2] i2c-s3c2410: Convert to devm_request_and_ioremap()

On Mon, Nov 5, 2012 at 2:03 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: A small code saving and less error handling to worry about. Looks good. request irq could be devm_* also. Not an objection though. -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the

Re: [PATCHv3 8/8] i2c: omap: cleanup the sysc write

On 11/5/12, Cousson, Benoit b-cous...@ti.com wrote: On 11/5/2012 3:25 PM, Felipe Balbi wrote: Hi, On Mon, Nov 05, 2012 at 07:53:45PM +0530, Shubhrajyoti wrote: On Monday 05 November 2012 07:44 PM, Felipe Balbi wrote: - dev-syscstate); -

Re: [PATCH] i2c: s3c2410: Add fix for i2c suspend/resume

On Tue, Nov 6, 2012 at 11:40 AM, Abhilash Kesavan a.kesa...@samsung.com wrote: The I2C driver makes a gpio_request during initialization. This request happens again on resume Do you know why request and free is needed across the suspend and resume? and fails due to the earlier successful

Re: [PATCH 2/2] i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207

On Fri, Nov 2, 2012 at 4:37 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 02, 2012 at 04:09:45PM +0530, Shubhrajyoti D wrote: The errata i207 is enabled for 2430 and 3xxx. Use the revision check to enable the erratum instead. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com very good. I

Re: [PATCH 1/2] i2c: omap: Fix the revision register read

On Fri, Nov 2, 2012 at 4:36 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Nov 02, 2012 at 04:09:44PM +0530, Shubhrajyoti D wrote: The revision register on OMAP4 is a 16-bit lo and a 16-bit hi. Currently the driver reads only the lower 8-bits. Fix the same by preventing the truncating of

Re: [PATCH RFC] i2c: omap: Fix the revision register read

On Wed, Oct 31, 2012 at 2:29 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: The revision register on OMAP4 is a 16-bit lo and a 16-bit hi. Currently the driver reads only the lower 8-bits. Fix the same by preventing the truncating of the rev register for OMAP4. Also use the scheme bit ie

Re: [PATCH v2] i2c: omap: re-factor omap_i2c_init function

On Thu, Oct 25, 2012 at 12:06 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Oct 25, 2012 at 12:06:51PM +0530, Shubhrajyoti D wrote: re-factor omap_i2c_init() so that we can re-use it for resume. While at it also remove the bufstate variable as we write it in omap_i2c_resize_fifo for every

Re: [PATCH] i2c: omap: ensure writes to dev-buf_len are ordered

On Thu, Oct 25, 2012 at 2:30 PM, Felipe Balbi ba...@ti.com wrote: if we allow compiler reorder our writes, we could fall into a situation where dev-buf_len is reset for no apparent reason. This bug was found with a simple script which would transfer data to an i2c client from 1 to 1024 bytes

Re: [PATCH v2] i2c: omap: re-factor omap_i2c_init function

On Thu, Oct 25, 2012 at 12:06 PM, Felipe Balbi ba...@ti.com wrote: [...] + * Don't write to this register if the IE state is 0 as it can + * cause deadlock. + */ + if (dev-iestate) + omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, dev-iestate); +} + static int

Re: [PATCH 2/8] i2c: omap: reorder exit path of omap_i2c_xfer_msg()

On Mon, Oct 22, 2012 at 3:16 PM, Felipe Balbi ba...@ti.com wrote: just a cleanup patch trying to make exit path more straightforward. No changes otherwise. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 26 +- 1 file changed, 17

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

On Tue, Oct 23, 2012 at 11:27 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 23, 2012 at 11:26:15PM +0530, Shubhrajyoti Datta wrote: @@ -1268,23 +1271,8 @@ static int omap_i2c_runtime_resume(struct device *dev) { struct omap_i2c_dev *_dev = dev_get_drvdata(dev

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

On Tue, Oct 23, 2012 at 10:48 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 23, 2012 at 08:57:19PM +0530, Shubhrajyoti D wrote: re-factor omap_i2c_init() so that we can re-use it for resume. While at it also remove the bufstate variable as we write it in omap_i2c_resize_fifo for every

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

On Tue, Oct 23, 2012 at 11:27 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 23, 2012 at 11:26:15PM +0530, Shubhrajyoti Datta wrote: @@ -1268,23 +1271,8 @@ static int omap_i2c_runtime_resume(struct device *dev) { struct omap_i2c_dev *_dev = dev_get_drvdata(dev

Re: [PATCH] i2c: omap: adopt pinctrl support

On Tue, Oct 16, 2012 at 8:53 PM, Sebastien Guiriec s-guir...@ti.com wrote: Some GPIO expanders need some early pin control muxing. Due to legacy boards sometimes the driver uses subsys_initcall instead of module_init. This patch takes advantage of defer probe feature and pin control in order

Re: [PATCH] i2c: omap: revert i2c: omap: switch to threaded IRQ support

On Mon, Oct 15, 2012 at 7:21 AM, Paul Walmsley p...@pwsan.com wrote: Commit 3b2f8f82dad7d1f79cdc8fc05bd1c94baf109bde (i2c: omap: switch to threaded IRQ support) causes communication with I2C devices to fail after system suspend/resume on all OMAP3 devices: Could you tell me which omap3

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

On Mon, Oct 15, 2012 at 2:46 PM, Kalle Jokiniemi kalle.jokini...@jollamobile.com wrote: ma, 2012-10-15 kello 09:21 +0300, Kalle Jokiniemi kirjoitti: Hi, pe, 2012-10-12 kello 14:46 +, Strashko, Grygorii kirjoitti: Hi Kevin, yep, [1] is the same fix - thanks. Hi Kalle, i've

Re: [PATCH 1/3] i2c: omap: Do not enable the irq always

On Fri, Oct 12, 2012 at 7:56 PM, Kevin Hilman khil...@deeprootsystems.com wrote: +Kalle, Grygorii, Huzefa Shubhrajyoti D shubhrajy...@ti.com writes: Enable the irq in the transfer and disable it after the transfer is done. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

On Fri, Oct 12, 2012 at 10:13 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Strashko, Grygorii grygorii.stras...@ti.com writes: Hi Kevin, yep, [1] is the same fix - thanks. Hi Kalle, i've applied these changes and PM runtime fix on top of

Re: [PATCH] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

this, also disable interrupts at the MPU INTC when idling the device in -runtime_suspend() (and re-enable them in -runtime_resume().) This part based on an original patch from Shubhrajyoti Datta. NOTE: for proper sharing the I2C with a coprocessor, this driver still needs hwspinlock support

Re: [PATCH v3] ARM: OMAP: i2c: fix interrupt flood during resume

On Wed, Oct 10, 2012 at 5:48 PM, Kalle Jokiniemi kalle.jokini...@jollamobile.com wrote: The resume_noirq enables interrupts one-by-one starting from first one. Now if the wake up event for suspend came from i2c device, the i2c bus irq gets enabled before the threaded i2c device irq, causing a

Re: [PATCH] char/tpm: Convert struct i2c_msg initialization to C99 format

On Wed, Oct 10, 2012 at 2:36 PM, Jean Delvare kh...@linux-fr.org wrote: On Tue, 9 Oct 2012 17:12:31 +0530, Shubhrajyoti D wrote: Thanks for review updated patch below From f3786807bbaafe1f0dfcf2d94e3bee1c273296a4 Mon Sep 17 00:00:00 2001 From: Shubhrajyoti D shubhrajy...@ti.com Date: Mon, 17 Sep

Re: [PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

On Wed, Oct 10, 2012 at 2:35 PM, Jean Delvare kh...@linux-fr.org wrote: On Tue, 9 Oct 2012 17:07:48 +0530, Shubhrajyoti D wrote: Thanks updated patch below. From 99073779197f5759a76e65c3f4ef2ad4e9c88eaf Mon Sep 17 00:00:00 2001 From: Shubhrajyoti D shubhrajy...@ti.com Date: Mon, 17 Sep 2012

Re: [PATCH 2/4] input: Convert struct i2c_msg initialization to C99 format

On Wed, Oct 10, 2012 at 2:32 PM, Jean Delvare kh...@linux-fr.org wrote: On Tue, 9 Oct 2012 17:01:18 +0530, Shubhrajyoti D wrote: [...] Acked-by: Jean Delvare kh...@linux-fr.org thanks updated patch below From 6638ecfa7982f95815382922c50573712c9626d7 Mon Sep 17 00:00:00 2001 From: Shubhrajyoti

Re: [PATCH v2] i2c: omap: Prevent NULL pointer dereference in remove

On Thu, Sep 6, 2012 at 5:51 PM, Jean Delvare kh...@linux-fr.org wrote: On Thu, 6 Sep 2012 17:31:56 +0530, Shubhrajyoti D wrote: Prevent the NULL pointer access by moving the platform_set_drvdata function after the access of the pdev. [ 654.961761] Unable to handle kernel NULL pointer

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

On Fri, Sep 14, 2012 at 7:11 PM, benjamin.tissoires benjamin.tissoi...@gmail.com wrote: From: Benjamin Tissoires benjamin.tissoi...@enac.fr Microsoft published the protocol specification of HID over i2c: http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx This patch

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

On Wed, Oct 3, 2012 at 9:03 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi, thanks also for the review. Two in the same day! I was about to send a ping on that patch ;-) On Wed, Oct 3, 2012 at 8:05 AM, Shubhrajyoti Datta omaplinuxker...@gmail.com wrote: On Fri, Sep 14

Re: [PATCH v2] i2c: add Renesas R-Car I2C driver

On Fri, Sep 28, 2012 at 11:26 AM, Kuninori Morimoto kuninori.morimoto...@renesas.com wrote: Dear Shubhrajyoti Thank you for your comment. Hi A few suggestions, On Tue, Aug 28, 2012 at 2:07 PM, Kuninori Morimoto kuninori.morimoto...@renesas.com wrote: R-Car I2C is similar with SH7760

Re: [PATCH v2] i2c: add Renesas R-Car I2C driver

Hi A few suggestions, On Tue, Aug 28, 2012 at 2:07 PM, Kuninori Morimoto kuninori.morimoto...@renesas.com wrote: R-Car I2C is similar with SH7760 I2C. But the SH7760 I2C driver had many workaround operations, since H/W had bugs. Thus, it was pointless to keep compatible between SH7760 and

Re: [PATCH] ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints

On Thu, Sep 20, 2012 at 9:38 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Convert the driver from the outdated omap_pm_set_max_mpu_wakeup_lat API to the new PM QoS API. Since the constraint is on the MPU subsystem, use the PM_QOS_CPU_DMA_LATENCY class of PM QoS. The resulting MPU

Re: [PATCHv7 00/23]I2C big cleanup

On Wed, Sep 12, 2012 at 7:14 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Wed, Sep 12, 2012 at 12:18:50PM +0200, Wolfram Sang wrote: I donot see the warning. Am I missing something? I deleted my logfiles already. Ignore it for now, if it comes up again with your new series, I will give

Re: [PATCH] i2c: omap: Prevent NULL pointer dereference in remove

Hi Jean, Thanks for the review. On Thu, Aug 30, 2012 at 12:17 AM, Jean Delvare kh...@linux-fr.org wrote: On Thu, 23 Aug 2012 19:51:26 +0530, Shubhrajyoti D wrote: Prevent the NULL pointer access of pdev-dev in remove. The platform_device is anyways deleted so remove

Re: [PATCH] i2c: add Renesas R-Car I2C driver

On Wed, Jul 25, 2012 at 12:06 PM, Kuninori Morimoto kuninori.morimoto...@renesas.com wrote: R-Car I2C is similar with SH7760 I2C. But the SH7760 I2C driver had many workaround operations, since H/W had bugs. Thus, it was pointless to keep compatible between SH7760 and R-Car I2C drivers. This

Re: [PATCH] i2c: add Renesas R-Car I2C driver

On Tue, Aug 28, 2012 at 11:03 AM, Kuninori Morimoto kuninori.morimoto...@renesas.com wrote: Hi Shubhrajyoti Thank you for checking patch. I create v2 patch and post it soon. There is not big reason, but I would like to keep adap-retries for now. Or maybe just wait for Jean's advice on the

Re: [PATCH 2/6] i2c-xiic: Fix a possible NULL pointer access

On Sat, Aug 18, 2012 at 3:47 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Thu, Aug 09, 2012 at 07:07:43PM +0530, Shubhrajyoti D wrote: platform_get_resource uses pdev so move the function platform_set_drvdata(pdev, NULL) after the get_resource. Yes agree. This descriptions sounds as

Re: [PATCH 1/6] i2c: omap: Prevent NULL pointer dereference in remove

On Sat, Aug 18, 2012 at 3:39 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Thu, Aug 09, 2012 at 07:07:42PM +0530, Shubhrajyoti D wrote: Prevent the NULL pointer access by moving the platform_set_drvdata function after the access of the pdev. [ 654.961761] Unable to handle kernel NULL

Re: [PATCH 2/6] i2c-xiic: Fix a possible NULL pointer access

On Sat, Aug 18, 2012 at 6:52 PM, Shubhrajyoti Datta omaplinuxker...@gmail.com wrote: On Sat, Aug 18, 2012 at 3:47 PM, Wolfram Sang w.s...@pengutronix.de wrote: On Thu, Aug 09, 2012 at 07:07:43PM +0530, Shubhrajyoti D wrote: platform_get_resource uses pdev so move the function

Re: [PATCH] I2C: MIPS: lantiq: add FALC-ON i2c bus master

Hi John , On Thu, Aug 16, 2012 at 1:04 PM, John Crispin blo...@openwrt.org wrote: This patch adds the driver needed to make the I2C bus work on FALC-ON SoCs. Signed-off-by: Thomas Langer thomas.lan...@lantiq.com Signed-off-by: John Crispin blo...@openwrt.org --- drivers/i2c/busses/Kconfig

  1   2   >