Re: [PATCH v4] i2c: designware: Do not require clock when SSCN and FFCN are provided

2016-01-06 Thread Suravee Suthikulpanit
erb...@linux.intel.com> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> Tested-by: Loc Ho <l...@apm.com> --- Note: This has been tested on AMD Seattle RevB for both DT and ACPI. Changes from V3 (https://lkml.org/lkml/2015/12/22/596): * Add i2c_dw_plat_prepare_clk() per

Re: [PATCH v3] i2c: designware: Do not require clock when SSCN and FFCN are provided

2016-01-04 Thread Suravee Suthikulpanit
Hi Andy, On 12/23/2015 12:27 PM, Andy Shevchenko wrote: diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c >b/drivers/i2c/busses/i2c-designware-platdrv.c >index 8ffc36b..04edd09 100644 >--- a/drivers/i2c/busses/i2c-designware-platdrv.c >+++ b/drivers/i2c/busses/i2c-designware-platdrv.c

[PATCH v4] i2c: designware: Do not require clock when SSCN and FFCN are provided

2016-01-04 Thread Suravee Suthikulpanit
provide these values. So, the clock information should no longer be required during probing. However, since clk can be invalid, additional checks must be done where we are making use of it. Signed-off-by: Mika Westerberg <mika.westerb...@linux.intel.com> Signed-off-by: Suravee Suthiku

Re: [PATCH] i2c: designware: Add support for AMD Seattle I2C

2016-01-03 Thread Suravee Suthikulpanit
Hi Wolfram, On 01/03/2016 12:45 PM, Wolfram Sang wrote: On Wed, Dec 16, 2015 at 06:49:59PM -0600, Suravee Suthikulanit wrote: Mika, On 12/16/2015 8:54 AM, Mika Westerberg wrote: On Wed, Dec 16, 2015 at 08:29:38AM -0600, Suravee Suthikulpanit wrote: On 12/16/2015 03:16 AM, Mika Westerberg

[PATCH v3] i2c: designware: Do not require clock when SSCN and FFCN are provided

2015-12-22 Thread Suravee Suthikulpanit
provide these values. So, the clock information should no longer be required during probing. However, since clk can be invalid, additional checks must be done where we are making use of it. Signed-off-by: Mika Westerberg <mika.westerb...@linux.intel.com> Signed-off-by: Suravee Suthiku

[PATCH v2] i2c: designware: Do not require clock when SSCN and FFCN are provided

2015-12-16 Thread Suravee Suthikulpanit
provide these values. So, the clock information should no longer be required during probing. However, since clk can be invalid, additional checks must be done where we are making use of it. Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> --- Note: This has been tested

Re: [PATCH] i2c: designware: Do not require clock when SSCN and FFCN are provided

2015-12-16 Thread Suravee Suthikulpanit
Hi Mika, On 12/16/2015 03:42 AM, Mika Westerberg wrote: +Jarkko and Andy On Tue, Dec 15, 2015 at 04:38:58PM -0600, Suravee Suthikulpanit wrote: The current driver uses input clock source frequency to calculate values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do

Re: [PATCH] i2c: designware: Add support for AMD Seattle I2C

2015-12-16 Thread Suravee Suthikulpanit
On 12/16/2015 03:16 AM, Mika Westerberg wrote: On Tue, Dec 15, 2015 at 08:14:34PM -0600, Suravee Suthikulpanit wrote: Hi Mika, On 12/15/15 15:55, Suravee Suthikulpanit wrote: Add device HID AMDI0510 to match the I2C controlers on AMD Seattle platform Signed-off-by: Suravee Suthikulpanit

Re: [PATCH] i2c: designware: Do not require clock when SSCN and FFCN are provided

2015-12-16 Thread Suravee Suthikulpanit
On 12/16/2015 08:28 AM, Mika Westerberg wrote: On Wed, Dec 16, 2015 at 08:11:12AM -0600, Suravee Suthikulpanit wrote: The clk framework should work fine if the returned clock is NULL (which I think is your case). The driver gates clocks when the device is suspended and on Intel LPSS

[PATCH] i2c: designware: Do not require clock when SSCN and FFCN are provided

2015-12-15 Thread Suravee Suthikulpanit
provide these values. So, this patch removes the clock requirement when SSCN and FFCN are provided. Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> --- Note: This has been tested on AMD Seattle RevB for both DT and ACPI. drivers/i2c/busses/i2c-designware-core.c

[PATCH] i2c: designware: Add support for AMD Seattle I2C

2015-12-15 Thread Suravee Suthikulpanit
Add device HID AMDI0510 to match the I2C controlers on AMD Seattle platform Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> --- drivers/i2c/busses/i2c-designware-platdrv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-designware-platdr

Re: [PATCH] i2c: designware: Add support for AMD Seattle I2C

2015-12-15 Thread Suravee Suthikulpanit
Hi Mika, On 12/15/15 15:55, Suravee Suthikulpanit wrote: Add device HID AMDI0510 to match the I2C controlers on AMD Seattle platform Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> --- drivers/i2c/busses/i2c-designware-platdrv.c | 1 + 1 file changed, 1 ins

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-15 Thread Suravee Suthikulpanit
On 12/15/2015 07:27 AM, Mika Westerberg wrote: On Mon, Dec 14, 2015 at 06:53:25PM -0600, Suravee Suthikulanit wrote: >I'm not sure if this has been discussed earlier. But after looking at the >the acpi_apd driver, all we need is just the platform-specific input clock >frequency value used by