Re: [RFC PATCH 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board

2012-02-01 Thread Sergei Shtylyov
Hello. On 31-01-2012 17:04, Heiko Schocher wrote: On Mon, Jan 23, 2012 at 09:56:07AM +0100, Heiko Schocher wrote: - AM1808 based board - 64 MiB DDR ram - 2 MiB Nor flash - 128 MiB NAND flash - use internal RTC - I2C support - hwmon lm75 support - UBI/UBIFS support - MMC support - USB OTG suppo

Re: [PATCH 6/6] i2c: davinci: use devm_ functions

2012-08-27 Thread Sergei Shtylyov
Hello. On 08/25/2012 09:41 PM, Julia Lawall wrote: > From: Julia Lawall > The various devm_ functions allocate memory that is released when a driver > detaches. This patch uses these functions for data that is allocated in > the probe function of a platform device and is only freed in the remo

Re: [PATCH 3/3] ARM: dts: cfa10049: Add the i2c muxer buses to the CFA-10049

2012-09-24 Thread Sergei Shtylyov
Hello. On 24-09-2012 13:53, Maxime Ripard wrote: This will allow to add the 3 Nuvoton NAU7802 ADCs and the NXP PCA9555 GPIO expander eventually. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/imx28-cfa10049.dts | 33 + 1 file changed, 33 insertions(+

Re: [PATCH 00/16] treewide: Convert dev_printk(KERN_ to dev_(

2012-10-28 Thread Sergei Shtylyov
Hello. On 28-10-2012 12:05, Joe Perches wrote: dev_ create smaller objects than dev_printk(KERN_. Convert non-debug calls to this form. Joe Perches (16): tile: Convert dev_printk(KERN_ to dev_( [...] tile: Convert dev_printk(KERN_ to dev_( [...] tile: Convert dev_printk(KERN_ to

Re: [PATCH] i2c: mv64xxx: Add support Armada-XP SoC

2012-10-30 Thread Sergei Shtylyov
Hello. On 10/30/2012 01:39 PM, Nobuhiro Iwamatsu wrote: > The Armada-XP SoC has the same I2C controller as mv64xxxi-i2c. > This validates to use mv64xxx in this SoC. > Signed-off-by: Nobuhiro Iwamatsu > --- > drivers/i2c/busses/Kconfig |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] i2c: mv64xxx: Remove useless parens

2012-10-31 Thread Sergei Shtylyov
Hello. On 10/31/2012 06:46 AM, Nobuhiro Iwamatsu wrote: > Signed-off-by: Nobuhiro Iwamatsu > --- > drivers/i2c/busses/Kconfig |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 65dd599..38abd47 100644 > ---

Re: [PATCH] i2c: at91: fix compilation issue due to header move

2012-11-09 Thread Sergei Shtylyov
Hello. On 09-11-2012 14:11, ludovic.desroc...@atmel.com wrote: From: Ludovic Desroches arch/arm/mach-at91/include/mach/at_hdmac.h has been move to include/linux/platform_data/dma-atmel.h, commit 7cdc39e. Need to also specify that commit's summary in parens. Signed-off-by: Ludovic Des

Re: [PATCH V2] i2c: davinci: update to devm_* API

2013-02-06 Thread Sergei Shtylyov
Hello. On 06-02-2013 15:22, Vishwanathrao Badarkhe, Manish wrote: Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Vishwanathrao Badarkhe, Manish --- Changes since V1: - Rebase on top of v3.8-rc6 of linus tree. - Apply devm operation on clk_g

Re: [PATCH RESEND 2/3] ahci: add AMD CZ SATA device ID

2013-06-03 Thread Sergei Shtylyov
Hello. On 03-06-2013 14:24, Shane Huang wrote: To add AMD CZ SATA controller device ID of IDE mode. Signed-off-by: Shane Huang Reviewed-by: Tejun Heo Cc: sta...@vger.kernel.org --- drivers/ata/ahci.c | 1 + drivers/pci/quirks.c| 2 ++ include/linux/pci_ids.h | 1 + 3 files ch

Re: [PATCH RESEND v2 3/3] i2c-piix4: add AMD CZ SMBus device ID

2013-06-03 Thread Sergei Shtylyov
Hello. On 03-06-2013 14:24, Shane Huang wrote: To add AMD CZ SMBus controller device ID. Signed-off-by: Shane Huang Reviewed-by: Tejun Heo Reviewed-by: Jean Delvare Cc: sta...@vger.kernel.org [...] diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 22449c1..b10a5b4 10

Re: [PATCH/RFC 1/1] recover from davinci i2c time out conditions

2009-07-15 Thread Sergei Shtylyov
Hello. Philby John wrote: From dbe7e824d576636bb15b82a20fd2557fddc9a8f7 Mon Sep 17 00:00:00 2001 From: Philby John Date: Tue, 14 Jul 2009 21:46:47 +0530 Subject: [PATCH] Reset i2c bus to come out of time out conditions Get out of i2c time out condition by resetting the i2c bus. The kernel

Re: [PATCH 3/3] i2c: davinci: Add cpufreq support

2009-12-07 Thread Sergei Shtylyov
Hello. Chaithrika U S wrote: Add cpufreq support for DaVinci I2C driver. Tested on DA850/OMAP-L138 EVM. For the purpose of testing, the patches which add cpufreq support [1] for this SoC are needed. [1]http://linux.davincidsp.com/pipermail/davinci-linux-open-source/ 2009-September/016118.html

Re: [PATCH v2 2/4] i2c: davinci: Add helper functions

2009-12-08 Thread Sergei Shtylyov
Hello. Chaithrika U S wrote: Add i2c reset control and clock divider calculation functions which will be useful for power management features. Signed-off-by: Chaithrika U S [...] @@ -138,15 +147,6 @@ static int i2c_davinci_init(struct davinci_i2c_dev *dev) u32 clkh; u32

Re: [PATCH v2 2/4] i2c: davinci: Add helper functions

2009-12-10 Thread Sergei Shtylyov
Hello. Chaithrika U S wrote: Hello. Chaithrika U S wrote: Add i2c reset control and clock divider calculation functions which will be useful for power management features. Signed-off-by: Chaithrika U S [...] @@ -138,15 +147,6 @@ static int i2c_davinci_init(struct dav

Re: [PATCH 1/3] MIPS: Octeon: Add I2C platform driver.

2010-01-07 Thread Sergei Shtylyov
Hello. David Daney wrote: Signed-off-by: David Daney CC: Rade Bozic [...] diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c index 20698a6..f2c0602 100644 --- a/arch/mips/cavium-octeon/octeon-platform.c +++ b/arch/mips/cavium-octeon/octeon

Re: [PATCH 21/37] drivers/ata: use .dev.of_node instead of .node in struct of_device

2010-03-11 Thread Sergei Shtylyov
Hello. Grant Likely wrote: .node is being removed Signed-off-by: Grant Likely --- drivers/ata/pata_macio.c |2 +- drivers/ata/pata_of_platform.c |2 +- drivers/ide/pmac.c | 10 +- 3 files changed, 7 insertions(+), 7 deletions(-) Should probably hav

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 1:44, Wolfram Sang wrote: From: Wolfram Sang Tested with RIIC2 on a genmai board. Others untested but hopefully trivial enough to be added. Signed-off-by: Wolfram Sang Acked-by: Magnus Damm --- arch/arm/mach-shmobile/clock-r7s72100.c | 12 +++- 1 file ch

Re: [PATCH 4/5] arm: shmobile: genmai: adapt dts to use native i2c driver

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 1:44, Wolfram Sang wrote: From: Wolfram Sang Switch from the gpio-driver to the shiny new native driver. Tested by accessing the eeprom on the genmai board. Signed-off-by: Wolfram Sang Acked-by: Magnus Damm --- arch/arm/boot/dts/r7s72100-genmai-reference.dts | 29

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Sergei Shtylyov
On 18-12-2013 15:43, Wolfram Sang wrote: @@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { CLKDEV_CON_ID("mtu2_fck", &mstp_clks[MSTP33]), /* ICK */ + CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]), + CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MSTP96]), +

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 17:49, Simon Horman wrote: @@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { CLKDEV_CON_ID("mtu2_fck", &mstp_clks[MSTP33]), /* ICK */ + CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]), + CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MST

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 18:44, Magnus Damm wrote: @@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { CLKDEV_CON_ID("mtu2_fck", &mstp_clks[MSTP33]), /* ICK */ + CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]), + CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MS

Re: [PATCH 3/6] i2c: rcar: do not print error if device nacks transfer

2014-05-08 Thread Sergei Shtylyov
Hello. On 01/26/2014 07:05 PM, Ben Dooks wrote: The i2c-rcar driver currently prints an error message if the master_xfer callback fails. However if the bus is being probed then lots of NAKs will be generated, causing the output of a number of errors printed. To solve this, disable the print

Re: [PATCH 3/6] i2c: rcar: do not print error if device nacks transfer

2014-05-09 Thread Sergei Shtylyov
Hello. On 05/09/2014 01:32 PM, Ben Dooks wrote: The i2c-rcar driver currently prints an error message if the master_xfer callback fails. However if the bus is being probed then lots of NAKs will be generated, causing the output of a number of errors printed. To solve this, disable the print

Re: [PATCH] i2c: rk3x: fix bug that cause transfer fails in master receive mode

2014-08-21 Thread Sergei Shtylyov
Hello. On 08/21/2014 09:50 PM, Addy Ke wrote: In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data in one transaction, so the size of data to be write/read to/from TXDATAx/RXDATAx must be less than or equal 32 bytes at a time. Test on pinky board, elan receive 158 bytes d

Re: ARM: shmobile: "i2c" vs. "iic" DT nodes and pinmux

2014-08-21 Thread Sergei Shtylyov
Hello. On 08/12/2014 05:11 PM, Geert Uytterhoeven wrote: On r8a7790, DT device nodes and C/DT pinmux data for IIC are called "iic", with DT aliases from "i2c" to the "iic" DT nodes. On r8a7791, DT device nodes and C/DT pinmux data for IIC are called "i2c", with DT aliases from "i2c" to the "i2c

Re: ARM: shmobile: "i2c" vs. "iic" DT nodes and pinmux

2014-08-21 Thread Sergei Shtylyov
Hello. On 08/21/2014 11:09 PM, Sergei Shtylyov wrote: "iic", with DT aliases from "i2c" to the "iic" DT nodes. On r8a7791, DT device nodes and C/DT pinmux data for IIC are called "i2c", with DT aliases from "i2c" to the "i2c" DT nodes

[PATCH 0/3] R-Car I2C driver: some cleanups

2014-08-22 Thread Sergei Shtylyov
Hello. Here's the set of 3 patches against Wolfram Sang's 'linux.git' repo's 'i2c/for-next' branch. [1/3] i2c-rcar: simplify check for last message [2/3] i2c-rcar: make rcar_i2c_prepare_msg() *void* [3/3] i2c-rcar: make rcar_i2c_irq_recv() *void* WBR, Sergei -- To unsubscribe from this list:

[PATCH 1/3] i2c-rcar: simplify check for last message

2014-08-22 Thread Sergei Shtylyov
rcar_i2c_master_xfer() needlessly compares the message pointers (using indirect addressing) in order to detect the last I2C message, while it's enough to only compare the message indexes. Signed-off-by: Sergei Shtylyov --- drivers/i2c/busses/i2c-rcar.c |2 +- 1 file changed, 1 inse

[PATCH 2/3] i2c-rcar: make rcar_i2c_prepare_msg() *void*

2014-08-22 Thread Sergei Shtylyov
rcar_i2c_prepare_msg() always returns 0, so we can make this function return *void* and thus remove the result check in rcar_i2c_master_xfer(). Signed-off-by: Sergei Shtylyov --- drivers/i2c/busses/i2c-rcar.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) Index: linux

[PATCH 3/3] i2c-rcar: make rcar_i2c_irq_recv() *void*

2014-08-22 Thread Sergei Shtylyov
rcar_i2c_irq_recv() always returns 0, so we can make this function return *void* and also remove rcar_i2c_flags_set() invocation in rcar_i2c_irq(). Signed-off-by: Sergei Shtylyov --- drivers/i2c/busses/i2c-rcar.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Index: linux

Re: [PATCH 08/11] i2c: rcar: remove spinlock

2014-08-22 Thread Sergei Shtylyov
Hello. On 05/28/2014 11:44 AM, Wolfram Sang wrote: From: Wolfram Sang The i2c core has per-adapter locks, so no need to protect again. The core's lock is unable to protect from the IRQs. So I'm proposing to revert this patch. It's a pity I hadn't noticed this issue when the patch was

[PATCH] Revert "i2c-rcar: remove spinlock"

2014-08-23 Thread Sergei Shtylyov
This reverts commit 150b8be3cda54412ad7b54f5392b513b25c0aaa7. The I2C core's per-adapter locks can't protect from IRQs, so the driver still needs a spinlock to protect the register accesses. Signed-off-by: Sergei Shtylyov Cc: sta...@vger.kernel.org # 3.16+ --- The patch is again

[PATCH v2] Revert "i2c: rcar: remove spinlock"

2014-08-23 Thread Sergei Shtylyov
This reverts commit 150b8be3cda54412ad7b54f5392b513b25c0aaa7. The I2C core's per-adapter locks can't protect from IRQs, so the driver still needs a spinlock to protect the register accesses. Signed-off-by: Sergei Shtylyov Cc: sta...@vger.kernel.org # 3.16+ --- The patch is again

Re: [PATCH v2] Revert "i2c: rcar: remove spinlock"

2014-08-24 Thread Sergei Shtylyov
Hello. On 8/24/2014 10:45 AM, Wolfram Sang wrote: This reverts commit 150b8be3cda54412ad7b54f5392b513b25c0aaa7. The I2C core's per-adapter locks can't protect from IRQs, so the driver still needs a spinlock to protect the register accesses. Looks to me like a plain revert. What about the

Re: [PATCH v2] Revert "i2c: rcar: remove spinlock"

2014-08-25 Thread Sergei Shtylyov
Hello. On 8/25/2014 7:40 AM, Wolfram Sang wrote: You told me to do 2 patches, one of them just revert. No no, I asked for one patch having both, see: "... feel free to send one patch with the revert and the updates you mentioned." Ah, I misunderstood you. However, I don't quite unde

[PATCH] i2c-rcar: fix MNR interrupt handling

2014-09-01 Thread Sergei Shtylyov
is a good thing anyway)... Signed-off-by: Sergei Shtylyov Cc: sta...@vger.kernel.org --- The patch is against Wolfram Sang's 'linux.git' repo. drivers/i2c/busses/i2c-rcar.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) Index: linux/driv

Re: [PATCH v2] Revert "i2c: rcar: remove spinlock"

2014-09-02 Thread Sergei Shtylyov
Hello. On 08/25/2014 06:33 PM, Wolfram Sang wrote: Ah, I misunderstood you. However, I don't quite understand why you want to combine revert and the mentioned updates... As I understood from your previous mail, a plain revert is less broken but still broken. Applying a correct fix is my

Re: [PATCH v2] Revert "i2c: rcar: remove spinlock"

2014-09-02 Thread Sergei Shtylyov
On 09/02/2014 09:18 PM, Wolfram Sang wrote: As I understood from your previous mail, a plain revert is less broken but still broken. Applying a correct fix is my preferred way. Actually, from the -stable kernel perspective, a single patch would complicate backporting. So could you please

Re: [PATCH v2] Revert "i2c: rcar: remove spinlock"

2014-09-02 Thread Sergei Shtylyov
On 09/02/2014 09:45 PM, Wolfram Sang wrote: I don't see why. If we have two patches, the state inbetween them is broken. Even so, it has always been broken, we don't make it more broken by reverting your change. Yes. Still, if I send something to *stable*, less broken is not an option

Re: [PATCH] i2c-rcar: fix MNR interrupt handling

2014-09-02 Thread Sergei Shtylyov
On 09/02/2014 01:15 AM, Sergei Shtylyov wrote: Sometimes the MNR and MST interrupts happen simultaneously (stop automatically follows NACK, according to the manuals) and in such case the ID_NACK flag isn't set since the MST interrupt handling precedes MNR and all interrupts are cleare

Re: [PATCH 08/11] i2c: rcar: remove spinlock

2014-09-02 Thread Sergei Shtylyov
On 08/23/2014 03:54 AM, Sergei Shtylyov wrote: From: Wolfram Sang The i2c core has per-adapter locks, so no need to protect again. The core's lock is unable to protect from the IRQs. So I'm proposing to revert this patch. It's a pity I hadn't noticed this issu

[PATCH] i2c-rcar: fix RCAR_IRQ_ACK_{RECV|SEND}

2014-09-05 Thread Sergei Shtylyov
Bits 8-31 of all registers reflect the value of bits 0-7 on reads and should be 0 on writes, according to the manuals. RCAR_IRQ_ACK_{RECV|SEND} macros have all 1's in bits 8-31, thus going against the manuals, so fix them. Signed-off-by: Sergei Shtylyov Cc: sta...@vger.kernel.org --- The

[PATCH v2 0/3] R-Car I2C driver: some cleanups

2014-09-14 Thread Sergei Shtylyov
Hello. Here's the set of 3 patches against Wolfram Sang's 'linux.git' repo's 'i2c/for-next' branch. [1/3] i2c-rcar: simplify check for last message [2/3] i2c-rcar: make rcar_i2c_prepare_msg() *void* [3/3] i2c-rcar: make rcar_i2c_irq_recv() *void* WBR, Sergei -- To unsubscribe from this list:

[PATCH v2 1/3] i2c-rcar: simplify check for last message

2014-09-14 Thread Sergei Shtylyov
rcar_i2c_master_xfer() needlessly compares the message pointers (using indirect addressing) in order to detect the last I2C message, while it's enough to only compare the message indexes. Signed-off-by: Sergei Shtylyov --- Changes in version 2: - refreshed patch. drivers/i2c/busses/i2c-r

[PATCH v2 2/3] i2c-rcar: make rcar_i2c_prepare_msg() *void*

2014-09-14 Thread Sergei Shtylyov
rcar_i2c_prepare_msg() always returns 0, so we can make this function return *void* and thus remove the result check in rcar_i2c_master_xfer(). Signed-off-by: Sergei Shtylyov --- Changes in version 2: - resolved reject, refreshed patch. drivers/i2c/busses/i2c-rcar.c |9 ++--- 1 file

[PATCH v2 3/3] i2c-rcar: make rcar_i2c_irq_recv() *void*

2014-09-14 Thread Sergei Shtylyov
rcar_i2c_irq_recv() always returns 0, so we can make this function return *void* and also remove rcar_i2c_flags_set() invocation in rcar_i2c_irq(). Signed-off-by: Sergei Shtylyov --- Changes in version 2: - refreshed patch. drivers/i2c/busses/i2c-rcar.c |8 +++- 1 file changed, 3

[PATCH] i2c-rcar: check for no IRQ in rcar_i2c_irq()

2014-09-14 Thread Sergei Shtylyov
Check if the ICMSR register (masked with the ICMIER register) evaluates to 0 in the driver's interrupt handler and return IRQ_NONE in that case, like many other drivers do. Signed-off-by: Sergei Shtylyov --- The patch is against Wolfram Sang's 'linux.git' repo's &#x

Re: [PATCH] i2c-rcar: fix RCAR_IRQ_ACK_{RECV|SEND}

2014-09-21 Thread Sergei Shtylyov
ff-by: Sergei Shtylyov Cc: sta...@vger.kernel.org Applied to for-current, thanks! Thanks. However, I don't see it in your tree (and neither my cleanups). WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@

Re: [PATCH v3 2/3] i2c/at91: add support for system PM

2014-10-24 Thread Sergei Shtylyov
Hello. On 10/24/2014 10:50 AM, Wenyou Yang wrote: Signed-off-by: Wenyou Yang --- drivers/i2c/busses/i2c-at91.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index a25fb5e..6a84a2a 100644 ---

Re: [PATCH v4] i2c/at91: adopt pinctrl support

2014-11-10 Thread Sergei Shtylyov
Hello. On 11/10/2014 4:55 AM, Wenyou Yang wrote: Amend the at91 i2c pin controller You're amending the hardware itself, really? :-) to optionally take a pin controlhandle I don't see the code that does this. and set the state of the pins to: - "default" on boot and resume. I

Re: [PATCH] Add support for SCCB devices into PXA27x I2C controller

2014-11-23 Thread Sergei Shtylyov
Hello. On 11/23/2014 1:52 AM, Petr Cvek wrote: Add support for SCCB devices into PXA27x I2C controller. Fix generated START but no STOP for message without I2C_M_NOSTART flag. Add support for I2C_M_IGNORE_NAK flag. Signed-off-by: Petr Cvek --- drivers/i2c/busses/i2c-pxa.c | 22

Re: [RFC 1/2] i2c: sh_mobile: refactor DMA setup

2014-12-10 Thread Sergei Shtylyov
Hello. On 12/10/2014 04:21 PM, Wolfram Sang wrote: From: Wolfram Sang Refactor DMA setup to keep the errno so we can implement better deferred probe support in the next step. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-sh_mobile.c | 35 ---

Re: [RFC 1/2] i2c: sh_mobile: refactor DMA setup

2014-12-16 Thread Sergei Shtylyov
Hello. On 12/16/2014 02:34 PM, Wolfram Sang wrote: Hm, alignment style changed... I am not too strict on that as long as the result is somewhat readable. I'd be more interested in your thoughts about the general approach taken in this series. Sorry, I'm not very familiar with thi

Re: [RFC 02/11] i2c: add quirk checks to core

2015-01-09 Thread Sergei Shtylyov
Hello. On 01/09/2015 08:21 PM, Wolfram Sang wrote: Let the core do the checks if HW quirks prevent a transfer. Saves code from drivers and adds consistency. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 53 ++ 1 file changed, 53

Re: [RFC 02/11] i2c: add quirk checks to core

2015-01-09 Thread Sergei Shtylyov
Hello. On 01/09/2015 11:45 PM, Wolfram Sang wrote: Let the core do the checks if HW quirks prevent a transfer. Saves code >from drivers and adds consistency. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 53 ++ 1 file changed, 5

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Sergei Shtylyov
Hello. On 01/15/2015 11:34 PM, Laurent Pinchart wrote: I still do not understand what we are trying to fix here. Why is "adi,adxl34x" compatible string no good anymore? If we start using exact models and the physical device does not match do we abort probe? What is the problem that we are solvi

Re: [PATCH v2] i2c: cadence: fixup of wait_for_completion_timeout return handling

2015-02-10 Thread Sergei Shtylyov
Hello. On 2/9/2015 6:03 PM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int. The return variable is renamed to reflect its use and the type adjusted to unsigned long. Signed-off-by: Nicholas Mc Guire --- v2: int ret is an idiom not only a decl

Re: [PATCH 02/14] ALSA: portman2x4: return proper error values from attach

2015-04-08 Thread Sergei Shtylyov
Hello. On 4/8/2015 2:20 PM, Sudip Mukherjee wrote: now that we are monitoring the return value from attach, make the So you've first changed the method prototype and follow up with the changes to the actual implementations? That's backward. I'm afraid such changes can't be done piecemeal

Re: [PATCH V3 5/6] dts: msm8974: Add blsp2_bam dma node

2015-04-11 Thread Sergei Shtylyov
Hello. On 04/11/2015 10:09 AM, Sricharan R wrote: Signed-off-by: Sricharan R --- arch/arm/boot/dts/qcom-msm8974.dtsi | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index e265ec1..2

Re: [PATCH v3 5/6] i2c: at91: print hardware version

2015-06-02 Thread Sergei Shtylyov
Hello. On 6/2/2015 4:18 PM, Cyrille Pitchen wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen --- drivers/i2c/busses/i2c-at91.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-at91.c b/driver

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-09 Thread Sergei Shtylyov
Hello. On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-10 Thread Sergei Shtylyov
Hello. On 6/10/2015 11:05 AM, Ludovic Desroches wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses

Re: [PATCH] i2c: rcar: Remove obsolete platform data support

2015-10-07 Thread Sergei Shtylyov
Hello. On 10/7/2015 11:16 AM, Geert Uytterhoeven wrote: Since commit 4baadb9e05c68962 ("ARM: shmobile: r8a7778: remove obsolete setup code"), Renesas R-Car SoCs are only supported in generic DT-only ARM multi-platform builds. The driver doesn't need to use platform data anymore, hence remove p

Re: [PATCH v2 04/10] i2c: rcar: remove spinlock

2015-11-12 Thread Sergei Shtylyov
Hello. On 11/12/2015 5:31 PM, Wolfram Sang wrote: From: Wolfram Sang After making sure to reinit the HW and clear interrupts in the timeout case, we know that interrupts are always disabled in the sections protected by the spinlock. What about SMP? Spinlocks are mostly necessary for the

Re: [PATCH v2 01/10] i2c: rcar: make sure clocks are on when doing clock calculation

2015-11-12 Thread Sergei Shtylyov
Hello. On 11/12/2015 05:31 PM, Wolfram Sang wrote: From: Wolfram Sang When calculating the bus speed, the clock should be on, of course. Most bootloaders left them on, so this went unnoticed so far. s/them/it/. Move the ioremapping out of this clock-enabled-block and prepare for adding

Re: [RFC 7/9] ARM: shmobile: r8a7791: dtsi: add internal delay for i2c IPs

2015-11-27 Thread Sergei Shtylyov
Hello. On 11/27/2015 1:59 AM, Wolfram Sang wrote: From: Wolfram Sang Signed-off-by: Wolfram Sang --- arch/arm/boot/dts/r8a7791.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi index d79102c0e7d346..57b806f8c28fa

Re: [RFC 3/3] i2c: rcar: disable PM in multi-master mode

2015-12-16 Thread Sergei Shtylyov
Hello. On 12/16/2015 09:44 PM, Wolfram Sang wrote: From: Wolfram Sang In multi master mode, the IP core needs to be always active for arbitration reasons. Get the config from DT and set up PM depending on the config. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-rcar.c | 17 +

Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-26 Thread Sergei Shtylyov
On 12/26/2015 11:58 PM, Julia Lawall wrote: The error return value of platform_get_irq seems to often get dropped. Signed-off-by: Julia Lawall --- v2: Check for the direct return case also. Added some mailing lists of common offenders. diff --git a/scripts/coccinelle/api/platform_get_irq_r

Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-26 Thread Sergei Shtylyov
On 12/27/2015 01:32 AM, Julia Lawall wrote: The error return value of platform_get_irq seems to often get dropped. Signed-off-by: Julia Lawall --- v2: Check for the direct return case also. Added some mailing lists of common offenders. diff --git a/scripts/coccinelle/api/platform_get_irq_r

Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-27 Thread Sergei Shtylyov
On 12/27/2015 9:13 AM, Julia Lawall wrote: Well, looking again, the patch should be good. I just thought its goal was to fix the code as well... I could do that for the irq < 0 case, but I think that in that case, kbuild will only run the patch version, and the <= cases will not be reporte