Re: SATA timeouts on two disks

2008-01-20 Thread Tejun Heo
Jim MacBaine wrote: > On Jan 13, 2008 1:07 PM, Mikael Pettersson <[EMAIL PROTECTED]> wrote: > >> The fact that the problems occur on different disks on >> different controllers driven by different drivers indicates >> that it's not a disk, controller, or driver problem. >> >> I strongly suspect an

Re: SATA port multiplier(Sil 3132) and JMicron 361-363

2008-01-20 Thread Tejun Heo
mikp wrote: > My SII 3132 port multiplier works with the JMB363 controller on my > motherboard using kernel-2.6.24-rc3 but not with the JMB361 esata controller > which i have on a second motherboard. > > I get messages: >ata5.15: failed to read PMP GSCR[1] (Emask=0x4) >ahci :00:12.0:

Re: SATA CDDVDRW and kernel 2.6.23.12 problems

2008-01-20 Thread Tejun Heo
Paul Surgeon wrote: > I keep getting the following error messages during bootup with kernel > 2.6.23.12 : > > scsi 4:0:0:0: CD-ROMTSSTcorp CDDVDW TS-L633A UO00 PQ: 0 ANSI: 5 > ata3.00: qc timeout (cmd 0xa0) > ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen > ata3.00:

Re: [PATCH 1/2] [libata] sata_mv: Remove PCI dependency

2008-01-20 Thread Tejun Heo
Jeff Garzik wrote: > saeed bishara wrote: >> -if (unlikely(irq_stat & PCI_ERR)) { >> +if (unlikely(irq_stat & PCI_ERR) && HAS_PCI(host)) { >> mv_pci_error(host, mmio); >> handled = 1; >> goto out_unlock;/* skip all other HC irq handling */ > > the unlikely()

Re: sata_sil24 / Alpha / 4726 PMP issue ..

2008-01-20 Thread Tejun Heo
Hello, Thomas. (cc'ing linux-ide, you don't have to be subscribed to post) Thomas Evans wrote: > I usually go by "[EMAIL PROTECTED]" - unfortunately I am unable to get > that machine started so I am using gmail instead. > > I have run into an odd situation with that machine - the 4726 port > mul

[PATCH 5/5] libata: make libata use printk_header() and mprintk

2008-01-20 Thread Tejun Heo
headers making them difficult to tell to which error they belong to, awkward manual indents and complex message printing logics. More importantly, by making message assembly flexible, this patch makes future changes to device configuration and EH reporting easier. Signed-off-by: Tejun Heo <[EM

[PATCH 4/5] printk: add Documentation/printk.txt

2008-01-20 Thread Tejun Heo
Add Documentation/printk.txt which explains printk, mprintk and their friends. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- Documentation/00-INDEX |2 + Documentation/printk.txt | 711 ++ 2 files changed, 713 insertions(+), 0 del

[PATCH 3/5] printk: implement merging printk

2008-01-20 Thread Tejun Heo
ing as a single message. <7>ata1.00: ATA 7, 1024 sectors <7> everything seems dandy Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- include/linux/kernel.h | 69 + kernel/printk.c| 253 2 files change

[PATCH 2/5] printk: implement [v]printk_header()

2008-01-20 Thread Tejun Heo
cq 7168 in res 40/00:34:de:71:02/00:00:00:00:00/40 Emask 0x10 (ATA bus error) ata8.00: cmd 60/7f:38:61:72:02/00:00:00:00:00/40 tag 7 ncq 65024 in res 40/00:34:de:71:02/00:00:00:00:00/40 Emask 0x10 (ATA bus error) Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- inc

[PATCH 1/5] printk: keep log level on multiline messages

2008-01-20 Thread Tejun Heo
by later changes. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- kernel/printk.c | 51 --- 1 files changed, 24 insertions(+), 27 deletions(-) diff --git a/kernel/printk.c b/kernel/printk.c index 89011bf..6df1872 100644 --- a/kerne

[PATCHSET] printk: implement printk_header() and merging printk, take #2

2008-01-20 Thread Tejun Heo
Hello, all. This is the second take of implement-printk_header-and-mprintk patchset. Changes from the last take[L] are... * s/mprintk_push/mprintk_add/ and other changes suggested by Randy Dunlap. * mp->buf instead of mp->header to ease freeing kmalloc'd buffer later. * mprintk

Re: Sata 4726 Testing

2008-01-19 Thread Tejun Heo
Andrew Ryder wrote: > Tejun, > > I've got the hardware fixed and everything is working great. I have two > PMP's attached to the system both with 4 drives and have had no problems. Good to hear. :-) -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-18 Thread Tejun Heo
Matt Mackall wrote: > On Wed, 2008-01-16 at 10:00 +0900, Tejun Heo wrote: >> And mprintk the following. >> >> code: >> DEFINE_MPRINTK(mp, 2 * 80); >> >> mprintk_set_header(&mp, KERN_INFO "ata%u.%2u: ", 1, 0); >> mprintk_push(&

Re: sata_mv oops on module removal

2008-01-18 Thread Tejun Heo
Tomasz Chmielewski wrote: > Tejun Heo schrieb: >> Mark Lord wrote: >>> Tejun, >>> >>> This Oops (2.6.23.13) looks very much like the same bug >>> you fixed recently for me in 2.6.24. >>> >>> The bug was with sata_qstor and other dr

Re: [PATCH #upstream] libata: fix off-by-one in error categorization

2008-01-18 Thread Tejun Heo
Tejun Heo wrote: > ATA_ECAT_DUBIOUS_BASE was too high by one and thus all DUBIOUS error > categorizations were wrong. This passed test because only ATA_BUS and > UNK_DEV were used during testing and the ones after them - ATA_BUS and > an overflowed entry - behaved similarly. > >

Re: ahci: factor out AHCI enabling and enable AHCI before reading CAP

2008-01-18 Thread Tejun Heo
Tejun Heo wrote: > Factor out AHCI enabling into ahci_enable_ahci() and enabling AHCI > before reading CAP in ahci_save_initial_config() as the spec requires > enabling AHCI mode before accessing any other registers. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Ping. So

[PATCH 3/3] ata_piix: implement SIDPR SCR access

2008-01-18 Thread Tejun Heo
SCRs but with two devices. This works well enough for PHY event, error reporting and hardreset. Supporting hardreset is important because in rare cases SATA devices fail to recover without it after PHY errors. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/ata_pi

[PATCH 2/3] ata_piix: convert to prepare - activate initialization

2008-01-18 Thread Tejun Heo
brings the happy side effect of enabling PCI device before accessing PCI configuration registers. Other than that, there shouldn't be any behavior change. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/ata_piix.c | 79 ++- 1 fi

[PATCH 1/3] libata: factor out ata_pci_activate_sff_host() from ata_pci_one()

2008-01-18 Thread Tejun Heo
Factor out ata_pci_activate_sff_host() from ata_pci_one(). This does about the same thing as ata_host_activate() but needs to be separate because SFF controllers use different and multiple IRQs in legacy mode. This will be used to make SFF LLD initialization more flexible. Signed-off-by: Tejun

[PATCHSET libata-dev#upstream] ata_piix: implement SIDPR SCR access, take #2

2008-01-18 Thread Tejun Heo
This patchset implements SIDPR SCR access which is available for ICH8 and above. With SIDPR SCR access enabled, ata_piix ports can access PHY events and errors and can also be hardreset which is important as in rare cases hardreset is necessary to recover from error conditions. Changes from the l

Re: sata_mv oops on module removal

2008-01-17 Thread Tejun Heo
Mark Lord wrote: > Tejun, > > This Oops (2.6.23.13) looks very much like the same bug > you fixed recently for me in 2.6.24. > > The bug was with sata_qstor and other drivers, in that > devres/libata were freeing the I/O resources before invoking > the LLD's host/port_stop routines .. which still

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

2008-01-17 Thread Tejun Heo
TED]> > Cc: Matt Piermarini <[EMAIL PROTECTED]> Acked-by: Tejun Heo <[EMAIL PROTECTED]> -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

2008-01-16 Thread Tejun Heo
Peter Schwenke wrote: > Tejun Heo wrote: >> If Toshiba is still doing this for their new products. We either need a >> better way to blacklist them or contact and tell them to stop what >> they're doing. Does anyone have a Toshiba contact? >> > > I'v

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

2008-01-16 Thread Tejun Heo
Peter Schwenke wrote: > From: Peter Schwenke <[EMAIL PROTECTED]> > > Add Toshiba Satellite R20 and Tecra M6 to broken suspend list. This is > from OSDL bug 7780. > > Signed-off-by: Peter Schwenke <[EMAIL PROTECTED]> Acked-by: Tejun Heo <[EMAIL PROTECTED]>

Re: [PATCH 3/4] printk: implement merging printk

2008-01-15 Thread Tejun Heo
Randy Dunlap wrote: > On Wed, 16 Jan 2008 10:00:09 +0900 Tejun Heo wrote: > > >> --- >> include/linux/kernel.h | 71 >> kernel/printk.c| 215 >> >> 2 files changed, 286 insertion

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-15 Thread Tejun Heo
Hello, Randy Dunlap wrote: >> mprintk_set_header(&mp, KERN_INFO "ata%u.%2u: ", 1, 0); >> mprintk_push(&mp, "ATA %d", 7); >> mprintk_push(&mp, ", %u sectors\n", 1024); >> mprintk(&mp, "everything seems dandy\n"); > > Looks pretty good to me except that I would change mprintk_push to > mpri

Re: [PATCH 4/4] libata: make libata use printk_header() and mprintk

2008-01-15 Thread Tejun Heo
Randy Dunlap wrote: >> -ata_dev_printk(dev, KERN_WARNING, >> -"Drive reports diagnostics failure. This may indicate a drive\n"); >> -ata_dev_printk(dev, KERN_WARNING, >> -"fault or invalid emulation. Contact drive vendor for information.\n"); >> -

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-15 Thread Tejun Heo
Tejun Heo wrote: > Hello, all. > > This patchset implements printk_header() and mprintk - merging printk > - to make printing multiline messages and assembling message > piece-by-piece easier. > > In a nutshell, printk_header() lets you do the following atomically >

[PATCH 3/4] printk: implement merging printk

2008-01-15 Thread Tejun Heo
ing as a single message. <7>ata1.00: ATA 7, 1024 sectors <7> everything seems dandy Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- include/linux/kernel.h | 71 kernel/printk.c| 215 2 files

[PATCH 4/4] libata: make libata use printk_header() and mprintk

2008-01-15 Thread Tejun Heo
headers making them difficult to tell to which error they belong to, awkward manual indents and complex message printing logics. More importantly, by making message assembly flexible, this patch makes future changes to device configuration and EH reporting easier. Signed-off-by: Tejun Heo <[EM

[PATCH 2/4] printk: implement [v]printk_header()

2008-01-15 Thread Tejun Heo
cq 7168 in res 40/00:34:de:71:02/00:00:00:00:00/40 Emask 0x10 (ATA bus error) ata8.00: cmd 60/7f:38:61:72:02/00:00:00:00:00/40 tag 7 ncq 65024 in res 40/00:34:de:71:02/00:00:00:00:00/40 Emask 0x10 (ATA bus error) Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- inc

[PATCHSET] printk: implement printk_header() and merging printk

2008-01-15 Thread Tejun Heo
Hello, all. This patchset implements printk_header() and mprintk - merging printk - to make printing multiline messages and assembling message piece-by-piece easier. In a nutshell, printk_header() lets you do the following atomically (against other messages). code: printk(KERN_INFO "ata1.00:

[PATCH 1/4] printk: keep log level on multiline messages

2008-01-15 Thread Tejun Heo
by later changes. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- kernel/printk.c | 51 --- 1 files changed, 24 insertions(+), 27 deletions(-) diff --git a/kernel/printk.c b/kernel/printk.c index 89011bf..6df1872 100644 --- a/kerne

[PATCH #upstream-fixes] libata: relocate sdev->manage_start_stop configuration

2008-01-14 Thread Tejun Heo
After 9b8e8de7, manage_start_stop configuration depends on valid ATA device. Move it into ata_scsi_dev_config(). This was detected by the coverity checker. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/ata/libata-scsi.c |6 ++

Re: Sata 4726 Testing

2008-01-13 Thread Tejun Heo
Andrew Ryder wrote: > Tejun, > > I have completed some of the testing, things were working fine.. then > something died. It will not even recognize the 4726 anymore. During book > when the HBA does it scan nor in windows 2000 does anything work or be > recognized. > > I will have a new eSATA cabl

Re: 40-wire cable detected when directly connected

2008-01-12 Thread Tejun Heo
Tobias Müller wrote: > Hi > >> Please apply the attached patch and specify libata.force_cbl=80 as >> kernel boot parameter. If you load libata from initrd or after boot you >> need to pass 'force_cbl=80' as module parameter. How you do it depends >> on your distro. Ah.. right. I'm brewing more

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-12 Thread Tejun Heo
Marc Howard Zuckman wrote: > On Sat, 12 Jan 2008, Bartlomiej Zolnierkiewicz wrote: > >> >> In "smart mode" controller takes care of mode programming. >> >>> Cc'ing Alan and Bartlomiej. Guys, is this the smart mode problem? Do >>> ide and libata have this fixed in 2.6.24-rc? >> >> [ added Alan an

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-12 Thread Tejun Heo
Marc Howard Zuckman wrote: > On Fri, 11 Jan 2008, Tejun Heo, replying to Marc Zuckman wrote: > >>> Zuckman: > >>> Is it possible that both drivers are present in the kernel and conflict >>> with one another in some fashion? >> Heo: > >

Re: Sata 4726 Testing

2008-01-12 Thread Tejun Heo
Andrew Ryder wrote: > Tejun, > > No problem. I should be thanking you and your team for all the hard work > writing the drivers for the hardware.. > > I think this patch might have solved the issue. I did a quick test: warm > rebooted and turned the 4726 on and off 3 times and all disks were > su

[PATCH #upstream-fixes] sata_sil24: freeze on non-dev errors reported via CERR

2008-01-12 Thread Tejun Heo
rt and the host port condition isn't properly recovered leading to EH failures. This patch makes CERR errors which require resets to freeze the port. This will force host port reset and proper recovery. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: Andrew Ryder <[EMAIL PROT

[PATCH #upstream-fixes] sata_sil24: fix stupid typo

2008-01-12 Thread Tejun Heo
Fix stupid typo. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/sata_sil24.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c index b4c674d..d9c8b32 100644 --- a/drivers/ata/sata_sil24.c +++ b/drive

Re: 40-wire cable detected when directly connected

2008-01-11 Thread Tejun Heo
[cc'ing Alan, thanks for the information on the other message] Tobias Müller wrote: > Tejun Heo schrieb: >> I don't know very well about CF but does it even fill UDMA/33? What >> does 'dd if=/dev/sdc of=/dev/null bs=1M count=16 iflag=direct' say? You >

Re: Sata 4726 Testing

2008-01-10 Thread Tejun Heo
Andrew Ryder wrote: > For the regular power on detected, are you referring to cold/warm > booting the system and verifying initialization or only power cycling > the 4726? > > Here are my test results, TestingRoutine.txt is the procedure I followed > and test results obtained. If I missed somethin

Re: 40-wire cable detected when directly connected

2008-01-10 Thread Tejun Heo
Tobias Müller wrote: > Hello! > > I'm running 2.6.24-rc7 with an Addonics AD4CFPRJ Quad-CF PCI Controller > (http://www.addonics.com/products/flash_memory_reader/ad4cfprj.asp) using > Silicon Image PCI0680 chipset which is connected direct (no cables) with 2 > Compact-Flash Cards. > > In confi

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-10 Thread Tejun Heo
Marc Howard Zuckman wrote: > On Thu, 10 Jan 2008, Tejun Heo wrote: > >> >> Oh... I thought you were using libata drivers because you mentioned >> pata_it821x on the subject. The IDE driver supports 'hdparm -d 1' fine. >> I wonder why that's not w

Re: [PATCH #upstream-fixes] ata_piix: ignore ATA_DMA_ERR on vmware ich4

2008-01-10 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> VMware ich4 emulation incorrectly sets DMA_ERR on TF error. Ignore >> it. >> >> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> > > hrm. IIRC, the old-IDE code just sorta ignores this, and in the > original libata I

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-10 Thread Tejun Heo
Marc Howard Zuckman wrote: > With apologies if this was supposed to be an attachment: Inline is fine. > IT8212: IDE controller at PCI slot :03:0c.0 > IT8212: chipset revision 17 > it821x: controller in smart mode. > IT8212: 100% native mode on irq 21 > ide2: BM-DMA at 0xb800-0xb807, BIOS

Re: disabling sata_nv ADMA for 2.6.24

2008-01-09 Thread Tejun Heo
Robert Hancock wrote: > However, how about putting in a printk in nv_adma_interrupt handler here: > > /* freeze if hotplugged or controller error */ > if (unlikely(status & (NV_ADMA_STAT_HOTPLUG | >NV_ADMA_STAT_HOTUNPLUG | >NV_ADMA_STAT_TIMEOUT | >NV

[PATCH #upstream-fixes] sata_sil24: prevent hba lockup when pass-through ATA commands are used

2008-01-09 Thread Tejun Heo
these commands must be sent alone, like ATAPI commands. Signed-off-by: Gwendal Grignou <[EMAIL PROTECTED]> Acked-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/sata_sil24.c | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) diff -

Re: Sata 4726 Testing

2008-01-09 Thread Tejun Heo
Hello, Andrew Ryder wrote: > This might be of interest.. I had turned the drive off for about 20 > minutes, then turned it back on. ata1.03 is now partially there, it is > recognized as a device, but of 0MB in size. > > All of this is done with the 4726 turned on.. > > Bootlog11.txt -> I unplugg

Re: [PATCH #upstream-fixes] sata_nv: disable ADMA mode by default

2008-01-09 Thread Tejun Heo
Hello, haven't fell asleep yet? Jeff Garzik wrote: > Tejun Heo wrote: >> There still are remaining issues with ADMA support. Disable it by >> default and warn when enabling. >> >> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> >> --- >> Jeff, plea

[PATCH #upstream-fixes] libata-pmp: propagate timeout to host link

2008-01-09 Thread Tejun Heo
Timeout on downstream command may indicate transmission problem on host link. Propagate timeouts to host link. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/libata-eh.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/ata/

[PATCH #upstream-fixes] libata-pmp: 4726 hates SRST

2008-01-09 Thread Tejun Heo
4726 hates SRST even on non-config ports. Don't use it. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/libata-pmp.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index c0c4dbc..cae

Re: Sata 4726 Testing

2008-01-09 Thread Tejun Heo
Andrew Ryder wrote: > Tejun, > > I rebooted with the 4726 online during bootup, verified everything was > there by re-formatting the fs on each drive. I powered off the 4726 for > approx 15 seconds, turned it back on, and repeated the power on/off > again about 1 minute later. > > The first 3 dri

Re: [Fwd: Re: libata , Silicon Image 3124]

2008-01-09 Thread Tejun Heo
Hello, Kasimir Müller wrote: > thanks very much again for your time and readiness to help. > > I applied the patch as you proposed without problem. > > I attach the kernel logs of the past few days. As far as I can see, with > the patched kernel errors appear only under heavy load . > > If you

Re: Sata 4726 Testing

2008-01-09 Thread Tejun Heo
Tejun Heo wrote: > Please apply the attached patch on top of 2.6.24-rc7 and report the > result. Thanks. Andrew, with the patch applied, please try to turn off and on the PMP array while the system is running and verify that each time the array gets detected correctly and disks are acce

Re: Sata 4726 Testing

2008-01-09 Thread Tejun Heo
Gaston, Jason D wrote: > Attached are two dmesg outputs from 2.6.24-rc7 with only this simg quirk > patch applied. > > The first (dmesg_wSipatch) was generated with the PMP turned off during > boot and then powered on, while connected to eSATA. > > The second (dmesg_poweronoff) was generated with

Re: [CALL-FOR-HELP] pata_ali: can't get MWDMA working!

2008-01-09 Thread Tejun Heo
Hello, Sergei. Sergei Shtylyov wrote: >Heh, it works by accident: PIO4 timings correspond to MWDMA ones. The > driver does *not* support MWDMA modes -- there's FIXME in > ali_set_dma_mode(). Yeap, I saw that and lifted MWDMA programming from pata_ali. That's how I got the identical PCI confi

Re: [CALL-FOR-HELP] pata_ali: can't get MWDMA working!

2008-01-09 Thread Tejun Heo
Mark Lord wrote: > Are you really sure that the old IDE is actually issuing DMA commands, > rather than falling back to PIO ? Yeap, pretty sure. Here is debug dump of IDE transferring sector zero. [ 114.377898] XXX writing 0x8 to dma_cmd [ 114.381718] XXX read dma_stat 0x24 and writing 0x26 [

Re: [CALL-FOR-HELP] pata_ali: can't get MWDMA working!

2008-01-09 Thread Tejun Heo
Alan Cox wrote: >> trying to fix it for some time now && finally got a machine with >> pata_ali and non-working MWDMA2 ATAPI device on my desk a few weeks ago. > > Oh good. I've been through a pile of ones that just work. > > Which North and south does it have and what revision ? Attached full o

Re: [CALL-FOR-HELP] pata_ali: can't get MWDMA working!

2008-01-09 Thread Tejun Heo
Hello, Bartlomiej Zolnierkiewicz wrote: >> I wondered whether the device was configured differently, so compared >> hdparm --Istdout results. They were identical too. (attached) > > ATA device, with non-removable media > Model Number: IC25N040ATMR04-0 > Serial Number:

Re: Sata 4726 Testing

2008-01-09 Thread Tejun Heo
Hello, Andrew. Andrew Ryder wrote: > It works. > > Boot log is attached. Great! > I ran mke2fs on all 4 drives simultaneously and all is . I did notice > that DMA was disabled on the hardware? Do you need any info from my side > for this? > > Should device node sdf on the 5th port exist even t

Re: SATA PMP support in 2.6.24-rc3?

2008-01-09 Thread Tejun Heo
Gaston, Jason D wrote: > I am using a Sans Digital PMP, which has a Sil3726CBHU controller in it. > I also have an Addonics PMP and it has the same controller in it. Hmmm... I wonder why all SIMG PMPs I have work just fine. :-( Anyways, can you please test the patch I posted on the other thread

Re: SATA PMP support in 2.6.24-rc3?

2008-01-09 Thread Tejun Heo
Thomas Evans wrote: > I stopped seeing this message when I started using rc4. > > I upgraded to rc7 with your patch - the dmesg is attached. > > The link speed seems limited to 1.5Gbps now though, which hasn't been > the case in rc3->rc6. So, yours works fine w/o the patch, right? -- tejun - T

[PATCH] libata and starting/stopping ATAPI floppy devices

2008-01-09 Thread Tejun Heo
] Sense Key : 0x2 [current] sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0 Signed-off-by: Ondrej Zary <[EMAIL PROTECTED]> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- Trimmed message body and reformatted such that it's script friendly. drivers/ata/libata-scsi.c |3 ++- 1 file

Re: [CALL-FOR-HELP] pata_ali: can't get MWDMA working!

2008-01-09 Thread Tejun Heo
Oh... I forgot to mention something. I traced DMA command execution and the following is what happens. 1. host setups DMA engine (programs BMDMA controller) 2. host issues PACKET 3. device sets BSY 4. host transfers CDB when BSY clears and DRQ sets (Status turns to 0xd0) 5. host activates BMDMA e

[CALL-FOR-HELP] pata_ali: can't get MWDMA working!

2008-01-09 Thread Tejun Heo
Hello, all. Broken MWDMA on pata_ali has caused a number of bug reports. I've been trying to fix it for some time now && finally got a machine with pata_ali and non-working MWDMA2 ATAPI device on my desk a few weeks ago. Testing confirms what users have been reporting - MWDMA2 works fine with th

Re: sata_sil[24] / silicon image binary drivers / SiI4726 RAID

2008-01-08 Thread Tejun Heo
Paul Neuwirth wrote: > Hallo, > i hope I am here at the right address. I am using a Silicon Image 3124 > SATA-Controller with the Silicon Image 4726 pm / > hardware-RAID product, using the sata_sil24 driver. > The pm is also a hardware raid-controller (not SATARAID - fake, see > docs on http://www.

Re: Sata 4726 Testing

2008-01-08 Thread Tejun Heo
Please apply the attached patch on top of 2.6.24-rc7 and report the result. Thanks. -- tejun diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index c0c4dbc..c07566c 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c @@ -467,7 +467,8 @@ static void sata_pmp_quirk

Re: SATA PMP support in 2.6.24-rc3?

2008-01-08 Thread Tejun Heo
Gaston, Jason D wrote: > For reference, here is the dmesg output from the 2.6.24-rc7 kernel W/O > the patch applied. Man, this is weird. Do you happen to have a addonics device too? I have one 4726 and two 3726s here and none shows such problem. Also, there are quite a few people confirming tha

Re: Do SATA tape drives work?

2008-01-08 Thread Tejun Heo
[cc'ing linux-ide] Jonathan Woithe wrote: > Hi guys > > I was wondering whether anyone can shed any light on the status of SATA tape > drives. There's very little info on the net about this at least in the > places I've checked; the only thing of any significance I've found thus far > is a note

Re: [PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-01-08 Thread Tejun Heo
James Bottomley wrote: >> Also, DMA alignment at >> block layer isn't enough for ATA. ATA needs drain buffers for ATAPI >> commands with variable length response. :-( > > OK, where is this in the libata code? The dma_pad size is only 4 bytes, > so this drain, I assume is only a word long? Giv

Re: disabling sata_nv ADMA for 2.6.24

2008-01-08 Thread Tejun Heo
Robert Hancock wrote: > Tejun Heo wrote: >> Tejun Heo wrote: >>> Robert Hancock wrote: >>>> Tejun Heo wrote: >>>>> Tejun Heo wrote: >>>>>>> [ 34.466899] testing NMI watchdog ... <4>WARNING: CPU#0: NMI >>>>>&g

Re: [PATCH #upstream-fixes] libata: implement libata.force_cbl parameter

2008-01-08 Thread Tejun Heo
Alan Cox wrote: >>> In which case we only need to be able to force UDMA33 or less ? >> Cable detection goes wrong and 40c is detected as 80c. However, we got > > In which case we only (see first question). I don't see why we need to > force anything but "max speed UDMA 33" Ah.. yeah, right. I s

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-08 Thread Tejun Heo
Hello, Marc Zuckman wrote: > I recently compiled gentoo-sources-2.6.23-r3 and subsequently vanilla > 2.6.23.12 , but could not get hdparm v 7.7 (or earlier) to set my it8212f > controlled raid array to use dma. > > From past experience, I have learned that my raid 1 array (using the it8212f

Re: [PATCH] libata and starting/stopping ATAPI floppy devices

2008-01-08 Thread Tejun Heo
should be applied? Yeah, looks good to me. Please reformat the message w/ S-O-B. Acked-by: Tejun Heo <[EMAIL PROTECTED]> -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata-sff: PCI IRQ handling fix

2008-01-08 Thread Tejun Heo
IRQF_SHARED, DRV_NAME, host); > if (rc) > @@ -816,7 +819,7 @@ > > ata_port_desc(host->ports[0], "irq %d", pdev->irq); > ata_port_desc(host->ports[1], "irq %d", pdev->irq); > - } else { > +

Re: Sg/libata hotplug kernel error

2008-01-08 Thread Tejun Heo
Fajun Chen wrote: > Hi All, > > Has anyone seen this kernel error before? The controller is Sil3124 > and kernel version 2.6.18-rc2. This seems to happen very rarely since > this is the first time I 've seen this error message. Thanks for your > feedback! 2.6.18? Sadly, you're on your own && th

Re: Believed resolved: SATA kern-buffRd read slow: based on promise driver bug

2008-01-08 Thread Tejun Heo
Linda Walsh wrote: >Is 'main' diff between NCQ/TCQ that TCQ can re-arrange 'write' > priority under driver control, whereas NCQ is mostly a FIFO queue? No, NCQ can reorder although I recently heard that windows issues overlapping NCQ commands and expects them to be processed in order (what wer

Re: [PATCH 2.6.24 1/1] sata_sil24: prevent hba lockup when pass-through ATA commands are used

2008-01-08 Thread Tejun Heo
these commands must be sent alone, like ATAPI commands. Thanks a lot. You forgot S-O-B. Acked-by: Tejun Heo <[EMAIL PROTECTED]> Jeff, please queue this for 2.6.24. Gwendal, IIRC you guys use lots of PMPs on your server farms, right? How is the current code working there? Do you guys see a

Re: [PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-01-08 Thread Tejun Heo
James Bottomley wrote: > ATA requires that all DMA transfers begin and end on word boundaries. > Because of this, a large amount of machinery grew up in ide to adjust > scatterlists on this basis. However, as of 2.5, the block layer has a > dma_alignment variable which ensures both the beginning a

Re: disabling sata_nv ADMA for 2.6.24

2008-01-08 Thread Tejun Heo
Tejun Heo wrote: > Robert Hancock wrote: >> Tejun Heo wrote: >>> Tejun Heo wrote: >>>>> [ 34.466899] testing NMI watchdog ... <4>WARNING: CPU#0: NMI appears >>>>> to be stuck (0->0)! >>>>> [ 34.555056] WARNING: CPU#1: N

Re: disabling sata_nv ADMA for 2.6.24

2008-01-08 Thread Tejun Heo
Robert Hancock wrote: > Tejun Heo wrote: >> Tejun Heo wrote: >>>> [ 34.466899] testing NMI watchdog ... <4>WARNING: CPU#0: NMI appears >>>> to be stuck (0->0)! >>>> [ 34.555056] WARNING: CPU#1: NMI appears to be stuck (0->0)! >>&g

Re: [Re: Linux 2.6.24-rc7] ata1: exception Emask 0x10 SAct 0x0 SErr 0x0 action 0x9 t4

2008-01-08 Thread Tejun Heo
Maciej Rutecki wrote: > I have this message when resume from suspend to disk: > > hda: host max PIO4 wanted PIO255(auto-tune) selected PIO4 > hda: MWDMA2 mode selected > sd 0:0:0:0: [sda] Starting disk > [...] > ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) > ata1.00: ACPI cmd f5/00:00:00

Re: [PATCH #upstream-fixes] libata: implement libata.force_cbl parameter

2008-01-08 Thread Tejun Heo
Alan Cox wrote: >> This only forces PATA controllers to certain cable type. It's a last >> resort method for installation or live media - just enough to get things >> going. > > In which case we only need to be able to force UDMA33 or less ? Cable detection goes wrong and 40c is detected as 80c.

Re: [PATCH #upstream-fixes] libata: implement libata.force_cbl parameter

2008-01-08 Thread Tejun Heo
Alan Cox wrote: > On Tue, 08 Jan 2008 22:19:38 +0900 > Tejun Heo <[EMAIL PROTECTED]> wrote: > >> Implement libata.force_cbl parameter to work around incorrect PATA >> cable detection. > > This seems to be a pretty hopeless hack as it assumes all your devices &g

[PATCH #upstream-fixes] libata: implement libata.force_cbl parameter

2008-01-08 Thread Tejun Heo
Implement libata.force_cbl parameter to work around incorrect PATA cable detection. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- Sledgehammer for just-in-case. Feel free to include or ignore. drivers/ata/libata-core.c |4 drivers/ata/libata-eh.c

Re: SATA PMP support in 2.6.24-rc3?

2008-01-08 Thread Tejun Heo
Tom Evans wrote: > > I'm also seeing this with 2.6.23-rc3 on my Alpha system - sata_sil24 and > a SiliconImage PMP. Gaston, Tom, can you guys please apply the attached patch on top of 2.6.24-rc7 and see whether the problem goes away. Thanks. -- tejun diff --git a/drivers/ata/libata-core.c b/dr

[PATCH #upstream-fixes] libata: don't normalize UNKNOWN to NONE after reset

2008-01-08 Thread Tejun Heo
fter non-classifying resets. This fixes the above problem. As UNKNOWN and NONE are handled differently by only EH hotplug logic, this doesn't cause other behavior changes. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: Robert Hancock <[EMAIL PROTECTED]> --- Robert, missing new

Re: disabling sata_nv ADMA for 2.6.24

2008-01-08 Thread Tejun Heo
Tejun Heo wrote: >> [ 34.466899] testing NMI watchdog ... <4>WARNING: CPU#0: NMI appears >> to be stuck (0->0)! >> [ 34.555056] WARNING: CPU#1: NMI appears to be stuck (0->0)! > > Oops, missed that. I'll see whether there's IRQ storm going o

Re: Sata 4726 Testing

2008-01-07 Thread Tejun Heo
Hello, Andrew Ryder wrote: > Yes the issue is still there. I have also tried it with 2.6.24-rc6-git4. > > BootLog1.txt > 2.6.24-rc6-git4: machine booting up, drive array on before machine is > powered on, drive array is configured as one large disk (RAID-1). > > Bootlog2.txt > Same kernel as #1,

Re: [Fwd: Re: libata , Silicon Image 3124]

2008-01-07 Thread Tejun Heo
Kasimir Müller wrote: > Hi Tejun, > > Old communication appended below. > > I wish you a Happy Xmas and a successful New Year. > > I spent some time during Christmas to further investigate the problem. I > bought a new 500GB disk and put all data on this disk. > This is also contineously watched

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Tejun Heo
Robert Hancock wrote: > Tejun Heo wrote: >> Tejun Heo wrote: >>> Robert Hancock wrote: >>>>> Okay, just succeeded on the current #upstream-fixes, attaching the >>>>> log. >>>>> The machine is a brick after the crash. >>>

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Tejun Heo
Tejun Heo wrote: > Robert Hancock wrote: >>> Okay, just succeeded on the current #upstream-fixes, attaching the log. >>> The machine is a brick after the crash. >> I assume the cable got reconnected at 325 seconds? It looks like that >> was during error handlin

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Tejun Heo
Robert Hancock wrote: >> Okay, just succeeded on the current #upstream-fixes, attaching the log. >> The machine is a brick after the crash. > > I assume the cable got reconnected at 325 seconds? It looks like that > was during error handling for the previous unplug? I don't remember too well (th

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Tejun Heo
Tejun Heo wrote: > Robert Hancock wrote: >>>> This has only been reported on one person's MSI board. Apparently >>>> another revision of the same board is reported to work, and I can't >>>> duplicate the problem on my Asus board, so it could just

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Tejun Heo
Robert Hancock wrote: >>> This has only been reported on one person's MSI board. Apparently >>> another revision of the same board is reported to work, and I can't >>> duplicate the problem on my Asus board, so it could just be some >>> hardware problem on that motherboard. >> >> IIRC, I have two f

Re: disabling sata_nv ADMA for 2.6.24

2008-01-07 Thread Tejun Heo
Robert Hancock wrote: > Mark Lord wrote: >> Tejun Heo wrote: >>> Hello, guys. >>> >>> We still have three problems with ADMA. >>> >>> * hard lockup during resume * occasional hard lockup after >>> hotplug or other erros (probably

Re: Sata 4726 Testing

2008-01-07 Thread Tejun Heo
Andrew Ryder wrote: > I've attached the boot log from the 2.6.24-rc5 kernel. The problem > repeats itself in the same manner as with the 2.6.23 kernel with the > libata patches. > > Here is the info on the sata controller and HPM. > > Addonics: > > - 4 port Sata II Raid5 HBA with the SIL3124 (AD

[PATCH #upstream-fixes] sata_nv: disable ADMA mode by default

2008-01-07 Thread Tejun Heo
There still are remaining issues with ADMA support. Disable it by default and warn when enabling. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- Jeff, please hold off till Robert acks. Robert, what do you think? drivers/ata/sata_nv.c |5 - 1 file changed, 4 insertions(+), 1 de

<    1   2   3   4   5   6   7   8   9   10   >