From: Sonic Zhang [EMAIL PROTECTED]
Signed-off-by: Sonic Zhang [EMAIL PROTECTED]
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
drivers/ata/pata_bf54x.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
index
From: Sonic Zhang [EMAIL PROTECTED]
Signed-off-by: Sonic Zhang [EMAIL PROTECTED]
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
drivers/ata/pata_bf54x.c | 12 +---
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
index
Many pata-bf54x driver updates against latest linus mainline tree
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Cc: Sonic Zhang [EMAIL PROTECTED]
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
drivers/ata/pata_bf54x.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
index d66f773..7f87f10 100644
--- a/drivers/ata/pata_bf54x.c
From: Sonic Zhang [EMAIL PROTECTED]
Signed-off-by: Robin Getz [EMAIL PROTECTED]
Signed-off-by: Michael Hennerich [EMAIL PROTECTED]
Signed-off-by: Sonic Zhang [EMAIL PROTECTED]
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
drivers/ata/pata_bf54x.c | 37 +++--
1
There's no reason not to allow multiple calls to pcim_enable_device().
Calls after the first one can simply be noop. All PCI resources will
be released when the initial pcim_enable_device() resource is
released.
This allows more flexibility to managed PCI users.
Signed-off-by: Tejun Heo [EMAIL
Hello, all.
This is the first take of cleanup-sht-ops patchset. As the name
suggests it reorganizes and cleans up scsi_host_template and
ata_port_operation tables used by libata core and low level drivers.
libata has always tried to allow a lot of flexibility to its low level
drivers and most
Over the time, ops in ata_port_operations has become a bit confusing.
Reorganize. SFF/BMDMA ops are separated into separate a group as they
will be taken out of ata_port_operations later.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
include/linux/libata.h | 117
-irq_clear() is used to clear IRQ bit of a SFF controller and isn't
useful for drivers which don't use libata SFF HSM implementation.
However, it's a required callback and many drivers implement their own
noop version as placeholder. This patch implements ata_noop_irq_clear
and use it to replace
Over the time, port info, ops and sht structures developed quite a bit
of inconsistencies. This patch updates drivers.
* Enable/disable_pm callbacks added to all ahci ops tables.
* Every driver for SFF controllers now uses ata_sff_port_start()
instead of ata_port_start() unless the driver has
libata core layer doesn't care about sht or -irq_handler. Those are
only of interest to the LLD during initialization. This is confusing
and has caused several drivers to have duplicate unused initializers
for these fields.
Currently only sata_nv uses these fields. Make sata_nv use
When no reset method is available, libata currently oopses. Although
the condition can't happen unless there's a bug in a low level driver,
oopsing isn't the best way to report the error condition. Complain,
dump stack and fail reset instead.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
This
applied 10-13
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
http://git.kernel.org/?p=linux/kernel/git/tj/libata-dev.git;a=shortlog;h=cleanup-sht-ops
git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata-dev.git cleanup-sht-ops
Thanks.
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL
Mark Lord wrote:
Jeff Garzik wrote:
Mark Lord wrote:
Create host-owned DMA memory pools, for use in allocating/freeing
per-port
command/response queues and SG tables. This gives us a way to
guarantee we
meet the hardware address alignment requirements, and also reduces
memory that
might
ata_pci_init_one() is the only function which uses ops-irq_handler
and pi-sht. Other initialization functions take the same information
as arguments. This causes confusion and duplicate unused entries in
structures.
Make ata_pci_init_one() take sht as an argument and use ata_interrupt
port_info-private_data is currently used for two purposes - to record
private data about the port_info or to specify host-private_data to
use when allocating ata_host.
This overloading is confusing and counter-intuitive in that
port_info-private_data becomes host-private_data instead of
Robert Hancock wrote:
Luben Tuikov wrote:
--- On Mon, 1/28/08, Robert Hancock [EMAIL PROTECTED] wrote:
The trick is that if an ATAPI device is connected, we (as
far as I'm aware) can't use ADMA mode, so we have to switch that
port into legacy mode.
Can you double check this with the HW
Jeff Garzik wrote:
Nope, not corrupted in transit or on this side. It falls into a
familiar pattern:
* git-am(1) fails
* patch(1) succeeds
* when applying patch, patch(1) drops a .orig turd
..
Okay, I figured it out. There's a 1-line offset difference
between what is used in patch 10,
Mark Lord wrote:
Meanwhile, no further action required here.
ACK :)
And thanks for rounding out the NCQ work. sata_mv has needed love and
attention for a while (well, really, its entire life).
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Tejun Heo wrote:
libata lets low level drivers build scsi_host_template and
ata_port_operations tables and register them with upper layers. This
allows low level drivers high level of flexibility but also burdens
them with lots of boilerplate entries in thoes data structures.
..
diff --git
Jeff Garzik wrote:
Mark Lord wrote:
Meanwhile, no further action required here.
ACK :)
And thanks for rounding out the NCQ work. sata_mv has needed love and
attention for a while (well, really, its entire life).
..
Well, it's going to be getting plenty of TLC over the next few months.
Mark Lord wrote:
..
Commands which were not ADMA compatible (eg. MODE_SENSE,
TEST_UNIT_READY, ..)
were simply handled with PIO (in the driver) rather than any form of DMA,
which is okay because those commands are relatively infrequent.
..
A slight correction there: TEST_UNIT_READY was fine
Mark Lord wrote:
Jeff Garzik wrote:
Mark Lord wrote:
Meanwhile, no further action required here.
ACK :)
And thanks for rounding out the NCQ work. sata_mv has needed love and
attention for a while (well, really, its entire life).
..
Well, it's going to be getting plenty of TLC over the
This patch fixes the following section mismatches:
-- snip --
...
WARNING: drivers/ata/built-in.o(.text+0x15072): Section mismatch in reference
from the function piix_init_one() to the function
.devinit.text:piix_init_sata_map()
WARNING: drivers/ata/built-in.o(.text+0x150dd): Section
From: Saeed Bishara [EMAIL PROTECTED]
Marvell's Orion SoC includes SATA controllers based on Marvell's
PCI-to-SATA 88SX controllers. This patch extends the libATA sata_mv
driver to support those controllers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c | 365
From: Saeed Bishara [EMAIL PROTECTED]
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/Kconfig |2 +-
This patch fixes the following section mismatch:
-- snip --
...
WARNING: vmlinux.o(.text+0x3b641c): Section mismatch in reference from the
function .pmac_ide_setup_device() to the function
.init.text:.pmac_ide_setup_dma()
...
-- snip --
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
Shuffling the drives did not change anything to the linkspeed of the 3
ports running with 1.5 Gbps. Looks like the problem is port-related.
Hmm... Okay. Maybe the signal traces or connectors have some problems.
But 3.0Gbps on downstream port doesn't make any difference anyway so
unless it
Mark Lord wrote:
Robert Hancock wrote:
Luben Tuikov wrote:
--- On Mon, 1/28/08, Robert Hancock [EMAIL PROTECTED] wrote:
The trick is that if an ATAPI device is connected, we (as
far as I'm aware) can't use ADMA mode, so we have to switch that
port into legacy mode.
Can you double check this
[EMAIL PROTECTED] wrote:
Sorry for my late answer, but i had to sort this out first.
After replacing the first PSU with a new Corsair 650W the power no longer
fluctuated more than 0,01 V (and this only when booting up the drives...)
I did a full resync on both raid arrays and got no more
Hi Roland, Borislav, Bart,
Added linux-ide ML, since we may be able to get helps from other
ide experts. This thread started from:
http://lkml.org/lkml/2008/1/29/140
On Tue, 29 Jan 2008 18:23:56 -0500 (EST), Kiyoshi Ueda wrote:
Hi Bart,
On Tue, 29 Jan 2008 14:22:53 -0800, Roland Dreier
Could you try the patch below and give me all boot messages again?
Sure, no problem, see below for full log (I updated to the latest git,
which seems to have some other unrelated problems with things timing
out earlier in the boot, but it does get to the ide-cd init); here's
the relevant
Mark Lord wrote:
So, I'm not sure its worth the latency penalty... at least as turned
on by default.
..
I agree. It should default to off, and perhaps have some /sys/ attributes
to enable/tune it. Or something like that.
Eeeek.. :-)
The theoretical value is apparently for situations
Tejun Heo wrote:
I'm skeptical about the benefit of IRQ coalescing on storage
controllers. Coalescing improves performance when there are many small
requests to complete and if you put a lot of small non-consecutive
requests to a disk, it gets really really really slow and IRQ coalescing
Mark Lord wrote:
Tejun Heo wrote:
libata lets low level drivers build scsi_host_template and
ata_port_operations tables and register them with upper layers. This
allows low level drivers high level of flexibility but also burdens
them with lots of boilerplate entries in thoes data
Tejun Heo wrote:
..
I'm skeptical about the benefit of IRQ coalescing on storage
controllers. Coalescing improves performance when there are many small
requests to complete and if you put a lot of small non-consecutive
requests to a disk, it gets really really really slow and IRQ coalescing
Tejun Heo wrote:
Mark Lord wrote:
Tejun Heo wrote:
libata lets low level drivers build scsi_host_template and
ata_port_operations tables and register them with upper layers. This
allows low level drivers high level of flexibility but also burdens
them with lots of boilerplate entries in thoes
Mark Lord wrote:
I think this will need to be re-diff'd against the latest sata_mv,
which now has NCQ support.
No problem at all. Just push it into #upstream. :-)
..
Oh, it is/was already there. And I quoted the wrong lines from your patch.
Let's try again:
Is it? I don't see it in
On Tue, Jan 29, 2008 at 02:09:52PM -0800, Luben Tuikov wrote:
The ideal solution would be to do mapping against a
different struct
device for each port, so that we could maintain the proper
DMA mask for
each of them at all times. However I'm not sure if
that's possible. The
On Wed, Jan 30, 2008 at 06:20:04PM +0900, Tejun Heo wrote:
There's no reason not to allow multiple calls to pcim_enable_device().
Calls after the first one can simply be noop. All PCI resources will
be released when the initial pcim_enable_device() resource is
released.
This allows more
41 matches
Mail list logo
