Re: [PATCH] libata-dev-2.6 -- pdc2027x timing register bug fix

2005-01-27 Thread Jeff Garzik
applied to libata-dev-2.6 queue - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Marvell 88SX[56]0[48]1 libata progress?

2005-01-27 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: I was just wondering if there's been any progress. I'm about to invest in an Abit SU-2S with an 88sx6081 on board, and was wondering how things were going. No progress to report, I'm afraid. I've been fighting bugs and working towards hotplug/queueing/error handling

Re: Marvell 88SX[56]0[48]1 libata progress?

2005-01-27 Thread Jeff Garzik
Andy Warner wrote: Jeff Garzik wrote: [...] If anybody has the hardware docs and time, they are welcome to contribute. A few months ago, it seems like things had already been started, got any code to share, or are we at ground zero for the Marvell chipset ? I've got a skeleton of a driver

Re: Marvell 88SX[56]0[48]1 libata progress?

2005-01-28 Thread Jeff Garzik
Bogdan Costescu wrote: On Thu, 27 Jan 2005, Jeff Garzik wrote: After that, I'll do a round of driver writing for Marvell and several other boards. Any tentative time-frame ? I'm also interested due to the presence of this controller disguised as Adaptec AIC-8110 on my Asus mainboard

Re: [PATCH} sata_nv: enable generic class support for future NVIDIA SATA controllers

2005-02-01 Thread Jeff Garzik
looks good, applied, sorry for the delay. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: SCSI to ATA translation fix

2005-02-01 Thread Jeff Garzik
Albert Lee wrote: Hi Jeff, Attached please find the patch against libata-2.6 for your review. Changes: #1. ata_scsi_rw_xlat(): Fix incorrect SCSI to ATA translation for 16 bytes SCSI Read/Write commands. (Already submitted in the previous patch. Merged with change #2 and resubmitted

Re: [PATCH] libata-dev-2.6: verify cmd bug fixes/support

2005-02-01 Thread Jeff Garzik
Brett Russ wrote: Below find a patch which gets the read verify command working. Note that in order to get this 100% working one also needs to apply Albert Lee's patch: http://article.gmane.org/gmane.linux.ide/2798 to libata* before or after this. I've stripped out his portion of the changes

Re: SATA NCQ

2005-02-02 Thread Jeff Garzik
Mat Loikkanen wrote: Jeff- Any word on when Native Command Queueing will be supported by Libata? I see in your status report there's a dependency on drives being available. As it [snip, due to mailing list] implemented over in Windows?) ... I'd be available to work on adding NCQ support to

Re: [PATCH] libata-2.6: verify cmd bug fixes/support

2005-02-05 Thread Jeff Garzik
Brett Russ wrote: Below is a resend of a patch which gets the read verify command working. I moved the patch to the libata-2.6 tree since that seems to be where Albert's patch ended up, so let's keep them together. Sending as an attachment to avoid mailer interference. Signed-off-by: Brett

Re: [Patch? 2.6.10-rc3-bk17] ata_pci_remove_one used freed memory

2005-02-05 Thread Jeff Garzik
Adam J. Richter wrote: Attempting to unload a serial ATA driver module gave me a kernel memory fault. I think this problem occurs in all configurations, but I should mention that my configuration may be slightly unusual in that I configured my BIOS not to do IDE emulation with SATA disks,

Re: Problem with Promise SATA-II 150 TX4 Controller (rev 2) [105a:3d18]

2005-02-05 Thread Jeff Garzik
Georg C. F. Greve wrote: [update] After some more investigation, I stumbled upon the thread that dealt with the Promise 579 in October 2004, which contained a similar situation and error message with the proposed fix at http://marc.theaimsgroup.com/?l=linux-idem=109814647928388w=2 a version of

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-06 Thread Jeff Garzik
Mark Lord wrote: Jeff Garzik wrote: 3) In Promise's GPL'd driver for their SATA (w/ PATA) cards, they unconditionally execute the INITIALIZE DEVICE PARAMETERS command. I wonder if we should do the same. That command was *necessary* for certain drives at one time, which refused all other

Re: [patch] scsi/ahci: Add support for ULi M5287

2005-02-05 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Hi,Jeff: I think you are not necessary add the m5287 support to ahci.c now, the code I add is to correct the two bugs of our controller, now we have designed a new AHCI controller name M5288(device id is 0x5288), it work perfectly with the linux ahci driver only add

Re: [PATCH 2.6.11-rc2 0/29] ide: driver updates

2005-02-02 Thread Jeff Garzik
Tejun Heo wrote: Hello, B. Zolnierkiewicz. These patches are various fixes/improvements to the ide driver. They are against the 2.6 bk tree as of today (20050202). 01_ide_remove_adma100.patch Removes drivers/ide/pci/adma100.[hc]. The driver isn't compilable (missing functions)

[RFT 2.6.11-rc2-bk10] libata (SATA) driver update

2005-02-02 Thread Jeff Garzik
translation fixes Andrew Chew: o sata_nv: enable generic class support for future NVIDIA SATA Jeff Garzik: o [libata sata_promise] support Promise SATAII TX2/TX4 cards o [libata] Remove CDROM drive from PATA DMA blacklist o [libata] add DMA blacklist diff -Nru a/drivers/scsi/libata-core.c

Re: Inclusion of patch for Promise SATAII 150 TX4 in mainline 2.6 kernel?

2005-02-07 Thread Jeff Garzik
Mark Hahn wrote: has no builtin support for Promise SATAII 150 TX4 yet; a separate patch (http://marc.theaimsgroup.com/?l=linux-idem=110426005503319q=raw) is needed to recognize this hardware. I had good luck with this patch as well. I think the SATA-SMART patches should go in too, even if

Re: Issues with SIS 964 chipset on SATA

2005-02-07 Thread Jeff Garzik
Gary Poppitz wrote: We tracked down a problem with the 964 chipset with a 0x180 ID code that may save someone on the list some time. The chip will only transfer multiples of 4 bytes. Anything else will cause it to hang. Interesting, either ULi or SiS set me a needs-to-be-cleaned-up-a-lot fix

Re: Sata_promise.c queries

2005-02-11 Thread Jeff Garzik
Gary Poppitz wrote: First off, I have the libdata-2.6 pull. The version of sata_promise.c is 1.58 . Is this the latest one available? Next question, in function pdc_qc_issue_prot, there is a BUG() call in the case of ATA_PROT_ATAPI_DMA. Is this one of those fixmes that will be addressed Real

Re: Problem on SATA-disk with Promise SATAII 150 TX4 (DriveReady SeekComplete Error)

2005-02-11 Thread Jeff Garzik
Johannes Resch wrote: Hi, [please CC me on replies] I've got a box running 2.6.10 (with the patch[0] needed to support the Promise SATAII 150 TX4 controller). This box has three software raid1 partitions mirrored on a SATA disk on the Promise controller and a disk on the mainboard IDE controller

PATA drivers in libata?

2005-02-13 Thread Jeff Garzik
I wanted to open a discussion on libata and PATA. libata-dev now has two drivers that support PATA, pata_pdc2027x and ata_piix, and the core is getting close (DMA blacklist in, C/H/S support close). What are the opinions on issues relating to making PATA libata support available in the

[SATA] libata-dev queue updated

2005-02-13 Thread Jeff Garzik
and errata for PATA-SATA bridges Jeff Garzik: o [libata] turn on ATAPI support o [libata sata_promise] merge Tobias Lorenz' pdc20619 patch, part 2 o [libata] small cleanups o [libata] remove unused execute-device-diagnostic reset method o [libata] add new driver ata_adma o [libata sata_via

Re: PATA drivers in libata?

2005-02-13 Thread Jeff Garzik
Mark Hahn wrote: * With ATA passthru (in libata-dev currently), libata supports SMART and the HDIO_CMD/HDIO_TASK generalized ioctls. Should I care about supporting other ioctls? is there some other mechanism to en/disable write caching? Besides the SG_IO | HDIO_DRIVE_CMD | HDIO_DRIVE_TASK |

Re: PATA drivers in libata?

2005-02-13 Thread Jeff Garzik
Alan Cox wrote: On Sul, 2005-02-13 at 18:51, Jeff Garzik wrote: libata-dev now has two drivers that support PATA, pata_pdc2027x and ata_piix, and the core is getting close (DMA blacklist in, C/H/S support close). Do you have DMA change down sorted - CRC error, drop speed and/or switch to PIO

Re: PATA drivers in libata?

2005-02-13 Thread Jeff Garzik
On Sun, Feb 13, 2005 at 06:19:31PM -0600, Doug Maxey wrote: On Sun, 13 Feb 2005 17:01:51 EST, Jeff Garzik wrote: Mark Hahn wrote: * With ATA passthru (in libata-dev currently), libata supports SMART and the HDIO_CMD/HDIO_TASK generalized ioctls. Should I care about supporting other

Re: sata disk failure?

2005-02-15 Thread Jeff Garzik
Guillaume Laurès wrote: Hello, Here is a small report in attachement, done with 2.6.11-rc4. * Hardware is nforce3 250GB, booting debian pure64 on pata (Maxtor 30Gb 6E030L0) drive. The goal is to mount data found on a sata

Re: libata oops 2.6.11-rc4 yesterdays BK

2005-02-16 Thread Jeff Garzik
Brad Campbell wrote: Brad Campbell wrote: Woke up to this, this morning. This is yesterdays 2.6.11-rc4 BK + libata BK + libata-dev BK It was in the middle of a RAID-6 rebuild (scheduled to take about 740 minutes) Oh well, it appears to be reproducible anyway! Reproducible without the libata-dev

Re: 31244 sata_vsc PPC

2005-02-16 Thread Jeff Garzik
Ajit Prem wrote: As a follow-up to my previous email where I indicated that int_status on entry into vsc_sata_interrupt indicates 0x8300, I put in a crude fix in the vsc_sata_interrupt handler to read the taskfile status register, and to clear the appropriate bits in the SATA SError register, and

Re: libata oops 2.6.11-rc4 yesterdays BK

2005-02-16 Thread Jeff Garzik
Andy Warner wrote: Brad Campbell wrote: [...] Actually, I'm not sure without the libata dev patch as that removes SMART support, and I'm not convinced that my smartd polling every 20 minutes does not have something to do with it. All I know is the older kernel seems to cope. We'll see. 320

Re: [PATCH 2.6.11-rc4+] sata_qstor: new basic driver for Pacific Digital QStor

2005-02-16 Thread Jeff Garzik
Mark Lord wrote: This is a new basic libata SATA driver for the Pacific Digital QStor SATA/RAID card. It features ordinary per-drive SATA with single-request DMA for R/W commands, and PIO for everything else. It currently does not implement any of the hardware RAID support, nor hot-plug, nor the

Re: Issues with SIS 964 chipset on SATA

2005-02-17 Thread Jeff Garzik
Gary Poppitz wrote: We tracked down a problem with the 964 chipset with a 0x180 ID code that may save someone on the list some time. The chip will only transfer multiples of 4 bytes. Anything else will cause it to hang. After further research, this is popping up on a number of chips (and

Re: Issues with SIS 964 chipset on SATA

2005-02-17 Thread Jeff Garzik
Mark Lord wrote: Jens Axboe wrote: It looks like I will need to do a workaround for all SATA ATAPI devices: if the transfer is not a multiple of 4 bytes, pad it with an DMA 1-3 byte DMA segment. Yup, that requirement has existed on most of the hardware I've done drivers for, both SATA and a

Re: Issues with SIS 964 chipset on SATA

2005-02-17 Thread Jeff Garzik
Jens Axboe wrote: On Thu, Feb 17 2005, Jeff Garzik wrote: It looks like I will need to do a workaround for all SATA ATAPI devices: if the transfer is not a multiple of 4 bytes, pad it with an DMA 1-3 byte DMA segment. Yeah we definitely need something like that. The optimal solution is to make

Re: libata oops 2.6.11-rc4 yesterdays BK

2005-02-17 Thread Jeff Garzik
Andy Warner wrote: Jeff Garzik wrote: [...] I'm starting to wonder if polling isn't just a dismal failure on SATA, since the status register/etc. is all emulated. Thinking further along those lines (how an ATA shadow register set is faked by the host controller using FIS data), I wonder

Re: Which SATA Combos To Consider?

2005-02-17 Thread Jeff Garzik
Danny Cox wrote: I've been mostly lurking here for awhile now, just seeing how things are going. I've seen various drives on a blacklist, and various controllers that do this or that well, but have problems doing foo. There also seem to have been a Strange Interaction as well, but that's

Re: libata oops 2.6.11-rc4 yesterdays BK

2005-02-17 Thread Jeff Garzik
Andy Warner wrote: Jeff Garzik wrote: [...] AHCI is the first scenario where PIO-via-DMA could be utilized in an efficient manner. The upcoming SiI 3124 is another. A few others (ADMA, Marvell) are PIO-via-DMA controllers as well. I agree this is a good thing. I _think_ the SATA-II stuff

libata docs updated

2005-02-18 Thread Jeff Garzik
I regenerated the libata documentation PDF (Documentation/DocBook/libata.tmpl), which includes documentation on the libata driver API, external (exported) functions, and internal functions. http://www.kernel.org/pub/linux/kernel/people/jgarzik/libata/libata.pdf Feel free to update this document

Re: SATAPI timing

2005-02-18 Thread Jeff Garzik
Albert Lee wrote: I'm a little confused about what is the correct behavior of ATAPI DMA INTRQ. 1. The ATA-4 flowchart and ATA-6 state diagram seems to be inconsistent. In the ATA-4 flowchart, no wait for INTRQ is specified. 2. From the ATA-5 errata: http://www.t13.org/project/e01122r0.pdf ...Page

Re: 2.4.29-pre1 OOPS early in boot with Intel ICH5 SATA controller

2005-02-19 Thread Jeff Garzik
Alan J. Wylie wrote: On Mon, 13 Dec 2004 06:09:26 -0500, Jeff Garzik [EMAIL PROTECTED] said: Is it possible for you to enable the following two #ifdefs in include/linux/libata.h, and send me the output? #define ATA_DEBUG/* debugging output */ #define ATA_VERBOSE_DEBUG

Re: sata_sil data corruption

2005-02-19 Thread Jeff Garzik
PALFFY Daniel wrote: Hi, I'm trying to set up a machine with a si3112a controller (lspci: 1095:3112 (rev 01) Subsystem: 1095:6112, cheap PCI card) and a ST3200822AS Rev: 3.01 disk and I see continuous silent data corruption while reading the disk. Writing seems to be ok. I have 2.6.10-ac1 built

[SATA] libata-dev queue updated

2005-02-19 Thread Jeff Garzik
for Promise PATA 2027x Brad Campbell: o libata basic detection and errata for PATA-SATA bridges Jeff Garzik: o [libata ahci] support PCI MSI interrupt vector o [libata adma] Add init code, fix CPB submission code o [libata ahci] finish ATAPI support o [libata adma] trivial whitespace

Re: sata_sil data corruption

2005-02-21 Thread Jeff Garzik
Doug McLain wrote: The sata_sil driver is without a doubt, totally hosed. I, along with without a doubt being defined, of course, as it works for a lot of people. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED]

Re: FC3 driver for Promise TX4200?

2005-02-21 Thread Jeff Garzik
Stephenson Yang wrote: Hello, Just wondering if there is a 2.6 driver for the TX4200. The latest sata_promise (for TX4) does not work with TX4200. I notice Promise has the source code for 2.4 (http://www.promise.com/support/download/download2_eng.asp?productID=128category=allos=100#) I don't

[PATCH] libata kfree fix

2005-02-21 Thread Jeff Garzik
Fixes double-kfree that caused slab corruption. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] = drivers/scsi/libata-core.c 1.116 vs edited = --- 1.116/drivers/scsi/libata-core.c2005-02-01 20:23:51 -05:00 +++ edited/drivers/scsi/libata-core.c 2005-02-20 23:34:32 -05:00 @@ -2800,7

[BK PATCHES] 2.6.x libata fixes (mostly)

2005-02-23 Thread Jeff Garzik
. If xlat_func returns non-zero, control jumps to err_out which fails to free the allocated command. Fix is to add a new API to free unused commands. Signed-off-by: John W. Linville [EMAIL PROTECTED] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] [EMAIL PROTECTED] (05/02/17

[BK PATCHES] 2.4.x libata fixes (mostly)

2005-02-23 Thread Jeff Garzik
Description reproduced from 2.6 version at http://marc.theaimsgroup.com/?l=linux-kernelm=110918919831955w=2: This BK push includes additional hardware support, but that's only because it's (a) obviously low impact and (b) it was in the queue. Far more important are: 1) API additions, to fix a

Re: [BK PATCHES] 2.6.x libata fixes (mostly)

2005-02-23 Thread Jeff Garzik
Thanks. All this stuff was minor, so I'll wait until 2.6.11 release to update. I forwarded the qstor stuff to maintainer Mark Lord. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: libata-scsi.c: ata_scsi_simulate question

2005-02-23 Thread Jeff Garzik
On Wed, Feb 23, 2005 at 04:35:11PM -0600, Winstel, Drew wrote: I noticed that in libata-scsi.c, the ata_scsi_simulate() function calls for the SCSI commands SEEK_6 and SEEK_10 are being simulated instead of being translated to the ATA SEEK command (0x70). Why is this being done? That's

Re: [PATCH libata-dev-2.6] ata_scsi_verify_xlat() fix

2005-02-24 Thread Jeff Garzik
As far as I can tell, your patches are diff'd correctly. Yet, they still do not apply: drivers/scsi/libata-scsi.c 1.68: 1661 lines 2 out of 2 hunks FAILED -- saving rejects to file drivers/scsi/libata-scsi.c.rej I do not understand the problem, so I simply applied them by hand. Thanks for

Re: PROBLEM: ICH7 SATA drive not detected.

2005-02-25 Thread Jeff Garzik
Comment out the function call to piix_disable_ahci() and see what happens. if (port_info[0]-host_flags PIIX_FLAG_AHCI) { int rc = piix_disable_ahci(pdev); if (rc) return rc; } Regards, Jeff - To unsubscribe from this

Re: [PATCH] Re: 2.6.11-rc4 libata-core (irq 30: nobody cared!)

2005-02-26 Thread Jeff Garzik
Rogério Brito wrote: On Feb 23 2005, Jeff Garzik wrote: Does this patch do anything useful? Jeff (...) The patch you posted seems to only affect people using SATA, right? BTW, just for clarity I'm seeing the message in a PATA environment (on i386) and Brian is seeing his problem

Re: [PATCH 2.6.11-rc3 10/11] ide: make ide_cmd_ioctl() use TASKFILE

2005-02-26 Thread Jeff Garzik
For what it's worth... Some vendor-specific commands on PATA devices require -exact- specification of registers in, and registers out. You never want to read more registers than are flagged. Ditto for write. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in

Re: PCI Constants Update for SATA Driver

2005-02-27 Thread Jeff Garzik
Henning Schmiedehausen wrote: Hi, having the various constants in pci_ids.h is a really good thing for grepping through the kernel source. And if they were used, it would be even better (if you e.g. are looking for which driver claims an SIImage 3112 card...). However, the sata_xxx.c files in the

Re: PCI Constants Update for SATA Driver

2005-02-27 Thread Jeff Garzik
On Sun, Feb 27, 2005 at 09:05:06PM +0100, Henning Schmiedehausen wrote: Let me rephrase: What sense does it make to have PCI_VENDOR_ID and PCI_DEVICE_ID constants if using them is optional/discouraged? Only PCI_DEVICE_ID_xxx is discouraged. Not PCI_VENDOR_ID_xxx. Jeff - To

Re: 2.6.11-rc5: sata_sil shows drive twice...

2005-02-28 Thread Jeff Garzik
Prakash Punnoor wrote: hi, dmesg shows this: -- ACPI: PCI Interrupt Link [APC3] enabled at IRQ 18 ACPI: PCI interrupt :01:0b.0[A] - GSI 18 (level, high) - IRQ 18 ata1: SATA max UDMA/100 cmd 0xF0806080 ctl 0xF080608A bmdma 0xF0806000 irq 18 ata2: SATA max UDMA/100 cmd 0xF08060C0 ctl 0xF08060CA

[SATA] libata-dev queue updated

2005-03-01 Thread Jeff Garzik
pdc2027x] fix incorrect pio and mwdma masks o [libata pdc2027x] remove quirks and ROM enable o [libata] add driver for Promise PATA 2027x Brad Campbell: o libata basic detection and errata for PATA-SATA bridges Jeff Garzik: o [libata ahci] Print out port id on error messages o [libata ahci

Re: PCI Constants Update for SATA Driver

2005-03-01 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: On Sun, 2005-02-27 at 13:08 -0500, Jeff Garzik wrote: Henning Schmiedehausen wrote: Hi, having the various constants in pci_ids.h is a really good thing for grepping through the kernel source. And if they were used, it would be even better (if you e.g. are looking

[BK PATCHES] 2.6.x libata updates

2005-03-02 Thread Jeff Garzik
insertions(+), 18 deletions(-) through these ChangeSets: tklauser:nuerscht.ch: o drivers/scsi/ahci: Use the DMA_{64,32}BIT_MASK constants o drivers/scsi/sata_vsc: Use the DMA_{64,32}BIT_MASK constants Jeff Garzik: o [libata ahci] Print out port id on error messages Mark Lord: o [libata

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-02 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Wed, 02 Mar 2005 01:08:56 -0500, Jeff Garzik [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: Yes but it seems that you've assumed that ioctl == flagged taskfile and fs/internal == normal taskfile which is _not_ what I aim for. I want fully-flagged

[SATA] libata-dev-2.6 queue updated

2005-03-03 Thread Jeff Garzik
incorrect pio and mwdma masks o [libata pdc2027x] remove quirks and ROM enable o [libata] add driver for Promise PATA 2027x Brad Campbell: o libata basic detection and errata for PATA-SATA bridges Jeff Garzik: o [libata ahci] Print out port id on error messages o [libata ahci] support PCI

Re: [PATCH] Some IDE chipsets are architecture-specific

2005-03-07 Thread Jeff Garzik
Matthew Wilcox wrote: Mark some chipset support as being for specific architectures. I may have got some wrong, so please double-check. Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] Index: ./drivers/ide/Kconfig === RCS file:

[BK PATCHES] 2.6.x libata updates

2005-03-07 Thread Jeff Garzik
Please do a bk pull bk://gkernel.bkbits.net/libata-2.6 This will update the following files: drivers/scsi/libata-core.c | 16 ++-- drivers/scsi/sata_nv.c |6 -- drivers/scsi/sata_sil.c|2 +- drivers/scsi/sata_svw.c|4 ++--

Re: [PATCH libata-2.6] AHCI: fix fatal error int handling

2005-03-09 Thread Jeff Garzik
Brett Russ wrote: I noticed that the AHCI CI (cmd issue) reg wasn't getting cleared after error ints resulting in no further commands being successfully issued to the port. This patch fixes. All that's really needed is the 1's complement but I also removed the disabling/enabling of the FIS_RX

Re: [PATCH] Re: AHCI: support for tf_read (RFC)

2005-03-10 Thread Jeff Garzik
Brett Russ wrote: Jeff Garzik wrote: I checked the attached patch into a local repository, but haven't yet merged it into libata-dev-2.6, or tested it. Jeff, The below works for me in testing. Can you push into libata-2.6? pulled - To unsubscribe from this list: send the line unsubscribe linux

[SATA] libata-2.4 backport queue updated

2005-03-10 Thread Jeff Garzik
from include/scsi, not drivers/scsi Brett Russ: o AHCI: fix fatal error int handling Jason Gaston: o [PCI] update SATA PCI quirk for Intel ICH7 Jeff Garzik: o [libata ahci] support -tf_read hook o [PCI, libata] Fix combined mode PCI quirk for ICH6 o [libata ata_piix] re-enable combined

Re: sata_via + VT8237 RAID 0 array of 2 s-ata drives

2005-03-11 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Hi Jeff, a quick question about libata + sata_via V1.10 as included in the most recent kernel 2.6.11.2: I have a MSI KT6V (MS-7021) mainboard with VIA VT-8237 Southbridge and want to connect two S-ATA hard disk drives. Both drives should run in a RAID 0 array, which is to

Re: [PATCH libata-2.6] AHCI: compiler warning fix

2005-03-11 Thread Jeff Garzik
Brett Russ wrote: This fixes the compile warning below, which seems due to the enum being signed: drivers/scsi/ahci.c:199: warning: overflow in implicit constant conversion Signed-off-by: Brett Russ [EMAIL PROTECTED] = drivers/scsi/ahci.c 1.17 vs edited = --- 1.17/drivers/scsi/ahci.c Thu

[BK PATCHES] 2.6.x libata fixes

2005-03-11 Thread Jeff Garzik
Please do a bk pull bk://gkernel.bkbits.net/libata-2.6 This will update the following files: drivers/scsi/ahci.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) through these ChangeSets: Brett Russ: o AHCI: fix fatal error int handling Jeff Garzik: o

Re: PATCH libata-2.6 4/5] Prevent the device from overrunning the buffer in __atapi_pio_bytes()

2005-03-22 Thread Jeff Garzik
Albert Lee wrote: Bartlomiej Zolnierkiewicz wrote: Problem: Some bad behaved CD-ROM drives will return more data than ask to. (I have such CD-RW drive and it crashed the kernel.) These devices are compliant with original ATAPI spec. Such condition shouldn't be treated as an error - extra

Re: [PATCH libata-dev-2.6 03/05] libata: update ATA PT sense desc code

2005-03-22 Thread Jeff Garzik
Brett Russ wrote: 03_libata_update_desc_code.patch Change the ATA pass through sense block descriptor code to 0x09 per SAT Signed-off-by: Brett Russ [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: [PATCH libata-2.6] AHCI: compiler warning fix

2005-03-22 Thread Jeff Garzik
Brett Russ wrote: This fixes the compile warning below, which seems due to the enum being signed: drivers/scsi/ahci.c:199: warning: overflow in implicit constant conversion Signed-off-by: Brett Russ [EMAIL PROTECTED] = drivers/scsi/ahci.c 1.17 vs edited = --- 1.17/drivers/scsi/ahci.c Thu

Re: [PATCH libata-2.6 1/5] Fix zero sg_dma_len() on 64-bit platform

2005-03-22 Thread Jeff Garzik
Just FYI... I'll review and merge these patches tomorrow. From a quick glance, they look sane, modulo the ATAPI padding comments earlier. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2.6.11.5 ] sata_sil: Fix FIFO PCI Bus Arbitration

2005-03-23 Thread Jeff Garzik
Carlos Pardo wrote: This patch set default values for the FIFO PCI Bus Arbitration to avoid data corruption. The root cause is due to our PCI bus master handling mismatch with the chipset PCI bridge during DMA xfer (write data to the device). The patch is to setup the DMA fifo threshold so that

Re: [PATCH libata-dev-2.6 01/03] libata: whitespace updates

2005-03-24 Thread Jeff Garzik
applied patches 1-3, thanks much. Small administrivia request, though: after using my patch merging script to merge your patches, I have to do the following things manually: * delete diffstat output * delete patch filename * un-indent patch description text It would be great if I didn't have to

[BK PATCHES] 2.6.x libata fixes

2005-03-29 Thread Jeff Garzik
deletions(-) through these ChangeSets: carlos.pardo:siliconimage.com: o sata_sil: Fix FIFO PCI Bus Arbitration Brett Russ: o libata: support descriptor sense in ctrl page Jason Gaston: o SATA AHCI correction Intel ICH7R Jeff Garzik: o [libata sata_sil] Don't presume PCI cache-line-size reg

Re: [PATCH] drivers/scsi/sata_svw.c: fix compiler warnings

2005-04-05 Thread Jeff Garzik
Nick Wilson wrote: Fixes compiler warnings: warning: passing arg 2 of `writeb' makes pointer from integer without a cast warning: passing arg 1 of `readw' makes pointer from integer without a cast (added to CC list, just to update people on the status of these warnings... I know they're

[PATCH] Re: LIBATA AHCI engine timeout hang with ATAPI devices

2005-04-08 Thread Jeff Garzik
Eric A. Cottrell wrote: Hello, I made the mistake of getting the Plextor SATA DVD Recorder with my new system not realizing that SATA support is just coming online. I want to turn this into an opportunity to make the Plextor work. Thanks to the IDE information pages I got a good start. I

[SATA] status reports updated

2005-04-15 Thread Jeff Garzik
My Linux SATA software/hardware status reports have just been updated. To see where libata (SATA) support stands for a particular piece of hardware, or a particular feature, go to http://linux.yyz.us/sata/ I've still got several patches from EMC (Brett) and IBM (Albert) to go through,

Re: [SATA] status reports updated

2005-04-15 Thread Jeff Garzik
Joe Harvell wrote: Jeff: You need to add a comment about the SATAII TX2/TX4 boards indicating users have experienced data corruption with the sata_promise driver and the SATAII TX4 board. I've posted several emails to linux-ide about this. Why haven't you responded? I've seen reports on the SX4,

Re: ST3120026A working in 2.4.30 w sata_sil

2005-04-18 Thread Jeff Garzik
Tim Moore wrote: FYI; Applied the v0.9 patch to sata_sil.c: # ChangeSet # 2005/03/24 23:32:42-05:00 [EMAIL PROTECTED] # [PATCH] sata_sil: Fix FIFO PCI Bus Arbitration Applied this Brian Kuschak hack to libata-core.c: --- libata-core.c.orig2005-02-23 17:41:03.831836464 -0800 +++ libata-core.c

Re: sata_sil 3112 activity LED patch

2005-07-06 Thread Jeff Garzik
Aric Cyr wrote: After finally getting fed up with not having my activity light working for my SATA drives, I came up with a small patch (more like hack) to make it work. It works quite well, but I'm afraid that there are many restriction that this patch does not check for that it probably

Re: Organized summary of the pacthes

2005-07-09 Thread Jeff Garzik
On Sat, Jul 09, 2005 at 07:54:06PM -0500, Doug Maxey wrote: However, I am pondering scrapping all the polling code, since on SATA, interrupt-driven mode is much more desirable. You need both interrupt and polled command issue. ACPI needs to be able to issue taskfiles to the IDE drive

[info] Silicon Image device hotplug debounce

2005-07-26 Thread Jeff Garzik
This is some info that Silicon Image provided, for use in developing SATA hotplug. This info is public and not NDA as of the publishing of the SiI 311x hardware documentation at http://gkernel.sourceforge.net/specs/sii/ Kudos again to SiI for opening their 311x and CMD680 [PATA]

Re: [PATCH 3/3 RESEND] Add disk hotswap support to libata

2005-07-26 Thread Jeff Garzik
Lukasz Kosewski wrote: Hey Jeff, everyone. This is a resend of patch 3 of my libata hotswap series, wherein I found a silly flaw in my logic. I don't know what kind of crack I was smoking, but I somehow turned a = a ~b in the Promise driver into a = a ^ b in my hotswap code, which is clearly

Re: [PATCH Linux 2.6.12 07/09] NCQ: stop dma before reset

2005-07-26 Thread Jeff Garzik
Tejun Heo wrote: 07_NCQ_ahci-stop-dma-before-reset.patch AHCI 1.1 mandates stopping dma before issueing COMMRESET. The original code didn't and it resulted in occasional lockup of the controller during EH recovery. This patch fixes the problem. Signed-off-by:

Re: ICH6R support 2.4.20

2005-07-26 Thread Jeff Garzik
Siddharth Taneja wrote: Hi, I am trying to port our software system (uses a 2.4.20 kernel) to a new platform which has a ICH6R controller. Due to some reasons we cannot update our kernel to a more recent one (probably 2.4.27) which has libata support in it. I can successfully patch the

Re: ATA Passthru unimplemented protocols

2005-07-27 Thread Jeff Garzik
Timothy Thelin wrote: I'm interested in soft reset (1) and return response information (15). But I didn't know who was doing what or had plans for what, which is why the question was so general. If I end up working on these two myself, I'd be nice to coordinate with existing efforts rather

Re: ATA Passthru unimplemented protocols

2005-07-27 Thread Jeff Garzik
Timothy Thelin wrote: Are there plans to eventually do them or is anyone actively working on them? Such as? Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 0/3] Add disk hotswap support to libata

2005-07-28 Thread Jeff Garzik
Doug Maxey wrote: On Thu, 21 Jul 2005 21:35:24 EDT, Jeff Garzik wrote: As soon as I finish SATA ATAPI (this week[end]), I'll take a look at this. A quick review of the patches didn't turn up anything terribly objectionable, though :) I would like to offer to test when you are ready

[RFC][PATCH] libata ATAPI alignment

2005-07-28 Thread Jeff Garzik
So, one thing that's terribly ugly about SATA ATAPI is that we need to pad DMA transfers to the next 32-bit boundary, if the length is not evenly divisible by 4. Messing with the scatterlist to accomplish this is terribly ugly no matter how you slice it. One way would be to create my own

[git patch] libata fix

2005-07-31 Thread Jeff Garzik
is not linked into the kernel, SCSI_SATA_AHCI is built modular (unresolved symbols due to missing libata) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED

Re: Plextor 712-sa write issue (repost)

2005-08-01 Thread Jeff Garzik
Polly wrote: Hi, This is my second post on this issue, in the hopes that someone can enlighten me, or point me off to the right resource for this problem. I can mount my Plextor 712 SA DVD burner read-only, but I can't mount it read-write. I have an Intel ICH6 SATA controller: --- Jul 28

Re: [PATCH 2/3] libata ata_data_xfer() fix

2005-08-01 Thread Jeff Garzik
Albert Lee wrote: Jeff, PATCH 2/3: ata_data_xfer() fix Changes: - Add ATA_FLAG_IO_32BIT to libata.h for hosts with 32-bit data register. - Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer length not aligned to 32-bit boundary. This patch does not reuse ap-pad as

Re: [PATCH 3/3] libata handle the case when device returns/needs extra data

2005-08-01 Thread Jeff Garzik
Albert Lee wrote: Jeff, PATCH 3/3: Sometimes the device returns/needs extra data than expected. Changes: - Modify __atapi_pio_bytes() to handle the case when device returns/needs extra data. - for read case, discard trailing data from the device - for write case, padding zero data

Re: Driver for sata adapter promise sata300 tx4

2005-08-01 Thread Jeff Garzik
Jens Axboe wrote: On Mon, Aug 01 2005, Daniel Drake wrote: Otto Meier wrote: My question is also are these features (NCQ/TCQ) and the heigher datarate be supported by this modification? or is only the basic feature set of sata 150 TX4 supported? NCQ support is under development. Search

Re: Driver for sata adapter promise sata300 tx4

2005-08-01 Thread Jeff Garzik
Jens Axboe wrote: Oh, and forget TCQ. It's a completely worthless technology inherited from PATA, Agreed. There are a few controllers where we may -eventually- add TCQ support, controllers that do 100% of TCQ in hardware. But that's so far down the priority list, it's below just about

Re: [RFC][PATCH] libata ATAPI alignment

2005-08-02 Thread Jeff Garzik
Jens Axboe wrote: On Fri, Jul 29 2005, Jeff Garzik wrote: diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c --- a/drivers/scsi/ahci.c +++ b/drivers/scsi/ahci.c @@ -44,7 +44,7 @@ enum { AHCI_PCI_BAR= 5, - AHCI_MAX_SG = 168, /* hardware max is 64K

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-02 Thread Jeff Garzik
Edward Falk wrote: Hi Tejun; I'm the guy at Google working on SATA drivers (port multipliers right now). As soon as I can (next week perhaps, I'll start looking at the driver you wrote. From what I can see, it looks quite good. + +static u8 sil24_check_status(struct ata_port *ap) +{ +

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-08 Thread Jeff Garzik
On Mon, Aug 08, 2005 at 10:31:45AM -0700, Carlos Pardo wrote: One question. Do the open source driver support pass-through commands ? if so, how ? If you do not support it, are you planning to implement pass-through commands sometime in the future ? I don't know about sata_sil24 in

Re: libata and PATA devices

2005-08-09 Thread Jeff Garzik
On Tue, Aug 09, 2005 at 09:48:12AM -0400, Mark Lord wrote: Erik Slagter wrote: Is there a possibility that dell attaches PATA harddisks using a SATA/PATA converter to the SATA connection of the ICH6M? That chipset is used in virtually all modern laptops, and includes a PATA interface as

Re: libata and PATA devices

2005-08-09 Thread Jeff Garzik
On Tue, Aug 09, 2005 at 10:10:17AM -0400, Mark Lord wrote: The PATA ATAPI works now -- perhaps it could be turned on by default while efforts continue to implement support for SATA ATAPI devices. No, PATA ATAPI DMA still needs the same fixes that SATA ATAPI does. ATAPI is incomplete, the

  1   2   3   4   5   6   7   8   9   10   >