Re: [PATCH 4/6] IDE: Coding Style fixes to drivers/ide/pci/it8213.c

2008-02-25 Thread Sergei Shtylyov
Paolo Ciarrocchi wrote: File is now error free, only a few WARNING: line over 80 characters are left. Compile tested. Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Sergei Shtylyov
Ravnborg [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] ide: fix sparse warning about shadowing 'flags' symbol

2008-02-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: drivers/ide/ide.c:801:18: warning: symbol 'flags' shadows an earlier one drivers/ide/ide.c:732:16: originally declared here Also fix some whitespace damage while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov

Re: [PATCH 4/5] ide-generic: use ide_find_port()

2008-02-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-generic.c

Re: [PATCH 4/4] ide-disk: fix issues found by checkpatch.pl

2008-02-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: There are no changes to the resulting drivers/ide/ide-disk.o binary file (md5sum-s after and before the patch match). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from

Re: [PATCH 03/12] ide: add ide-4drives host driver

2008-02-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: CONFIG_BLK_DEV_4DRIVES deserves its own host driver: * Add drivers/ide/legacy/ide-4drives.c and move 4drives support there. * Add ide-4drives.o in the link order after all other legacy host drivers enabled by ide0= options (they all are mutually

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Sergei Shtylyov
Hello. Jan Evert van Grootheest wrote: Prefetch needs to be set for some ide devices to work when connected to Prefetch bit seems to mean 1=disable, 0=enable despite what the datasheet says... a ht6560b interface. This was not always done properly, causing a system with a HD and CD on

Re: [PATCH 1/4] ide: fix sparse warning about shadowing 'flags' symbol

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: drivers/ide/ide.c:801:18: warning: symbol 'flags' shadows an earlier one drivers/ide/ide.c:732:16: originally declared here Also fix some whitespace damage while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov

Re: [PATCH 7/9] ht6560b: use driver name for resource allocation

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/5] ide: remove PIO downgrade quirk

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: No need for it nowadays Since which moment, could you elaborate so remove quirk code from ide_get_best_pio_mode() and IDE_HFLAG_PIO_DOWNGRADE host flag. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this

Re: [PATCH 2/4] ide-disk: add missing printk() KERN_* levels

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 8/9] qd65xx: return error value in qd_probe()

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Return error value in qd_probe() and use it in qd65xx_init() instead of checking ide_hwifs[].chipset. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-14 Thread Sergei Shtylyov
Kroah-Hartman [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-11 Thread Sergei Shtylyov
and testing patches (extra thanks to Sebastian for bisecting it to the guilty commmit). Cc: Sebastian Siewior [EMAIL PROTECTED] Cc: Christoph Hellwig [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Cc: Jens Axboe [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Cc: Sergei Shtylyov [EMAIL

Re: [PATCH 1/3] ide-tape: remove never executed code

2008-02-09 Thread Sergei Shtylyov
. There should be no functional changes caused by this patch. Cc: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: [PATCH] ide: remove -hold field from ide_hwif_t (take 2)

2008-02-09 Thread Sergei Shtylyov
-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] ide: introduce CONFIG_BLK_DEV_IDEDMA_SFF option

2008-02-09 Thread Sergei Shtylyov
Introduce new option CONFIG_BLK_DEV_IDEDMA_SFF for non-PCI SFF-8038i compatible bus mastering IDE controllers (which there are a few known), thus fixing a hack made for Palmchip BK3710 controller... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Bart, did you mean something like

Re: ide/arm/bast-ide.c compile error

2008-02-09 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Remove 'ide_hwif_t **hwif' argument from bastide_register() (together with write-only ifs[]). Cc: Adrian Bunk [EMAIL PROTECTED] Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH 07/18] ide: factor out devices init from ide_init_port_data()

2008-02-09 Thread Sergei Shtylyov
Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/18] ide: factor out code unregistering devices from ide_unregister()

2008-02-09 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Factor out code unregistering devices from ide_unregister() to ide_port_unregister_devices(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH] pata_ninja32: setup changes

2008-02-08 Thread Sergei Shtylyov
Alan Cox wrote: Forcibly set more of the configuration at init time. This seems to fix at least one problem reported. We don't know what most of these bits do, but we do know what windows stuffs there. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from

Re: [PATCH 08/18] ide: move ide_port_setup_devices() call to ide_device_add_all()

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add ide_cfg_mtx lock/unlock to ide_port_setup_devices() and then move ide_port_setup_devices() call from init_irq() to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 02/18] ide: fix ide_find_port()

2008-02-08 Thread Sergei Shtylyov
() which needs such fixup). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Probe port _after_ it is fully initialized. Hm, I thought the usual sequence is vice versa: you first probe and then initialize. :-) Cc: Anton Salnikov [EMAIL PROTECTED] Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [PATCH 3/3] palm_bk3710: factor out cable detection

2008-02-08 Thread Sergei Shtylyov
: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] pdc202xx_old: always enable burst mode

2008-02-08 Thread Sergei Shtylyov
PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] WBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 05/18] ide: factor out cable detection from ide_init_port()

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Factor out cable detection from ide_init_port() to ide_port_cable_detect(). * Move ide_port_cable_detect() call to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-07 Thread Sergei Shtylyov
? Replacing printk() with BUG_ON() and also removing BUG_ON() from ide_execute_command()? OK, will do... Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 3/5] ide: remove ide_setup_ports()

2008-02-07 Thread Sergei Shtylyov
PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] palm_bk3710: factor out cable detection

2008-02-07 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Factor out cable detection to palm_bk3710_cable_detect(). Cc: Anton Salnikov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Index: b/drivers/ide/arm/palm_bk3710.c

[PATCH] ide: insert BUG_ON() into __ide_set_handler() (take 2)

2008-02-07 Thread Sergei Shtylyov
Replace the check for hwgroup-handler and printk(KERN_CRIT, ...) at the start of __ide_set_handler() with mere BUG_ON() while removing such from the caller, ide_execute_command(). Fix up the code formatting, while at it... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Oops, forgot

[PATCH] ide: insert BUG_ON() into __ide_set_handler()

2008-02-07 Thread Sergei Shtylyov
Replace the check for hwgroup-handler and printk(KERN_CRIT, ...) at the start of __ide_set_handler() with mere BUG_ON() while removing such from the caller, ide_execute_command(). Fix up the code formatting, while at it... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] drivers/ide/ide-iops.c

Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-06 Thread Sergei Shtylyov
PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] ide: remove write-only -sata_misc[] from ide_hwif_t

2008-02-03 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Remove write-only -sata_misc[] from ide_hwif_t. * Remove no longer used SATA_{MISC,PHY,IEN}_OFFSET defines. Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: [PATCH] ide-tape: dump gcw fields on error in idetape_identify_device()

2008-02-03 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-tape.c === --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide

Re: [PATCH 5/5] ide: add ide_read_error() inline helper

2008-02-03 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 4/5] ide: add ide_read_[alt]status() inline helpers

2008-02-03 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 5/8] ide: always set DMA masks in ide_pci_setup_ports()

2008-01-29 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Always set DMA masks in ide_pci_setup_ports() to make sure that the valid masks for a host are set. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-29 Thread Sergei Shtylyov
PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: 2.6.24.ide/drivers/ide/arm/palm_bk3710.c === --- /dev/null +++ 2.6.24.ide/drivers/ide/arm/palm_bk3710.c +static void palm_bk3710_setudmamode(u32 base, unsigned int dev

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-01-28 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Remove 'struct pci_dev *dev' argument from ide_hwif_setup_dma(). * Un-static ide_hwif_setup_dma() and add CONFIG_BLK_DEV_IDEDMA_PCI=n version. * Add 'const struct ide_port_info *d' argument to ide_device_add[_all](). * Factor out generic ports

Re: Marvel 88SE6121 driver

2008-01-28 Thread Sergei Shtylyov
Hello. Mike Zheng wrote: From PCI config space, the VENDOR_ID and DEVICE_ID are correct for my driver. However the PCI_COMMAND register of 88SE6121 I got is 0x7, which is the same as default value. Based on the document, it has to be 0x0207 to enable interrupt. However I always failed to do

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-24 Thread Sergei Shtylyov
Anton Salnikov wrote: This is Palmchip BK3710 IDE controller support for kernel version 2.6.24-rc8. The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes. Supports interface to compact Flash (CF) configured in True-IDE mode. Signed-off-by: Anton Salnikov [EMAIL PROTECTED]

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-23 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Why you chose to use ioread32() and iowrite32() if your device is strictly memory mapped? Those functions add some overhead, and boil down to readl() and There are distinct portability advantages but you shouldn't mix ioread32/iowrite32 with ioremap as that isn't

Re: [PATCH 08/16] ide: remove -nice0 and -nice2 fields from ide_drive_t

2008-01-22 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/16] ide: convert -straight8 field in ide_hwif_t to bit flag

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 10/16] ide: use __ide_set_handler() in ide_execute_command()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Use __ide_set_handler() in ide_execute_command(). While at it: * Fix whitespace damage in ide_execute_command(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe

Re: [PATCH 12/16] ide: remove set_transfer()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 06/16] ide: remove unused -auto_poll field from ide_hwif_t

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 04/16] ide-cris: use ide_execute_command()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 02/16] ide-scsi: use ide_execute_command()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 01/16] ide-tape: use ide_execute_command()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 03/16] trm290: use ide_execute_command()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 15/16] ide: remove ide_auto_reduce_xfer()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: While at it: * Remove needless '!drive-crc_count' check. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: [PATCH 14/16] ide: move drive-crc_count check out from check_dma_crc()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-22 Thread Sergei Shtylyov
Hello. Anton Salnikov wrote: This is Palmchip BK3710 IDE controller support for kernel version 2.6.24-rc8. The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes. Supports interface to compact Flash (CF) configured in True-IDE mode. Use ide_setup_dma() since

Re: [PATCH] pdc2026x: remove surplus initialiser

2008-01-19 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc8-mm1/drivers/ide/pci/pdc202xx_old.c linux-2.6.24-rc8-mm1/drivers/ide/pci/pdc202xx_old.c ---

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-18 Thread Sergei Shtylyov
Alan Cox wrote: It won't -- we can *not* call ide_setup_dma() which fills them out as this is not a PCI chip. Gak. Or maybe we still can -- with hwif-mmio set? AFAIR (from the 2006 discussion) Bart said it's *only* for PCI devices... Alan MBR, Sergei - To unsubscribe from this

Re: [PATCH] Palmchip BK3710 IDE driver

2008-01-18 Thread Sergei Shtylyov
Hello. Alan Cox wrote: This is Palmchip BK3710 IDE controller support for kernel version 2.6.24-rc8. The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes. Supports interface to compact Flash (CF) configured in True-IDE mode. New drivers should really be going at least

Re: [CALL-FOR-HELP] pata_ali: can't get MWDMA working!

2008-01-09 Thread Sergei Shtylyov
Tejun Heo wrote: Hello, all. Broken MWDMA on pata_ali has caused a number of bug reports. I've been trying to fix it for some time now finally got a machine with pata_ali and non-working MWDMA2 ATAPI device on my desk a few weeks ago. Testing confirms what users have been reporting - MWDMA2

Re: [PATCH 2/15] ide: move wait_hwif_ready() documentation in the right place

2008-01-09 Thread Sergei Shtylyov
HNY. :-) Bartlomiej Zolnierkiewicz wrote: * Move wait_hwif_ready() documentation before this function. * Fix trailing whitespaces. * s/wait-for-busy/wait-for-non-busy/ * Remove no longer valid comment about the current code behavior. * Docbook-ize it. * Rename wait_hwif_ready()

Re: [PATCH 2/15] ide: move wait_hwif_ready() documentation in the right place

2008-01-09 Thread Sergei Shtylyov
(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Oops, forgot to stamp: Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 2/3] ide-pmac: macio resource freeing bugfix

2008-01-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Release DMA resource before zeroing pmif. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH 5/13] cy82c693: add -set_dma_mode method

2008-01-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Fix SWDMA/MWDMA masks in cy82c693_chipset. * Add IDE_HFLAG_CY82C693 host flag and use it in ide_tune_dma() to check whether the DMA should be enabled even if ide_max_dma_mode() fails. I didn't get why this was necessary... * Convert

Re: [PATCH 21/21] ide: make remaining built-in only IDE host drivers modular

2008-01-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Make remaining built-in only IDE host drivers modular, add ide-scan-pci.c file for probing PCI host drivers registered with IDE core (special case for built-in IDE and CONFIG_IDEPCI_PCIBUS_ORDER=y) and then take care of the ordering in which all IDE host

[PATCH 1/2] trm290: cannot call ide_setup_dma()

2007-12-30 Thread Sergei Shtylyov
The TRM-290 chip is *not* SFF-8038i compatible and therefore can *not* call ide_setup_dma() -- fix this and also cleanup the code a bit... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] drivers/ide/ide-dma.c| 13 - drivers/ide/pci/trm290.c | 62

[PATCH 2/2] ide_setup_dma() assumes 8 ports

2007-12-30 Thread Sergei Shtylyov
According to http://marc.info/?l=linux-idem=114346138611631, the drivers must always register 8 DMA ports with ide_setup_dma(), so its last argument is not needed. While at it, kill some useless parens in that function... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Both patches

Re: [PATCH 4/9] ide: use ide_destroy_dmatable() instead of pci_unmap_sg()

2007-12-29 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/9] icside: use hwif-dev

2007-12-29 Thread Sergei Shtylyov
PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 7/9] icside: use hwif-dev

2007-12-29 Thread Sergei Shtylyov
Sergei Shtylyov wrote: * Setup hwif-dev in icside_setup(). * Use hwif-dev instead of state-dev in icside_build_sglist(), icside_dma_end(), icside_dma_start() and icside_dma_setup(). * Remove no longer needed 'dev' field from struct icside_state. Cc: Russell King [EMAIL PROTECTED

Re: [PATCH 3/3] ide: add IDE_HFLAG_NO_DSC host flag

2007-12-29 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -1098,6 +1098,8 @@ enum { IDE_HFLAG_CY82C693 = (1 27

Re: [PATCH 2/9] ide: fix ide_intr() for non-PCI devices and CONFIG_BLK_DEV_IDEPCI=y

2007-12-28 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: 'hwif-pci_dev !hwif-pci_dev-vendor' condition is never true, check for 'hwif-chipset != ide_pci' instead. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list

Re: [PATCH 7/9] icside: use hwif-dev

2007-12-28 Thread Sergei Shtylyov
PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei PS: Russel, that was only an eyes check, the last word is yours. :-) - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: [PATCH] trm290: do hook dma_host_{on,off} methods (take 2)

2007-12-28 Thread Sergei Shtylyov
... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied The next patch is cooking... :-) WBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] trm290: do hook dma_host_{on,off} methods (take 2)

2007-12-27 Thread Sergei Shtylyov
methods in init_hwif_trm290()... --- Fixed the header, added 'static' to the new method definitions. The patch is against Linus' kernel tree... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] drivers/ide/pci/trm290.c | 29 - 1 files changed, 20 insertions(+), 9 deletions

[PATCH] trm290: do hook dma_host_{on,off} methods

2007-12-26 Thread Sergei Shtylyov
in init_hwif_trm290()... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] drivers/ide/pci/trm290.c | 26 ++ 1 files changed, 18 insertions(+), 8 deletions(-) Index: linux-2.6/drivers/ide/pci/trm290.c

Re: [PATCH] trm290: do hook dma_host_{on,off} methods

2007-12-26 Thread Sergei Shtylyov
Hello, I wrote: Those two methods were reading/writing TRM-290 config. register; luckily (?) the writes only tried to change undefined bits. Actually, the writes were falling at the PRD address register. Well, nobody noticed anyway... :-) MBR, Sergei - To unsubscribe from this list:

Re: [PATCH 1/2] ide: add ide_dump_identify() debug helper

2007-12-25 Thread Sergei Shtylyov
is enabled. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 02/63] ide-cd: fix ACER/AOpen 24X CDROM speed reporting on big-endian machines

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Fix ACER/AOpen 24X CDROM speed reporting on big-endian machines by adding missing le16_to_cpu() calls. While at it: * Replace ntohs() by be16_to_cpu(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH 01/63] ide-cd: fix SAMSUNG CD-ROM SCR-3231 quirk

2007-12-21 Thread Sergei Shtylyov
Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/63] ide-cd: fix error messages in cdrom_{read,write}_check_ireason()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 05/63] ide-cd: add missing 'ireason' masking to cdrom_write_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Mask 'ireason' variable with 0x3 so the valid interrupt reason value is passed to cdrom_write_check_ireason() for checking. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe

Re: [PATCH 08/63] ide-cd: fix error message in cdrom_pc_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 09/63] ide-cd: fix 'ireason' reporting in cdrom_pc_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Mask 'ireason' variable so only the valid interrupt reason bits will be reported on drive appears confused error. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from

Re: [PATCH 13/63] ide-cd: fix DMA error handling in cdrom_newpc_intr()

2007-12-21 Thread Sergei Shtylyov
] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 16/63] ide-cd: remove stale cdrom_transfer_packet_command() comment

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 63/63] ide-cd: update driver version, comments and copyrights

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Bump driver version. * Remove filename and stale TODO from comments. * Add my copyrights. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send

Re: [PATCH 21/63] ide-cd: remove unused and write-only struct ide_cd_config_flags fields

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: unused fields: * -writing * -reserved write-only fields: * -playmsf_as_bcd * -subchan_as_bcd * -test_write * -supp_disc_present Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 06/63] ide-cd: fix error messages in cdrom_write_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 07/63] ide-cd: add error message for DMA error to cdrom_read_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 59/63] ide-cd: call blk_dump_rq_flags() on missing data in cdrom_rw_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 30/63] ide-cd: remove NO_DOOR_LOCKING define

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 34/63] ide-cd: remove duplicate sense keys definitions from ide-cd.h

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: ide-cd.c already uses sense keys definitions from scsi/scsi.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 23/63] ide-cd: cleanup ide_cdrom_update_speed()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 12/63] ide-cd: fix missing data handling in cdrom_pc_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: If drive still wants to transfer the data we need to pad the transfer instead of just finishing the request. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list

Re: [PATCH 18/63] ide-cd: remove dead code from cdrom_pc_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 42/63] ide-cd: coding style fixes for cdrom_get_toc_entry()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: This is a preparation to move code handling cdrom.c IOCTLs out of ide-cd.c. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 17/63] ide-cd: remove unused defines from ide-cd.h

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 20/63] ide-cd: remove needless zeroing of 'info' fields from ide_cdrom_setup()

2007-12-21 Thread Sergei Shtylyov
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 22/63] ide-cd: remove struct atapi_{mechstat_header,changer_info,slot}

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Remove -changer_info from struct cdrom_info (it is never allocated). * Remove unused struct atapi_{mechstat_header,changer_info,slot}. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 19/63] ide-cd: remove unused struct atapi_cdrom_subchnl

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

  1   2   3   4   5   6   7   8   >