Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread Alexander
Robert Hancock wrote: > There's this patch which was intended to fix it: > > http://lkml.org/lkml/2007/11/22/148 I applied this patch to 2.6.24-rc7. Now at boot time my DVD-RW is normaly detected as: sr0: scsi3-mmc drive: 48x/48x writer dvd-ram cd/rw xa/form2 cdda tray But I cannot mount it. Al

Updated shutdown in Debian Lenny/Sid

2008-01-12 Thread Stephan Windmüller
Hello! The issue mentioned on [0] happened on my system a few weeks ago. But now it seems that Debian Testing (Lenny) and Unstable (Sid) corrected this problem with sysvinit (2.86.ds1-47)[1]. Perhaps you can add the distro to your list of fixed distros with updated shutdown. Regards Stephan Win

Re: 40-wire cable detected when directly connected

2008-01-12 Thread Tobias Müller
Hi Please apply the attached patch and specify libata.force_cbl=80 as kernel boot parameter. If you load libata from initrd or after boot you need to pass 'force_cbl=80' as module parameter. How you do it depends on your distro. [ 41.116289] ata7: forcing 80c [ 41.116356] ata7.00: ATA-4:

Re: [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > The driver used to test whether the flexible disk page has changed by > memcmp-ing > it with a cached copy of a previous version of the page from a different remo- > vable medium. Since, according to the SFF-8070i spec, the flexible disk page >

Re: [PATCH 07/21] ide-floppy: remove struct idefloppy_capacity_descriptor

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > We test here for updated capacity descriptors by checking whether the media > has changed instead of memcmp-ing with a cached copy of the capacity > descriptors. > > Also: > > - remove one of 2 consecutive if (!i)-tests. > - start loop at 1 in i

Re: [PATCH 00/21] ide-floppy redux v2

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > > Hi Bart, > >here's the second version of the ide-floppy refactoring trail. All the > patches are based on the version of your quilt tree from the 05.01. Also, > you've > already applied patch 5 in this series but i'm submitting it still f

Re: 40-wire cable detected when directly connected

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Tobias Müller wrote: > Tejun Heo schrieb: > > I don't know very well about CF but does it even fill UDMA/33? What > > does 'dd if=/dev/sdc of=/dev/null bs=1M count=16 iflag=direct' say? You > > can increase count for more reliable result. > > 16+0 Datensätze ein > 16+0

Re: [PATCH 04/21] ide-floppy: cleanup and unify debugging macro calls

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > * some debug_log() calls were not using "ide-floppy: " prefix > > * a few used printk levels different than KERN_INFO (KERN_NOTICE > and KERN_ERR, which is the default one if no level is given) > > There should be no functional change resultin

Re: 40-wire cable detected when directly connected

2008-01-12 Thread Tobias Müller
Bartlomiej Zolnierkiewicz schrieb: Please send 'hdparm --Istdout /dev/hdc' output. /dev/sdc: 044a 3e08 0010 0240 003f 00f4 3f80 2020 2020 3031 3036 3131 4532 3239 3753 3035 3130 0002 0002 0004 4844 5820 342e 3230 5361 6e44 6973 6b20 5344 4346 5834 2d38 3139 3220 2020 2020 2020 20

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Thursday 10 January 2008, Tejun Heo wrote: > Marc Howard Zuckman wrote: > > With apologies if this was supposed to be an attachment: > > Inline is fine. > > > IT8212: IDE controller at PCI slot :03:0c.0 > > IT8212: chipset revision 17 > > it821x: controller in smart mode. > > IT8212: 100%

Re: 40-wire cable detected when directly connected

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Saturday 12 January 2008, Tobias Müller wrote: > Bartlomiej Zolnierkiewicz schrieb: > > Please send 'hdparm --Istdout /dev/hdc' output. > > /dev/sdc: [...] Thanks, device has no cable detection (no surprise here, it is a CF card) so over-riding only host side cable detection won't work. As a

Re: 40-wire cable detected when directly connected

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Saturday 12 January 2008, Bartlomiej Zolnierkiewicz wrote: [...] > I've re-read the whole thread and it seems that the possible solution for > Addonics card would be to detect it by PCI Subsystem Vendor/Device IDs. It seems I wasn't paying enough attention, Tejun already thought of this but u

Re: 40-wire cable detected when directly connected

2008-01-12 Thread Tobias Müller
Hi Bartlomiej Zolnierkiewicz schrieb: As a workaround you can try using IDE subsystem siimage driver and pass "idex=ata66" option or modify Tejun's patch to also override device side cable detection by replacing ATA_CBL_PATA80 with ATA_CBL_PATA40_SHORT. I'll try this. Could you send the outpu

Re: 40-wire cable detected when directly connected

2008-01-12 Thread Tobias Müller
Hi Bartlomiej Zolnierkiewicz schrieb: As a workaround you can try using IDE subsystem siimage driver and pass "idex=ata66" option or modify Tejun's patch to also override device side cable detection by replacing ATA_CBL_PATA80 with ATA_CBL_PATA40_SHORT. I changed some code in libata=core.c in at

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread Robert Hancock
Alexander wrote: Robert Hancock wrote: There's this patch which was intended to fix it: http://lkml.org/lkml/2007/11/22/148 I applied this patch to 2.6.24-rc7. Now at boot time my DVD-RW is normaly detected as: sr0: scsi3-mmc drive: 48x/48x writer dvd-ram cd/rw xa/form2 cdda tray But I cann

SATA port multiplier(Sil 3132) and JMicron 361-363

2008-01-12 Thread mikp
My SII 3132 port multiplier works with the JMB363 controller on my motherboard using kernel-2.6.24-rc3 but not with the JMB361 esata controller which i have on a second motherboard. I get messages: ata5.15: failed to read PMP GSCR[1] (Emask=0x4) ahci :00:12.0: controller can't do PMP,

Re: [PATCH 8/8] ide: add ->cable_detect method to ide_hwif_t

2008-01-12 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Add ->cable_detect method to ide_hwif_t. * Call the new method in ide_init_port() if: - the host supports UDMA modes > UDMA2 ('hwif->ultra_mask & 78') - DMA initialization was successful (if hwif->dma_base is not set ide_init_port() sets hwif

Re: [PATCH 00/21] ide-floppy redux v2

2008-01-12 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 12 January 2008, Bartlomiej Zolnierkiewicz wrote: > On Friday 11 January 2008, Borislav Petkov wrote: > > > > Hi Bart, > > > >here's the second version of the ide-floppy refactoring trail. All the > > patches are based on the version of your quilt tree from the 05.01. Also,

Re: [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Saturday 12 January 2008, Bartlomiej Zolnierkiewicz wrote: [...] > > - header = (idefloppy_mode_parameter_header_t *) pc.buffer; > > - floppy->wp = header->wp; > > + floppy->wp = pc.buffer[3] & 0x80; > > This is not an equivalent transformation: > > header->wp is 0 or 1 > pc.buffer[3]

Re: [PATCH 11/21] ide-floppy: fix comments formatting

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > That is, > - remove unnecessary comments > - shorten comments > - shorten lines longer 80 columns > - cleanup whitespace > - add a missing loglevel KERN_ to a printk-call > - fix misc checkpatch warnings Majority of this patch consists of checkpa

Re: [PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl()

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > By passing idefloppy_floppy_t *floppy to the factored out functions, we get > rid of (almost) all local vars so stack usage should be at minimum here. Also, > we merge idefloppy_begin_format() into idefloppy_format_start() since it is > its > onl

Re: [PATCH 20/21] ide-floppy: merge idefloppy_{input,output}_buffers

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by > introducing a 4th arg. called direction. According to its value > we atapi_input_bytes() or atapi_output_bytes(). Also, simplify the interrupt This change is fine but ..

Re: [PATCH 21/21] ide-floppy: remove atomic test_*bit macros

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > This change is temporary and after unification of the IDE subsystem proper > bit setting and testing macros will be introduced. > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> > --- > drivers/ide/ide-floppy.c | 82 > +++

Re: [PATCH 14/21] ide-floppy: mv idefloppy_{should_,}report_error

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > In addition to shortening the function name, move the printk-call into the > function thereby saving some code lines. Also, make the function out_of_line > since it is not on a performance critical path. > > Signed-off-by: Borislav Petkov <[EMAIL

Re: [PATCH 19/21] ide-floppy: fix most of the remaining checkpatch.pl issues

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > i.e., > ERROR: switch and case should be at the same indent > ERROR: need spaces around that '=' (ctx:VxV) > ERROR: trailing statements should be on next line > WARNING: no space between function name and open parenthesis '(' > WARNING: printk() s

Re: [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe()

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> > --- > drivers/ide/ide-floppy.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c > index 89b26ea..0729df5 1006

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 13:25 -0600, Robert Hancock wrote: > Alexander wrote: > > Robert Hancock wrote: > >> There's this patch which was intended to fix it: > >> > >> http://lkml.org/lkml/2007/11/22/148 > > > > I applied this patch to 2.6.24-rc7. Now at boot time my DVD-RW is > > normaly detected

Re: [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page

2008-01-12 Thread Borislav Petkov
[...] > This is not an equivalent transformation: > > header->wp is 0 or 1 > pc.buffer[3] & 0x80 is 0 or 0x80 > > It seems to work fine for ->wp (because it is needlessly defined as 'int') > but may seriously confuse set_disk_ro() and thus bdev_read_only() users. > > Should be fixed to '(pc.bu

Re: [PATCH 00/21] ide-floppy redux v2

2008-01-12 Thread Borislav Petkov
On Sat, Jan 12, 2008 at 09:14:39PM +0100, Bartlomiej Zolnierkiewicz wrote: [...] > PS1 Please rebase the patches still needing polishing on top of updated > IDE quilt tree, recast them and respin the patch series (no need to post > already merged patches). sure, will do. > PS2 what happend to "f

Re: [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe()

2008-01-12 Thread Borislav Petkov
On Sat, Jan 12, 2008 at 09:18:01PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Friday 11 January 2008, Borislav Petkov wrote: > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> > > --- > > drivers/ide/ide-floppy.c |3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff

Re: [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Saturday 12 January 2008, Borislav Petkov wrote: [...] > > > set_disk_ro(floppy->disk, floppy->wp); > > > - page = (idefloppy_flexible_disk_page_t *) (header + 1); > > > - > > > - page->transfer_rate = be16_to_cpu(page->transfer_rate); > > > - page->sector_size = be16_to_cpu(page->sector_siz

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread Robert Hancock
James Bottomley wrote: With mem<=4098M or sata_nv.adma=0 it still mounts and works ok. As I wrote, it would appear that somehow the blk_queue_bounce_limit setting that the driver has made is not being respected and the block layer is still trying to feed it addresses over 4GB. Any ideas anyone?

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 17:04 -0600, Robert Hancock wrote: > I don't think the problem is that there's some buffer which is getting > allocated above 4GB and never bounced, since the problem goes away if > ADMA is disabled entirely and the DMA mask remains 32-bit always. My > guess is something is

SATA timeouts on two disks

2008-01-12 Thread Jim MacBaine
Hi, Recently I'm experiencing strange sata errors on my desktop system. The system was recently equipped with three 250 GB SATA drives from three different manufacturers and I'm having an identical problem on two of them. The drives are connected to two on-board controllers on an Asus A8V board,

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread Robert Hancock
James Bottomley wrote: On Sat, 2008-01-12 at 17:04 -0600, Robert Hancock wrote: I don't think the problem is that there's some buffer which is getting allocated above 4GB and never bounced, since the problem goes away if ADMA is disabled entirely and the DMA mask remains 32-bit always. My gues

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 19:38 -0600, Robert Hancock wrote: > James Bottomley wrote: > > On Sat, 2008-01-12 at 17:04 -0600, Robert Hancock wrote: > >> I don't think the problem is that there's some buffer which is getting > >> allocated above 4GB and never bounced, since the problem goes away if > >

SATA timeouts on CD DVD RW

2008-01-12 Thread Paul Surgeon
I keep getting the following error messages during bootup with kernel 2.6.23.12 : scsi 4:0:0:0: CD-ROMTSSTcorp CDDVDW TS-L633A UO00 PQ: 0 ANSI: 5 ata3.00: qc timeout (cmd 0xa0) ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata3.00: (irq_stat 0x4001) ata3.00: cmd

[PATCH #upstream-fixes] sata_sil24: fix stupid typo

2008-01-12 Thread Tejun Heo
Fix stupid typo. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/sata_sil24.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c index b4c674d..d9c8b32 100644 --- a/drivers/ata/sata_sil24.c +++ b/drivers/ata/sata

[PATCH #upstream-fixes] sata_sil24: freeze on non-dev errors reported via CERR

2008-01-12 Thread Tejun Heo
CERR reports errors detected during executing a command. This doesn't mean the error is tied to the command and can be recovered by just issuing it again. Many of the errors are fatal port-wide connditions including HSM violation, host bus error and ATA bus error and require freezing and port res

Re: Sata 4726 Testing

2008-01-12 Thread Tejun Heo
Andrew Ryder wrote: > Tejun, > > No problem. I should be thanking you and your team for all the hard work > writing the drivers for the hardware.. > > I think this patch might have solved the issue. I did a quick test: warm > rebooted and turned the 4726 on and off 3 times and all disks were > su

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-12 Thread Marc Howard Zuckman
On Fri, 11 Jan 2008, Tejun Heo, replying to Marc Zuckman wrote: Zuckman: Is it possible that both drivers are present in the kernel and conflict with one another in some fashion? Heo: The don't conflict. If both are in the kernel, IDE drivers have priority. Can you plea

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-12 Thread Tejun Heo
Marc Howard Zuckman wrote: > On Fri, 11 Jan 2008, Tejun Heo, replying to Marc Zuckman wrote: > >>> Zuckman: > >>> Is it possible that both drivers are present in the kernel and conflict >>> with one another in some fashion? >> Heo: > >> The don't conflict. If both are in the kernel, ID

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-12 Thread Marc Howard Zuckman
On Sat, 12 Jan 2008, Bartlomiej Zolnierkiewicz wrote: In "smart mode" controller takes care of mode programming. Cc'ing Alan and Bartlomiej. Guys, is this the smart mode problem? Do ide and libata have this fixed in 2.6.24-rc? [ added Alan and myself ;) to cc: ] Marc, please also send ou

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-12 Thread Marc Howard Zuckman
On Sun, 13 Jan 2008, Tejun Heo wrote: Does this change anything? And, yeah, I really wanna see the hdparm --Istdout too. I will apply the patch and test it as you have requested. To be clear, the output of the hpdarm -Istdout /dev/hde command that I reported a few minutes ago was performed

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-12 Thread Tejun Heo
Marc Howard Zuckman wrote: > On Sat, 12 Jan 2008, Bartlomiej Zolnierkiewicz wrote: > >> >> In "smart mode" controller takes care of mode programming. >> >>> Cc'ing Alan and Bartlomiej. Guys, is this the smart mode problem? Do >>> ide and libata have this fixed in 2.6.24-rc? >> >> [ added Alan an

Re: 40-wire cable detected when directly connected

2008-01-12 Thread Tejun Heo
Tobias Müller wrote: > Hi > >> Please apply the attached patch and specify libata.force_cbl=80 as >> kernel boot parameter. If you load libata from initrd or after boot you >> need to pass 'force_cbl=80' as module parameter. How you do it depends >> on your distro. Ah.. right. I'm brewing more

Re: Problem setting dma using pata_it821x driver in vanilla 2.6.23.12 and gentoo-sources 2.6.23-r3

2008-01-12 Thread Marc Howard Zuckman
On Sun, 13 Jan 2008, Tejun Heo wrote: Does this change anything? And, yeah, I really wanna see the hdparm --Istdout too. I applied the patch to libata-core.c. A scsi device, /dev/sdb, was recognized, but partition /dev/sdb1 (where all the data resides) is not seen. Boot log messages and hd