Hi Bart,
here's the ide_atapi_pc unification series. It all went pretty smoothly along
the search replace line. Using driver-specific members in ide_atapi_pc like
idefloppy_callback and idetape_callback is kinda dumb but this approach seemed
the fastest versus unnecessary callback function
On Mon 11. Feb - 11:37:15, Tejun Heo wrote:
Hello,
Holger Macht wrote:
Calling ap-ops-set_piomode(ap, dev) on a device/controller which got
already removed, locks the system hard. Reproducibly on an X60 attached to
a dock station containing a cdrom device with doing
$ echo 1
Tejun Heo wrote:
When no reset method is available, libata currently oopses. Although
the condition can't happen unless there's a bug in a low level driver,
oopsing isn't the best way to report the error condition. Complain,
dump stack and fail reset instead.
Signed-off-by: Tejun Heo [EMAIL
While updating Fedora to 2.6.25-rc1, I noticed this little gem...
This swim3 and mediabay dependancy is pretty grody. Commit
34394e45c3387bd66619d9a51b4be507e4222b02 moved the ifdef around, which
meant the EXPORT_SYMBOL wasn't happening, which was bad, since if swim3
is built modularly, and
Tejun Heo [EMAIL PROTECTED] wrote:
Hello,
Elias Oltmanns wrote:
Hmmm... The reason why max_host_blocked and max_device_blocked are set
to 1 is to let libata re-consider status after each command completion
as blocked status can be rather complex w/ PMP. I haven't really
followed the code
commit 29dd59755a849cc6475faa6a75f3b804e23a6fc2 (ide: remove ide_setup_ports)
forgot to take into account the base addresses for the CONTROL registers for
falconide and macide, as pointed out by Michael Schmitz.
Falconide was tested on Aranym.
Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED]
Please pull from 'upstream-fixes' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-fixes
to receive the following updates:
drivers/ata/libata-core.c | 48 +-
drivers/ata/pata_amd.c |2 +-
Byron Bradley wrote:
When the sata_mv driver is used as a platform driver,
mv_create_dma_pools() is never called so it fails when trying
to alloc in mv_pool_start().
Signed-off-by: Byron Bradley [EMAIL PROTECTED]
Acked-by: Mark Lord [EMAIL PROTECTED]
---
Mark, based on the comment from Andrew
Tejun Heo wrote:
Some controllers (VIA CX700) raise device error on SETXFER even after
mode configuration succeeded. Update ata_dev_set_mode() such that
device error is ignored if transfer mode is configured correctly. To
implement this, device is revalidated even after device error on
Tejun Heo wrote:
PCI device should be powered up or powered up before its PCI regsiters
are accessed. Although PCI configuration register access is allowed
in D3hot, PCI device is free to reset its status when transiting from
D3hot to D0 causing configuration data to change.
Many libata SFF
On Monday 11 February 2008, Andi Kleen wrote:
Without this patch a Opteron test system here oopses at boot with currentg
git.
Calling to_pci_dev() on a NULL pointer gives a negative value so the
following NULL
pointer check never triggers and then an illegal address is referenced.
On Sat, Feb 02, 2008 at 12:35:30AM +0100, Bartlomiej Zolnierkiewicz wrote:
Index: b/drivers/ide/arm/icside.c
===
--- a/drivers/ide/arm/icside.c
+++ b/drivers/ide/arm/icside.c
@@ -459,11 +456,19 @@
On Mon, Feb 11, 2008 at 09:33:14AM -0800, Linus Torvalds wrote:
On Mon, 11 Feb 2008, Andi Kleen wrote:
Without this patch a Opteron test system here oopses at boot with currentg
git.
Calling to_pci_dev() on a NULL pointer gives a negative value so the
following NULL
On Mon, 11 Feb 2008, Linus Torvalds wrote:
So we should probably make pcibus_to_node() be an inline function for that
case
Or, we could just do the ugliest patch ever, namely
-#define pcibus_to_node(node) (-1)
+#define pcibus_to_node(node) ((int)(long)(node),-1)
Wow.
On Mon, 11 Feb 2008, Andi Kleen wrote:
Without this patch a Opteron test system here oopses at boot with currentg
git.
Calling to_pci_dev() on a NULL pointer gives a negative value so the
following NULL
pointer check never triggers and then an illegal address is referenced. Check
On Mon, 2008-02-11 at 10:23 -0600, James Bottomley wrote:
On Sun, 2008-02-10 at 23:25 -0800, Yinghai Lu wrote:
please check it...
This one looks perfect, thanks!
Well, nearly perfect. I corrected this typo:
+ if (!buf)
+ goto simple_polulate;
Bartlomiej Zolnierkiewicz wrote:
From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Subject: [PATCH] ide-disk: fix flush requests (take 2)
commit 813a0eb233ee67d7166241a8b389b6a76f2247f9
Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Date: Fri Jan 25 22:17:10 2008 +0100
ide:
On Sun, 2008-02-10 at 23:25 -0800, Yinghai Lu wrote:
please check it...
This one looks perfect, thanks!
James
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon 11. Feb - 22:11:32, Tejun Heo wrote:
Holger Macht wrote:
It should be called via ata_acpi_{ap|dev}_notify() callbacks installed
via acpi_install_notify_handler(). Can you add dump_stack() in the
function and verify that it actually is being called? It could be that
the method is
On Tue, Feb 12, 2008 at 01:09:24AM +0100, Bartlomiej Zolnierkiewicz wrote:
On Monday 11 February 2008, Borislav Petkov wrote:
Hi Bart,
here's the ide_atapi_pc unification series. It all went pretty smoothly
along
the search replace line. Using driver-specific members in
Hi,
On Monday 11 February 2008, Daniel Exner wrote:
Hi!
Please CC me as I'm not subscribed to any list, thx in advance.
I tried all -git Kernels since begining of cycle and starting when they
finaly
compiled fine, they weren't able to mount my root.
As my laptop with the serial
Yinghai Lu wrote:
[PATCH] sata_mv: fix loop with last port
commit f351b2d638c3cb0b95adde3549b7bfaf3f991dfa
sata_mv: Support SoC controllers
cause panic:
[...]
last_port already include port0 base.
this patch change use last_port directly, and move pp assignment later.
Signed-off-by:
On Monday 11 February 2008, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Subject: [PATCH] ide-disk: fix flush requests (take 2)
commit 813a0eb233ee67d7166241a8b389b6a76f2247f9
Author: Bartlomiej Zolnierkiewicz [EMAIL
Andrew Paprocki wrote:
I haven't used the system with these errors in a day or two and I came
back and noticed 5 exceptions in dmesg. These are all the same:
ata1: exception Emask 0x10 SAct 0x0 SErr 0x90200 action 0xe frozen
ata1: irq_stat 0x0040, PHY RDY changed
ata1: SError: { Persist
Saeed Bishara wrote:
host-private_data = hpriv;
hpriv-n_ports = n_ports;
-host-iomap = NULL;
hpriv-base = ioremap(res-start, res-end - res-start + 1);
+host-iomap = hpriv-base;
hpriv-base -= MV_SATAHC0_REG_BASE;
rc = mv_create_dma_pools(hpriv, pdev-dev);
Elias Oltmanns wrote:
+static int piix_qc_defer(struct ata_queued_cmd *qc)
+{
+ static struct ata_port *ap = NULL;
+ struct ata_queued_cmd qcmd[ATA_MAX_QUEUE];
missing static?
+ static int count = 0;
+#define PIIX_QC_DEFER_THRESHOLD 5000
+
+ if (!ap)
+ ap =
On Sat, 2008-02-09 at 10:40 +0900, Tejun Heo wrote:
Clear drain buffer before chaining if the command in question is a
write.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
block/blk-merge.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/block/blk-merge.c
On Monday 11 February 2008, Geert Uytterhoeven wrote:
commit 29dd59755a849cc6475faa6a75f3b804e23a6fc2 (ide: remove
ide_setup_ports)
forgot to take into account the base addresses for the CONTROL registers for
falconide and macide, as pointed out by Michael Schmitz.
Falconide was tested on
On Saturday 09 February 2008, Borislav Petkov wrote:
From 92dd5c1cfb27c0945894a3a055098290047d1ff0 Mon Sep 17 00:00:00 2001
From: Borislav Petkov [EMAIL PROTECTED]
Date: Sat, 9 Feb 2008 20:33:48 +0100
Subject: [PATCH 2/2] ide-tape: remove atomic test/set macros for packet
commands
On Wed, Feb 06, 2008 at 12:46:59PM +, Russell King - ARM Linux wrote:
On Wed, Feb 06, 2008 at 06:58:17AM -0500, Jeff Garzik wrote:
ACK patch series... would it be ok to send via the ARM maintainer?
I would prefer to add this at the same time as its user...
I've only seen the one
On Sat, Feb 02, 2008 at 04:21:33PM +, Ben Dooks wrote:
Repost of previous patch-set with email address in part 3
corrected.
Did this get dropped in the noise, or where people awaiting
changes to the ppc for this to be applied? It would be great
if this could get applied in the next window.
Holger Macht wrote:
On a related note, shouldn't ata_acpi_handle_hotplug delete the device
like what is done when doing
echo 1 /sys/devices/.../block/sr0/device/delete
Yeap, when the ata_acpi_handle_hotplug() was added, the focus was
supporting hotplug when the controller itself doesn't
In the above example, even the reset sequence itself can cause hang if
the hardware is implemented slightly differently. The reason why
set_piomode() locks up but reset sequence doesn't is simple dumb luck.
I think the proper fix is to tell libata to detach the cdrom before
undocking.
Just
On Mon, Feb 11, 2008 at 11:29:07AM +0100, Holger Macht wrote:
In the above example, even the reset sequence itself can cause hang if
the hardware is implemented slightly differently. The reason why
set_piomode() locks up but reset sequence doesn't is simple dumb luck.
Another thing,
On Mon 11. Feb - 20:16:38, Tejun Heo wrote:
Hello,
Holger Macht wrote:
In the above example, even the reset sequence itself can cause hang if
the hardware is implemented slightly differently. The reason why
set_piomode() locks up but reset sequence doesn't is simple dumb luck.
I think
Mark Lord wrote:
Byron Bradley wrote:
I'm having problems getting the sata_mv driver working as a platform
driver on the QNAP TS-209 and the Linkstation/Kurobox (both are Marvell
Orion 88f5182 based devices). First of all it would oops in
mv_port_start() while calling dma_pool_alloc(), the
Hello,
Holger Macht wrote:
In the above example, even the reset sequence itself can cause hang if
the hardware is implemented slightly differently. The reason why
set_piomode() locks up but reset sequence doesn't is simple dumb luck.
I think the proper fix is to tell libata to detach the
Hello,
Holger Macht wrote:
In the above example, even the reset sequence itself can cause hang if
the hardware is implemented slightly differently. The reason why
set_piomode() locks up but reset sequence doesn't is simple dumb luck.
Another thing, whether it's poor luck or not, it worked
Hello,
Elias Oltmanns wrote:
Hmmm... The reason why max_host_blocked and max_device_blocked are set
to 1 is to let libata re-consider status after each command completion
as blocked status can be rather complex w/ PMP. I haven't really
followed the code yet but you're saying that blocked
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 251 ++--
1 files changed, 114 insertions(+), 137 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 09ff9b0..aefbb47 100644
---
This new struct unifies ide{-floppy,-tape,-scsi}'s view of a packet command.
For now,
it represents the common denominator between the three drivers while adding
driver-
specific members at the end of the struct which will be merged/simplified into
the
generic ATAPI handling code in later
Tejun Heo wrote:
The first port of cx700 is SATA. Fix cable detection.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/pata_via.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the
On Monday 11 February 2008, Borislav Petkov wrote:
Hi Bart,
here's the ide_atapi_pc unification series. It all went pretty smoothly along
the search replace line. Using driver-specific members in ide_atapi_pc like
idefloppy_callback and idetape_callback is kinda dumb but this approach
On Saturday 09 February 2008, Borislav Petkov wrote:
Hi Bart,
thanks for the update earlier. I'll look into blk_{get,put}_request later and
try it on idefloppy. In the meantime, here are the patches as requested:
Thanks.
---
From 0d91862fc802d6f5aa79947b2685de6c209236f2 Mon Sep 17
Alan Cox wrote:
This has confused a few people so fix it
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-mm1/drivers/ata/pata_amd.c
linux-2.6.24-mm1/drivers/ata/pata_amd.c
---
On Mon, Feb 11, 2008 at 11:04:46AM +0100, Holger Macht wrote:
Wouldn't the proper fix be to call ata_acpi_handle_hotplug _somewhere_?
(which is currently called nowhere AFAICS)
I think so. The T61 at least generated ACPI dock and undock messages for
IDE master/slaves and we can use those.
-
To
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 205 +-
1 files changed, 93 insertions(+), 112 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 4ce67bd..7e62dfc 100644
---
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/scsi/ide-scsi.c | 133 ++-
1 files changed, 62 insertions(+), 71 deletions(-)
diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
index 7fea769..5ec421c 100644
---
On Mon, 11 Feb 2008 00:16:07 +0100, Bartlomiej Zolnierkiewicz [EMAIL
PROTECTED] wrote:
It is too late for -git but not too late for 2.6.25-rc1. ;-)
Could you make a patch please?
I went ahead and made a patch (sorry, I needed it for git pull request :).
From: Bartlomiej
On Mon 11. Feb - 11:37:15, Tejun Heo wrote:
Hello,
Holger Macht wrote:
Calling ap-ops-set_piomode(ap, dev) on a device/controller which got
already removed, locks the system hard. Reproducibly on an X60 attached to
a dock station containing a cdrom device with doing
$ echo 1
host-private_data = hpriv;
hpriv-n_ports = n_ports;
-host-iomap = NULL;
hpriv-base = ioremap(res-start, res-end - res-start + 1);
+host-iomap = hpriv-base;
hpriv-base -= MV_SATAHC0_REG_BASE;
rc = mv_create_dma_pools(hpriv, pdev-dev);
..
Well, that's
Holger Macht wrote:
It should be called via ata_acpi_{ap|dev}_notify() callbacks installed
via acpi_install_notify_handler(). Can you add dump_stack() in the
function and verify that it actually is being called? It could be that
the method is called too late or libata takes too long to
Alan Cox wrote:
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c
linux-2.6.24-mm1/drivers/ata/pata_legacy.c
--- linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c 2008-02-06
On Mon, Feb 11, 2008 at 09:37:18AM -0800, Linus Torvalds wrote:
On Mon, 11 Feb 2008, Linus Torvalds wrote:
So we should probably make pcibus_to_node() be an inline function for that
case
Or, we could just do the ugliest patch ever, namely
-#define pcibus_to_node(node)
54 matches
Mail list logo
