Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> On Tuesday 12 February 2008, Kamalesh Babulal wrote:
>> Bartlomiej Zolnierkiewicz wrote:
>>> Hi,
>>>
>>> On Monday 11 February 2008, Kamalesh Babulal wrote:
Nish Aravamudan wrote:
> On 2/7/08, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
shost->hostdata can contain arbitrary data including DMA target
buffers. Align it to cacheline.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
James, what do you think?
include/scsi/scsi_host.h |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/include/scsi/scsi_ho
Am Donnerstag, 14. Februar 2008 schrieb Borislav Petkov:
> On Thu, Feb 14, 2008 at 12:37:50AM +0100, Hans-Peter Jansen wrote:
>
> [Added Bart to CC]
>
> > Am Dienstag, 12. Februar 2008 schrieb Borislav Petkov:
> > > On Tue, Feb 12, 2008 at 10:26:17AM +0100, Hans-Peter Jansen wrote:
> > > > Hi,
> >
ap->sector_buf is used as DMA target and misalignment can cause data
corruption on non-coherent architectures. This problem is spotted and
initial patch is submitted by Mark Mason.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Cc: Mark Mason <[EMAIL PROTECTED]>
---
I thought about it more and mark
On Thu, Feb 14, 2008 at 1:46 AM, Kamalesh Babulal
<[EMAIL PROTECTED]> wrote:
>
> Bartlomiej Zolnierkiewicz wrote:
> > Hi,
> >
> > On Tuesday 12 February 2008, Kamalesh Babulal wrote:
> >> Bartlomiej Zolnierkiewicz wrote:
> >>> Hi,
> >>>
> >>> On Monday 11 February 2008, Kamalesh Babulal wrot
Hi,
On Thursday 14 February 2008, Kamalesh Babulal wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > Hi,
> >
> > On Tuesday 12 February 2008, Kamalesh Babulal wrote:
> >> Bartlomiej Zolnierkiewicz wrote:
> >>> Hi,
> >>>
> >>> On Monday 11 February 2008, Kamalesh Babulal wrote:
> Nish Aravamudan
On Thursday 14 February 2008, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Thursday 14 February 2008, Kamalesh Babulal wrote:
> > Bartlomiej Zolnierkiewicz wrote:
> > > Hi,
> > >
> > > On Tuesday 12 February 2008, Kamalesh Babulal wrote:
> > >> Bartlomiej Zolnierkiewicz wrote:
> > >>> Hi,
> >
On Wed, 13 Feb 2008 21:14:18 -0800
Harvey Harrison <[EMAIL PROTECTED]> wrote:
> Avoid a metric ton of sparse warnings like:
> drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one
> drivers/ata/pata_ali.c:176:14: originally declared here
NAK that appears to be a sparse bug.
On Wed, 13 Feb 2008 21:14:32 -0800
Harvey Harrison <[EMAIL PROTECTED]> wrote:
> Let's use ld for legacy_data instead of shadowing these static
> int variables.
NAK - I purposefully used names that indicate what device the private
data is being used for in order to make it clear. Changing qdi and
On Thursday 14 February 2008, Borislav Petkov wrote:
> On Thu, Feb 14, 2008 at 12:37:50AM +0100, Hans-Peter Jansen wrote:
>
> [Added Bart to CC]
>
> > Am Dienstag, 12. Februar 2008 schrieb Borislav Petkov:
> > > On Tue, Feb 12, 2008 at 10:26:17AM +0100, Hans-Peter Jansen wrote:
> > > > Hi,
> > >
On Thursday 14 February 2008, Andreas Jaeger wrote:
> Greg KH <[EMAIL PROTECTED]> writes:
>
> > How does the patch below look? I didn't want to remove the whole config
> > option, as there is more to the logic than just the "reverse order"
> > stuff there.
>
> I think you miss Documentation - it
On Thursday 14 February 2008, Borislav Petkov wrote:
> On Wed, Feb 13, 2008 at 11:04:23PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > On Wednesday 13 February 2008, Borislav Petkov wrote:
> > > commit d1f1f84f413ab00cb2fec48170d022fcd900e214
> > > Author: Borislav Petkov <[EMAIL PROTECTED]>
> > > D
If a device/bay is inside a docking station, we need to register for dock
events additionally to bay events. If a dock event occurs, the dock driver
will call the appropriate handler (ata_acpi_ap_notify() or
ata_acpi_dev_notify()) for us.
Signed-off-by: Holger Macht <[EMAIL PROTECTED]>
---
diff -
On Mon 11. Feb - 22:11:32, Tejun Heo wrote:
> Holger Macht wrote:
> >> It should be called via ata_acpi_{ap|dev}_notify() callbacks installed
> >> via acpi_install_notify_handler(). Can you add dump_stack() in the
> >> function and verify that it actually is being called? It could be that
> >> th
On Thu 14. Feb - 13:40:48, Holger Macht wrote:
> If a device/bay is inside a docking station, we need to register for dock
> events additionally to bay events. If a dock event occurs, the dock driver
> will call the appropriate handler (ata_acpi_ap_notify() or
> ata_acpi_dev_notify()) for us.
>
>
> > this will fix crash bug when doing rmmod to the driver, this is because the
> > port_stop function get called later and it could access the device's
> registers.
> >
>
> Where does the iounmap() now get done instead of that place?
>
nowhere, the /proc/iomem still shows that sata_mv uses io
From: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Subject: [PATCH] ide: mark "ide=reverse" option as obsolete
- it is valid only if "Probe IDE PCI devices in the PCI bus order
(DEPRECATED)" config option is used
- Greg needs to remove pci_get_device_reverse() for PCI core changes
Cc:
On 2/14/08, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
> On Thursday 14 February 2008, Borislav Petkov wrote:
> > On Thu, Feb 14, 2008 at 12:37:50AM +0100, Hans-Peter Jansen wrote:
> >
> > [Added Bart to CC]
> >
> > > Am Dienstag, 12. Februar 2008 schrieb Borislav Petkov:
> > > > On Tue,
On Thu, 2008-02-14 at 18:48 +0900, Tejun Heo wrote:
> shost->hostdata can contain arbitrary data including DMA target
> buffers. Align it to cacheline.
>
> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
> ---
> James, what do you think?
Hmm, it will blow out the host size ... although that's not s
On Thu, 2008-02-14 at 13:07 +0100, Bartlomiej Zolnierkiewicz wrote:
> > I worry that another git-bisect session will be needed unless SCSI
> > developers are already aware of the problem source.
>
> Yinghai Lu noticed that it may be actually a SES problem:
>
> http://lkml.org/lkml/2008/2/14/88
>
http://bugzilla.kernel.org/show_bug.cgi?id=9904
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #1
http://bugzilla.kernel.org/show_bug.cgi?id=9904
--- Comment #2 from [EMAIL PROTECTED] 2008-02-14 08:02 ---
Joseph, please send output of 'hdparm --Istdout /dev/hdd' command.
James, you are using different host driver so most likely this is not the same
bug - please open a new bugzill
http://bugzilla.kernel.org/show_bug.cgi?id=9904
--- Comment #3 from [EMAIL PROTECTED] 2008-02-14 08:15 ---
# hdparm --Istdout /dev/hdd
/dev/hdd:
85c0
2020 2020 2020 2020 2020 2020
2020 2020 2020 2020 312e
3038 2020 2020 4153
Tejun Heo wrote:
..
* For timeouts, result TF isn't available and thus res printout is
misleading. res shouldn't be printed after timeouts. This would
require allocating yest another temp buf and separating out res printing
into separate snprintf.
..
And snprintf() is buggy, by the way. It d
saeed bishara wrote:
> this will fix crash bug when doing rmmod to the driver, this is because the
> port_stop function get called later and it could access the device's
registers.
>
Where does the iounmap() now get done instead of that place?
nowhere, the /proc/iomem still shows that sat
Tejun Heo wrote:
Mark Lord wrote:
Tejun Heo wrote:
This patch implements libata.force module parameter which can
selectively override ATA port, link and device configurations
including cable type, SATA PHY SPD limit, transfer mode and NCQ.
...
+libata.force=[LIBATA] Force configuratio
Greg KH wrote:
On Wed, Feb 13, 2008 at 02:41:07AM +0100, Rene Herman wrote:
On 13-02-08 01:15, Greg KH wrote:
I'm reworking the pci device list logic (we currently keep all PCI
devices in 2 lists, which isn't the nicest, we should be able to get
away with only 1 list.)
The only bother I've fou
Use ld_qdi and ld_winbond to avoid shadowing static int
variables qdi and winbond. The ld_ prefix refers to
legacy_data.
drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one
drivers/ata/pata_legacy.c:128:12: originally declared here
drivers/ata/pata_legacy.c:811:21: warn
On Thu, 2008-02-14 at 12:01 +, Alan Cox wrote:
> On Wed, 13 Feb 2008 21:14:18 -0800
> Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > Avoid a metric ton of sparse warnings like:
> > drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one
> > drivers/ata/pata_ali.c:176:14:
On Thu, 14 Feb 2008 09:36:32 -0800
Harvey Harrison <[EMAIL PROTECTED]> wrote:
> Use ld_qdi and ld_winbond to avoid shadowing static int
> variables qdi and winbond. The ld_ prefix refers to
> legacy_data.
>
> drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one
> driver
On Thu, Feb 14, 2008 at 1:18 PM, Richard Liu <[EMAIL PROTECTED]> wrote:
> Hello all:
>
> I bought a Seagate ES.2 ST31000340NS (1000GB) and run at Gentoo
> Linux kernel 2.6.24.
> But Linux kernel report the disk size only 33MB.
> I tried Intel ICH5 and Sil3112, but get the same result.
>
>
>
> Mmm.. sounds like a bug to me. Possibly two bugs:
>
> 1. the ioremap() should fail if the range is already mapped, and
> 2. we should free the resources on module unload.
>
> I suppose this would be mostly automatic if the code simply
> were to use devm_ioremap() instead of ioremap().
my
Instead of using min/max_t(short... use a static inline to get
typechecking.
As a bonus, avoid a metric ton of sparse warnings like:
drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one
drivers/ata/pata_ali.c:176:14: originally declared here
Due to nesting min_t macro insid
Hello all:
I bought a Seagate ES.2 ST31000340NS (1000GB) and run at Gentoo
Linux kernel 2.6.24.
But Linux kernel report the disk size only 33MB.
I tried Intel ICH5 and Sil3112, but get the same result.
I don't know this issue was caused by libsata or scsi layer .
Could you help me to solved
rc is used to test the return value and possibly return an error.
No need to redeclare inside the loop.
drivers/ata/libata-core.c:7089:7: warning: symbol 'rc' shadows an earlier one
drivers/ata/libata-core.c:7030:9: originally declared here
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
drivers/ata/libata-scsi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index c02c490..1cea18f 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-sc
Current code is essentially choosing between dividing by 1 or
dividing by two, make the conditions a little more obvious.
As a bonus, removes a sparse error:
drivers/ata/pata_amd.c:59:11: warning: symbol '__x' shadows an earlier one
drivers/ata/pata_amd.c:59:11: originally declared here
Signed-of
Richard Liu wrote:
Hello all:
I bought a Seagate ES.2 ST31000340NS (1000GB) and run at Gentoo
Linux kernel 2.6.24.
But Linux kernel report the disk size only 33MB.
I tried Intel ICH5 and Sil3112, but get the same result.
I don't know this issue was caused by libsata or scsi layer .
..
hd
This patch may be too ugly to live, it suppresses a lot of
sparse warnings in the libata build and produces slightly
tighter code. (4 instructions vs 5 and a few bytes saved).
include/linux/libata.h:1214:13: warning: potentially expensive pointer
subtraction
Original:
if (++link - ap->pm
saeed bishara wrote:
Mmm.. sounds like a bug to me. Possibly two bugs:
1. the ioremap() should fail if the range is already mapped, and
2. we should free the resources on module unload.
I suppose this would be mostly automatic if the code simply
were to use devm_ioremap() instead of iorem
Hi Bart.
On Thu, Feb 14, 2008 at 09:55:50PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS to drivers/ide/Kconfig and use
> it instead of defining IDE_ARCH_OBSOLETE_DEFAULTS in .
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
> ---
> drivers/ide
Stephen Rothwell wrote:
Also, more trees please ... :-)
Please add the 'NEXT' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
to your list. This is a throwaway meta-branch that is rebased often.
The 'master' branch of libata-dev.git always contains the base co
Jeff Garzik wrote:
Please add the 'NEXT' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
to your list. This is a throwaway meta-branch that is rebased often.
Additional FYI:
Don't be worried if "git diff master..NEXT" is empty from time to time.
This condition
On Thu, 14 Feb 2008 01:36:56 +0100
Bartlomiej Zolnierkiewicz wrote:
> * Initialize IDE ports in mpc8xx_ide_probe().
>
> * Remove m8xx_ide_init() and ppc_ide_md hooks - no need for them
> (IDE mpc8xx host driver takes care of all this setup).
>
> * Remove needless 'if (irq)' and 'if (data_port
* Use CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS instead of
CONFIG_IDE_ARCH_OBSOLETE_INIT in init_ide_data().
* Remove no longer needed CONFIG_IDE_ARCH_OBSOLETE_INIT.
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/id
Add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS to drivers/ide/Kconfig and use
it instead of defining IDE_ARCH_OBSOLETE_DEFAULTS in .
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/Kconfig |3 +++
drivers/ide/ide.c |5 +
include/as
>
> I agree but this option is meant to be only temporary to ease the cleanup
> process. We can think about the proper solution after default IDE ports
> initialization gets moved to ide_generic host driver.
Makes sense and agreed. (I hoped so - which is why I said "borderline").
Sam
-
Hi,
On Thursday 14 February 2008, Sam Ravnborg wrote:
> Hi Bart.
>
> On Thu, Feb 14, 2008 at 09:55:50PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > Add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS to drivers/ide/Kconfig and use
> > it instead of defining IDE_ARCH_OBSOLETE_DEFAULTS in .
> >
> > Signed-off-
On Thu, 2008-02-14 at 16:03 -0500, Jeff Garzik wrote:
> Stephen Rothwell wrote:
> > Also, more trees please ... :-)
>
> Please add the 'NEXT' branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
>
> to your list. This is a throwaway meta-branch that is rebased often
James Bottomley wrote:
So does this indicate the meaning of upstream and upstream-fixes is
still the same? I always took upstream-fixes to be bug fixes for this
-rc and upstream as queued for the next merge window, in which case NEXT
would be the union of those two sets?
In practice, #upstrea
Jeff Garzik wrote:
Greg Kroah-Hartman (cc'd) needs to pick up your patch, since it is in
the "PCI" side of the house...
In addition to just waiting, it is normal to "ping" someone and/or
resend the patch, if nothing happens in 1-2 weeks.
Jeff
-
To unsubscribe from this list: send
James Bottomley wrote:
> On Thu, 2008-02-14 at 18:48 +0900, Tejun Heo wrote:
>> shost->hostdata can contain arbitrary data including DMA target
>> buffers. Align it to cacheline.
>>
>> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
>> ---
>> James, what do you think?
>
> Hmm, it will blow out the h
To be honest, I didn't believe that doing anything with the PSU
would do something.
However, seemingly it did.
I have also updated the BIOS, but I guess this has not much
to do with it.
So a different brand PSU was additionally installed, and this
one got the motherboard and the 4 disk which were
Gabor FUNK wrote:
> To be honest, I didn't believe that doing anything with the PSU
> would do something.
> However, seemingly it did.
> I have also updated the BIOS, but I guess this has not much
> to do with it.
I too am amazed at the number of PSU problems getting reported here. It
seems most
Malte Schröder wrote:
> Hello,
> on one of my machines neither 2.6.24 nor 2.6.24.1 work.
> The system is 64bit on Athlon X2 and ATI-Chipset (SB600).
>
> Extract from the kernel messages during boot:
>
> [ 66.943103] ahci :00:12.0: controller can't do 64bit DMA, forcing 32bit
> [ 66.950374
Hi Jeff,
On Thu, 14 Feb 2008 16:03:19 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
> Please add the 'NEXT' branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
>
> to your list. This is a throwaway meta-branch that is rebased often.
Added, thanks.
> I will continu
Harvey Harrison wrote:
> This patch may be too ugly to live, it suppresses a lot of
> sparse warnings in the libata build and produces slightly
> tighter code. (4 instructions vs 5 and a few bytes saved).
>
> include/linux/libata.h:1214:13: warning: potentially expensive pointer
> subtraction
>
On Fri, 2008-02-15 at 08:39 +0900, Tejun Heo wrote:
> Harvey Harrison wrote:
> > This patch may be too ugly to live, it suppresses a lot of
> > sparse warnings in the libata build and produces slightly
> > tighter code. (4 instructions vs 5 and a few bytes saved).
> >
> > include/linux/libata.h:12
http://bugzilla.kernel.org/show_bug.cgi?id=9994
Summary: atiixp ide timeouts
Product: IO/Storage
Version: 2.5
KernelVersion: 2.6.24
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: norma
http://bugzilla.kernel.org/show_bug.cgi?id=9994
[EMAIL PROTECTED] changed:
What|Removed |Added
Regression|0 |1
--
Configure bugmail: http://bugz
Tejun Heo wrote:
> Hello,
>
> Andrew Morton wrote:
>> On Thu, 14 Feb 2008 09:40:51 +0900
>> Tejun Heo <[EMAIL PROTECTED]> wrote:
>>
>>> Can you please take a look at ata_eh_link_report() in
>>> drivers/ata/libata-eh.c?
>> I did. Punishment?
>
> Heh.. :-)
>
>>> Currently, it has some problems.
Harvey Harrison wrote:
>>> I know it's ugly, but I had it done anyways. The one real problem I have
>>> with it is that if link and ap->pmp_link ever get changed to different types
>>> the compiler will not even warn as we cast away to (char *). To make it
>>> a bit more robust, a BUILD_BUG_ON ch
On Fri, 15 Feb 2008 10:49:31 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote:
> > printk is a special case, I think. It's the primary logging/debugging
> > method which can't fail and as it's mostly interpreted by human beings
> > (and developers in problematic cases), it has different maneuvering room
Andrew Morton wrote:
>>> printk is a special case, I think. It's the primary logging/debugging
>>> method which can't fail and as it's mostly interpreted by human beings
>>> (and developers in problematic cases), it has different maneuvering room
>>> on errors - ie. it's far better to print messag
On Fri, 15 Feb 2008 11:36:12 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote:
> Andrew Morton wrote:
> >>> printk is a special case, I think. It's the primary logging/debugging
> >>> method which can't fail and as it's mostly interpreted by human beings
> >>> (and developers in problematic cases), it h
Andrew Morton wrote:
>> So, I guess it's NACK w/o suggested alternatives, right?
>
> I wouldn't nack without good reasons, and I have none here. I don't have
> very strong opinions either way.
I was just wondering whether I should just go with snprintf dancing in
eh_link_report, which does make
Dear Mark:
2008/2/15, Mark Lord <[EMAIL PROTECTED]>:
> Richard Liu wrote:
> > Hello all:
> >
> > I bought a Seagate ES.2 ST31000340NS (1000GB) and run at Gentoo
> > Linux kernel 2.6.24.
> > But Linux kernel report the disk size only 33MB.
> > I tried Intel ICH5 and Sil3112, but
http://bugzilla.kernel.org/show_bug.cgi?id=8006
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED] |linux-ide@vger.kernel.org
On Thu, Feb 14, 2008 at 01:11:42PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 14 February 2008, Andreas Jaeger wrote:
> > Greg KH <[EMAIL PROTECTED]> writes:
> >
> > > How does the patch below look? I didn't want to remove the whole config
> > > option, as there is more to the logic th
On Wed, Feb 13, 2008 at 10:14:59AM -0800, Greg KH wrote:
> On Wed, Feb 13, 2008 at 07:47:11PM +0200, Muli Ben-Yehuda wrote:
> > On Wed, Feb 13, 2008 at 09:32:03AM -0800, Greg KH wrote:
> >
> > > Is there some reason you aren't using the "real" PCI driver api here
> > > and registering a pci driver
On Thu, Feb 14, 2008 at 11:17:03PM -0800, Greg KH wrote:
> Hm, that's wierd. I thought I got something, until I realized that
> you are doing a lot of logic before you ever even determine that
> your hardware is present in the system. Why are you calling
> calgary_locate_bbars() and doing all of
71 matches
Mail list logo
