Re: [PATCH] input: pwm-beeper: Add devicetree probing support

2012-09-24 Thread Rob Herring
On 09/24/2012 02:37 AM, Sascha Hauer wrote: A very simple binding, the only property is the phandle to the PWM. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Acked-by: Rob Herring rob.herr...@calxeda.com --- Documentation/devicetree/bindings/input/pwm-beeper.txt |7

Re: [PATCH 2/2] Input: matrix-keypad - Add device tree support

2012-10-19 Thread Rob Herring
On 10/19/2012 02:06 AM, AnilKumar Ch wrote: Add device tree support to matrix keypad driver and usage details are added to device tree documentation. Driver was tested on AM335x EVM. Signed-off-by: AnilKumar Ch anilku...@ti.com --- .../devicetree/bindings/input/matrix-keypad.txt| 52

Re: [PATCH v5] Input: matrix-keypad - Add device tree support

2012-11-10 Thread Rob Herring
On 11/10/2012 03:40 PM, AnilKumar Ch wrote: Add device tree support to matrix keypad driver and usage details are added to device tree documentation. Driver was tested on AM335x EVM. Signed-off-by: AnilKumar Ch anilku...@ti.com Acked-by: Rob Herring rob.herr...@calxeda.com --- This patch

Re: [PATCH v6] Input: matrix-keypad - Add device tree support

2012-11-15 Thread Rob Herring
On 11/15/2012 04:42 AM, AnilKumar Ch wrote: Add device tree support to matrix keypad driver and usage details are added to device tree documentation. Also modified the driver according to recent update of matrix_keypad_build_keymap(), which automatically allocate memory for keymap.

Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-21 Thread Rob Herring
On 12/20/2012 03:41 PM, Simon Glass wrote: Hi Dmitry, On Thu, Dec 20, 2012 at 1:13 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Simon, On Thu, Dec 20, 2012 at 12:23:58PM -0800, Simon Glass wrote: For the key repeat feature, we need to set this after the input device is

Re: [PATCH v4] Input: sysrq - DT binding for key sequence

2013-07-15 Thread Rob Herring
On 07/15/2013 10:36 AM, mathieu.poir...@linaro.org wrote: From: Mathieu J. Poirier mathieu.poir...@linaro.org Adding a simple device tree binding for the specification of key sequences. Definition of the keys found in the sequence are located in 'include/uapi/linux/input.h'. For the sysrq

Re: [PATCH v4] Input: sysrq - DT binding for key sequence

2013-07-16 Thread Rob Herring
On Tue, Jul 16, 2013 at 5:24 PM, Mathieu Poirier mathieu.poir...@linaro.org wrote: On 15 July 2013 20:43, Rob Herring robherri...@gmail.com wrote: On 07/15/2013 10:36 AM, mathieu.poir...@linaro.org wrote: From: Mathieu J. Poirier mathieu.poir...@linaro.org [snip] + prop

Re: [PATCH 1/2] include: dt-binding: input: create a DT header defining key codes.

2013-08-19 Thread Rob Herring
On Mon, Aug 19, 2013 at 11:24 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/19/2013 08:53 AM, Laxman Dewangan wrote: On Monday 12 August 2013 11:29 PM, Stephen Warren wrote: On 08/12/2013 11:15 AM, Dmitry Torokhov wrote: Device tree files can only include headers in

Re: [PATCHv5][ 1/4] Input: tsc2007: Add device tree support.

2013-10-23 Thread Rob Herring
On 10/23/2013 07:10 AM, Denis Carikli wrote: Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: devicet...@vger.kernel.org Cc: Dmitry

Re: [PATCHv6][ 1/4] Input: tsc2007: Add device tree support.

2013-10-24 Thread Rob Herring
On Thu, Oct 24, 2013 at 5:16 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, 24 Oct 2013 10:38:50 +0200, Denis Carikli de...@eukrea.com wrote: Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar

Re: [PATCHv3 1/4] DT: Add vendor prefix for Emerging Display Technologies

2014-01-17 Thread Rob Herring
On Fri, Jan 17, 2014 at 6:28 AM, Lothar Waßmann l...@karo-electronics.de wrote: Signed-off-by: Lothar Waßmann l...@karo-electronics.de --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 files changed, 1 insertions(+), 0 deletions(-) Applied. Rob diff --git

Re: [PATCHv2 1/5] Input: add common DT binding for touchscreens

2014-04-07 Thread Rob Herring
On Sat, Apr 5, 2014 at 5:26 PM, Sebastian Reichel s...@kernel.org wrote: Add common DT binding documentation for touchscreen devices and implement input_parse_touchscreen_of_params, which parses the common properties and configures the input device accordingly. Good. Signed-off-by:

Re: [PATCHv2 1/5] Input: add common DT binding for touchscreens

2014-04-07 Thread Rob Herring
On Mon, Apr 7, 2014 at 3:00 PM, Sebastian Reichel s...@kernel.org wrote: On Mon, Apr 07, 2014 at 11:38:01AM -0500, Rob Herring wrote: On Sat, Apr 5, 2014 at 5:26 PM, Sebastian Reichel s...@kernel.org wrote: Add common DT binding documentation for touchscreen devices and implement

[PATCH] Input: pxa27x_keypad - remove unnecessary ARM includes

2015-02-03 Thread Rob Herring
Remove some left-over ARM only includes in order to enable building on ARM64. __raw_{read,write}l were getting implicitly included, so add linux/io.h include. Signed-off-by: Rob Herring r...@kernel.org Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: linux-input@vger.kernel.org --- drivers

Re: [PATCH v1 4/4] leds: no longer use unnamed gpios

2015-01-08 Thread Rob Herring
On Thu, Jan 8, 2015 at 2:45 AM, Olliver Schinagl oli...@schinagl.nl wrote: Hey Dmitry, On 08-01-15 00:55, Dmitry Torokhov wrote: On Wed, Jan 07, 2015 at 10:08:42AM +0100, Olliver Schinagl wrote: From: Olliver Schinagl oli...@schinagl.nl The gpio document says we should not use unnamed

Re: [PATCH v1 3/4] leds: Let the binding document example for leds-gpio follow the gpio bindings

2015-01-07 Thread Rob Herring
an exception, so update the example in the document bindings. Signed-off-by: Olliver Schinagl oli...@schinagl.nl The example isn't exactly wrong, so I'd question how much this is really needed, but: Acked-by: Rob Herring r...@kernel.org --- Documentation/devicetree/bindings/leds/leds-gpio.txt

Re: [PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-28 Thread Rob Herring
On Tue, Jul 28, 2015 at 3:23 PM, Belisko Marek marek.beli...@gmail.com wrote: Hi Dmitry, On Thu, Jul 23, 2015 at 10:53 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Jul 23, 2015 at 10:38:34PM +0200, Marek Belisko wrote: Fix following: [8.862274] ERROR: Bad of_node_put()

Re: [PATCH v2 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2015-11-14 Thread Rob Herring
On Fri, Nov 13, 2015 at 09:35:52PM +0100, H. Nikolaus Schaller wrote: > commit b98abe52fa8e ("Input: add common DT binding for touchscreens") > introduced common DT bindings for touchscreens [1] and a helper function to > parse the DT. > > This has been integrated and interpretation of the

Re: [PATCH] input: st1232.c: Add devicetree attributes

2015-11-16 Thread Rob Herring
On Sun, Nov 15, 2015 at 05:20:47PM +0100, Sander Vermin wrote: > Add support for rotating and inverted axis for the Sitronix ST1232 > touchscreen controller. > > For the rotation of the touchscreen the devicetree resolution propteries are > requierd. For this purpose the following devicetree

Re: [PATCH] Input: pixcir_i2c_ts: add wake and enable gpios

2015-11-16 Thread Rob Herring
On Sun, Nov 15, 2015 at 04:56:43PM +0100, Sander Vermin wrote: > This patch improves the pixcir_i2c_ts touchscreen controller which is used by > the POV PROTAB2 tablet. > > On POV PROTAB2 tablet the WAKE and ENABLE gpios are used, and the screen is > rotated, so touchscreen-inverted-x and

Re: [PATCH v8 1/8] ARM: dt: Binding documentation for imx25 ADC/TSC

2015-11-16 Thread Rob Herring
On Mon, Nov 16, 2015 at 01:01:02PM +0100, Markus Pargmann wrote: > This documentation describes the devicetree bindings for the > ADC/Touchscreen unit of the i.MX25 SoC. > > Signed-off-by: Markus Pargmann <m...@pengutronix.de> > Acked-by: Jonathan Cameron <ji...@kernel.org

Re: [PATCH v8 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller

2015-11-16 Thread Rob Herring
On Mon, Nov 16, 2015 at 01:01:04PM +0100, Markus Pargmann wrote: > This is the touchscreen conversion queue binding documentation. It uses > the shared imx25 ADC. > > Signed-off-by: Markus Pargmann > --- > > Notes: > Changes in v5: > - Fix signed/unsigned

Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings

2015-11-02 Thread Rob Herring
On Fri, Oct 30, 2015 at 7:41 PM, Michael Welling wrote: > Adds documentation for the devicetree bindings of the new tsc2004 driver. > > Signed-off-by: Michael Welling > --- > .../bindings/input/touchscreen/tsc2005.txt | 39 > ++

Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings

2015-11-03 Thread Rob Herring
On Tue, Nov 3, 2015 at 1:21 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > On Mon, Nov 02, 2015 at 02:50:29PM -0600, Michael Welling wrote: >> On Mon, Nov 02, 2015 at 09:19:50AM -0600, Rob Herring wrote: >> > > +Required properties: >> > > + -

Re: [PATCH 2/3] input: rotary-encoder: Introduce new 'steps-per-period' property

2015-10-09 Thread Rob Herring
oder > for each GPIO period. > > Such a property is required to accurately describe all kinds of > rotary-encoders devices. > > Signed-off-by: Ezequiel Garcia <ezequ...@vanguardiasur.com.ar> Acked-by: Rob Herring <r...@kernel.org> Are there any in tree dts's using the d

Re: [PATCH 2/4] devicetree: bindings: Add header file with evdev type and abs/rel code defines

2015-09-10 Thread Rob Herring
On 09/09/2015 04:11 AM, Hans de Goede wrote: > This header provides evdev constants for linux,code, and linux,input-* > properties. > > Signed-off-by: Hans de Goede > --- > include/dt-bindings/input/evdev.h | 76 > +++ This looks fine,

Re: [PATCH 1/4] devicetree: bindings: Update gpio-keys-polled with support for abs/rel axis

2015-09-10 Thread Rob Herring
/ down and ABS_Y). One minor comment, otherwise: Acked-by: Rob Herring <r...@kernel.org> > > Signed-off-by: Hans de Goede <hdego...@redhat.com> > --- > Documentation/devicetree/bindings/input/gpio-keys-polled.txt | 7 ++- > 1 file changed, 6 insertions(+), 1 deleti

Re: [PATCH 2/4] devicetree: bindings: Add header file with evdev type and abs/rel code defines

2015-09-10 Thread Rob Herring
+Ian On 09/10/2015 01:50 PM, Hans de Goede wrote: > Hi, > > On 10-09-15 20:42, Dmitry Torokhov wrote: >> On Thu, Sep 10, 2015 at 11:40 AM, Hans de Goede <hdego...@redhat.com> >> wrote: >>> Hi, >>> >>> >>> On 10-09-15 20:34, Dmitry

Re: [PATCH 2/3] devicetree: bindings: use input-event-codes.h for evdev codes

2015-09-17 Thread Rob Herring
hing to --tree-filter if at all possible because it >> checks out the tree and is therefore a _little_ I/O intensive ;-) > > Thanks for your work on this, so what does this mean for moving forward > with the patch-set I posted. Can this be merged now ? And if not what > are we waiting for ? I thought you were sending another version using "linux-event-codes.h." Anyway, for the series for DT: Acked-by: Rob Herring <r...@kernel.org> Rob -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v9 2/8] ARM: dt: Binding documentation for imx25 GCQ

2015-12-07 Thread Rob Herring
On Sun, Dec 06, 2015 at 08:52:15PM +0100, Markus Pargmann wrote: > The documentation describes the bindings for the imx25 GCQ unit which is > essentially a generic conversion queue using the imx25 ADC. > > Signed-off-by: Markus Pargmann <m...@pengutronix.de> Acked-

Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1

2015-12-08 Thread Rob Herring
s <pl...@plaes.org> > --- > .../bindings/input/touchscreen/gt801_2plus1.txt| 23 ++ For the binding: Acked-by: Rob Herring <r...@kernel.org> > MAINTAINERS| 6 + > drivers/input/touchscreen/Kconfig | 1

Re: [PATCH RFC 3/3] input: rotary_encoder: support more than 2 gpios as input

2015-12-02 Thread Rob Herring
On Wed, Dec 02, 2015 at 11:07:14AM +0100, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> > --- > .../devicetree/bindings/input/rotary-encoder.txt | 2 +- For the binding: Acked-by: Rob Herring <r...@kernel.org> > arch

Re: [PATCH 09/10] Input: synaptics-rmi4: Add device tree support to the SPI transport driver

2015-11-30 Thread Rob Herring
On Wed, Nov 25, 2015 at 04:10:25PM -0800, Andrew Duggan wrote: > Add devicetree binding for SPI devices. > > Signed-off-by: Andrew Duggan > --- > .../devicetree/bindings/input/rmi4/rmi_spi.txt | 57 > ++ > drivers/input/rmi4/rmi_spi.c

Re: [PATCH v9 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller

2015-12-07 Thread Rob Herring
On Sun, Dec 06, 2015 at 08:52:16PM +0100, Markus Pargmann wrote: > This is the touchscreen conversion queue binding documentation. It uses > the shared imx25 ADC. > > Signed-off-by: Markus Pargmann > --- > > Notes: > Changes in v9: > - Updated binding descriptions

Re: [PATCH 1/2] Input: add touchscreen bindings for TS-4800

2015-12-10 Thread Rob Herring
y of those here? Otherwise, Acked-by: Rob Herring <r...@kernel.org> > --- > .../devicetree/bindings/input/touchscreen/ts4800-ts.txt | 12 > > 1 file changed, 12 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/input/to

Re: [PATCH v2 2/3] Input: cyttsp - add device tree support

2016-01-06 Thread Rob Herring
On Tue, Jan 05, 2016 at 01:59:14PM +0100, Oreste Salerno wrote: > Add support for retrieving the platform data from the device > tree. Converting platform data to DT as is is typically not the right thing to do. There's some overlap, but it is not typically 1-1. > Signed-off-by: Oreste Salerno

Re: [PATCH v10 3/8] ARM: dt: Binding documentation for imx25 touchscreen controller

2015-12-19 Thread Rob Herring
repeat-wait. Previously the touchscreen caused massive number of > interrupts. > > .../bindings/input/touchscreen/fsl-mx25-tcq.txt| 35 > ++ > 1 file changed, 35 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/input/touchscreen/

Re: [PATCH 05/10] Input: synaptics-rmi4: Add device tree support for 2d sensors and F11

2015-11-27 Thread Rob Herring
On Wed, Nov 25, 2015 at 04:09:13PM -0800, Andrew Duggan wrote: > 2D sensors have several parameter which can be set in the platform data. > This patch adds support for getting those values from devicetree. > > Signed-off-by: Andrew Duggan > --- >

Re: [PATCH 03/10] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices

2015-11-27 Thread Rob Herring
On Wed, Nov 25, 2015 at 04:07:21PM -0800, Andrew Duggan wrote: > Add devicetree binding for I2C devices and add bindings for optional > parameters in the function drivers. Parameters for function drivers are > defined in child nodes for each of the functions. > > Signed-off-by: Andrew Duggan

Re: [PATCH 4/7] touchscreen: pixcir_i2c: Add support for wake and enable gpios

2015-11-20 Thread Rob Herring
a bunch of dev_info calls to make the driver less chatty > -Use devm_gpiod_get_optional as these new gpios are optional > -Only msleep after setting enable high if we have an enable pin > --- > .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 2 + For the binding: Acked-by: Rob He

Re: [PATCH v11 6/8] Input: goodix - add support for ESD

2015-11-20 Thread Rob Herring
ious devices). > > Signed-off-by: Irina Tirdea <irina.tir...@intel.com> > For the binding: Acked-by: Rob Herring <r...@kernel.org> You should not have the "For the binding:" part here. It was just a note so it was clear what part I looked at. It is preferr

Re: [PATCH v11 2/8] Input: goodix - reset device at init

2015-11-20 Thread Rob Herring
() > { > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > Package () > { > Package (2) {"irq-gpios", Package() {^STAC, 0, 0, 0 }}, > Package (2) {"reset-gpios", Package() {^STAC, 1, 0, 0 }}, > ... > }

Re: [PATCH v10 2/8] Input: goodix - reset device at init

2015-11-18 Thread Rob Herring
On Wed, Nov 18, 2015 at 06:31:35PM +0200, Irina Tirdea wrote: > After power on, it is recommended that the driver resets the device. > The reset procedure timing is described in the datasheet and is used > at device init (before writing device configuration) and > for power management. It is a

Re: [PATCH v10 6/8] Input: goodix - add support for ESD

2015-11-18 Thread Rob Herring
s > are properly initialized from ACPI/DT. > > This is based on Goodix datasheets for GT911 and GT9271 and on Goodix > driver gt9xx.c for Android (publicly available in Android kernel > trees for various devices). > > Signed-off-by: Irina Tirdea <irina.tir...@intel.com>

Re: [PATCH V4 3/3] Input: goodix - update dt bindings documentation (axis swapping/inversion)

2015-11-22 Thread Rob Herring
/touchscreen/touchscreen.txt. > > Document these properties in the goodix bindings description. > > Signed-off-by: Karsten Merker <mer...@debian.org> > Reviewed-by: Irina Tirdea <irina.tir...@intel.com> Acked-by: Rob Herring <r...@kernel.org> > --- > Documentati

Re: [PATCH v3] touchscreen: pixcir_i2c: Add support for wake and enable gpios

2015-11-22 Thread Rob Herring
quot;if (!IS_ERR_OR_NULL(ts->foo))" > -No need to set gpio-s to 1 after requesting them with GPIOD_OUT_HIGH > --- > .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 2 ++ For the binding: Acked-by: Rob Herring <r...@kernel.org> > drivers/input/touchscreen/pixcir_i2c_ts.c