Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'

2013-08-06 Thread Li Zefan
>> The right answer to the code is to config it out and then you don't have >> to worry about it one way or another. >> > > Pardon? > > Excuse me, my English is not quite well, I don't quite understand your > meaning, could you please repeat again in details or say more clearly ? > > >> The

Re: [PATCH 1/5] pdev: Fix platform device resource linking

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 11:19:14AM +0100, Russell King - ARM Linux wrote: > On Tue, Aug 06, 2013 at 06:15:27PM +0800, Greg Kroah-Hartman wrote: > > On Tue, Aug 06, 2013 at 12:45:42PM +0300, Pantelis Antoniou wrote: > > > What would it take to move all this into driver core? > > > > What

Re: [PATCH 1/5] pdev: Fix platform device resource linking

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 01:27:35PM +0300, Pantelis Antoniou wrote: > Hi Greg, > > On Aug 6, 2013, at 1:15 PM, Greg Kroah-Hartman wrote: > > > On Tue, Aug 06, 2013 at 12:45:42PM +0300, Pantelis Antoniou wrote: > >> Hi Greg, > >> > >> On Aug 6, 2013, at 12:36 PM, Greg Kroah-Hartman wrote: > >> >

linux-next: Tree for Aug 7

2013-08-06 Thread Stephen Rothwell
Hi all, Changes since 20130806: The ext4 tree lost its build failure. The mvebu tree gained a build failure so I used the version from next-20130806. The akpm tree gained conflicts against the ext4 tree. I have

Re: [PATCH 5/5] arm: omap: Proper cleanups for omap_device

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 03:37:13PM +0200, Alexander Holler wrote: > Am 06.08.2013 12:14, schrieb Greg Kroah-Hartman: > > >> What exactly is a platform device anyway? > > > > Originally it was a "something that wasn't connected to a bus, but just > > had memory-mapped i/o." Like the PS2 keyboard

unused swap offset / bad page map.

2013-08-06 Thread Dave Jones
Seen while fuzzing with lots of child processes. swap_free: Unused swap offset entry 001263f5 BUG: Bad page map in process trinity-child29 pte:24c7ea00 pmd:09fec067 addr:7f9db958d000 vm_flags:00100073 anon_vma:88022c004ba0 mapping: (null) index:f99 Modules linked in: fuse

Re: Can we drop __must_check from driver_for_each_device()?

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 10:31:25PM +0200, Paul Bolle wrote: > On Fri, 2013-08-02 at 08:31 +0800, Greg Kroah-Hartman wrote: > > On Wed, Jul 31, 2013 at 11:35:13PM +0200, Paul Bolle wrote: > > > 2) Please note that if the callback always returns zero, > > > driver_for_each_device() can still return

Re: linux-next: build failure after merge of the ext4 tree

2013-08-06 Thread Sedat Dilek
odes in no journal mode"). >> > >> > I have used the ext4 tree from next-20130726 for today. >> >> Since this message ext4-tree was not updated. >> The commit "ext4: avoid reusing recently deleted inodes in no journal >> mode" was refreshed

Re: linux-next: build failure after merge of the ext4 tree

2013-08-06 Thread Stephen Rothwell
Hi Sedat, On Wed, 7 Aug 2013 07:16:57 +0200 Sedat Dilek wrote: > > On Mon, Jul 29, 2013 at 3:08 AM, Stephen Rothwell > wrote: > > > > After merging the ext4 tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > > > fs/ext4/ialloc.c: In function '__ext4_new_inode':

Re: [PATCH 00/11] Add compression support to pstore

2013-08-06 Thread Tony Luck
On Tue, Aug 6, 2013 at 10:13 PM, Aruna Balakrishnaiah wrote: > How is it with erst and efivars? ERST is at the whim of the BIOS writer (the ACPI standard doesn't provide any suggestions on record sizes). My systems support ~6K record size. efivars has, IIRC, a 1k limit coded in the Linux back

Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'

2013-08-06 Thread Chen Gang F T
On 08/07/2013 06:13 AM, Eric W. Biederman wrote: > Andrew Morton writes: > >> On Tue, 06 Aug 2013 15:29:42 +0800 Chen Gang wrote: >> >>> Improve the usage of return value 'result', so not only can make code >>> clearer to readers, but also can improve the performance. >> >> It used to be

[PATCH] genalloc: fix overflow of ending address of memory chunk

2013-08-06 Thread Joonyoung Shim
In struct gen_pool_chunk, end_addr means ending address of memory chunk, but actually it is starting address + size of memory chunk in codes, so it points the address increased one instead of correct ending address. The ending address of memory chunk increased one will cause overflow on the case

Re: [PATCH v2 1/2] perf tools: Add support for pinned modifier

2013-08-06 Thread Michael Ellerman
On Tue, Aug 06, 2013 at 03:59:37PM +0200, Jiri Olsa wrote: > On Tue, Aug 06, 2013 at 11:28:05PM +1000, Michael Ellerman wrote: > > SNIP > > > > > while (*p) { > > @@ -812,6 +818,9 @@ int parse_events__modifier_event(struct list_head > > *list, char *str, bool add) > >

linux-next: manual merge of the akpm tree with the ext4 tree

2013-08-06 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in fs/ext4/extents_status.c between commit 49c6efc7b80e ("ext4: add new ioctl EXT4_IOC_PRECACHE_EXTENTS") from the ext4 tree and commit "fs-convert-fs-shrinkers-to-new-scan-count-api-fix" from the akpm tree. I fixed it up (see

Re: linux-next: build failure after merge of the ext4 tree

2013-08-06 Thread Sedat Dilek
On Mon, Jul 29, 2013 at 3:08 AM, Stephen Rothwell wrote: > Hi Theodore, > > After merging the ext4 tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > fs/ext4/ialloc.c: In function '__ext4_new_inode': > fs/ext4/ialloc.c:817:1: warning: label 'next_ino' defined but not

linux-next: manual merge of the akpm tree with the ext4 tree

2013-08-06 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in fs/ext4/extents_status.c between commit 49c6efc7b80e ("ext4: add new ioctl EXT4_IOC_PRECACHE_EXTENTS") from the ext4 tree and commit "fs: convert fs shrinkers to new scan/count API" from the akpm tree. I fixed it up (see

Re: [RFC] gcc feature request: Moving blocks into sections

2013-08-06 Thread Ondřej Bílka
On Tue, Aug 06, 2013 at 08:56:00PM -0400, Steven Rostedt wrote: > On Tue, 2013-08-06 at 20:45 -0400, Steven Rostedt wrote: > > > [3.387362] short jumps: 106 > > [3.390277] long jumps: 330 > > > > Thus, approximately 25%. Not bad. > > Also, where these happen to be is probably even more

Re: [PATCH 00/11] Add compression support to pstore

2013-08-06 Thread Aruna Balakrishnaiah
Hi Tony, On Wednesday 07 August 2013 08:55 AM, Tony Luck wrote: On Tue, Aug 6, 2013 at 6:58 PM, Aruna Balakrishnaiah wrote: The patch looks right. I will clean it up. Does the issue still persist after this? Things seem to be working - but testing has hardly been extensive (just a couple of

Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'

2013-08-06 Thread Chen Gang
Thank you for your reply in details, especially you are very busy. My original opinion about optimization is incorrect. Thanks. On 08/07/2013 05:43 AM, Andrew Morton wrote: > On Tue, 06 Aug 2013 15:29:42 +0800 Chen Gang wrote: > >> Improve the usage of return value 'result', so not only can

Re: [PATCH 0/5] ACPI: acpi_bind_one()/acpi_unbind_one() cleanups

2013-08-06 Thread Yasuaki Ishimatsu
(2013/08/06 9:22), Rafael J. Wysocki wrote: Hi All, The following 5 patches clean up a little mess in acpi_bind_one() and acpi_unbind_one(). They are on top of current linux-next plus the patch at https://patchwork.kernel.org/patch/2839101/ . [1/5] Move duplicated code from

Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'

2013-08-06 Thread Chen Gang
On 08/07/2013 05:46 AM, Eric W. Biederman wrote: > Chen Gang writes: > > Have you tested this code? Do you have anything that actually the > uses sysctl binary interface? > No, I only compile about it, not give a test. It is really better to give a test, but it seems not quite necessary to

rcu stall warning, again.

2013-08-06 Thread Dave Jones
Still seeing these (though not as frequently) INFO: rcu_preempt self-detected stall on CPU { 2} (t=6500 jiffies g=4433279 c=4433278 q=0) sending NMI to all CPUs: NMI backtrace for cpu 0 CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.11.0-rc4+ #1 task: 81c10440 ti: 81c0

Re: [PATCH -tip ] x86/insn: Add Haswell-introduced opcodes

2013-08-06 Thread H. Peter Anvin
On 08/06/2013 09:51 PM, Masami Hiramatsu wrote: > > Thanks, Andi also asked me to support them ;) > As far as I can see, that requires more work to support > EVEX decoding. And perhaps, I have to classify new instructions > and operands and introduce new abbreviations/superscripts for > them,

[PATCH v3] backlight: lm3630: apply chip revision

2013-08-06 Thread Daniel Jeong
The LM3630 chip was revised by TI and chip name was also changed to LM3630A. And register map, default values and initial sequences are changed. The files, lm3630_bl.{c,h} are replaced by lm3630a_bl.{c,h} You can find more information about LM3630A(datasheet, evm etc) at

Re: Re: [PATCH -tip ] x86/insn: Add Haswell-introduced opcodes

2013-08-06 Thread Masami Hiramatsu
(2013/08/07 0:16), H. Peter Anvin wrote: > On 08/06/2013 12:37 AM, Masami Hiramatsu wrote: >> Add TSX-NI related instructions and new instructions to >> x86-opcode-map.txt according to the Intel(R) 64 and IA-32 >> Architectures Software Developer's Manual Vol2C (June, 2013). >> This also includes

Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks

2013-08-06 Thread H. Peter Anvin
On 08/06/2013 07:54 PM, Raghavendra K T wrote: > On 08/07/2013 02:31 AM, H. Peter Anvin wrote: >> >> What is the baseline for this patchset? I tried to apply it on top of >> 3.11-rc4 and I got nontrivial conflicts. >> > > I had based it on top of 445363e8 [ Merge branch 'perf/urgent'] > of tip.

Re: [PATCH] lto, watchdog/hpwdt.c: Make assembler label global

2013-08-06 Thread Andi Kleen
On Tue, Aug 06, 2013 at 01:51:18PM -0700, Andrew Morton wrote: > On Mon, 5 Aug 2013 15:16:39 -0700 Andi Kleen wrote: > > > We cannot assume that the inline assembler code always ends up > > in the same file as the original C file. > > um, why not? You put an asm(".text\n...") into a .c file

Re: [PATCH] acpi: video: improve quirk check

2013-08-06 Thread Aaron Lu
On 08/04/2013 10:19 PM, Felipe Contreras wrote: > On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki wrote: >> On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: > >>> Personally I think there are better ways to fix the code for the >>> synthetic case than what you patch does, which

linux-next: build failure after merge of the mvebu tree

2013-08-06 Thread Stephen Rothwell
by commit 8f400e08b197 ("PCI: use weak functions for MSI arch-specific functions"). I have used the version of the mvebu tree from next-20130806 for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpU6x4r9jzm2.pgp Description: PGP signature

Re: [PATCH] f2fs: fix a deadlock in fsync

2013-08-06 Thread Jim Xu
Hi Kim, The patch sounds good to me. BTW, as in the deadlock situation I noticed, I did not find any thread was doing checkpoint at that moment. The bdi writeback thread and the fsync user thread was not. Neither was the background f2fs_gc thread because there had enough free segments.

Re: [RFC 0/1] drm/pl111: Initial drm/kms driver for pl111

2013-08-06 Thread John Stultz
On Tue, Aug 6, 2013 at 5:15 AM, Rob Clark wrote: > On Tue, Aug 6, 2013 at 7:31 AM, Tom Cooksey wrote: >> >>> > So in some respects, there is a constraint on how buffers which will >>> > be drawn to using the GPU are allocated. I don't really like the idea >>> > of teaching the display controller

Re: [PATCH V5] pci: exynos: split into two parts such as Synopsys part and Exynos part

2013-08-06 Thread Jingoo Han
On Wednesday, July 31, 2013 5:14 PM, Jingoo Han wrote: > Exynos PCIe IP consists of Synopsys specific part and Exynos > specific part. Only core block is a Synopsys designware part; > other parts are Exynos specific. > Also, the Synopsys designware part can be shared with other > platforms; thus,

Re: [PATCH 04/12] KVM: MMU: log dirty page after marking spte writable

2013-08-06 Thread Xiao Guangrong
On 08/07/2013 09:48 AM, Marcelo Tosatti wrote: > On Tue, Jul 30, 2013 at 09:02:02PM +0800, Xiao Guangrong wrote: >> Make sure we can see the writable spte before the dirt bitmap is visible >> >> We do this is for kvm_vm_ioctl_get_dirty_log() write-protects the spte based >> on the dirty bitmap, we

Re: [PATCH] checkpatch: Better --fix of SPACING errors.

2013-08-06 Thread Joe Perches
On Tue, 2013-08-06 at 19:55 -0700, Joe Perches wrote: > Previous attempt at fixing SPACING errors could > make a hash of several defects. I have run this against drivers/staging/... It works rather better than the older version. It does have an issue with c99 style comments when it needs to

Re: [tip:x86/asmlinkage] x86, asmlinkage: Make kprobes code visible and fix assembler code

2013-08-06 Thread Masami Hiramatsu
(2013/08/07 6:43), tip-bot for Andi Kleen wrote: > Commit-ID: 04bb591ca74fb8ea06d5ab7fadfb7bf5b11fb28e > Gitweb: http://git.kernel.org/tip/04bb591ca74fb8ea06d5ab7fadfb7bf5b11fb28e > Author: Andi Kleen > AuthorDate: Mon, 5 Aug 2013 15:02:41 -0700 > Committer: H. Peter Anvin >

Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'

2013-08-06 Thread Chen Gang
On 08/07/2013 06:11 AM, Joe Perches wrote: > On Tue, 2013-08-06 at 14:43 -0700, Andrew Morton wrote: >> On Tue, 06 Aug 2013 15:29:42 +0800 Chen Gang wrote: >> >>> Improve the usage of return value 'result', so not only can make code >>> clearer to readers, but also can improve the performance. >>

[PATCH 03/17] Add system pointer argument to shared EFI stub related functions so they no longer use global system table pointer as they did when part of eboot.c.

2013-08-06 Thread Roy Franz
Signed-off-by: Roy Franz --- arch/x86/boot/compressed/eboot.c | 38 +++-- drivers/firmware/efi/efi-stub-helper.c | 96 +--- 2 files changed, 72 insertions(+), 62 deletions(-) diff --git a/arch/x86/boot/compressed/eboot.c

[PATCH 16/17] Add EFI stub for ARM

2013-08-06 Thread Roy Franz
This patch adds EFI stub support for the ARM Linux kernel. The EFI stub operations similarly to the x86 stub: it is a shim between the EFI firmware and the normal zImage entry point, and sets up the environment that the zImage is expecting. This includes loading the initrd (optionaly) and device

[PATCH 12/17] Add proper definitions for some EFI function pointers.

2013-08-06 Thread Roy Franz
The x86/AMD64 EFI stubs must us a call wrapper to convert between the Linux and EFI ABIs, so void pointers are sufficient. For ARM, the ABIs are compatible, so we can directly invoke the function pointers. The functions that are used by the ARM stub are updated to match the EFI definitions.

[PATCH 11/17] Move EFI_READ_CHUNK_SIZE define to shared location.

2013-08-06 Thread Roy Franz
This #define is only used the the shared code, so move it there. Signed-off-by: Roy Franz --- arch/x86/boot/compressed/eboot.h |1 - drivers/firmware/efi/efi-stub-helper.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/boot/compressed/eboot.h

[PATCH 05/17] Add minimum address parameter to efi_low_alloc()

2013-08-06 Thread Roy Franz
This allows allocations to be made low in memory while avoiding allocations at the base of memory. Signed-off-by: Roy Franz --- arch/x86/boot/compressed/eboot.c | 11 ++- drivers/firmware/efi/efi-stub-helper.c |5 - 2 files changed, 10 insertions(+), 6 deletions(-) diff

[PATCH 01/17] EFI stub documentation updates

2013-08-06 Thread Roy Franz
The ARM kernel also has an EFI stub which works largely the same way as the x86 stub, so move the documentation out of x86 directory and update to reflect that it is generic, and add ARM specific text. Signed-off-by: Roy Franz --- Documentation/efi-stub.txt | 78

[PATCH 04/17] Rename memory allocation/free functions

2013-08-06 Thread Roy Franz
Rename them to be more similar, as low_free() could be used to free memory allocated by both high_alloc() and low_alloc(). high_alloc() -> efi_high_alloc() low_alloc() -> efi_low_alloc() low_free() -> efi_free() Signed-off-by: Roy Franz --- arch/x86/boot/compressed/eboot.c | 19

[PATCH 09/17] Generalize handle_ramdisks() and rename to handle_cmdline_files().

2013-08-06 Thread Roy Franz
The handle_cmdline_files now takes the option to handle as a string, and returns the loaded data through parameters, rather than taking an x86 specific setup_header structure. For ARM, this will be used to load a device tree blob in addition to initrd images. Signed-off-by: Roy Franz ---

[PATCH 10/17] Renames in handle_cmdline_files() to complete generalization.

2013-08-06 Thread Roy Franz
Rename variables to be not initrd specific, as now the function loads arbitrary files. Signed-off-by: Roy Franz --- drivers/firmware/efi/efi-stub-helper.c | 92 1 file changed, 46 insertions(+), 46 deletions(-) diff --git

[PATCH 08/17] Allow efi_free() to be called with size of 0, and do nothing in that case.

2013-08-06 Thread Roy Franz
Make efi_free() safely callable with size of 0, similar to free() being callable with NULL pointers. Remove size checks that this makes redundant. This also avoids some size checks in the ARM EFI stub code that will be added as well. Signed-off-by: Roy Franz ---

[PATCH 07/17] Enforce minimum alignment of 1 page on allocations. The efi_high_alloc() and efi_low_alloc() functions use the EFI_ALLOCATE_ADDRESS option to the EFI function allocate_pages(), which req

2013-08-06 Thread Roy Franz
The existing code could fail to allocate depending on allocation size, as although repeated allocation attempts were made, none were guaranteed to be page aligned. Signed-off-by: Roy Franz --- drivers/firmware/efi/efi-stub-helper.c | 14 ++ 1 file changed, 14 insertions(+) diff

[PATCH 14/17] resolve warnings found on ARM compile

2013-08-06 Thread Roy Franz
2 unused labels 1 "value computed is not used" Signed-off-by: Roy Franz --- drivers/firmware/efi/efi-stub-helper.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c index bbe02fd..3515c3a

[PATCH 06/17] rename __get_map() to efi_get_memory_map(), add parameter to optionally return mmap key. The mmap key is required to exit EFI boot services, and allows efi_get_memory_map() to be used fo

2013-08-06 Thread Roy Franz
Signed-off-by: Roy Franz --- drivers/firmware/efi/efi-stub-helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c index 63e3556..cd7701f 100644 ---

[PATCH 17/17] Add config EFI_STUB for ARM to Kconfig

2013-08-06 Thread Roy Franz
Signed-off-by: Roy Franz --- arch/arm/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 37c0f4e..192968c 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1805,6 +1805,16 @@ config UACCESS_WITH_MEMCPY However, if

[PATCH 13/17] Fix types in EFI calls to match EFI function definitions.

2013-08-06 Thread Roy Franz
EFI calls can made directly on ARM, so the function pointers are directly invoked. This allows types to be checked at compile time, so here we ensure that the parameters match the function signature. Signed-off-by: Roy Franz --- drivers/firmware/efi/efi-stub-helper.c | 15 +-- 1

[PATCH 15/17] Add strstr to compressed string.c for ARM.

2013-08-06 Thread Roy Franz
The shared efi-stub-helper.c functions require a strstr implementation. Implementation copied from arch/x86/boot/string.c Signed-off-by: Roy Franz --- arch/arm/boot/compressed/string.c | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot/compressed/string.c

[PATCH V2 00/17] EFI stub for ARM

2013-08-06 Thread Roy Franz
This patch series adds EFI stub support for the ARM architecture. Some code that was previously only used by x86/x86_64 is now shared and has been made more general. The stub for ARM is implemented in a similar manner to x86 in that it is a shim layer between EFI and the normal zImage/bzImage

[PATCH 02/17] Move common EFI stub code from x86 arch code to common location

2013-08-06 Thread Roy Franz
No code changes made, just moving functions from x86 arch directory to common location. Code is shared using #include, similar to how decompression code is shared among architectures. Signed-off-by: Roy Franz --- arch/x86/boot/compressed/eboot.c | 442 +-

Re: kernel mailing list permalinks

2013-08-06 Thread Joe Perches
On Tue, 2013-08-06 at 20:39 -0700, H. Peter Anvin wrote: > On 08/06/2013 04:15 PM, Joe Perches wrote: > > Rather than relying on third party links, > > it'd be nice if vger was the archive too. > We probably should archive the contents, but it really doesn't seem to > matter if we outsource

Re: kernel mailing list permalinks

2013-08-06 Thread H. Peter Anvin
On 08/06/2013 04:15 PM, Joe Perches wrote: > On Tue, 2013-08-06 at 16:05 -0700, H. Peter Anvin wrote: >> On 08/06/2013 02:55 PM, Anders Larsen wrote: >>> On 2013-08-06 23:23, H. Peter Anvin wrote: On 08/06/2013 02:11 PM, Bjorn Helgaas wrote: >> >> The above link is also a good example

Re: [PATCH 1/2] kernel/sys.c: return the current gid when error occurs

2013-08-06 Thread Chen Gang
On 08/07/2013 04:21 AM, Andy Lutomirski wrote: > On 08/06/2013 01:01 AM, Chen Gang wrote: >> According to the API definition, when error occurs, need return current >> fsgid instead of the previous one. >> >> The related informations ("man setfsgid"): >> >> RETURN VALUE >> On success,

[PATCH] mmc: dw_mmc: Don't disable vmmc if keeping power in suspend

2013-08-06 Thread Derek Basehore
If we keep power for suspend on a host for dw_mmc, don't disable vmmc-supply regulator when suspending the host. Signed-off-by: Derek Basehore Reviewed-by: Doug Anderson --- drivers/mmc/host/dw_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 00/11] Add compression support to pstore

2013-08-06 Thread Tony Luck
On Tue, Aug 6, 2013 at 6:58 PM, Aruna Balakrishnaiah wrote: > The patch looks right. I will clean it up. Does the issue still persist > after this? Things seem to be working - but testing has hardly been extensive (just a couple of forced panics). I do have one other question. In this code: >>

Re: [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic()

2013-08-06 Thread Yasuaki Ishimatsu
(2013/08/07 1:56), Toshi Kani wrote: On Tue, 2013-08-06 at 19:11 +0900, Yasuaki Ishimatsu wrote: try_offline_node() checks that all cpus related with removed node have been removed by using cpu_present_bits. If all cpus related with removed node have been removed, try_offline_node() clears the

Re: acpi_bus_trim does not detach devices in post order

2013-08-06 Thread Yasuaki Ishimatsu
(2013/08/07 9:57), Rafael J. Wysocki wrote: On Wednesday, August 07, 2013 09:35:51 AM Yasuaki Ishimatsu wrote: (2013/08/06 23:26), Rafael J. Wysocki wrote: On Tuesday, August 06, 2013 07:06:37 PM Yasuaki Ishimatsu wrote: (2013/08/06 12:07), Yasuaki Ishimatsu wrote: I acked the following

Re: [PATCH v4 8/9] pci: Tune secondary bus reset timing

2013-08-06 Thread Alex Williamson
On Tue, 2013-08-06 at 16:27 -0700, Alexander Duyck wrote: > On 08/05/2013 12:37 PM, Alex Williamson wrote: > > The PCI spec indicates that with stable power, reset needs to be > > asserted for a minimum of 1ms (Trst). Seems like we should be able > > to assume power is stable for a runtime

[PATCH] checkpatch: Better --fix of SPACING errors.

2013-08-06 Thread Joe Perches
Previous attempt at fixing SPACING errors could make a hash of several defects. This patch should make --fix be a lot better at correcting these defects. Trim left and right sides of these defects appropriately instead of a somewhat random attempt at it. Trim left spaces from any following bit

paper supplier

2013-08-06 Thread Akbyu
Dear Purchasing manager: Nice time to you It is my big pleasure to hear you need A4 paper we are the leading supplier from China If you still need that pls tell me Then i can send you our best price Best wishes Ida Ida Chen SALES MANAGER East Siweite industry Co., Ltd www.dfswtpaper.com

Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks

2013-08-06 Thread Raghavendra K T
On 08/07/2013 02:31 AM, H. Peter Anvin wrote: What is the baseline for this patchset? I tried to apply it on top of 3.11-rc4 and I got nontrivial conflicts. I had based it on top of 445363e8 [ Merge branch 'perf/urgent'] of tip. Sorry for not mentioning that. Please let me know, if I

Re: [PATCH trivial] UAPI: Kbuild: add/modify comments for "uapi/Kbuild" and "uapi/linux/Kbuild"

2013-08-06 Thread Chen Gang
On 08/07/2013 01:31 AM, Joe Perches wrote: > On Tue, 2013-08-06 at 09:46 +0800, Chen Gang wrote: >> "include/uapi/" is the whole Linux kernel API, it is important enough >> to get more global explanations by comments. > > It'd probably be useful to have more descriptions > of uapi in the

Re: [PATCH 0/2] kernel/sys.c: for setfsgid(), return the current gid when error occurs

2013-08-06 Thread Chen Gang
On 08/07/2013 02:36 AM, Kees Cook wrote: > On Tue, Aug 6, 2013 at 1:00 AM, Chen Gang wrote: >> They are 2 related patches for setfsgid(). >> >> Patch 1 for bug fix: return the current gid when error occurs. >> Patch 2 for cleaning code: remove useless variable 'old_fsgid'. >> >> Signed-off-by:

Re: [PATCH] fs/nfs/inode.c: adjust code alignment

2013-08-06 Thread Dave Quigley
On 8/6/2013 2:04 PM, Steve Dickson wrote: Hello, On 05/08/13 10:59, Myklebust, Trond wrote: On Mon, 2013-08-05 at 16:47 +0200, Julia Lawall wrote: From: Julia Lawall Signed-off-by: Julia Lawall --- This patch adjusts the code so that the alignment matches the current semantics. I have

Re: [PATCH 00/11] Add compression support to pstore

2013-08-06 Thread Aruna Balakrishnaiah
On Wednesday 07 August 2013 05:06 AM, Tony Luck wrote: On Mon, Aug 5, 2013 at 2:20 PM, Tony Luck wrote: Still have problems booting if there are any compressed images in ERST to be inflated. So I took another look at this part of the code ... and saw a couple of issues: while ((size

Re: [PATCH 04/12] KVM: MMU: log dirty page after marking spte writable

2013-08-06 Thread Marcelo Tosatti
On Tue, Jul 30, 2013 at 09:02:02PM +0800, Xiao Guangrong wrote: > Make sure we can see the writable spte before the dirt bitmap is visible > > We do this is for kvm_vm_ioctl_get_dirty_log() write-protects the spte based > on the dirty bitmap, we should ensure the writable spte can be found in

Re: [PATCH v2 RESEND 11/18] x86, acpi: Try to find SRAT in firmware earlier.

2013-08-06 Thread Tang Chen
On 08/07/2013 07:33 AM, Toshi Kani wrote: On Fri, 2013-08-02 at 17:14 +0800, Tang Chen wrote: This patch introduce early_acpi_firmware_srat() to find the phys addr of SRAT provided by firmware. And call it in find_hotpluggable_memory(). Since we have initialized acpi_gbl_root_table_list

Re: [PATCH 17/18] mm, hugetlb: retry if we fail to allocate a hugepage with use_reserve

2013-08-06 Thread Davidlohr Bueso
On Wed, 2013-08-07 at 11:03 +1000, David Gibson wrote: > On Tue, Aug 06, 2013 at 05:18:44PM -0700, Davidlohr Bueso wrote: > > On Mon, 2013-08-05 at 16:36 +0900, Joonsoo Kim wrote: > > > > Any mapping that doesn't use the reserved pool, not just > > > > MAP_NORESERVE. For example, if a process

[PATCH] ARM: dts: Fix memory node in skeleton64.dtsi

2013-08-06 Thread Stepan Moskovchenko
Update the reg property of the memory node in skeleton64.dtsi to reflect the fact that the root node uses address-cells=2 and size-cells=2. Change-Id: Ie9b61166143969e020ceebc51e9a384405d8c0f2 Signed-off-by: Stepan Moskovchenko --- arch/arm/boot/dts/skeleton64.dtsi |2 +- 1 files changed, 1

Re: [PATCH 17/18] mm, hugetlb: retry if we fail to allocate a hugepage with use_reserve

2013-08-06 Thread David Gibson
On Tue, Aug 06, 2013 at 05:18:44PM -0700, Davidlohr Bueso wrote: > On Mon, 2013-08-05 at 16:36 +0900, Joonsoo Kim wrote: > > > Any mapping that doesn't use the reserved pool, not just > > > MAP_NORESERVE. For example, if a process makes a MAP_PRIVATE mapping, > > > then fork()s then the mapping

Re: List corruption in hidraw_release in 3.11-rc4

2013-08-06 Thread Jiri Kosina
On Tue, 6 Aug 2013, Peter Wu wrote: > While debugging upowerd (with Logitech Unifying receiver via hidraw), > I came across this list corruption warning. Peter, does the patch below fix the problem you are seeing? --- drivers/hid/hidraw.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] proc: Add workaround for idle/iowait decreasing problem.

2013-08-06 Thread Frederic Weisbecker
On Tue, Jul 02, 2013 at 07:39:08PM +0900, Fernando Luis Vazquez Cao wrote: > On 2013年07月02日 12:56, Fernando Luis Vazquez Cao wrote: > >Hi Frederic, > > > >I'm sorry it's taken me so long to respond; I got sidetracked for > >a while. Comments follow below. > > > >On 2013/04/28 09:49, Frederic

Re: Performance regression from switching lock to rw-sem for anon-vma tree

2013-08-06 Thread Tim Chen
On Tue, 2013-08-06 at 16:55 -0700, Davidlohr Bueso wrote: > I got good numbers, recovering the performance drop I noticed with the > i_mmap_mutex to rwsem patches. That's good. I remembered that the earlier version of the patch not only recovered the performance drop, but also provide some

[PATCH] regulator: fan53555: Prevent multiple include of fan53555.h

2013-08-06 Thread Axel Lin
Add define for __FAN53555_H__ to prevent multiple include of the header file. Signed-off-by: Axel Lin --- include/linux/regulator/fan53555.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/regulator/fan53555.h b/include/linux/regulator/fan53555.h index 5c45c85..f13880e 100644

Re: [RFC] gcc feature request: Moving blocks into sections

2013-08-06 Thread Steven Rostedt
On Tue, 2013-08-06 at 20:45 -0400, Steven Rostedt wrote: > [3.387362] short jumps: 106 > [3.390277] long jumps: 330 > > Thus, approximately 25%. Not bad. Also, where these happen to be is probably even more important than how many. If all the short jumps happen in slow paths, it's

Re: [PATCH] mm/mempolicy: return NULL if node is NUMA_NO_NODE in get_task_policy

2013-08-06 Thread Jianguo Wu
Hi Andrew, On 2013/8/7 5:03, Andrew Morton wrote: > On Tue, 6 Aug 2013 12:06:56 +0800 Jianguo Wu wrote: > >> If node == NUMA_NO_NODE, pol is NULL, we should return NULL instead of >> do "if (!pol->mode)" check. >> >> Signed-off-by: Jianguo Wu >> --- >> mm/mempolicy.c | 2 ++ >> 1 file

Re: [PATCH aio-next] aio: fix error handling and rcu usage in "convert the ioctx list to table lookup v3"

2013-08-06 Thread Benjamin LaHaise
On Tue, Aug 06, 2013 at 05:57:32PM -0400, Sasha Levin wrote: > Old error is gone, but now seeing this, which seems related. > > ctx = table->table[id]; > if (ctx->user_id == ctx_id) { <--- here > percpu_ref_get(>users); > ret = ctx; > } ...

Re: acpi_bus_trim does not detach devices in post order

2013-08-06 Thread Rafael J. Wysocki
On Wednesday, August 07, 2013 09:35:51 AM Yasuaki Ishimatsu wrote: > (2013/08/06 23:26), Rafael J. Wysocki wrote: > > On Tuesday, August 06, 2013 07:06:37 PM Yasuaki Ishimatsu wrote: > >> (2013/08/06 12:07), Yasuaki Ishimatsu wrote: > >>> > >>> I acked the following commit but I hit a problem by

Re: [RFC] gcc feature request: Moving blocks into sections

2013-08-06 Thread Steven Rostedt
On Tue, 2013-08-06 at 16:43 -0400, Steven Rostedt wrote: > On Tue, 2013-08-06 at 16:33 -0400, Mathieu Desnoyers wrote: > > > Steve, perhaps you could add a mode to your binary rewriting program > > that counts the number of 2-byte vs 5-byte jumps found, and if possible > > get a breakdown of

Re: acpi_bus_trim does not detach devices in post order

2013-08-06 Thread Yasuaki Ishimatsu
(2013/08/06 23:26), Rafael J. Wysocki wrote: On Tuesday, August 06, 2013 07:06:37 PM Yasuaki Ishimatsu wrote: (2013/08/06 12:07), Yasuaki Ishimatsu wrote: I acked the following commit but I hit a problem by the commit. So I report it. commit cecdb193c8d91a42d9489d00618cc3dfff92e55a Author:

Re: [systemd-devel] [PATCH] Change CONFIG_FW_LOADER_USER_HELPER to default n and don't select it

2013-08-06 Thread Andy Lutomirski
On Tue, Aug 6, 2013 at 5:24 PM, Tom Gundersen wrote: > > On 6 Aug 2013 18:32, "Bryan Kadzban" wrote: >> >> On Tue, Aug 06, 2013 at 11:17:17AM +0200, Tom Gundersen wrote: >> > On Tue, Aug 6, 2013 at 11:11 AM, Tom Gundersen wrote: >> > > On Tue, Aug 6, 2013 at 10:20 AM, Maarten Lankhorst >> > >

Re: [PATCH 17/18] mm, hugetlb: retry if we fail to allocate a hugepage with use_reserve

2013-08-06 Thread Davidlohr Bueso
On Mon, 2013-08-05 at 16:36 +0900, Joonsoo Kim wrote: > > Any mapping that doesn't use the reserved pool, not just > > MAP_NORESERVE. For example, if a process makes a MAP_PRIVATE mapping, > > then fork()s then the mapping is instantiated in the child, that will > > not draw from the reserved

Re: [PATCH] proc: Add workaround for idle/iowait decreasing problem.

2013-08-06 Thread Frederic Weisbecker
On Tue, Jul 02, 2013 at 12:56:04PM +0900, Fernando Luis Vazquez Cao wrote: > Hi Frederic, > > I'm sorry it's taken me so long to respond; I got sidetracked for > a while. Comments follow below. > > On 2013/04/28 09:49, Frederic Weisbecker wrote: > >On Tue, Apr 23, 2013 at 09:45:23PM +0900,

Re: [PATCH] block: support embedded device command line partition

2013-08-06 Thread Andrew Morton
On Tue, 6 Aug 2013 10:53:01 + Caizhiyong wrote: > > -Original Message- > > From: Andrew Morton [mailto:a...@linux-foundation.org] > > Sent: Tuesday, August 06, 2013 6:22 AM > > To: Caizhiyong > > Cc: Karel Zak; linux-kernel@vger.kernel.org; Wanglin (Albert); Quyaxin; > > Jens Axboe;

Re: [PATCH V2 00/11] CPUFreq: Fixes & Cleanups for 3.12

2013-08-06 Thread Rafael J. Wysocki
On Tuesday, August 06, 2013 10:53:02 PM Viresh Kumar wrote: > Hi Rafael, > > This is V2 of the patch series which was posted here earlier: > > http://www.gossamer-threads.com/lists/linux/kernel/1759514 > > This patchset tries to fix & cleanup many existing cpufreq core issues. First > four

Re: [PATCH 0/2] hugepage: optimize page fault path locking

2013-08-06 Thread Davidlohr Bueso
On Mon, 2013-07-29 at 15:18 +0900, Joonsoo Kim wrote: > On Fri, Jul 26, 2013 at 07:27:23AM -0700, Davidlohr Bueso wrote: > > This patchset attempts to reduce the amount of contention we impose > > on the hugetlb_instantiation_mutex by replacing the global mutex with > > a table of mutexes,

Re: [PATCH] MAINTAINERS: drivers/power: add entry for SmartReflex AVS drivers

2013-08-06 Thread Rafael J. Wysocki
On Tuesday, August 06, 2013 04:58:05 PM Kevin Hilman wrote: > "Rafael J. Wysocki" writes: > > > On Monday, August 05, 2013 09:29:19 AM Kevin Hilman wrote: > >> The SmartReflex AVS driver evolved out of the OMAP kernel and now > >> lives under drivers/power/avs. > >> > >> I've historically been

Re: [PATCH] mutex: fix deadlock injection

2013-08-06 Thread Dave Airlie
On Tue, Jul 30, 2013 at 6:41 PM, Peter Zijlstra wrote: > On Tue, Jul 30, 2013 at 10:13:41AM +0200, Maarten Lankhorst wrote: >> The check needs to be for > 1, because ctx->acquired is already incremented. >> This will prevent ww_mutex_lock_slow from returning -EDEADLK and not locking >> the mutex.

Re: [PATCH] pktcdvd: Fix defective misuses of pkt_

2013-08-06 Thread Jiri Kosina
On Tue, 6 Aug 2013, Andrew Morton wrote: > > Andrew, I believe Jiri picked up this series and > > you can drop them from mm. Thanks. > > Shall do if/when they turn up in linux-next. Pull request to Jens is there [1], but his branch has been silent for two weeks ... [1]

Re: [PATCH] MAINTAINERS: drivers/power: add entry for SmartReflex AVS drivers

2013-08-06 Thread Kevin Hilman
"Rafael J. Wysocki" writes: > On Monday, August 05, 2013 09:29:19 AM Kevin Hilman wrote: >> The SmartReflex AVS driver evolved out of the OMAP kernel and now >> lives under drivers/power/avs. >> >> I've historically been maintainer of this but Nishanth Menon is doing >> most of the heavy

Re: [PATCH] MAINTAINERS: drivers/power: add entry for SmartReflex AVS drivers

2013-08-06 Thread Kevin Hilman
Anton Vorontsov writes: > On Mon, Aug 05, 2013 at 09:29:37AM -0700, Kevin Hilman wrote: >> The SmartReflex AVS driver evolved out of the OMAP kernel and now >> lives under drivers/power/avs. >> >> I've historically been maintainer of this but Nishanth Menon is doing >> most of the heavy lifting

Re: Performance regression from switching lock to rw-sem for anon-vma tree

2013-08-06 Thread Davidlohr Bueso
On Mon, 2013-07-29 at 17:13 -0700, Tim Chen wrote: > On Tue, 2013-07-23 at 11:53 +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > > > On Tue, Jul 23, 2013 at 11:45:13AM +0200, Ingo Molnar wrote: > > > > > > > Why not just try the delayed addition approach first? The spinning is > > >

Re: [PATCH] pinctrl: msm: Add support for MSM TLMM pinmux

2013-08-06 Thread Hanumant Singh
On 7/31/2013 5:17 PM, Hanumant Singh wrote: On 7/31/2013 2:06 PM, Stephen Warren wrote: On 07/31/2013 01:46 PM, Hanumant Singh wrote: On 7/30/2013 8:59 PM, Stephen Warren wrote: On 07/30/2013 06:13 PM, Hanumant Singh wrote: On 7/30/2013 5:08 PM, Stephen Warren wrote: On 07/30/2013 06:01 PM,

Re: [PATCH V2 5/6] cpuidle/powerpc: Backend-powerpc idle driver for powernv and pseries.

2013-08-06 Thread Scott Wood
On Wed, 2013-08-07 at 09:30 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2013-08-06 at 18:08 -0500, Scott Wood wrote: > > Here's another example. get_lppaca() will only build on book3s -- and > > yet we get requests for e500 code to use this file. > > Indeed, Besides there is already accessors

Re: [PATCH 1/1] module: fix sprintf format specifier in param_get_byte()

2013-08-06 Thread Joe Perches
On Tue, 2013-08-06 at 23:12 +0200, Christoph Jaeger wrote: > In param_get_byte(), to which the macro STANDARD_PARAM_DEF(byte, ...) expands, > "%c" is used to print an unsigned char. So it gets printed as a character what > is not intended here. Use "%hhu" instead. > > Signed-off-by: Christoph

Re: [PATCH 00/11] Add compression support to pstore

2013-08-06 Thread Tony Luck
On Mon, Aug 5, 2013 at 2:20 PM, Tony Luck wrote: > Still have problems booting if there are any compressed images in ERST > to be inflated. So I took another look at this part of the code ... and saw a couple of issues: while ((size = psi->read(, , , , , ,

  1   2   3   4   5   6   7   8   9   10   >