[PATCH v3 05/36] hrtimer: Fix hrtimer function description

2017-11-29 Thread Anna-Maria Gleixner
The hrtimer_start[_range_ns]() starts a timer reliable on this CPU only when HRTIMER_MODE_PINNED is set. Furthermore the HRTIMER_MODE_PINNED mode is not considered, when a hrtimer is initialized. Signed-off-by: Anna-Maria Gleixner --- include/linux/hrtimer.h | 6 +++--- kernel/time/hrtimer.c |

[PATCH v3 03/36] hrtimer: Fix kerneldoc for struct hrtimer_cpu_base

2017-11-29 Thread Anna-Maria Gleixner
The sequence '/**' marks the start of a struct description. Add the missing second asterisk. While at it adapt the ordering of the struct members to the struct definition and document the purpose of expires_next more precisely. Signed-off-by: Anna-Maria Gleixner --- include/linux/hrtimer.h | 8 +

[PATCH v3 08/36] tracing/hrtimer: Take all clock bases and modes into account

2017-11-29 Thread Anna-Maria Gleixner
So far only CLOCK_MONOTONIC and CLOCK_REALTIME were taken into account as well as HRTIMER_MODE_ABS/REL in hrtimer_init tracepoint. The query for detecting timer mode ABS or REL is not valid, since the introduction of HRTIMER_MODE_PINNED. HRTIMER_MODE_PINNED is not evaluated in hrtimer_init() call.

[PATCH v3 07/36] hrtimer: Cleanup hrtimer_mode enum

2017-11-29 Thread Anna-Maria Gleixner
It's not obvious that the HRTIMER_MODE variants are bit combinations because all modes are hard coded constants. Change it so the bit meanings are clear and use the symbols for creating modes which combine bits. While at it get rid of the ugly tail comments. Signed-off-by: Anna-Maria Gleixner -

[PATCH v3 10/36] hrtimer: Switch for loop to _ffs() evaluation

2017-11-29 Thread Anna-Maria Gleixner
Looping over all clock bases to find active bits is suboptimal if not all bases are active. Avoid this by converting it to a __ffs() evaluation. The functionallity is outsourced into an own function and is called via a macro as suggested by Peter Zijlstra. Suggested-by: Peter Zijlstra Signed-off

[PATCH v3 09/36] tracing/hrtimer: Print hrtimer mode in hrtimer_start tracepoint

2017-11-29 Thread Anna-Maria Gleixner
The hrtimer_start tracepoint lacks the mode information. The mode is important because consecutive starts can switch from ABS to REL or from PINNED to non PINNED. Add the mode information. Signed-off-by: Anna-Maria Gleixner --- include/trace/events/timer.h | 13 - kernel/time/hrtime

[PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-29 Thread Daniel Vetter
cross-release ftl >From Chris: "Fwiw, this isn't cross-release but us reloading the module many times, creating a whole host of new lockclasses. Even more fun is when the module gets a slightly different address and the new lock address hashes into an old lock... "I did think about a module-hook

Re: [PATCH v1] USB: storage: Notify the subdrivers that they need to reinitialize the device.

2017-11-29 Thread Alan Stern
On Wed, 29 Nov 2017, Mikhail Zaytsev wrote: > This patch adds the device_reinit function into the us_data structure. > The usb-storage driver uses this function for notify the subdrivers that > they need to reinitialize the device. > > Signed-off-by: Mikhail Zaytsev I'd feel more inclined to a

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

2017-11-29 Thread Chen-Yu Tsai
On Wed, Nov 29, 2017 at 11:37 PM, Andrew Lunn wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: >> On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: >> > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: >> > > The driver expect "allwinner,leds-activ

[PATCH 0/2] lockdep cross-release fallout from -rc1

2017-11-29 Thread Daniel Vetter
Hi all, -rc1 set our CI on fire with a pile of issues that cross-release highlights. The two patches in this series get things back into working order on our side, so we pulled them into our local branches to unblock CI and drm/i915. But they're ofc far from polished, so pls look at this more as

[PATCH 1/2] lockdep: finer-grained completion key for kthread

2017-11-29 Thread Daniel Vetter
Ideally we'd create the key through a macro at the real callers and pass it all the way down. This would give us better coverage for cases where a bunch of kthreads are created for the same thing. But this gets the job done meanwhile and unblocks our CI. Refining later on is always possible. v2: -

[PATCH v3 13/36] hrtimer: Reduce conditional code (hres_active)

2017-11-29 Thread Anna-Maria Gleixner
The hrtimer_cpu_base struct has the CONFIG_HIGH_RES_TIMERS conditional struct member hres_active. All related functions to this member are conditional as well. There is no functional change, when the hres_active member is unconditional with all related functions and is set to zero during initializ

[PATCH v3 14/36] hrtimer: Use accesor functions instead of direct access

2017-11-29 Thread Anna-Maria Gleixner
__hrtimer_hres_active() is now available unconditionally. Replace the direct access to hrtimer_cpu_base.hres_active. No functional change. Signed-off-by: Anna-Maria Gleixner --- kernel/time/hrtimer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/time/hrtimer.c b

[PATCH v3 15/36] hrtimer: Make the remote enqueue check unconditional

2017-11-29 Thread Anna-Maria Gleixner
hrtimer_cpu_base.expires_next is used to cache the next event armed in the timer hardware. The value is used to check whether an hrtimer can be enqueued remotely. If the new hrtimer is expiring before expires_next, then remote enqueue is not possible as the remote hrtimer hardware cannot be accesse

[PATCH v3 16/36] hrtimer: Make hrtimer_cpu_base.next_timer handling unconditional

2017-11-29 Thread Anna-Maria Gleixner
hrtimer_cpu_base.next_timer stores the pointer to the next expiring timer in a cpu base. This pointer cannot be dereferenced and is solely used to check whether a hrtimer which is removed is the hrtimer which is the first to expire in the CPU base. If this is the case, then the timer hardware need

[PATCH v3 11/36] hrtimer: Store running timer in hrtimer_clock_base

2017-11-29 Thread Anna-Maria Gleixner
The pointer to the currently running timer is stored in hrtimer_cpu_base before the base lock is dropped and the callback is invoked. This results in two levels of indirections and the upcoming support for softirq based hrtimer requires splitting the "running" storage into soft and hard irq contex

[PATCH v3 20/36] hrtimer: Unify handling of remote enqueue

2017-11-29 Thread Anna-Maria Gleixner
hrtimer_reprogram() is conditionally invoked from hrtimer_start_range_ns() when hrtimer_cpu_base.hres_active is true. In the !hres_active case there is a special condition for the nohz_active case: If the newly enqueued timer expires before the first expiring timer on a remote CPU then the re

[GIT] Networking

2017-11-29 Thread David Miller
There is a small overlapping conflict to net/rxrpc/call_object.c, it should be easy to resolve. In your tree there was a setup_timer() --> timer_setup() conversion, and in my tree there are new lines adding a lockdep_set_class() call right beforehand. 1) The forcedeth conversion from pci_*() DMA

[PATCH v3 17/36] hrtimer: Make hrtimer_reprogramm() unconditional

2017-11-29 Thread Anna-Maria Gleixner
hrtimer_reprogram() needs to be available unconditionally for softirq based hrtimers. Move the function and all required struct members out of the CONFIG_HIGH_RES_TIMERS #ifdef. There is no functional change because hrtimer_reprogram() is only invoked when hrtimer_cpu_base.hres_active is true. Mak

[PATCH v3 19/36] hrtimer: Unify handling of hrtimer remove

2017-11-29 Thread Anna-Maria Gleixner
When the first hrtimer on the current CPU is removed, hrtimer_force_reprogram() is invoked but only when CONFIG_HIGH_RES_TIMERS=y and hrtimer_cpu_base.hres_active is set. hrtimer_force_reprogram() updates hrtimer_cpu_base.expires_next and reprograms the clock event device. When CONFIG_HIGH_RES_TIM

[PATCH v3 21/36] hrtimer: Make remote enqueue decision less restrictive

2017-11-29 Thread Anna-Maria Gleixner
The current decision whether a timer can be queued on a remote CPU checks for timer->expiry <= remote_cpu_base.expires_next. This is too restrictive because a timer with the same expiry time as an existing timer will be enqueued on right-hand size of the existing timer inside the rbtree, i.e. behi

Re: UFS utilities

2017-11-29 Thread Bean Huo (beanhuo)
Hi, Greg >On Mon, Nov 27, 2017 at 11:25:47AM +, Bean Huo (beanhuo) wrote: >> Hi, all >> Is there someone knows if exists one utilis dedicated to UFS device, rather >than SCSI utils? >> I have tried sg3-utils, but it is not convenient for the embedded ARM-based >system. >> And also it doesn't s

[PATCH v3 22/36] hrtimer: Remove base argument from hrtimer_reprogram()

2017-11-29 Thread Anna-Maria Gleixner
hrtimer_reprogram() must have access to the hrtimer_clock_base of the new first expiring timer to access hrtimer_clock_base.offset for adjusting the expiry time to CLOCK_MONOTONIC. This is required to evaluate whether the new left most timer in the hrtimer_clock_base is the first expiring timer of

Re: [PATCH net-next 0/3] rxrpc: Fixes

2017-11-29 Thread David Miller
> The patches can be found here also: > > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-fixes-20171129 This e

Re: [PATCH v6 04/11] x86: define IA32_FEATUE_CONTROL.SGX_LC

2017-11-29 Thread Jarkko Sakkinen
On Wed, Nov 29, 2017 at 12:21:41AM +0200, Jarkko Sakkinen wrote: > On Tue, Nov 28, 2017 at 02:00:03PM -0800, Sean Christopherson wrote: > > What about SGX_LC_ENABLE?  The title in the MSR section of the SDM is > > "SGX Launch Control Enable", and it's more consistent with the other > > bits defined

[PATCH v3 25/36] hrtimer: Use irqsave/irqrestore around __run_hrtimer()

2017-11-29 Thread Anna-Maria Gleixner
__run_hrtimer() is called with the hrtimer_cpu_base.lock held and interrupts disabled. Before invoking the timer callback the base lock is dropped, but interrupts stay disabled. The upcoming support for softirq based hrtimers requires that interrupts are enabled before the timer callback is invoke

[PATCH v3 18/36] hrtimer: Make hrtimer_force_reprogramm() unconditionally available

2017-11-29 Thread Anna-Maria Gleixner
hrtimer_force_reprogram() needs to be available unconditionally for softirq based hrtimers. Move the function and all required struct members out of the CONFIG_HIGH_RES_TIMERS #ifdef. There is no functional change because hrtimer_force_reprogram() is only invoked when hrtimer_cpu_base.hres_active

[PATCH v3 24/36] hrtimer: Split __hrtimer_get_next_event()

2017-11-29 Thread Anna-Maria Gleixner
Preparatory patch for softirq based hrtimers to avoid code duplication. No functional change. Signed-off-by: Anna-Maria Gleixner --- kernel/time/hrtimer.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c index

[PATCH v3 23/36] hrtimer: Split hrtimer_start_range_ns()

2017-11-29 Thread Anna-Maria Gleixner
Preparatory patch for softirq based hrtimers to avoid code duplication. No functional change. Signed-off-by: Anna-Maria Gleixner --- kernel/time/hrtimer.c | 44 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/kernel/time/hrtimer.c b/ke

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

2017-11-29 Thread Andrew Lunn
On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: > On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > > the binding doc expect

Re: [Xen-devel] [PATCH V2] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Govinda Tatti
Jan, Please see below for my comments. On 11/9/2017 2:49 AM, Jan Beulich wrote: On 09.11.17 at 00:06, wrote: --- a/drivers/xen/xen-pciback/pci_stub.c +++ b/drivers/xen/xen-pciback/pci_stub.c @@ -244,6 +244,91 @@ struct pci_dev *pcistub_get_pci_dev(struct xen_pcibk_device *pdev, retur

[PATCH v3 26/36] hrtimer: Add clock bases and hrtimer mode for soft irq context

2017-11-29 Thread Anna-Maria Gleixner
hrtimer callback functions are always executed in hard interrupt context. Users of hrtimer which need their timer function to be executed in soft interrupt context, make use of tasklets to get the proper context. Add additional hrtimer clock bases for timers which must expire in softirq context, s

[PATCH v3 27/36] hrtimer: Prepare handling of hard and softirq based hrtimers

2017-11-29 Thread Anna-Maria Gleixner
The softirq based hrtimer can utilize most of the existing hrtimers functions, but need to operate on a different data set. Add an active_mask argument to various functions so the hard and soft bases can be selected. Fixup the existing callers and hand in the ACTIVE_HARD mask. Signed-off-by: Anna

Re: [linux-sunxi] Cedrus driver

2017-11-29 Thread Thomas van Kleef
Hi Maxime, > > So there's a couple of issues with those patches (the pull request > itself is fine though :)) > > I'll try to break them down as much as possible. > > A) If you want to have proper commit logs, you will usually do two >things: first create a commit title, which is what appear

Re: [PATCH v8 1/6] lib/dlock-list: Distributed and lock-protected lists

2017-11-29 Thread Davidlohr Bueso
On Tue, 31 Oct 2017, Waiman Long wrote: Linked list is used everywhere in the Linux kernel. However, if many threads are trying to add or delete entries into the same linked list, it can create a performance bottleneck. This patch introduces a new list APIs that provide a set of distributed lis

[PATCH v3 29/36] hrtimer: Implement SOFT/HARD clock base selection

2017-11-29 Thread Anna-Maria Gleixner
All prerequisites to handle hrtimers for expiry in either hard or soft interrupt context are in place. Add the missing bit in hrtimer_init() which associates the timer to the hard or the soft irq clock base. Signed-off-by: Anna-Maria Gleixner --- kernel/time/hrtimer.c | 15 +++ 1 fi

[PATCH v3 34/36] ALSA/dummy: Replace tasklet with softirq hrtimer

2017-11-29 Thread Anna-Maria Gleixner
From: Thomas Gleixner The tasklet is used to defer the execution of snd_pcm_period_elapsed() to the softirq context. Using the HRTIMER_MODE_SOFT mode invokes the timer callback in softirq context as well which renders the tasklet useless. [o-takashi: avoid stall due to a call of hrtimer_cancel()

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Jan Beulich
>>> On 29.11.17 at 16:08, wrote: > On 11/9/2017 2:28 AM, Jan Beulich wrote: > On 08.11.17 at 16:44, wrote: >>> On 11/7/2017 8:40 AM, Jan Beulich wrote: >>> On 06.11.17 at 18:48, wrote: > --- a/Documentation/ABI/testing/sysfs-driver-pciback > +++ b/Documentation/ABI/testing/sysfs-

[PATCH v3 33/36] softirq: Remove tasklet_hrtimer

2017-11-29 Thread Anna-Maria Gleixner
From: Thomas Gleixner There are no more tasklet_hrtimer users of this interface. Remove it. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner --- include/linux/interrupt.h | 25 --- kernel/softirq.c | 51

[PATCH] zswap: Update with same-value filled page feature

2017-11-29 Thread Srividya Desireddy
From: Srividya Desireddy Date: Wed, 29 Nov 2017 20:23:15 +0530 Subject: [PATCH] zswap: Update with same-value filled page feature Updated zswap document with details on same-value filled pages identification feature. The usage of zswap.same_filled_pages_enabled module parameter is explained. Sig

[PATCH net 3/3] rxrpc: Fix variable overwrite

2017-11-29 Thread David Howells
From: Gustavo A. R. Silva Values assigned to both variable resend_at and ack_at are overwritten before they can be used. The correct fix here is to add 'now' to the previously computed value in resend_at and ack_at. Addresses-Coverity-ID: 1462262 Addresses-Coverity-ID: 1462263 Addresses-Coverit

[PATCH net 2/3] rxrpc: Fix ACK generation from the connection event processor

2017-11-29 Thread David Howells
Repeat terminal ACKs and now terminal ACKs are now generated from the connection event processor rather from call handling as this allows us to discard client call structures as soon as possible and free up the channel for a follow on call. However, in ACKs so generated, the additional information

[PATCH net 1/3] rxrpc: Clean up whitespace

2017-11-29 Thread David Howells
Clean up some whitespace from rxrpc. Signed-off-by: David Howells --- net/rxrpc/call_event.c |2 +- net/rxrpc/conn_object.c |2 +- net/rxrpc/input.c |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index b

[PATCH v3 36/36] net/mvpp2: Replace tasklet with softirq hrtimer

2017-11-29 Thread Anna-Maria Gleixner
From: Thomas Gleixner The tx_done_tasklet tasklet is used in invoke the hrtimer (mvpp2_hr_timer_cb) in softirq context. This can be also achieved without the tasklet but with HRTIMER_MODE_SOFT as hrtimer mode. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Cc: Thomas Petazzo

[PATCH net-next 0/3] rxrpc: Fixes

2017-11-29 Thread David Howells
/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20171129 David --- David Howells (2): rxrpc: Clean up whitespace rxrpc: Fix ACK generation from the connection event processor

[PATCH v3 35/36] usb/gadget/NCM: Replace tasklet with softirq hrtimer

2017-11-29 Thread Anna-Maria Gleixner
From: Thomas Gleixner The tx_tasklet tasklet is used in invoke the hrtimer (task_timer) in softirq context. This can be also achieved without the tasklet but with HRTIMER_MODE_SOFT as hrtimer mode. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Cc: Felipe Balbi Cc: linux-..

[PATCH v3 32/36] xfrm: Replace hrtimer tasklet with softirq hrtimer

2017-11-29 Thread Anna-Maria Gleixner
From: Thomas Gleixner Switch the timer to HRTIMER_MODE_SOFT, which executed the timer callback in softirq context and remove the hrtimer_tasklet. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Cc: Steffen Klassert Cc: net...@vger.kernel.org Cc: Herbert Xu Cc: "David S. Mil

[PATCH v3 12/36] hrtimer: Make room in struct hrtimer_cpu_base

2017-11-29 Thread Anna-Maria Gleixner
The upcoming softirq based hrtimers support requires an additional field in the hrtimer_cpu_base struct, which would grow the struct size beyond a cache line. The struct members nr_retries and nr_hangs of hrtimer_cpu_base are solely used for diagnostic output and have no requirement to be unsigned

[PATCH v3 28/36] hrtimer: Implement support for softirq based hrtimers

2017-11-29 Thread Anna-Maria Gleixner
hrtimer callbacks are always invoked in hard interrupt context. Several users in tree require soft interrupt context for their callbacks and achieve this by combining a hrtimer with a tasklet. The hrtimer schedules the tasklet in hard interrupt context and the tasklet callback gets invoked in softi

[PATCH v3 30/36] can/bcm: Replace hrtimer_tasklet with softirq based hrtimer

2017-11-29 Thread Anna-Maria Gleixner
From: Thomas Gleixner Switch the timer to HRTIMER_MODE_SOFT, which executed the timer callback in softirq context and remove the hrtimer_tasklet. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Acked-by: Oliver Hartkopp Cc: Oliver Hartkopp Cc: Marc Kleine-Budde Cc: linux-.

[PATCH v3 31/36] mac80211_hwsim: Replace hrtimer tasklet with softirq hrtimer

2017-11-29 Thread Anna-Maria Gleixner
From: Thomas Gleixner Switch the timer to HRTIMER_MODE_SOFT, which executed the timer callback in softirq context and remove the hrtimer_tasklet. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Cc: linux-wirel...@vger.kernel.org Cc: Johannes Berg Cc: Kalle Valo --- drivers

Re: [PATCH v8 0/6] vfs: Use dlock list for SB's s_inodes list

2017-11-29 Thread Waiman Long
On 11/29/2017 10:26 AM, Davidlohr Bueso wrote: > Are you planning on sending a v9 with the discussed changes? afaict: > > - Drop last two patches > - Fix tearing (WRITE/READ_ONCE()) > - Reduce barrier usage for dlock_lists_empty() -- which I'll be sending > you shortly. > > Thanks, > Davidlohr Y

Re: [PATCH net,stable v2] vhost: fix skb leak in handle_rx()

2017-11-29 Thread Michael S. Tsirkin
On Wed, Nov 29, 2017 at 09:23:24AM -0500, w...@redhat.com wrote: > From: Wei Xu > > Matthew found a roughly 40% tcp throughput regression with commit > c67df11f(vhost_net: try batch dequing from skb array) as discussed > in the following thread: > https://www.mail-archive.com/netdev@vger.kernel.o

Re: [PATCH v8 0/6] vfs: Use dlock list for SB's s_inodes list

2017-11-29 Thread Davidlohr Bueso
Are you planning on sending a v9 with the discussed changes? afaict: - Drop last two patches - Fix tearing (WRITE/READ_ONCE()) - Reduce barrier usage for dlock_lists_empty() -- which I'll be sending you shortly. Thanks, Davidlohr On Tue, 31 Oct 2017, Waiman Long wrote: v7->v8: - Integrate th

Re: [kernel-hardening] Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-29 Thread Geo Kozey
> From: Linus Torvalds > Sent: Wed Nov 29 01:17:05 CET 2017 > To: Geo Kozey > Subject: Re: [kernel-hardening] Re: [PATCH v5 next 5/5] net: modules: use > request_module_cap() to load 'netdev-%s' modules > > > On Tue, Nov 28, 2017 at 3:51 PM, Linus Torvalds > wrote: > > > > So a patch that avo

[PATCH] ARC: Enable machine_desc->init_per_cpu for non-SMP configs

2017-11-29 Thread Alexey Brodkin
As of today we assumed that "machine_desc->init_per_cpu" calls are only usable on SMP systems when we want to run some piece of code on early boot for each and every core, I guess assumption was we have "machine_desc->init_early" for single-core cases where the one and only master core can do all t

Re: [PATCH 13/17] drm/sun4i: Add DE2 CSC library

2017-11-29 Thread Maxime Ripard
On Tue, Nov 28, 2017 at 10:43:39PM +0100, Jernej Škrabec wrote: > Hi! > > Dne torek, 28. november 2017 ob 21:55:50 CET je Maxime Ripard napisal(a): > > On Mon, Nov 27, 2017 at 09:57:46PM +0100, Jernej Skrabec wrote: > > > DE2 have many CSC units - channel input CSC, channel output CSC and > > > mi

Re: [PATCH] x86/mm/kaiser: Flush the correct ASID in __native_flush_tlb_single()

2017-11-29 Thread Peter Zijlstra
On Wed, Nov 29, 2017 at 07:21:23AM -0800, Dave Hansen wrote: > Yes, that works. Also, as I think about it, INVLPG is a safer > (bug-resistant) instruction to use too. INVPCID _can_ get the current > (kernel) ASID wrong, as we saw. But INVLPG always uses the current one > and can't be wrong about

[PATCH v3] arch: arm: mach-stm32: Fix copyright

2017-11-29 Thread Benjamin Gaignard
Uniformize STMicroelectronics copyrights header Add SPDX identifier Signed-off-by: Benjamin Gaignard --- arch/arm/mach-stm32/board-dt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm32/board-dt.c index e918686e4191..77899ae4b8ed 100644 --

Re: [PATCH v2 27/35] irqchip: Andestech Internal Vector Interrupt Controller driver

2017-11-29 Thread Greentime Hu
Hi, Marc: 2017-11-28 17:37 GMT+08:00 Marc Zyngier : > On 27/11/17 12:28, Greentime Hu wrote: >> +static void ativic32_ack_irq(struct irq_data *data) >> +{ >> + __nds32__mtsr_dsb(1 << data->hwirq, NDS32_SR_INT_PEND2); > > Consider writing (1 << data->hwirq) as BIT(data->hwirq). Thanks for this

[PATCH 4/5] MIPS: Execute any partial write of the last register with PTRACE_SETREGSET

2017-11-29 Thread Maciej W. Rozycki
Fix a commit d614fd58a283 ("mips/ptrace: Preserve previous registers for short regset write") bug and allow the last register requested with a ptrace(2) PTRACE_SETREGSET call to be partially written if supplied this way by the caller, like with other register sets. Cc: sta...@vger.kernel.org #

[PATCH 5/5] MIPS: Disallow outsized PTRACE_SETREGSET NT_PRFPREG regset accesses

2017-11-29 Thread Maciej W. Rozycki
Complement commit c23b3d1a5311 ("MIPS: ptrace: Change GP regset to use correct core dump register layout") and also reject outsized PTRACE_SETREGSET requests to the NT_PRFPREG regset, like with the NT_PRSTATUS regset. Cc: sta...@vger.kernel.org # v3.17+ Fixes: c23b3d1a5311 ("MIPS: ptrace: Chang

Re: drm/amd/display: Restructuring and cleaning up DML

2017-11-29 Thread Harry Wentland
On 2017-11-28 10:34 PM, Cheng, Tony wrote: > That code is to handle NAN (not a number) in float. Unfortunately our HW > architect decided NAN is one of the way to determine if something isn't > supported. We have feed this back to our HW team and they will look into > improving this for next n

Re: [PATCH] perf annotate: Fix objdump comment parsing for Intel mov dissassembly

2017-11-29 Thread Ravi Bangoria
On 11/29/2017 08:33 PM, Thomas-Mich Richter wrote: > On 11/29/2017 02:24 PM, Ravi Bangoria wrote: >> >> On 11/28/2017 01:26 PM, Thomas Richter wrote: >>> The command 'perf annotate' parses the output of objdump and also >>> investigates the comments produced by objdump. For example the >>> output

Re: [PATCH] x86/mm/kaiser: Flush the correct ASID in __native_flush_tlb_single()

2017-11-29 Thread Dave Hansen
On 11/29/2017 06:35 AM, Peter Zijlstra wrote: >> @@ -451,6 +474,9 @@ static inline void __native_flush_tlb_si >> if (kern_asid(loaded_mm_asid) != user_asid(loaded_mm_asid)) >> invpcid_flush_one(user_asid(loaded_mm_asid), addr); >> invpcid_flush_one(kern_asid(loaded_mm_asid),

[PATCH 3/3] drm/ttm: Fix comment syntax

2017-11-29 Thread Will Deacon
"/**" identifies a kerneldoc comment, so avoid using it for comments that don't conform to kerneldoc syntax. Without this patch, kerneldoc throws errors when building the kernel with W=1. Cc: David Airlie Cc: Thomas Hellstrom Signed-off-by: Will Deacon --- drivers/gpu/drm/ttm/ttm_object.c | 2

[PATCH 2/5] MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA

2017-11-29 Thread Maciej W. Rozycki
Fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset") public API regression, then activated by commit 1db1af84d6df ("MIPS: Basic MSA context switching support"), that caused the FCSR register not to be read or written for CONFIG_CPU_HAS_MSA kernel configurations (re

[PATCH 3/5] MIPS: Also verify sizeof `elf_fpreg_t' with PTRACE_SETREGSET

2017-11-29 Thread Maciej W. Rozycki
Complement commit d614fd58a283 ("mips/ptrace: Preserve previous registers for short regset write") and like with the PTRACE_GETREGSET ptrace(2) request also apply a BUILD_BUG_ON check for the size of the `elf_fpreg_t' type in the PTRACE_SETREGSET request handler. Cc: sta...@vger.kernel.org # v4

[PATCH 1/3] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none

2017-11-29 Thread Will Deacon
My bisect scripts starting running into build failures when trying to compile 4.15-rc1 with the builds failing with things like: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! The line in question is actually just a #define, but after some digg

[PATCH 2/3] brcmfmac: Fix comment syntax

2017-11-29 Thread Will Deacon
"/**" identifies a kerneldoc comment, so avoid using it for comments that don't conform to kerneldoc syntax. Without this patch, kerneldoc throws errors when building the kernel with W=1. Cc: Arend van Spriel Cc: Franky Lin Signed-off-by: Will Deacon --- drivers/net/wireless/broadcom/brcm80211

Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE

2017-11-29 Thread Rasmus Villemoes
On 2017-11-29 15:42, Michal Hocko wrote: > > The first patch introduced MAP_FIXED_SAFE which enforces the given > address but unlike MAP_FIXED it fails with ENOMEM if the given range > conflicts with an existing one. [s/ENOMEM/EEXIST/, as it seems you also did in the actual patch and changelog]

[PATCH 1/5] MIPS: Factor out NT_PRFPREG regset access helpers

2017-11-29 Thread Maciej W. Rozycki
In preparation to fix a commit 72b22bbad1e7 ("MIPS: Don't assume 64-bit FP registers for FP regset") FCSR access regression factor out NT_PRFPREG regset access helpers for the non-MSA and the MSA variants respectively, to avoid having to deal with excessive indentation in the actual fix. No fun

Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record()

2017-11-29 Thread Vladislav Valtchev
On Wed, 2017-11-29 at 09:53 -0500, Steven Rostedt wrote: > On Tue, 28 Nov 2017 20:17:46 +0200 > Vladislav Valtchev wrote: > > > On Tue, 2017-11-28 at 11:48 -0500, Steven Rostedt wrote: > > > > > > Is there a reason that init_instance() isn't called in > > > init_common_record_context()? > > >

[PATCH 0/5] MIPS: NT_PRFPREG regset handling fixes

2017-11-29 Thread Maciej W. Rozycki
Hi, This series corrects a number of issues with NT_PRFPREG regset, most importantly an FCSR access API regression introduced with the addition of MSA support, and then a few smaller issues with the get/set handlers. I have decided to factor out non-MSA and MSA context helpers as the first s

Re: [PATCH v2] arch: arm: mach-stm32: Fix copyright

2017-11-29 Thread Philippe Ombredanne
On Wed, Nov 29, 2017 at 3:55 PM, Benjamin Gaignard wrote: > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard > --- > arch/arm/mach-stm32/board-dt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-stm32/board-dt.c

Re: [PATCH v3 00/11] perf stat: Enable '--per-thread' on all thread

2017-11-29 Thread Jiri Olsa
On Wed, Nov 29, 2017 at 08:05:47PM +0800, Jin Yao wrote: > v3: > --- > Update according to Jiri's comments. The major modifications are: > > 1. Fix the crash issue when performing the git bisect. >Move the removing of runtime_saved_values to the switching point >(perf util: Remove a set of

[PATCH] [RESEND] drivers:mtd:spi-nor:checkup FSR error bits

2017-11-29 Thread Bean Huo (beanhuo)
For the Micron SPI NOR, when the erase/program operation fails, especially, for the failure results from intending to modify protected space, spi-nor upper layers still get the return which shows the operation succeeds. This because spi_nor_fsr_ready() only uses bit.7 to device whether ready. For t

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-29 Thread Thomas Gleixner
On Wed, 29 Nov 2017, Gustavo A. R. Silva wrote: > Quoting Thomas Gleixner : > > > > > So I have to ask WHY this information was not in the changelog of the patch > > in question: > > > > 1) How it works > > > > 2) Why comments have been chosen over macros > > > > I will add this info and

Re: [PATCH] perf annotate: Fix objdump comment parsing for Intel mov dissassembly

2017-11-29 Thread Thomas-Mich Richter
On 11/29/2017 02:24 PM, Ravi Bangoria wrote: > > > On 11/28/2017 01:26 PM, Thomas Richter wrote: >> The command 'perf annotate' parses the output of objdump and also >> investigates the comments produced by objdump. For example the >> output of objdump produces (on x86): >> >> 23eee: 4c 8b 3d 13

[PATCH 1/2] drm/bridge/sii8620: remove HSIC initialization

2017-11-29 Thread Maciej Purski
HSIC initialization was taken from the vendor code. HSIC in MHL circuit is not connected, so it is not possible to test it. Tests prove that without HSIC the device works well. Therefore it can be removed. Signed-off-by: Maciej Purski --- drivers/gpu/drm/bridge/sil-sii8620.c | 38 ---

[PATCH 2/2] drm/bridge/sii8620: fix HDMI cable connection to dongle

2017-11-29 Thread Maciej Purski
MHL bridge is usually connected to TV via MHL dongle. Currently plugging HDMI cable to dongle is handled improperly. This patch fixes it. Signed-off-by: Maciej Purski --- drivers/gpu/drm/bridge/sil-sii8620.c | 49 1 file changed, 27 insertions(+), 22 deletion

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-29 Thread Gustavo A. R. Silva
Quoting Thomas Gleixner : So I have to ask WHY this information was not in the changelog of the patch in question: 1) How it works 2) Why comments have been chosen over macros I will add this info and send the patch again. In preparation to enabling -Wimplicit-fallthrough, mark sw

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-29 Thread Govinda Tatti
Jan, Sorry for the late response. Please see below for my comments. On 11/9/2017 2:28 AM, Jan Beulich wrote: On 08.11.17 at 16:44, wrote: On 11/7/2017 8:40 AM, Jan Beulich wrote: On 06.11.17 at 18:48, wrote: --- a/Documentation/ABI/testing/sysfs-driver-pciback +++ b/Documentation/ABI/testi

Re: [PATCH] ethernet: dwmac-stm32: Fix copyright

2017-11-29 Thread David Miller
From: Benjamin Gaignard Date: Wed, 29 Nov 2017 15:20:00 +0100 > Uniformize STMicroelectronics copyrights header > > Signed-off-by: Benjamin Gaignard Applied.

Re: [PATCH] watchdog: stm32: Fix copyright

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:27 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard CC: Yannick Fertre --- drivers/watchdog/stm32_iwdg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/stm32_iwdg.c b/dr

Re: [PATCH v2] arch: arm: mach-stm32: Fix copyright

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:55 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Add SPDX identifier Signed-off-by: Benjamin Gaignard --- arch/arm/mach-stm32/board-dt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm3

Re: [PATCH] irqchip: stm32: Fix copyright

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:22 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard --- drivers/irqchip/irq-stm32-exti.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c ind

Re: [PATCH] rtc: stm32: Fix copyright

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:26 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard CC: Amelie Delaunay --- drivers/rtc/rtc-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/r

Re: [PATCH] pinctrl: stm32: Fix copyright

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:25 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard --- drivers/pinctrl/stm32/pinctrl-stm32.c | 1 + drivers/pinctrl/stm32/pinctrl-stm32.h | 1 + drivers/pinctrl/stm32/pinctrl-stm32f429.c | 1 + drivers

Re: [PATCH] i2c: stm32: Fix copyrights

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:21 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights headers Signed-off-by: Benjamin Gaignard --- drivers/i2c/busses/i2c-stm32.h | 1 + drivers/i2c/busses/i2c-stm32f4.c | 1 + drivers/i2c/busses/i2c-stm32f7.c | 1 + 3 files changed, 3 insertions(+)

Re: [PATCH] ethernet: dwmac-stm32: Fix copyright

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:20 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard CC: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/

Re: [PATCH] dma: stm32: Fix copyright

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:18 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard --- drivers/dma/stm32-dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c index 786fc8fcc38e..bb013ffe8a

Re: [PATCH] clk: stm32-h7: fix copyright

2017-11-29 Thread Alexandre Torgue
On 11/29/2017 03:15 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard CC: Gabriel Fernandez --- drivers/clk/clk-stm32h7.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-stm32h7.c b/drivers/

Re: [PATCH] PM: Provide a config snippet for disabling PM

2017-11-29 Thread Mark Brown
On Wed, Nov 29, 2017 at 03:37:01PM +0100, Rafael J. Wysocki wrote: > On Wed, Nov 29, 2017 at 12:12 PM, Mark Brown wrote: > > A frequent source of build problems is poor handling of optional PM > > support, almost all development is done with the PM options enabled > I'm going to apply this short

Re: [PATCH] firmware: Use PTR_ERR_OR_ZERO()

2017-11-29 Thread Gabriel L. Somlo
Acked-by: Gabriel Somlo On Tue, Nov 28, 2017 at 10:40:27PM +0100, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/

Re: [PATCH] net: via: via-rhine: use %p to format void * address instead of %x

2017-11-29 Thread David Miller
From: Colin King Date: Wed, 29 Nov 2017 14:11:49 + > From: Colin Ian King > > Don't use %x and casting to print out an address, instead use %p > and remove the casting. Cleans up smatch warnings: > > drivers/net/ethernet/via/via-rhine.c:998 rhine_init_one_common() > warn: argument 4 to %l

RE: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

2017-11-29 Thread David Laight
From: Andy Lutomirski > Sent: 29 November 2017 14:34 > > On Nov 29, 2017, at 4:47 AM, Peter Zijlstra wrote: > > > >> On Wed, Nov 29, 2017 at 08:09:51AM +0100, Ingo Molnar wrote: > >> diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S > >> index f81d50d7ceac..c0b52df8ee4f 100644 > >

[PATCH v2] arch: arm: mach-stm32: Fix copyright

2017-11-29 Thread Benjamin Gaignard
Uniformize STMicroelectronics copyrights header Add SPDX identifier Signed-off-by: Benjamin Gaignard --- arch/arm/mach-stm32/board-dt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm32/board-dt.c index e918686e4191..b01f40543e6e 100644 --

Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record()

2017-11-29 Thread Steven Rostedt
On Tue, 28 Nov 2017 20:17:46 +0200 Vladislav Valtchev wrote: > On Tue, 2017-11-28 at 11:48 -0500, Steven Rostedt wrote: > > > > Is there a reason that init_instance() isn't called in > > init_common_record_context()? > > > > Hi Steven, > > init_instance() has been put into init_common_recor

Re: [RFC PATCH v2 1/7] ASoC: Intel: Fix Kconfig with top-level selector

2017-11-29 Thread Pierre-Louis Bossart
On 11/29/17 4:27 AM, Vinod Koul wrote: On Tue, Nov 28, 2017 at 07:45:45PM -0600, Pierre-Louis Bossart wrote: I am not sure about top level being default to Y... It's standard procedure apparently, see Linus/Mark/Takashi's emails. config SND_SST_ATOM_HIFI2_PLATFORM tristate "Intel

<    4   5   6   7   8   9   10   11   12   13   >